From patchwork Thu Apr 6 14:49:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 671618 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E840C761A6 for ; Thu, 6 Apr 2023 14:50:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239510AbjDFOus (ORCPT ); Thu, 6 Apr 2023 10:50:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239492AbjDFOu1 (ORCPT ); Thu, 6 Apr 2023 10:50:27 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 338E2974C for ; Thu, 6 Apr 2023 07:49:27 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id a44so22296977ljr.10 for ; Thu, 06 Apr 2023 07:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680792565; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ft7kjU4G4EGx0zy/5R74WdAFRhnHqVLzykdVApX9NyA=; b=RskBn9ONNJF4qCqAS3MW+DCx+fLnQQcNx+N9R/0XPAClVia+FrpJrCIT9tfQoa9sMr 5cnvhZDF5YA+jshlEg7+QbwB35v0cWSibrhHtIuRKnWdqheX0OBtUjQ9YxqsdTwsw7o/ sG25S+jQCPGZVck6aLs0HjT5JLy0sahR6Ol3+OBisAcFqz4Q9LaDvfZT2NVETN6RrxW1 vRD0swxKf8/enTSi/wEMz8AhLKgQwabiqwF97e8CEcWXTlk3Dyt28IQOVE7jHL6Q04Pa CCFfT4LhfjCz38ThaKWzqv9EmAmFzLgT9UB3zwd744Mw/HuW5BhEIcyMQtFq6UetIvQa W5bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680792565; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ft7kjU4G4EGx0zy/5R74WdAFRhnHqVLzykdVApX9NyA=; b=0J/cRiwSOI27nho9ACkW9Sl0/4ywoC4IQ6ErHs3ciaaos3xorPNyas4BRC6WBvKtXA gybTokgp39dNjjt2579OO4FvIq4oFGjOzT5R+BBbBSbR5NIe3k5XI4yjAmQe7q78EQSv EfuiE44MFqzRwjRIAtZPcMGH7clu7mpnCNqC+mNtMZa60819nEVXo6U9bcNIghjHjNNP zA8KZ91K7TLgYKfuAkxO4TfGbHzXFUutPB9l0Ezt21+4qNfbhj2s77xhuNSSCWPr1SbT tLWrk67pXgAfdqV1MeqJa5XO5ypuPHNTbI8VF5YK/VvgEoyvzZcJDdG97oza4q2pua8b DdUQ== X-Gm-Message-State: AAQBX9cjMHWT0+D/Km52t86daoc6iCOtDm+v2sZ1JV3SPz2E2PqIGAUj Wo6eiuzukZDKDpwfrohVO9WnWw== X-Google-Smtp-Source: AKy350YRod0Z5QxGSbYmy/5L9qZpEYzwKFawSIvoJu8J7R32kMaf+ooeh0E6H+92wMLxVsYBGrOX+A== X-Received: by 2002:a2e:9d0c:0:b0:29b:4f87:c7cf with SMTP id t12-20020a2e9d0c000000b0029b4f87c7cfmr2613194lji.26.1680792565326; Thu, 06 Apr 2023 07:49:25 -0700 (PDT) Received: from [192.168.1.101] (abxh37.neoplus.adsl.tpnet.pl. [83.9.1.37]) by smtp.gmail.com with ESMTPSA id w24-20020a2e9598000000b002945b851ea5sm313864ljh.21.2023.04.06.07.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 07:49:25 -0700 (PDT) From: Konrad Dybcio Date: Thu, 06 Apr 2023 16:49:17 +0200 Subject: [PATCH v2 1/2] dt-bindings: soc: qcom: Add RPM Master stats MIME-Version: 1.0 Message-Id: <20230405-topic-master_stats-v2-1-51c304ecb610@linaro.org> References: <20230405-topic-master_stats-v2-0-51c304ecb610@linaro.org> In-Reply-To: <20230405-topic-master_stats-v2-0-51c304ecb610@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1680792561; l=2154; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=ElCnIUYxGJbzmv8fonT+78Z6yzpbG7zdv2M4WxEElMk=; b=24L55Di9UeNO/+RsP3P/EAnmdsa804gJ3zohqj+el3eHnfHY1sgKMx3oVpb1M7H8rw+QQEkpjKiW vxoFSrOzCaQ4BDgQ2V2CP3vzoXyhs/T9W0EL7H7SiXKpttnzrM3S X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The RPM MSG RAM contains per-RPM-master (e.g. APPS, ADSP etc.) sleep statistics. They let one assess which core is actively preventing the system from entering a true low-power mode. Signed-off-by: Konrad Dybcio --- .../bindings/soc/qcom/rpm-master-stats.yaml | 53 ++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/qcom/rpm-master-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/rpm-master-stats.yaml new file mode 100644 index 000000000000..d2d6a2a39fef --- /dev/null +++ b/Documentation/devicetree/bindings/soc/qcom/rpm-master-stats.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/qcom/rpm-master-stats.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Technologies, Inc. (QTI) RPM Master Stats + +maintainers: + - Konrad Dybcio + +description: + Per-RPM-Master (e.g. APSS, ADSP, etc.) sleep statistics. + +properties: + compatible: + const: qcom,rpm-master-stats + + qcom,rpm-msg-ram: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: Phandle to an RPM MSG RAM slice containing the master stats + minItems: 1 + maxItems: 5 + + qcom,master-names: + $ref: /schemas/types.yaml#/definitions/string-array + description: RPM Master name + minItems: 1 + maxItems: 5 + +required: + - compatible + - qcom,rpm-msg-ram + - qcom,master-names + +additionalProperties: false + +examples: + - | + stats { + compatible = "qcom,rpm-master-stats"; + qcom,rpm-msg-ram = <&apss_master_stats>, + <&mpss_master_stats>, + <&adsp_master_stats>, + <&cdsp_master_stats>, + <&tz_master_stats>; + qcom,master-names = "APSS", + "MPSS", + "ADSP", + "CDSP", + "TZ"; + }; +... From patchwork Thu Apr 6 14:49:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 670844 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A98C77B70 for ; Thu, 6 Apr 2023 14:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238150AbjDFOuv (ORCPT ); Thu, 6 Apr 2023 10:50:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238785AbjDFOua (ORCPT ); Thu, 6 Apr 2023 10:50:30 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC4F3BB92 for ; Thu, 6 Apr 2023 07:49:29 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id y7so8519241ljp.2 for ; Thu, 06 Apr 2023 07:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680792568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zqXmpgmRysqU36801gaf+bjZZHAu37+5IYEzwGtzlac=; b=Nxt2hrQbvRQYqsPhWj1JYYCoMq6nG+SF1yp1XQpTNwtMdoOrhVH/61zvKwoDd8AkEX pJmneTRObw4GB65DXZARwAkRp0vKTPghWavMSgIWEIGu2cd4UwyzSJBz05LVIDR8c66F qf+ZfC/faPkbOXAw19gItybH1e4JNjQfGNcezCKhcvYIB90W+W4MaHyUyJsuZyLH5JB+ IV9gGfl74MWvhOTwdVnfP3L0f+t39WXJRChfau4xDoj/FlTiAuOQbyn3jMvMhcBWBpth gSksPH9Xajx1TxYWHsJN3V/lzwM3QpiOyY7UFaMexj8gcbFB9IXFiB2WPwjOCy/OKdWZ XyzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680792568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zqXmpgmRysqU36801gaf+bjZZHAu37+5IYEzwGtzlac=; b=gp3jBVzLcHlwGFHcZyinkuYkmckbjRn9EvWhGJddZ5Z+U4ut0O43AiA8kNE2C643J7 dSzWGzwU0lQgXXtWp5yPj3RQASGJzlWEbq4DaUo6eLxAx9rK+BI906V+uKhvCi2ZqSBH Itq1WWedbZLk99CLpkJB+cbL3td/+IiLdHJ0V82iprn3RYqgjsqmI9cVJsZqGr0VNOdk ygp7+enrKkfGoGfPflgqV2RcKjrkZPOIsGAMNexb6CNq9SPsVqgXlulW7molIttT5DsB f3Eh2yamFb6RfbUryNc0bKkWxxDyNvICBk7R4mFwkm0ERFrf4I7vN8tbwHlvaoB3Tptv vTzQ== X-Gm-Message-State: AAQBX9eP12/NM0my/kHutWrgCKBikJCW6PjYV9ANQwJzenAFYSEDy0Qx jMSMp5/36KBrn1S9hIstYBwAlw== X-Google-Smtp-Source: AKy350a2J+6TtyPN6P7gNxBrfzrCFwIcLdAMXPEa2B2R5mIjvO/H1PBhNS4qCIFv+Ev4K2BQIGbbMQ== X-Received: by 2002:a2e:9c96:0:b0:2a2:ac00:4de4 with SMTP id x22-20020a2e9c96000000b002a2ac004de4mr1693816lji.22.1680792567971; Thu, 06 Apr 2023 07:49:27 -0700 (PDT) Received: from [192.168.1.101] (abxh37.neoplus.adsl.tpnet.pl. [83.9.1.37]) by smtp.gmail.com with ESMTPSA id w24-20020a2e9598000000b002945b851ea5sm313864ljh.21.2023.04.06.07.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 07:49:27 -0700 (PDT) From: Konrad Dybcio Date: Thu, 06 Apr 2023 16:49:18 +0200 Subject: [PATCH v2 2/2] soc: qcom: Introduce RPM master stats driver MIME-Version: 1.0 Message-Id: <20230405-topic-master_stats-v2-2-51c304ecb610@linaro.org> References: <20230405-topic-master_stats-v2-0-51c304ecb610@linaro.org> In-Reply-To: <20230405-topic-master_stats-v2-0-51c304ecb610@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1680792561; l=7204; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=3BKmryIPL+HG2OMWgSCrIoJr7gZHqFJMYzHPn6AQTu8=; b=qIz28CxvcrxluEJUptGTcNqT/SqlcJUEq8ivivcBtAqv6QQzNDOL+6LLCnVvI36VoVdqhyoWRG9J PXOq2utpB80+vMLkYZPT9ImlnyumSjbgZ1DXlRHbHVrOPdbtrM// X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Introduce a driver to query and expose detailed, per-subsystem (as opposed to the existing qcom_stats driver which exposes SoC-wide data) about low power mode states of a given RPM master. That includes the APSS (ARM), MPSS (modem) and other remote cores, depending on the platform configuration. This is a vastly cleaned up and restructured version of a similar driver found in msm-5.4. Signed-off-by: Konrad Dybcio --- drivers/soc/qcom/Kconfig | 11 +++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/rpm_master_stats.c | 160 ++++++++++++++++++++++++++++++++++++ 3 files changed, 172 insertions(+) diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index a25df9e3c70e..325b733c102c 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -135,6 +135,17 @@ config QCOM_RMTFS_MEM Say y here if you intend to boot the modem remoteproc. +config QCOM_RPM_MASTER_STATS + tristate "Qualcomm RPM Master stats" + depends on ARCH_QCOM || COMPILE_TEST + help + The RPM Master sleep stats driver provides detailed per-subsystem + sleep/wake data, read from the RPM message RAM. It can be used to + assess whether all the low-power modes available are entered as + expected or to check which part of the SoC prevents it from sleeping. + + Say y here if you intend to debug or monitor platform sleep. + config QCOM_RPMH tristate "Qualcomm RPM-Hardened (RPMH) Communication" depends on ARCH_QCOM || COMPILE_TEST diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile index 6e88da899f60..196bb87f2576 100644 --- a/drivers/soc/qcom/Makefile +++ b/drivers/soc/qcom/Makefile @@ -14,6 +14,7 @@ obj-$(CONFIG_QCOM_QMI_HELPERS) += qmi_helpers.o qmi_helpers-y += qmi_encdec.o qmi_interface.o obj-$(CONFIG_QCOM_RAMP_CTRL) += ramp_controller.o obj-$(CONFIG_QCOM_RMTFS_MEM) += rmtfs_mem.o +obj-$(CONFIG_QCOM_RPM_MASTER_STATS) += rpm_master_stats.o obj-$(CONFIG_QCOM_RPMH) += qcom_rpmh.o qcom_rpmh-y += rpmh-rsc.o qcom_rpmh-y += rpmh.o diff --git a/drivers/soc/qcom/rpm_master_stats.c b/drivers/soc/qcom/rpm_master_stats.c new file mode 100644 index 000000000000..73080c92bf89 --- /dev/null +++ b/drivers/soc/qcom/rpm_master_stats.c @@ -0,0 +1,160 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2012-2020, The Linux Foundation. All rights reserved. + * Copyright (c) 2023, Linaro Limited + * + * This driver supports what is known as "Master Stats v2", which seems to be + * the only version which has ever shipped, all the way from 2013 to 2023. + */ + +#include +#include +#include +#include +#include +#include + +struct master_stats_data { + void __iomem *base; + const char *label; +}; + +struct rpm_master_stats { + uint32_t active_cores; + uint32_t num_shutdowns; + uint64_t shutdown_req; + uint64_t wakeup_idx; + uint64_t bringup_req; + uint64_t bringup_ack; + uint32_t wakeup_reason; /* 0 = "rude wakeup", 1 = scheduled wakeup */ + uint32_t last_sleep_trans_dur; + uint32_t last_wake_trans_dur; + + /* Per-subsystem (*not necessarily* SoC-wide) XO shutdown stats */ + uint32_t xo_count; + uint64_t xo_last_enter; + uint64_t last_exit; + uint64_t xo_total_dur; +}; + +static int master_stats_show(struct seq_file *s, void *unused) +{ + struct master_stats_data *d = s->private; + struct rpm_master_stats stat; + + memcpy_fromio(&stat, d->base, sizeof(stat)); + + seq_printf(s, "%s:\n", d->label); + + seq_printf(s, "\tLast shutdown @ %llu\n", stat.shutdown_req); + seq_printf(s, "\tLast bringup req @ %llu\n", stat.bringup_req); + seq_printf(s, "\tLast bringup ack @ %llu\n", stat.bringup_ack); + seq_printf(s, "\tLast wakeup idx: %llu\n", stat.wakeup_idx); + seq_printf(s, "\tLast XO shutdown enter @ %llu\n", stat.xo_last_enter); + seq_printf(s, "\tLast XO shutdown exit @ %llu\n", stat.last_exit); + seq_printf(s, "\tXO total duration: %llu\n", stat.xo_total_dur); + seq_printf(s, "\tLast sleep transition duration: %u\n", stat.last_sleep_trans_dur); + seq_printf(s, "\tLast wake transition duration: %u\n", stat.last_wake_trans_dur); + seq_printf(s, "\tXO shutdown count: %u\n", stat.xo_count); + seq_printf(s, "\tWakeup reason: 0x%x\n", stat.wakeup_reason); + seq_printf(s, "\tShutdown count: %u\n", stat.num_shutdowns); + seq_printf(s, "\tActive cores bitmask: 0x%x\n", stat.active_cores); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(master_stats); + +static int master_stats_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct device_node *msgram_np; + struct master_stats_data *d; + struct dentry *dent, *root; + struct resource res; + int count, i, ret; + + count = of_property_count_strings(dev->of_node, "qcom,master-names"); + if (count < 0) + return count; + + d = devm_kzalloc(dev, count * sizeof(*d), GFP_KERNEL); + if (!d) + return -ENOMEM; + + root = debugfs_create_dir("rpm_master_stats", NULL); + platform_set_drvdata(pdev, root); + + for (i = 0; i < count; i++) { + msgram_np = of_parse_phandle(dev->of_node, "qcom,rpm-msg-ram", i); + if (!msgram_np) { + debugfs_remove_recursive(root); + return dev_err_probe(dev, -EINVAL, + "Couldn't parse MSG RAM phandle idx %d", i); + } + + /* + * Purposefully skip devm_platform helpers as we're using a + * shared resource. + */ + ret = of_address_to_resource(msgram_np, 0, &res); + if (ret < 0) { + debugfs_remove_recursive(root); + return ret; + } + + d[i].base = devm_ioremap(dev, res.start, resource_size(&res)); + if (IS_ERR(d[i].base)) { + debugfs_remove_recursive(root); + return dev_err_probe(dev, -EINVAL, + "Could not map the MSG RAM slice idx %d!\n", i); + } + + ret = of_property_read_string_index(dev->of_node, "qcom,master-names", i, + &d[i].label); + if (ret < 0) { + debugfs_remove_recursive(root); + return dev_err_probe(dev, ret, + "Could not read name idx %d!\n", i); + } + + /* + * Generally it's not advised to fail on debugfs errors, but this + * driver's only job is exposing data therein. + */ + dent = debugfs_create_file(d[i].label, 0444, root, + &d[i], &master_stats_fops); + if (!dent) { + debugfs_remove_recursive(root); + return -EINVAL; + } + } + + device_set_pm_not_required(dev); + + return 0; +} + +static void master_stats_remove(struct platform_device *pdev) +{ + struct dentry *root = platform_get_drvdata(pdev); + + debugfs_remove_recursive(root); +} + +static const struct of_device_id rpm_master_table[] = { + { .compatible = "qcom,rpm-master-stats" }, + { }, +}; + +static struct platform_driver master_stats_driver = { + .probe = master_stats_probe, + .remove_new = master_stats_remove, + .driver = { + .name = "rpm_master_stats", + .of_match_table = rpm_master_table, + }, +}; +module_platform_driver(master_stats_driver); + +MODULE_DESCRIPTION("RPM Master Statistics driver"); +MODULE_LICENSE("GPL");