From patchwork Thu Apr 13 19:40:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 674203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9AAC77B71 for ; Thu, 13 Apr 2023 19:41:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229622AbjDMTlS (ORCPT ); Thu, 13 Apr 2023 15:41:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbjDMTlQ (ORCPT ); Thu, 13 Apr 2023 15:41:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C80606A48 for ; Thu, 13 Apr 2023 12:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681414832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DAws+N1whAZqdp2+FmcZLsXGffvhZMy054TUXCEFTxA=; b=c21UMAk5iscdghwkUGvCeUq/zkukLdfPXRkNdveNT28MbI4g3t/k18WJuZTveJMWscQcZM 5ph85kwSD2dwnzDqQ+o06XYbqYzv/69A0uxrfc3t0ckczQIvJnP32UuC+uIlT5WNkGWmMG 9AVNxC/mtSJQOF+e5t+7ZxS7Fzopy+8= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-KjonrA-GPDqa8c0QmSFiwQ-1; Thu, 13 Apr 2023 15:40:30 -0400 X-MC-Unique: KjonrA-GPDqa8c0QmSFiwQ-1 Received: by mail-ot1-f71.google.com with SMTP id w8-20020a9d5388000000b006a43c04758eso366527otg.10 for ; Thu, 13 Apr 2023 12:40:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681414830; x=1684006830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DAws+N1whAZqdp2+FmcZLsXGffvhZMy054TUXCEFTxA=; b=KV8Im8szNrbv/M3/Pn9dQZIINs9XUN+m8151JMxnimYRxeEouQh3gHi8brDD8TiwTz 07bihiiI6b9nkdzPwsNLQWa2l3Eyw/+dhqhzh8nrH34ZzS/niwNQq453byaI1LXszBDW pMld2vkTFEXF2WQMCa4dztr2s27m34lM2Wm4TPvUbJqD+CRSaqdfExgzx7FYRrKw3tGB LqWQrSdDpvlra+M6jQ2IdUc669C46mf+1R9AJnXlaNzekXh6t/66g2ZUD0kJR7BFxRi4 CNyiEPYMPQWaWE/HETp8eXcnuGCAyVRs5QQCga6nXfGEPhZbXvp7zFWDfGfre1Xl8epH 3YSQ== X-Gm-Message-State: AAQBX9dOc4/2Y1s6tefiggvmomnz3aosGEKsY5U01HbBnYtqeWXNNtBT Zfr07A7cCpMyLVUM11X62+fW0SVshkqvvD5TKoXpmTwySRCt5sw97SYGlmSRFLVd2IdrMsSM68l BL28CtBPUUWLMwg+ajXL1eQ== X-Received: by 2002:a05:6808:49:b0:387:3324:29c6 with SMTP id v9-20020a056808004900b00387332429c6mr1720495oic.30.1681414830168; Thu, 13 Apr 2023 12:40:30 -0700 (PDT) X-Google-Smtp-Source: AKy350bFJPcabd2xer93D43uqwTOnEY7fzuGU+iChbHVBOp+gryFxy/XPCdtzRuuHoUgy+wpwDOzRg== X-Received: by 2002:a05:6808:49:b0:387:3324:29c6 with SMTP id v9-20020a056808004900b00387332429c6mr1720483oic.30.1681414829849; Thu, 13 Apr 2023 12:40:29 -0700 (PDT) Received: from halaney-x13s.redhat.com (104-53-165-62.lightspeed.stlsmo.sbcglobal.net. [104.53.165.62]) by smtp.gmail.com with ESMTPSA id x19-20020a056808145300b003898bec0e01sm966140oiv.17.2023.04.13.12.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 12:40:29 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v2 1/3] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Date: Thu, 13 Apr 2023 14:40:18 -0500 Message-Id: <20230413194020.1077857-1-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org As stated at the below link in another review, compatible is always the first property. Follow suit here to avoid copying incorrectly in the future. Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3 Signed-off-by: Andrew Halaney --- Changes since v1: * None arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 339fea522509..029b23198b3a 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -352,19 +352,18 @@ ðernet { max-speed = <1000>; mdio { + compatible = "snps,dwmac-mdio"; #address-cells = <0x1>; #size-cells = <0x0>; - compatible = "snps,dwmac-mdio"; - /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { + compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; interrupt-parent = <&tlmm>; interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ device_type = "ethernet-phy"; - compatible = "ethernet-phy-ieee802.3-c22"; }; }; }; From patchwork Thu Apr 13 19:40:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 672900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7DAC77B61 for ; Thu, 13 Apr 2023 19:41:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbjDMTlc (ORCPT ); Thu, 13 Apr 2023 15:41:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229685AbjDMTl1 (ORCPT ); Thu, 13 Apr 2023 15:41:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8D8F86A8 for ; Thu, 13 Apr 2023 12:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681414840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wHh16MFI12gMsfqbehl6umAoFEnRY63CfuAwT9OzHsk=; b=IWGX+pg2GPKQfjAyFZzPjyRCNWKNcHeKOsUNQltrc8ywUOHPEILpnQkuPODtrbkRr8uYh9 V1AT3s7PMmKJ1otdx06MQrfnPoG3vhQ8RNFXXSqypZlWSoJYJWF6XmDuSSMJAvzevT4Dss u4jXbVah7DXstWUmy9zHLazOHc/dY/Y= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-GQkoEWsEPNOUgS1Gf1tLaA-1; Thu, 13 Apr 2023 15:40:39 -0400 X-MC-Unique: GQkoEWsEPNOUgS1Gf1tLaA-1 Received: by mail-oi1-f199.google.com with SMTP id q206-20020acad9d7000000b00389899548dbso10970559oig.22 for ; Thu, 13 Apr 2023 12:40:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681414839; x=1684006839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wHh16MFI12gMsfqbehl6umAoFEnRY63CfuAwT9OzHsk=; b=TwoOLhbfsyUcTBlvMm5BLyHO9I02G9IP6j3W7nUbr8mB6FS9RvUAsn0uZeRERN52+W ZWgnU+Gh+LL9FavWGgu0/pJOJgz+9NkmuZ5K9DD9MmT/+GZqMTRrRotK8XlRYSlLCctk SawgsDKKSko/K5BQjRXb5EqozetzDn9m08MoDTCQmJH9EsRZJOgcvZG/lpKsuTcYzOQA ewvPapHWLOtM5vL/Is90sJHTSxFSOTZSGKMML6djbD1F4feb+L1EP88mnDZjmv1BfB0e wTCGSSnUVA/z1GiwEP/X0uwt1eUZ+9pkEpvXfIruXVB1UXcL8fZibiFT357RqwklasaZ wQvA== X-Gm-Message-State: AAQBX9epW1hBFjvFLrHgSfwhk+8Bol9F11ZJdKRs3rpRH2fpe5G1XuWh 8qIc26oij8Fu8t11DvIOP18kX/D0srXWgvxl+gBGdugh6Fqz2UT+rTRS9hfkb7uDWRxJ1IVW7OL W/wSMFDGzDHNUbdjfkMieJw== X-Received: by 2002:a05:6808:4046:b0:389:4ea4:7a59 with SMTP id cz6-20020a056808404600b003894ea47a59mr1472110oib.33.1681414838917; Thu, 13 Apr 2023 12:40:38 -0700 (PDT) X-Google-Smtp-Source: AKy350bWufTE+ePpSscH/Va3pVkErpxbVW3rmbXpnUl6PIFkY+rrCsQ+ppVWMagLa8KFfSBI9GvSpA== X-Received: by 2002:a05:6808:4046:b0:389:4ea4:7a59 with SMTP id cz6-20020a056808404600b003894ea47a59mr1472106oib.33.1681414838685; Thu, 13 Apr 2023 12:40:38 -0700 (PDT) Received: from halaney-x13s.redhat.com (104-53-165-62.lightspeed.stlsmo.sbcglobal.net. [104.53.165.62]) by smtp.gmail.com with ESMTPSA id x19-20020a056808145300b003898bec0e01sm966140oiv.17.2023.04.13.12.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 12:40:38 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v2 2/3] arm64: dts: qcom: sa8155p-adp: Make -cells decimal Date: Thu, 13 Apr 2023 14:40:19 -0500 Message-Id: <20230413194020.1077857-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230413194020.1077857-1-ahalaney@redhat.com> References: <20230413194020.1077857-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The property logically makes sense in decimal, and is the standard used elsewhere. Suggested-by: Konrad Dybcio Signed-off-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 029b23198b3a..ac52a8dfeba1 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -353,8 +353,8 @@ ðernet { mdio { compatible = "snps,dwmac-mdio"; - #address-cells = <0x1>; - #size-cells = <0x0>; + #address-cells = <1>; + #size-cells = <0>; /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { From patchwork Thu Apr 13 19:40:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 674202 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CCCEC77B6E for ; Thu, 13 Apr 2023 19:42:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbjDMTmU (ORCPT ); Thu, 13 Apr 2023 15:42:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjDMTmT (ORCPT ); Thu, 13 Apr 2023 15:42:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3389D9EEE for ; Thu, 13 Apr 2023 12:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681414889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pe0/oi4k+3plRUDjjra5Jf/XI2sf8St247Sf5O8j+8g=; b=K4a2WduOJ0U5HM/GwlKgiDV+pwL7xXdFRrO2kTpX2h/fDbfGIiQcXihfVFtO8nFyIyikw2 ZvDK8oeIQNsp7GUn+Xu/4eGdX7Gv1O7Td1BUW4N6zrpWRBZuy0BsWMkQoaCozAK9L+OV6c Ksq1c4VXOvnZpaHs7hj/pplJuA8+Etg= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-qqItgR9QM1ai520IfYwrvQ-1; Thu, 13 Apr 2023 15:41:27 -0400 X-MC-Unique: qqItgR9QM1ai520IfYwrvQ-1 Received: by mail-ot1-f72.google.com with SMTP id x5-20020a9d6285000000b006a12c805a17so1761895otk.11 for ; Thu, 13 Apr 2023 12:41:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681414886; x=1684006886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pe0/oi4k+3plRUDjjra5Jf/XI2sf8St247Sf5O8j+8g=; b=PWbeW7oT5ogXpj10VJUe7BjmdzOrnNtAqIH6b53eSNRX2qgS/9stN3kmzIxcZnMIl8 5dxWq4R82kXGJItICmvREaO0lCXIyXa3feuWgydRVhZhtKRM+dHXPle4JOmDJHSBb5F6 KZgbR4DmZ645EhJ55TVYcfEY/+WURxTo9nDctBxixFTzRTMx3yx3Y9puO6qgugvBCHTP UqDw3E6xKWNJDfd/W81/3uA1YPRyYjDv7a5niB/wrQyiKgY384ota+S6hgcwT+r1l9ju YiR6rIuBi756/3BHIEcBsu7JEdKWw7p8iqzV8zYHuT8+GMiNTs4GhTpOaeaYVcnbs7Gb RCxg== X-Gm-Message-State: AAQBX9duY9OKDZIQ+uIGFlXlvCAGmZ3bc4StUVZSlBhJRK0Jnd3zUUAQ Lvy3ZM8VlQYEhBcwIqVdtie5xZtronieV0qj79dTGcHIPExNeSdvE/cs9f1X0gGo71wRFI+lZ3p cr5kPDd5hVaTNgBuD99TBmQ== X-Received: by 2002:a05:6808:9a2:b0:377:f784:3332 with SMTP id e2-20020a05680809a200b00377f7843332mr1567412oig.24.1681414886723; Thu, 13 Apr 2023 12:41:26 -0700 (PDT) X-Google-Smtp-Source: AKy350YlwdBnAy6xihkKJw9Nntu9FJ2LoTnC1J6rgKBnqrGWtgp/R0SrzSgYs1pLXe/uellQrAs7aw== X-Received: by 2002:a05:6808:9a2:b0:377:f784:3332 with SMTP id e2-20020a05680809a200b00377f7843332mr1567402oig.24.1681414886483; Thu, 13 Apr 2023 12:41:26 -0700 (PDT) Received: from halaney-x13s.redhat.com (104-53-165-62.lightspeed.stlsmo.sbcglobal.net. [104.53.165.62]) by smtp.gmail.com with ESMTPSA id x19-20020a056808145300b003898bec0e01sm966140oiv.17.2023.04.13.12.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 12:41:26 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v2 3/3] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information Date: Thu, 13 Apr 2023 14:40:21 -0500 Message-Id: <20230413194020.1077857-3-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230413194020.1077857-1-ahalaney@redhat.com> References: <20230413194020.1077857-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Using interrupts-extended already indicates what the interrupt-parent is, so drop the explicit interrupt-parent. The comment about this being the phy-intr is not helpful either, since this is the only interrupt in the phy node. Suggested-by: Konrad Dybcio Signed-off-by: Andrew Halaney --- Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index ac52a8dfeba1..b65e0203d783 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -361,8 +361,7 @@ rgmii_phy: phy@7 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; - interrupt-parent = <&tlmm>; - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; device_type = "ethernet-phy"; }; };