From patchwork Tue May 2 16:08:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678419 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595404wrs; Tue, 2 May 2023 09:10:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7s8VK/uv0iqEuNB48lMUNKLf3v3BLM1ekWt7u8kCucS3yIaSZWBqsPx7xA2N1KbbgcT53l X-Received: by 2002:a05:6214:4002:b0:5ef:d3b6:5ce8 with SMTP id kd2-20020a056214400200b005efd3b65ce8mr5060415qvb.42.1683043806947; Tue, 02 May 2023 09:10:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043806; cv=none; d=google.com; s=arc-20160816; b=rlnBS0wE2rNEeh5RVL1CDeBtaVAFl5TUNdafbwHGzbODPGoie7IPdgv5v1xv/jZ5/t wVwN8Qj6Q6Ra/AGgYgLcCYgVXZwL6cBz2SRxRNw4kns1C1dI8hyDkr0T2EqpxlrfplDU pe3LK3YwK+XQW5THMC3kTFzgl4ezZRJ6PshZP719rDPjtj1XB3ZtMT25Dl2X2g6aPpGV m9fl9kjgUFG6ZiVY9Ljmp2/kxrN5EIKJq0JTXKWHymDYVR6MZKNFYlNkhdDbGnDpIISR 1UIsfEJh6U+d+CqaLq0PNUsoV9MffrPoe/O4IpPJaB/sUFsxHSCxze9xhTVT7NGLqeV0 BA/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=yNUcAaiIsith4A3MmMU6YaHlVSgymDmwyA221woU1dE=; b=qPOMKd79DjQFnx3d65Afc9MHe2FQG/bGDPhf1HAAS3MbOZsF/4Yu8gwYXw5W+UahHc +A9eSrjEnbx8q7nJPjvoIN+z0cIJFcwwBXAUVAI6Xy8AOZl+QXsapdK84K826G9z6M87 D3oR187yA4osql0lKTelVBaCduWjIMZe1OeqsvCg09uxdg0lI1d4sK9+73CrNReYHf2Q SrnfHj9zaM6R8NGmnnkbZybtXb8SNraq3eyJmXhaAUnnZL3sBlb5dA7RlLEgc4HTEr3X bcNZeqO0KJVxG3CmTlJRHG+mr2CxfSewCPLQFSnL08rQsYNxss+SLIUY5xQkx3KtuyVx kVsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iDdmT96S; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f18-20020ac859d2000000b003e4690a0c00si17927147qtf.271.2023.05.02.09.10.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:10:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iDdmT96S; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYr-0002od-Gh; Tue, 02 May 2023 12:09:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYg-0002ln-A9 for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:59 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYd-0000aX-64 for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:53 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f195b164c4so25384705e9.1 for ; Tue, 02 May 2023 09:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043728; x=1685635728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yNUcAaiIsith4A3MmMU6YaHlVSgymDmwyA221woU1dE=; b=iDdmT96SWk3haDdxJlL0Ke1VnzrEoNl/eQtyRPXexjJ5r4cz/FXwRj7Cl3HbD5PSUk 50bDp8ADXN7EHMgEB6yVwP3xcrurE2aOoem8Fd6VDyAo9X298m9YLSG5Be2ceKa22shQ fkw38ITOcUxxgCHNnh0LVydUhk44/BqkXC1I/BmHSEHsToBCUqIOdVHiXWGHhyNkxDuy ZHsMq4v1z11PjmeOBo+OKyq3JF6CJMVGQXP+sRpL3Uoc9O/PQ0HfW9XwlBrT7oxt6Unt HWus2wZSxkLfdUdfOQMTrwx4w56C2v1TEh2NfMIyxGQqDiZNDyL+FUrdDE0rSbIBpQjm rkXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043728; x=1685635728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yNUcAaiIsith4A3MmMU6YaHlVSgymDmwyA221woU1dE=; b=e9gkYRiNlFChmfrlgeOn8MUJeSHeimX+Cp+Ob6RIFQnhU+UZOZeOzNSRYSKPikal2g 4KgW3u3bOY9w6EP/IVrlfvM3+vU4rDx3TZk1I/A+2/uKj4DDcZpth1gZauDFpkkDpI1G 1/i9zqH4lvNEbVa9Ph+J5m0DkG89G9twQ+OFnik2o058FkppgVqmHpybBF7NJThPTW/5 HRktCo0zGS/7lAwLQXApxo9JBXVrAb7zpliLzJJS8USMIXNdwmFVGFfd4F907qbSutb1 yIXcdCVuOwoLck5FRZPoP3M/HpxRQS//HYsJ6RPgASzYwYIENnJuVRKYGR0ZnlBc+Jji vKHQ== X-Gm-Message-State: AC+VfDx/27rYaSYzKF9PRnxLHUNkeec6gXHUDUUCa63UbtbS/81hvQNK NRTfgqnNtMdJdnvP+kPbBufg+zjXexOdb5h8EfFBww== X-Received: by 2002:a7b:c8cc:0:b0:3f1:98e1:c902 with SMTP id f12-20020a7bc8cc000000b003f198e1c902mr11865985wml.4.1683043728286; Tue, 02 May 2023 09:08:48 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 01/16] target/alpha: Use MO_ALIGN for system UNALIGN() Date: Tue, 2 May 2023 17:08:31 +0100 Message-Id: <20230502160846.1289975-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson --- target/alpha/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 9d25e21164..ffbac1c114 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -72,7 +72,7 @@ struct DisasContext { #ifdef CONFIG_USER_ONLY #define UNALIGN(C) (C)->unalign #else -#define UNALIGN(C) 0 +#define UNALIGN(C) MO_ALIGN #endif /* Target-specific return values from translate_one, indicating the From patchwork Tue May 2 16:08:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678414 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595174wrs; Tue, 2 May 2023 09:09:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ66sP0owAltEIjp/gONLM0246SmmQshyK9o8TNhK6tfwDt7LAm/syfKrNSUtdQ5SDWhWlNe X-Received: by 2002:ad4:5f0c:0:b0:5ea:9fc5:fca2 with SMTP id fo12-20020ad45f0c000000b005ea9fc5fca2mr5837150qvb.45.1683043782810; Tue, 02 May 2023 09:09:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043782; cv=none; d=google.com; s=arc-20160816; b=FD4EBMkUuN+SIlrXFoM04QPfVR4W1ix5v1iUgQssZ3AwyLqy7mY7YAj9ySy5aH2uSt PGBLs0cwo/rYHMZgJQA5mz1qWymwKqs8wFKATaqnQMrRuXWrrRx5kFMDVPKsDAum2rj/ Jnlz+7xdH5DS005JD2qNJdg7bXZhuiZHe30v2kOt3SQku/cA2X+Gn17U9BP+fmk6jDV1 7icTj8ILeEQN4j03/8HRsLxMg1gHnmiIutY4HduwGB/c4o74kt2MkCu5P2dS042CipY1 A+ADp6ZH9sg1lYFgrI2dTzBSOgeJ3SWExmKGwkGKmMKbpbR1RevCrtM7eGSNwM6UrHP6 vtSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ElGkLkSZPG5U6w3IO50r2nvTqh+XRQqzsanCGPviKUM=; b=S96IDUAQ8Ga/lvwJVsD9E9h9pTKoTU5Morue4BQIEks1gPAIl6aYMN93JfnqtEJs1m s1Zek1buVP3B13QYx+KyvRX6Bc04gCMWlc1+Ms9xpK1vB0mt2A6bepLgZp/CujYdcq+A RpnKbwK4K/yizR4wBHWkQfDZRpUUY460/7TNiXxa9eeIgtoVNXfxqgxH2+V7K36qCNBY DKhauKWexsb5eMGePawbmw+7cEAe5+iMPHuGfQVfio7T3ebHedL9ylrF8g0Ep6szBGqW mO7qhyJVbUaJRYDxLjCh4WpHrtL5VCtwJ8oBaFXvxFZPbFQzCGPthzMCCqbtH9REC7+y 6Ezg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jr2g7nGC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id bj13-20020a05620a190d00b0074fc523b35dsi10026159qkb.311.2023.05.02.09.09.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:09:42 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jr2g7nGC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYw-0002pM-Ik; Tue, 02 May 2023 12:09:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYf-0002lm-MN for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:59 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYc-0000b9-Sc for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:53 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-2f6401ce8f8so2489766f8f.3 for ; Tue, 02 May 2023 09:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043729; x=1685635729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ElGkLkSZPG5U6w3IO50r2nvTqh+XRQqzsanCGPviKUM=; b=jr2g7nGCKLSUqBjmWl2In101FECMXT4VwKxb+mXz7gobIPG0tqjipoHNngCj2KGsKS i9OEN856b0Sbbp3KlV7PcpFuze14EWeSWeSskjzYR/BJ8SD/09nNTBfHGo+PwSZBVpHi Nu+JnjHLAWNwOlBx9JYNQvj/g8+TA8TjwscctE+Kj6SCyyqmVC7N6BBtL8Yrej6kHkG3 hkUGon7PLL8sc2Km6I4KPUhNsHxraGbji6wgGeBa613Ss6VlrNsIk/2hWTeJsdlbYCYI osLNKfhfK/5XKVP8UBkGaScIV960Pw0Ed2GPNX0B3Y4Xyi5EKk6x8Z2c6bjJ5FuqpAlq UslQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043729; x=1685635729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ElGkLkSZPG5U6w3IO50r2nvTqh+XRQqzsanCGPviKUM=; b=ILxAhS44Mi8biUT+iPx7fCfMHNIDAl+Mm84JspWEmw1mvPqC0L30/c9gAFyBIZhpJ4 kNYeTeOTvhK9ilnZp2ZWaPknYmBQLBXGMTUmlfQStRtmQMLgAxaYXc3wwj9etCbusY0C tV4aE81d+vrXeS6LmG70Iu9n5qe8u0tLY4l3TV5TAVQWYIalb8FWjehEDLzrwfD6qsr6 b3ZXiOkzCvXujgHekd+J41J4GXksUm3JqCpOfnCFPCDKLqneceh/EjzLxTY7hzQFHivy zGAbryCgJzx8ra6DUepdfZEPNqJGas/6b3XfRWQrciqxg96OSz3JpUChu8Zk5lmATpRk Dqjw== X-Gm-Message-State: AC+VfDzSIdtK+O264XHTW1WRo1j+VdYPwJ0pLB1wOjGltz1e0In+ANyp vTwP/P9S5XIHOJ5QA4OGlJwX6LVTKQ1nwwnGx4L2TQ== X-Received: by 2002:adf:f892:0:b0:306:320f:7bd0 with SMTP id u18-20020adff892000000b00306320f7bd0mr3695310wrp.19.1683043728974; Tue, 02 May 2023 09:08:48 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 02/16] target/alpha: Use MO_ALIGN where required Date: Tue, 2 May 2023 17:08:32 +0100 Message-Id: <20230502160846.1289975-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Mark all memory operations that are not already marked with UNALIGN. Signed-off-by: Richard Henderson --- target/alpha/translate.c | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index ffbac1c114..be8adb2526 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -2399,21 +2399,21 @@ static DisasJumpType translate_one(DisasContext *ctx, uint32_t insn) switch ((insn >> 12) & 0xF) { case 0x0: /* Longword physical access (hw_ldl/p) */ - tcg_gen_qemu_ld_i64(va, addr, MMU_PHYS_IDX, MO_LESL); + tcg_gen_qemu_ld_i64(va, addr, MMU_PHYS_IDX, MO_LESL | MO_ALIGN); break; case 0x1: /* Quadword physical access (hw_ldq/p) */ - tcg_gen_qemu_ld_i64(va, addr, MMU_PHYS_IDX, MO_LEUQ); + tcg_gen_qemu_ld_i64(va, addr, MMU_PHYS_IDX, MO_LEUQ | MO_ALIGN); break; case 0x2: /* Longword physical access with lock (hw_ldl_l/p) */ - tcg_gen_qemu_ld_i64(va, addr, MMU_PHYS_IDX, MO_LESL); + tcg_gen_qemu_ld_i64(va, addr, MMU_PHYS_IDX, MO_LESL | MO_ALIGN); tcg_gen_mov_i64(cpu_lock_addr, addr); tcg_gen_mov_i64(cpu_lock_value, va); break; case 0x3: /* Quadword physical access with lock (hw_ldq_l/p) */ - tcg_gen_qemu_ld_i64(va, addr, MMU_PHYS_IDX, MO_LEUQ); + tcg_gen_qemu_ld_i64(va, addr, MMU_PHYS_IDX, MO_LEUQ | MO_ALIGN); tcg_gen_mov_i64(cpu_lock_addr, addr); tcg_gen_mov_i64(cpu_lock_value, va); break; @@ -2438,11 +2438,13 @@ static DisasJumpType translate_one(DisasContext *ctx, uint32_t insn) goto invalid_opc; case 0xA: /* Longword virtual access with protection check (hw_ldl/w) */ - tcg_gen_qemu_ld_i64(va, addr, MMU_KERNEL_IDX, MO_LESL); + tcg_gen_qemu_ld_i64(va, addr, MMU_KERNEL_IDX, + MO_LESL | MO_ALIGN); break; case 0xB: /* Quadword virtual access with protection check (hw_ldq/w) */ - tcg_gen_qemu_ld_i64(va, addr, MMU_KERNEL_IDX, MO_LEUQ); + tcg_gen_qemu_ld_i64(va, addr, MMU_KERNEL_IDX, + MO_LEUQ | MO_ALIGN); break; case 0xC: /* Longword virtual access with alt access mode (hw_ldl/a)*/ @@ -2453,12 +2455,14 @@ static DisasJumpType translate_one(DisasContext *ctx, uint32_t insn) case 0xE: /* Longword virtual access with alternate access mode and protection checks (hw_ldl/wa) */ - tcg_gen_qemu_ld_i64(va, addr, MMU_USER_IDX, MO_LESL); + tcg_gen_qemu_ld_i64(va, addr, MMU_USER_IDX, + MO_LESL | MO_ALIGN); break; case 0xF: /* Quadword virtual access with alternate access mode and protection checks (hw_ldq/wa) */ - tcg_gen_qemu_ld_i64(va, addr, MMU_USER_IDX, MO_LEUQ); + tcg_gen_qemu_ld_i64(va, addr, MMU_USER_IDX, + MO_LEUQ | MO_ALIGN); break; } break; @@ -2659,7 +2663,7 @@ static DisasJumpType translate_one(DisasContext *ctx, uint32_t insn) vb = load_gpr(ctx, rb); tmp = tcg_temp_new(); tcg_gen_addi_i64(tmp, vb, disp12); - tcg_gen_qemu_st_i64(va, tmp, MMU_PHYS_IDX, MO_LESL); + tcg_gen_qemu_st_i64(va, tmp, MMU_PHYS_IDX, MO_LESL | MO_ALIGN); break; case 0x1: /* Quadword physical access */ @@ -2667,17 +2671,17 @@ static DisasJumpType translate_one(DisasContext *ctx, uint32_t insn) vb = load_gpr(ctx, rb); tmp = tcg_temp_new(); tcg_gen_addi_i64(tmp, vb, disp12); - tcg_gen_qemu_st_i64(va, tmp, MMU_PHYS_IDX, MO_LEUQ); + tcg_gen_qemu_st_i64(va, tmp, MMU_PHYS_IDX, MO_LEUQ | MO_ALIGN); break; case 0x2: /* Longword physical access with lock */ ret = gen_store_conditional(ctx, ra, rb, disp12, - MMU_PHYS_IDX, MO_LESL); + MMU_PHYS_IDX, MO_LESL | MO_ALIGN); break; case 0x3: /* Quadword physical access with lock */ ret = gen_store_conditional(ctx, ra, rb, disp12, - MMU_PHYS_IDX, MO_LEUQ); + MMU_PHYS_IDX, MO_LEUQ | MO_ALIGN); break; case 0x4: /* Longword virtual access */ @@ -2771,11 +2775,11 @@ static DisasJumpType translate_one(DisasContext *ctx, uint32_t insn) break; case 0x2A: /* LDL_L */ - gen_load_int(ctx, ra, rb, disp16, MO_LESL, 0, 1); + gen_load_int(ctx, ra, rb, disp16, MO_LESL | MO_ALIGN, 0, 1); break; case 0x2B: /* LDQ_L */ - gen_load_int(ctx, ra, rb, disp16, MO_LEUQ, 0, 1); + gen_load_int(ctx, ra, rb, disp16, MO_LEUQ | MO_ALIGN, 0, 1); break; case 0x2C: /* STL */ @@ -2788,12 +2792,12 @@ static DisasJumpType translate_one(DisasContext *ctx, uint32_t insn) case 0x2E: /* STL_C */ ret = gen_store_conditional(ctx, ra, rb, disp16, - ctx->mem_idx, MO_LESL); + ctx->mem_idx, MO_LESL | MO_ALIGN); break; case 0x2F: /* STQ_C */ ret = gen_store_conditional(ctx, ra, rb, disp16, - ctx->mem_idx, MO_LEUQ); + ctx->mem_idx, MO_LEUQ | MO_ALIGN); break; case 0x30: /* BR */ From patchwork Tue May 2 16:08:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678429 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp596194wrs; Tue, 2 May 2023 09:11:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7FKk2JtCLg5xWD7NibSas/MS9pkemWG4pHHSGEujuHWIsweLTFzocBtm8ZqmmFKOB10vZ4 X-Received: by 2002:ac8:5846:0:b0:3ef:3511:f494 with SMTP id h6-20020ac85846000000b003ef3511f494mr29050597qth.16.1683043890810; Tue, 02 May 2023 09:11:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043890; cv=none; d=google.com; s=arc-20160816; b=D2HvUldNTmdAMur2B5ah+mRdbXFZNsmbYiyouKuOGCYhOlvbA6g7vOayi1SHMRKTv0 SiregVAJQ5wo2JjypdY0AMfJ/rPNai3DsyYjFYKzbtDkyUCsLMA9Y1KzS8D2BF7258dJ fRCRQtkvBfMggGMfhOvAxNRjwx6fqETnGX8tiAuojA2aEavl3k6tCNagHewOsPk05aMH ZK4SN8OiQYyZ20WFvna7kQ/a2OpMAFixbFH0Pa4nVT4YD3QlcL2D3kcg0CfOLJ/ikSNR 6kku7mO6cBG7DGcFtaKixh16Wso7vqmsSihgJyJruA6v+Hz9dvrkt6GRHN34DFoTrfz9 M2eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=swNKPZEVj6WtYC73JG1+6YoXeoe7hSurM9orzPiUbwo=; b=EazFKrs6diRN8kuHp8bAnLrc6fgiHclhzxcNqmnhpRFYsWHzEWYRYpBfK4xVfi436/ 7kXFpXwhl2I7JNZF+uI8bylXmZnEOB7H/Am9PrJR60fRyv20NgTmPFZjij1rF0wH22K6 83OUx+ueYMjuNqhQIin5Wm7bRw9tR7hZbMUEv3BBt1KER6G79U2thmZUj9jve+5fm5Ia 0MUfCvH0Yd1DJ4YGD1nYot7msgzS5SCipsvN+57WR/Onkl8Np42ewRm3JcaiW6NKM+rf r3YZLTgWHxLfF/kY1JgwIWwR2t7kuOQ8mI3cbnjxmhHHVv15tl/8kYo6oV9oP4oS0usW LfuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lU1/ibpn"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c127-20020a379a85000000b007485d6a6e3csi17539618qke.624.2023.05.02.09.11.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:11:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lU1/ibpn"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYt-0002pF-KL; Tue, 02 May 2023 12:09:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYg-0002lp-As for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:01 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYd-0000bE-JH for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:53 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f315712406so176606745e9.0 for ; Tue, 02 May 2023 09:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043729; x=1685635729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=swNKPZEVj6WtYC73JG1+6YoXeoe7hSurM9orzPiUbwo=; b=lU1/ibpnqpfJiYuMWerOE9tpSd8zNGHKudFU1bHPdm5Yq0ZAH5q+/kTAtZYLJKeW/A 3tN1cEI9x9n4Ee+KL0szoCml1syXB55ug40QovzmfZOn2hFCnVimZyNGxyF00nCcZtBl e9gG1/mSFYl6Sx9vP9emyWvdeOenGrjaM/nFhiOhHcerE+Zs19hymlDOkGFDLtM5AbI7 D6N84vncxkvgxfH6rnXrFMwDCEvTEMDk4m2lWk42HyvGjlYZ6VZHYxBBidXUCns+swHo L8wCjay3CPJK0VWfbnMiS1c+Uji0YivIuomjdxiVVzY1XRyvX3Gm5rJN42q236hdjTqc rqHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043729; x=1685635729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=swNKPZEVj6WtYC73JG1+6YoXeoe7hSurM9orzPiUbwo=; b=kxWKfqX7J808a4qtjdvBjsEi/VHmYuRVvmJ78YlXODC61SBAam4Jx4UkjrI/fUzpt9 NUSmSiG3IFurfWGSrcTsUSw7ApMow1kp0B0GCHLWZYF1ULr6cdKzORN/nl16wUbr/2sQ 5vGjAdJZ2+DY6ruLCQHemTVXFiZ+bEGCvYpGQgg4KmjvQfgZzyTa+qkWVmoejEgpYFB1 l0GDIMK4xLIYntG1MtePRn4bTe5/HloPlbxQtJhxi1U5DEAPuYTBBX99+X/JsOoPuAXJ Phoq5CfoCHQKPCkDye45zL0RE1NvxIs5ams+eGEJkDrcrmjMUnxu1jXeTHTaeb0UjTW3 goqA== X-Gm-Message-State: AC+VfDyVO24raCJj2Ksi7x+UejuxNM52aGhpxJGPYI2g9lDTD4UnrJsT bM9q0hKEOZ11NKW4pcHXNPcGTu631KD7v+e3jmPDCw== X-Received: by 2002:a1c:4b12:0:b0:3f1:70d5:1be8 with SMTP id y18-20020a1c4b12000000b003f170d51be8mr13425364wma.15.1683043729603; Tue, 02 May 2023 09:08:49 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:49 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 03/16] target/alpha: Remove TARGET_ALIGNED_ONLY Date: Tue, 2 May 2023 17:08:33 +0100 Message-Id: <20230502160846.1289975-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson --- configs/targets/alpha-linux-user.mak | 1 - configs/targets/alpha-softmmu.mak | 1 - 2 files changed, 2 deletions(-) diff --git a/configs/targets/alpha-linux-user.mak b/configs/targets/alpha-linux-user.mak index 7e62fd796a..f7d3fb4afa 100644 --- a/configs/targets/alpha-linux-user.mak +++ b/configs/targets/alpha-linux-user.mak @@ -1,4 +1,3 @@ TARGET_ARCH=alpha TARGET_SYSTBL_ABI=common TARGET_SYSTBL=syscall.tbl -TARGET_ALIGNED_ONLY=y diff --git a/configs/targets/alpha-softmmu.mak b/configs/targets/alpha-softmmu.mak index e4b874a19e..9dbe160740 100644 --- a/configs/targets/alpha-softmmu.mak +++ b/configs/targets/alpha-softmmu.mak @@ -1,3 +1,2 @@ TARGET_ARCH=alpha -TARGET_ALIGNED_ONLY=y TARGET_SUPPORTS_MTTCG=y From patchwork Tue May 2 16:08:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678417 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595201wrs; Tue, 2 May 2023 09:09:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ65u5UAH4osqDxwbf/NvXjOPtCrG8Uhp0EUrIsHLoWX6akPDjX7BnZi+1pcu2MmRE/NTPgy X-Received: by 2002:a05:6214:519b:b0:61b:7115:559e with SMTP id kl27-20020a056214519b00b0061b7115559emr548197qvb.1.1683043784558; Tue, 02 May 2023 09:09:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043784; cv=none; d=google.com; s=arc-20160816; b=WPuzsxPHM9HHGFC6LqxCXrQGD+oh9+niOCxYzUFrvMQ2KscLYgnasmVaENlvGqTsC1 h2+2dM8pxX/d5UPkDrEAUEbHsQrQ7p/tXD2BOnrw+tn6fT/p42dZ4KMQ0/UaMCmGUg9t NdZQj5fmiSe3jKg4tyNwUTpwEKHyomVJZP3MP4VgsTO4iAvWfaLEu6KfgVZMC7Dr0eI7 TxIXh+UI9vjQTUeI2eX+8swj7Rbee1TpDkqdmkqh9fSktp0pwirDhKihXUkEznW0NmXX gSJUcLygXOryexRtz0L7OxDoOq5lFcaq3pzlTTKRuQgOZofxko4zBzvWWxM8PgOdNI3C eheA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v0deTbEGbpLLBkwrVJC8/AKUmMSe9YNlMldt/k2nv5E=; b=AwY9MBhk4FTOV7BDqJPg/PYcphYBW4qIEy2WwN58bNAFbyWI3WttL26HxZ0ruf9nS5 yIteMeM5WekcT2RWwpkmoZlSjF80kchOGTfqJm7aZ8C3PCU+mWHeXTGLZIOGGdqEiBmI 9+WeaF09+Pa62spjREgAzc36KM8nt+pM1qmYz5ASgmr3cLRNV1NbbuAQcVxk+6xk4nQ5 FReSZyo6zD71zbB7PfzykHw/zRZgG2DpLBz/frIedQM83Fbfa/YoEOZ2xWPLi8C0ncaB 1lDg7t693fArmSvCJDcH5q5T/X8Oqll7qk8vD7vjUOyUpdSVpA1c57aiZBAmGfUvEkP5 bJfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="oPDDZ/tR"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ed14-20020ad44eae000000b005efa77575efsi17719271qvb.178.2023.05.02.09.09.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:09:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="oPDDZ/tR"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYv-0002pL-7X; Tue, 02 May 2023 12:09:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYg-0002lo-AT for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:01 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYd-0000bL-QH for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:53 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3f199696149so25395315e9.0 for ; Tue, 02 May 2023 09:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043730; x=1685635730; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v0deTbEGbpLLBkwrVJC8/AKUmMSe9YNlMldt/k2nv5E=; b=oPDDZ/tRKPvvWy1Ri3lD0bH0qo+8ZtUd4pI1J8T4eCjZLXJi/jjCrJ4SdV/C+mJSt2 Yz7YxgSroYMFwqOgQ+48oa0vMKbZfbBDj31TnVTxxQHd2x82LfCvRvpVFHkZgSQdnOi9 Xgd0dA5RCs+dAlk1JAZ89AyHzkShzLInIEpsJpP2hJTw8zyB6foFD2OG12juI/vUnGlT quY7v7WbcDDKiAQ8AI46F/YrP8RYGpxAVW7Nvp2WvTLvFCs1SF8JHoUUd6Gml02LRHCr zcEeZt+dd7gYxI0y9ynNuEfMuiNTeRcqG+qv08q1fuqOuxl5M7+Vs1Xa7rLJf12/RuMk m6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043730; x=1685635730; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v0deTbEGbpLLBkwrVJC8/AKUmMSe9YNlMldt/k2nv5E=; b=Vm5E14DZ/TQTbiDfv2iKqHG7IxmY4U9tRaUiv0vQWtpt9x3zLWkT0umdwTq7cdGwRl WvUibJTu7pNyp+qzhWouVN/T+gtjDsPpgogUV6oQyyKGPYN12lTEKgZqV89iD0qbFyoi 51nLaYWhkJQal3JuSO9uOMrBy5nQ/+nmHXC5q8LAutdyVGenqBiL3ANR9uPMiStQmhA3 4erAhwKQ14aUpKt2tC+SBEX2Pqare7gO9GJ5PQrly5KrXD1tZwG7AEs4W3+IvqfJWCxl ypuBLDC02+kHrM7wC8Vy6AKvXxjDEkKNFeQHhiLIbyZyqw9y8Jrfc0ZhkUkbwtN2AWIM 1/XA== X-Gm-Message-State: AC+VfDxYo3lCUWC+HNw4/1/ApXlEH1fs9Cj5GzQziTgscKqKUOZ6dFW6 CQZtAC8G8XiQdshHurqx1LgkBYgIx0qrPXlW0LkrUQ== X-Received: by 2002:a5d:570f:0:b0:2ee:e47e:9014 with SMTP id a15-20020a5d570f000000b002eee47e9014mr10562473wrv.1.1683043730338; Tue, 02 May 2023 09:08:50 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:50 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 04/16] target/hppa: Use MO_ALIGN for system UNALIGN() Date: Tue, 2 May 2023 17:08:34 +0100 Message-Id: <20230502160846.1289975-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 6a3154ebc6..59e4688bfa 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -271,7 +271,7 @@ typedef struct DisasContext { #ifdef CONFIG_USER_ONLY #define UNALIGN(C) (C)->unalign #else -#define UNALIGN(C) 0 +#define UNALIGN(C) MO_ALIGN #endif /* Note that ssm/rsm instructions number PSW_W and PSW_E differently. */ From patchwork Tue May 2 16:08:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678416 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595199wrs; Tue, 2 May 2023 09:09:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7/MTwLf/8YDJm85qxGk4oNWGknfeEgdn83z/QijVT4cnYa24MTKcCtATsR87vDA7KDi7Tp X-Received: by 2002:a05:6214:c89:b0:5ef:5049:f49a with SMTP id r9-20020a0562140c8900b005ef5049f49amr6609603qvr.32.1683043784543; Tue, 02 May 2023 09:09:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043784; cv=none; d=google.com; s=arc-20160816; b=W5+tHPd5w32MfGD1KZQWWv01Y1g8pv5ljOiVA6fTGKTHGMdp2IMYdtqBDZwrnv5VOF 8cxX3iLgRYsojxu8bu1mZfRNDpZfk72jhbZxP2MaMNoQu4n+i1YUKoZ63mX7cbDzgqIk xc2SW4W4CviMEpuzs+If6c3uIuPxfnpPXsR1GRCqGagoUJ58YU4g7KlZWb/UJNnkXBJ5 zpHvySvlksgKBIBoISIpyNYgpsLtaYvyDpHsa49ukleGQd35Wz3XU/8EF+TC02i9s5GS 0SJ29uqKFvKh7GwzB4CLTaWJrhnC6aHB00IcuWfOas4ZgK0Hq0zGqw475NyNGP1rBo0p sMQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Rrz9M9TbqlhgVjUVbycqe3VtoE3QrVAsV7Ge7VQZ3uw=; b=Td1Pl/bffsr52WQrzYt/3iJH6WdKFd0SEhtDrxUFaWA72S+gyBFQ0hj2HcDqwn0Nxo /H2M1tvNFoeuw7ph0zLzhMDstj6gNpWQ40yBD0civSIjIwJ0Ch3GXHa+MFdXkyn6G6cp tWoWTxC2S+3dv/WnHzxEql5Q/u+dSBZL9blfA8uDPedCptguXtNA1SuToGXHeHjDWB2/ Ptf/q/WOr0iupnJf4/OK8kq2ISczavPhbNr7qfVOtjVisEyVGSuexppRctlODtnhY3CH RGvgrEgBO2X/V0lkMJq25Z4dz+mSou3UeyfME2derEaC19WW5b7EGg3I+d+eM5h85xwH jdOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hrZfkvFd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 4-20020a0562140d6400b005ef85b53a54si18512194qvs.4.2023.05.02.09.09.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:09:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hrZfkvFd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsZ0-0002rA-3f; Tue, 02 May 2023 12:09:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYg-0002lt-Va for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:02 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYf-0000bQ-8n for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:54 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f19b9d5358so40228455e9.1 for ; Tue, 02 May 2023 09:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043731; x=1685635731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rrz9M9TbqlhgVjUVbycqe3VtoE3QrVAsV7Ge7VQZ3uw=; b=hrZfkvFdg6gm7Ztg58vy6gzrEx2+euFRT+2zezJbH+C5vmGIWYsOCMWnzja6DgPymq u7p8bAfWEiGZILff7tQF/F2JQb23ncCV9DAjXLMBLbLAGSB9ucufKig51J2Yhb5VKs+u KBK2xNOZjRbMFq743kWu4RtH2EFviIgffuvuaeWZXMcrkUzdS0oWE7zpZB8ACdOrN/5W 1jsJSbswXebOILZxiR+dQdR0oGc2goO71qHb1ZPAKYZpDhzbqyxc1vcigfKxuUu6UIYn Sd5eEDWBiL+kmjvR2rEo9/q7NpNVZUCtBeNLZ5yXQC5IDl+2mXA7VEUqEuxf6coHsBjy WWHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043731; x=1685635731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rrz9M9TbqlhgVjUVbycqe3VtoE3QrVAsV7Ge7VQZ3uw=; b=JwzOIGeSoUy1/TVeu1rUQuV7FbqDu7ZUoM7hiFoXoP51LqnK+fj11m8dlNCv+hnz1r G1t5850s+4aWC97GG8hcx/J4Mb0vvO2KFG2tkUsvQtHWiVrmQL6lkmIe71vJu5x92pjI B4eypn1ylp1ffn/AntChO8pv5OMiGR83dID3ZBS5CPO2+vrqBPmEeywk/qCZs+B72qXS mHh63ehYu3jAymf0S4j5KO0w5hhfGrtJCo4I2VFGEA3gLPStO9qb0Kd8284dktwEfhsj 3F4Xwymm/uDp48i4tJxHW11+qDVMCivLrg8oAZ87IHwagAcukrbvsiTd6m7lkZIuDDKl Alxg== X-Gm-Message-State: AC+VfDyMYcOXsuoae3lboqF8/wa5FctJw3lQ9AaLO/oFO3VDaBLq06sd SfGerc3Se9jKIXAiDMSk6lnfR3o+Kjw7JEOdYNZ8zQ== X-Received: by 2002:a05:600c:2051:b0:3f1:7581:eaaf with SMTP id p17-20020a05600c205100b003f17581eaafmr11819619wmg.4.1683043731046; Tue, 02 May 2023 09:08:51 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:50 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 05/16] target/hppa: Remove TARGET_ALIGNED_ONLY Date: Tue, 2 May 2023 17:08:35 +0100 Message-Id: <20230502160846.1289975-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson --- configs/targets/hppa-linux-user.mak | 1 - configs/targets/hppa-softmmu.mak | 1 - 2 files changed, 2 deletions(-) diff --git a/configs/targets/hppa-linux-user.mak b/configs/targets/hppa-linux-user.mak index db873a8796..361ea39d71 100644 --- a/configs/targets/hppa-linux-user.mak +++ b/configs/targets/hppa-linux-user.mak @@ -1,5 +1,4 @@ TARGET_ARCH=hppa TARGET_SYSTBL_ABI=common,32 TARGET_SYSTBL=syscall.tbl -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y diff --git a/configs/targets/hppa-softmmu.mak b/configs/targets/hppa-softmmu.mak index 44f07b0332..a41662aa99 100644 --- a/configs/targets/hppa-softmmu.mak +++ b/configs/targets/hppa-softmmu.mak @@ -1,4 +1,3 @@ TARGET_ARCH=hppa -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y TARGET_SUPPORTS_MTTCG=y From patchwork Tue May 2 16:08:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678423 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595804wrs; Tue, 2 May 2023 09:10:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ42NbY9UKkchpMbuOcyj1kQ2CDk97QcHLmQ+fx4+b71HoCZU9h4h+4AbBoxedcMJ6WJm8yu X-Received: by 2002:a05:622a:1494:b0:3f2:1b6a:689 with SMTP id t20-20020a05622a149400b003f21b6a0689mr12016224qtx.3.1683043848096; Tue, 02 May 2023 09:10:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043848; cv=none; d=google.com; s=arc-20160816; b=ZRKNGC3PeoC9bE+TkjAhmOGVeiFCqp+2j3iTJfTnfoTESuoBAYQ5m5aJ8+sqkiK3VE +uyeIGYnj/9dyGoIcWdBbAR/+0k9j9RT3WMWeXwQvGaorLgy67kk3leNKxL+4wyTpx/P x7CGX7eAO1Qhjw6T7ofGbbPYUNX6MM7dqek8Y2z9n8cfEJsyxiKRfs96Og1xrIS6s6rS gQzNHpNR7BgkcZsoRb+t5vZpjBL8QH6jvmmSbK5ZgMirRX+7YiQbB69nzuJLebiaWKd6 BiMuH7NXQPPTS6ZtHOy1aLrs5TXmJ7BeRRtoXSpDKbA0RdoQDK1GctFmraeDA1vDuZH5 KcPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ak9lI8a+Y3Ekw5fqxmz/fOYShDZB2hBrThel6H303CQ=; b=ROleo4XzN8QFpgwQapX2NmLno3yseaKhqjzZhbX4fViJlc3kX3wr4BQ+4kMmy9B7dj J88Iyi7e1zZ66V1AAJEUNCzCzVdVVWxMzdTNEhRKi+NUBfm4+8v5qSsQL2a35meFQsye zwSYfl66tDETkX83d7WH2s+rbthkcJMLqZ/kxLUf4kC6uX2VKxAKq4V1aHdCtCxN7QV/ fJR3S/2IeUpyb904RoulJeccRI3TGNJWJKHl50TDIa0BA4UV7+wd1IyxA51c4WrPnqNK 7F6lkEiv2ueW3rYPwSEYDr/cSIX8oTcFGonUTIPV3lOPf5g9cUc8VXjjGa/Pa5Z3ZlDM la3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kiM4bx9c; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o6-20020a05620a22c600b00746a2634149si16686154qki.642.2023.05.02.09.10.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:10:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kiM4bx9c; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYz-0002qr-CC; Tue, 02 May 2023 12:09:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYh-0002m1-AU for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:03 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYf-0000dx-9F for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:54 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f09b4a1527so41720195e9.0 for ; Tue, 02 May 2023 09:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043732; x=1685635732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ak9lI8a+Y3Ekw5fqxmz/fOYShDZB2hBrThel6H303CQ=; b=kiM4bx9c8BffCFeInQPs2TaEJgMP6upq6yhI4671vB84k2F29DiOze+5wXz77BjnF8 Jg2lhBag8ZP1Ift0W2MTr3uW29F9ux3ihP4ZqLKeYNxWIb7lF4RCY2NeYLPrvnpboxeT 4qQS67N+eIw0kVrdzJSsSoJT+iOm985FxV+Us8+5RQ98hHvAAZWnOpMbzLY0TDH0lxuq 0H0QNmkr09ScDG/HsSi87zrY74KgByoAlQHgNiwplu4RDQ1TpQ3Licz9XrCdLWsBmExy npgLhj4Jba+PTHhPcWQAup6dzdmzxNk0og1N9om3g8nGqSTEtwrdpWFuw2vWQ3rIRxJ0 aU5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043732; x=1685635732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ak9lI8a+Y3Ekw5fqxmz/fOYShDZB2hBrThel6H303CQ=; b=Unf4WFLNmTxYpINxuCQvomEVgpKuxwf4XiXcf0TnlL0ZX9UfeMtJBy/i+r9YeCKBaQ IH6Yq6SeIEqeUvMSM418fWan/pHN+nWMdJD8OYBsNV6IOXnh2WR+Re/exDjjs0unQJ8Q +ZKXe2IhPJ/anWIJJj41a53TFfOU/58Z0uNSJlSeUX6SjTbTU2T1uCD+PiGu5tRq5Jin /uOzsiGClZmkPDHrkOmlgigfN8ARgQ9yuBAhQSX6TuHx1NSaRI6uvDcHthXPz07gICFB +i6//9WcvObHi8lTxZJLee60vrnFixR10y/Wr+W6+ZzKjN9bewZGlZ8o4sW7Ti/mPyqd Ptmg== X-Gm-Message-State: AC+VfDwoSFUj2PxfYnlrpSXGMDmfdIdjC1dkZ/tL9qOx9CQ7DCkmz3AW p7htbkWi2C/vAyyMdqi+fYhjtcJAe2gY6Kv0OL+YDg== X-Received: by 2002:a7b:cd18:0:b0:3f1:6f57:6fd3 with SMTP id f24-20020a7bcd18000000b003f16f576fd3mr12270265wmj.17.1683043731764; Tue, 02 May 2023 09:08:51 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 06/16] target/mips: Add MO_ALIGN to gen_llwp, gen_scwp Date: Tue, 2 May 2023 17:08:36 +0100 Message-Id: <20230502160846.1289975-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org These are atomic operations, so mark as requiring alignment. Signed-off-by: Richard Henderson --- target/mips/tcg/nanomips_translate.c.inc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nanomips_translate.c.inc index 97b9572caa..e08343414c 100644 --- a/target/mips/tcg/nanomips_translate.c.inc +++ b/target/mips/tcg/nanomips_translate.c.inc @@ -998,7 +998,7 @@ static void gen_llwp(DisasContext *ctx, uint32_t base, int16_t offset, TCGv tmp2 = tcg_temp_new(); gen_base_offset_addr(ctx, taddr, base, offset); - tcg_gen_qemu_ld_i64(tval, taddr, ctx->mem_idx, MO_TEUQ); + tcg_gen_qemu_ld_i64(tval, taddr, ctx->mem_idx, MO_TEUQ | MO_ALIGN); if (cpu_is_bigendian(ctx)) { tcg_gen_extr_i64_tl(tmp2, tmp1, tval); } else { @@ -1039,7 +1039,8 @@ static void gen_scwp(DisasContext *ctx, uint32_t base, int16_t offset, tcg_gen_ld_i64(llval, cpu_env, offsetof(CPUMIPSState, llval_wp)); tcg_gen_atomic_cmpxchg_i64(val, taddr, llval, tval, - eva ? MIPS_HFLAG_UM : ctx->mem_idx, MO_64); + eva ? MIPS_HFLAG_UM : ctx->mem_idx, + MO_64 | MO_ALIGN); if (reg1 != 0) { tcg_gen_movi_tl(cpu_gpr[reg1], 1); } From patchwork Tue May 2 16:08:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678420 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595418wrs; Tue, 2 May 2023 09:10:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ49Ue7e3MB5fIVVi27U0NZ1lYL0uJ6NW++sb9wA6zP623NOoeiRI7jSSiTIYBEkiHgmh23L X-Received: by 2002:ad4:5be3:0:b0:5f1:683e:9bd6 with SMTP id k3-20020ad45be3000000b005f1683e9bd6mr6690740qvc.9.1683043807624; Tue, 02 May 2023 09:10:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043807; cv=none; d=google.com; s=arc-20160816; b=L2i4kc4/rJklcee0IqlBxMTkh8ZSvplMY5CfCs8HFN2uHCmRWQDhLHTGLUjSDfTzEh d/oT/SAksAndHU/TGCNPzetrVyGvNui4nfshKES19fpHVQYjK2wctNzebwxZIxpoVMsR tZLlKbyqBu/TTBWv1GcXyxxaHVnRsKxZT4LwtdZT2eXABjEPEKOwfIw+7zoY66/Snnfr 2b76iHWvdQ8r/ymyz2QfaEnGQcal5zYtDEJXsGVqLtd2CAfln4q/1A4cKX1Lfbi6ueGh EOKis9aqKwjj7FjEjTIIHEeIMmZsJbg4cWd+hAmJbp6754DTH9pcRTnEMbIL06A1OjNL gvQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cqP+kmlr3vGIQ8ytEhUxnQ61nNI/I+I3GQWyWpYA5O0=; b=LzT0vr3nl2h5qX1G8+Ss3rUWp9Sqatts3CftjhLgDiFW+9TZwcA0PZkLPg2ZGjiqe6 hgyX18+FQOBjIhKnPekUBt9x1vKTfcoJvw/v+Zeor+aDgaLgGMd8GKopwvQi1Rgh1Xrf ZUO0eMuV9X77aEZ1m/ChQ/zJz9zxyoAHirmN64d4l/Rg44HFcBF+qani5aGzUryIrUi7 4Zp4mB4Rqy8Q8FFCZdRDWT2kt4wPxk24p87PtCFultP2BkWj/M5yO8qE+0rek8T43ifM lh60pAilwtHrlQeaOOCfThwiYs8tHrttGmMBzz47ZZcUmM564tg8o6DXXhpHcppM7Paa fW/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pFF6UPF2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t5-20020a05621421a500b005a80fa94cf2si17340942qvc.469.2023.05.02.09.10.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:10:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pFF6UPF2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYy-0002pl-O0; Tue, 02 May 2023 12:09:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYi-0002m3-9T for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:03 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYg-0000h2-2j for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:55 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f1cfed93e2so40076265e9.3 for ; Tue, 02 May 2023 09:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043732; x=1685635732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cqP+kmlr3vGIQ8ytEhUxnQ61nNI/I+I3GQWyWpYA5O0=; b=pFF6UPF2RExQPjwrP+De74sNxYRPqFV+m0KjdSCHQ+SboEaQTg8udETdSFK8DTw0hp l7+Do6nEQ96ykz+N1IE6e3m0/bcqI8/ewyMt0g8oTfRsQt7PbK94SVFtg+AkaurKLC1Z Xezl7iu8a6b7vwVzJ1GCYhOoXSu8vM1QR7L/uAuBmUVeDmmjBFI3kTrb6RwsaKrpbNf7 YmMsBz1ClASjhQ5kzGE7lJFMl+7PnVY386qEjA2CcA5KYXTMKi8f1VDjQnJOJ3Di88AJ 8kCE0gPX4YJ1wSblnGFuGWmDNMcK1EFtQLO/dXJB1dCM3X9NmZuloFFaXkg4sUbTtECw 5BWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043732; x=1685635732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cqP+kmlr3vGIQ8ytEhUxnQ61nNI/I+I3GQWyWpYA5O0=; b=Zt+O0GPjR4Uarp9abB9H3+sBkNMEqqn6oj74fkObOGBcJp0rSp3wLrirmVTJGamDtf E1vAbnIF8P714bPwyo6k7DWTCiQ/x0BH7ztXL4JcwEABpkkjnvdky3X6uWhidjQkbvbX u9GXB9XgtNayImoOTctOlAqhRL+fG/Za1kf27OVMnZW1DTG9uVCBqpagA5XaBOCD/hgc 1CoKJ4gCk9IzTbUb0Uudv5nq4Dx7wBzpQQ29siYbnaM+qRfKxSXeo5/cZn3Msm9wkWUl J8AnRHhO6W5dVQOaVQtKuGuki380hA+A5WHfrlCVq5geJGRUj+PbzRFUE6Z9FBkwjn+w 4BhA== X-Gm-Message-State: AC+VfDwz0jEEfnefOfdQFuzZQmKlnMkPhmVK2tj3wDBmIVHiwRL+atgg lBzZDBpv0LBxm/uHrblfi2UwQpznI6UOmzc6A53haQ== X-Received: by 2002:a7b:c847:0:b0:3eb:37ce:4c3d with SMTP id c7-20020a7bc847000000b003eb37ce4c3dmr12607555wml.38.1683043732481; Tue, 02 May 2023 09:08:52 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 07/16] target/mips: Add missing default_tcg_memop_mask Date: Tue, 2 May 2023 17:08:37 +0100 Message-Id: <20230502160846.1289975-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Memory operations that are not already aligned, or otherwise marked up, require addition of ctx->default_tcg_memop_mask. Signed-off-by: Richard Henderson --- target/mips/tcg/mxu_translate.c | 3 ++- target/mips/tcg/micromips_translate.c.inc | 24 ++++++++++++++-------- target/mips/tcg/mips16e_translate.c.inc | 18 ++++++++++------ target/mips/tcg/nanomips_translate.c.inc | 25 +++++++++++------------ 4 files changed, 42 insertions(+), 28 deletions(-) diff --git a/target/mips/tcg/mxu_translate.c b/target/mips/tcg/mxu_translate.c index bdd20709c0..be038b5f07 100644 --- a/target/mips/tcg/mxu_translate.c +++ b/target/mips/tcg/mxu_translate.c @@ -831,7 +831,8 @@ static void gen_mxu_s32ldd_s32lddr(DisasContext *ctx) tcg_gen_ori_tl(t1, t1, 0xFFFFF000); } tcg_gen_add_tl(t1, t0, t1); - tcg_gen_qemu_ld_tl(t1, t1, ctx->mem_idx, MO_TESL ^ (sel * MO_BSWAP)); + tcg_gen_qemu_ld_tl(t1, t1, ctx->mem_idx, (MO_TESL ^ (sel * MO_BSWAP)) | + ctx->default_tcg_memop_mask); gen_store_mxu_gpr(t1, XRa); } diff --git a/target/mips/tcg/micromips_translate.c.inc b/target/mips/tcg/micromips_translate.c.inc index e8b193aeda..211d102cf6 100644 --- a/target/mips/tcg/micromips_translate.c.inc +++ b/target/mips/tcg/micromips_translate.c.inc @@ -977,20 +977,24 @@ static void gen_ldst_pair(DisasContext *ctx, uint32_t opc, int rd, gen_reserved_instruction(ctx); return; } - tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TESL); + tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TESL | + ctx->default_tcg_memop_mask); gen_store_gpr(t1, rd); tcg_gen_movi_tl(t1, 4); gen_op_addr_add(ctx, t0, t0, t1); - tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TESL); + tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TESL | + ctx->default_tcg_memop_mask); gen_store_gpr(t1, rd + 1); break; case SWP: gen_load_gpr(t1, rd); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL | + ctx->default_tcg_memop_mask); tcg_gen_movi_tl(t1, 4); gen_op_addr_add(ctx, t0, t0, t1); gen_load_gpr(t1, rd + 1); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL | + ctx->default_tcg_memop_mask); break; #ifdef TARGET_MIPS64 case LDP: @@ -998,20 +1002,24 @@ static void gen_ldst_pair(DisasContext *ctx, uint32_t opc, int rd, gen_reserved_instruction(ctx); return; } - tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TEUQ); + tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TEUQ | + ctx->default_tcg_memop_mask); gen_store_gpr(t1, rd); tcg_gen_movi_tl(t1, 8); gen_op_addr_add(ctx, t0, t0, t1); - tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TEUQ); + tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TEUQ | + ctx->default_tcg_memop_mask); gen_store_gpr(t1, rd + 1); break; case SDP: gen_load_gpr(t1, rd); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUQ); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUQ | + ctx->default_tcg_memop_mask); tcg_gen_movi_tl(t1, 8); gen_op_addr_add(ctx, t0, t0, t1); gen_load_gpr(t1, rd + 1); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUQ); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUQ | + ctx->default_tcg_memop_mask); break; #endif } diff --git a/target/mips/tcg/mips16e_translate.c.inc b/target/mips/tcg/mips16e_translate.c.inc index 602f5f0c02..5cffe0e412 100644 --- a/target/mips/tcg/mips16e_translate.c.inc +++ b/target/mips/tcg/mips16e_translate.c.inc @@ -172,22 +172,26 @@ static void gen_mips16_save(DisasContext *ctx, case 4: gen_base_offset_addr(ctx, t0, 29, 12); gen_load_gpr(t1, 7); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL | + ctx->default_tcg_memop_mask); /* Fall through */ case 3: gen_base_offset_addr(ctx, t0, 29, 8); gen_load_gpr(t1, 6); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL | + ctx->default_tcg_memop_mask); /* Fall through */ case 2: gen_base_offset_addr(ctx, t0, 29, 4); gen_load_gpr(t1, 5); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL | + ctx->default_tcg_memop_mask); /* Fall through */ case 1: gen_base_offset_addr(ctx, t0, 29, 0); gen_load_gpr(t1, 4); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL | + ctx->default_tcg_memop_mask); } gen_load_gpr(t0, 29); @@ -196,7 +200,8 @@ static void gen_mips16_save(DisasContext *ctx, tcg_gen_movi_tl(t2, -4); \ gen_op_addr_add(ctx, t0, t0, t2); \ gen_load_gpr(t1, reg); \ - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL); \ + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL | \ + ctx->default_tcg_memop_mask); \ } while (0) if (do_ra) { @@ -298,7 +303,8 @@ static void gen_mips16_restore(DisasContext *ctx, #define DECR_AND_LOAD(reg) do { \ tcg_gen_movi_tl(t2, -4); \ gen_op_addr_add(ctx, t0, t0, t2); \ - tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TESL); \ + tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TESL | \ + ctx->default_tcg_memop_mask); \ gen_store_gpr(t1, reg); \ } while (0) diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nanomips_translate.c.inc index e08343414c..b96dcd2ae9 100644 --- a/target/mips/tcg/nanomips_translate.c.inc +++ b/target/mips/tcg/nanomips_translate.c.inc @@ -2641,52 +2641,49 @@ static void gen_p_lsx(DisasContext *ctx, int rd, int rs, int rt) switch (extract32(ctx->opcode, 7, 4)) { case NM_LBX: - tcg_gen_qemu_ld_tl(t0, t0, ctx->mem_idx, - MO_SB); + tcg_gen_qemu_ld_tl(t0, t0, ctx->mem_idx, MO_SB); gen_store_gpr(t0, rd); break; case NM_LHX: /*case NM_LHXS:*/ tcg_gen_qemu_ld_tl(t0, t0, ctx->mem_idx, - MO_TESW); + MO_TESW | ctx->default_tcg_memop_mask); gen_store_gpr(t0, rd); break; case NM_LWX: /*case NM_LWXS:*/ tcg_gen_qemu_ld_tl(t0, t0, ctx->mem_idx, - MO_TESL); + MO_TESL | ctx->default_tcg_memop_mask); gen_store_gpr(t0, rd); break; case NM_LBUX: - tcg_gen_qemu_ld_tl(t0, t0, ctx->mem_idx, - MO_UB); + tcg_gen_qemu_ld_tl(t0, t0, ctx->mem_idx, MO_UB); gen_store_gpr(t0, rd); break; case NM_LHUX: /*case NM_LHUXS:*/ tcg_gen_qemu_ld_tl(t0, t0, ctx->mem_idx, - MO_TEUW); + MO_TEUW | ctx->default_tcg_memop_mask); gen_store_gpr(t0, rd); break; case NM_SBX: check_nms(ctx); gen_load_gpr(t1, rd); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, - MO_8); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_8); break; case NM_SHX: /*case NM_SHXS:*/ check_nms(ctx); gen_load_gpr(t1, rd); tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, - MO_TEUW); + MO_TEUW | ctx->default_tcg_memop_mask); break; case NM_SWX: /*case NM_SWXS:*/ check_nms(ctx); gen_load_gpr(t1, rd); tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, - MO_TEUL); + MO_TEUL | ctx->default_tcg_memop_mask); break; case NM_LWC1X: /*case NM_LWC1XS:*/ @@ -3739,7 +3736,8 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *env, DisasContext *ctx) addr_off); tcg_gen_movi_tl(t0, addr); - tcg_gen_qemu_ld_tl(cpu_gpr[rt], t0, ctx->mem_idx, MO_TESL); + tcg_gen_qemu_ld_tl(cpu_gpr[rt], t0, ctx->mem_idx, + MO_TESL | ctx->default_tcg_memop_mask); } break; case NM_SWPC48: @@ -3755,7 +3753,8 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *env, DisasContext *ctx) tcg_gen_movi_tl(t0, addr); gen_load_gpr(t1, rt); - tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, MO_TEUL); + tcg_gen_qemu_st_tl(t1, t0, ctx->mem_idx, + MO_TEUL | ctx->default_tcg_memop_mask); } break; default: From patchwork Tue May 2 16:08:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678430 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp596201wrs; Tue, 2 May 2023 09:11:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4nU2WhprlJPNMvL4SPORL/GtddXMFAuQ7j7z4+YysXMTdEG6izbLZxUZpy8Q1OLq17JQtZ X-Received: by 2002:a05:622a:1891:b0:3ef:499a:dd99 with SMTP id v17-20020a05622a189100b003ef499add99mr26649169qtc.66.1683043891514; Tue, 02 May 2023 09:11:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043891; cv=none; d=google.com; s=arc-20160816; b=O0oKFEcv6bhGpzur41ow1lzNDfl0469Vr/T1BTmTROBucY9HXqvcaHqooBb8Wi1dMF utm6d+xwJZ0XTbtvtxkhds63qoWq5LnQCKG4eonPVY927ousu80chETbfwdITtV2StWp v/98E2aHlozVF2ajeLSywxSWlkukl0Df8ZhjIYJyDDencSnGB0ZyifivleB95DLt2QjE dwElE4usHRilskiAdBiZs4vX5zZWhFGT/OKD8Pocu5Lcsleezw+QggKreEeFm/plrdI/ iD1+9zxoup82FNLQ9TZqb4eOg/+DIcaZbKEo4UA1pKqzOpC7xGt6TwZumpzmagWfBGBU M71g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+izzL5UeSD6JbwL0jozvlCRqZk7eiF+iQRw2O4DosRA=; b=n7ibEvWDYwJflLx8Qo+tHrf6fEAD3CEFTkme6EFO4hpDsIRWgaIJiObayePf7ZjNgh r7Nia+4BqYsqy/LMry8rK4+wh39XuJtP5O5ViPTPFLhz9q3wq+P+hBR6vR885HGYTu4w Kzd9kd3+DyvM5zNpOMpu9kzDdrgbmcFB20P0Sg/imFohnu/C+9Yjm4WDhlWkWLpmZ8wR gynfO+7hh0L/n2yOpPKOAej0FiV/7hjeqfzc/Rp8wbhWEvqJ6VobtuK42iHblcbS91wX BhNWF7tpKT7lHEbOK+9oGUNHhz7cPhGRVFnUC8NOtAHYfk2bAY/q29W0ee86pcayGhhf dQpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UNcSYt73; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s12-20020a37a90c000000b0074d7880dfa5si17060967qke.65.2023.05.02.09.11.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:11:31 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UNcSYt73; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYt-0002pI-OU; Tue, 02 May 2023 12:09:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYi-0002m2-9I for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:03 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYg-0000hO-HD for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:55 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-2f27a9c7970so3727265f8f.2 for ; Tue, 02 May 2023 09:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043733; x=1685635733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+izzL5UeSD6JbwL0jozvlCRqZk7eiF+iQRw2O4DosRA=; b=UNcSYt73qobgQt2odKyfqeUkozBgka/I3U6xeaFNaSvtBTimPVbDXDTT5xAesnT05v dIXYJs1tsiNdJUfuOy9TaYqmRoNM2971cLEdZ+3B1k0/ZZY07fAmDZGEXomeXWf8Uxq9 afmLBs+2+IIyh/gkICr+69UXbn3Aznh7kdJiJp0NlkwolqdV1+Rx0M9mn+cX0gZ1nJca C7aszYtN92V8I48IeN/mNPc5B4dDR6XVO89X4uH5El8uem2Z+ygxXF060cvVO9oRYjz4 /0Pd5y3GfnBiSei3x2Q+br2W4cYXxSwo+t6L8FXh+SMmWMgGRqT3ULm/qn0n+6RfVHxk iYQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043733; x=1685635733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+izzL5UeSD6JbwL0jozvlCRqZk7eiF+iQRw2O4DosRA=; b=EBIE6KzH0D2y45bl0cH1UWxvBEZ2Smass8zPFo2kWHhaBh/qk1n9ewewrf3hCujF0Z VPwvsxsb51n6pkgvDOVLMtmeKWkeBjaBJq9mxXLugOQa05/G21+4WNb5OQLYvRkZFNss nJwW3g0/Xke22iXoOzJefn+LoYhNWQ51x4Y2gfMFdOFjoXzVg0z4IAo4SGKuSzFmW6Ft hDZTZBKJn/ETL2RWTOkzW0G2NqthLOVMenb6ywi8m8eWXx6LLnZl+KprqTJ3xW2ejaIf eDd+4YzguhhrVQvOG1rCtxgGHykD0/TryoM6IfLYjdWp5uoUvbr1pQwl63uFFe6kfM5d dx/w== X-Gm-Message-State: AC+VfDxVVR0wn5tqzXO4B2fugrNlTmvti3544UfCRv2944ndbwuco/LK U0y3/fVkRwUbJAGOazBMLBCnDaVHKjIpyneMMuOfLQ== X-Received: by 2002:a05:6000:182:b0:2fa:55f3:4ea2 with SMTP id p2-20020a056000018200b002fa55f34ea2mr11663241wrx.5.1683043733064; Tue, 02 May 2023 09:08:53 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 08/16] target/mips: Use MO_ALIGN instead of 0 Date: Tue, 2 May 2023 17:08:38 +0100 Message-Id: <20230502160846.1289975-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The opposite of MO_UNALN is MO_ALIGN. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/mips/tcg/nanomips_translate.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nanomips_translate.c.inc index b96dcd2ae9..a98dde0d2e 100644 --- a/target/mips/tcg/nanomips_translate.c.inc +++ b/target/mips/tcg/nanomips_translate.c.inc @@ -4305,7 +4305,7 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *env, DisasContext *ctx) TCGv va = tcg_temp_new(); TCGv t1 = tcg_temp_new(); MemOp memop = (extract32(ctx->opcode, 8, 3)) == - NM_P_LS_UAWM ? MO_UNALN : 0; + NM_P_LS_UAWM ? MO_UNALN : MO_ALIGN; count = (count == 0) ? 8 : count; while (counter != count) { From patchwork Tue May 2 16:08:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678425 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595966wrs; Tue, 2 May 2023 09:11:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6cbRtEO6Ug8tAxGAvP/9YxjIysyxI39KG7keAqd8nAUqwpJlDv9R7JJrOxCtr/lHTglfk4 X-Received: by 2002:ac8:5907:0:b0:3e6:4535:d24c with SMTP id 7-20020ac85907000000b003e64535d24cmr27838512qty.61.1683043862604; Tue, 02 May 2023 09:11:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043862; cv=none; d=google.com; s=arc-20160816; b=nueHXIUQIAsivvcMzEyDE8IEQSXKuKygJ7yNYQSwH8CRyhf3EGj28w2qpIX1QIrRf0 U6NVydIDpgzSkXhImPXHeYzL7ARORvQSN6YZnR7YOHX2jWPFaEpmXoMaqq7NkPz97qoL eoFVzltbAFdu93nLvI1hDIYcIL7hAUOQiIFIAtFjNY046tRr937BieIp+NAKJF3rnF7p oXfwMQbgPYbZbjqeq/Q+0rmCBqHhhrQgJmT8NslERmGr+rWZ8utQXQ/xWXX+CjrfuhKU EyjJ4LYeYVQ+dTqTEgTLRD8lm7kocO0lhyOMgtzZw4an9VnauOJlb+liYhf+Jh83p4y8 mr5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=azGpR/vI4E4lJ27AqLH4AuBHdfSf/EVVZa9vn6F5YtM=; b=bB41XS2Bq8+gLxWV4ejeqVs78mLbF8ZAY5GBy/+NJUqqXHWqKl3wQEQkeYlWFcDppe kE4qu2Uz4qbJ7+z2NWnIWLvFphUopb0uOh8HT7LVKOPGrGkGfAeKNU7zqeiofYnM2Ghc teZL+LBmbW4KD6Kwah8oK6SwCEOm3wbEqXgOZqaJzoDEO/wd6n1pAHe585KlepwXH1uo lpDrFms2EKo15JMkAs6QRcPcEcuyi3+WotWAlCMmuTi8YjkVB2/3jDg8mEDgnnNIV9FM E2j3GrPlIOXGnCpLUa1ZGWfW9EVSarVitpQzM5y3xGnmzCYeHvv/3cktwKZQCTSfTCPI 56LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tIerp0+3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j10-20020a05622a038a00b003f2207cedd2si1754943qtx.461.2023.05.02.09.11.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:11:02 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tIerp0+3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYy-0002pk-Mc; Tue, 02 May 2023 12:09:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYi-0002m4-Tb for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:03 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYh-0000ha-5u for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:56 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3f1cfed93e2so40076485e9.3 for ; Tue, 02 May 2023 09:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043733; x=1685635733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=azGpR/vI4E4lJ27AqLH4AuBHdfSf/EVVZa9vn6F5YtM=; b=tIerp0+3CNOt8TO9USS3yMfdFVcoZPOxzzf9XLkqnrL6Yp9EInCPPRsLP3FVqWiKMZ 6iM4iilM6RNV8OXRqb8sV57VLHi3OiJVMin3VYCEIqPXsQbosNcHvLdx3QUsqSHAjUyg ZmWKHh82t7QZ6XnO2m0ZgcPGrypx6xXaDLBTq4ut+tKGoIWkQI+lrjon0z/U77oJPBNa nKRjR6906VBslczgBjncroiNEV9hgTkryD+126zjbxcfqjnqT4tAPITzlQdQ3mG8xnM9 jh9UKVM84syr4Ss5fEdA/avmq7VKWxVa50rWKY2e4e3bO/D82VTChTr0DhJ47Y5Nyb5B wMLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043733; x=1685635733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azGpR/vI4E4lJ27AqLH4AuBHdfSf/EVVZa9vn6F5YtM=; b=cwOFpJW9C4z9IFTgHEgQwxZ/tB+A0kezXo2a01VCl58GYz+lJZSRJT/rPTjJvRGAeP yUNxZ1eI/YKFGjtBpgkZyAXInIg9QJSNEQUQKKITZsBLpcyUxylzOBOle+WqUUPAF/jx Koo/83BOeX/hNVWS7xvASL+5IHTDQeWXfM06eRHi4PI67MSsFQOAlPPQC3vI82XxyBHS DFp5+yKyiNcHifOVh24Iy97mZcqLEm8bbXZBmWs1ErEhJvLPREZ9rCXyWXoiwamwG2nk p1A0yajIF8x3rRvmE3ndjDy1XCBnPJjG/E/qqUUG8sPL1NYx0+LVF7nYAswh62P5amqB 7xlA== X-Gm-Message-State: AC+VfDz20zy1Z2O70hAxWmJwxuL0sJ6Dn2cnId3okQVWw0ySsMek2DJI eV2OpSJicr1Q396jezcE6JaSVYEMrh+Hz7hTwWOb6w== X-Received: by 2002:a05:600c:228f:b0:3ed:2a41:8525 with SMTP id 15-20020a05600c228f00b003ed2a418525mr12941967wmf.22.1683043733734; Tue, 02 May 2023 09:08:53 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 09/16] target/mips: Remove TARGET_ALIGNED_ONLY Date: Tue, 2 May 2023 17:08:39 +0100 Message-Id: <20230502160846.1289975-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson --- configs/targets/mips-linux-user.mak | 1 - configs/targets/mips-softmmu.mak | 1 - configs/targets/mips64-linux-user.mak | 1 - configs/targets/mips64-softmmu.mak | 1 - configs/targets/mips64el-linux-user.mak | 1 - configs/targets/mips64el-softmmu.mak | 1 - configs/targets/mipsel-linux-user.mak | 1 - configs/targets/mipsel-softmmu.mak | 1 - configs/targets/mipsn32-linux-user.mak | 1 - configs/targets/mipsn32el-linux-user.mak | 1 - 10 files changed, 10 deletions(-) diff --git a/configs/targets/mips-linux-user.mak b/configs/targets/mips-linux-user.mak index 71fa77d464..b4569a9893 100644 --- a/configs/targets/mips-linux-user.mak +++ b/configs/targets/mips-linux-user.mak @@ -2,5 +2,4 @@ TARGET_ARCH=mips TARGET_ABI_MIPSO32=y TARGET_SYSTBL_ABI=o32 TARGET_SYSTBL=syscall_o32.tbl -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y diff --git a/configs/targets/mips-softmmu.mak b/configs/targets/mips-softmmu.mak index 7787a4d94c..d34b4083fc 100644 --- a/configs/targets/mips-softmmu.mak +++ b/configs/targets/mips-softmmu.mak @@ -1,4 +1,3 @@ TARGET_ARCH=mips -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y TARGET_SUPPORTS_MTTCG=y diff --git a/configs/targets/mips64-linux-user.mak b/configs/targets/mips64-linux-user.mak index 5a4771f22d..d2ff509a11 100644 --- a/configs/targets/mips64-linux-user.mak +++ b/configs/targets/mips64-linux-user.mak @@ -3,5 +3,4 @@ TARGET_ABI_MIPSN64=y TARGET_BASE_ARCH=mips TARGET_SYSTBL_ABI=n64 TARGET_SYSTBL=syscall_n64.tbl -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y diff --git a/configs/targets/mips64-softmmu.mak b/configs/targets/mips64-softmmu.mak index 568d66650c..12d9483bf0 100644 --- a/configs/targets/mips64-softmmu.mak +++ b/configs/targets/mips64-softmmu.mak @@ -1,4 +1,3 @@ TARGET_ARCH=mips64 TARGET_BASE_ARCH=mips -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y diff --git a/configs/targets/mips64el-linux-user.mak b/configs/targets/mips64el-linux-user.mak index f348f35997..f9efeec8ea 100644 --- a/configs/targets/mips64el-linux-user.mak +++ b/configs/targets/mips64el-linux-user.mak @@ -3,4 +3,3 @@ TARGET_ABI_MIPSN64=y TARGET_BASE_ARCH=mips TARGET_SYSTBL_ABI=n64 TARGET_SYSTBL=syscall_n64.tbl -TARGET_ALIGNED_ONLY=y diff --git a/configs/targets/mips64el-softmmu.mak b/configs/targets/mips64el-softmmu.mak index 5a52aa4b64..8d9ab3ddc4 100644 --- a/configs/targets/mips64el-softmmu.mak +++ b/configs/targets/mips64el-softmmu.mak @@ -1,4 +1,3 @@ TARGET_ARCH=mips64 TARGET_BASE_ARCH=mips -TARGET_ALIGNED_ONLY=y TARGET_NEED_FDT=y diff --git a/configs/targets/mipsel-linux-user.mak b/configs/targets/mipsel-linux-user.mak index e23793070c..e8d7241d31 100644 --- a/configs/targets/mipsel-linux-user.mak +++ b/configs/targets/mipsel-linux-user.mak @@ -2,4 +2,3 @@ TARGET_ARCH=mips TARGET_ABI_MIPSO32=y TARGET_SYSTBL_ABI=o32 TARGET_SYSTBL=syscall_o32.tbl -TARGET_ALIGNED_ONLY=y diff --git a/configs/targets/mipsel-softmmu.mak b/configs/targets/mipsel-softmmu.mak index c7c41f4fb7..0829659fc2 100644 --- a/configs/targets/mipsel-softmmu.mak +++ b/configs/targets/mipsel-softmmu.mak @@ -1,3 +1,2 @@ TARGET_ARCH=mips -TARGET_ALIGNED_ONLY=y TARGET_SUPPORTS_MTTCG=y diff --git a/configs/targets/mipsn32-linux-user.mak b/configs/targets/mipsn32-linux-user.mak index 1e80b302fc..206095da64 100644 --- a/configs/targets/mipsn32-linux-user.mak +++ b/configs/targets/mipsn32-linux-user.mak @@ -4,5 +4,4 @@ TARGET_ABI32=y TARGET_BASE_ARCH=mips TARGET_SYSTBL_ABI=n32 TARGET_SYSTBL=syscall_n32.tbl -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y diff --git a/configs/targets/mipsn32el-linux-user.mak b/configs/targets/mipsn32el-linux-user.mak index f31a9c394b..ca2a3ed753 100644 --- a/configs/targets/mipsn32el-linux-user.mak +++ b/configs/targets/mipsn32el-linux-user.mak @@ -4,4 +4,3 @@ TARGET_ABI32=y TARGET_BASE_ARCH=mips TARGET_SYSTBL_ABI=n32 TARGET_SYSTBL=syscall_n32.tbl -TARGET_ALIGNED_ONLY=y From patchwork Tue May 2 16:08:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678421 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595422wrs; Tue, 2 May 2023 09:10:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ63bnD0LFH16+RVE9m/DDYa2+PuqPYJaz/Kz/E94Tilaz0r9KvWJClcIQHr214CjiPP0aJ6 X-Received: by 2002:a05:6214:b67:b0:5f1:6892:7440 with SMTP id ey7-20020a0562140b6700b005f168927440mr6694590qvb.23.1683043807906; Tue, 02 May 2023 09:10:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043807; cv=none; d=google.com; s=arc-20160816; b=WaiDnoztBDamsenKMznJzvAXuNRhHTTn8RRZEwnK0+LVkXWyA5PTC+RVQv6httVJn2 x3ijg38iGdqwFij+ZbjaFI+v0NauHx6hH9tr76c9OcgoS5fN511qHKLvcSbQUxzCHUBr 5uOSmPSzXvyYkx2Pd/1SJSGV1LVXRoK8pDQRK8Ah0rbm4JZ/2cvrNovAaVo0iCr9b8+U 5lKGYvFV/HW7i890D2xqowl02R/qNwWRsLoJTYL7F0wfLQylJZK1n12601cjAGGbVace 5AFkQJLKEWetYuyUvComVFoG+5LhGCP/G2/qKNPHI6NHh+PUnVGaHueVeiGkaw51q9eb SSbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mQVUDi+CRoMJva8bEs9dFGVpgdctxMJkq0XbdWl/CUI=; b=uA75DiMWJdpO6Zr3bYQO7XZ/8ZxS9+D0kJkj3wBjQvKhvASeX2avgMmWnmSvfdSKtl 4avpMxtHdIliImz5aQTkx9xx+dTw7QjBNsZ9FgVZVWsaaUfYnDsVReQV5GaUdXJ6IasS gCTh1sCExs8KCOZKsqYgQLWbrYmQLS36T5kiL6j9O1DR0kNjTR5XDsEFyUDANyBrSrCj kZ8k0nwmU4ktKyaEC0RyptzBNs0YSga3Up8ir5eDdhC+G2jVp5hMmV41Zk4kSY/TRKjM 3NJygMUuCNCo60Jx4S4fM77VuySnBKjXZIt86uTIT7QH2vVDNsO7/6vg7+vLmamYy5nO fv3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Wr1dAyA4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s5-20020a0562140ca500b00619ff0c9255si2728971qvs.475.2023.05.02.09.10.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:10:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Wr1dAyA4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYu-0002pJ-AZ; Tue, 02 May 2023 12:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYn-0002mJ-Ps for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:03 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYi-0000hx-1b for qemu-devel@nongnu.org; Tue, 02 May 2023 12:08:57 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3063afa2372so563865f8f.0 for ; Tue, 02 May 2023 09:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043734; x=1685635734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mQVUDi+CRoMJva8bEs9dFGVpgdctxMJkq0XbdWl/CUI=; b=Wr1dAyA4sF7zOtrSFgw9dni8vfD3k/2XJAzS233hheofcgvas/9t3YP7KGj+FMygTt d2qRJ8dJ9pCeQ23gxkTWPoZ43iDNf5hKjZpG16RvmyLRpFWV7v+gJQQsqIuKlkWBKCUU NtMLYkjreoX6Rd5BbmZQwtxgn2Wi9ojpDvN4/P215XjwDir2jx6ZLkUF65AzjQaW3sN9 NZr+kwqp/LapoNWrglxKk1Ipr/di+gci1KvY8W6yfeoIeDn0oyDJEzlk9OzvWLQriDNY QWYugxcte88QYx2GFhXEUMZkOJBTIqfgrc4PNcILTmlyfIYLQUiYKasuRUsUBdXPYjMj L+FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043734; x=1685635734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQVUDi+CRoMJva8bEs9dFGVpgdctxMJkq0XbdWl/CUI=; b=N9vpCYgnn0Fi1QWiKHPaa2CjgKYDfOBPcNU1+loAHFrpfEJwe6ukDzXNnBCR14p1Mq rQ4Bjw4CTh4mPyr3/VbwKkMI1gsclW/ryqtBwm2ejvZByI1jIA2sXUFO3BAy4VaAfus6 1aT+2BER2fKeOQmeBgJ8PdFq7vPTuqeov4x7twpZ2WZlSc2MRzsOe0L6bTYZFb8LLFON BNennoX4paZqNPD+Gyfi/RNgRLmNSgITAen4FzaCub1g7VTR7Lj9jP0MXugKubUfYUvf CyORJYvh59wMxoLu/ziKa9qwXMsbfGhMHD3FuCLcB1BKvWGg0PSRSprbsHcd3UJKAdfO ENOw== X-Gm-Message-State: AC+VfDxLllNP6AyyN0+9g/QjYfMn2T5XDn5xa8KSvny/U+YohPT0ZVsZ yaS2WsZ5gSr7/nRffJ8LO0jpRtw2qTwUuv14EaMdWQ== X-Received: by 2002:a5d:4e41:0:b0:306:2db9:a33a with SMTP id r1-20020a5d4e41000000b003062db9a33amr4766736wrt.33.1683043734464; Tue, 02 May 2023 09:08:54 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 10/16] target/nios2: Remove TARGET_ALIGNED_ONLY Date: Tue, 2 May 2023 17:08:40 +0100 Message-Id: <20230502160846.1289975-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org In gen_ldx/gen_stx, the only two locations for memory operations, mark the operation as either aligned (softmmu) or unaligned (user-only, as if emulated by the kernel). Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- configs/targets/nios2-softmmu.mak | 1 - target/nios2/translate.c | 10 ++++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/configs/targets/nios2-softmmu.mak b/configs/targets/nios2-softmmu.mak index 5823fc02c8..c99ae3777e 100644 --- a/configs/targets/nios2-softmmu.mak +++ b/configs/targets/nios2-softmmu.mak @@ -1,3 +1,2 @@ TARGET_ARCH=nios2 -TARGET_ALIGNED_ONLY=y TARGET_NEED_FDT=y diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 6610e22236..a548e16ed5 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -298,6 +298,11 @@ static void gen_ldx(DisasContext *dc, uint32_t code, uint32_t flags) TCGv data = dest_gpr(dc, instr.b); tcg_gen_addi_tl(addr, load_gpr(dc, instr.a), instr.imm16.s); +#ifdef CONFIG_USER_ONLY + flags |= MO_UNALN; +#else + flags |= MO_ALIGN; +#endif tcg_gen_qemu_ld_tl(data, addr, dc->mem_idx, flags); } @@ -309,6 +314,11 @@ static void gen_stx(DisasContext *dc, uint32_t code, uint32_t flags) TCGv addr = tcg_temp_new(); tcg_gen_addi_tl(addr, load_gpr(dc, instr.a), instr.imm16.s); +#ifdef CONFIG_USER_ONLY + flags |= MO_UNALN; +#else + flags |= MO_ALIGN; +#endif tcg_gen_qemu_st_tl(val, addr, dc->mem_idx, flags); } From patchwork Tue May 2 16:08:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678418 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595329wrs; Tue, 2 May 2023 09:09:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6FIKkVCl2s2RtO0T7sMbX0P/7kicVb/93Cje5xU6qCFZiK8GeizWx6vo61yDcEe3dD/ERA X-Received: by 2002:ac8:5e0b:0:b0:3f1:fa37:c82e with SMTP id h11-20020ac85e0b000000b003f1fa37c82emr25005919qtx.57.1683043799037; Tue, 02 May 2023 09:09:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043799; cv=none; d=google.com; s=arc-20160816; b=sI0vckioCIGRRUy3fnM4NJjn9esWx6cOlCN9LfXZpdISj77X8vSB4NZ75MHGbiC6qz uLYIGciAjfBI/pT2/DwVu6gCRo5r3J1vzaRzwPOkBTWQOe27CpDbzSQ+/nUobh5aS7X1 ww4LRYKm+9pT6GVnHQ5fKdczvmqOgwCld2YHvMMSch0Dm0aS6/Sm2ve9Xz6tVfrWDDKB VUClE6OujyW7hH+9aPuH+uuDhdzpJMnRDqipdOGB9lw8wISYH+wv2EU13KYbtDAdZPRh AHKIl1iHfS3Adxmw3ao6nw+nI/LLpO9R695uDuf9bvEDxyE60PZM3xTxucl8E3SfR/hh WuqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mPzCthQhAAzGRz8yw5OKm2S/UV6MMNarT36deOz1baU=; b=1HK2gs4dPMrwh4j4QYiLB2P9yUbL5mdh4FRUOOfcGxkf/+qccGu8xHFunf3w0RAZJg U2ovdhgnO2zolOvUFIcrePnqVNEGNCFValLCcS4wkKujWamq+8ttUhGk44M34TzBM2Nj 9kSVeNlzspUKF1pvMNMeTb8AkBJFz5WliP6NEvb1yW4PNyFGP+hYDyUSE7O0eGqJLlMv onggp25vC3yrlBuaHVDjS8soirpRNqyk1gybvJIBJSKc/cwJW4g7lY7GroG6sBAQJ3xZ 2SVt7pmLMfqk6tP7tKvOUJlKkvGGWe9SfG49mHECkbjEuKYHKNT9FC2PCiP0C4QswCeW 07+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W5Nk1XN6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t22-20020a05620a451600b0074a40e6f23dsi18779457qkp.474.2023.05.02.09.09.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:09:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W5Nk1XN6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsZ1-0002sF-CV; Tue, 02 May 2023 12:09:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYp-0002n6-MZ for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:03 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYi-0000iT-MA for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:03 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f192c23fffso24841355e9.3 for ; Tue, 02 May 2023 09:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043735; x=1685635735; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mPzCthQhAAzGRz8yw5OKm2S/UV6MMNarT36deOz1baU=; b=W5Nk1XN63Lb5QkQZ0EoRZAie2/D79dZ2QR+P9nLne8fL8ol9s5xUN+RUo1M7ztJQg6 jBiYhml057UY9mivZhfiJTPE5QL66eOGOyWxcaijNe/mEDf7iVY/25bcJauEjg5FTtQ4 V3SjGSjkK3qwTt1IpYtf5HyRzlHt/MpSX07ZsjtcnJD3te3ay+eEijeytcxE9CcMH3vZ 0RYokXUuMWXGcnFxtkgB58EMDI/b2I2Gp59vS9jA/Fq26TUFba4/ldDRgItel1WdRgUu 4CaJ8f5ourm+2pk4o+7RRYaeSQRKDmJiTTDhTxebZWCwX41GwgRMosXYZohZjN9GIAE0 siDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043735; x=1685635735; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mPzCthQhAAzGRz8yw5OKm2S/UV6MMNarT36deOz1baU=; b=GGsqq/0h9NntTmZC2iGRNYLSHheq+0ZGz1iIGh3kUVBV2mQjolVN3Lr8XEOvwSnl2H khmU5/0fu5fZsG3hzhq+kG9fdoOt/sMSMx1K2dthX+kHmSwp4ldgK+WrrTkMdlq0qqNq S41R6qpRLpG0DuE7imNfO7eDjugiAlsu5jm4Gysp1UVEWUpb/PozWHFKLd4aLkhdXpw8 dPDWyIE8jpxmR8r/zL9uC7iMUgBFT0pZLcEVb5ye/PlImUb0K2vPIOYeQlO79rZLYRCm mywrc+av9OxaxcpeqSID5Af1z+ZQps2ohbBb2UR49zWGjTXTOnlf7V0xjWxBbYqFTLpV atSA== X-Gm-Message-State: AC+VfDw8J6Q5JwCPkO98PVS10JydcEjwk2n4W445UHMXvjjoobIe4qra cwKihSUcYiPQ9a77awof4xUCf/nPi4D2ALckLEVbtQ== X-Received: by 2002:a7b:c7d0:0:b0:3f1:cfea:fd49 with SMTP id z16-20020a7bc7d0000000b003f1cfeafd49mr12894517wmk.1.1683043735145; Tue, 02 May 2023 09:08:55 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 11/16] target/sh4: Use MO_ALIGN where required Date: Tue, 2 May 2023 17:08:41 +0100 Message-Id: <20230502160846.1289975-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Mark all memory operations that are not already marked with UNALIGN. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/sh4/translate.c | 102 ++++++++++++++++++++++++++--------------- 1 file changed, 66 insertions(+), 36 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 6e40d5dd6a..0dedbb8210 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -527,13 +527,15 @@ static void _decode_opc(DisasContext * ctx) case 0x9000: /* mov.w @(disp,PC),Rn */ { TCGv addr = tcg_constant_i32(ctx->base.pc_next + 4 + B7_0 * 2); - tcg_gen_qemu_ld_i32(REG(B11_8), addr, ctx->memidx, MO_TESW); + tcg_gen_qemu_ld_i32(REG(B11_8), addr, ctx->memidx, + MO_TESW | MO_ALIGN); } return; case 0xd000: /* mov.l @(disp,PC),Rn */ { TCGv addr = tcg_constant_i32((ctx->base.pc_next + 4 + B7_0 * 4) & ~3); - tcg_gen_qemu_ld_i32(REG(B11_8), addr, ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(REG(B11_8), addr, ctx->memidx, + MO_TESL | MO_ALIGN); } return; case 0x7000: /* add #imm,Rn */ @@ -801,9 +803,11 @@ static void _decode_opc(DisasContext * ctx) { TCGv arg0, arg1; arg0 = tcg_temp_new(); - tcg_gen_qemu_ld_i32(arg0, REG(B7_4), ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(arg0, REG(B7_4), ctx->memidx, + MO_TESL | MO_ALIGN); arg1 = tcg_temp_new(); - tcg_gen_qemu_ld_i32(arg1, REG(B11_8), ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(arg1, REG(B11_8), ctx->memidx, + MO_TESL | MO_ALIGN); gen_helper_macl(cpu_env, arg0, arg1); tcg_gen_addi_i32(REG(B7_4), REG(B7_4), 4); tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4); @@ -813,9 +817,11 @@ static void _decode_opc(DisasContext * ctx) { TCGv arg0, arg1; arg0 = tcg_temp_new(); - tcg_gen_qemu_ld_i32(arg0, REG(B7_4), ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(arg0, REG(B7_4), ctx->memidx, + MO_TESL | MO_ALIGN); arg1 = tcg_temp_new(); - tcg_gen_qemu_ld_i32(arg1, REG(B11_8), ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(arg1, REG(B11_8), ctx->memidx, + MO_TESL | MO_ALIGN); gen_helper_macw(cpu_env, arg0, arg1); tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 2); tcg_gen_addi_i32(REG(B7_4), REG(B7_4), 2); @@ -961,30 +967,36 @@ static void _decode_opc(DisasContext * ctx) if (ctx->tbflags & FPSCR_SZ) { TCGv_i64 fp = tcg_temp_new_i64(); gen_load_fpr64(ctx, fp, XHACK(B7_4)); - tcg_gen_qemu_st_i64(fp, REG(B11_8), ctx->memidx, MO_TEUQ); + tcg_gen_qemu_st_i64(fp, REG(B11_8), ctx->memidx, + MO_TEUQ | MO_ALIGN); } else { - tcg_gen_qemu_st_i32(FREG(B7_4), REG(B11_8), ctx->memidx, MO_TEUL); + tcg_gen_qemu_st_i32(FREG(B7_4), REG(B11_8), ctx->memidx, + MO_TEUL | MO_ALIGN); } return; case 0xf008: /* fmov @Rm,{F,D,X}Rn - FPSCR: Nothing */ CHECK_FPU_ENABLED if (ctx->tbflags & FPSCR_SZ) { TCGv_i64 fp = tcg_temp_new_i64(); - tcg_gen_qemu_ld_i64(fp, REG(B7_4), ctx->memidx, MO_TEUQ); + tcg_gen_qemu_ld_i64(fp, REG(B7_4), ctx->memidx, + MO_TEUQ | MO_ALIGN); gen_store_fpr64(ctx, fp, XHACK(B11_8)); } else { - tcg_gen_qemu_ld_i32(FREG(B11_8), REG(B7_4), ctx->memidx, MO_TEUL); + tcg_gen_qemu_ld_i32(FREG(B11_8), REG(B7_4), ctx->memidx, + MO_TEUL | MO_ALIGN); } return; case 0xf009: /* fmov @Rm+,{F,D,X}Rn - FPSCR: Nothing */ CHECK_FPU_ENABLED if (ctx->tbflags & FPSCR_SZ) { TCGv_i64 fp = tcg_temp_new_i64(); - tcg_gen_qemu_ld_i64(fp, REG(B7_4), ctx->memidx, MO_TEUQ); + tcg_gen_qemu_ld_i64(fp, REG(B7_4), ctx->memidx, + MO_TEUQ | MO_ALIGN); gen_store_fpr64(ctx, fp, XHACK(B11_8)); tcg_gen_addi_i32(REG(B7_4), REG(B7_4), 8); } else { - tcg_gen_qemu_ld_i32(FREG(B11_8), REG(B7_4), ctx->memidx, MO_TEUL); + tcg_gen_qemu_ld_i32(FREG(B11_8), REG(B7_4), ctx->memidx, + MO_TEUL | MO_ALIGN); tcg_gen_addi_i32(REG(B7_4), REG(B7_4), 4); } return; @@ -996,10 +1008,12 @@ static void _decode_opc(DisasContext * ctx) TCGv_i64 fp = tcg_temp_new_i64(); gen_load_fpr64(ctx, fp, XHACK(B7_4)); tcg_gen_subi_i32(addr, REG(B11_8), 8); - tcg_gen_qemu_st_i64(fp, addr, ctx->memidx, MO_TEUQ); + tcg_gen_qemu_st_i64(fp, addr, ctx->memidx, + MO_TEUQ | MO_ALIGN); } else { tcg_gen_subi_i32(addr, REG(B11_8), 4); - tcg_gen_qemu_st_i32(FREG(B7_4), addr, ctx->memidx, MO_TEUL); + tcg_gen_qemu_st_i32(FREG(B7_4), addr, ctx->memidx, + MO_TEUL | MO_ALIGN); } tcg_gen_mov_i32(REG(B11_8), addr); } @@ -1011,10 +1025,12 @@ static void _decode_opc(DisasContext * ctx) tcg_gen_add_i32(addr, REG(B7_4), REG(0)); if (ctx->tbflags & FPSCR_SZ) { TCGv_i64 fp = tcg_temp_new_i64(); - tcg_gen_qemu_ld_i64(fp, addr, ctx->memidx, MO_TEUQ); + tcg_gen_qemu_ld_i64(fp, addr, ctx->memidx, + MO_TEUQ | MO_ALIGN); gen_store_fpr64(ctx, fp, XHACK(B11_8)); } else { - tcg_gen_qemu_ld_i32(FREG(B11_8), addr, ctx->memidx, MO_TEUL); + tcg_gen_qemu_ld_i32(FREG(B11_8), addr, ctx->memidx, + MO_TEUL | MO_ALIGN); } } return; @@ -1026,9 +1042,11 @@ static void _decode_opc(DisasContext * ctx) if (ctx->tbflags & FPSCR_SZ) { TCGv_i64 fp = tcg_temp_new_i64(); gen_load_fpr64(ctx, fp, XHACK(B7_4)); - tcg_gen_qemu_st_i64(fp, addr, ctx->memidx, MO_TEUQ); + tcg_gen_qemu_st_i64(fp, addr, ctx->memidx, + MO_TEUQ | MO_ALIGN); } else { - tcg_gen_qemu_st_i32(FREG(B7_4), addr, ctx->memidx, MO_TEUL); + tcg_gen_qemu_st_i32(FREG(B7_4), addr, ctx->memidx, + MO_TEUL | MO_ALIGN); } } return; @@ -1158,14 +1176,14 @@ static void _decode_opc(DisasContext * ctx) { TCGv addr = tcg_temp_new(); tcg_gen_addi_i32(addr, cpu_gbr, B7_0 * 2); - tcg_gen_qemu_ld_i32(REG(0), addr, ctx->memidx, MO_TESW); + tcg_gen_qemu_ld_i32(REG(0), addr, ctx->memidx, MO_TESW | MO_ALIGN); } return; case 0xc600: /* mov.l @(disp,GBR),R0 */ { TCGv addr = tcg_temp_new(); tcg_gen_addi_i32(addr, cpu_gbr, B7_0 * 4); - tcg_gen_qemu_ld_i32(REG(0), addr, ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(REG(0), addr, ctx->memidx, MO_TESL | MO_ALIGN); } return; case 0xc000: /* mov.b R0,@(disp,GBR) */ @@ -1179,14 +1197,14 @@ static void _decode_opc(DisasContext * ctx) { TCGv addr = tcg_temp_new(); tcg_gen_addi_i32(addr, cpu_gbr, B7_0 * 2); - tcg_gen_qemu_st_i32(REG(0), addr, ctx->memidx, MO_TEUW); + tcg_gen_qemu_st_i32(REG(0), addr, ctx->memidx, MO_TEUW | MO_ALIGN); } return; case 0xc200: /* mov.l R0,@(disp,GBR) */ { TCGv addr = tcg_temp_new(); tcg_gen_addi_i32(addr, cpu_gbr, B7_0 * 4); - tcg_gen_qemu_st_i32(REG(0), addr, ctx->memidx, MO_TEUL); + tcg_gen_qemu_st_i32(REG(0), addr, ctx->memidx, MO_TEUL | MO_ALIGN); } return; case 0x8000: /* mov.b R0,@(disp,Rn) */ @@ -1286,7 +1304,8 @@ static void _decode_opc(DisasContext * ctx) return; case 0x4087: /* ldc.l @Rm+,Rn_BANK */ CHECK_PRIVILEGED - tcg_gen_qemu_ld_i32(ALTREG(B6_4), REG(B11_8), ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(ALTREG(B6_4), REG(B11_8), ctx->memidx, + MO_TESL | MO_ALIGN); tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4); return; case 0x0082: /* stc Rm_BANK,Rn */ @@ -1298,7 +1317,8 @@ static void _decode_opc(DisasContext * ctx) { TCGv addr = tcg_temp_new(); tcg_gen_subi_i32(addr, REG(B11_8), 4); - tcg_gen_qemu_st_i32(ALTREG(B6_4), addr, ctx->memidx, MO_TEUL); + tcg_gen_qemu_st_i32(ALTREG(B6_4), addr, ctx->memidx, + MO_TEUL | MO_ALIGN); tcg_gen_mov_i32(REG(B11_8), addr); } return; @@ -1354,7 +1374,8 @@ static void _decode_opc(DisasContext * ctx) CHECK_PRIVILEGED { TCGv val = tcg_temp_new(); - tcg_gen_qemu_ld_i32(val, REG(B11_8), ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(val, REG(B11_8), ctx->memidx, + MO_TESL | MO_ALIGN); tcg_gen_andi_i32(val, val, 0x700083f3); gen_write_sr(val); tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4); @@ -1372,7 +1393,7 @@ static void _decode_opc(DisasContext * ctx) TCGv val = tcg_temp_new(); tcg_gen_subi_i32(addr, REG(B11_8), 4); gen_read_sr(val); - tcg_gen_qemu_st_i32(val, addr, ctx->memidx, MO_TEUL); + tcg_gen_qemu_st_i32(val, addr, ctx->memidx, MO_TEUL | MO_ALIGN); tcg_gen_mov_i32(REG(B11_8), addr); } return; @@ -1383,7 +1404,8 @@ static void _decode_opc(DisasContext * ctx) return; \ case ldpnum: \ prechk \ - tcg_gen_qemu_ld_i32(cpu_##reg, REG(B11_8), ctx->memidx, MO_TESL); \ + tcg_gen_qemu_ld_i32(cpu_##reg, REG(B11_8), ctx->memidx, \ + MO_TESL | MO_ALIGN); \ tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4); \ return; #define ST(reg,stnum,stpnum,prechk) \ @@ -1396,7 +1418,8 @@ static void _decode_opc(DisasContext * ctx) { \ TCGv addr = tcg_temp_new(); \ tcg_gen_subi_i32(addr, REG(B11_8), 4); \ - tcg_gen_qemu_st_i32(cpu_##reg, addr, ctx->memidx, MO_TEUL); \ + tcg_gen_qemu_st_i32(cpu_##reg, addr, ctx->memidx, \ + MO_TEUL | MO_ALIGN); \ tcg_gen_mov_i32(REG(B11_8), addr); \ } \ return; @@ -1423,7 +1446,8 @@ static void _decode_opc(DisasContext * ctx) CHECK_FPU_ENABLED { TCGv addr = tcg_temp_new(); - tcg_gen_qemu_ld_i32(addr, REG(B11_8), ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(addr, REG(B11_8), ctx->memidx, + MO_TESL | MO_ALIGN); tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4); gen_helper_ld_fpscr(cpu_env, addr); ctx->base.is_jmp = DISAS_STOP; @@ -1441,16 +1465,18 @@ static void _decode_opc(DisasContext * ctx) tcg_gen_andi_i32(val, cpu_fpscr, 0x003fffff); addr = tcg_temp_new(); tcg_gen_subi_i32(addr, REG(B11_8), 4); - tcg_gen_qemu_st_i32(val, addr, ctx->memidx, MO_TEUL); + tcg_gen_qemu_st_i32(val, addr, ctx->memidx, MO_TEUL | MO_ALIGN); tcg_gen_mov_i32(REG(B11_8), addr); } return; case 0x00c3: /* movca.l R0,@Rm */ { TCGv val = tcg_temp_new(); - tcg_gen_qemu_ld_i32(val, REG(B11_8), ctx->memidx, MO_TEUL); + tcg_gen_qemu_ld_i32(val, REG(B11_8), ctx->memidx, + MO_TEUL | MO_ALIGN); gen_helper_movcal(cpu_env, REG(B11_8), val); - tcg_gen_qemu_st_i32(REG(0), REG(B11_8), ctx->memidx, MO_TEUL); + tcg_gen_qemu_st_i32(REG(0), REG(B11_8), ctx->memidx, + MO_TEUL | MO_ALIGN); } ctx->has_movcal = 1; return; @@ -1492,11 +1518,13 @@ static void _decode_opc(DisasContext * ctx) cpu_lock_addr, fail); tmp = tcg_temp_new(); tcg_gen_atomic_cmpxchg_i32(tmp, REG(B11_8), cpu_lock_value, - REG(0), ctx->memidx, MO_TEUL); + REG(0), ctx->memidx, + MO_TEUL | MO_ALIGN); tcg_gen_setcond_i32(TCG_COND_EQ, cpu_sr_t, tmp, cpu_lock_value); } else { tcg_gen_brcondi_i32(TCG_COND_EQ, cpu_lock_addr, -1, fail); - tcg_gen_qemu_st_i32(REG(0), REG(B11_8), ctx->memidx, MO_TEUL); + tcg_gen_qemu_st_i32(REG(0), REG(B11_8), ctx->memidx, + MO_TEUL | MO_ALIGN); tcg_gen_movi_i32(cpu_sr_t, 1); } tcg_gen_br(done); @@ -1521,11 +1549,13 @@ static void _decode_opc(DisasContext * ctx) if ((tb_cflags(ctx->base.tb) & CF_PARALLEL)) { TCGv tmp = tcg_temp_new(); tcg_gen_mov_i32(tmp, REG(B11_8)); - tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx, + MO_TESL | MO_ALIGN); tcg_gen_mov_i32(cpu_lock_value, REG(0)); tcg_gen_mov_i32(cpu_lock_addr, tmp); } else { - tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx, MO_TESL); + tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx, + MO_TESL | MO_ALIGN); tcg_gen_movi_i32(cpu_lock_addr, 0); } return; From patchwork Tue May 2 16:08:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678415 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595187wrs; Tue, 2 May 2023 09:09:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6iLtSNNAOzixHeP02OTU0eBQTqtL4gpvYzdjINGkIk1EQNYzOpM75VuK+gLS6DaEO22egW X-Received: by 2002:ac8:7fcb:0:b0:3db:7f42:ab0f with SMTP id b11-20020ac87fcb000000b003db7f42ab0fmr27296207qtk.67.1683043783493; Tue, 02 May 2023 09:09:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043783; cv=none; d=google.com; s=arc-20160816; b=OcCIBxv+tMtItyut2PnGVWFwXA45GhgCQo5FY428rXmYwl52ElwVxGzqa5XbtQxNwB sbNEWl4URqWNZukzFpwOpX+TGxy+DSw2jJn3czFZgKEO8N/XZWt3up5G4EytsUJOzQGk QX6qYrQENsqP/kqdXQtKfrM8qFuJg6c3ZOo3QXTZzsdEGcSLsctrPF4vYFIhEwOxn5v9 Qkj1/YWP6QApPvIHOtDr01obopsBHX54BKFSeIqIaHVV9ppSLE3mrrw5RoQZQy5rlzZJ xGUoqjsXjybZVqGCK9Yh1EAlXimBsXIV7xuJY/G4A77Wguu3O0CTHoq+rb7fYEqnKSV7 srmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZP31Pk3tH34mbeH0aDrvA9wL/7YteLfz9EWB0OFwplU=; b=VLGVd3rvdXAdont18/BlOS82cvsgtAo1Urb3dCgvMw4UiJH5iBVy8Ygrbl11gBXyfB 8dAYR8tobT3ojRsm8VDOtfj6YQkrmrhNwA0NIyVaKiFuRlJoYLJ1FZllMgFSadrnyIoD f2fFwkMgUE5RwZCrPbYxx8bzheB4881ftYuE8ZLbNfvYFLTSTsuXKxGJojQzEiefOTWi A/WbfEfPGlxaiOxwRZf59PaG2cWfNcQ/XUruQNkMTbpiHLvspZ5+KzhfVTiLRsRyYh0Z +QDu5iZtULjHQVrisQLExJ8sKl6Le76bN5zC8Shv+1SkqeEVVwHimLdbJgeOD+D5TLhI PIeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IbRs+cx3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t9-20020ac85889000000b003e38657e649si17636709qta.433.2023.05.02.09.09.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:09:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IbRs+cx3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsZ1-0002sE-CE; Tue, 02 May 2023 12:09:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYq-0002oK-Mw for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:05 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYn-0000l1-Ib for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:04 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3f1958d3a53so39873405e9.0 for ; Tue, 02 May 2023 09:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043736; x=1685635736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZP31Pk3tH34mbeH0aDrvA9wL/7YteLfz9EWB0OFwplU=; b=IbRs+cx3OVUZsotJShRta6LhNB4MH7w5kpDnzogltARZc+W7uSkBsdIAQybtMsOS2A qjHXa4L7sk21Qa+US9GCJzRvN6UMCvIlv/ZhjTIOt/j1HCDXiEFXWxWYS9CbrXQDU7yo 1cDs7S3zlRq1K+QATbOphWIgRnCoyuzPPx3DDiuJM5dgA89QT60hChMaTdIvAmngrR0D mGN5TOhMGYKY5WX5Vcsjx+1pCuBcfxSmNbqrR2dloRqGbn0tNo91prfIoDzQd+bwBawL doEzqdpkCrUFt34tfr+aq1BJeQv4p/7PRnbBuZHX/RQUqsn9yfZdNQDvJhR+qUbnOUCU 4rqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043736; x=1685635736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZP31Pk3tH34mbeH0aDrvA9wL/7YteLfz9EWB0OFwplU=; b=ZYpVLu5gyhtWqXTbvFu4sSuG69SLie83+UIy6hy8RG0oZBhbaeDbu/cqsTIZcWumUo 7spc7NEqJJU5PyVZ4SCkAS04VknBoB0GC+VmqDjzZ47PkfTsC+ieq3JQG2JTV3XSUpFc Ppk/gBkEA6pVpM/S47U0B+hwh1l9J2RG5vXNB0yb3x3ZhbrphJi2cZftDXuJVl+gw4je 9We+Uml6CTu/QvCmeDiOGIblFdUgbixgzuUzC06fo2qPE7yZGzKXU85NK7DBOhtW79Cd lRxhuCjD2wmrmFr8MPzAy4NBQ0SUyQOyukkh41nHNIz2cE3nL3VK79zSiuXX8iefOiFp EAjw== X-Gm-Message-State: AC+VfDwGLWW4nGcD8A2ERdx2FLN+p5NOqLqseBhRROnwT1Z/Rc9irs7C lgj5qJoAmKbt4TaaXXS92Jn85AIVN01l5g08SVDdug== X-Received: by 2002:a5d:470c:0:b0:2e6:3804:5be with SMTP id y12-20020a5d470c000000b002e6380405bemr11146550wrq.59.1683043735769; Tue, 02 May 2023 09:08:55 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:55 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 12/16] target/sh4: Remove TARGET_ALIGNED_ONLY Date: Tue, 2 May 2023 17:08:42 +0100 Message-Id: <20230502160846.1289975-13-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- configs/targets/sh4-linux-user.mak | 1 - configs/targets/sh4-softmmu.mak | 1 - configs/targets/sh4eb-linux-user.mak | 1 - configs/targets/sh4eb-softmmu.mak | 1 - 4 files changed, 4 deletions(-) diff --git a/configs/targets/sh4-linux-user.mak b/configs/targets/sh4-linux-user.mak index 0152d6621e..9908887566 100644 --- a/configs/targets/sh4-linux-user.mak +++ b/configs/targets/sh4-linux-user.mak @@ -1,5 +1,4 @@ TARGET_ARCH=sh4 TARGET_SYSTBL_ABI=common TARGET_SYSTBL=syscall.tbl -TARGET_ALIGNED_ONLY=y TARGET_HAS_BFLT=y diff --git a/configs/targets/sh4-softmmu.mak b/configs/targets/sh4-softmmu.mak index 95896376c4..f9d62d91e4 100644 --- a/configs/targets/sh4-softmmu.mak +++ b/configs/targets/sh4-softmmu.mak @@ -1,2 +1 @@ TARGET_ARCH=sh4 -TARGET_ALIGNED_ONLY=y diff --git a/configs/targets/sh4eb-linux-user.mak b/configs/targets/sh4eb-linux-user.mak index 6724165efe..9db6b3609c 100644 --- a/configs/targets/sh4eb-linux-user.mak +++ b/configs/targets/sh4eb-linux-user.mak @@ -1,6 +1,5 @@ TARGET_ARCH=sh4 TARGET_SYSTBL_ABI=common TARGET_SYSTBL=syscall.tbl -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y TARGET_HAS_BFLT=y diff --git a/configs/targets/sh4eb-softmmu.mak b/configs/targets/sh4eb-softmmu.mak index dc8b30bf7a..226b1fc698 100644 --- a/configs/targets/sh4eb-softmmu.mak +++ b/configs/targets/sh4eb-softmmu.mak @@ -1,3 +1,2 @@ TARGET_ARCH=sh4 -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y From patchwork Tue May 2 16:08:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678424 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595896wrs; Tue, 2 May 2023 09:10:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5UAK9t+pbHuZZla1qhbNBKDsxXWTo7FfVQQtlr+270oDEPAjjPSw1oKbbHErCJJ+hxcHdY X-Received: by 2002:ac8:5fd1:0:b0:3f1:f8fa:11cd with SMTP id k17-20020ac85fd1000000b003f1f8fa11cdmr28438679qta.49.1683043857707; Tue, 02 May 2023 09:10:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043857; cv=none; d=google.com; s=arc-20160816; b=EvC7yWOLZT9MCRRAXaRjApuPE68vE9L/8mevJU8KENMW1YYFnb7Wioy0f+7TzvZ8Bz okfjPQJy05toSVcbU0J9N88P3xxtq8Bt6xKv66qUJhD+YqLyDod9oC923wwN3+y+aeOz qNElNPkIS+CtNe/lvKtDEM/vXMZq93Fpuw3dDaW0jTVQEmVattlGUx6ibdO5EX00QKQ1 ugSUu2PmypuI6EotzsjyC33OKm9V/llR6bDXAAVXtxgDGYyCHx/qTJbEjTqwA819ClOO 6jmDkpOISYl4iVddrffUDETaeFUXCxvKcNeuSIRhTVb10gA4ubX0VV+Y8FNEGY7AS5lR 3UIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0yzJc4jZKJ70DTOT+LrCw9YC1efp+iFqVCbc/e9SoDg=; b=K+ig4e3YMIakON83szP+OBup0nlUij3AzkCZd3AgsS89qkFhaoh9Mij3a/5NbHpHQY tdQhJxK4ZrSumq9ftHtFPFQGxjkZB84nNGQOoDpDp9BPQMzGN2RgxrWx0lSuZzJOdLYT VrEsiV4mT8uIzfKkd3Njw0a+ipRT0Gmnjnkifc6Pgbe6vY/lNQziPhfw8lMmKEE6FgVx e//wfatcqWBCSKqhEnfjxprSQGCGSIIpyN5BIZYHP2N6CcPq46TkDusvtL+iIjk3tw/C MLyMIJejgarFuQV5eIB+rP4E3Dv0HkKRzXGgiVML8jY4ZX2ffV/FpDWhq6a0EM40iqJ1 AwDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EhfVLWP6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id bn43-20020a05620a2aeb00b007445e4b5fb6si17183670qkb.697.2023.05.02.09.10.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:10:57 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EhfVLWP6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYx-0002pW-1F; Tue, 02 May 2023 12:09:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYs-0002oz-8a for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:07 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYn-0000lD-JD for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:06 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f178da21afso26643935e9.1 for ; Tue, 02 May 2023 09:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043736; x=1685635736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0yzJc4jZKJ70DTOT+LrCw9YC1efp+iFqVCbc/e9SoDg=; b=EhfVLWP60sVbqdPlNGRO7Y8UCGznwnok8aEfPJ6IaQiefEPTAOsnWXsHSO/Ft+SIJu ZhMO7MpH+1nf0S9QhSgkeLkVLgWkNftVrIhNWlONHfXnAbVxGU5HmhOvyxckxf6hc3i3 JwBdq4C9HLHFCELECwqt67zeBbA8V4G5UvRpC3saO386hF/OuBatk4oRgSdS8RtprKAL rQ8zZr155G0Nswj5IB0d4UUuG7bDQm6Ic4eJLwK3eVjSu/HMhB75zaJ+k5uCENNXDe0l sYmHWtB0cqacVZwppDbpnxH1i3nzQ5nuGzdZFHSVmn7csm2Z5rMbm+1aCjieBmPZAgCC Qieg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043736; x=1685635736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0yzJc4jZKJ70DTOT+LrCw9YC1efp+iFqVCbc/e9SoDg=; b=bIFVehPDIHBwoAJBzRH6fUDnaQLdwiQcziez+04ZvIbWng+a/URV7BHpm943R5LXdd z+g4NO/SOesJe5Qi3pAQhwQjs20zQGLrVMNm9BUxo5IgnyJrs8QQW3MIaOoI4PTTdesp 1+Ew4hV8U/jQwNA64YN3VXtmFyczDbmuxFRRPoZT/2a0hVU0QLGqTizmxK9ZN1QYP3HG tg0v/m9pFBqBBt2SyNmFXKZfD1lfZsqWfA7CfzLJKzqHgV2Mi87jVMNj4a5ZZGnNlWA9 +E/kuYVXmoYDm9AKstLm6DCInxhbmqMKUm8G6qsWuWfD2XWYe9+wMROdTsU+IQeDheeV 4xjQ== X-Gm-Message-State: AC+VfDwPDw9zcELE6387tPRqDMw0e+Nyy4/6xRagfL7Ywck/QWF+NOuz 0axh/KchE6cVK+Q+5XUJ9rIAxeeFI2UDBQV/fck36w== X-Received: by 2002:a1c:f217:0:b0:3f1:70cf:a2d9 with SMTP id s23-20020a1cf217000000b003f170cfa2d9mr12431460wmc.9.1683043736469; Tue, 02 May 2023 09:08:56 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:56 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 13/16] target/sparc: Use MO_ALIGN where required Date: Tue, 2 May 2023 17:08:43 +0100 Message-Id: <20230502160846.1289975-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson Acked-by: Mark Cave-Ayland --- target/sparc/translate.c | 66 +++++++++++++++++++++------------------- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index bc71e44e66..414e014b11 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -1899,7 +1899,7 @@ static void gen_swap(DisasContext *dc, TCGv dst, TCGv src, TCGv addr, int mmu_idx, MemOp memop) { gen_address_mask(dc, addr); - tcg_gen_atomic_xchg_tl(dst, addr, src, mmu_idx, memop); + tcg_gen_atomic_xchg_tl(dst, addr, src, mmu_idx, memop | MO_ALIGN); } static void gen_ldstub(DisasContext *dc, TCGv dst, TCGv addr, int mmu_idx) @@ -2155,12 +2155,12 @@ static void gen_ld_asi(DisasContext *dc, TCGv dst, TCGv addr, break; case GET_ASI_DIRECT: gen_address_mask(dc, addr); - tcg_gen_qemu_ld_tl(dst, addr, da.mem_idx, da.memop); + tcg_gen_qemu_ld_tl(dst, addr, da.mem_idx, da.memop | MO_ALIGN); break; default: { TCGv_i32 r_asi = tcg_constant_i32(da.asi); - TCGv_i32 r_mop = tcg_constant_i32(memop); + TCGv_i32 r_mop = tcg_constant_i32(memop | MO_ALIGN); save_state(dc); #ifdef TARGET_SPARC64 @@ -2201,7 +2201,7 @@ static void gen_st_asi(DisasContext *dc, TCGv src, TCGv addr, /* fall through */ case GET_ASI_DIRECT: gen_address_mask(dc, addr); - tcg_gen_qemu_st_tl(src, addr, da.mem_idx, da.memop); + tcg_gen_qemu_st_tl(src, addr, da.mem_idx, da.memop | MO_ALIGN); break; #if !defined(TARGET_SPARC64) && !defined(CONFIG_USER_ONLY) case GET_ASI_BCOPY: @@ -2233,7 +2233,7 @@ static void gen_st_asi(DisasContext *dc, TCGv src, TCGv addr, default: { TCGv_i32 r_asi = tcg_constant_i32(da.asi); - TCGv_i32 r_mop = tcg_constant_i32(memop & MO_SIZE); + TCGv_i32 r_mop = tcg_constant_i32(memop | MO_ALIGN); save_state(dc); #ifdef TARGET_SPARC64 @@ -2283,7 +2283,7 @@ static void gen_cas_asi(DisasContext *dc, TCGv addr, TCGv cmpv, case GET_ASI_DIRECT: oldv = tcg_temp_new(); tcg_gen_atomic_cmpxchg_tl(oldv, addr, cmpv, gen_load_gpr(dc, rd), - da.mem_idx, da.memop); + da.mem_idx, da.memop | MO_ALIGN); gen_store_gpr(dc, rd, oldv); break; default: @@ -2347,7 +2347,7 @@ static void gen_ldf_asi(DisasContext *dc, TCGv addr, switch (size) { case 4: d32 = gen_dest_fpr_F(dc); - tcg_gen_qemu_ld_i32(d32, addr, da.mem_idx, da.memop); + tcg_gen_qemu_ld_i32(d32, addr, da.mem_idx, da.memop | MO_ALIGN); gen_store_fpr_F(dc, rd, d32); break; case 8: @@ -2397,7 +2397,8 @@ static void gen_ldf_asi(DisasContext *dc, TCGv addr, /* Valid for lddfa only. */ if (size == 8) { gen_address_mask(dc, addr); - tcg_gen_qemu_ld_i64(cpu_fpr[rd / 2], addr, da.mem_idx, da.memop); + tcg_gen_qemu_ld_i64(cpu_fpr[rd / 2], addr, da.mem_idx, + da.memop | MO_ALIGN); } else { gen_exception(dc, TT_ILL_INSN); } @@ -2406,7 +2407,7 @@ static void gen_ldf_asi(DisasContext *dc, TCGv addr, default: { TCGv_i32 r_asi = tcg_constant_i32(da.asi); - TCGv_i32 r_mop = tcg_constant_i32(da.memop); + TCGv_i32 r_mop = tcg_constant_i32(da.memop | MO_ALIGN); save_state(dc); /* According to the table in the UA2011 manual, the only @@ -2454,7 +2455,7 @@ static void gen_stf_asi(DisasContext *dc, TCGv addr, switch (size) { case 4: d32 = gen_load_fpr_F(dc, rd); - tcg_gen_qemu_st_i32(d32, addr, da.mem_idx, da.memop); + tcg_gen_qemu_st_i32(d32, addr, da.mem_idx, da.memop | MO_ALIGN); break; case 8: tcg_gen_qemu_st_i64(cpu_fpr[rd / 2], addr, da.mem_idx, @@ -2506,7 +2507,8 @@ static void gen_stf_asi(DisasContext *dc, TCGv addr, /* Valid for stdfa only. */ if (size == 8) { gen_address_mask(dc, addr); - tcg_gen_qemu_st_i64(cpu_fpr[rd / 2], addr, da.mem_idx, da.memop); + tcg_gen_qemu_st_i64(cpu_fpr[rd / 2], addr, da.mem_idx, + da.memop | MO_ALIGN); } else { gen_exception(dc, TT_ILL_INSN); } @@ -2543,7 +2545,7 @@ static void gen_ldda_asi(DisasContext *dc, TCGv addr, int insn, int rd) TCGv_i64 tmp = tcg_temp_new_i64(); gen_address_mask(dc, addr); - tcg_gen_qemu_ld_i64(tmp, addr, da.mem_idx, da.memop); + tcg_gen_qemu_ld_i64(tmp, addr, da.mem_idx, da.memop | MO_ALIGN); /* Note that LE ldda acts as if each 32-bit register result is byte swapped. Having just performed one @@ -2613,7 +2615,7 @@ static void gen_stda_asi(DisasContext *dc, TCGv hi, TCGv addr, tcg_gen_concat32_i64(t64, hi, lo); } gen_address_mask(dc, addr); - tcg_gen_qemu_st_i64(t64, addr, da.mem_idx, da.memop); + tcg_gen_qemu_st_i64(t64, addr, da.mem_idx, da.memop | MO_ALIGN); } break; @@ -2651,7 +2653,7 @@ static void gen_casx_asi(DisasContext *dc, TCGv addr, TCGv cmpv, case GET_ASI_DIRECT: oldv = tcg_temp_new(); tcg_gen_atomic_cmpxchg_tl(oldv, addr, cmpv, gen_load_gpr(dc, rd), - da.mem_idx, da.memop); + da.mem_idx, da.memop | MO_ALIGN); gen_store_gpr(dc, rd, oldv); break; default: @@ -2678,7 +2680,7 @@ static void gen_ldda_asi(DisasContext *dc, TCGv addr, int insn, int rd) return; case GET_ASI_DIRECT: gen_address_mask(dc, addr); - tcg_gen_qemu_ld_i64(t64, addr, da.mem_idx, da.memop); + tcg_gen_qemu_ld_i64(t64, addr, da.mem_idx, da.memop | MO_ALIGN); break; default: { @@ -2710,7 +2712,7 @@ static void gen_stda_asi(DisasContext *dc, TCGv hi, TCGv addr, break; case GET_ASI_DIRECT: gen_address_mask(dc, addr); - tcg_gen_qemu_st_i64(t64, addr, da.mem_idx, da.memop); + tcg_gen_qemu_st_i64(t64, addr, da.mem_idx, da.memop | MO_ALIGN); break; case GET_ASI_BFILL: /* Store 32 bytes of T64 to ADDR. */ @@ -5180,7 +5182,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) case 0x0: /* ld, V9 lduw, load unsigned word */ gen_address_mask(dc, cpu_addr); tcg_gen_qemu_ld_tl(cpu_val, cpu_addr, - dc->mem_idx, MO_TEUL); + dc->mem_idx, MO_TEUL | MO_ALIGN); break; case 0x1: /* ldub, load unsigned byte */ gen_address_mask(dc, cpu_addr); @@ -5190,7 +5192,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) case 0x2: /* lduh, load unsigned halfword */ gen_address_mask(dc, cpu_addr); tcg_gen_qemu_ld_tl(cpu_val, cpu_addr, - dc->mem_idx, MO_TEUW); + dc->mem_idx, MO_TEUW | MO_ALIGN); break; case 0x3: /* ldd, load double word */ if (rd & 1) @@ -5201,7 +5203,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) gen_address_mask(dc, cpu_addr); t64 = tcg_temp_new_i64(); tcg_gen_qemu_ld_i64(t64, cpu_addr, - dc->mem_idx, MO_TEUQ); + dc->mem_idx, MO_TEUQ | MO_ALIGN); tcg_gen_trunc_i64_tl(cpu_val, t64); tcg_gen_ext32u_tl(cpu_val, cpu_val); gen_store_gpr(dc, rd + 1, cpu_val); @@ -5217,7 +5219,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) case 0xa: /* ldsh, load signed halfword */ gen_address_mask(dc, cpu_addr); tcg_gen_qemu_ld_tl(cpu_val, cpu_addr, - dc->mem_idx, MO_TESW); + dc->mem_idx, MO_TESW | MO_ALIGN); break; case 0xd: /* ldstub */ gen_ldstub(dc, cpu_val, cpu_addr, dc->mem_idx); @@ -5272,12 +5274,12 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) case 0x08: /* V9 ldsw */ gen_address_mask(dc, cpu_addr); tcg_gen_qemu_ld_tl(cpu_val, cpu_addr, - dc->mem_idx, MO_TESL); + dc->mem_idx, MO_TESL | MO_ALIGN); break; case 0x0b: /* V9 ldx */ gen_address_mask(dc, cpu_addr); tcg_gen_qemu_ld_tl(cpu_val, cpu_addr, - dc->mem_idx, MO_TEUQ); + dc->mem_idx, MO_TEUQ | MO_ALIGN); break; case 0x18: /* V9 ldswa */ gen_ld_asi(dc, cpu_val, cpu_addr, insn, MO_TESL); @@ -5328,7 +5330,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) gen_address_mask(dc, cpu_addr); cpu_dst_32 = gen_dest_fpr_F(dc); tcg_gen_qemu_ld_i32(cpu_dst_32, cpu_addr, - dc->mem_idx, MO_TEUL); + dc->mem_idx, MO_TEUL | MO_ALIGN); gen_store_fpr_F(dc, rd, cpu_dst_32); break; case 0x21: /* ldfsr, V9 ldxfsr */ @@ -5337,14 +5339,14 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) if (rd == 1) { TCGv_i64 t64 = tcg_temp_new_i64(); tcg_gen_qemu_ld_i64(t64, cpu_addr, - dc->mem_idx, MO_TEUQ); + dc->mem_idx, MO_TEUQ | MO_ALIGN); gen_helper_ldxfsr(cpu_fsr, cpu_env, cpu_fsr, t64); break; } #endif cpu_dst_32 = tcg_temp_new_i32(); tcg_gen_qemu_ld_i32(cpu_dst_32, cpu_addr, - dc->mem_idx, MO_TEUL); + dc->mem_idx, MO_TEUL | MO_ALIGN); gen_helper_ldfsr(cpu_fsr, cpu_env, cpu_fsr, cpu_dst_32); break; case 0x22: /* ldqf, load quad fpreg */ @@ -5377,7 +5379,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) case 0x4: /* st, store word */ gen_address_mask(dc, cpu_addr); tcg_gen_qemu_st_tl(cpu_val, cpu_addr, - dc->mem_idx, MO_TEUL); + dc->mem_idx, MO_TEUL | MO_ALIGN); break; case 0x5: /* stb, store byte */ gen_address_mask(dc, cpu_addr); @@ -5386,7 +5388,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) case 0x6: /* sth, store halfword */ gen_address_mask(dc, cpu_addr); tcg_gen_qemu_st_tl(cpu_val, cpu_addr, - dc->mem_idx, MO_TEUW); + dc->mem_idx, MO_TEUW | MO_ALIGN); break; case 0x7: /* std, store double word */ if (rd & 1) @@ -5400,7 +5402,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) t64 = tcg_temp_new_i64(); tcg_gen_concat_tl_i64(t64, lo, cpu_val); tcg_gen_qemu_st_i64(t64, cpu_addr, - dc->mem_idx, MO_TEUQ); + dc->mem_idx, MO_TEUQ | MO_ALIGN); } break; #if !defined(CONFIG_USER_ONLY) || defined(TARGET_SPARC64) @@ -5424,7 +5426,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) case 0x0e: /* V9 stx */ gen_address_mask(dc, cpu_addr); tcg_gen_qemu_st_tl(cpu_val, cpu_addr, - dc->mem_idx, MO_TEUQ); + dc->mem_idx, MO_TEUQ | MO_ALIGN); break; case 0x1e: /* V9 stxa */ gen_st_asi(dc, cpu_val, cpu_addr, insn, MO_TEUQ); @@ -5442,7 +5444,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) gen_address_mask(dc, cpu_addr); cpu_src1_32 = gen_load_fpr_F(dc, rd); tcg_gen_qemu_st_i32(cpu_src1_32, cpu_addr, - dc->mem_idx, MO_TEUL); + dc->mem_idx, MO_TEUL | MO_ALIGN); break; case 0x25: /* stfsr, V9 stxfsr */ { @@ -5450,12 +5452,12 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) gen_address_mask(dc, cpu_addr); if (rd == 1) { tcg_gen_qemu_st_tl(cpu_fsr, cpu_addr, - dc->mem_idx, MO_TEUQ); + dc->mem_idx, MO_TEUQ | MO_ALIGN); break; } #endif tcg_gen_qemu_st_tl(cpu_fsr, cpu_addr, - dc->mem_idx, MO_TEUL); + dc->mem_idx, MO_TEUL | MO_ALIGN); } break; case 0x26: From patchwork Tue May 2 16:08:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678428 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp596145wrs; Tue, 2 May 2023 09:11:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7EkZsO9GmHOrZocrgJ/srFRRV6UOdDNYtzLwMpfUmBPPUfkdSPIyuknVK/u5lDmtzlysjV X-Received: by 2002:a05:6214:1c45:b0:616:54c7:316a with SMTP id if5-20020a0562141c4500b0061654c7316amr6313886qvb.8.1683043884746; Tue, 02 May 2023 09:11:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043884; cv=none; d=google.com; s=arc-20160816; b=P5+vMDP/jOCIhc9CX/0sMCRqf0+47W84Z6ahgkS0POiP8hm7SP9rAtQ5gVc3KfKSx9 f1/ZD8YftPRjEFxaKsjyGPolaNTgCywm2WpuvJmYjcN8Lukkmte+zbYFy1qkhne1E6gL bLCGTesX1KUFQYLNK/vckdI3eoCRfmSgVzxeCXF9itQXUvxWTNbxtOAoPXrobD6q91NN 5qyXWWPUtkl11GZ68R2J2jQBmT50x/M9igDbueynC+0u4U9zf4RulczvHK7SsXL+gD3/ w40GgZdDFgbjQhoZigHK41MApHyRXtUySfl6rJ0jZ/RETIcTVxMI5gn51ggdqhAFSEZy T7bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZCshE9IafXKgT2vV4eAlemBF7e2BqlY02AfvfYW7tmM=; b=vLKle0K8mTwlhUysSv2XXEL8MsRSxMh9VkPVV2E40GFNY10UU+Rr0lUYoDT11j410x Or76nwHDt7ZaUxbcocGBZP5HngQq4JE20JkLqu+mGl7Hpar0PhpedFTstmEoJyUky5A0 JoHU4c1RCzk80tbagySmDR32Abr3OLJMYAmU5IS7Lx7QqeTSaehA9I4ULdir4aJvbEkX H5FpVH13mxDadKYK9TuamVJq3Tk1ulLDwlrP1hZJumbK98S2QTWcYUO7t4iFp81KjYzF SvU0bBOK5ZtJzRuJ/gu2boSY69gEzdjT0G99qebGaQiZaUPI6V+h9zV+GczMJSCet/kd b/7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="CT/VUoNq"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s40-20020a05622a1aa800b003ef5b5c070esi16102643qtc.237.2023.05.02.09.11.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:11:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="CT/VUoNq"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsZ3-0002u9-HD; Tue, 02 May 2023 12:09:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYr-0002ow-Pn for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:07 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYn-0000lJ-JM for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:05 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-30639daee76so605356f8f.1 for ; Tue, 02 May 2023 09:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043737; x=1685635737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZCshE9IafXKgT2vV4eAlemBF7e2BqlY02AfvfYW7tmM=; b=CT/VUoNq1F9GVkXN0bN4HQIBPxrRwjbbgkqSpCxXny61zy03jgsJM0sUfsVsvlwaiT iqqXQGW/oIN0pqOUogKy/wLfFOmidEBzBzPLyMz+0vLkVXj0pBq2RFP+nZS71c1brtaB rczH8ZmajREHAsGrKSGy/dVy8T0WfwS3XbXAyOQWclMn8jWTzEKMdYcpO56v3pBAqIzm ha0gKLZWRhhXrxanvr3XlyIhiEgflVSCcurTY+4/RuFvRpAqwZzikmwGHIiwVcx6lr3I ub6sAhGRxPQmcPoqV/XHcNuR/KCghbEIqF6vrldb+d/arblx5PIcnspklN5G8EhfQ9rM N4IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043737; x=1685635737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZCshE9IafXKgT2vV4eAlemBF7e2BqlY02AfvfYW7tmM=; b=Sk3RVZFXKiajE1jBOGgJktc9TPOe+c6+X2yXA1wRTw2whTmsaBEAqYd94AC46BUe58 AmndMSXWcF0tFGimcBpG1gA/mS08zfRjqm/RiIQgVU6Y2CQO01esNiGShmKQ2/JdT4CO ONzq/mmZ4rDysQr9UjtcmS9c5bYqgYR762HhrflLJ0PjZTxJ4HdhZHGVtl177yghV+o4 GxXHSeHt657pK5Y19i4DSTiI+VTa5ObVYMVFMnvhK/BCwNuIuUeOdz3h7Put/JZd6XaI QSf8k16vo1pvsxNhCA6EgjAYp4hKOjq2NO+pzPBV7+2ySoSrer+ioWub0sLTuWwTy5dT RWTA== X-Gm-Message-State: AC+VfDzsHXdl6X1fVBdxSllR35zoM2nwITpf41K/OuPNGr6M5TPL29RL HwcmOPC42lLIo5HoGHTe2vwgaylxb8X64nKum0M81Q== X-Received: by 2002:a5d:6d47:0:b0:306:339b:684 with SMTP id k7-20020a5d6d47000000b00306339b0684mr3311452wri.65.1683043737406; Tue, 02 May 2023 09:08:57 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 14/16] target/sparc: Use cpu_ld*_code_mmu Date: Tue, 2 May 2023 17:08:44 +0100 Message-Id: <20230502160846.1289975-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This passes on the memop as given as argument to helper_ld_asi to the ultimate load primitive. Signed-off-by: Richard Henderson Reviewed-by: Mark Cave-Ayland --- target/sparc/ldst_helper.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index a53580d9e4..7972d56a72 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -593,6 +593,7 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulong addr, #if defined(DEBUG_MXCC) || defined(DEBUG_ASI) uint32_t last_addr = addr; #endif + MemOpIdx oi; do_check_align(env, addr, size - 1, GETPC()); switch (asi) { @@ -692,19 +693,20 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulong addr, case ASI_M_IODIAG: /* Turbosparc IOTLB Diagnostic */ break; case ASI_KERNELTXT: /* Supervisor code access */ + oi = make_memop_idx(memop, cpu_mmu_index(env, true)); switch (size) { case 1: - ret = cpu_ldub_code(env, addr); + ret = cpu_ldb_code_mmu(env, addr, oi, GETPC()); break; case 2: - ret = cpu_lduw_code(env, addr); + ret = cpu_ldw_code_mmu(env, addr, oi, GETPC()); break; default: case 4: - ret = cpu_ldl_code(env, addr); + ret = cpu_ldl_code_mmu(env, addr, oi, GETPC()); break; case 8: - ret = cpu_ldq_code(env, addr); + ret = cpu_ldq_code_mmu(env, addr, oi, GETPC()); break; } break; From patchwork Tue May 2 16:08:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678422 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp595513wrs; Tue, 2 May 2023 09:10:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7p2sAoUrjmBQREYNwiUVlJNFuPZvBluXXABXM4s1GtNLwR8fhGsTHKk5GFyiBEgURvJyxt X-Received: by 2002:a05:6214:40d:b0:5ed:fa66:bf6a with SMTP id z13-20020a056214040d00b005edfa66bf6amr5704811qvx.52.1683043818412; Tue, 02 May 2023 09:10:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043818; cv=none; d=google.com; s=arc-20160816; b=A2Gw7ITtMY6M7c79+HtyVIuLeqe12IRyKnou/MY82VC6uHWVVPcs11h8EV8htRulsu /aXKUS+rnhE5yy/a5siIVDckkDNueuE/HtibAAWi/0jft+epPozngLVnzOpmgSTUWi5C HYmfUe1EdstlwbAd+o1eHVqKFu03C8JEYTyPIExZ2BjpfpgvNhhRU2LkTI5qpPgwuI5m 8WZ018zX4nii9dry3ma6LuasJXmP4ZdhUM4xUzEWwjXSZIVr9HvA0xSceS9xaOdHK1Ak 38WQDBCreQA62d4BtFre3sppn0UaODN+NKsQUTzKtjE/wx92WnTA1/Ui8Z5M/xO0ZIrX K1Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CuEFSNGMh/WzbQQ92fOBrKgMOL6IF2RkfhGTw2qebH8=; b=AibX5hfpPEUI0+zC+jjKV+fGWNOFFrIh+cVuLUSmA/lTQ/S+fUQ41JHvCqdu5cvFh7 ZxiyQkjKViYOIhII07/x3Zl2OSHmTfA/m5K4aek5vrlZfCLM7qLAm3RnUisJsIF368WI Ct1OVTb4ht7Xl8e6k0DZpeVMGQrHRvw+cSRVh3QF/sMQqLLTLw+BwT8Iv7vREXs1kCry 6pjKMSeMZQbaRtNQyeXY4DchTADpnrRnYIxrq8YJRKGsvBd4z88h3dGKqgEORwoxXwFL 640NiYNql+OVCALqsdr3io36mHW44QtxGbm8dYfeMiyYOQII2SY13jzzZvxQZb0uon8P ZlRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=knyJDa8a; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id gm1-20020a056214268100b005e1c3ed5465si17856444qvb.268.2023.05.02.09.10.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:10:18 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=knyJDa8a; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsYz-0002qq-BD; Tue, 02 May 2023 12:09:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYp-0002mM-9z for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:03 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYn-0000lL-J0 for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:03 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3062db220a3so1630293f8f.0 for ; Tue, 02 May 2023 09:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043738; x=1685635738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CuEFSNGMh/WzbQQ92fOBrKgMOL6IF2RkfhGTw2qebH8=; b=knyJDa8aknyY6eIgnOhlh1hDu4eGpaPHFp0Mes8WyV+6/l5UnHAUgUAPcU6lvqEQ7G UMRJ2aIPcgSGREVdSkJ+oXIHI5Do9uvtyW3dyk+tcju58zEQGvxVkjpD5aJ534/Vm/y0 kpGdExMn4JWF5gTmURtOgJo+YNEWtMhEVEEQ1FmMXvqNBxI4OIkmHBhOFYg6wBVMI7Oc 54geW9Y4slNODkYYQuVD86pfL92rBw7ea/cH6Ea275kcVP4cwB9vqFkL0IHNuhiNSrQA pIiVzxSYstffugAzgaFSbG6+vIZyKkl8DzIQhc5mq/Yq3OZVo9C/sdogSYKIL9ztRhTw 5sXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043738; x=1685635738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CuEFSNGMh/WzbQQ92fOBrKgMOL6IF2RkfhGTw2qebH8=; b=Ld2VpXqyAodD0Y6wYk1pEs6KluD6JI9OhG277kdbSDGkfjDCrmnmFQxBT/v+vtHcxP 2+xEOWwaPQJDSM60Gl5LwL7DAFeQdfX8oKMl54ImfNfOWaXiUt+6LWfFY4Ggr5wsFciS OPxr7r7rlaiTQYraG8yNc13BFXigHqzb2kD4DgXanM6gfgMaXzlwiTQ77ZvZw2XrSxda urespLAh7G2reVW+ANmFigZOhu/aDkBVlW0gEimBvsPB+hliFYzjQR22GQUIT4bVtEZ7 JI9bCS/1rqqIfLjvD+pmDnb9qo+N23IMBbXnfVl+DVHoQUhbpdTmiaIw1K1rfDvpK/Qj J3Qw== X-Gm-Message-State: AC+VfDy0NN55fv3nV9YNRz36X+A9GaYaRXe/2gnFew5MsdWUxumiYLSp uSNe/q+CDNn0xcaHSlITPF4I+hr5kiNo6VnwdpG5Yg== X-Received: by 2002:a5d:4a0a:0:b0:301:8551:446f with SMTP id m10-20020a5d4a0a000000b003018551446fmr13843225wrq.38.1683043738009; Tue, 02 May 2023 09:08:58 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 15/16] target/sparc: Remove TARGET_ALIGNED_ONLY Date: Tue, 2 May 2023 17:08:45 +0100 Message-Id: <20230502160846.1289975-16-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson Reviewed-by: Mark Cave-Ayland --- configs/targets/sparc-linux-user.mak | 1 - configs/targets/sparc-softmmu.mak | 1 - configs/targets/sparc32plus-linux-user.mak | 1 - configs/targets/sparc64-linux-user.mak | 1 - configs/targets/sparc64-softmmu.mak | 1 - 5 files changed, 5 deletions(-) diff --git a/configs/targets/sparc-linux-user.mak b/configs/targets/sparc-linux-user.mak index 00e7bc1f07..abcfb8fc62 100644 --- a/configs/targets/sparc-linux-user.mak +++ b/configs/targets/sparc-linux-user.mak @@ -1,5 +1,4 @@ TARGET_ARCH=sparc TARGET_SYSTBL_ABI=common,32 TARGET_SYSTBL=syscall.tbl -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y diff --git a/configs/targets/sparc-softmmu.mak b/configs/targets/sparc-softmmu.mak index a849190f01..454eb35499 100644 --- a/configs/targets/sparc-softmmu.mak +++ b/configs/targets/sparc-softmmu.mak @@ -1,3 +1,2 @@ TARGET_ARCH=sparc -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y diff --git a/configs/targets/sparc32plus-linux-user.mak b/configs/targets/sparc32plus-linux-user.mak index a65c0951a1..6cc8fa516b 100644 --- a/configs/targets/sparc32plus-linux-user.mak +++ b/configs/targets/sparc32plus-linux-user.mak @@ -4,5 +4,4 @@ TARGET_BASE_ARCH=sparc TARGET_ABI_DIR=sparc TARGET_SYSTBL_ABI=common,32 TARGET_SYSTBL=syscall.tbl -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y diff --git a/configs/targets/sparc64-linux-user.mak b/configs/targets/sparc64-linux-user.mak index 20fcb93fa4..52f05ec000 100644 --- a/configs/targets/sparc64-linux-user.mak +++ b/configs/targets/sparc64-linux-user.mak @@ -3,5 +3,4 @@ TARGET_BASE_ARCH=sparc TARGET_ABI_DIR=sparc TARGET_SYSTBL_ABI=common,64 TARGET_SYSTBL=syscall.tbl -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y diff --git a/configs/targets/sparc64-softmmu.mak b/configs/targets/sparc64-softmmu.mak index c626ac3eae..d3f8a3b710 100644 --- a/configs/targets/sparc64-softmmu.mak +++ b/configs/targets/sparc64-softmmu.mak @@ -1,4 +1,3 @@ TARGET_ARCH=sparc64 TARGET_BASE_ARCH=sparc -TARGET_ALIGNED_ONLY=y TARGET_BIG_ENDIAN=y From patchwork Tue May 2 16:08:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678427 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp596094wrs; Tue, 2 May 2023 09:11:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6mvf0UKXwPJpVm0ib+m0i9oRJzxpvGvE8JJPFp8HSlQcBp9S1Kup0QdzL6AOgr4k19sQQh X-Received: by 2002:a05:622a:100a:b0:3f1:fa37:c830 with SMTP id d10-20020a05622a100a00b003f1fa37c830mr27702315qte.49.1683043878002; Tue, 02 May 2023 09:11:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683043877; cv=none; d=google.com; s=arc-20160816; b=d0dMs+Zxiq6PaY4qzFcWfeiPXXk4T//jpWkrBJjyajClybvJl8TyRc8R6xfL5jU2t7 fszRpyLSXtsL3yeS2M5bRT826zIllSf7r4clZP8bxECXwbSwKvEh0RAMukcV7fufnuPB pe3SqxGU+0JOqUC/Kyp8bgQC6SotjB2D91CiW2oSJTxuVj6J6omd9B8/QcVkaf5UP6TI Rgqr6WE5H4nt96eJGPCAXQo/wbSJ71EzTMMG7awIElS8g+tF5yXH6TjUIR0K8Jtz2uQ7 Qx8e2Ltvv0GFgwLNfotBIwl9RySksgTChg6KPruHpHGwEIIPKzp4iDXCZCvS8y3Av8Qd nXLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=V/VkzTTqO3D6h3H85l5Fuk7F2N9PjLSut9TQvQbh7t8=; b=vTzy+UaqGmjB5dxauYxwhcRpd5g5Xludjj8GBZahnvJbFswLlUfrNLSv7+HQS6BwsC uSHaPxanK1RPLXiWFyIjFqWjUlPo6Tmm4KD4z7dBDpng07liBbWrfx4l982YcqF28gWJ 4iUN0XNG/G7rscVGkYoGsCPUe9/s5Tizkbr8a8EomH0rlNdzNc03+iOfyPlH7xXW6VxB F0sLeCirDjF7YGaO5VUti9a7CJxtabCClkS0PGko3839WHJiqwp28LqTy3tQEzWeGJuA rF3trcspGjMrfPBT6Edp1ztCud/1fjm2z598h8hndrlEAW8RmCxjTPloe/utwBux6m97 2COw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gAQsTkjn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w1-20020a05620a444100b0074ced3e0003si18632709qkp.26.2023.05.02.09.11.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 09:11:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gAQsTkjn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptsZ0-0002r8-3h; Tue, 02 May 2023 12:09:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptsYq-0002oJ-M1 for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:04 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptsYn-0000lT-Id for qemu-devel@nongnu.org; Tue, 02 May 2023 12:09:04 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3062678861fso2193438f8f.0 for ; Tue, 02 May 2023 09:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683043738; x=1685635738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V/VkzTTqO3D6h3H85l5Fuk7F2N9PjLSut9TQvQbh7t8=; b=gAQsTkjnll3StMQpBK++s438VyluyAXkbKheuaQIz9WAMZpMUMdTYJWWMzCmQY/J2o fVbn7p4lgLguKBKXu3LXaOvLVubXFD9/BM4F6IYuDpW3NkRG5DRVfU/dMww8DN4YksN/ 9HvELRkjPslKu6Etn24xJOF45Mez0hGSXnS2ejNzJWBfuKNYrlThM+pBVDOPA/es4bWp /IvbrA2JZWObha9EsufOJikL/p6LecoQzjKcl4HgeLYA6YH4jtddNK2k8TPq4/nJMP/L 86WSUEsVHJmf+S7ArnRu2J0SvRk5lPpwhESS8HfFSB3ZxqkHSJFvBuWS2Y1dwpn9b5dn A5fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043738; x=1685635738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V/VkzTTqO3D6h3H85l5Fuk7F2N9PjLSut9TQvQbh7t8=; b=CN4XhFdpraQLR5GZ4vrxycucCTd4jyySitmH2CeDosnRLd5kE9d2iy49nsaUS1nD9t oLgKKG0Wfc4HH0ybYMnI0KE0GkabyRlhtkWv3y/JKbfxQS3JFmRllBEbAaqvDsMyrwxB Vy/W9kG8jFrZT+zOiaxZCy1cKU2WN2OSVFcGVTJWjIaGf/3lNUAwvbsTNIemB8wLWkOL GOyUhan5YL2cSjOiaQImnkWH8uol3gV6janLFsTzyJBXgDYiXNXc0/dU4x47kGg09MO0 IljC1O8qBLWYbIlYGjDDBBfEv8NYix5KE/+RC4Mb9KOXQ3JCxGn0rUf+2/smuosbkmd1 jWXQ== X-Gm-Message-State: AC+VfDwcW/HK3Ocmw4XS4a4fMaVXV+h0gr53O9fvBZvM7EfDA3gSrfcF pH37HAtwXlECtqnzCJCYsL5GxMLtwAHW6EN1UWOQhg== X-Received: by 2002:a5d:5492:0:b0:304:a984:7cb5 with SMTP id h18-20020a5d5492000000b00304a9847cb5mr12472753wrv.50.1683043738616; Tue, 02 May 2023 09:08:58 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm39918471wmo.41.2023.05.02.09.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:08:58 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: philmd@linaro.org, jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de, ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk Subject: [PATCH 16/16] tcg: Remove TARGET_ALIGNED_ONLY Date: Tue, 2 May 2023 17:08:46 +0100 Message-Id: <20230502160846.1289975-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502160846.1289975-1-richard.henderson@linaro.org> References: <20230502160846.1289975-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org All uses have now been expunged. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- include/exec/memop.h | 13 ++----------- include/exec/poison.h | 1 - tcg/tcg.c | 5 ----- 3 files changed, 2 insertions(+), 17 deletions(-) diff --git a/include/exec/memop.h b/include/exec/memop.h index 25d027434a..07f5f88188 100644 --- a/include/exec/memop.h +++ b/include/exec/memop.h @@ -47,8 +47,6 @@ typedef enum MemOp { * MO_UNALN accesses are never checked for alignment. * MO_ALIGN accesses will result in a call to the CPU's * do_unaligned_access hook if the guest address is not aligned. - * The default depends on whether the target CPU defines - * TARGET_ALIGNED_ONLY. * * Some architectures (e.g. ARMv8) need the address which is aligned * to a size more than the size of the memory access. @@ -65,21 +63,14 @@ typedef enum MemOp { */ MO_ASHIFT = 5, MO_AMASK = 0x7 << MO_ASHIFT, -#ifdef NEED_CPU_H -#ifdef TARGET_ALIGNED_ONLY - MO_ALIGN = 0, - MO_UNALN = MO_AMASK, -#else - MO_ALIGN = MO_AMASK, - MO_UNALN = 0, -#endif -#endif + MO_UNALN = 0, MO_ALIGN_2 = 1 << MO_ASHIFT, MO_ALIGN_4 = 2 << MO_ASHIFT, MO_ALIGN_8 = 3 << MO_ASHIFT, MO_ALIGN_16 = 4 << MO_ASHIFT, MO_ALIGN_32 = 5 << MO_ASHIFT, MO_ALIGN_64 = 6 << MO_ASHIFT, + MO_ALIGN = MO_AMASK, /* Combinations of the above, for ease of use. */ MO_UB = MO_8, diff --git a/include/exec/poison.h b/include/exec/poison.h index 140daa4a85..256736e11a 100644 --- a/include/exec/poison.h +++ b/include/exec/poison.h @@ -35,7 +35,6 @@ #pragma GCC poison TARGET_TRICORE #pragma GCC poison TARGET_XTENSA -#pragma GCC poison TARGET_ALIGNED_ONLY #pragma GCC poison TARGET_HAS_BFLT #pragma GCC poison TARGET_NAME #pragma GCC poison TARGET_SUPPORTS_MTTCG diff --git a/tcg/tcg.c b/tcg/tcg.c index cfd3262a4a..2ce9dba25c 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2071,13 +2071,8 @@ static const char * const ldst_name[] = }; static const char * const alignment_name[(MO_AMASK >> MO_ASHIFT) + 1] = { -#ifdef TARGET_ALIGNED_ONLY - [MO_UNALN >> MO_ASHIFT] = "un+", - [MO_ALIGN >> MO_ASHIFT] = "", -#else [MO_UNALN >> MO_ASHIFT] = "", [MO_ALIGN >> MO_ASHIFT] = "al+", -#endif [MO_ALIGN_2 >> MO_ASHIFT] = "al2+", [MO_ALIGN_4 >> MO_ASHIFT] = "al4+", [MO_ALIGN_8 >> MO_ASHIFT] = "al8+",