From patchwork Thu Jun 8 06:48:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 690542 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50DF9C7EE23 for ; Thu, 8 Jun 2023 06:50:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4C033826; Thu, 8 Jun 2023 08:49:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4C033826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686207017; bh=o56TsGCDACQyHIZmaIXc0S8UsVez4bqhhWvEen4riz0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=P+KidsjtGNxOabinMZBAYlEdqAnwvfTzNjQjbAonG4XiB71Vs691ddbROqhfIOlab ZbAwWtOr14pFXXabIdM7T4s7OvVg9UlZE34UkpdoI3oWb3k5E2qJFEzEAm1SH1lzhu 3rRyM/M4sxyELAbE4sXchFrZW4pur8ekT9DeW3sg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0037CF80548; Thu, 8 Jun 2023 08:48:50 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 84AE4F80549; Thu, 8 Jun 2023 08:48:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 806D3F80549; Thu, 8 Jun 2023 08:48:47 +0200 (CEST) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on2071f.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::71f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E275DF80199 for ; Thu, 8 Jun 2023 08:48:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E275DF80199 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=Z8YO3fz7 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FEmhmvs9Z15UndEYAZ9naL3VK823sQP3hgCbwwRdjxHxh3zlMfXo9NPs5EF5cz1xpWd4AM+fgb55oYebw8B36WCzfEFeZD8676nscGN+XOBZ7yNMEEms/0yO1en/P2jF++nm3MwLOgymaaDqh+GXSXnrGVgkZ582WVNYylr+YyS364O0TMBR3qoCFd//OczmVdxBR8IeKVzs2IJ8ofrbrXS3Lm4Xc6ENnEhjiXRce9vtcZmgFo5HDubQdFdG3NHfM8BfdtbckuKSzEzfGI9WQFhWpTb6FGY5EhRPuOyFIede04SuIoRmpLmNb17bmoMSjmKeYYfUTMs5ORXEZkQj8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3fpPMhbpfYxZQ5lm+Ei3wce4ynDM/kshsQrMsmX28wE=; b=WGCOz6WOGyS77acD6ZpKUGyu4tNqP2U2JCjuTkWP4YDOWZaRxwxsXkYkAFz9ejGwPf2WGnFte9BChA1t3EcLN2lX2ASNGm7Y0AxBR7zqMm77hTkdRTszOzkUCh0BdW3JEUc3BW4lqJARozeUJkK+4pYkeDisHKpQF/uR21xR3gCD7Rf56UTSIzYYWzWv4/3W4tswwMdkJdOHvP2+2mH/sXuUgVwl7sLx9WTAJiYvxFjMBia1oFzu7pPdush9Za5IPXGeGUTrmEQY+58dZAiBUQLHgmlhi4yEqqCR5XhhOSI+zHSnYcsJrV/+LhIBGjjUtU6n/S7rboaS/h36EbTeog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3fpPMhbpfYxZQ5lm+Ei3wce4ynDM/kshsQrMsmX28wE=; b=Z8YO3fz7iWS47lHSG2ekOUZjEZln3Eo6vEzgLfj7IM3oC5118YLubOFk9hRNQHrA9DQnce02lXIrSBn5VP/2UGn3ifLwNpvPVRSm33BQeFCFafXyEtRlZy7MVYYugyI9eoNw+ZwlexBePTJaQZNmwXLNANG6JdopSvQco77lYHI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by OS3PR01MB9300.jpnprd01.prod.outlook.com (2603:1096:604:1cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 8 Jun 2023 06:48:36 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%6]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 06:48:36 +0000 Message-ID: <87r0qmfnzx.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: alsa-devel@alsa-project.org Subject: [PATCH v2 1/5] ASoC: add new trigger ordering method User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> References: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> Date: Thu, 8 Jun 2023 06:48:36 +0000 X-ClientProxiedBy: TYCP286CA0007.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:26c::12) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|OS3PR01MB9300:EE_ X-MS-Office365-Filtering-Correlation-Id: ca897499-5954-413f-2996-08db67ec62a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sxb1gcj8VHIZAzvrzsiOc0o9ifFuw/yHDP5bleMwc71zbH1C6aYU8+3NZVQydQXun5bQf1Bdzdy5yc3KtlOEr8Jt/WgT6j5kyaAa3fVUiIQdZnEi9vNKzFhzkm3XsgLsuFrgkH4P/APuiEEZIt30K3C7MnDx4N5B0tIoJrUv3/ZZbCiPYqQlPLfR+1I4esKqtLW7idqTKHut8//PrAy7Ixn6xedD8WjreVVIqCEKgFFyL1xs11anavamSV+6Tgaf+oATfsaNr5lvY86lhucVilpc4tQ29Gs9eoDJ3kUhUn5SDxsv8FI/bPPD9PL5SVoC/FQkjfsVRuaR7aYcoCBJQP8gZsho7g2G99W6Rt/FMyoZItJ51CPXBl8suAYtD/AIjRBdV24upeHq+QFCux+y6tctfIaaFPqOihKWgDAmZPbLi9b4ZKciwZKrA0GBJOMSSH5Q+J1jKsGHsQQl43kCW/am5iCIQ+x6BqfJHfZubxePTDLEfqgQRdz/wU3asMg+NcvKUqs4t7BMBfZ+h2TTnjk5lvPbbhhC3dy2YJR3g/y6i7aIKABGW0EVZ4AvaIRPRsfV0MDh0jnunpnDD9sg1AbgvSiErVxon5r6qKUWFpRO+8Qk4oT96cv5inwm4QuY X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3PR01MB8426.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199021)(41300700001)(8676002)(4326008)(66556008)(66476007)(8936002)(66946007)(110136005)(5660300002)(316002)(2906002)(478600001)(38100700002)(6512007)(6506007)(86362001)(26005)(38350700002)(186003)(36756003)(52116002)(6486002)(83380400001)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9TT1MnkSSa7tcrIIWMWYYhK9pLIMfXZiJDQW6+hcHq9FeMx5TD5MCdlhydmnvrNUMQ8AYjoYA1l6oqF7TfGoxABZtHccBUls0IIkDOt2EFTdYoXxOtX50vYRvvoJXZDjjtt3kYb6KxGDF8Cfw/8CCZRWp7fWQoUNTzDeIRGwV9KuhAJZlhvGZeOFW9qXr1/wZJyfXpViAZ8mNe4f4jGhAKH2SYgfLooLUKNoRvJ44A4XJh2YuehI9w0B9xGfw0457ZMWU+83FcGpaU/lm3hwoGASPNwIFzRdIKuzLFvbTQiymYwlwkpyB/Yr/JtUeW6VWxEsfwyXjeDePKp9KAju0SfvQpzD4mGkgWm5/XE6AWt+lVhZoeYhr9QKqq+5aRH4AcDvIPbrdkMZaLsIB+f/4QdM3fVCQu1gy2ET3VfaxTXrydFsY91KLPNKRFzEogGIxbvcmTZy8RhfNju5mWifZUgoE9XlyTEonHdURtOtuLvqYK3ppkrTR0vhvhUiAxM/aLS+3SBPrw1XYYsGdKtlN69v7gi8kRyGueqyxwEyNt+VNfzW5i40gNiVhBHvzTbsC3kBXSBFPU0qvwzqGDbWfS4LjSTpL21+1x5q4OIJmuwQX6a7z3srIQkhOKhSj+CJZXdQS8wTCLdshYG6C5jL1WjJ4vNiVQMsTpdIfiF9kaRId0b55UkdveMj2sLYuAxa19Vfij1gOecIHI8uP9RmMUoP1NJOLa8V1SGjFjJiYQ9X47HIhXIApiji9OfGS3ea+s6g/SV0HbU50JXhU59ZXyH5m/UmPMWHFqlS5V/KGAG8CGOz660UlppPG9VydIo79mMBUPulv1S0qprelL0eMS+9qrMETrWhksiqjKn8CeiKSByanxnV/pXIKpFW9Axo1dDASNyyLXjRky5cmzicfPFRCkZLPNA1MvspZW+z7tnXRqOeqG2ViUxEMdoXLEv2d59+KbyrT/0ryGfKr07NGABkzHoUwAa8ADA7MjL0vf0Mc4jZvMrEYeIygOOwwuXE1okM3L51lFOutVdE8eBqURSExBDpGdSPH/O5rX3Jl5Zq5SGAhP2nEWg1lTRCUoPdNVBSXTw4A6hKojCMll0Y4p1l4XAXKQKX9W+Gup6KJQ6/ot0N0N61OYA6T0vBcet8nq8dRpmGqSeZsYkDDqkp2cm6aMRFaiWsuicaq6hvDyJ/i9SSXMlacUDg4bKNy0kzAwFEap13S+W6ybkSLCx9RyPoM62FYP/P/uZ9YOFKio4ogDQYllB78xHAm0URQFFtMAFevoEiI6oC0pCk/UySgUdDZ7+M0IhC2f3rKWo2ODhylHtQuSsWnfmWhEFulkg/8Jrd33VBmqEyZ5FNA7Mt2SIr+ImXy+ksESbrbbG4sa7tLYMURdhU25hxl8Y7bwGWvFUGAJAlZcFpQw4pssixvoE5z2dLCOeHLD2qeCmGO0FDrY9U/+hglrGdQoEtaQHwy6+upxNaTtKcYSlwG1fijH7q96Yt7ggzLKFHN+m4lqJyWfIazs6hB28iGYH++t4g4A6BTMrveIRb1jG9Fh3bMiqSBPlUiWkMft0aR4ZgMGGdyO/ydOnLaOMzaJOojKIO0y0AsgyS3O/0xrrCoAGHzwM93TI1DV6HWWmQF7knbLk= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca897499-5954-413f-2996-08db67ec62a2 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 06:48:36.8665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9eXx6S79FdXyHbMUm4/nEwm52wmV77MhTRR+vQ7ktHWNv7YH1t6tJ7HNzQJ+xzUVxbVL6KPd46JLgpXQFtHHggyysLXYbwNivw+A/CTXs7TMRlTtdkpblr7WMt7wsens X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB9300 Message-ID-Hash: FSADGP2VWGYE2GENPVA3XFW4ANCDV4OQ X-Message-ID-Hash: FSADGP2VWGYE2GENPVA3XFW4ANCDV4OQ X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Current ASoC is assuming that trigger starting order is Link -> Component -> DAI as default, and its reverse order for stopping. But some Driver / Card want to reorder it for some reasons. We have such flags, but is unbalance like below. struct snd_soc_component_driver :: start_dma_last struct snd_soc_dai_link :: stop_dma_first We want to have more flexible, and more generic method. This patch adds new snd_soc_trigger_order for start/stop at component / DAI-link. Signed-off-by: Kuninori Morimoto --- include/sound/soc-component.h | 9 +++ include/sound/soc.h | 17 +++++ sound/soc/soc-pcm.c | 114 +++++++++++++++++++--------------- 3 files changed, 90 insertions(+), 50 deletions(-) diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h index 0b47603c9db2..c7733382757b 100644 --- a/include/sound/soc-component.h +++ b/include/sound/soc-component.h @@ -158,6 +158,15 @@ struct snd_soc_component_driver { int probe_order; int remove_order; + /* + * soc_pcm_trigger() start/stop sequence. + * see also + * snd_soc_dai_link + * soc_pcm_trigger() + */ + enum snd_soc_trigger_order trigger_start; + enum snd_soc_trigger_order trigger_stop; + /* * signal if the module handling the component should not be removed * if a pcm is open. Setting this would prevent the module diff --git a/include/sound/soc.h b/include/sound/soc.h index 10e4ea0664af..49442583d46d 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -607,6 +607,14 @@ int snd_soc_get_strobe(struct snd_kcontrol *kcontrol, int snd_soc_put_strobe(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol); +enum snd_soc_trigger_order { + /* start stop */ + SND_SOC_TRIGGER_ORDER_DEFAULT = 0, /* Link->Component->DAI DAI->Component->Link */ + SND_SOC_TRIGGER_ORDER_LDC, /* Link->DAI->Component Component->DAI->Link */ + + SND_SOC_TRIGGER_ORDER_MAX, +}; + /* SoC PCM stream information */ struct snd_soc_pcm_stream { const char *stream_name; @@ -707,6 +715,15 @@ struct snd_soc_dai_link { const struct snd_soc_ops *ops; const struct snd_soc_compr_ops *compr_ops; + /* + * soc_pcm_trigger() start/stop sequence. + * see also + * snd_soc_component_driver + * soc_pcm_trigger() + */ + enum snd_soc_trigger_order trigger_start; + enum snd_soc_trigger_order trigger_stop; + /* Mark this pcm with non atomic ops */ unsigned int nonatomic:1; diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index f16402ee5a19..40a75b3d0e9e 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1071,49 +1071,77 @@ static int soc_pcm_hw_params(struct snd_pcm_substream *substream, return ret; } +#define TRIGGER_MAX 3 +static int (* const trigger[][TRIGGER_MAX])(struct snd_pcm_substream *substream, int cmd, int rollback) = { + [SND_SOC_TRIGGER_ORDER_DEFAULT] = { + snd_soc_link_trigger, + snd_soc_pcm_component_trigger, + snd_soc_pcm_dai_trigger, + }, + [SND_SOC_TRIGGER_ORDER_LDC] = { + snd_soc_link_trigger, + snd_soc_pcm_dai_trigger, + snd_soc_pcm_component_trigger, + }, +}; + static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) { struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); struct snd_soc_component *component; - int ret = -EINVAL, _ret = 0, start_dma_last = 0, i; + int ret = 0, r = 0, i; int rollback = 0; + int start = 0, stop = 0; + /* + * select START/STOP sequence + */ + for_each_rtd_components(rtd, i, component) { + if (component->driver->trigger_start) + start = component->driver->trigger_start; + if (component->driver->trigger_stop) + stop = component->driver->trigger_stop; + } + if (rtd->dai_link->trigger_start) + start = rtd->dai_link->trigger_start; + if (rtd->dai_link->trigger_stop) + stop = rtd->dai_link->trigger_stop; + + if (start < 0 || start >= SND_SOC_TRIGGER_ORDER_MAX || + stop < 0 || stop >= SND_SOC_TRIGGER_ORDER_MAX) + return -EINVAL; + + /* REMOVE ME */ + for_each_rtd_components(rtd, i, component) { + if (component->driver->start_dma_last) { + start = SND_SOC_TRIGGER_ORDER_LDC; + break; + } + } + if (rtd->dai_link->stop_dma_first) + stop = SND_SOC_TRIGGER_ORDER_LDC; + + /* + * START + */ switch (cmd) { case SNDRV_PCM_TRIGGER_START: case SNDRV_PCM_TRIGGER_RESUME: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: - /* Do we need to start dma last? */ - for_each_rtd_components(rtd, i, component) { - if (component->driver->start_dma_last) { - start_dma_last = 1; + for (i = 0; i < TRIGGER_MAX; i++) { + r = trigger[start][i](substream, cmd, 0); + if (r < 0) break; - } - } - - ret = snd_soc_link_trigger(substream, cmd, 0); - if (ret < 0) - goto start_err; - - if (start_dma_last) { - ret = snd_soc_pcm_dai_trigger(substream, cmd, 0); - if (ret < 0) - goto start_err; - - ret = snd_soc_pcm_component_trigger(substream, cmd, 0); - } else { - ret = snd_soc_pcm_component_trigger(substream, cmd, 0); - if (ret < 0) - goto start_err; - - ret = snd_soc_pcm_dai_trigger(substream, cmd, 0); } -start_err: - if (ret < 0) - rollback = 1; } - if (rollback) { - _ret = ret; + /* + * Rollback if START failed + * find correspond STOP command + */ + if (r < 0) { + rollback = 1; + ret = r; switch (cmd) { case SNDRV_PCM_TRIGGER_START: cmd = SNDRV_PCM_TRIGGER_STOP; @@ -1127,34 +1155,20 @@ static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) } } + /* + * STOP + */ switch (cmd) { case SNDRV_PCM_TRIGGER_STOP: case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: - if (rtd->dai_link->stop_dma_first) { - ret = snd_soc_pcm_component_trigger(substream, cmd, rollback); - if (ret < 0) - break; - - ret = snd_soc_pcm_dai_trigger(substream, cmd, rollback); - if (ret < 0) - break; - } else { - ret = snd_soc_pcm_dai_trigger(substream, cmd, rollback); - if (ret < 0) - break; - - ret = snd_soc_pcm_component_trigger(substream, cmd, rollback); - if (ret < 0) - break; + for (i = TRIGGER_MAX; i > 0; i--) { + r = trigger[stop][i - 1](substream, cmd, rollback); + if (r < 0) + ret = r; } - ret = snd_soc_link_trigger(substream, cmd, rollback); - break; } - if (_ret) - ret = _ret; - return ret; } From patchwork Thu Jun 8 06:48:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 691213 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7B48C7EE25 for ; Thu, 8 Jun 2023 06:50:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C37F03E8; Thu, 8 Jun 2023 08:49:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C37F03E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686207023; bh=2gkP1bzT4xJ2rTf7JzXA1Y91a/JG2KiC91KqxD2wmD8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=p/tmQ6E/k9+KUJMc7/6V7FhqXnTSnJS3eXXSLK62tXEMNHM9K1+xTWI6+4IhFO7Du ltGM3euX4p71KQevtw743AL+F2SrPulrTT3PB+i3zryUeD1M2aSyqUAe0kGN+mM+o6 wc0l7cl3mUQNsSsW2SpdMkjGeg/ftnAn+Sej0Sg8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D0963F80571; Thu, 8 Jun 2023 08:49:04 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 55AD8F80564; Thu, 8 Jun 2023 08:49:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 75B2CF80571; Thu, 8 Jun 2023 08:49:00 +0200 (CEST) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on2070e.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::70e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 15005F8055C for ; Thu, 8 Jun 2023 08:48:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 15005F8055C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=NnIrxed0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbHl3zJ0MzIUoGXyqGunjtCF36G5ndGFseOvF1GPxJ6/4J1uA7stTw+n+3hmSTl0IawAIcy1zkwX/YsSsdyw8xCPrT3ktFJPGe3IyK19PKwyBH7DE6XRfBlHXhS+dPY/c0zlOc57sfd/KtdTnWUqndNuRK+3DpMiVekoEesCwDNQMZjbfy1+Gb5tqzHgfGWeF7Vk/TztvkxBGKHMUyDCV7XptEa+9xErKmIPlOaq37m4Co0v+SjH5vNo66huRUWX20lyvZbs8c685rg/0ZWZkMK5WQl7ofjt2OX3R5tjr/S0dwDe6JwIGv5IgV+/QnT6Y2eo7/Y5haVTol2Aja2zOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uSMB4Ecq9DAlKwApwYjZ37teSY3Ze/sy8W3Y3UTaGBM=; b=lhp37EFNDwQKY4bk2Trq+zju/jjvcJhd0P98jY/Flr78d58UDYCBrln72UIqYK8Hc3X9QY3fjDc7YmdTU4cpxlLG0Wz2zsYgcY0Wv5j2WI7VIZx2gL1W9jL233W+3Q+CrQJ0rZTTR/Haa3Fxu8S0R0ktqqdAFL2etAZ/2yuWc+m0qpoMY/CGffIRJir2BHleuf2Mwcl316XVT469rhk+WuBljCI3iL23+NFgMGp1hzfMfCSzber+coDZkDtgHYDVWMHnsXa/meAVNOGVE5kILZjqx9+aNt38ppZNxI3YhbEa9yhiWgNGEd+qVCOmq0JULu4CwVD7WrxncI+Hzyf/jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uSMB4Ecq9DAlKwApwYjZ37teSY3Ze/sy8W3Y3UTaGBM=; b=NnIrxed0CCnl8vDYqf4xZxv33rMCoAoNQ7c+qS1rcXjoIRbIGSLfWOpYvDxtfeTNntAHpswIRftAHyHSjc6zuKyHEdzD9jfSJczv4QCoc9omSvzEaW52hD41SR6G0SVoF+o8uxtC4hgo2oxlUl+xc3BrCzToZnNp3ja1Cz6b0nk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by OS3PR01MB9300.jpnprd01.prod.outlook.com (2603:1096:604:1cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 8 Jun 2023 06:48:50 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%6]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 06:48:51 +0000 Message-ID: <87pm66fnzi.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai , Vijendar Mukunda Cc: alsa-devel@alsa-project.org Subject: [PATCH v2 2/5] ASoC: amd: use use new trigger ordering method User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> References: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> Date: Thu, 8 Jun 2023 06:48:51 +0000 X-ClientProxiedBy: TYCP286CA0218.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c5::17) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|OS3PR01MB9300:EE_ X-MS-Office365-Filtering-Correlation-Id: dff642ed-7b92-4f2e-f248-08db67ec6b81 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W1M+IsK/t0bb6B6/lw2QGUI9Gfq6YQnniwLZY15YMAFfDZ59IqUwo8S8RdanEnCdjYbQgpQjvGYW3U1SiVQffWls2Y3Vph8XyIcVNHtFf1MVAWLw2SMbFx2+zjDim9hNpnHjtbMrBktPKVX9c6sAwNxV2twIFvSw+6wroU/dLShHw6qKCwPs1vxLogg8uszmzT9xEA7rLe/0m9xqxqz01XK7/aJA4un6hf0uhgABx2RD0Uv8RoTRjoLZba6o5x/9QuGPG3HhXNOAD60ZzL3FzJ4lRP4H5P4iuBTvEBVeUOudLsGsQxclBPOO6fErczSMD1kLW2vOuxO4hxGC39madjzPCcJS5XJga62fQ8HmbxoEfDps74+9zaNQXlMuNmLpkJIPMaSQk6HQYlQTLDC8L0RKoJms2N1tPUUSPM+AjUboY2GZjaQVgELZy72A4h1JZpG11EFjSj7Y6SAKJlVuQo8Hf7HH1l3PUX/wVz6rl4a59nCXUl4Za0ZJ/nrV/3RYvhpF/K3HoFVuCo7nPIuUFwytO01T+KwyX2gNeoXXSuGcR14z3Cm5sPArYWMt0dOTY8zLz6qwwXBHBkFqME2ByT/OpUaPIRclCDhErt6tPJ3bHOuHidDBRbxI0NQmdBVa X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3PR01MB8426.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199021)(41300700001)(8676002)(4326008)(66556008)(66476007)(8936002)(66946007)(110136005)(5660300002)(316002)(2906002)(478600001)(38100700002)(6512007)(6506007)(86362001)(26005)(38350700002)(186003)(36756003)(52116002)(6486002)(83380400001)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: h30uB7k2jox6tZ9xrMr1DTX0mQ33NkWHCm656bu/8v/UdGEbE2g0OC2bQIFhDQr61VCLwEOixW+kXjNlbiaG2+QHhBgbObj1SAiGX9eOVd7TmyaTEiUygIilMZzQdJ21klh6za7MrNaZgFDmrOsm9FVfUWh+dqwwoHh04D4VzNG94u4ThkDkrEjuEZb+gNFHVZLeKryDCMpgafDmeOwhGh7dWMvgYmJXcgNRZOK35HhcBdhffHAMGPgnd96QRgSWmPSev18QzYhKjKfYPOVpGWvro9PlKwKWQyXdrR8x5D5+h7eLhrhTqbTJTr4AoL0BDfIMk+a90SDkSOVYEd1B6ptb2nQmD+Uns/1oL89+N3ex0AMpvjqEs0Qutus9ABx5EjXebK/Vmsu5PwEY9dGZQNJ5wtdEaYQ8Tbfuyt9X/WFKwNs6V60NMJJsk6Qc2N9+503A2YaYIJyTH94QI7dnaPsFRd3V6S+jnVyIBeCwv934MYkRnLTV/gX+DhJUmwSoyoo/3llrPrMgvb9YM4DsDw73WUNZeNGv4Li1Y4eGjYBtoreKr0d96px1x8Bi2ppLVY0zvg8pOtVlJZqO0fvNo0D94pXpE36H26y/tAIpAgYIIwaAATJ5b2HmdEYl+RriXYtEtfZ6qE5qra7gpdCyyc2Vw0ksBCSfeotwDI+pvfKkvwKvigsD/IO2jPkUXSYWOHiFT2y/gx4rFHUbKcwQjsGT25QZ3TWQ6chIFjc38n/CdV74qkmxntTgxf5cLrfUmmGXqmgs5Y9U1omRvjigr13fBBO1Tk6KwVcnnrWRZoAWThXhNAOtBvYJVvjHuFhuzUsrWixn19OPlAML179/dTU12q0jVuSL6b3sf6P5a1dlgle5t95RqNl4FJ+/xcv69bgWIPQrq8nfTeuICxJ5Vnmhe7ikhYnhX4B51jyB7omo5r4uwZL4EuHG4Gf55J16nALwfZ4cYrHw27H0A5ioKfq7jMcBgNMa/aviBpwiOFkyeTR+Nln3BK+FAAk6spqLpC5TGwVdSDw3pC8x0zHg2Ta50mNF+xSkZesQMJSC8cIcDaa1xf+v0kBedJ3HvdduMqLGKl+czKVwu/pGZ4Yy2CKiwVGdZmsA3f33TCbt6N6FfMUAfz11FGTTsRQ4qGIqly4Nehb185VtHJpb1I6jwOV9Q9hbkT2/jt9k1N3vxCLOLc76PxDXv1Y5AT5fpFQ5UgjBaryo0+z03cdbUVD7jk7niG4DWxq4HqMcfxqy5T65kEUAz5IOGeiM6Es0SBczOg+JOMFuTxzBEB3dGVRqyJANtLpMNG0YD03iTCmaNhQuvUfz359YEpsoLlXLqAJJmifTKTE8p/wxt7brPij7cZl/Lx3EeD3fGkguy2HYMaPRAj/ojAP0viq6DinY6X7WJNkaF5+GQo55x3XQDN2dvt7wjDx31oHWMm8haCZs5bcCXhyrgVcoegMZ8PmWXX7IHvlqOvihqmHNbzlQhXdI3ymPrzXlTAY0GSBO5jzmfwqNrWgt+7XmcSzcyCKWQohkcGMk0XtBZrZpfuWc1lR4eJZJnIHeysSOoJ9ejHTvz3Ei06hb6IIO54vNLEY0EiKfGG9jbNgx2lU2VZ30B/2aMLkiAbJMiwN6Tr+jao474Uc= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: dff642ed-7b92-4f2e-f248-08db67ec6b81 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 06:48:51.7523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ver20Fg5a0bFvR8EK7yk2x7VMdjPePRUjdcBopQugTgfEiwgD4B8jNGarXLzwdaPXr+m0xMVEHKcqJHLIInLJUAEdz4G3syTcdgtXxL/Asjg1bnm+h35AKKp3H/8oSho X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB9300 Message-ID-Hash: UZR45B4PFTCZ7B2VRZQWNHH6YUXNUGSP X-Message-ID-Hash: UZR45B4PFTCZ7B2VRZQWNHH6YUXNUGSP X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ASoC is now supporting generic trigger ordering method. This patch switch to use it. Signed-off-by: Kuninori Morimoto --- sound/soc/amd/acp-da7219-max98357a.c | 20 ++++++++++---------- sound/soc/amd/acp-es8336.c | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index 375417bd7d6e..7464ca2b596c 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -524,7 +524,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { | SND_SOC_DAIFMT_CBP_CFP, .init = cz_da7219_init, .dpcm_playback = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_da7219_play_ops, SND_SOC_DAILINK_REG(designware1, dlgs, platform), }, @@ -534,7 +534,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_da7219_cap_ops, SND_SOC_DAILINK_REG(designware2, dlgs, platform), }, @@ -544,7 +544,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_playback = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_max_play_ops, SND_SOC_DAILINK_REG(designware3, mx, platform), }, @@ -555,7 +555,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_dmic0_cap_ops, SND_SOC_DAILINK_REG(designware3, adau, platform), }, @@ -566,7 +566,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_dmic1_cap_ops, SND_SOC_DAILINK_REG(designware2, adau, platform), }, @@ -580,7 +580,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { | SND_SOC_DAIFMT_CBP_CFP, .init = cz_rt5682_init, .dpcm_playback = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_play_ops, SND_SOC_DAILINK_REG(designware1, rt5682, platform), }, @@ -590,7 +590,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_cap_ops, SND_SOC_DAILINK_REG(designware2, rt5682, platform), }, @@ -600,7 +600,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_playback = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_max_play_ops, SND_SOC_DAILINK_REG(designware3, mx, platform), }, @@ -611,7 +611,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_dmic0_cap_ops, SND_SOC_DAILINK_REG(designware3, adau, platform), }, @@ -622,7 +622,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_dmic1_cap_ops, SND_SOC_DAILINK_REG(designware2, adau, platform), }, diff --git a/sound/soc/amd/acp-es8336.c b/sound/soc/amd/acp-es8336.c index 89499542c803..5e56d3a53be7 100644 --- a/sound/soc/amd/acp-es8336.c +++ b/sound/soc/amd/acp-es8336.c @@ -149,7 +149,7 @@ static struct snd_soc_dai_link st_dai_es8336[] = { .stream_name = "ES8336 HiFi Play", .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .dpcm_capture = 1, .dpcm_playback = 1, .init = st_es8336_init, From patchwork Thu Jun 8 06:48:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 690541 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EB2FC7EE23 for ; Thu, 8 Jun 2023 06:50:45 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D211874C; Thu, 8 Jun 2023 08:49:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D211874C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686207042; bh=JedLMgsuGpKvPbjClm2qG1ONH+8KFgsXrg1AGmJDWRY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=idSKZCj6syPdH2wScquJtH+nE4h8BZVawOeAlIc9xkHZZh3br+CULT+K+JF0Epc9n QTwFBxj1whtlU9Va7bRvHO/zP7WHAYX8KYfY8vjn3s2unxXJ22BiSW0Q6NbZPGIX6B ntQpmMDYwDQSxCgkcVMtR0fEzBRGxVZaTxdkYpiY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 81571F805A0; Thu, 8 Jun 2023 08:49:06 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id BCF06F8057F; Thu, 8 Jun 2023 08:49:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 014A6F80564; Thu, 8 Jun 2023 08:49:01 +0200 (CEST) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on2070e.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::70e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 42CF3F800ED for ; Thu, 8 Jun 2023 08:48:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 42CF3F800ED Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=Khr5i88O ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/daMGqA5CKPt3+T7oi8b0UFzedmBH3lKkv2dHO5LB5WsGUa/3vfNiaF6W1Ahpmf+KcU21V+J43KBU6+/sUy4PSdD9lWos1tHuKVEfCraCqghL0/8eQB5H3+Kgic/M4U736Z6FlvHs17s/ZstM3+oE7YSX1o/96tkIK/bPN4+DaiTLE8YAjiYJjMDiN0/+ZfPPgOK6btxXFBX/Tw0705YpTddrucewdY2K9fbfdatnm8OqceCM8ImsHD/sc1MPPNzIgzbfQHnMniX942pb2o2qDQwhc253CIYLiYBwvFlXwmyiGP8X0hfjsaw3NbrYtarGE+yfRBPmDqsT9n2VtDlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2fLC9GCw6jiHc6GwdV2jQ+7O1ASraTYwwsIlAvCeFTA=; b=Bctw9AyYE+6rHYG/RTZOyboC+U+NcQHnLc3Ge9M2eDrs1UMSnVjm9ko2fRVGfWELf1x5RBnDyOgievu1pG9HNnFfnwtDGrkSlcH7MvE4nNM+hoyOL+zhrquXO2lGn+GGoOl4sipWPCe6Ji/HQZGqzb2nM12F2MTafa1LQoNnqrfvRQhyfJHUhlJIqxfdYVZKQ9h2H9/0KmpZEb+o11nYrOGmuUk/XwpWCKJziVsY9kE/PNBoMl/VYOpB7DBNVCf9nVTulJY4WpPtdjilM/kwFCT2v0uVusXux42BVTs4cIusBVyY5XceXJMS906i439ER+9tMy/lj/ooKXWlBf5UPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2fLC9GCw6jiHc6GwdV2jQ+7O1ASraTYwwsIlAvCeFTA=; b=Khr5i88O7R2Gb/DzWwAhgc/erCWKg0h8WUMvcjL00VjIVRw94wHFVJ+PcJ57ekDF7wYgf/P57LJQmxWUCpGF6MZeRV59nuy4DMxQA+RI/alTFO8qsmMJOX+qPFNAN/+nX8jCh+xIK8oQ0tQFiwAPklLmD4FVbZjVO3bx7zUffOY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by OS3PR01MB9300.jpnprd01.prod.outlook.com (2603:1096:604:1cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 8 Jun 2023 06:48:57 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%6]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 06:48:58 +0000 Message-ID: <87o7lqfnzb.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Alexandre Belloni , Claudiu Beznea , Jaroslav Kysela , Liam Girdwood , Mark Brown , Nicolas Ferre , Takashi Iwai Cc: alsa-devel@alsa-project.org Subject: [PATCH v2 3/5] ASoC: atmel: use use new trigger ordering method User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> References: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> Date: Thu, 8 Jun 2023 06:48:58 +0000 X-ClientProxiedBy: TYCPR01CA0096.jpnprd01.prod.outlook.com (2603:1096:405:3::36) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|OS3PR01MB9300:EE_ X-MS-Office365-Filtering-Correlation-Id: 17a7bf72-ce0c-4d5c-9b42-08db67ec6f80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EPt95toJhX+Alc1yCTSHk6AXBaewrqwnx5FlxyJXUJuK85wSkxT4bGsmF2hpf3rfH2/T4Cv078VfyuU+5zYopl4pKMJ6JXsk80DevAHmRBSRU02QIgFFdypi/bKtkynXW4V/0k73Q4yux9NkEA5UTWE+s8E2aNFPRSqakhstAa4cm+DK73p9TM7KuaUJVgHn3Dl2JGxhXnJx4qAyVoean8OaoRUFsE+05lAF/raD/WwoJziZyMBUoMB4859zqFcepwumZXpQ1woliaze378x88RjK8tzVX2MuLR2R1dJRxc8svOx30F0ky/Nve0W3jbZyjS5+MVOPnvo6JPWskbBNx0v7mQm9nQmg/0GA9bNcTjQ4lvWVP68hTdSDQfRue+QEDbcdyhVkiCRvID/8tNQ+cyOrztw+YpOrf2tOHg8QZmZOZ5SD/HrF1xiEnVyTK3xtaWcgtgyO6C6STJWCARAiN96hAmCqJ5P9XRmjda5xokiUTYpom9cq3HdrRgyOdvm+7jPY71InIfGZ9eyLyc9cJnj7IArg1dOOSj4493z9qaARbMGXHqzvRZ73c0pgaRaUGC5GfpcnaLx2t57keFzTWTGeos59la/PTO64Ztj80r52moRBh0BEzuk32uW+pPa X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3PR01MB8426.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199021)(41300700001)(8676002)(4326008)(66556008)(66476007)(8936002)(66946007)(110136005)(5660300002)(316002)(2906002)(4744005)(478600001)(38100700002)(6512007)(6506007)(86362001)(26005)(38350700002)(186003)(36756003)(52116002)(6486002)(83380400001)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: brmjGNhOOKkdWd6z9md9Lb8pYAcmpXLpGbA2JUUc+cEFBT5jxZD2yQoQuIeyMP06oz0WjBHw6tznzgcErq4Iejgx3BIU0oTGa2IuftMrM+xKX6B1DVj9troivdKjB5J11P2huko4vt8Gnke9MNBB4THYq7rjicBw8ZFERyqA/rq6I1HXEUS8IYYg0sams1y3xQZMZjBORTO4kv43JxEcwzLMfAOYnEGKXbr7mTP2IFyYuH3DEZrVvzMljUPBO57DI7qLz48VeOdozvuo/4BYOE1wnOkjK7AeQk0FCgAdNSgPfgwwrRFPNR3GATe+zZnUbpsh3XPtmuYY+PPVvNmRt8hQ30YdJwpCZLupXUNFnCjMdgYu6j9v/c1v9F6jhLUS6TE6Nrob+zuvIKfba0yDCowYMYjNyre/f82gUR9kPNnbbO/IptSTUgod9Y4H1/WlAOshHhjkIFmP4d1RzlQLw/XXVVwHGhBrQcc+uVcXpebDMeCy2DD1T6+hxxHOIpEANhgdhJa7NKM0OpX+oLscLY+F56WhBrTKMdeq0x6kjnErqTBOcEWkV1XvmodAT/5duJvr/DNIFqG+F5ufLWa+dk7X/XhVXT0mdn/jXT9TExgw8Z6OplrOcwoJCOK5tQ1tmdY73L60sJkBBeVLcQGcHmQJ96DlR5SGnXWcI02RFbYZ86OsJ5IxFT3Kt4eoJhy130MsR5gJ7oNCzKRD95OQrdksTERbBRUHPu50NM8OE//6rK6nuJ6UCE0cotQturY7BtbIXYFMyk5a75TE/Ua4rSZesrguiF7dczdX96XFLPGDNmodJbHCBaRNX5vtYe3LYKia1ncWDSb6uMIiXlqE6WDsoxxVNnUsGo8bZeuhz1msGuqtcawBgQLcPKKdpy9msrqbBal8Fj5cuMgMX4QmMl2by9o9eB2mzdxbXna1bhqtnaG7J6RG6HV8LAL7Q61G4lk/VjdDS8dfRgBCfyuqejpxJWGnad0VbLtFIE+49xdz6+baV/uewL2YJdcIQr0BS1SptwfTONnwHNbcD/eX1d/J/pw5HaTtOgf0HdOo+nBian9leME0+VpiAj/Od1XdxTB+lZcI7HjKmjJ51TCWl4/Xc3R8BlDCaRs9Wq2KUd1WYfFd5B3Ejj7UgcLTN0MAdQZcqPTrE6dMu0z4UVSKu9ZGDI24SJSFWaPXMF70dZQ57cCquCFd750RvMrAXII9dzwBq0UFYghxxhPPEZj5HIjqPAG27qYiirLql6pGLMpw3vhx3Vta3G5AHaGRFqfcCEJQ648CP3gMSgrlpcIxW2ysza5n5kJ7Ua9bH/P+g1SFSjBMTGDJGHTNiwPbA7HusNpGagJEXhgSI89bTCBQMorLXI8qOyBIK0LlEhuOtYSBYI9NZwxIlXjQIksIIUmr2W6o6inYBSLCI9KQupfg6yRiXtCeZu+oAP8plHfQ9RswVbe37Q4Ah7hudeh1AjQkwEIaenLFJhTqyk6XtsDWiMLxIRjbyh8qRaoA7XqXC4KSkMLdMx2UAoWXvtWJzzXUOIP0FvfJWyaIXW31FXlBBc3ZaUKpgyD4BykMoO6oRDou/r26SfREILHExhwc6Vk3yOBkqSwc1EH9LjU4Ew98WrGZi8Zf+F73Dx54Kd8cDAM= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17a7bf72-ce0c-4d5c-9b42-08db67ec6f80 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 06:48:58.4604 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PJGgbBa82q/XnAKVUZNbb2ZRKlA5VfuD1wkarC44degkXvAB1ALEoHzsK8o+YpV9gATbGftuIdvGmAvZuyiw7HCIWkV4KNGVOzn1/tgY+Bp2Nl+AflkG70rzVJEbpdn2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB9300 Message-ID-Hash: SMFF7WUJVEUTD5VNJIAS6JXMRWAMT6SB X-Message-ID-Hash: SMFF7WUJVEUTD5VNJIAS6JXMRWAMT6SB X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ASoC is now supporting generic trigger ordering method. This patch switch to use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Claudiu Beznea Tested-by: Claudiu Beznea --- sound/soc/atmel/mchp-pdmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c index da23855a0e40..c79c73e6791e 100644 --- a/sound/soc/atmel/mchp-pdmc.c +++ b/sound/soc/atmel/mchp-pdmc.c @@ -423,7 +423,7 @@ static const struct snd_soc_component_driver mchp_pdmc_dai_component = { .open = &mchp_pdmc_open, .close = &mchp_pdmc_close, .legacy_dai_naming = 1, - .start_dma_last = 1, + .trigger_start = SND_SOC_TRIGGER_ORDER_LDC, }; static const unsigned int mchp_pdmc_1mic[] = {1}; From patchwork Thu Jun 8 06:49:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 691212 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC9CFC7EE23 for ; Thu, 8 Jun 2023 06:51:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 92726846; Thu, 8 Jun 2023 08:50:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 92726846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686207066; bh=q4P+NsLb/c0lnXYU+z9HZ/DfNFXn+6KEgAJ8+ZVMqtk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=qWnMsJriBIihy+DVd31cwN7kbkZS1tmZWovW5HUwXU1eRsop8NleqdelH7MkHpT0y xYuoZESiF8jxoMsLamJFJ8kOjD07N2XKto9vu8v0HmlglA573lefeFKu0viytPx3LM lQtGn37Ys4qU47a8adyQKA7xOIDnbN2Z+5PsB7Oo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C6DC8F805AC; Thu, 8 Jun 2023 08:49:15 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1E767F805A8; Thu, 8 Jun 2023 08:49:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3C274F805A8; Thu, 8 Jun 2023 08:49:12 +0200 (CEST) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01on20707.outbound.protection.outlook.com [IPv6:2a01:111:f403:700c::707]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6FD49F8058C for ; Thu, 8 Jun 2023 08:49:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6FD49F8058C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=EWhV+0cj ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=INqvgNjexRHr9Ew61rXkOIBr4IrEikrZYuulMwvvsh/5uBkMxNWDyb/Ht/WpFbQCH0C34r7wdR2xoYV+NGpCihdK6YXB89oawmdg6D4LL7LsaBi73TifezHR4WS6TEZkj6uNT76SLuXYdTGYRlo+lTU0KgZAj5x66s9GmLYQ/J+sp32i7S1RmFVUv9r0TvrfPfOHzDu7KetXVYMajuaN/TxaOCqyl8/95mhK+v1WnAZf8O8QUTdqLvW+GXUjhJ1b+C2nWDMizD9+xlq6sFpz02XrvC9ANx6UXKMMq6B8kGfe8PDv9+IkDE6T5pMzMRBz5bDP7I7pcGrIqSCWFBuhuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2eGlZ/vA/Aq8vSCJ1PnfCAJ6gKdI2REhaMBdsCpOLJY=; b=LsFISanj5ZH12cgGf44mlydYTQbhn/xJlBbCImLX0hZfZU4fShz0DjXpCg+tM/4ahf/iKmnGkWuHg3RnnhAQijms2RWhDdE6hzlbew4zZvc/6ou20TvVPG+uhAen0GzWdsMLjcz+RKfJDP8URtNGVCILywbB7PbcMJ/jENOFJfr2j1qO/q3l8Do5wnrv9cEV8SmNS9rp6fZAL6rDWjfjnIyw0MD+RB81w/oCjFjGjMoDH72SISR7v/REAsvHTgB4U0Dgc2xrY+eYGrkFezJiAE0esnADt2QMCUSdv08dLSrvbeZBOev5zV5XnzmfZfXkX1KZbWNguvh4+GX7M+kJSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2eGlZ/vA/Aq8vSCJ1PnfCAJ6gKdI2REhaMBdsCpOLJY=; b=EWhV+0cjEpn2zJPkZg6ugCx0PnSSiaVsnL25N0vHyru9CIcCnBqIiCj8wCFsrUgvu9EgGYYFBxYn8PwqUsG9QYg5Ofby0EjwwwtCsSKZ08WuHGVCs58c7TO3CPVCaExhSrN3liTOQwAuQkYejTNu2iM6zfhAyvMm/MbxX7WO1+4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by OS3PR01MB9300.jpnprd01.prod.outlook.com (2603:1096:604:1cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 8 Jun 2023 06:49:03 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%6]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 06:49:04 +0000 Message-ID: <87mt1afnz5.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai , Walker Chen Cc: alsa-devel@alsa-project.org Subject: [PATCH v2 4/5] ASoC: starfive: use use new trigger ordering method User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> References: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> Date: Thu, 8 Jun 2023 06:49:04 +0000 X-ClientProxiedBy: TYCP286CA0039.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29d::13) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|OS3PR01MB9300:EE_ X-MS-Office365-Filtering-Correlation-Id: e122f29a-deb0-49c5-f915-08db67ec7351 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8bW0PmlLc/QzObiWsTRM4yFt1qnqG/VBtSrXEwi/DLUbVhOLmWFhf3Ne0hZcQH2ZOCyZGJ30FEhbDdr0NUWJRDqK7ZSR8c6eP0j1t1JMsSBl39TPJzTssjQLgt/nWAuOtngUZa5t+R0fmyAmhGxF+RkvDr1WMQPZHzj2OfenRvwZ2WdjI4+T0QFTlZ2Uq7RYcdjhvfm1tR00bNUyUQPJR9g2vOVAD2BH/HQJmXLFSguQqTmWLZnjgokCiO90Sw6DWAL1mfpDHV86VS8B6hY9XXF21p6SoAJ0OQS5KkWnmaG2dvM+OLrY3IGkoArWL9EuHxgvb4i2QX/pW0TPqo/HBE/otZyXJgjFCQ7wiOTdGac3/jxwHQjIFI/rNnkTHoLX0Urm8s1BjOk5Y9sD9BUnZKVLV3PIPdG65lRJtJGu5RawrPgscarCiesRLOfeqM0XZqZod/clu/Gj80YV7IpS5ER4J9IPC80ACNWCKIdvTyw4S/N73RFB++W42HGU1JBwH6S8suJVyitKcV6lkoGLBRvLBUGGluQCalOrNTzY5S4aqK6dNfh6Hl5EeE1ntCnrUrOGb+47HTNT2ieUp0fs1K8fKuX0xkKU/bQgfH2wI+G4sl+AoE585Gkp/w07vHuI X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3PR01MB8426.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199021)(41300700001)(8676002)(4326008)(66556008)(66476007)(8936002)(66946007)(110136005)(5660300002)(316002)(2906002)(4744005)(478600001)(38100700002)(6512007)(6506007)(86362001)(26005)(38350700002)(186003)(36756003)(52116002)(6486002)(83380400001)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TFlRWOjGFVuT4QFUBZcoib/4rXDOBHeXAlXJrS2qY6IkgIU6c33mZUPwcZRfwppA+2+htzy3L9Dl3ALhVhG7dm4G98bwTQsv7XTCoQVrbz16qNH/UVacZ2ewZCUbR7meINMNCnNiY2rn6GnX+9jzt+k5VSZIfkfCVrAmX8SZ8SRc4EZyXS03bKDkT/EkhwUJjjyit7vlS4Tfz5fGBh+g1roPD5sQ6KKcyLQxcnhcFv5mFwzy9kufKrvmcG2btsBm7weJY+uiXzsKoQq3ynLiZULJ0f5yneCXJBn/yiXnKNFhU3IzQiv+jqmIOgsISYqrg5qL/zLfY8aENM3oMNVft+pMUIr/zYeZkAI3T11LW0qGAFziIE73Oxk2QNkiUyyMz30N12+PijNTqqJzSe/RRWN7BxyVf3QTbPCuGeaKUbDEuLPJyNKqz/65ZO0JlpTq2s1GOob3bJM7oM7bHMctoW0yaQSVY3pw2Rplcf4td/QWTCh4sFOF5n3MmzwX5vXNwdS8FKzpEPSEmmAG6yZVQnJdpIqpaLwcwFstetbuD1O/uwdB5rt081eNPL0r9iyBK92Kcx/f3aUm/ucullQOMms3Hbb4H7vuTfZEZX8CT9zXv2buin9nrGNeZxw17pVjieE4Q1nbCb34XBEqQLsLlsY51EJVbX5xH0XrcHCiRUCekf/hoOnmkElLX7v5YLbGKA9y0Aab7IBgwJq+NbZ4cjheLSbQeml1+06jdvpDscsn5PIAwge//FbyG9uuRpy6WrXs06Gures8zj+HLaIJ9Fury1bCARpqnDedr+53WPFvZ0d/dYEQWBkPmVyvvUcu59AlViiKhd26X6eW0uo3+bP2gQoBunpvepC7lZx6hgtJGQkGDWqxgXj/Fxa2Emy9nlWjpPS1A73fSXFYfWWPCeVmSrFG1Cqu69p5FEfgwkLwYOBuZIJ7zsHc26InmWG9MfA9n/O0Pu0Tgb5OixHpmbeSdBanksb3qY+V/d47z8KXTa6Qra0MdrDoTrzLfW5H7CQaB/UNXwIkZv8h3qvMnODz3LN4ur6jNsqi9LWZKzfw+pStCFTammZX4YI7hBW4LC5B9eKL83kkBE9cw0gPMDKl8smJDJP82/g8lLHjryj15wv1sx50V9C6zJYP9/hHfFCRdxLNM0YKWWgyHKTfeKjshk/XrnddgjlH5aQxrUxmj9BRsL4abqMU+P9nhZ1rwS6x/cac5uNIQ8MqtkCA99OE8tHSLPEfCANDq0V9s09+e6pWag1ZQA8dJJkqpsSDlRQXqtUPGAZUtJvyamI1FlzvFeRmAvltVpdrfm1ymb5znmjjlXKy4R2niW8mN3WoYOB8kAkng36d45fi6CYr18zAWjCDenECVUDIJ5JSzzX3bMXp0T0flq7R0MEghxUjFACgKLdv2Ulo2BbQtqZImZUGwjL32u+0WcO/dKjFnJwXiejizaDJPzY0Yt4HIb9wAcy7/HQ4v2tXGlSHrVvSKHPRdRLBI79t9eK+rF7qTGwnzCO2aDj4lw+LrXyMOjf+Vexm75lTHTbJCIS/nzmZqIWHB64zY86A+/0nr6suPN4K7wAp051IuP9OAToz7ATLtoRAKURhZJMbsYBhFEjpz4U22jMWecxTTtSh+eofz8c= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: e122f29a-deb0-49c5-f915-08db67ec7351 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 06:49:04.8657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EB4yeqnnZ5odAoZ/0DjNlveODmgoQX23MJmOriHvd/07RrN5vDzHJmZiAGzcy6aC+TpFWCiXkE9ZZlTIOHxtsX8ekkWYq50tTB5MHvIKBDYr4b9MjycHHP7mssEFIb23 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB9300 Message-ID-Hash: KHHZGUFVUZAQITU7ZFD3MBJHDGFXURO3 X-Message-ID-Hash: KHHZGUFVUZAQITU7ZFD3MBJHDGFXURO3 X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ASoC is now supporting generic trigger ordering method. This patch switch to use it. Signed-off-by: Kuninori Morimoto --- sound/soc/starfive/jh7110_tdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/starfive/jh7110_tdm.c b/sound/soc/starfive/jh7110_tdm.c index 973b910d2d3e..c4cf347b5229 100644 --- a/sound/soc/starfive/jh7110_tdm.c +++ b/sound/soc/starfive/jh7110_tdm.c @@ -336,7 +336,7 @@ static int jh7110_tdm_startup(struct snd_pcm_substream *substream, struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); struct snd_soc_dai_link *dai_link = rtd->dai_link; - dai_link->stop_dma_first = 1; + dai_link->trigger_stop = SND_SOC_TRIGGER_ORDER_LDC; return 0; } From patchwork Thu Jun 8 06:49:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 690540 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11D8CC7EE23 for ; Thu, 8 Jun 2023 06:51:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AE5D484A; Thu, 8 Jun 2023 08:50:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AE5D484A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686207071; bh=1nOFaW0Fu199oPgODN+yetNgIo6WGftlFqrbEzfF090=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ame23kLR4vwuHu1p8XqhF9GJebrMQjFSckBlgB0JYJLFHmrw+VOFDl8p8ipK1alm4 RFnMGVUh0YMcTzXht2jLu22jvJcYgJemiLTcIfvkR7UawYPFOLrx8cMV2jAuuFymgY sJ4zrnerrdzCU44KjoEIhvlHnEipyc6ANwzjzmk0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E39B5F805AF; Thu, 8 Jun 2023 08:49:18 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 692D8F805B0; Thu, 8 Jun 2023 08:49:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0B5E8F805A8; Thu, 8 Jun 2023 08:49:14 +0200 (CEST) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01on20707.outbound.protection.outlook.com [IPv6:2a01:111:f403:700c::707]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A5281F8058C for ; Thu, 8 Jun 2023 08:49:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A5281F8058C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=m8S4cthL ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c6beWdThYQRd9KGRbrCG7G/0DblN0rNb1VtT6q61mok+0TMIPhWMcbj97/l5xWWxSYvrcYFGBUEtmHStjCaZ4yi6+ECrb7/OUGzm4PLtBXIIIgG8g1obP0Lny/aWw78H+kpMZSGx/sGI0ciPGEI/+28bL8wGL3CHq1Bq8b3jnfhcE1SKv35XAIstRYiEwvUKT1Fc8CXJq0iPjdBeCiy/+qUSZik1XtZZf1K2sCRlgxiSf0XkiNbNlwewxHGgCJaukjYN6dQOqcqy2EA8yrFi9CJ7/QBvJG0DZ/kYWdbtP6iV3Su+qrg9agOK0GaFjIiHM1gQyc2iB/LnAQbXYyyonQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zpZCRgL1VfS8cYkHJvx6jZY/31YGIxV23swv8phq2WY=; b=UV7xafQe1CNLAB9mvhOlwlj/SZkiSfFH3IqUZBpE36VLEp0yWT3KcdrmUPQnha2oOm7eqdCucGLd/vr64Bt1Houq+IHsLb7ETC2IAaTsA8OcSrX7/+JNBgvFCLOl6mVmCV1zKrLxPrjS/PuuOEitF92Y9Ib9wUnrav1pug0Ebp8ZU9arw4+Bkz7AHAkuav66ZgdQBFvkstFpPYl65VGLoYj8SpEhYx0zFvuzRBn09kJ0BlzZauR7BiWiLYNwDImrjEpzVCF6rwZqywm48UWJ1bC7NZgDO0f9Gj8Vqp4YQnRhgMcEM6yhgnQe/jdj8v+QYe8FH9hvLGRW5IKqeNmlBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zpZCRgL1VfS8cYkHJvx6jZY/31YGIxV23swv8phq2WY=; b=m8S4cthLTTjrXJh8kW70lPcoIv4zvcBEG//N7hGDVJG/Nzi4ETSxILzfDeX+T0NEApWhSCsUSjx5Cn+wFAow0VBmuShgsQ5UWfyzdIrdRNCGMfzzhtZSsSjjo3egDD+LxI0Pe5gdUG0l5OCGTyGgzZWr1pKehu0kDwvMXxt/Fy8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by OS3PR01MB9300.jpnprd01.prod.outlook.com (2603:1096:604:1cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 8 Jun 2023 06:49:10 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%6]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 06:49:11 +0000 Message-ID: <87legufnyy.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: alsa-devel@alsa-project.org Subject: [PATCH v2 5/5] ASoC: remove old trigger ordering method User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> References: <87sfb2fo0d.wl-kuninori.morimoto.gx@renesas.com> Date: Thu, 8 Jun 2023 06:49:11 +0000 X-ClientProxiedBy: TYCP286CA0262.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:455::9) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|OS3PR01MB9300:EE_ X-MS-Office365-Filtering-Correlation-Id: 5eaab750-b0c0-4967-7d76-08db67ec772a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HuBC+dPXKhNUf5lR6EVYB+BngpMP2e6d15MiMNVSKAZFyTAv9n4kSlxDDiSQev+nzZ0sxttT+xPsOp9klxC11OoLF8QGaYVjxfEiJxd9oawCdm/aYnzIKl5dJaZoTxc71Q/yLLhvt5BA/xoppcE7XEJOEj9xXI2Ur94oMNztlT+xo5JCwxMzMtwCC3bEluZJyB+yPLCo6G7Qq0FugfA8WFvCGLXbBRDtQdlL21U791kI4sVWVtb1K5E4QyebWruYIUYwUbVxsAIK9GKRTqvQx4IXydpyKtSX8HpQtwcpRtZTtQD6UFDAhqrDlKVUFiFz2Y02IzyyEJVoxPgPCSh6097wPtPK8LOBKm0ZU04W0x1qED9UlEKoQbAuxFOPS+dHrBUI3gz7ODQSxadd5osyjJvX4AR160+d5/TbFqkHXTG93kquiFAQa81f8IbS+ELgxA6mCbD0s0dHzVhwGQct6IStFHTIsdx0nRd0c/ahcjqdwP6J0E/1+CfXw/Lq9jUvHavg2+GkSYhDzKVwAvc/HNnmr761l9omfjoxQ16TehX8MiR3bkmEzAOEoVYrcyLcm+/kggVwn7c7J+ucKEvMJpsHEfV5FZlKEoIHtOzhX5nIW2g2+R+C1/dz1pY+Irmr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3PR01MB8426.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199021)(41300700001)(8676002)(4326008)(66556008)(66476007)(8936002)(66946007)(110136005)(5660300002)(316002)(2906002)(478600001)(38100700002)(6512007)(6506007)(86362001)(26005)(38350700002)(186003)(36756003)(52116002)(6486002)(83380400001)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fu0Duk6ThbKDmaobXRZwEFsDDCd94bz5RDr4kRIgCJrubCUE5dpZ6ijVBQZHmzb5dD82FB5bZUmLDkfJvkcVhtjtpjAUeC3KLaQ2qbFuSnJciib/QYDruRMv/PAl/NPvBszwXTroFzdCoov3kLzySawGKxk9q0uY7pPAyGpVK8RoBp8uPoXhyWPM6eP2Lm/cYDP9nxn670acdtjPLGPDJ3wCIasPfbCUMF4pyFv9mSnyS5fNeasw1NNJcDRMmCiPu+coKAuJd77BDZF8YkrDNq6wWtHsZVDo9pfWRO8DPi9DQF4m7hiHlqvcyrpeF8jRGOuONFVdFm7AnHQEq+r2PDN3IqCau6YzS2EFXkNwz6gY+axRPc0oryJTZA1VDLONRChlMuUOWn9+wZ3uTvXRZ3XUd5+ycl9cv1bN7eIekc2AE4MoIx01gIYmtpcZSuCl/9zOxk8jhFS1SQTw2yAhmdkf1fweJfWVdLwLU0fLn1yP6V6RVJUNIyJ3Po7Pmvk2PrUb4HHxCFWto/WFzBtgs5friyCao/rAxRtpRRX0D7xYtvqiNZtRTc227BnjOvvTtmE+moLYu60rR4PsQucejJ2O8A4CIGXSiCaaiwvOyiM3MS9uZ0JLDzHr8lO64COGVsdyABg/U9PVeUffxMtIieeiR19f98yB86rqn/FOCrmIrjvTsrRPonWYlh8QgEom1A2nZaJXhOLOeoVBHUttOiSJJtewDjd1OX0bpdBsq6WwTW7ncqndGrkJ+u8RleU4gsrXcqPO1MVyuqnMO51XqXCvYsRpAHCnZPKEVVD1b3DklZeKlQR1oF2BRv7yrl7s0h8AjoBKm1isTEbIm11fpoVSCZkCu7VVxK57FO1vIaVQTK+TtxtIIPG3spiuFAWZDfW5qZCpAvvWofABHo3OffgiswOd92beicxaGo+wAeqbMWegd9EbefXMlQff4TbNDFvjC5j5eh77MRnkM5iznh8xjpG1KF0Jetf0m6N6stWE0W5HegeACVIulX/imp5a9+JWiEigPau8yuTRCuquBog70QIAZCXOigKetPfim2MCPhR7/QfAjLB2nN736FpXX1IVjGct6T1ob0wLmLGEnGNTxI1d1wnALALu0UAVfc3SrV8jv2hSEzkXSE7joh2Ns13S2s+Y5FGm9+WaQWLlTu85O4RLUnzDaZo8ra6oqdlL+Kg4a+a1Kg/LTrBGT8jyOmEr2whz+h4FRQlLhrql3VcgbfMN+V2wHjg4QEChFVrZqQiFJI25ZoWFwdWbBHSsXF96ke5SjiKUzJ7AaIgAA4MIaS9IHmLWgOpftoVZICQP6uc0HfNaJZtWYbrPAZRNSsW/q7k5Z8gWcOE0c/V7WHY9/kdE/6HHRab3FSGt7b145Vbw/Ir3Ehi6cXPGiU+r0RA/nGLAncOAU6MXV58oG5OryJKXaoFraY0Aw3IZdqFmaaPBgOlOWrEV+d8Lx31DfjQkyKwaG8ZpPvxA9IV8dyPWcD7hqz4GcmlrN3ObXxExamUvsOaHCcofWneVblEQwqt3FhI/sNqu6H+D1kBA8nB5MUiV4DjLSD1PZNM+XmY2Tm6Z/rueJUSNPa4/1yGKGVdkZJdW7XU+mDFKVpqCL8P7aqiHMS4y4kobM27qVnQ= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5eaab750-b0c0-4967-7d76-08db67ec772a X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 06:49:11.2998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 50qcNQ2afFMp5imNZcuQFNmQsMHEWbsyazeP2kZ9EC/oP1OranWXupni9CivPNALmzwxdsSiqXKvcHQHX+cgPRicHhHiBWAkE0sXaUNVeKEWPpfKXCySYExYcFX2IbKm X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB9300 Message-ID-Hash: FDFZRDS7WFKQ3HABEVCXALGIRG3TJBIK X-Message-ID-Hash: FDFZRDS7WFKQ3HABEVCXALGIRG3TJBIK X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: All drivers switch to use generic trigger ordering method. Let's remove old method. Signed-off-by: Kuninori Morimoto --- include/sound/soc-component.h | 2 -- include/sound/soc.h | 6 ------ sound/soc/soc-pcm.c | 10 ---------- 3 files changed, 18 deletions(-) diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h index c7733382757b..87f248a06271 100644 --- a/include/sound/soc-component.h +++ b/include/sound/soc-component.h @@ -199,8 +199,6 @@ struct snd_soc_component_driver { bool use_dai_pcm_id; /* use DAI link PCM ID as PCM device number */ int be_pcm_base; /* base device ID for all BE PCMs */ - unsigned int start_dma_last; - #ifdef CONFIG_DEBUG_FS const char *debugfs_prefix; #endif diff --git a/include/sound/soc.h b/include/sound/soc.h index 49442583d46d..52bb64d427f5 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -762,12 +762,6 @@ struct snd_soc_dai_link { /* Do not create a PCM for this DAI link (Backend link) */ unsigned int ignore:1; - /* This flag will reorder stop sequence. By enabling this flag - * DMA controller stop sequence will be invoked first followed by - * CPU DAI driver stop sequence - */ - unsigned int stop_dma_first:1; - #ifdef CONFIG_SND_SOC_TOPOLOGY struct snd_soc_dobj dobj; /* For topology */ #endif diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 40a75b3d0e9e..73860fe9b3a7 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1111,16 +1111,6 @@ static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) stop < 0 || stop >= SND_SOC_TRIGGER_ORDER_MAX) return -EINVAL; - /* REMOVE ME */ - for_each_rtd_components(rtd, i, component) { - if (component->driver->start_dma_last) { - start = SND_SOC_TRIGGER_ORDER_LDC; - break; - } - } - if (rtd->dai_link->stop_dma_first) - stop = SND_SOC_TRIGGER_ORDER_LDC; - /* * START */