From patchwork Fri Jun 9 08:15:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 691072 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1348C7EE2F for ; Fri, 9 Jun 2023 08:16:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238963AbjFIIQK (ORCPT ); Fri, 9 Jun 2023 04:16:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240079AbjFIIQI (ORCPT ); Fri, 9 Jun 2023 04:16:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80FBE1FEC; Fri, 9 Jun 2023 01:16:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E83561300; Fri, 9 Jun 2023 08:16:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 032BBC433D2; Fri, 9 Jun 2023 08:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686298566; bh=fhq7UqggYiVg/1COUBVntIvsMJLXIEfwBDhAv2lnM2Y=; h=From:To:Cc:Subject:Date:From; b=G28YEgrgn2lu1p5R3l5ckjxag/p3SQF3AL/dQ4H0P6yHYvymEjeqjKHwgbwZFshiN +DXRcLNePGWkV2wjJrnBHW0MM2SjvfQviBwCjzKym9TF3W1fFrDGOlsAIZf0oxG0X2 JduFSfbl4efpACPpq+1j3w3mxIgKZSwNXjF0npmmIhimGZ0oHhqqgwU0SUIuc6aqUY RpTDqVcnOHAALa+eJ96oS6nDhDofPv2I180Bg2Cgcr3lOvUH2USV88C7EKjrE1mQbF ZxENFHAnMcnAEwFfUFxp90ulbJWi+u/dGJqYWdRIYk8M4PBWi/UKr2msYHnMTexwws EfQr+wvYaOZzQ== From: Arnd Bergmann To: Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd Cc: Arnd Bergmann , Josh Poimboeuf , Alim Akhtar , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] clk: samsung: add CONFIG_OF dependency Date: Fri, 9 Jun 2023 10:15:49 +0200 Message-Id: <20230609081559.915867-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org From: Arnd Bergmann When CONFIG_OF is disabled, build testing on x86 runs into a couple of objtool warnings from functions that unconditionally call panic() but have no __noreturn annotation: vmlinux.o: warning: objtool: exynos3250_cmu_isp_probe+0x17: samsung_cmu_register_one() is missing a __noreturn annotation vmlinux.o: warning: objtool: exynos7885_cmu_probe+0x16: exynos_arm64_register_cmu() is missing a __noreturn annotation vmlinux.o: warning: objtool: exynos850_cmu_probe+0x16: exynos_arm64_register_cmu() is missing a __noreturn annotation vmlinux.o: warning: objtool: exynosautov9_cmu_probe+0x16: exynos_arm64_register_cmu() is missing a __noreturn annotation The objtool analysis is correct, and this could be addressed by just returning success whenever CONFIG_OF is disabled to let all that code be eliminated, but since the driver is no use without CONFIG_OF, just add that as a dependency. It will still get compile tested on all architectures since CONFIG_OF is enabled in allmodconfig and most randconfig builds. Cc: Josh Poimboeuf Signed-off-by: Arnd Bergmann --- drivers/clk/samsung/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig index c07bb50513bfe..76a494e95027a 100644 --- a/drivers/clk/samsung/Kconfig +++ b/drivers/clk/samsung/Kconfig @@ -2,6 +2,7 @@ # Recent Exynos platforms should just select COMMON_CLK_SAMSUNG: config COMMON_CLK_SAMSUNG bool "Samsung Exynos clock controller support" if COMPILE_TEST + depends on OF select S3C64XX_COMMON_CLK if ARM && ARCH_S3C64XX select S5PV210_COMMON_CLK if ARM && ARCH_S5PV210 select EXYNOS_3250_COMMON_CLK if ARM && SOC_EXYNOS3250