From patchwork Tue Jun 13 09:56:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 692159 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A97C5C7EE29 for ; Tue, 13 Jun 2023 09:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241934AbjFMJ5O (ORCPT ); Tue, 13 Jun 2023 05:57:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241474AbjFMJ4z (ORCPT ); Tue, 13 Jun 2023 05:56:55 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2106.outbound.protection.outlook.com [40.107.255.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B570D1BD5; Tue, 13 Jun 2023 02:56:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fLTSmsbhi7i4nUUWRBTmeJkGUbqqkVCyqKzX2ZKMw5hP4joOvmDePwp4CsUHXqco/pWMe6hftnr6oot6z5/0AVmJJS7LAY7wQUSNS/TccTDVCnGRpWchcxjdmwaQC6YVhesY13f5JD+iHoqAW0MW/q/g8kpUL4BbJNRTaqF39KhOL0IZte7z7kISh4ay3+5Z66e/mREDQ+9I3mxGHtJsoMFGjoy2WzR319eEbDyEUrMEN9KiTjNBNqHrVUFeFM/zxnR8ofkCKHpRDsptV1dAqjPR4kERE37ec7PndQYjjrlibPORqCb7xotWv6Vmj/NJAMK0jRaeGcDu15EWLq/O4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wgUHWTc8w9uXoZ9FmOs4xU+yjuY46oZRm/AqUHLmhp0=; b=G7aWWL4FylmrzoPEMSaYOS59A1lDPFgi4TTx6xuBvdb2xE9F8voqV2dN7KliSEGexErNvsa5GFbOtm26Vb1bzLGU9K2ACMV9m3BvixTXIp04o0M+yWd1Cj+QMEJ+MPYg/ehtLHM39t6MviNK0NPZZb02N9vFlfAOLzD6hZEbhDcsLHaob+wxPJRxA109zvr+8SiHImifKJY5lf+x4nFq/pInVU/mUb+5Ekst42iEYL+z1pSdbxXtnH0WDl65IfettoCjY8PdrQuGNcJ8QibmdV1ucFR7O+4t6AlrHjcrqdjaYx5fN+053g55dlPoNiwDVBCmEN+07DJkGbnV0crCZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wgUHWTc8w9uXoZ9FmOs4xU+yjuY46oZRm/AqUHLmhp0=; b=dj3M1cu7b0va+GFHEXe0G4j1uKkhHW2sdRflxUN384l4jMdZpMqyRI0KVVMGjNJihuyCzHuFDunfOACMhJrehAvUSOhbh/c1/TEl38eLHx1eIw7nAjiAQlXnJPuvtHyGOEFNOUEEnWlgkdD+6GOhhBcLtTcEV6afthQND65fKT+dUjzVGu8lya4sgm455sAOB5FXC2NNgnnED7OiS96HZZkRGH7G4nWKLAszklzzDPqe1D+O4MSsrHab3RLLXNsmrdnkLn9jVBTu6aAEpaOasqlmkBdY+a7raYR+suHc9mjzXlUflJazR0hZt+9ocBLcNaja1G2XcJEXqraG4fND8A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB4012.apcprd06.prod.outlook.com (2603:1096:4:f9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.46; Tue, 13 Jun 2023 09:56:39 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965%3]) with mapi id 15.20.6455.039; Tue, 13 Jun 2023 09:56:38 +0000 From: Yangtao Li To: glaroque@baylibre.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, thara.gopinath@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anarsoul@gmail.com, tiny.windzz@gmail.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, thierry.reding@gmail.com, jonathanh@nvidia.com, edubezval@gmail.com, j-keerthy@ti.com, f.fainelli@gmail.com Cc: linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Yangtao Li Subject: [RESEND 1/9] thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs() Date: Tue, 13 Jun 2023 17:56:16 +0800 Message-Id: <20230613095624.78789-1-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: SG2PR02CA0033.apcprd02.prod.outlook.com (2603:1096:3:18::21) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB4012:EE_ X-MS-Office365-Filtering-Correlation-Id: e9f0c09d-eb81-4388-4502-08db6bf47ade X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iVbodcEwfJ06GuaAFyq2QmgKS2CWgmq5KMceHodqVJPsXi/m8tXdlx1F/kO/CKjNv0LtiGIOcdvWMLuzy23pLZWpUlps0ms/QlRvjO+i+DVzGflD0M3N/a+JMvH6G6iVHij2/NOrL/b6SiBsxczFk4eWGcfbCUkgXCHErFAS2TtOGv7pJD0MIO5y5X/ZYsN3mumISuqCB0PArD+lSTBkrwbxqemTU7OngrHQghGEsf1I+NVSMudxiwJZr/JY2LpQ4/n3MFM1UZZAhU2T9I1N/AOJAW/yn5J1P5CukZGk34ORYqyKLz7y29NP4tDYDW8Alw9IYaHJGlwlqgtEb8ONquBr1ljcpgHaKFw8ZaNBXfuEJ+BA22hhC4Z9o8xWpaZ8hai34JPESBjWw4Fo6zcyUdPae4XPWonCSJnEGN1nQoS2hugYuc0zPDEvBmNGsKB4aC+lh2PpnyxApXeNZ74ZWPyX+1Q5WsyQy+is7ft0SlnKWJ9lxEA60LblkSsXb+fp46XlOV32NfQhWjh3N/j0HrugLCz9sJc7OM6TpToO9CI/tWT0UvYaxG2R+yXUQ8Md4pJcek1Nq/aQJ7W6EsyM2IXM8ic/m1J20qWj/NTrRzK2EYm3aMm39nH6+V+HVK4q X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(451199021)(4326008)(8936002)(66556008)(316002)(7406005)(7416002)(66476007)(41300700001)(186003)(2906002)(66946007)(478600001)(8676002)(5660300002)(6666004)(52116002)(6486002)(107886003)(1076003)(921005)(6506007)(6512007)(26005)(36756003)(83380400001)(86362001)(38100700002)(2616005)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PkovJBVBwalxUd6yVGZZ7Zc9EOhF/vgSPkmecnEeoYNW/PcG4a74d6ytOBKyWcjZToECquF8xM1UlBRXMn6f5FTdleSLoGiONAvO7U1p6w1SdsXY69Tw4TUouTuVH1Ifsg76ccunyjfSBnEEYqY5BOjYyl0Vey3WMKV4/FvOot/r52G71aEbLh66TPtUsLWDZAHibPvMKpU5pQlpx8qalGANLM6Uis8NlkRMMfR6AtKE/93OpH2jmDYEWNJA57m2AgYRJg7DhtkigzdaDpIekWrwz7bfm6IK03LS9PmyjF1bh4CnTaeuYd1WTf09hBbD03ffe0NmG8hRQiEfgeF6a4XaoZqe3OerYTbv6C78G2QBSGNkQsm7pEbw5WE5Yogluz5OpzUwCXJBNfT4jOUVXGI7e1jJd72MEGnk7JugLahuOFGCWJi59BmC6uIYcsCzvgalQCLWSA8pAh8tWTFfmmwiFG5ZlIhARMxEHF7m4Xu2gusvSe+xqj6+tXhVHb8S9qVNe31FyLBlIo7nP4YqJORcO00vjwQ/csZkBygXmORc1m2TII8s5Z5gZaM89j9gfrn9f1osALX2mTPi+vPU47KRZXGiXrm9baJqsQed6W0m02SAC287+D4megeGa9g6dX+GFM1cOTNoNIX7aN9/5oiIRAA71kiXF2xdZCW3nIdkLDQ38alx5D5zXuyT8fKcVSmlHzZTT5+TqIzjrhDqytfDdKk2Po4O26iM5khGXoxx3t3KnIgyVBag4Bd3JskAMEfw3cBNSfts3Y/qyN0yO+36e65Ffqz4DhLEJWuP12zCQTbqik6V2eFbomNiGwNnLHxL39V6JykKW+7fM4YF2duZXOV36PZ+yo4lITJxAogUY1kvm5vx9iJdZKrYHQvDgJNLcks0FuqxUf2KkRdeYjBkfmyJ5DWf5xAjyeP/ND6QxbY4N6Qo90rN7GJ4NesPK8mKYE6rUWnff3w+bMRIZwXwA0Qq+NT7M30QbdcqZ/GHDuo9LYhVgDhJpetYRqb0XbOjEEoQJYg/2vugwD25TmEJMFVXORXDWk+EY7eVJDw7TFUu6xuCg2vgnP1rxTc1dNsgtT/ekEn1U5kqXEdLUktMCFY/Uw/YNipEqH8cTSIJaxpex7+PiHXu00+mDJwYUWBv1V3sB1QsmKuHMIMMGCm4mZdxTd0zUcUs31OJK0LRIrPV48PI4FHtj6QMQF6bCMIV0fEpUnFJgNvo3oIDvBfrOY/ozDYQWJoBs0tC45WZ6i/3SfYSze46+o/Hzn68l5ujuW0UsMx6SzRH7oiZ5ZeTH6I2WsREh1iakC7jk3ij7i+paP6M0kpKXd+x7Fl4MwPTZ0yC4tAEMSgJEyBMqvdMeZUW+eaWpxhHCmpilvXN1AaDZMB39Z74jnc+Np4kCqZza1+ECTDNvenF2CLm8qH2aSVgrsjwYakeVvQm2xi3xTdxwnsndFokYYl3kzWAIf6kq1icKA+EaPCijWd296bMTJH0ckphxHoHjH/KL/nqYnNPCt2/9SqgMu7QkAoTcobpz0YfaTFw1wXCQXYnsMpDo2JTRpj/qmkII0QAqbL2VqzRYcad5vKx/WKga3En X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9f0c09d-eb81-4388-4502-08db6bf47ade X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:56:38.3657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LOfQ6gJ3ZWkmW0VC2s3VqfMQAqzhA23tWix5WZuZ0eXwAqa6I6NeLoyDfdzb5XOHAW7ho3veECp8JAcOspzWwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4012 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Signed-off-by: Yangtao Li --- Resend patchset so that the changes to thermal/hwmon.c are copied to everyone. drivers/thermal/thermal_hwmon.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c index fbe55509e307..a580add5a2f6 100644 --- a/drivers/thermal/thermal_hwmon.c +++ b/drivers/thermal/thermal_hwmon.c @@ -271,11 +271,14 @@ int devm_thermal_add_hwmon_sysfs(struct device *dev, struct thermal_zone_device ptr = devres_alloc(devm_thermal_hwmon_release, sizeof(*ptr), GFP_KERNEL); - if (!ptr) + if (!ptr) { + dev_err(dev, "Failed to allocate device resource data\n"); return -ENOMEM; + } ret = thermal_add_hwmon_sysfs(tz); if (ret) { + dev_err(dev, "Failed to add hwmon sysfs attributes\n"); devres_free(ptr); return ret; } From patchwork Tue Jun 13 09:56:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 692158 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B98C7EE29 for ; Tue, 13 Jun 2023 09:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239242AbjFMJ5r (ORCPT ); Tue, 13 Jun 2023 05:57:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240450AbjFMJ5n (ORCPT ); Tue, 13 Jun 2023 05:57:43 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2106.outbound.protection.outlook.com [40.107.255.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D4011BDC; Tue, 13 Jun 2023 02:57:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=khbyOLYBVUPX93GhKQ169V9J5VenjcpeEmO8RBkycbF0E6gSAgKU6Gm+qf4lrMg9P64BRDMieDWnKTNs7/+ogt2PjSAG83tnew21FfM0wR8juKEX0X0/tlkWEJrPzBEHTq5ejYMcXYM95Ohd63uBak7duZRZVZ3XtWC2jPKES4IaiZRRgaz1Y0WIkY9Iq+FnjbTJEDAQvebOXwFdQAndNdtNCbswX1XDdsFkAigEeq6kqY7Oqtac5kNaf7RgLtY3lSb0hP44fPCY7C5KO/4uxOwdrV0UiCHl3Rz5og6uVcQsxzhL7yQCF9wODlpFtQQdLxZgXTr6xhKbencOujdVuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+3OBtGY/5chd6gxnhXKVzWiME3BSs4Qa259qqbn6U0M=; b=cxBJ42t+80G+QPLqo3pLLuCg82GP7uy801jvkq9CrOtmEp6cp4WTBS1y3X1RkMzJYezJueETspjwFIbY5xOLkhub1Xz/vT2ArJT3JhyNScwxqhH2SSwBbnq7jMCiOGxqCn3VSc+myoF8AR/gHqpD+jOhzRf8Yz1ZuZZflzEkQrMD3LWMNdtr3SESdTdiLTZBtsSige8GRluUE+IbEvb1p0k16TCd3bhBAzgEPBJg7X5ojLPGD1mctrCDgsU2AdLpafIyN3uMvgDSl93c9UNGkJXt9VoPfGEtj6eJa79l5sV0s0B0B5XSCoarKnxhn8kLjlBMChLYat5xnbfJmG/ltQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3OBtGY/5chd6gxnhXKVzWiME3BSs4Qa259qqbn6U0M=; b=TwUcDeBUef26bO4uCt6sh5yKBTpgUeGePhzCOGb1LZ/4r7yTbEKfFcN30nMIcF0kWaVth0BVdjuSU1PEaSUFCVEiDOO2lKTnXwvaXTTTbmQeAK0XY2ZK5dvy/DKEzKxAHUZksvu/4O/bmlvWtfhhJsGpCXErV0XAm4WalmvsGX1IRcnyHqw6lGQ9AMXjUkHefpfTzgRJ1gShAoZy1ZaCNDeTA0/fft7rusDt517vTXNlQQEfvl8UjzKoCqwITAY/sS+FUdoPxVjPsrB55Yet67HaW8pRumSFZnv0tPv6aGBAUK9NvvE/aar4I8rM0gITmig9kwig0qn4ouXe0DY2Lg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB4012.apcprd06.prod.outlook.com (2603:1096:4:f9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.46; Tue, 13 Jun 2023 09:56:55 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965%3]) with mapi id 15.20.6455.039; Tue, 13 Jun 2023 09:56:55 +0000 From: Yangtao Li To: glaroque@baylibre.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, thara.gopinath@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anarsoul@gmail.com, tiny.windzz@gmail.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, thierry.reding@gmail.com, jonathanh@nvidia.com, edubezval@gmail.com, j-keerthy@ti.com, f.fainelli@gmail.com Cc: linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Yangtao Li , Martin Blumenstingl Subject: [RESEND 3/9] thermal/drivers/amlogic: remove redundant msg in amlogic_thermal_probe() Date: Tue, 13 Jun 2023 17:56:18 +0800 Message-Id: <20230613095624.78789-3-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230613095624.78789-1-frank.li@vivo.com> References: <20230613095624.78789-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0033.apcprd02.prod.outlook.com (2603:1096:3:18::21) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB4012:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c2232c5-7e3b-4b7f-3968-08db6bf48534 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fsjus5dFmEBfFKA4qpq9GakphRC06lbP0mje3pPnghpm785wWLbCf60cmkCMb7lVix0rhMp9gAn4uL8AYdZ4EVAsJdkyW9gipzAoDT37uTFQ9xCJ/dJpJw+Vh4kymBCoKz6YZR3ArdKUoQErtInjMl8yy6Up9Sj7F2YEvyoqMi6/eT+5Kmwxm2Drgq4FZKxMJgM4EcGsk77yrAIfqu53Dwq4pJ16x0E9h+DSYPuzB/h5Iq3IR2KnlUrXswvENxdoqWx8Xx93/DafPPZNTBsL3nfccwXKV3xuRlK3yUqG/ka40yJdUJykXHG92GQtq0jw3F0WwobxaeC1G0K5JcoGyFbmgDU5Mvp0onRFJxKsB/L6uXMMYnAOzeEBQdvo/1a6KH+vdoLUn1OMoP40+uJd3BHIAMsApTCbV/U2HSTNUutmXVlNqIj1q1jL7VT1BP2opbIplL84xXlsZGbWl82LqVH8QBulAGqtTzKvkzxeDSBu4r5oyOjJAST7slXxBFcfOPp/oqe5iIUfEuRyfJfPyT+l2gDBLL2QpUW1o6y+GLBmgYojhtNnLHLULrAGhZ0W1MflVEB8362CMmczy4we3MT3umYis/rhhrXYfmEGhGDqro5SE5/EHQxtNUQjDd263PB/JvNcrbasRy/ywD3nxg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(451199021)(4326008)(8936002)(66556008)(316002)(7406005)(7416002)(66476007)(41300700001)(186003)(2906002)(66946007)(54906003)(4744005)(478600001)(8676002)(5660300002)(6666004)(52116002)(6486002)(1076003)(921005)(6506007)(6512007)(26005)(36756003)(83380400001)(86362001)(38100700002)(2616005)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gTX90PoWwoMxRelS+WiGSTCbhJAeBjo9ZNisLX6mslHPOS3vINt6vW8dyrjENSN1/VdgXH2ScIBr23JLgQA249Fj5+qURDjc2D+TOVh4HPKaWl3bUsT5FHJyo+GC1YjQXjQ5N6xXWv4KVr+Qn/v1IL/a0BH2HIC3oQ9iL5R0fpjqVzjEqeVprFRIhpryTLNSlAMuT4O/Sdv1hxqAWCGd4XV1JGUL0pd1oPooClHRN3yaS1+nMWlcir0YtLGuEIkAXAqQLsVEgeIRz9qxuXbroM3NxBelJdTAUR+NCq//SPHlVEweQqd3hK9Ry4/nvh3EKrnd6alLK2VP/UlTNl3pA3oSUWKiN52iL7iNgoTfeDaCR6c59bL/YhNgI/1NGYv0WCjl/RNL7+c3Osxn4S0KUCVU1BXYnRxTspOMtk/IhV0d3+O8UBkRYEQ9PFkk+HGGAv7/+d9WBnpRU7o3jIUuIskW7600zb661/uSS8cyjZTo93S1h6Hf3PY4dAJqs7N8sfToI0Sa2KG3AXlkjotGLNeyZab2ftICW8uqGJ1jj5HRG5ysza3nr7UrLhKktJZhHold4Eozqo78e3cw+iPBNzq29By3mRfxo1dUirL49BDNa4bjgPpkqFV3j7MGvMcA8gOOJAkiBRQvk5NFrcjs+7wSsh4YccOV6Hn4V6cfaiOimWpuHRnNpK/nh3XlnhzTEYBcDxJXkFQdMw5Vrn/WujNLuqduY8bm5266T2U0A4EPWfzeRBqLoIya0f0lPt4TPdDxZp3f8OKJkY9RIyHHhhnS8ImT8k7rns3sEuNmkLqEuH6x2/dN9UP4IeI53AjbRq/pW9h9q4nfyYOP+H9azhEn4ORQDnaW3EkNieIJjHx6ygo2edIZtB/GKm2jfEfvZBXAWJfWG2kfg/2/W8nnbDT8hDIC1vgTQuu0Oo3rGY0xg23dMezQyF6f520fOfrDbBvxhQLGbtAdzpTJnQm9J9BtBWxUxbnS6wCkxFyFYLg3B6yrRUIyCwyAtpJHMhmIS22ea0FL88Sd0vLLQ06yKllwfUNq20o8DhbndakIFpy/5pP9bBCV5/x0Wxupz9NhEPjP4dsO4hpZ38YL+I45t8Xe2TWHwFv1CDuDAbPKf9eDFg/A2WloBD4ycS4482nj1ScbY7LXyycZLS9CQnGEy5yUpxHjNPyCPj4RgK1LPuP6if6NKB1L3N3ylriwaKqzVTgTJd5jJ1JvKREYdb2aHVOQ+VgHZ0+BSLnv5oITQdlK50YZujG3TG1rctVZ7bBebBi5EbenAMHglgB3S91i3fH7dUPDZAkTErMVkEvcg3hfX0R0aa2ezkzilDjucvm73jSnt7jpEzv8l6yCykfeyifH/v/LVKD4U0nqdtOkrzKfrup/I7CY0jDF9jzVmKFrsCR2YVhdoANqmcDNLfnqXYzM9aR18w/gMa82t10iDbgYgU+03MzJlvhrKaTADw4LsKuBt6MOVqR578/TYmDtHlzyT0CNGmwsqccdnci+/uVWGKAsFwxQW8NrrOW/JFuohs8/N7hAjmQGEKI5MdAn806dyy9iBRrY7HCZSV/gVEUu4LHk/RKqqDiZFFkip8Du X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c2232c5-7e3b-4b7f-3968-08db6bf48534 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:56:55.6621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S0qq/9W4wI/CoxCKo6g+84999w6STuBnPcH/SLaRw88OyIzRgxON9XvrWTYkfREiNkoQOfMEEo8R6XvLAn7GSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4012 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The upper-layer devm_thermal_add_hwmon_sysfs() function can directly print error information. Signed-off-by: Yangtao Li Reviewed-by: Martin Blumenstingl --- drivers/thermal/amlogic_thermal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c index 3abc2dcef408..756b218880a7 100644 --- a/drivers/thermal/amlogic_thermal.c +++ b/drivers/thermal/amlogic_thermal.c @@ -282,8 +282,7 @@ static int amlogic_thermal_probe(struct platform_device *pdev) return ret; } - if (devm_thermal_add_hwmon_sysfs(&pdev->dev, pdata->tzd)) - dev_warn(&pdev->dev, "Failed to add hwmon sysfs attributes\n"); + devm_thermal_add_hwmon_sysfs(&pdev->dev, pdata->tzd); ret = amlogic_thermal_initialize(pdata); if (ret) From patchwork Tue Jun 13 09:56:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 692157 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4433EC88CB4 for ; Tue, 13 Jun 2023 09:59:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238624AbjFMJ6d (ORCPT ); Tue, 13 Jun 2023 05:58:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241061AbjFMJ6K (ORCPT ); Tue, 13 Jun 2023 05:58:10 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2106.outbound.protection.outlook.com [40.107.255.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A6691738; Tue, 13 Jun 2023 02:57:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dof2h1n4hKnnxuKWJ9cPF7O8JY5/IlxQvB7L4aRejL+jNEe2VYZnZOapJh0BuZP7SraryR9coNF238OrMpeSXmJjNdBNyMiHXTXSmKsdz0oK0ldMZ1vj46sEUPuWhMe99BOyna0rFRzrWx4qRvrvX5wDLWbd9/WrnC6pQBQGVmBcuo+/eCr/Zod6qBE2olE+7+3dDjgo2YVC6Ldd6IS5WEP5QkdCw9hB/rfVibkdMrcVqy6wl1a4Q5CVJe/KtE7iFHegvuTnITM+MAmTAbPjbs5xYayk2vZfjJ/sPRywWc7/sqGtiU/hKwwnpQ2lIxmy906AOpYgDQSrbXWEBfv4sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jy+wdJ4SRgf2qsL63HDh5KAoa148kEROpkTGcT1sxb0=; b=VGVy7zusHJgsPEx2dNjT9ZDwanjN1edkRkjQYBVaabw2/WrNrwZ6qkIjCM2q1DfMaEZ2PwOnZhD8zhb+y4GBZASv5o50nR9mad7emkEg917K+k21NYE9ETlx+dvGcb16r3GhFhnOjm0E+zrEOzmYEoikA61KOSRBH52fyoDr/VxdLMY9OwZSMLSqzf0txh78gTRlPfa1TYifhoEZUOBfdKrj3FEnmF3CK4GsrCt9wpPAZ5+KUYvRffC7Nw74ehBuC575A1gHFZmIfetzWR+eJA15EG0JoQr434VJznJdno/JtLC8CAHXZYgEXtknFnIoWapi0bCGddoV6A/+JZYxSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jy+wdJ4SRgf2qsL63HDh5KAoa148kEROpkTGcT1sxb0=; b=Orcz2Mp+jHez8l4acJ0nNumFl+0f2PVCa9Y7/FfqYusrqNdwY0dPaMB6ONPpFxEgNdxcF+4+Ah/RfVfGInN6Ew4VxH4uwKYp/bJrXJDppVPdJI6Ee3KNvsg8U7DOMYAtiwIcdgds0pPXDQHA6N3WWVuS91c+qGiDhQqzUWJsJNOLfohFjNirD+Dtyn3c/EiLEHCvwNusOlpX6xiuMSsAlN8JCg9FsfF7DuEuojgGpH/13OsmOpHFrHpMycFAEVrCsgNxc288OLB7DrFZGozlh6jiBEgDd8RAI+WCBbwQNI3Drj4mINVja3nHL1sP2JhHzfLGOlj2rP+ALiyAIG6XmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB4012.apcprd06.prod.outlook.com (2603:1096:4:f9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.46; Tue, 13 Jun 2023 09:57:01 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965%3]) with mapi id 15.20.6455.039; Tue, 13 Jun 2023 09:57:01 +0000 From: Yangtao Li To: glaroque@baylibre.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, thara.gopinath@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anarsoul@gmail.com, tiny.windzz@gmail.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, thierry.reding@gmail.com, jonathanh@nvidia.com, edubezval@gmail.com, j-keerthy@ti.com, f.fainelli@gmail.com Cc: linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Yangtao Li Subject: [RESEND 4/9] thermal/drivers/imx: remove redundant msg in imx8mm_tmu_probe() and imx_sc_thermal_probe() Date: Tue, 13 Jun 2023 17:56:19 +0800 Message-Id: <20230613095624.78789-4-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230613095624.78789-1-frank.li@vivo.com> References: <20230613095624.78789-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0033.apcprd02.prod.outlook.com (2603:1096:3:18::21) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB4012:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bdfa49d-535a-4611-6b74-08db6bf488c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QuPUHxyDyt82q5l/j54Qi6mgXIdgLSJSQDqpn7Ekq6TcbQdESI/2mXh6Y31oOh8d3VZt6ghplbg8AsLEg0DJXs2jYeKAq4oH4OBx35oU62VK0PMI4eMdRkJCevkGYnTDEWHevGt5pIyx0QmOQBC8od3f5FZa72u+mYqyc5mApRLoqi/lj25BnZiOop0ppHUyKyU2BwPOr/ZQ8zx4b8RdjsN8G+mlmEpNYrLEggGwR+jNxsq+xt/6/nEjR/3b4dGltGtqXC8wev+7OIbvlN14EruLbK+XhMJVlrhSgUL0lfc15Gb9lei7UbLRWqO62SkhjhatbsGdTnkrO7htG6MdRWVCkt2v1tr7tutAt0LeeFpbUexuur581bMNG8HXS0yyjiyZoy3U3sExKexMOqFe3m3kmWYC/Z44+Fd/3muqzGO6HlMilhPTgn4OyGlHmewCiUQlTvQ0ISaT7dyK7SD0+BB55KN81PtZTspxHTwoG/9BKbevEtB9QHvd/K1Hr7Sv0EqxdXjqv9SttmeDvBybQRMjfv82LioSkgJk02n8auwBfoiBSXZCTCBMQ+7JTXvr6/qrEzoVPinsShburNooiVLMQw0wPoSjWE8jtEBsFlYtGdAy12CK/s184NgpqBOM7OfrN/rxOsBWUlo0SGY4Xg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(451199021)(4326008)(8936002)(66556008)(316002)(7406005)(7416002)(66476007)(41300700001)(186003)(2906002)(66946007)(478600001)(8676002)(5660300002)(6666004)(52116002)(6486002)(107886003)(1076003)(921005)(6506007)(6512007)(26005)(36756003)(83380400001)(86362001)(38100700002)(2616005)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xs3M4M0ia+hBnu0BA7ZHCAsvbZu8Ohy+QVSKOCKz3l11RO6xHC0gmDc6+EPWtL7BhZELXrZ6DHJQWjjpRy6NDDAEW99AnslVx2pwOpqQr1gzC97Tq/k5SEZtJAggKmSp+zalpO4YUVAALvXtkW7Iwwr9kv69nPbc5Igu4O5izI+l2IUpehvEPFaGzxHOaR/C5jG4I9XfAID1IGS3GFSpmbdGEA/DMYyOsAtTZ4RkfA/ytG3lhSKgTmndCbU9dQj8T80GK/xe69FgKtvDhp+nYv3AlE8/1iY/GaGq1bL4aSFcdQhp/bRahQ32DgZc0+GL/5kI6j1gtC6xticvUyKOm73Lcscu4pVhgtDCcIGTMxHKJEQzmN/NZY5JPewXCThT60LE+83YAYabtbW3lcAPgy3agW0rsKXD25vvhDSRLj3EnS/gD1GWSwNXTcshBT3kabnsta9PDYR4zr+q77gKyWNtendbRstDtgcqELe5FnXOJuk5Iu4ARfSyJ4UGUeLonWwcGKkq0SxTiT9XNDlU7DEtK6NYV5r92QGHhZIBc4mhwtdI2AOsJnyfmdvy1BmmenWcE8nuqMXwYlbKQBmzdD1I5w4D7ui3Mw1Iw/bdcZ1TX9/NozJs0mkEmvGfCLXviZLvquwloqAjL0Z12Ko+0sxlsUw16Ot2cCk0qNYK2EItRYo+PMLhwwAxSUk+3B4v81EX+1iR6Pg1hpdRCycadSRF3zTAb+X5HWXkEABjFblaNrQRxg2oEcbLho/WWvjnO0zNAAuSvmEaQieUAILeOifIRctIu9BKD8mJrPhDOg3/jljG5GC0+0uRmzophvbO2WfYBqoC2kwo2oq4TQrBAXiBkgnodzHsjJB16GotZ4J38TRsLF90lwgEsiW0U3bVuRhkfpj6PNThuzioUGbfi6IjFl+X5DZFsOvzlApji8JFtW8HoLtpMyG8hZhTlOxoSp0UEl7A8mBrheV1JWzLlsnlSDNaDQenmmDAJIVTyzCE5kr7n78Ay5tC9NKSdubYgzQj77HLT+6DzwYawa/sBCB0K9vJLw0l2vIwHi2DVjOyPFh8nZeSN6G+ghUt3ISNVqlms/BWbaUGL7aQEpfGXvYXeM3No8y5Z0V7qTxhIax/BKRZ8O6y7YS1erD14hwqI1hWEy4yZC/DKOmn3zPJ90PH0axoWLjAg4URCH7f9LQenPPDO5Cq1ByXIoO5Vv5NaufoZSiQOKRx3sH9hA2wUH3uiDg8SvGS/bCbjzZpPuVYbz39nMPABOaofoVup+lDLsOoUVLhI/TPFm8672m49QiMYFKgZBdYapI+ggUYSsU6apKWXP+oHyKUFlNctE7rIRXmU1tj8789gD0G7xLbdUvft6JqqgfoyNOBSiTjqj/MLXWcbqyvXX08XChus9VC8M0StpZ9MnhAhDrLL/CBNP/4Oz9NcsSVY3wwlH0QzM9G69paPlHvWJ0e/Okv2j/vY2d7SoEEpCDa2ELfh6yNfTrgtzrS8Co/HrH3xNp5wMnrkD88qOAV6wH9LXIi36vlAMJfe1ApwXixd3Lavmk6WgQhSzsv7KLfQPJdoyTH0jlCQUO1PI62M60D8ya+Dlgk X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bdfa49d-535a-4611-6b74-08db6bf488c0 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:57:01.5306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A2cpkTIEoNWuM4x4GF37fxI6kWAUIe7Lo3pBYKH88Tv+s9dVz3dxeBcrI/QKk+AlYdIJKrcJ27KtHc0RVtIkEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4012 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The upper-layer devm_thermal_add_hwmon_sysfs() function can directly print error information. Signed-off-by: Yangtao Li --- drivers/thermal/imx8mm_thermal.c | 3 +-- drivers/thermal/imx_sc_thermal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c index d8005e9ec992..d4b40869c7d7 100644 --- a/drivers/thermal/imx8mm_thermal.c +++ b/drivers/thermal/imx8mm_thermal.c @@ -343,8 +343,7 @@ static int imx8mm_tmu_probe(struct platform_device *pdev) } tmu->sensors[i].hw_id = i; - if (devm_thermal_add_hwmon_sysfs(&pdev->dev, tmu->sensors[i].tzd)) - dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n"); + devm_thermal_add_hwmon_sysfs(&pdev->dev, tmu->sensors[i].tzd); } platform_set_drvdata(pdev, tmu); diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c index 839bb9958f60..8d6b4ef23746 100644 --- a/drivers/thermal/imx_sc_thermal.c +++ b/drivers/thermal/imx_sc_thermal.c @@ -116,8 +116,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) return ret; } - if (devm_thermal_add_hwmon_sysfs(&pdev->dev, sensor->tzd)) - dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n"); + devm_thermal_add_hwmon_sysfs(&pdev->dev, sensor->tzd); } return 0; From patchwork Tue Jun 13 09:56:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 692155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC8EC88CB4 for ; Tue, 13 Jun 2023 09:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239868AbjFMJ7H (ORCPT ); Tue, 13 Jun 2023 05:59:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242031AbjFMJ6a (ORCPT ); Tue, 13 Jun 2023 05:58:30 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2106.outbound.protection.outlook.com [40.107.255.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CA471BE7; Tue, 13 Jun 2023 02:58:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EF5inGOzeggYc/yeLkpbpE5ioXhoDeK+jraVyU/v2Q/B32alU+c6diqQ46W+shNMcyd2rbe/tUFWCcBrcLZz0wDNQiducNbJOO4JEND02CjPlJzbyktt4EzfWfsgnoM90dGp089JCesQx78YGv/qjZFkOe2gnz/M0eChbUJ/+9zWjKTVXLre1a2QhtHMkIlaLX2XUHfsfL+Ps5uLf60SHJCgLPp/CnV4wcAuQaTrYHdVC2h6MmNTO7SbB6+AF2pTSO97kxi475P9wL9jQ/ZR0vlcfhYuDQox3shHH763c3qMAy1GcJCCJpsKyPPtzbEq32o5gHkV6EYXbCREaH0gYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tgjRIFM7XXXA1ZiuM4luxgQMbyvfhlw0vWc2ywkdzrY=; b=KVowd4hFZRTmAXFhj5rjQ+HRmST9qGivWh6gRoBZhzmXVaOdXSq6MoU1u/9j2QcPn6dc7Q9CmVqp1SBAw6ptuo7hhTJpjT/9mMFwzsz6SW/7pxJ4J1L4t1a0LKCubnXMbzKeZ8duY3UaCnruPKw2ogsFkNiAc+MlybNtSqaFCnZwK60RmtfVMLfUKgCRN6YTGnVHdL5Q/RcWQgJUVo45jwzJtpALqef9ViquVcg26jE25bcUQdyRmEctLsnubZDFJhZAQVqrBgxBsX/DIsaQwGD1sIPuNohbRTgdaOrvXiCMCp/xe9lOSuRqurmnHmF/e/ZU2hSwyjbGfLX9Ft/tqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tgjRIFM7XXXA1ZiuM4luxgQMbyvfhlw0vWc2ywkdzrY=; b=enjQ6KTh5oqNB4pKilC6NSlY8XuoDWwThiiVOVwtBPwCoIa9sAmH1BBOTQJs9qi2Q7tLlnNBUkfsyqngOkAZp+bS19TsQCpaUFGM3IFgvJkUe2rqR3WVYKtSUbwvhCvvTH0sZ74oCJYOHIpLcoZ8n8pAXflC0lSTtMEw6NjkgW2YGsz9ZpGCbP0XKrjJsNSmPS9aC4hhv7aewajThKXyqezkh/v0SGGtW7DHABgA5ogjcG05XsPgV8t3zSerQ7bv4om8V2fbql/xKTw4/4Xftw67U32H6MyGXCesHpJmco5nMLhw7tKLLir6ShzNJWFRCmzwjB/ls6QIbRub8wp7QQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB4012.apcprd06.prod.outlook.com (2603:1096:4:f9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.46; Tue, 13 Jun 2023 09:57:07 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965%3]) with mapi id 15.20.6455.039; Tue, 13 Jun 2023 09:57:07 +0000 From: Yangtao Li To: glaroque@baylibre.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, thara.gopinath@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anarsoul@gmail.com, tiny.windzz@gmail.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, thierry.reding@gmail.com, jonathanh@nvidia.com, edubezval@gmail.com, j-keerthy@ti.com, f.fainelli@gmail.com Cc: linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Yangtao Li Subject: [RESEND 5/9] drivers/thermal/k3: remove redundant msg in k3_bandgap_probe() Date: Tue, 13 Jun 2023 17:56:20 +0800 Message-Id: <20230613095624.78789-5-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230613095624.78789-1-frank.li@vivo.com> References: <20230613095624.78789-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0033.apcprd02.prod.outlook.com (2603:1096:3:18::21) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB4012:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f99ec5c-f51f-4db9-ecd9-08db6bf48c5a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HQ3QzG5rhAJ0ZHJ78PoHbF6nj9ht/8JXy7or3jAb33Uhrpp/NY6Vh22slPr2Amw0NlhkXTlnL3CuvlpAl3muI/+X9wFdGuHlU/gAdL7417rlq9jmTqdScnfIsy2SEL/kSzte/B1NcW6timisWN6P24iKPL93buuUu/AKX1QwmuA83Hk1jocuxpqhZu+RQCCFbYrjM/mEn5kLQDLI6pvYLUXn3aEubLL/MwxuPF5BamOJL1wrmm1DRfwtxaM7KyAWr15RZty7Kf4I6eIbN9QYKpB3X94tTddcyMuAp/D/UZj/47qg1/er0kfThP5aiCB020vDjuSvoxTm+PtOSMNs4jBqyIbhTff0XBjhuDg+ZmMdKvA827NnpoDIOc1MM1lmHYgUF+75HXjjwA0u/Y+UFc4ZGXRfEFBPPCFwK6gcweqsGNBeoroas0JUUhDqfxp1MGS5Cr6MIBTaI4wamzPDTqW1WRcZJVJg+fyoBF+0SjXvbNR0Ez9kUA4oWz8n6y3NFycv2cyi4sFgsZ0D8QPN/kToJheQqqlwlRfcB66FI21p+V1Qh5wOMaZroZnsFtR8glWb9NYNRTQ9X1AEQBfX01fAhlu8+ZWGw4GvcJaIyGUlqvLKSyvA6b3qF83PK34/kxP+6qZM9M21P89+NRhzaw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(451199021)(4326008)(8936002)(66556008)(316002)(7406005)(7416002)(66476007)(41300700001)(186003)(2906002)(66946007)(4744005)(478600001)(8676002)(5660300002)(6666004)(52116002)(6486002)(107886003)(1076003)(921005)(6506007)(6512007)(26005)(36756003)(83380400001)(86362001)(38100700002)(2616005)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: foPhasOcUN0yPQqI1CiAOuxfbyb7HDttxQMlUNHaPrqGa9cYhTz2WYc43a3LMlgXN5jnlAEdvCgNketnLZtQW7UqkLpUsa4on8kqR7XKbhTJlkmy/X7XBe743S6Xeq58vr5XNJRXsmjyKSZqHo7Gk0tcxyZbTkSJJJ//yGbq75Ivjwh/X1eoR/jI661aWbMzcdJPEyKtTalYc54jDHGKyhaCi+QdLpJlL2YcaEmP7hS+ylQ37cNwrOk2e7inRz5F8xBSEM7ATn4iTjS8Vc440td78MGS5FGNKOeUPwzgs5b78YhUt+tFYvKlc9RhIaba6y539yYYhtufMSt/gKoTKgMLQbUDZihlL13b2EUEIdY74jtdfgxGPGvgEDTt/ojA6PbzVFEsdJ7YOU+eM5lJ68LKnTnbV/3P7mRVZjVNtc25UNzpcifL2PqODkjbU1avPeCpCLR5R/wqljxnaSKfaOTCrj9gmwAxui/+9791lne/fq8ZZrscid0sGmAHpyxR+OlK8HJY0ayipB2pCRmOsreeddIIziOnqQ5pe4frayinapLcTH6Fnmstcos9zUqvq+r0PhkFVO4RiZ3xiK5ey63feVpB8+ZPF/BhfDPOvbP1hlzdIujsEyuDl5PLlAdurBsejWDX24Fp+XfyOKqyock+ZoscY6kU+oRTuT6XtPSzUfcYf7wM829R7Jfeunfy+Zp1HA3pKDwdoO5ONFOtiNqlvvhW7rVgdxa/ZpU8zCLSYjWV08KGKTOpaMbnPs8XRUP+FWiq44/3evMvI3WMYaK7/BtbIJh9ZHJBmNfjA+RkG9401MqqKEPoWMLpia5OFvhMT3CuoJ1Gd+Uf3ZwBwlD+2jwCWqdRujavqauM8Smp+50OHjtHDKEZ3QSJGhCzl8RgG8OKZcgsggSM8+b8tL4/dvGaABg2RIoi2W1nGfxn71qzGDYr/K+2WzHiraFQGKW7rdvWFQBiN0QlmJeW2XDbV0y2fjAsdoN9nmAzVGqEI0d2/kWlQlAxuR9/536NGyL+gq2fbjoszlie4Br83wr14V32AmjjLqvdztfADH2nv+y8P8+pLQdOHiWcZI2UifpGqvixHf12gwRyGhu6Sd20HZQUtU8UUOTLhJYtgPh/T85feuh8LdvTXPiO0gwfCskPJXvloy8E1S6anU1cx0P9IMuayKRt8jcMAqIwbOmcDtSjVaQ3mu5SjgGIYbW+FDeHMcy0rOCvlAxxa2MKHr4w72OZsxjSbPdqSqsQKvub1E3dYwYqcboEupX8xJ2axlmL5Dmr1mnKyAqmLqhQbu2LCxSd5g5ELFTVoNm+NBCe8O5EDqttqMl/yytisW0/tG9bkiwsrXdc80TRbKKeG78JxUtCckPwSUcALMMaIIN5hrBcn/oXuNh9M6N/HQKcP6xlwtCt5OwVHM/JHZSE6l/Bp6xV9860Ivdrk3C4c5AuYsbc9735WQGCROjOcsFH3N92bMVzuIr2GyHocPA/xv5RW2IHIUHZ/cZC8znMZIZaoHdpQ/FzciOXl/bRkARrY5CIBQDQNlEP2raNFTAX3Lg4qpIJXokoaP8VbRYCa8ixwPvvzlKT1IulrNCL0tPO X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f99ec5c-f51f-4db9-ecd9-08db6bf48c5a X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:57:07.6374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r4mCyEthmO1fZs8G8MIWpaapAKi6ca4jfM8R+mzbJG2GZyLkq2VbwxIw6roFCZ2vaGIubFfwtgRqDmvG1WmsZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4012 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The upper-layer devm_thermal_add_hwmon_sysfs() function can directly print error information. Signed-off-by: Yangtao Li --- drivers/thermal/k3_bandgap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c index 791210458606..1c3e590157ec 100644 --- a/drivers/thermal/k3_bandgap.c +++ b/drivers/thermal/k3_bandgap.c @@ -222,8 +222,7 @@ static int k3_bandgap_probe(struct platform_device *pdev) goto err_alloc; } - if (devm_thermal_add_hwmon_sysfs(dev, data[id].tzd)) - dev_warn(dev, "Failed to add hwmon sysfs attributes\n"); + devm_thermal_add_hwmon_sysfs(dev, data[id].tzd); } platform_set_drvdata(pdev, bgp); From patchwork Tue Jun 13 09:56:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 692156 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168D8C7EE2E for ; Tue, 13 Jun 2023 09:59:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242124AbjFMJ7G (ORCPT ); Tue, 13 Jun 2023 05:59:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240669AbjFMJ6e (ORCPT ); Tue, 13 Jun 2023 05:58:34 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2093.outbound.protection.outlook.com [40.107.255.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B49C11BF3; Tue, 13 Jun 2023 02:58:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E694vZwLb9ZCcdTB5FEhq1igtNrvu0wZYc35D1oPEMB+Psg+02qVvwhYcO2GWHaH6zsZ8qm/wvaqyrFA8Q9ptvyFso3WFAIqBGbMM84jQdL/ZnZxo3aGOmC+3H3FSMx7z4rL2pGuKLA3H7ToDUhadZAK6xAX5qyVnp9b5kABbyJJ5HC4Dki9wnSIBYBXq3h4xoWwooMwyA7LBGt8MqptqQreSps7/ltuujwD73wAOngaex4/v93ztjwUZSk53mNvzPaohP2AQODlP2zeFrHmRyDcatMRc0usVDPRC06nYK8hlpdGCGQEWUOXouxghC+qcagDfRs8tIarzuTx3cWCwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/rD8kg+92/T4iqfi8bXxqd9k54ysUymkpnPOGQgUuiY=; b=UzaOUbNIYpLnI/CrGrH09f+W+KEGiF/wXvV0skfX27j/RX1rYJTk1BDekYi1BqONOTG1V0kMdC2Xwm3YIsC6O8hYXyHxPWtZIQAacBF+CRf6prrlGg2iWmuyjAlXfWjF13UNNgVTmm8466JSS6RXE1I59aCgtS0+PD+cjiLSE5TBXHJ9xWJl4/zX8ttQ3QYx7R9umFWSB0H+RCEA14+DLUhTmKkoUjYuQIDtgJJGwaQ4dlIZXC0zzR1SzkGx0q+nqVNy2cRrbjxtT1kq5c3c3miQgFtzm+OoFsrh3+PUXnCZCt97PQKAHQ+7Ivh0LunKfpJiyTe3z6GE9AQoXXm5JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/rD8kg+92/T4iqfi8bXxqd9k54ysUymkpnPOGQgUuiY=; b=nUk60FHS8Jd3w7Os4Fy7usIlo1uA4RHcUSrrffXyp23NfFm3pHAtfuU8V9vLwCVrMZhNxHKt4TLV5/f2a8f96qNYBDdN98IRlEegfV/NCNOLsrL6HdovksAW4E0usxW552Ncc5ZWQVLAw863bxoOScu/67NI2gucx7LEUD5rd4ZpuvYi3QQXzoTMI8YWwHach4808xq/pZUgvfrw4MPJe+I02D60fu2uUq8apP/+L/2R9v5Afneou/BZBThMssd0T5ChO4U6BqA6rDcl3KCkezfvIFXTF30LJokdRCA28ekLUYtwRSbur0/t9ZKFbP6NUWH4O3nWFY9siAPufAVzmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB5784.apcprd06.prod.outlook.com (2603:1096:400:268::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Tue, 13 Jun 2023 09:57:26 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::76d6:4828:7e80:2965%3]) with mapi id 15.20.6455.039; Tue, 13 Jun 2023 09:57:26 +0000 From: Yangtao Li To: glaroque@baylibre.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, thara.gopinath@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anarsoul@gmail.com, tiny.windzz@gmail.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, thierry.reding@gmail.com, jonathanh@nvidia.com, edubezval@gmail.com, j-keerthy@ti.com, f.fainelli@gmail.com Cc: linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Yangtao Li Subject: [RESEND 8/9] thermal/drivers/ti-soc: remove redundant msg in ti_thermal_expose_sensor() Date: Tue, 13 Jun 2023 17:56:23 +0800 Message-Id: <20230613095624.78789-8-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230613095624.78789-1-frank.li@vivo.com> References: <20230613095624.78789-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0033.apcprd02.prod.outlook.com (2603:1096:3:18::21) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB5784:EE_ X-MS-Office365-Filtering-Correlation-Id: 74f4db90-d6f3-4863-0bf1-08db6bf49766 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZL4HtP2FO3dZKAQzurKTEcq/YKD10GiyfrgfcsBfErHEHzApElliHk/67L8Qr+VgrVShFHPZejof0HyzoTUe8VA5mpqVjUwEUckTQhgfeACKdLwFi6BDFyBldRY5L5Shd5AJRfYXDYK6ITfv4o83sZ1+jLibDCF7m7FhXES4MKKrTBlioVNsadp/AXxneR5A16xwqAhxApStrxcUOt95jFYxUaDs8COXlCeVZEZymsOCf1iggN0rDa1fuahki2LUyTUhjhxo+xtD8vETMTMh2bQuDxyc3aMK+PNyg4ujlQXBT6hwUBUqbOqKzLW6u+FTk35wJZ7fuExqNk8W3nwanm0tfr48YKPbwYJ/aDU5Qz8NWaY7ED9vrqPhQMaQrS3E8HL/PSGR5RwxisHoWXaAtSsgR81pZ8mcFt0XHiNEGO0/7aV/ZzxqXRMjfZ22ddiJpGmnKEfvAQKPkQk+kMAdavEY+XDIUJmlRQFwHTr1i5MzBteNZ/oAqx+atu79nnU3lYaak1bzoIV5k+nHllt6F8+ZUiQBAPyzQ4J30SHsGcWhDN6VGaUxb7berD8Ou/DWDT/DewRU0KkTzxwYKbAHZ6lYNUGUu2KQRHBX/3aFznrCDIXVs315wNS42tmvIcofevX+7YprUlACApPRc9aNeg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39850400004)(136003)(376002)(396003)(346002)(366004)(451199021)(6666004)(478600001)(52116002)(6486002)(6506007)(107886003)(6512007)(26005)(1076003)(36756003)(83380400001)(186003)(38100700002)(38350700002)(86362001)(2616005)(921005)(4326008)(66946007)(66476007)(66556008)(316002)(8936002)(8676002)(7416002)(7406005)(5660300002)(4744005)(41300700001)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cMzkVWyFHPGX/nGipmkcheHbSzfBSeSbbHnC5GuiATon+zpje/epsxXfTzbc2GZM840Q38fYaiWlfff0ZxRgtwgBK3l/LcOvAK75cHM5lHHsNfyp3JvUQq6F0fciviF0Y/VJGST33xUaR6IlKGqu/Mrq98u4n1Kyq73xA2fbY2BAIRwOTnk4r7gjywrzts2X3KsDc9qSdZnMVZMjvjX5DA9LECO3vOaD1heqgpyO+BKc/Wll/dbCbsECxAbuGCPpx4MyY/BR/kicDPok/+hYP/szkI7e7es2TxOWX+nHVLOUJ+hf2Sbxq871KC/emgXdLnNOXfKVCLrJ/0jG6hiVoKT8wR4VZfADOrNxKt9cmyeBithY/URYvLdaCFHjhSzaitaqzfijLcyy6atvUDLBG5TdHgU3qvmQwBAyI+5c21ORnGraEuvo2nSbeLodJjFDCCFMciJ+OepE9vqn0+wLKzTVLPuJeSYHGxg1m6MXCtSLGALn9hZUD9c9ehsWCsbaOplfF8NmExXp25vkQQpMODzyLtgXHLb+h+HFXVUj2Rh1JcYbuCeT9+wXRTDktm22ZVmRqNGSyfvEnp4datYqjKlrQYKGhIC0kiPvPkLljQ+9bR7TGrvWgv1kTvEpvXJfFu2aktCN2ndB4+1G87OTxurJdjLLVzeD03nix3V/27ESANCn7fKaZs8VKGmeHiJFElIUjJTTnjZt2RMLBKvwYgkon66LIAVOLiuccIufnCG+0VLah/Wdep1hojwWYSlK9AbWPWEqU0AyJTNdWhKVqZ9vIeEbIIe06SsbRuxuXg3l9VVsZTElqIsxs0Nsmd5d69xTDFQWVp6QVO6JskBnNhIjC0rlK9wvm7xUJptitO5Q+IJP/S+6gqctif2qezQH+DcZUSpGMxDrF8EBeRYbYgRfC+lf76f1fdQXthx9xOiQF5pUzKwbbKdB12XNY9w4y8aL5Rul2hKcA9k71fO7vPmCUAmjRfEdTG/6AEPH9L4yXFcSM6YDCnRKn5hjMrnTOqauOQ0DRZRTGQbdPHuRK9hLqR0zOpfL7CInSC9oAmRbFVCrjtFaVxBJUIyUSmfWkgTzjD6w7HUS/vyfF8arvSoSzdx5AVz2Mj7tYndMRTk2K4w1mEGzOD790JyykrlCtvNdvKDnPeMnPAMQqBK9Iq1LiCAacPmc2zqMYcxtUFSy0z1i5WQb7FtCzVSBMi/OwW6uJVJhunfUQq3OQAObDmKnEX7F2Dg6MwYIX8+3k7dnMAitBhMUfLArrBKSOCmy6QV/6QIJbRg4lxDaD0Oi2eB477l8C2IvEKu4+2BCjrmyKbpCNPUA5PIdxeZdpIWgWFxjFU/E1pGO4kKpSzKaGp2jXpejToCwsPOe6jvO240XBVg87E/KnCn6/z5HPDCyOFgBMw6iQS97z/ozZVyMdZbqQrYPKMjF/232qfR0CMZM70pwOmCxZi0l/v0VfItBr0qh5A+np6okj0AuzLr18FGxNBgXM8uwvSJNHot/dAKS91EP31LyYgufmbC/MhaBvlHPiuZNr4N1rK5QwBajPrx1W9MqIwiV8auFW4hqa84j2kotdWSYXhK6KoEflm2q X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74f4db90-d6f3-4863-0bf1-08db6bf49766 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:57:26.1588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nPkPz7ak3gSNF+X2258dv2DOL2lIvTYxabPdmP5RJGVt8bSXWeJYFYsTfZZ05/J04xhnHN8Kkb32/WrqVRVj2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5784 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The upper-layer devm_thermal_add_hwmon_sysfs() function can directly print error information. Signed-off-by: Yangtao Li --- drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c index 6a5335931f4d..d414a4b7a94a 100644 --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c @@ -182,8 +182,7 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id, ti_bandgap_write_update_interval(bgp, data->sensor_id, TI_BANDGAP_UPDATE_INTERVAL_MS); - if (devm_thermal_add_hwmon_sysfs(bgp->dev, data->ti_thermal)) - dev_warn(bgp->dev, "failed to add hwmon sysfs attributes\n"); + devm_thermal_add_hwmon_sysfs(bgp->dev, data->ti_thermal); return 0; }