From patchwork Tue Jun 27 07:16:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 697130 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7E9C0015E for ; Tue, 27 Jun 2023 07:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229568AbjF0HSb (ORCPT ); Tue, 27 Jun 2023 03:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230146AbjF0HS2 (ORCPT ); Tue, 27 Jun 2023 03:18:28 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2103.outbound.protection.outlook.com [40.107.255.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72D911BEC; Tue, 27 Jun 2023 00:18:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ORJciElWF5fC9RgbH9QjiEKrZ4vImoiL+neQbIJUFe78FO0QbJYkdiAbcusMEDh7M904zaC89864XrlmHdcpGPyxMcMHT7i5FK3Y/g4U5dOUpLyPXllKB9D6lY890LcnBYL8rpBqUAsWmX8RaZnMkEMTFXuwTHfK1VkLlmlFgshEWBPPaLulFIRog3IGik1s8DhItQCAiNys/JI2YV60VVaJQdyl56ahny9/1DCxW1bILNYVUUybNYYwGP2busTWFJhsVnOn7iJw1ucadpaaEQrnNIFDfsTLybNIlmwNv14XYMGXp87kPqXQ7av6YXyJnSzgycz/6TtOCIxb0ph7fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=51TqBSHuDXoJXJu/QRggDkPtKMVIjd+MxWJJWwhPeEY=; b=neMprW9P7ckOmO7clUlJkWtvbbJZW1IIBvB/OL8r6uAJtFoEFvdg/X8TR/AGJnDmWIkIa0VdSzrKgX2EC+9KJEhd7SyoUiP8LG+Wdn7tytmMZwWJ4I0M6aBUzsW0fsU58LgiS5crTs2mcdVIfa/1cMdJ5cS7VYZA9bLnE27ShuOuGL6jYcBXth3KbSxr7UTrT0F8w/pYcoQclvr5mg0L82NXDOm8h2MImir0m6TCsTMk8J9SenDx2xYw7cGGKDafKX5Jss/kVB2Cpm41+HvbzHxDivDFHMUWnUW2AWADtzBnPi+Mt4/ESAqpvJw6FNVBIBDwkeuB3XeiknEYu9SYkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=51TqBSHuDXoJXJu/QRggDkPtKMVIjd+MxWJJWwhPeEY=; b=NuKi8+9aCEPG7NoMyiAlPkABJXEUTT+8+1V+Sgmh1CCZ6bjeb8+kmvvumxqVU5vOHHxiCaxWIKSxRDhUTJMA5kCOW6ag5ld4vcCqh71AkCcpsSR04P5yxxrvv4QONO+J9fMY7HFtSocxwqajiEmw17u4Vkqp+8e4HmlWeZgmjBwYrfl1UWiVCwmPQhSR2CfG9fTHocG5ccCqxCPMQ/ghgHi4DB0fdLZ7xPBNTCTTI5LwYTkm5cz/Kjs0QNwvrxVN7vBWCI4vqIt1jw2jGcNxVf9bBMfRDdFbd0ewjVAXwjcb5C5k9FVc1dFi/oJCWBOFXQ50U0IEPGyjF5wx/5639Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5137.apcprd06.prod.outlook.com (2603:1096:4:1ac::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.27; Tue, 27 Jun 2023 07:18:19 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6521.023; Tue, 27 Jun 2023 07:18:19 +0000 From: Yangtao Li To: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, frank.li@vivo.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 01/15] genirq/devres: Add error information printing for devm_request_threaded_irq() Date: Tue, 27 Jun 2023 15:16:52 +0800 Message-Id: <20230627071707.77659-1-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5137:EE_ X-MS-Office365-Filtering-Correlation-Id: 59c7243b-d573-4ca7-edd4-08db76deae7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BMuimp7YIXmbJcYdHfRwr0mPIB2kRS4bhtcjhs/CyvMe0GTjViBkRrquU/ldbzyBK+HnNvjG74mPYHA7gOPwr46+22R7KOnix0VL3botXy1F4QxzV+Ka/U5m+CqpQMlfo4I3orc6DLfyY4Od89C3U1yjfPRj4Bqk7np7Ipr827wLH+AtcYZNwuQh6fDdP/saWyuQsh45FbrpXuG8D0VPA6Nk5zypVBr0JXeU7Ki72kyR8H2l4VWYVhWzpXmCRTzhvhIEcClzgm9mnYlMesGIno/e525i2jT9IbN3BBzzufMakYmkLLdR2noql9bsf+5GsxccEw7MoKfezEXspnJ7qDZxGdxOo7nt+b5XZFDwVIgH9hO+arI1E8RQnj125U7T4N3x+MUTCMXc05hSYgn5yWIhCmCHyD7U1qr7YOr1GPJe3HrAi53uR9NvHF3Qiwk3HvLHN1U1tVhkaB4Br1oQ0lIsBcEBtMe9/oKEAQgwDl58zuH4t58lnCw9j2ZfDaVAjw22sgxSnQj9GDvJfdmCixMhYhv4xmAfPGN37MB0FFxA58TMPM5iXOnG8inwe1GbJuYu1tsROlEtqDUBD0d0W41YNHgAgP9vxVbFYuX9ucdymkaHFA9Kp5PGlZbp/hQfCJqsMj7+3uRTzLmnu+N9WA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(346002)(39860400002)(396003)(366004)(451199021)(52116002)(478600001)(6666004)(6486002)(1076003)(6506007)(2906002)(26005)(186003)(66476007)(6512007)(66556008)(5660300002)(66946007)(4326008)(7416002)(38350700002)(41300700001)(316002)(8676002)(8936002)(38100700002)(921005)(36756003)(7406005)(2616005)(86362001)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qLWCLn6Atkpmn4V9QXQofQM/y+zY3+Phjs3YQpk8roZYbbWC3DlUoMEmBWqM+jGwprheKz+OyWrabLR4aw04cB3MXmAFKKRsTpo9f5BCCjX2iIAAiAewFdrJnV998ifonD4+nImmQW+nbvXGLnS5s3hyMfTLhnF+vFxjBEvsUEdKXbTOm/LfFruuwO2D6CrMxjG9ahvJr95TwNXegMCardugJRZ+cX74MOO8oe5fWg+YMWHq/PmKNpI0P0rXpOVjwIcXa+IIebo538LXlwqGcHuip7a9srJ8pbjQSi1Rwxq1pTtfo2EgcXLysymu01NiBWqCuHGFLD7fvtGh8gBbthbQiMQKA6KGStfeGBqrUzXQ+PcTbhVTrjxpa3AFhJ1QlByYnpIjgv4VdAT19KsX4nqmjUF7RBdIEbuFlUz2whbz7kwmgufCRP3BjfZRmq/QkgRlzDMcp1AdVoK12UjixOWcv0AI6tncDKwZeSk7W0Ln5zgu4NPNYOYCw4ncIF0NzwoVEYzMR4YdPLvvWvKi8eYMW21JofJ2KvylWWtEyimwnqvn92n2JIXtQKxsQywpVfQl+k4q+eoeonk0cmkfaKa9mG7cozugKy/wooUJu4MelO8Gk6HiWc0pJAwaTKdwjK7FDx68fh7bMneneI6/gvzAOdQujeub1011MK+45NsYlvpZhMWVd3PMkAEPFIO9H/8Zge65DhATHKlgvxHEIlY5t5ZmMhMAwIC4E2nCZcPGrOYl4rrjHNgy5qWWFnvyeZPZIdDdtggTB609QEz6pK99/uM8D+mOd9flqgOYPVumR3Z3umKRc9crxs5NNZBnWNRAKdQwAFvyiKmJK/Q7089lP+6xMj49sv93HTqGxfjKg9Ujm2UJ8hw6FIoBpq24QhQoFo16ESPjpYbcKk5Z9rkxJkCpgWPwU6ru8DMT3+1eqSkQl/RIj73HPFwIp5AqIqJC7KYAfeH7WqgdKnt0IE/cBEOxz8ywuMWMftAQyErgpcrFasDLJYiNxL+ls5Ls6gpE+FlQLuDXM5YnSxGR5wbtCfSp5Csxg8urLGlGYkpDUUOeRysxmWbAd0bXk/ea6ctY2bgixjDDhfj744zRnaqyzYNi8Ur1JRNZHnGyCs6hwU+QKKhPFIyrRX1KYXhkZ3cXjOl6WAJbOrvl4ZoGXdG3MO2ChXyqmls8A5bm3qNVqEglRH3Oj13FVJmZ+JcXYR4eceUXXAzeoWOlALn/HB3nAAGddDRnAoyVk1GQohq728vArmijHFjHJ9fH2qT2PPk9tFtYydQbKUUWQY4SBx8yYQNpKaLf2+XNEo7RFOA2t7V5JnL8TdtwvXr7pNS+I6rpsFCy+VTUd37OKB+wELA5Z5y3PkHfOsVAZrDM3pcy168VV8ubp40i3/OKc2H+JgtcOUDugBMqD5dBgRfiP8Vgy5M8COOmd3TqIgx4WPV8THB5CoAuDnTGh9dX2XKiMJ2lCWFWblHrOb3/+8+U0PO7P9S0qVHEJUedN0dRpT4SunS+af0JPuN4LpKQs2HfpQshvp5kTGJTyCUd4nPYQld6FFmmrJXX8bgl6SjtXfzXq76MEB3U0eGVQeNuC2Ui X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59c7243b-d573-4ca7-edd4-08db76deae7b X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 07:18:18.7400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GBm1nYiZe272EoTZzTUHqEZ8CHM0QqaA1Yu+Dhzxv9kiYwTs3Ns106LEgm3MVXcwuPZdcjOFYIT1p5E2uaff5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5137 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. There are more than 700 calls to the devm_request_threaded_irq method. If error messages are printed everywhere, more than 1000 lines of code can be saved by removing the msg in the driver. Signed-off-by: Yangtao Li --- kernel/irq/devres.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/irq/devres.c b/kernel/irq/devres.c index f6e5515ee077..94039a915218 100644 --- a/kernel/irq/devres.c +++ b/kernel/irq/devres.c @@ -58,8 +58,10 @@ int devm_request_threaded_irq(struct device *dev, unsigned int irq, dr = devres_alloc(devm_irq_release, sizeof(struct irq_devres), GFP_KERNEL); - if (!dr) + if (!dr) { + dev_err(dev, "Failed to allocate device resource data\n"); return -ENOMEM; + } if (!devname) devname = dev_name(dev); @@ -67,6 +69,7 @@ int devm_request_threaded_irq(struct device *dev, unsigned int irq, rc = request_threaded_irq(irq, handler, thread_fn, irqflags, devname, dev_id); if (rc) { + dev_err(dev, "Failed to request threaded irq\n"); devres_free(dr); return rc; } From patchwork Tue Jun 27 07:16:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 697129 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8012EC0015E for ; Tue, 27 Jun 2023 07:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbjF0HTL (ORCPT ); Tue, 27 Jun 2023 03:19:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbjF0HSq (ORCPT ); Tue, 27 Jun 2023 03:18:46 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2108.outbound.protection.outlook.com [40.107.117.108]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F5731FC7; Tue, 27 Jun 2023 00:18:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7kLW7UXfNulr2B0Ds5YJTJiYVSope4bkxdLG4+9XREnoxHEZ+AooZJ9HVhrLBlDwiETGSiSR+stRgfQiA0YtDGClevg2BrMEuOLOMN98LvbNwk4ABvFWTYc+OyY8FI2VcENdKZn99FmIGdKPzUJ5WHt1l0pu019SBxyJXMIlEl3yWaQeCX2gpbDElf92TufY5eOPxAxTEijwsMDnIr5JK3VBrvzLmlDL/wMbr9rbRN9GzZws+I7MAa9Lp7WiW9KgGXbc3pX4pNhorU5eu3eOfIOtjogZR1XT6riMfXWYlFABdHa2AjnMKvIp0S62k8r/g8ZzLmp6+6kK/K6hTqU0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+UQE0AEZW65NsiV/uGAbT3rdeapcj3tNcNmQMa72/UQ=; b=f1exNuxTusMuOgydFqRp8qFZ5AkYMDdAKO/JxiqW4g4U9k3Wz3W94Td/Bp5SBQt+y+gSPzo/L6qNGqCSaP/PlWf0sBR5zLxvPYsXpZ7xybati/KWlR21iTnzpRSuKaXYWbD/jBsNhKo4AmfIMd0nbkbbbkCYGVVRBjzJbvr4mGTLIemmPmojczeQjIdWHs4d2SJDRl+oXfgWuYa/nhPYUAKNNiLlFM3+0dIYmHQRv5w351BPsmujEGaGsoGIWHSGTTsforA7NvpbDJSrbfLUp32/hDManxzSlKV8CrZiAhhNmEwZerUS0gmyYaIH229U8dYzBv1UkmtEfWh/ovopBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+UQE0AEZW65NsiV/uGAbT3rdeapcj3tNcNmQMa72/UQ=; b=AAsvYOmJwScj3mqydd9YQhFJ5qSbpqO894QCeNZFlhDpDVATliPhsSiy5gtV6G6PU+YhgTQiy3MFbZz/TswNb+gd1/GgEdJ8PdCJrByp4XSCcxDGsZKEqNrGXasuTYIQS4DYGO+sBQ/urMG/6nLqd9tP3ycls0VPBtCZq+MqKIHIP3RwSxHTkeMQIEmgnWTRBF9MGUmt0ERqrV0xDyMeZZIibFVCHxOkFg1E+J7ECGvpkm4BCMKgUgN2PknkuErqdIL3uXGxtl99N/XcvuvxWlZVFiE+5JYHgZqDYgUiX53ZJLh4Peg9wMUKCCdr0YsKdmltSGGj19JbDC2yGgqTbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB4205.apcprd06.prod.outlook.com (2603:1096:400:2e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Tue, 27 Jun 2023 07:18:42 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6521.023; Tue, 27 Jun 2023 07:18:42 +0000 From: Yangtao Li To: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, frank.li@vivo.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 04/15] thermal/drivers/db8500: remove redundant msg Date: Tue, 27 Jun 2023 15:16:55 +0800 Message-Id: <20230627071707.77659-4-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230627071707.77659-1-frank.li@vivo.com> References: <20230627071707.77659-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB4205:EE_ X-MS-Office365-Filtering-Correlation-Id: fc486a99-0481-4a63-5076-08db76debc59 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WluFfQi2WYlUQ/YfjSjRzxIZK8ZAkPJqGH492xl3B2xRt7zf+jYexh1ktsX668vj9569EH1MfiLWWPuXjctDmu3BpxdT+xczXnI/kPwFfnhggli8YI/Jm7js2clm1rt9L7/pE8FIdas+kADT0sCYfA1rUhk6c7gTbS+C4JWpWbPXn2RpsPZl0aP/+GQumcpWbQrOIev1Sa7iqE6qBOlFHYZ/CQRsryXOl9AeQy2Vc0plrkkZqWnYPh2wsDNjLxDPLvkMyGFLDuOSUUwSTq6/FczaNPVC3FaMxn5p7I1ZdYJXcUX5UwxaQBprR72TuhM95RQ8CRN9TBUe19nB3zDaUZAwYf8o+YDVoDRNXpTdZFSqagj2vI+vmJKK5skVt5sFXnJW45BM5I1WRuZzDssQQEDVNj88Yz5xlaBY3okbjmVWSXRKnFcIXpk5/StQRy16Y59STd3kZdPzQ5eZyFbe49h9z/Eb0gvbH4R97wyhhTF5QON2+1bNMiNc37mqXQEzEePFlOLvgLQGay+H887PVrfnvIV97Om0CW/NV8TNIuPlldQqiARvzyJnTbjKa3VnsNM06a4NmFGC7To+kOgjpl5972L1gthFHVYCiWxdk4mm68wEwtJLot5o0itlveTc2EZfdwjsjxKtMh65jkcufA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(366004)(396003)(39850400004)(376002)(451199021)(2906002)(2616005)(38350700002)(38100700002)(921005)(83380400001)(86362001)(66476007)(6506007)(4326008)(316002)(1076003)(6512007)(66556008)(5660300002)(26005)(478600001)(66946007)(41300700001)(186003)(36756003)(52116002)(6486002)(6666004)(8936002)(8676002)(7406005)(7416002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rRS49Ydsdqtvt7Q+UQWT6QSxUDmYs3WY/BEGsLfx+J67joxwqJhHd7Xe8cQxDp3WQuHFGwiZbXkJ1G9g0rBNvhHfPcr9lB8tEv9gT2BLmol8MNuS8PrA/f4cjC1KQFYWh5kXwDCJIO9Go6bZZ9CutIoBZtepytZV8mmADjk63vAabn2Lj8VB2IHQ+BPyFBUroCLeJdNTTlIgYNIA3vRwLX8X3D+cW1c4LQWu07HSKqXdWM7H1Iw03yFWYyhSZLAXGpGic/S+MIOLVsvO2mrzRfShBTRZXWkuJ+r+O4UC3W6qbXlHYOXYGRV4+IqaPt5G8xkeoiD8YbW7LkPzNoZ4wuYgXcXcPHPvYJB2Uy6o1ai5Wc5ma4LGMty9mQz2ztq+kyiGJNWfBd+fna0+wOhdpSLQLRjye9vrnF3qE2yGCVt/OsTFFQZbDvXI+2OI/g66HfmmHhK9cvZDxdR2VlP8FtIYkv6wumSRyeJ2vGVZRSUzw3RbZoGmVM39I82LhFgpw7sihC3/Hgdq7ZvTb5tMw7XWoddHig5UyM2Tm2TMqLB/tu6Iw39ml13omS+o6ZckGsinZsCvj6Q/bX7lNjRDxfliIZlzg8JWoys18PZB/3LFtBIFrMNrcL1rYH15R2Q7yF3XaaqA0eE6blZL4XqnkmvJBMyG9F48XXLy1xY3vHhTDR/ApdS4vujRgQQfgaCdTA52ncXkt7GRMnmr1rVjzRQpPgPpJMqYrjHpk7+F0BEbwr470weR5D26J52KLHlDuoIaSaio4Mkgfn7U1ptXRcBR/ffuGGjA5R3rvruInY7DfESXve2ppz1OMQ+1nrisI67+JN9zZxkht6gs0a2IzEnzkBJBrRwFnJchaIVwjF07X6Zzrp4Qk2tYfkPINSkMHCsyowIMSj8bkCTg8Kv0ClZGudCPiBmRcXD/uvNvjJS8DE6CSfUNty4nd7Cz9oZUwrVe67FWjrT0eCqJcX/riKtJuahM+Z3tPpaXe7fBTqCYwoxa2MFqmlHqc5yOPcSFPfarsAAG3yw1/g7my6JBp4iYrndeoZK8cmIrwJush7Eh9am1DcryzBCk/S/Kesr4ySE7exrHmzOQyorn+wmZBCDi6adC0CDZGHlTpYyAufU2mKgWV3HpOJyZrQrasd8gcuG5I82ljgnXGD23QEvi5Ek/UrS0pX3Pjno+PgSMFFvmurSBxuVVHvtL3WjwmH/+5xkVx7hfbzxp13F1ZjchUVzEghht2wA5D1bIS71nlDv/7nttN4xKBaIgGwqeJpVegLsF/lH5LfN93xs4QI0FjgaM5or9CxpZIsnI+cY5cPW9ix2bNbquEQAef3cgVV8UpakeeptGOAHuj68E17Z2cxbl2Xzh7gXaqj4WNS0w/bbz/uqB2Jwz5kUwROWd42Ipjy/lYmKIIJyKxwkPr3q+fqy9NwnviQ+rR655EmyxQh81diFOKCyuBDGIkwy6LNevyszeLGiRMUBXEkEaQTtJBViIUpj+mDpxo9lnXQz09xMz/5agnuiTz9f5pAqtHOSflw/YX2kYq0LGSxrXnWO7CKEeXAK7IvzWCxNIk8V0XmtlFPWI3idmyRJe17GlaoRX X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc486a99-0481-4a63-5076-08db76debc59 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 07:18:41.9507 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iHSnfDsdRVpSXx/PKVtQO4C+8q8RvyMfodmdauwinn5n6rVv/PybZy9cRUxSJB9zCuA7TIT6EBJwTgn99Z/YCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4205 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The upper-layer devm_request_threaded_irq() function can directly print error information. Signed-off-by: Yangtao Li --- drivers/thermal/db8500_thermal.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c index fca5c2c93bf9..0a890d1338cf 100644 --- a/drivers/thermal/db8500_thermal.c +++ b/drivers/thermal/db8500_thermal.c @@ -167,10 +167,8 @@ static int db8500_thermal_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(dev, low_irq, NULL, prcmu_low_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT, "dbx500_temp_low", th); - if (ret < 0) { - dev_err(dev, "failed to allocate temp low irq\n"); + if (ret < 0) return ret; - } high_irq = platform_get_irq_byname(pdev, "IRQ_HOTMON_HIGH"); if (high_irq < 0) @@ -179,10 +177,8 @@ static int db8500_thermal_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(dev, high_irq, NULL, prcmu_high_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT, "dbx500_temp_high", th); - if (ret < 0) { - dev_err(dev, "failed to allocate temp high irq\n"); + if (ret < 0) return ret; - } /* register of thermal sensor and get info from DT */ th->tz = devm_thermal_of_zone_register(dev, 0, th, &thdev_ops); From patchwork Tue Jun 27 07:16:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 697128 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D2DC001E0 for ; Tue, 27 Jun 2023 07:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230337AbjF0HTO (ORCPT ); Tue, 27 Jun 2023 03:19:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbjF0HTL (ORCPT ); Tue, 27 Jun 2023 03:19:11 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2117.outbound.protection.outlook.com [40.107.117.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CDC12130; Tue, 27 Jun 2023 00:19:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KDOvUj9csUGXYGq/siKVCbDnsQaYjexXIlsq8+l8yoAudwwKsXjsZ56OgVSVqsVrFZ/ImkfiUftgWP4Mkgl2eMTQ+hLnEJfiMxmq5Imb+3vY0ygkoUwEyhKyvJ9dK5XlvNfNBJEe7aOADFxqufYBA5lCH/hm0VUaDpPXInuE4KbSCI0DKt1boOE8Ah7Ar6Rp0WWgfg69c4xE6gvSzscbGlaStY5FXtIHJ2Y1G+LpcEuj2NyW2CCCk3tPjl0D/A+pG3Yt+ERy4xp+xsKB5NkZJwyiQxouZtnB4F7t2qdeHBb2bkLZOJTIdwI6yGBeSqPFzmvBk8hCWSnG2b7ilsU6gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SilFgsAMQbXdSQR30c4xs4aLOy8alWsnz6AffYE7ars=; b=Xth6uZ/qn8aTK/6iXyFxTHTvg4DOFGxrn6Ld0sSwU2Q+qyDG/9Lq5i/aRUCsGVZ9qw+DNozAjzwLR0DkoGgyuS+E6tVEUCx2UO7WS4ydAn0dfFbQF7Kcpyq/DkRFX7PUGxBzB1LT0PK+aihQ8p77f++JINdKIdmcNlZd9lx/ndZXndH9tpVjEKWYQm3Ne1qLkv3dl99gEv6v/sfJraQB/3YwYqWBOR5nwwnbcJZPRMCa4HAWfPqb9Ai1rmF/MZoUys6nX0IdKEBz757kcXqXjLOTCMy9KWq88wm5lhtq8tUuBNNtUpn51Et1hgMK592YQPwfSH9dfUmpHAQJu5R3+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SilFgsAMQbXdSQR30c4xs4aLOy8alWsnz6AffYE7ars=; b=hdTv0pYOAfFO9EKU9kehyTAJ19cnOt9jUOo/WE/fhvL405+z9AqYODVl4nChR1bVDvRVM3m0ToT/Fj9pqaSXj9fl+om7JovDRyE6xmwyYJ/4qT94AP0UtGZVQndIVI1zDY9gXR5PCJUw1xQMtiaT8+tsaNnjYPVweH+ZRuB7vLJDbap91a7YB1ZjiPwr6gBbylmAXlREhnUphCWAGkeQk1g8dC2jYF5WAvRG8DxnloD9mt8/6kFqxM1erg1TNUvxOGShLVWhw/ymrjlVYTff7sIeZNZzmA353TP4hps5v1W9eqI0uF5UpBnd62bglJSfUVQL6U4CwguNOkRsRKLYhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB4205.apcprd06.prod.outlook.com (2603:1096:400:2e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Tue, 27 Jun 2023 07:19:03 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6521.023; Tue, 27 Jun 2023 07:19:03 +0000 From: Yangtao Li To: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, frank.li@vivo.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 07/15] thermal/drivers/qcom: remove redundant msg Date: Tue, 27 Jun 2023 15:16:58 +0800 Message-Id: <20230627071707.77659-7-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230627071707.77659-1-frank.li@vivo.com> References: <20230627071707.77659-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB4205:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b9ee0c7-c894-4e48-1a9f-08db76dec92e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y1v9RngV3a2KYo7Xj0vdyvuwxPpfRacfMIDsSKBgx731BvWrkosWiNpSVFqWzLdUnQCwIrHhYiBq+Be3W3s51p1mFQzTI8z6/Y92JsQ6dVst3Qrz/558zQhnMzvTuFI9l0elALT5KuHNuvGX4DoYW9ivSnauQa8wjfbMxS1C7e9Yso7vuXBeJP5ux5NcatWQvuCBwrbKpXTkVfC+J9Xboww0rfsul2rHEwPZf+RBe4gSZEMUUvSCDuCBhdgGUWngVpVMTUQsqq20zyj9c7zeM5l9g2VWXvzThBAaaRtNBC0UhzdZE3q0bfxFOoTwgnF4s7BtAkWYJGuDG9cZtaQij7O1msaJUW3nDIfUsvaVvZwxiUm/QWaLQdaudkyVLUSSFtgOTlyrQHeoDvALP/vW/6b6FAtVPX3fURX6CiA06VvLv1yJZ9N8aw3YHo8iS1Yzfs2Egs6qqXExmk7K6fohoe5Dk4ABldCbk2yjanO07ZUTQTQYOGpVNlzkwB7KVZalL3pnxl/lHCE0c2xPfNFD7dSRdkXQZIJQgFrGMbh0pBFT+1cVsJobOsuiqnJCTo0r4NyKU2Lb5zldLVIL2KV2jxeny4hTZSycr+0HIhhv+18p35jgRKFpPiZUwvncXlt3ZW+YejqfCVSMTo6OCkL3+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(366004)(396003)(39850400004)(376002)(451199021)(2906002)(2616005)(38350700002)(38100700002)(921005)(4744005)(83380400001)(86362001)(66476007)(6506007)(4326008)(316002)(1076003)(6512007)(66556008)(5660300002)(26005)(478600001)(66946007)(41300700001)(186003)(36756003)(52116002)(6486002)(6666004)(8936002)(8676002)(7406005)(7416002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: foFQkMXVLukeg7XChlUzsoYJzdky48QSPkzlcJE9Zf4JWXeBZB7Ypf5XaVe/kCZ/MEOQghj7TN/J8xHjDBVVq+OwZnOql7uc7U5QkpmPDR1Yc6Pc/wknMwRIsXhOp0u4p0YcJtfwQ8qU53pxUCEqVV2Jr2LW2tWJrQRmax0HGPSWA+58s0ZKZtlkyBSFxCBWbTJM9HiQ5XdsJn1TYK5/nOjwHFIDZx28lCTnJjJCZJO4gMSUfAC5ICN7bcUjamVSIkBVayE4Bnp0o59ABoN69QIfBTndGbF49nJZpuqb3F8UGhBmBSxRZUZyd04n8vlCp02Ur4QZC5MleOXwfu+xZ2cHJTSDdSKgJq5uFUcXbNEKqBmQwIbyS1pwUtYIXMoQq0/2p3SrmuiJJlU/nbZftQMg0IsoKQ2ihyp0orLi5KOX08eogeg8Szf1l+DCqIyQ+J8dUtDFda9JK7DuOzFsrsT5vmHW3uU5zvPcqS0Ndt/gPASLGETO/PDjQR3mpoONu2ypPN2HCLVM3WPHMfIGFE2W/GLQFetUFHS1efYAJ4t+7fAult4zoK8NZtE968J7LMP6np9DDTI+7O4SIAuZfthv016kNzgsD0Jie15wvXHmhnvhMByGECNtDXuNI1AxbA9mf0f0wvaevH4vROWa+/9gds4Hv4SnRYanIl4nHE5tlAKnztDpJ/qSm8H3Z/HcwBJdscQEAmppCj8u6zfr/+CvynAGfPFGBVrHzhHaS0AUPvEu3KYI6xmYjnJBoV9A/veJxXY1DvNoMulQPiEq7uwQK6CJxy1vgf/kLcD0ttQxf1gXBuJX1LuM24oFmwPqLJzQrW8R46UZUBRA9INkrvvhXOWaZJEetP5svfbZwlc4vjKUBF3Jd7/QcuRFeTZyN2sCv0wfEhMZdGh7wuz/3BNx56ZYhLPYV/7UhkmrHHoP6mgoZ8+/w+bJ9aIFE+b2MkUVSGyFFyIK0GLSfsu2HGWtwECfzrd6GFwbUwmLubxg3QBqO6kQ+M8lMCgbk+DSIVKuD+e3WiJyyoi0K20lge9WSZnE13YqSxk32ejIoCrzEgEM5SH93oZN1jh7cz5OoO+hG8hnMB7+lU2EVwYkC0MKeFtj74j4jmeNkukOkK/l5gzFBFgOKpAL7tc5SyS9j/VwkqILOiqH7AjjOYXmsc5a8Y4pFJ2IQyiShDAOTovB4kW1FXFvmXJXi2p/6GJLmiYBy7gR44emQcMb4x4/EuLHDf5qzf6VE51JQ/RhQLsCdsDr2vBUj+4c6GoGE7t2tVAw2a931rEW72LujWxwWrjBeTQJB52DevtDPfHk3/nVCry60dio0jt0vxAyBSjMtymHjQ6qFCry+p013FHT2AX0q2bQRivenrnjMPkTccQRz0zptjWHu/1poo5QP7YYzKs1vOXBplUudcXxulZm6CsmYV8IJWDZ8VmndHE7J4AQr38/vIMHe4IGRN5lG9sQQjobyaRpXws6nVRmL61QTULqvmeKtwNgNrb7Bb42EfsNTlKicf0ulknPzjj63fTO1Gw6NwYYXW6MVCq/ehm3UbnAi46hPEhYg/cIQ8zTUT6Mr4Ykvvwvcu7jPqUeDJ6j X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b9ee0c7-c894-4e48-1a9f-08db76dec92e X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 07:19:03.4961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y8EBXvf+4Ogzj/UgufdztN/vNgGiiHOUfik56ItZW0qJiEVvdgSPsW4xvq1xow0cYcRByqECUJoCEO1mARDqdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4205 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The upper-layer devm_request_threaded_irq() function can directly print error information. Signed-off-by: Yangtao Li --- drivers/thermal/qcom/tsens.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 98c356acfe98..63a16d942b84 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -1182,10 +1182,7 @@ static int tsens_register_irq(struct tsens_priv *priv, char *irqname, dev_name(&pdev->dev), priv); - if (ret) - dev_err(&pdev->dev, "%s: failed to get irq\n", - __func__); - else + if (!ret) enable_irq_wake(irq); } From patchwork Tue Jun 27 07:16:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 697127 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B701C05052 for ; Tue, 27 Jun 2023 07:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230104AbjF0HTe (ORCPT ); Tue, 27 Jun 2023 03:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbjF0HTS (ORCPT ); Tue, 27 Jun 2023 03:19:18 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2131.outbound.protection.outlook.com [40.107.255.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A28D1FF3; Tue, 27 Jun 2023 00:19:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jlIrQsUowEfSE1W2d67znryTEuOGPPw0P/PqFUqcQkM2TnCfFaQ9M2/anJJMtwq7KTakbkYSbucPP4eenMipSFyqKLflKDP2iIU+2DLuJnYkWYgVddWA33cwsM60EO4KHIaqn1KrEQI+WixXVLHdquQxCnYosyBTdsds/aMeLIS1W08RTR4PupybE9AgxjAOxDkmEv4HB2MJAjKNaQGXWgx973118XpJmuymAFaVnRft3ZirjXMdg6FqUZau8UIeWPIURrLcUxmONwo15fFBUCH5gbEDeFFAmt6FnHxXXqXBKBxcI0vcCqmS71X+LgEkmQcDnTCCbAy+dlhsefkEzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/6/GPomcj97CiX6Tq/X1JIri+6OnHfOyo5lzfljPCc=; b=bB90roR9ikCj5dTzw4HNXXMisZD6OADROX8IJj0XEoKQ6T9nNATwNWb9uJ8erNSmfr0hmiDsVLBRylUrUhJ8KjOxzKwHtvVN6G/WD1dgw5NQMrOIrA/H7QFw0wbSntmKObPhr1/5OceViE4KQHPgVJeXP09SvLB0s8KvrTO/paCbh19Zp+Jlaw4LjCvukX/8kamqWqflsD1oy4UM9yYbHs0FBsnxO0qw214bE3mowRIIMhgMpjNPezszKqkqPB79sxbrQvqiWsz0kGGv1ZgWTDXmOMQWdiEN/oZyJ8SUJXekYYQO5zVhFOaw98iyJuZ6WeAJaoJ/ShlPM7g2PcExmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9/6/GPomcj97CiX6Tq/X1JIri+6OnHfOyo5lzfljPCc=; b=mpAfHzLKibbJbTH6GumZVMk7WcPbaBM4XVZPhL7PBYX8HX9tuL8EW932+3QalO+SKNiocny80BMI8Bb2E4H+FsHTJKJYjlViI0E8LWrt0Y5WRQp8O1bdD4QI5aF8Ad5z1mKELaofbxY/8S/rEIibnxmFz196Qmygxi9hNB69ers6CQXcWFdGNUNNf6voa4vjHH4Tz0fzDw0lOBE5s5zm6KEKN/+eEDOLim31/J4zcozipTXnDGvIF8hZazoi5ON4JYNflQnnNJKKEF9wWxifbkv81esEo3QoxMhdRevQHZHW/w84mQkqCJCbDlDa2BV5+Rpz486iU673N0go9buubw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5137.apcprd06.prod.outlook.com (2603:1096:4:1ac::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.27; Tue, 27 Jun 2023 07:19:10 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6521.023; Tue, 27 Jun 2023 07:19:10 +0000 From: Yangtao Li To: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, frank.li@vivo.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 08/15] thermal/drivers/tegra-soctherm: remove redundant msg Date: Tue, 27 Jun 2023 15:16:59 +0800 Message-Id: <20230627071707.77659-8-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230627071707.77659-1-frank.li@vivo.com> References: <20230627071707.77659-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5137:EE_ X-MS-Office365-Filtering-Correlation-Id: 17b71bc0-d5ef-4d73-b731-08db76decd4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KFnpnnToyKa/sU3217xLoF89878YeV5eNpIKQD/8OoYYXZOpPlLh+IAOdnD+rerirkUHurZOmBT8qtC0NmVa9xXB7KKtcc1N1DRDMhQqcvs6jydnXAlvj7VhAcTbdICeE19qaqMxN5M9MmOp8tiJHxl4CjlOMxdvhn041nLqBACK+q2Wx7ByTMDSpyPfnw7BV9QgEk+aPPsIH4bcCjveTpbZrQ2n2xst8X/HOn5ZuS+RgQK8EaIZD4i07WKSEGVYGndwICs+z8kB9HkUDeGnpJ2DhtBbwrQYcqmrY+CrKVRaAWZJwNCPav5OwB4WUGQUaCDoXaYUhlrEmj9zCZWBK64Rr+cwbrKbNIKeQowtW3TQN14LtqqTQ2V4/y2WZwksSfJ9TyGcg8ckRWawiSaIZaNB4dD9KASD5rESCaWusMCUsA2EIuUqFtxLpI3lVXePulChFGovL9BfRKZSNoQscBnTnC+dXE8NFbny9Yb2Ke+l5azbgNv9LxAxn8dLAz1G35RvQPsCnLaENJ6wnqYGF34hHRTriI5h8FbGzoQ4HhVbf/A1I73xGsFTJh1LXu5fW6quf/Pp8UjyPmsLGdS6juwF8jKo4Fungyt1lcgKMH98Vv+UwMH+zOorIy9iWnWm X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(346002)(39860400002)(396003)(366004)(451199021)(52116002)(478600001)(6666004)(6486002)(1076003)(4744005)(6506007)(2906002)(26005)(186003)(66476007)(6512007)(66556008)(5660300002)(66946007)(4326008)(7416002)(38350700002)(41300700001)(316002)(8676002)(8936002)(38100700002)(921005)(36756003)(7406005)(2616005)(86362001)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZVy8LkYR20MmowpUVfs9T5nt1fcbPsk3ZHkpw4NGalLkbtzyfOy1InjiraRapqxRC1aooxuTnYFPx1GluEa35p/LAPrq+mcUoh6++EWXOuabw6zonk5v8L2Z4AGbMORfLYs+vHWl6GPjzSgdJBtmMru5Oa1l0r4sHZh6ghLrz7NOwkhnPqmT/hHJd37oXIwk7SX3FqBmcXYpzAFbTZHdd04PbNCNrEwZpehA8TF5m5KbrtN6hSbGnd4JC6uVf6mJO8P6QekfKGll1gl8lwRb//LalwN3LuynHEw/KyUvbsVhBl9LqppZ+40mbJdNFSOVwYs6SQ+j7wOtBeUPcSoJgfBIcNsxNovAHmrfE/gRtr90EA7tJK7ZeIvHXys3+O4EmKuKecQ31kjELcn3JNXBRLx98CKhZ7YZjf8vFAUsDtoEPYrRs4XTQwWyB0wuKaJhJEJHid3vIG3qwfjems8Wwf4yGsVRgGo8FVfG0SNKBYr0GOr3kzNpI2/t20WlcTzaKEDFdO5WoP5vNcLDMXtzh8m8ImxmGUDIfNpu6GrLdKOgkybdtRHc66h0az2L4y8ZDJ3diGYOQJcwRVsPh9WR5pUzcx86W1OSedRJD/2F+iazBxgnJ65AInTSUkg+zYYJzejjd1IWQczO6ZeUssEdZW3yffseuclkYGE0iMOSpvUC+htt5hxxb6I0d/NBRx5w3Rj8mUN0QvkS0uYF3t5zOl9VZZlBp7XzeOM2+wJfpRuSvYaN891FLGvGVAvOdhItDBnMx8tnRTkNzYzHmfqvBD2uMDpRxzbfeNO/ZQIGNNvyCWNUiLTq1s0hJ+sBtMA3rFfrg+0Q7T4evm+jILyvsI1YfroorE57BiuPMWSRdXNFWXoPNTxpUVRmENvTDnRsI1YpqdKDiDFz0tpEk+8wCO7pS4iwtkwxQsxEnKxOYHj+RE9QoB7Nhadc6Jnt/qaaaS3Hr4+MrvX/bpjX8/USqdJ7Oiy95EQpgGsPPtVw/IKMWo6zhWmBWAI7vFGcyR6EgpegE8adsntOKcbb7qMRx94G3/ADCU3hOQkozaKo1BooXXiJRhhPDWBsgUaVS1XGY/zO64S2NMyhnB0vcER1GrdeiJbIeyeopCGieG++wy+7Rg/SExELBR8RspDGgCmzYLyNdiJvJUK7u9lRVIfWSx5WWkVSTpqRs1S1upbhMlOVAnpU61W6tnVxVDGsi7TFtE+LnD2jHeMzIZhgdPbWb6ilKE6ilxn/Bx54Ru2B70ALIH33YQUAVMwhONwmZTKo+r9O6wd1RML9BGbr9LuS00E1v8e4iR4nGPGAeDGh38CylZIdpwMfHOaiYVPzSGyRb/Q4SS5X381bnx4aMjJAq9PRCbrUkNnlbGoZwp8VJ1MQOLGVVRDaNXpCKdw2ke0yVkY8AUcUTGMugYc2RYhPExgUz8BGiRFGKssIP2EyRooBdm6ZvcOHvYwWju/o1T35T1ebpGHE9D693AZLvcVp5sZ9FT2AQqOyIF4+J3uyTdWVFnwLs66ePeYPEYIlSWSgOYanqts/cHff0IlqVZ005I9QdTqTSOUIcId54i+Y46h/x3JZKNLQ9hdp24DFk0bJ X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17b71bc0-d5ef-4d73-b731-08db76decd4b X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 07:19:10.3888 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: luYBpswzUHYjrXFuuZIsHbsqf6vFTh/FZgIOnW3rCM6SRCnjB6MSiQyEg1TrVl586JmeV82yvFnzfgUqTc38Tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5137 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The upper-layer devm_request_threaded_irq() function can directly print error information. Signed-off-by: Yangtao Li --- drivers/thermal/tegra/soctherm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index ea66cba09e56..55966c0a2610 100644 --- a/drivers/thermal/tegra/soctherm.c +++ b/drivers/thermal/tegra/soctherm.c @@ -2000,10 +2000,8 @@ static int soctherm_interrupts_init(struct platform_device *pdev, IRQF_ONESHOT, dev_name(&pdev->dev), tegra); - if (ret < 0) { - dev_err(&pdev->dev, "request_irq 'thermal_irq' failed.\n"); + if (ret < 0) return ret; - } ret = devm_request_threaded_irq(&pdev->dev, tegra->edp_irq, @@ -2012,10 +2010,8 @@ static int soctherm_interrupts_init(struct platform_device *pdev, IRQF_ONESHOT, "soctherm_edp", tegra); - if (ret < 0) { - dev_err(&pdev->dev, "request_irq 'edp_irq' failed.\n"); + if (ret < 0) return ret; - } return 0; } From patchwork Tue Jun 27 07:17:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 697126 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF8DEB64DC for ; Tue, 27 Jun 2023 07:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229992AbjF0HUZ (ORCPT ); Tue, 27 Jun 2023 03:20:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbjF0HUU (ORCPT ); Tue, 27 Jun 2023 03:20:20 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2112.outbound.protection.outlook.com [40.107.117.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A56EE26BE; Tue, 27 Jun 2023 00:19:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q+tgbYkL4yljv8NGMjH9MkubnXeMrz0q0CysBspRCVCDVaXodWyahqI0MEFdjcf8rSQKhiNhkDtULLcYdrhpbIpzjp2inZHD70oMAyA0QGDWz5Z10DjNVhJahfxxCeDYq1M1718xA8Hgi1GsMJEm/+wqzEMaPhaWGnq0e1ovked7pgIL7BOl2OK7HweHqAe1YL+cfFCa/dTzP/tJpfItNK4Zi7LItM0UADA2N85X8zKbSHYdbuNzor+pZcdg9qg0AN6YbHbIaM4ZOpdRL+aCwtIuUbc9WukfQx5VXd9nvs4ooFCnNmWpWCseNBS6+PyKLxQrZTZzrsS1VCgLI++xbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vjgKyXZeb4Pa++8I8gRPsqs0ePfqjO53OpDqWyzv/zo=; b=TDonwbf7patfiueABPEIGRA9lyLCImR+r1SYxygSe0TSkIa6yNcfrV3GjcF1DtYS8bAlRQygl+u3zskJL9S5yci3q8MJpxavRfg+ZICS3F91TJE2xkPN7hOYYNSHji7AM/WBMjHFGPDUw8vBdpNlCEyrs9/w55nz33dKEJfpvRkJXx+yYR7qPkdeH5wR99f5+zx8+vOCynpNqPbmMfD3e9Xbp1cAF8VcEZRf4tQ4fsKBrqwN7TOOS3pW2JsN4N9LzjnT+2ngSGevEmL3PtZTIbK1zKnCKjthQkVpodknxDZCdhXMUkRiN8vdL33fmHFJTtM1N3K6GQPpPzDaT3377A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vjgKyXZeb4Pa++8I8gRPsqs0ePfqjO53OpDqWyzv/zo=; b=Uy+FfDkw9WLXD71SnE8+1CBCdxc7PVBXfO/syaVOSpOHAjAAgB9fsZnB90+2ZXqDtJ9QRu1MOnFdiFN6pQvvYzzbndIzVTDDq4OrARMXym0WDXPZuCTTIIZcOxuTJonij4VKJJeI4R/cbTK1p+jixfgnVXTzf17VVkQZc056UqeC6oZrB6b8mZQitaV9YMm7J4wC+oLk4aLxj8M3wuBawwgrIvMVmitj2jDM/s+HKLXSSk1PCtfvGOmQkk0kkYj6g33zco6GZdUc5WXnoKAav+zNafv57rkMQT0KrAuIm7PrdBdZysHGBCMuoibUm19Ccj8b3AzPYt3y8XSkH0QTaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4289.apcprd06.prod.outlook.com (2603:1096:820:78::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Tue, 27 Jun 2023 07:19:25 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6521.023; Tue, 27 Jun 2023 07:19:25 +0000 From: Yangtao Li To: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, frank.li@vivo.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 10/15] thermal/drivers/int340x: remove redundant msg Date: Tue, 27 Jun 2023 15:17:01 +0800 Message-Id: <20230627071707.77659-10-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230627071707.77659-1-frank.li@vivo.com> References: <20230627071707.77659-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4289:EE_ X-MS-Office365-Filtering-Correlation-Id: bac76a8d-1d7b-4977-58b1-08db76ded618 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hg3/eumoAeHzpq514NsPNmcGQAy9yZhxeQKWzHByR/ejX3CPYuznYOCTPzmY6zjld+QdIEXbrxSpgh0WHinN68aZ3fBVRR7JCwc1anCjiICkG1w+tvhSeD7CTBTKHBB0ACbjm11UxD1yaIxUzriaUKtHyO4uxZxfKu4eUt9VueXhFvT2MB/cxPI7ATpOdpeGwdP5dDXBFUvswMspD2ZqECX6tukPIbPqwVnmI5tni1fwsqIdCz7mFR0X9y4SfyS3QXl4Ux9GLSH3Uvv31q9jzmpB6Wl84lkUNwsa3tVc413KUdjJz28pHL4gs7nm7SlBmSgEYU5WYpEG2EPCPaekm4LCzHkvCKKHXBe43v9WFCAbZHLZyRPOh7c6aAaJ5a9Aqp98oKtbM22nPOQB+xzAWf70wqcOelB6GjQJ+3+BIU27X48aleZXFmlaTC4F+DK7vhaYzMyD0Yt5/KDdy4pDdVpIqAZ1jFuafW6Nt2sMK/r2dM/qqOWTzA5Ec8Lu6dm4RexEhcjCyNei1TMFk04n47MF5RlKrB9eT9wmVP9LIIqJW4B8sgqeby7LIu64YABN2raJgL0fQLpWDVgUp0DW7ktivzLWSw36ELmx5JLF4W/Oa5xZlE+3aJ7RkbimIc+SHxj3pYDDvOzkfHzqFIBjcg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(451199021)(6506007)(36756003)(6486002)(478600001)(52116002)(2616005)(6666004)(83380400001)(2906002)(1076003)(26005)(6512007)(186003)(4744005)(5660300002)(316002)(86362001)(7416002)(7406005)(921005)(66476007)(38100700002)(38350700002)(66946007)(41300700001)(8936002)(4326008)(8676002)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 98r8NLdS+Wb8hRZQzJPF2FFeoX76fCjTYYw5ojdKRc+L4wZZAV3PLwIagkQd4/qXMds0kU74XxH4c41zhXUGHaJ/JwO34Ym6jnuZdjmVN9U4N47IhX6c391j2y9617ebG4j0yqjMXY1daVqISSjdHuJTXV+s5PhZNTTDPnMsv3dDjcc47E8UZSQAyT8UtJT6gtrvkZBYadDhNtoLb6CeumMa1iQVLG6ynxgIx3428PzB1v8loPmnvlSroi26EPyAMYmR7MCri3194Zr32Grf+IN+NPqRHG0qitWKWMgESAPKsJuvDj26ZR0Ix/vgcjYa276OyUaYXUAqius5BrFh77IPnwwrxunFvN/k3XbfVlHpwNtvILGPxahPHYHOirykzdp3UUA2uSKMzeJpmPYVJwq9xSBi9yzgn3h/ESFLkJ7WxPW+4fCS65H2CrvRmd2mcd1/JE+cfaaRbYgtt6RAVS8YdXEPGI7NuWVR4bya7QcE66MjxGR0ZuicdOA1IF3+IAx3tkWfVu1UsNZNaTe67wystN0ypVt7AF0QBwnWwhiH6PrSvyi6miyw6/MgoMxC2kEJ/DoaB0XXz8I+u1RJrzk3ip2aleBHvPXf0VubWFEDumzeOBIZJJdd4HZbwcvXopY3Z/Y65umwoYCpcaFuppYa22Ntr21sFdU+rDLIQq0cyv9j3gpTZhhV1GsOhwVO6udmD9ffQe4o8AmYYlXcsE9nbH9GE/RNw9gaJnHbpJfO/Tns1C7nzOPCkOB8beWOTCbmaIvHL7Fv9I9sWHF3sLfONGvFyRoA+iSr8rOvAXbHyxXL2YJiivtujxDj9a+r/vFrO7u1Igqf82OTNat4MXmURfvQTE0ccf7bdMo55zJsgU34EMNvJrTNXfi8ItstwuTxytLB8+qu/UGeRRM/tZRc8R9YpAeQ72FAmaOi1iKYBixSWy4NC1bjYUAWGfWM4U3YP9cQkQvQKDlq5ZA7f2PrB0xu1rhvJgJpuq321oJBwY8im2eC6cVplm/93hrEZNYhiS7NvyYpH/tjf5VKwbwb/MOelbTo/4GtjsYj9QoxaauNav+vrhK57JEX+RFOy9kEEFq9PjAlEpOyx5pfdTaVhYh6Jiy7n8lpa98bV58OaIW5R8ehzdKGkd5T/fv0hbYZ+W1/3x/2LRLMDJmzO5Ob2PwUX26uJkiBSNVb99gDa446BLVemXrk8xg7KeonjHec6niwt9f29/RftAd9AN/hB/tmXGNdHKFUtz5hIsOjp6d/YvEWdB96Ri57qL/bKgQAJub86ELhSmk/d3mtwZNV3gcxsf0tG9AUYnvD3p7yZF6NQM4MylfKf6pHZ//SYiq2sVN31LfjVO8WUX1x6A27TGiEKgBux2yORiPlLnrBjU+0QnPs4W3juqQEh6MOTfOROFEtRKKc6kxBuU9XXWv2IwVUGHAAHkQlPSmSNH2j7wL1uFTGr8d9IYsmz8+mdo//FtF9v2VPD+Y/BnzMrfz5f+ri2lOi48ChPhwxJvDGQzOI8YvmjUzNaoOZD9OrXtWBwnhBRCZUcsmvo2RsJq/8wUlhkAX9VmBwROGElGzgyTJhCc7QQQ1eZ23VbDRk X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: bac76a8d-1d7b-4977-58b1-08db76ded618 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 07:19:25.1588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n3CGjs7yyT2d10tcLxw7a7rEFAJFl7twUVghe/+ho1WZ5wIhVue4dm1sK3lv/44M575QgRDAShNqfP3XvhaopA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4289 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The upper-layer devm_request_threaded_irq() function can directly print error information. Signed-off-by: Yangtao Li --- .../intel/int340x_thermal/processor_thermal_device_pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c index 0d1e98007270..6ea9892b3660 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c @@ -261,10 +261,8 @@ static int proc_thermal_pci_probe(struct pci_dev *pdev, const struct pci_device_ ret = devm_request_threaded_irq(&pdev->dev, irq, proc_thermal_irq_handler, NULL, irq_flag, KBUILD_MODNAME, pci_info); - if (ret) { - dev_err(&pdev->dev, "Request IRQ %d failed\n", pdev->irq); + if (ret) goto err_free_vectors; - } ret = thermal_zone_device_enable(pci_info->tzone); if (ret) From patchwork Tue Jun 27 07:17:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 697125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382EEC001B3 for ; Tue, 27 Jun 2023 07:21:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbjF0HVL (ORCPT ); Tue, 27 Jun 2023 03:21:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230409AbjF0HVD (ORCPT ); Tue, 27 Jun 2023 03:21:03 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on20729.outbound.protection.outlook.com [IPv6:2a01:111:f403:704b::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02886269E; Tue, 27 Jun 2023 00:20:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FRsdY0iuVvC2IfjjiAE3MKNJ7yQt6uhJqyA89NQz06nczGvi+nc5p1CoUDDYAc29N4PUp0d71iy6i1sRQgrXxgDS/9g/2ux4HvaVryXLVJmeV8AQDxDjE+nSGkhbBvriefTpLV+l8V3WHIg3RQw4rTjMM+VjwXZ8KwbNSH37YtVByvckpd0vCKtZiDqWQ4+Y2z+mzdZZp00bBvwDUSLqDPkQncp3vmN9N4l8hO9P6s+nz7r0ce7NlD2AKjwGfa5ZZbn71lljDTWUpqKhyBVp6pKZndmBxUkOBJcOHiQUvq2r8t3S/E24ODnXSLYJvetetE5nX6vCg1YOU+q6hUWMpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v1gQQy2LsLzxKVpupOl7l07DODTlYKrF46Uz2jsXo6Y=; b=eS/tZdcq/04ZLcdu1LZj4N3T/lW+cJQeiMuPBNEpApleOoA/51gwCegJOeWvkpUYhgNxsY359KrdrAEZg5s/j8uIVhmO616CFOAQmnIfOYRgfozuql1dnQF0+gXIHBl/XpWWLIX5Nv2ez2qHcW5zSECirPHVwuHpi06i6eSjsEMI2uYY8gHTGBSrABYlttLMFFoa8Lxs2JPdi1GqQhpj00JQC8glaQhSfUTog2KeDTzpLFZoOOxfbZqOWPfoMjD+hIZLIW33QDFX+Q3fx369HrHbUSSuM2a852kcWXdDbduNa6IqMBNH1/sVRCmBgNEkM51hT3+iarOfLFcOGP+Vsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v1gQQy2LsLzxKVpupOl7l07DODTlYKrF46Uz2jsXo6Y=; b=bMqOk90DQWKU2ip4prgSaIcTJ/tl0MpVeQmeBZjKCRgWBWV5WElIMiZQeCENgZQ4NmhWVcpa2NHxNuTQQtH9pWVBjogAg13FZUl2UN0ktPP3MmP/ZYIc7f/JNFrLHG4z7ipgiCkZc33/z6Uh3Z78SW02MGZfBBzhNU9jcMfK+pPNnx7jfVUtW8W3T4aPwkpu5AwJyY/ZurA4KIXV4xOUG51zfIbf811skKb/Krwoz3tPncxuCwZAm3/uUTE1Rg4nxYL+JCJcGcqXswTRrYuDPCWSblyJ3qqw4+tv5xNBNWhhQJNbcou087h1WhUxlDRF71dkv0zAVJpvqYORfLnRZg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4289.apcprd06.prod.outlook.com (2603:1096:820:78::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Tue, 27 Jun 2023 07:19:32 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6521.023; Tue, 27 Jun 2023 07:19:31 +0000 From: Yangtao Li To: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, frank.li@vivo.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 11/15] thermal/drivers/intel: remove redundant msg Date: Tue, 27 Jun 2023 15:17:02 +0800 Message-Id: <20230627071707.77659-11-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230627071707.77659-1-frank.li@vivo.com> References: <20230627071707.77659-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4289:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f51b0d1-8011-49f6-95ec-08db76deda14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /q6op132s8e2iGNDI4sNScDlHEvdzhKJd9QZJ4xKJvd82NEWXs60rJqb/wmenW54fxAOdP40mhuV/G2Gmz0WC/3dW1LJy3DZ7PUnefwM9XQuu4hI5NA6w2p6uD2D6haSo0RLTCd8JdLlo7C1xx+PxujMW++Smmm3pZxJq08miflQPBUaXJhrQj66dEVHdgvdOObIH0K+17TBa+9QBNN3ppzrsItoSj3T3V5BsSUmLFs84q2kiQtJ66MONq1sAqD901Pt1LGhKfYOzrzpJ1+fEEFXkZ/irTFbf1z83HH9w9pzzZBtxvOEfBerUmmB05KQYEL9Mx3hJn9PzL0eHUHgrrnGhQehT/JU9UEzOVbbgbnxPHsqytsQIOyKOqPxtHxl4f2mLInYkZg9OHpSzsDnsN1yKxF+Jg+UwaBWlsCeuYwZ/2zFHTJYx8MtSAo96hFlCD031zzYaMmgTmXOqLXuLwiZ67XUTCEjc79zZThywk4BtLqMM7Goqooum/DwzvIK7SIljEiLgp3mp0eQ+FCNUPYSZRK6bDTKmWlWBHobneCR1SlY7vb7IbQwwpy3vur081py0ZjtjgWA35987jKmVCpCfNfGQ+mqaun2kXD2TLUKfwZRav6ZJIKmxjoX3ofibLLQ4omq3J/3k9s2WmP/7w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(451199021)(6506007)(36756003)(6486002)(478600001)(52116002)(2616005)(6666004)(83380400001)(2906002)(1076003)(26005)(6512007)(186003)(4744005)(5660300002)(316002)(86362001)(7416002)(7406005)(921005)(66476007)(38100700002)(38350700002)(66946007)(41300700001)(8936002)(4326008)(8676002)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: BtfY/6mZ6WXpGYwHHhTJ/gy0ikfGNI8eRg6R55YNtAht9PU5/F8fLCHjdfFkfBGdYVIOqDJJuPivfJtwK/iBisnDmBxavxOzBxCBmPMD0W+oKUvDgzv5MTG0/MxLdLv0Qpm6jigp/2jP4VWFUFp3MDjbBuzkE2PTYn5KWEeAvfqL6wV0v4Ab87FAcvEXLnrA3gDR7JF5nbIWZIFPy8a9vwERGpdHqav/1qAr1n2tZmeGSAzny0knRRun5cyJNnqpaCOJXk8YUxqycoUmP6SAyaomxRpc7K8LdiSAPqwlWtN+qRAJTMKYHFzf3QNOsFr/tXKXzZOut2usRdyTJksiVZ1X9qvNPdwr7YgQHDM1eG3lrdi/x0c4Qxd39SxIxVxxikeNSQzrLDfi/OojHFhQTQ0UwvAbVbW5Q4AsxNlZeSwEyPXh8PzB5s7roQygOXY7CWXY2idumNz150j0/jq7uQxXSCe/AXBaNXc1UVY2XGFzsFCbejlooFifNjCNZZAh2o7fxWrewgpixvB2kPPzpyNwEVtYFwgefKZeLUbfZNa1Pn25Zdb9gRXCWCi4hKncBBEVTvnEJW7Xq1yhKJGKdoXpG9ukNe+JuUI6tFdoEXkf7UC6u6khXARPePQiL6rXgmmngI2bs47g01wWAHhMo60v0sg1nXthYyQh2D7o18lEb5Z1kbtkH8Q0Fmuffd8o9pm955VHNZf5kwezHGgFs0GztEdklp/ENoGjK3WAw1eHYMiNOZfU/WnYMAAHxVmL/xX53ZOadQMcUvu3e1gWbMQP//M8jrEDN7pA99xTjndB4mE/j/PMNpVS/JTPft4TyvxAyGWK8WocJYoivY5ExEsbv2C557WvE7KX8PdHbqS9ol4DUhda3QRYlD2gfwffLE7g/mA/yYull4G7Gs4vT8J4DRajqCmk/Lys6FnUXBBw01PlbaV6fCg1dIcng2zjEtvKabWpLVYBhBy2P67OkZJZgBTHfZv9uMgLd7WJg4vanpYa9AYVZB2KKp5bvKdmyoCb9sNstXZ9RprHlb1gfLGjyYfL+yHyhbxPojQmL3zO5BdtFfRKZVSxevJCAczCKnph43uAVBIJix0L3HBMi1fhAywAcsehgEEhkzrkX2tkQdNtW0Ez0ipqw3+/iI3hwgn5rhI8EWWQ11ajJdV4j1fomj4WZTULH9UATZpMbRuiPcewJILFHIcTO7bWKGUIhnaoQ5yzFjtpxeCk84n5R1yCLnvV6uO2O5HMHyFBrck99UDOJSeDXvYkTF0EIrSp+4toBGooSmr7eHQiRw4AzTh6Zw3EyB9O7upIp31r7ospW1Blx5cHMKbIaEqdO8oPHKo3hqszDk884/nORiBabKOCOVIU5lYCxplFHRKpdMJ11q112e/uRgJdYC12ddwVIeZT9Aat7MfZhmGE2/FxghtS5gCRXO8wdAJB4udOvZTpYsWCdBrmI0Yo7hKzyA3qvcmKsaBU8QZBqVHKr7CASgjQ+u8Yeo4hSryHdxGJoWWybZX4o/Vkt7TivsR7hbYcHH79tkzkFtjNogV0+H0xtQlwgzxT841zeaKQGTK055wJ8wijP3Gj9rU9jTL5ivzv X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f51b0d1-8011-49f6-95ec-08db76deda14 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 07:19:31.8321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X0kQjbacXc8vjEWmQf+hpKggq5nZqIXd3NJG+3P3DBAHGZawG4wBKrYwd2jEAQJLp+g/8Xl+O8v0lqvv7cVWqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4289 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The upper-layer devm_request_threaded_irq() function can directly print error information. Signed-off-by: Yangtao Li --- drivers/thermal/intel/intel_bxt_pmic_thermal.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/thermal/intel/intel_bxt_pmic_thermal.c b/drivers/thermal/intel/intel_bxt_pmic_thermal.c index 6312c6ba081f..aeaefbbd5d8f 100644 --- a/drivers/thermal/intel/intel_bxt_pmic_thermal.c +++ b/drivers/thermal/intel/intel_bxt_pmic_thermal.c @@ -245,10 +245,8 @@ static int pmic_thermal_probe(struct platform_device *pdev) NULL, pmic_thermal_irq_handler, IRQF_ONESHOT, "pmic_thermal", pdev); - if (ret) { - dev_err(dev, "request irq(%d) failed: %d\n", virq, ret); + if (ret) return ret; - } pmic_irq_count++; } From patchwork Tue Jun 27 07:17:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 697124 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63050C001DE for ; Tue, 27 Jun 2023 07:21:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231196AbjF0HVu (ORCPT ); Tue, 27 Jun 2023 03:21:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbjF0HVk (ORCPT ); Tue, 27 Jun 2023 03:21:40 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on20729.outbound.protection.outlook.com [IPv6:2a01:111:f403:704b::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 490202D63; Tue, 27 Jun 2023 00:20:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KrXBcy/Iy7nHI18BgL2/2UlObyhVYzK7BmcI5Q1zyPvig1A89fTNeSiIqD9TV//6BUFq1QPhZJaPK9Li/7rwyjsu5aM0DB4dI0cqjd7EapfiJ1IEGAILuCrucd/YZebchxktPBsgvSgyts25LCmCUsrDcd78fDEgkBLUod06N5XH4Sm1g0XlrHVcKOA/crkWpfFGU/ui/qhu38P3qfhnjErDJnunEWLUinxSv3AaMUUSMi7vXfmJqVbVOS2yqCEsNsa07WeA8ZbIZ1AaX5GWgJoInwbh3BX6pA3WANR0sFSYq9TFxhXYRHu7r3OTx7J7G3Bek/PdC7Z1bOxl/eXUhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CNadqL0WqyqUBdkAuQcsi37js7GRgeqx9jrx5etaUws=; b=b3e7WurqVXp9b48LIl5NMzsPPBL+QEbUR+JJDAewjlHZCyMKT+zbMYvwC5YKxoZMnLbvn0lPxqeK8+spNbLYlSCEnTJCYNbxw+PLFKmt9ZK6lmWw9ECJFrtfELRUyuaQH4EAAWUnFWQ6fw4wMgpJjCPjRK0a2euMv6Zhlki/ewD+/D0fqK3XNNtAWPv4lnaoWEUGbuCEahOPdHo0tpetF8QNES628xdQu67n1T5iaNcTAUABjIhUqzgeeIa2sWZF9/rSMns24xRbGq5vEes3S1JPPTZtoD7fQAWfehbeMZV66W0EnzebSFe+6UqTcs9DDQZd5yiHtNmDx9AOHDa7Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CNadqL0WqyqUBdkAuQcsi37js7GRgeqx9jrx5etaUws=; b=WOlkkjcRoqiMG7FaktUt5pvvFGqfxMuRjFyFf4dcrOweX43hLDW1AIeWRwj1lH7pOij+F5na3BNNNNvXAQPfiGATy87PZoF5qS1YcSeCUDjas89UBZdkGR1dCCmEfOV0ivp1XmsDmOD08HnMHTu2uQxH0e89PlIVjbGbQLpRtRERgb0zV3cTIBSiea0Z+TgAojvetgtzP71DKu978qD3RCxMmkSfGy6jISTWTAlfP5LOqnx/LvUft0EMmcpZSnk2hh2mXIV4qfdZnkG97HT17k2X7PBsRneuNa779XuupEzyOEb3ZSVRsNhGEIMeCYWV4/2eCsm/kQimPmfPi5AjRA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4289.apcprd06.prod.outlook.com (2603:1096:820:78::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Tue, 27 Jun 2023 07:20:00 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6521.023; Tue, 27 Jun 2023 07:19:59 +0000 From: Yangtao Li To: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, frank.li@vivo.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 15/15] thermal/drivers/mediatek/lvts_thermal: remove redundant msg Date: Tue, 27 Jun 2023 15:17:06 +0800 Message-Id: <20230627071707.77659-15-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230627071707.77659-1-frank.li@vivo.com> References: <20230627071707.77659-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4289:EE_ X-MS-Office365-Filtering-Correlation-Id: e0d8f096-6dd4-45b8-171f-08db76deeabd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nU2p+ASGFvDR5WKCJNn8CyNovmGR5Bz5em6VjWVVpoA1PPsi9y7175fhKJITlNjBryrtTOfvLcEUxvijJNL1XbKICSQGH93vR+Xsno6Q6qACxVDQtmnykJiC53WRSMre2jhVBLA+6CFboGE6rO06yrs73fMivMZrpq6gMM8FxdPxaRCvzz/yJS0N3ZOiYXmHaIV8HX1BUvtT2lKBZSMCfhPxVGGWjUc4e/PBWiogfK+5AiCkFQFkaFuHAfWkxr29QW69MhcEcumaTAxnQMCSviskq7tg63xEgW9Rq1y1jROOeAw581DhnHv1E8lKine8dAEDfug9koF3DjR5G8o7o1I5olMb32pHePGofQle7TwYUugBfm0FT50lUW6uFBqbLtlWvXRwm6y8W4tT/nLp8q/cPwqXN36mcIVU11wWDbvaRo+sElKG1Yosigt1+QIOJT6wVnUNVt6tdDyM04kFIxSdZHurpPXJjkacmqZ/qZjt0n2/04XZisCEqy6CQsOgf8pj99M7Cp6bv/EBJ97Dz+Hgu9xwuWEcaaRdRPLfjG9zHBEqIxBe0hC6PrWh8vTBOWR6CSu7BElG+Mi74ubDs2p9HMghnzKsbRw5u+pnc3Fj0uccse1qbmc9XxOmFgvixrCzlKpGN4/Zkz8xOgZ9NQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(451199021)(6506007)(36756003)(6486002)(478600001)(52116002)(2616005)(6666004)(83380400001)(2906002)(1076003)(26005)(6512007)(186003)(4744005)(5660300002)(316002)(86362001)(7416002)(7406005)(921005)(66476007)(38100700002)(38350700002)(66946007)(41300700001)(8936002)(4326008)(8676002)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: spOZMpR7b314EGbX6EKO4/obELRG249t6lk9KTRg6wDctoISjrXrTCVefnWTsPDfvGW3ACmCscyfHRN0SAQh79EzPqzhKDHvbeLEDcp00YuRasafG/RPctIH6v34zHrQNP7V649S2sw16Uq92OTRM3N/nQjm4MgOXsZzDQgRdxS/aHQUsA+akpoxGnHGjTI8nNKsJORl+s8jkfwyP58OTCHXScXU9qRENF+ztnq3RkQ6O9E+FsO8ZpSQvmJZa5GwQMag9GikB5e1mCtXmYfjo0GloR0mvp4PF7iO0NXYNbvoBtWMOC7WW9bZoT8PLW58xyPAIfUjAWvCHCarriB7XzOaBPaM0WUjJZ8ppip3rlI23xWGk3sMF3yNRHrLXl2VJw6Ktc91g23t5HJJcxS5s/D2ShxcKfEOUsJ44uBkQUHkNw/N9V6Pwuv41USeTnMSGnFCsaTb8xW2tVwaaF5Dxe1RtrH9PYuL8AhgGZKFVC9V4zMNhY0TA4OAHi2KwbPfhIC1UjHf9HQCmtl/qgYA9qtci8f75/QrD7n3NoywUmOWhqe1UCKutXvv/hyfm+kurZYbrijxTrNhq8gh8XAfMArGuHj/5NxFsSuWh9HRv2lwhoFRly4SXfHMcphtapluuhqO8qTwuJdbafPmkDaSb9RN9zyDiDBJ/MEDknU+W2PYh1aqEeXLGRNWKVFza1S31WQ2S0yVXZttf6P2pYGDqHFiWLBjRxIof84qqdbjIJT3Xl1mHOxfVYIkrzOMm/3RS9+/mmerh0oMg6BlGZhFwOxl4/9jE3XAB6r7zcramuycaX01G5dhbEkOaNtA8PJnHlAJPda+HvWzYcczHsLZ6hb2GhVh2T9LM9Xv/Bl4vGcdxhzNHDBnUyeh2AXHiAD19SA5rGhR66bCX7MCEE3b7AvrPij8WuBldxk9Dk5Gnstv8XXPJSij7mvpO9SPkslvU0qcyKN9fnXCatTgvFV+ilUcC8fekv3tznGvHi/mPjNFXGgrgEAxKzbl5XKjCeNvDh+FT7U4keYS76nMyRSBxLJ10L14j7sR7B3bpR1gT+9Qr1dDXBsiheHqcNpRXswzdNQJaTOmFYKfjMKvjLJPCF8eQ5BurV/lg9KY+KO6p5FqRBkjYanKxmbHZDL61915IcTFChw9gqK52BReFGZzTzQZ5h7FYnbFIjPgELECt8oU8JdLvyxqUD/nXm20TuVQWiak0+s3mBpYp4TkzGekh+ISBtvSESX62o5sqdhK8axNiVM97a4OWSRfNCVvG3Tpc+YgCUJ7HVa4nOLy03hK3VKo9KRXKts4YRA43bmlsmPn4QNSwn4CYBCLiJOjqBXnhciqMofIybxw8V+t5EhD4NgtAYzIdqktJ7O1e05XF16zJCJhohkV+SBhk1g+VwXPlGnZj9If8ipi1MjO8R9MZd6Fexh9yDq4/RPswhnoEa3imyhsWgHOTMQ5j77A/CVIkJwnyPt0O6QFP0+64QeR+ZbAyL9LA6X9NVXcod94lLYwb4ryI1swoZL7whIgMk72AfJLXpG4T1JqerEldhSCb9FoahiPtlq21zdJ20SnAndn60WBwI/XggTNKLb4XCME X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0d8f096-6dd4-45b8-171f-08db76deeabd X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 07:19:59.7872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J9oS8dlQKhNVcWkc9pJPLNfkXYewt6CrIO6FqRVNTir5rFa75yo9PUrVQvywraBM1Au6a+co+lPAgY7Q+vCL6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4289 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The upper-layer devm_request_threaded_irq() function can directly print error information. Signed-off-by: Yangtao Li --- drivers/thermal/mediatek/lvts_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c index b693fac2d677..bd503fbcba51 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -1151,7 +1151,7 @@ static int lvts_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(dev, irq, NULL, lvts_irq_handler, IRQF_ONESHOT, dev_name(dev), lvts_td); if (ret) - return dev_err_probe(dev, ret, "Failed to request interrupt\n"); + return ret; platform_set_drvdata(pdev, lvts_td);