From patchwork Mon Jul 3 18:20:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 700641 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C65C30658 for ; Mon, 3 Jul 2023 18:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230330AbjGCSUP (ORCPT ); Mon, 3 Jul 2023 14:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230214AbjGCSUO (ORCPT ); Mon, 3 Jul 2023 14:20:14 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F19CE6C for ; Mon, 3 Jul 2023 11:20:12 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b6b98ac328so70714431fa.0 for ; Mon, 03 Jul 2023 11:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688408411; x=1691000411; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fy3w9ZErCL0BlDSMy/TiatQjTzRvjJDARdwjHF/mGRU=; b=ek9UtWIyuD/xpwYcGqI4EunDqUcCaAWNiLpeyhz+ZMULa4FNYC7sST0/xUzjCygngD giHBd8zYriREYoXksKyQu4xx791sccc03bOeCKqlezEPXzJNUidbtqsBhNpJzDMXLdIe i6f4uzT84jmotiHcdQGD4Bkxxvg/aHHnbmSPyjQ45V1IvJI+HslmFLTisP9WpO00b9TR Gg1gnM+gk2IMVglhkYE5k7nReulDrDyHM4uf812PDasIZryMZNGEmFrcodZKXp+Elbn7 Wf9ZIIHPzpctKH2vICPVFQo8i3l/uHuLCT6tT12eCduAuFE7s17mRx9H/Tk42+5yXnbu n2hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688408411; x=1691000411; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fy3w9ZErCL0BlDSMy/TiatQjTzRvjJDARdwjHF/mGRU=; b=IOUnn8RGqPWWEX0Rx1SylvZzmJZ46TEniLkvLgfEYprQhNXz/ON0yo5u7tfxuv7ZvY 9fux13P/nqlTZwkf01dKyYUtfV0TcjFyx5YtWTu7aBu9DjuuovLlHyiHXVZd6F9jh1VZ wF026tmrb9ASBQ3MpwMLeWcLqnnmpqDKDwLQ04j0ftkedQzh/foNRJiYKoekCGQDoaCp YhqA3LM1o+kAPxgRG5XmdIjqEYDJO48Ue6GmG5XsJfz639KkwUzB2iUgWczlex+29vPi 4ah6QPj10cQLk4Va7Zz5bPE4LhBZL0aM6QGARTEBlTO0rNaXptv9QG+4Nf2QtNOWMp52 bi8w== X-Gm-Message-State: ABy/qLZyGvHzeMop/QFYw41SWKIgrtzY5OPojo20v+Oxk81TVu97sZI7 hHmCNdKUJC15u/GRBbJfPCfm/A== X-Google-Smtp-Source: APBJJlGx1nDv8sasm5EGEl2d9Qhe+l2SypAeADNunMFolSBsGzdU03dykDNi04FE/qE2Cdm8GocpJg== X-Received: by 2002:a2e:800b:0:b0:2b4:7380:230 with SMTP id j11-20020a2e800b000000b002b473800230mr7542739ljg.13.1688408410893; Mon, 03 Jul 2023 11:20:10 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id s9-20020a2e9c09000000b002b6995f38a2sm4946224lji.100.2023.07.03.11.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 11:20:10 -0700 (PDT) From: Konrad Dybcio Date: Mon, 03 Jul 2023 20:20:05 +0200 Subject: [PATCH v2 1/8] dt-bindings: clk: qcom,gcc-msm8998: Add missing GPU/MMSS GPLL0 legs MIME-Version: 1.0 Message-Id: <20230622-topic-8998clk-v2-1-6222fbc2916b@linaro.org> References: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> In-Reply-To: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeffrey Hugo , Taniya Das Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1688408407; l=1010; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=JIx6npJcVBGixIBbPlj9ig6P9iKP6MTqkDy6Kyhia0o=; b=8hu0iu2JreuANFYEfJK59dDXmixKP/h9qapYapLFNzlQCIOJHewgI7ULe7OXOFQ0LcQX/dWsV 8woRuyDsuBiDCY50v8hv6PjcrKEwXDb3uweqLT3HJJoWz/5gg/FkjcH X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org GPLL0 has two separate outputs to both GPUSS and MMSS: one that's 2-divided and one that runs at the same rate as the GPLL0 itself. Add the missing ones to the binding. Acked-by: Krzysztof Kozlowski Reviewed-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- include/dt-bindings/clock/qcom,gcc-msm8998.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/dt-bindings/clock/qcom,gcc-msm8998.h b/include/dt-bindings/clock/qcom,gcc-msm8998.h index 1badb4f9c58f..b5456a64d421 100644 --- a/include/dt-bindings/clock/qcom,gcc-msm8998.h +++ b/include/dt-bindings/clock/qcom,gcc-msm8998.h @@ -190,6 +190,9 @@ #define AGGRE2_SNOC_NORTH_AXI 181 #define SSC_XO 182 #define SSC_CNOC_AHBS_CLK 183 +#define GCC_MMSS_GPLL0_DIV_CLK 184 +#define GCC_GPU_GPLL0_DIV_CLK 185 +#define GCC_GPU_GPLL0_CLK 186 #define PCIE_0_GDSC 0 #define UFS_GDSC 1 From patchwork Mon Jul 3 18:20:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 698803 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 737E7C001B0 for ; Mon, 3 Jul 2023 18:20:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230389AbjGCSUQ (ORCPT ); Mon, 3 Jul 2023 14:20:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbjGCSUP (ORCPT ); Mon, 3 Jul 2023 14:20:15 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56B86E60 for ; Mon, 3 Jul 2023 11:20:14 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b6a152a933so73537951fa.1 for ; Mon, 03 Jul 2023 11:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688408412; x=1691000412; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4b/59TX3NkNSrRx1/m56RgmPe4rp5T4RY2auPLNOxCM=; b=vEPPO14XFcYlPOIaEAuxo/dZhl7EL0xbkhERdiyxO9jl5hO1Pa/Z5i4RKbrfWqxk5T QlbzvIylhE0SxOo2KatRqme3tYrrknajkFtUtTD86/AQ2dGv5m3waBEy5t4jjpqfQP5c av5VmAo9fAomrYxIasldvTfbSp4JrFV80pDB8Q+6Aym3JmE+27hta/CBsZSyErSY/N8G YYSQLbIpc78CLK4e04yswes1/CjJzHv5FP2Zyo9rAl5lCe/WfZiusUpiCOkd0fRqGHE3 Sjs6ziqWuOe9xmWn+Ji3/uS+s3p/F5vZBZmuF8A0/rnDl0O9W0bJgBtWgK6zThLbs4zM 0Z4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688408412; x=1691000412; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4b/59TX3NkNSrRx1/m56RgmPe4rp5T4RY2auPLNOxCM=; b=TAV0aftn2yhayDIq9cH05GBedemjpAwdOnOtkKkKEH7QWYkxVjdyhdpoU7hfzu6Nr7 LFZy2BkcyJJTfU2Mdnp7ZT9fDojl5RpmVfrePJPLiIRax4LPOUwMCIlDPIdgCceBrmRM dOue8NWPKTWMOONkrlFRdU5LlNshplS37/iENfOraFJ+DGApyQomgs4hf1QO+o9uU8ZR u6T1QG9XEF+xWkxuAVYFwP2BTdL+XTR/ZZ0jy6EZSpVoJL0Ny/anI8UxKi0kpgJ8Txur 1/3mI5as/ZZbSYe3w+Yau63kyJJdOsyrjF8ISBkRkUl8rwMuWKpXK2C206sqOEtLzGPB XGFg== X-Gm-Message-State: ABy/qLYzvX2uGeppvfGyHPVn+xqcnSl8V+mVssUNDuMko+OUu/LQV05s 2cPtYoCchxd0YlfWWYAgCidHlw== X-Google-Smtp-Source: APBJJlETYBi4L9GqYgzWWTB1XcujP7DKtsvaHR7Wux9K4DRxHMYt73wftJGDGAHjljx7eKqQX6ulUw== X-Received: by 2002:a2e:3815:0:b0:2b6:a804:4cc with SMTP id f21-20020a2e3815000000b002b6a80404ccmr7031505lja.53.1688408412303; Mon, 03 Jul 2023 11:20:12 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id s9-20020a2e9c09000000b002b6995f38a2sm4946224lji.100.2023.07.03.11.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 11:20:12 -0700 (PDT) From: Konrad Dybcio Date: Mon, 03 Jul 2023 20:20:06 +0200 Subject: [PATCH v2 2/8] dt-bindings: clock: qcom,mmcc: Add GPLL0_DIV for MSM8998 MIME-Version: 1.0 Message-Id: <20230622-topic-8998clk-v2-2-6222fbc2916b@linaro.org> References: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> In-Reply-To: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeffrey Hugo , Taniya Das Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski , Rob Herring X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1688408407; l=1174; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=NW778pWgYBPPqowr5L2HeywHk4bs4soIi+/Ehlrhk7Y=; b=VKw260lOv11+Bdr4GUzbu4N6czUT+8U9InWU83w0agHhegZ8fbsucgItBgK6kRqVlr8r2yyBE 5QnXGmY9CkNAkb0YfFoedubjdsslTg2PraKIjuu7vByCF0LEmv5bUD4 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org We've not been consuming that clock for no apparent reason. Describe it. Acked-by: Krzysztof Kozlowski Acked-by: Rob Herring Acked-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/clock/qcom,mmcc.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml index 422f5776a771..67e1eae0bbd0 100644 --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml @@ -297,6 +297,7 @@ allOf: - description: HDMI phy PLL clock - description: DisplayPort phy PLL link clock - description: DisplayPort phy PLL vco clock + - description: Global PLL 0 DIV clock clock-names: items: @@ -309,6 +310,7 @@ allOf: - const: hdmipll - const: dplink - const: dpvco + - const: gpll0_div - if: properties: From patchwork Mon Jul 3 18:20:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 700640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0022BC30654 for ; Mon, 3 Jul 2023 18:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbjGCSUY (ORCPT ); Mon, 3 Jul 2023 14:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231129AbjGCSUR (ORCPT ); Mon, 3 Jul 2023 14:20:17 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41EE9E69 for ; Mon, 3 Jul 2023 11:20:15 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b69923a715so73476231fa.0 for ; Mon, 03 Jul 2023 11:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688408413; x=1691000413; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6nV+W23ixU/gsOOwjBJ3HxinzG6QROQL9vhOLjLD7/c=; b=hBPfrZheoomPOR+k1h07sXx3Y/6OjceP3l2BrMg2f8BhDAOnz9JGggba3WBM/AVPMe r7GPJ5j7UyAIyeT7ZMIS103fKWaqWNPx2ILu9XqTf8Kx3uFxo/ZHV0Uf1PbB/N1feMo6 5IIx9cn+JA7yeeijtQX88W8geHebsVNs9YNfoFE6yuX3drB08iGMroOP69/NWHS52OrY UclsqeO3ZEN/aS/uV1a2NUk3DepG6U3YijgHcjWubIRHEEWWvPXFK9tUU6LGyx66vK1e bsygjdC8yIWpJjL5bZDgarum040OP2LLekzRln5+vzez73etfBkLzl8Bl3QoMNByt6Kn /Pmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688408413; x=1691000413; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6nV+W23ixU/gsOOwjBJ3HxinzG6QROQL9vhOLjLD7/c=; b=KNxbmD3jX6taoeZ2BfBk3p2eHKywDFekHvhhOYlmpkl+iHQZK2tVltzdoR4HaP6cz7 5bn4SiCFnxgVq7BAuS0ntt7jnr8HAww8Nv45X9ZaC5p+SGJpl84mofdXW5M9YroEOnv2 r7HOaWrNPa1nMUJfh4Wku6mbqoTLTZNpf9oZmuO3X3sbvhgR808qCv7PPra8x/IgOdX5 9/ag+UNLTEdB30x7mYNw8cgmPVXbRx9e5z9TKUKNK3VLGik1kBn+jch+qYs3nlCbC7G9 FnJuiUXQFQbdXHHMCWH6PkmrofIJ47inh2zTM+2OMyXsiz7xRQcVXYtfq56DjoBc3sth cezg== X-Gm-Message-State: ABy/qLZirR8fw5OZSAnzaEb/URCYjm+PuA7T6ktbHqzp2ISCVupgee3O CfDGvpShLb6g88PmF6Kd7X9IPQ== X-Google-Smtp-Source: APBJJlGrLSA6uun2H5C7lzAMO2VxYu0WZk/tJL9rMjsBoujWnevzEjOM4VTdVpgPfs1y8SfG+lyQkQ== X-Received: by 2002:a2e:7a11:0:b0:2b6:a19e:5153 with SMTP id v17-20020a2e7a11000000b002b6a19e5153mr8108582ljc.15.1688408413644; Mon, 03 Jul 2023 11:20:13 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id s9-20020a2e9c09000000b002b6995f38a2sm4946224lji.100.2023.07.03.11.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 11:20:13 -0700 (PDT) From: Konrad Dybcio Date: Mon, 03 Jul 2023 20:20:07 +0200 Subject: [PATCH v2 3/8] clk: qcom: gcc-msm8998: Control MMSS and GPUSS GPLL0 outputs properly MIME-Version: 1.0 Message-Id: <20230622-topic-8998clk-v2-3-6222fbc2916b@linaro.org> References: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> In-Reply-To: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeffrey Hugo , Taniya Das Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1688408407; l=3382; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=t/yKGa//yIWyr0eUqgxiqgLvRVjuxq7khyy0L6VwrLU=; b=HoYPHPJnk0lOO6Hc8Rh3ktspFtE9vgXAD7FBr8jeDugiD0WzNx4S2Efdic/bsr7zNcNSzrJlq 8303bTIwgimC7yIxEYNL+pS65ffRsKVhKNMvMBOepk9qQakiP4IW4Fr X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Up until now, we've been relying on some non-descript hardware magic to pinkypromise turn the clocks on for us. While new SoCs shine with that feature, MSM8998 can not always be fully trusted. Register the MMSS and GPUSS GPLL0 legs with the CCF to allow for manual enable voting. Reviewed-by: Jeffrey Hugo Tested-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-msm8998.c | 58 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c index be024f8093c5..cccb19cae481 100644 --- a/drivers/clk/qcom/gcc-msm8998.c +++ b/drivers/clk/qcom/gcc-msm8998.c @@ -25,6 +25,9 @@ #include "reset.h" #include "gdsc.h" +#define GCC_MMSS_MISC 0x0902C +#define GCC_GPU_MISC 0x71028 + static struct pll_vco fabia_vco[] = { { 250000000, 2000000000, 0 }, { 125000000, 1000000000, 1 }, @@ -1367,6 +1370,22 @@ static struct clk_branch gcc_boot_rom_ahb_clk = { }, }; +static struct clk_branch gcc_mmss_gpll0_div_clk = { + .halt_check = BRANCH_HALT_DELAY, + .clkr = { + .enable_reg = 0x5200c, + .enable_mask = BIT(0), + .hw.init = &(struct clk_init_data){ + .name = "gcc_mmss_gpll0_div_clk", + .parent_hws = (const struct clk_hw *[]) { + &gpll0_out_main.clkr.hw, + }, + .num_parents = 1, + .ops = &clk_branch2_ops, + }, + }, +}; + static struct clk_branch gcc_mmss_gpll0_clk = { .halt_check = BRANCH_HALT_DELAY, .clkr = { @@ -1395,6 +1414,38 @@ static struct clk_branch gcc_mss_gpll0_div_clk_src = { }, }; +static struct clk_branch gcc_gpu_gpll0_div_clk = { + .halt_check = BRANCH_HALT_DELAY, + .clkr = { + .enable_reg = 0x5200c, + .enable_mask = BIT(3), + .hw.init = &(struct clk_init_data){ + .name = "gcc_gpu_gpll0_div_clk", + .parent_hws = (const struct clk_hw *[]) { + &gpll0_out_main.clkr.hw, + }, + .num_parents = 1, + .ops = &clk_branch2_ops, + }, + }, +}; + +static struct clk_branch gcc_gpu_gpll0_clk = { + .halt_check = BRANCH_HALT_DELAY, + .clkr = { + .enable_reg = 0x5200c, + .enable_mask = BIT(4), + .hw.init = &(struct clk_init_data){ + .name = "gcc_gpu_gpll0_clk", + .parent_hws = (const struct clk_hw *[]) { + &gpll0_out_main.clkr.hw, + }, + .num_parents = 1, + .ops = &clk_branch2_ops, + }, + }, +}; + static struct clk_branch gcc_blsp1_ahb_clk = { .halt_reg = 0x17004, .halt_check = BRANCH_HALT_VOTED, @@ -3080,6 +3131,9 @@ static struct clk_regmap *gcc_msm8998_clocks[] = { [AGGRE2_SNOC_NORTH_AXI] = &aggre2_snoc_north_axi_clk.clkr, [SSC_XO] = &ssc_xo_clk.clkr, [SSC_CNOC_AHBS_CLK] = &ssc_cnoc_ahbs_clk.clkr, + [GCC_MMSS_GPLL0_DIV_CLK] = &gcc_mmss_gpll0_div_clk.clkr, + [GCC_GPU_GPLL0_DIV_CLK] = &gcc_gpu_gpll0_div_clk.clkr, + [GCC_GPU_GPLL0_CLK] = &gcc_gpu_gpll0_clk.clkr, }; static struct gdsc *gcc_msm8998_gdscs[] = { @@ -3235,6 +3289,10 @@ static int gcc_msm8998_probe(struct platform_device *pdev) if (ret) return ret; + /* Disable the GPLL0 active input to MMSS and GPU via MISC registers */ + regmap_write(regmap, GCC_MMSS_MISC, 0x10003); + regmap_write(regmap, GCC_GPU_MISC, 0x10003); + return qcom_cc_really_probe(pdev, &gcc_msm8998_desc, regmap); } From patchwork Mon Jul 3 18:20:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 698802 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F1A5C001B0 for ; Mon, 3 Jul 2023 18:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231241AbjGCSUY (ORCPT ); Mon, 3 Jul 2023 14:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbjGCSUW (ORCPT ); Mon, 3 Jul 2023 14:20:22 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D73E6C for ; Mon, 3 Jul 2023 11:20:16 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b69923a715so73476641fa.0 for ; Mon, 03 Jul 2023 11:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688408415; x=1691000415; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IgXZ+eRdRJHN8xsGvQGmmBaJDurThI2IbqW/jpkrGj0=; b=uceXZfbYZOlKkij7wFKMEyEmOpiTzp3vyUd3NWusgPamjZjrHdpgJB50UATD5qUJVN yp9pOw3lJ8SjlVVYm3i9XTH4z67lRQT9XmOFr7EK/+QEn1B6pJDUG73+Fk6XQW/t23a2 v09orOz49sLAu/xYaPDQBEPMjCS1afCRFuR+6U78OnhG8jZvNRC5lXe/en01U6Gg1WjL cR/IIlBbTerGBIy2WAlGeTDhO/9b5YhATd9fyCETx5k0HZbk0ht0bbpSYpR6r3Gp5+fp f7D1r7AhCXIxdpsTXe8BO2DYWL2ll75pKS9vibr74/hVWcznEJImkXoQYS89pdVafroc C2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688408415; x=1691000415; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IgXZ+eRdRJHN8xsGvQGmmBaJDurThI2IbqW/jpkrGj0=; b=HJmB7tobSdm7jj5RUeAp7/up6BGAHinQgHOXLMLBeYCsilrERpHPLZngKnhZje9Cgl ZzUW0LrbySlufVKUtF7BeS1q75Br/VjLRkVtQDeC1Chxe8A28fVe+NRxhxjR+9p/+TYN NkZr32sP+RM4YRVtwvQJ7WgmKvlSVS17uPNFqUJ8O7jBFjWZcVqeMHL8V1msDUW4TL6P EC4rJw96pee3Zdc2vEU4Si6hsPW7iMga2p0DjcvRfxryqQUxrMZJ7yPhZODtgJN9FrtZ bYdgL5+Sof+U6+1b+AI5c3rt2uUJfc731fzASuxV11h+ovw+RR0nhKA3qmcfx9JqMe8j BHbA== X-Gm-Message-State: ABy/qLbcUkcvv8IlyTOUswm8DWjNwNMCTFv78U98mo1UO2IBLqu9WlNS hpD3HMKXG4qtf2NyhAOI9IkVcg== X-Google-Smtp-Source: APBJJlGO0FKQ32so8WWSWQSzDz/qJL9MkbQlG8vOXtueV2IcSk0985GL6XUv9PMX3DwtmNejitKBIQ== X-Received: by 2002:a2e:9143:0:b0:2b4:6eb0:2a27 with SMTP id q3-20020a2e9143000000b002b46eb02a27mr8806972ljg.17.1688408415010; Mon, 03 Jul 2023 11:20:15 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id s9-20020a2e9c09000000b002b6995f38a2sm4946224lji.100.2023.07.03.11.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 11:20:14 -0700 (PDT) From: Konrad Dybcio Date: Mon, 03 Jul 2023 20:20:08 +0200 Subject: [PATCH v2 4/8] clk: qcom: mmcc-msm8998: Properly consume GPLL0 inputs MIME-Version: 1.0 Message-Id: <20230622-topic-8998clk-v2-4-6222fbc2916b@linaro.org> References: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> In-Reply-To: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeffrey Hugo , Taniya Das Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1688408407; l=4937; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=pNpFd/werWG+oLvuHHpeYrlGmkALZ/dmf7xfH7d+kHc=; b=VW4i1+gxxDJfK3DsiUrdpLeAHClFLSCtu4j6f+S5L06ubK/8moZi9q4rRdK2cSupBisds/iH7 KHuuZiZqwb6AZ12Wzu9X4/WrbFYWG53iiaAox16NU35zKUvncwcDm8W X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Up until now, the GPLL0_DIV MMSS input has been modeled as a fixed child of MMSS_GPLL0_DIV that's always-on. Properly representing the former in the GCC driver makes us unable to keep doing so. Consume MSS_GPLL0_DIV through fw_name ("gpll0_div") as well as add a fixed .name link to keep backwards compatibility. Reviewed-by: Jeffrey Hugo Tested-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/mmcc-msm8998.c | 35 ++++++++--------------------------- 1 file changed, 8 insertions(+), 27 deletions(-) diff --git a/drivers/clk/qcom/mmcc-msm8998.c b/drivers/clk/qcom/mmcc-msm8998.c index 4490594bde69..040c495e91e4 100644 --- a/drivers/clk/qcom/mmcc-msm8998.c +++ b/drivers/clk/qcom/mmcc-msm8998.c @@ -46,19 +46,6 @@ enum { P_DPLINK, }; -static struct clk_fixed_factor gpll0_div = { - .mult = 1, - .div = 2, - .hw.init = &(struct clk_init_data){ - .name = "mmss_gpll0_div", - .parent_data = &(const struct clk_parent_data){ - .fw_name = "gpll0" - }, - .num_parents = 1, - .ops = &clk_fixed_factor_ops, - }, -}; - static const struct clk_div_table post_div_table_fabia_even[] = { { 0x0, 1 }, { 0x1, 2 }, @@ -354,7 +341,7 @@ static const struct parent_map mmss_xo_gpll0_gpll0_div_map[] = { static const struct clk_parent_data mmss_xo_gpll0_gpll0_div[] = { { .fw_name = "xo" }, { .fw_name = "gpll0" }, - { .hw = &gpll0_div.hw }, + { .fw_name = "gpll0_div", .name = "gcc_mmss_gpll0_div_clk" }, }; static const struct parent_map mmss_xo_mmpll0_gpll0_gpll0_div_map[] = { @@ -368,7 +355,7 @@ static const struct clk_parent_data mmss_xo_mmpll0_gpll0_gpll0_div[] = { { .fw_name = "xo" }, { .hw = &mmpll0_out_even.clkr.hw }, { .fw_name = "gpll0" }, - { .hw = &gpll0_div.hw }, + { .fw_name = "gpll0_div", .name = "gcc_mmss_gpll0_div_clk" }, }; static const struct parent_map mmss_xo_mmpll0_mmpll1_gpll0_gpll0_div_map[] = { @@ -384,7 +371,7 @@ static const struct clk_parent_data mmss_xo_mmpll0_mmpll1_gpll0_gpll0_div[] = { { .hw = &mmpll0_out_even.clkr.hw }, { .hw = &mmpll1_out_even.clkr.hw }, { .fw_name = "gpll0" }, - { .hw = &gpll0_div.hw }, + { .fw_name = "gpll0_div", .name = "gcc_mmss_gpll0_div_clk" }, }; static const struct parent_map mmss_xo_mmpll0_mmpll5_gpll0_gpll0_div_map[] = { @@ -400,7 +387,7 @@ static const struct clk_parent_data mmss_xo_mmpll0_mmpll5_gpll0_gpll0_div[] = { { .hw = &mmpll0_out_even.clkr.hw }, { .hw = &mmpll5_out_even.clkr.hw }, { .fw_name = "gpll0" }, - { .hw = &gpll0_div.hw }, + { .fw_name = "gpll0_div", .name = "gcc_mmss_gpll0_div_clk" }, }; static const struct parent_map mmss_xo_mmpll0_mmpll3_mmpll6_gpll0_gpll0_div_map[] = { @@ -418,7 +405,7 @@ static const struct clk_parent_data mmss_xo_mmpll0_mmpll3_mmpll6_gpll0_gpll0_div { .hw = &mmpll3_out_even.clkr.hw }, { .hw = &mmpll6_out_even.clkr.hw }, { .fw_name = "gpll0" }, - { .hw = &gpll0_div.hw }, + { .fw_name = "gpll0_div", .name = "gcc_mmss_gpll0_div_clk" }, }; static const struct parent_map mmss_xo_mmpll4_mmpll7_mmpll10_gpll0_gpll0_div_map[] = { @@ -436,7 +423,7 @@ static const struct clk_parent_data mmss_xo_mmpll4_mmpll7_mmpll10_gpll0_gpll0_di { .hw = &mmpll7_out_even.clkr.hw }, { .hw = &mmpll10_out_even.clkr.hw }, { .fw_name = "gpll0" }, - { .hw = &gpll0_div.hw }, + { .fw_name = "gpll0_div", .name = "gcc_mmss_gpll0_div_clk" }, }; static const struct parent_map mmss_xo_mmpll0_mmpll7_mmpll10_gpll0_gpll0_div_map[] = { @@ -454,7 +441,7 @@ static const struct clk_parent_data mmss_xo_mmpll0_mmpll7_mmpll10_gpll0_gpll0_di { .hw = &mmpll7_out_even.clkr.hw }, { .hw = &mmpll10_out_even.clkr.hw }, { .fw_name = "gpll0" }, - { .hw = &gpll0_div.hw }, + { .fw_name = "gpll0_div", .name = "gcc_mmss_gpll0_div_clk" }, }; static const struct parent_map mmss_xo_mmpll0_mmpll4_mmpll7_mmpll10_gpll0_gpll0_div_map[] = { @@ -474,7 +461,7 @@ static const struct clk_parent_data mmss_xo_mmpll0_mmpll4_mmpll7_mmpll10_gpll0_g { .hw = &mmpll7_out_even.clkr.hw }, { .hw = &mmpll10_out_even.clkr.hw }, { .fw_name = "gpll0" }, - { .hw = &gpll0_div.hw }, + { .fw_name = "gpll0_div", .name = "gcc_mmss_gpll0_div_clk" }, }; static struct clk_rcg2 byte0_clk_src = { @@ -2544,10 +2531,6 @@ static struct clk_branch vmem_ahb_clk = { }, }; -static struct clk_hw *mmcc_msm8998_hws[] = { - &gpll0_div.hw, -}; - static struct gdsc video_top_gdsc = { .gdscr = 0x1024, .pd = { @@ -2855,8 +2838,6 @@ static const struct qcom_cc_desc mmcc_msm8998_desc = { .num_resets = ARRAY_SIZE(mmcc_msm8998_resets), .gdscs = mmcc_msm8998_gdscs, .num_gdscs = ARRAY_SIZE(mmcc_msm8998_gdscs), - .clk_hws = mmcc_msm8998_hws, - .num_clk_hws = ARRAY_SIZE(mmcc_msm8998_hws), }; static const struct of_device_id mmcc_msm8998_match_table[] = { From patchwork Mon Jul 3 18:20:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 700639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B28D4C30657 for ; Mon, 3 Jul 2023 18:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbjGCSUg (ORCPT ); Mon, 3 Jul 2023 14:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231221AbjGCSUX (ORCPT ); Mon, 3 Jul 2023 14:20:23 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1D45E74 for ; Mon, 3 Jul 2023 11:20:17 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b5c231c23aso76561451fa.0 for ; Mon, 03 Jul 2023 11:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688408416; x=1691000416; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mMoCMtDKw+oilBFVn9iuBCIfJo4ov6JGgxWl+DyeDZI=; b=mkJkyf3cCt0nkb+4LfexC3d1AK/CC33YpQLi4RMAQ6jddtFVDVCNk19KxBVVO6ex41 YvGg3As8fxUKT30C51+08/We/atAU6CPC1fL+X+Wr80NDrR1FzxgtlrQYz1BYZjiut5S eOXVX8pm7UaoKk0A7OSsOsDnTaeHOWqx1sgSAnJNFnXGewtViaMpNltNK2/Q0g+G7QqZ dqaZPr3QWDKwfUP15wFfX0qogXcNuXAs+aYCmMjaztul5N4wOszC/ksaLHFh76jYp4T6 ErOSEmsFGQfjc3rDOb1zkalHqG28fXu/sY0oc0N3q3tQh4eMi4ERY6oqkLN/9WTq68dr MprA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688408416; x=1691000416; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mMoCMtDKw+oilBFVn9iuBCIfJo4ov6JGgxWl+DyeDZI=; b=hvs/Si0ZCcJYjVtBJTTLF6vDYJT04nIDzwQ+Nv2N3UTdCsXsOs61m/lIi/0kUfYfZU 83OXBndNZVP9ClqQlpbYj351eraBp/YcNBTRg6z4LQY3M+AOsdIYA8y1p71k71d12Ibe YdczDGAcsj67c6BW219lhh5HCchpBCLXvm7nFd4Yw//IAzzpfHORuFFvNHXYUdD8vtwa AgxzdAjNZjNUDmOOYDBEWOTP92WW8ES5HNTYsGhV9OyfdghX2ciU+puUaHBJtNM+9w5i bhsbHfm8OU0zdnxnsFWg+fu5sJ2LIJvwmQqnmHmQ4XPQYpAsj9Gzr68SqyfzgoDHeonq TfWg== X-Gm-Message-State: ABy/qLaVEXDCPY/GPEpUkJIzHHAtiq2EgAjVxH1NiGLrsWyz9kSnLDes FS5QUpMTSYrig4DJBZmn+tmG5w== X-Google-Smtp-Source: APBJJlEdMlWsbEJAgyrqjFSYTIHacyg2SS1m44Awa4ZwaUPhz9uDUB9S06BvI/4neG0YONpl93/T9Q== X-Received: by 2002:a2e:80d5:0:b0:2b6:ec2d:a4b with SMTP id r21-20020a2e80d5000000b002b6ec2d0a4bmr2256165ljg.42.1688408416333; Mon, 03 Jul 2023 11:20:16 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id s9-20020a2e9c09000000b002b6995f38a2sm4946224lji.100.2023.07.03.11.20.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 11:20:16 -0700 (PDT) From: Konrad Dybcio Date: Mon, 03 Jul 2023 20:20:09 +0200 Subject: [PATCH v2 5/8] clk: qcom: gpucc-msm8998: Use the correct GPLL0 leg with old DTs MIME-Version: 1.0 Message-Id: <20230622-topic-8998clk-v2-5-6222fbc2916b@linaro.org> References: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> In-Reply-To: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeffrey Hugo , Taniya Das Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1688408407; l=933; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=of30u1SnABmz3I8AeyXXYsnJq/vKvFUI7MDU8kDdOEI=; b=e9UlQ0qbi7SeWjuaZi73FWEHwOV0ZkqBcHYh6CVRQzhQO0sDUsTh8aV0y0/KQriKJ31lc0ZYV pRgsGnb1AjrCnAOwk3EgQifWya7nK/l3i4qJkj3d6QG2UOwInovq6dY X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org GPUCC has its own GPLL0 legs - one for 1-1 and one for div-2 output. Add .name lookup to make sure older DTs consume the correct clock. Reviewed-by: Jeffrey Hugo Tested-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gpucc-msm8998.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gpucc-msm8998.c b/drivers/clk/qcom/gpucc-msm8998.c index f929e0f2333f..cc0b43354787 100644 --- a/drivers/clk/qcom/gpucc-msm8998.c +++ b/drivers/clk/qcom/gpucc-msm8998.c @@ -98,7 +98,7 @@ static const struct parent_map gpu_xo_gpll0_map[] = { static const struct clk_parent_data gpu_xo_gpll0[] = { { .hw = &gpucc_cxo_clk.clkr.hw }, - { .fw_name = "gpll0" }, + { .fw_name = "gpll0", .name = "gcc_gpu_gpll0_clk" }, }; static const struct parent_map gpu_xo_gpupll0_map[] = { From patchwork Mon Jul 3 18:20:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 698801 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 809A3C30658 for ; Mon, 3 Jul 2023 18:20:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231244AbjGCSUh (ORCPT ); Mon, 3 Jul 2023 14:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231232AbjGCSUX (ORCPT ); Mon, 3 Jul 2023 14:20:23 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE4C1E7B for ; Mon, 3 Jul 2023 11:20:19 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b699a2fe86so79104061fa.3 for ; Mon, 03 Jul 2023 11:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688408418; x=1691000418; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Qt7V3UlchNnOxeTA5rMeaxcrjkQGtjZo+XDYRU++2Ls=; b=vpv3etGnXrrEh35dcbEHYW1nSyzFNZEy/767Pgh23Vnu80xCW8YURIg24i292S2E7I jrQ8RX+QYccHX+6ADW0dXKmvV/zz18cPkqaimQb/IPky3Xo7/HSbnbgrbdf46ZgbM0pa hD1BcT8M6RXz21wKPk21BEEGEMdd99Zx6Av+pp0LyAz/3I+2NrEcWZSEdrzPJhyKPeTy accz4U/BiVbEN2XG4TdertR42GI48Qyx5Yn7CN96aPz5uktTO/nPL/viWzIj5W9wACif PxfxXSslREtYASdLoEdSkMjFb0+rp4Xrp61Z45h2LyFPuMguxFEgdVQnisbWiWWJbbrB Rk1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688408418; x=1691000418; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qt7V3UlchNnOxeTA5rMeaxcrjkQGtjZo+XDYRU++2Ls=; b=QqrFBgsI3CdzP7/SZ5sTj7US19jFjTRau84b1urgFRCnIhiZwAraoD4hefCtXZK4K9 ycK+0ucmeSYAblJ1bJQ3EBi34aedqRHGZz2knqq9Ye52EgqnFtPS/EDWmPV2vm6UPuPl HBekQP2adZ29ekHPfbo93lflb5LPVG4Xd0Z6w2xpg0rgO+WfKMpwP3YkhE22x99V5Cyd aDsy73lkiMry/HV4q8EhykcS9FORuzXs6XFP1H+tYySMYQu0i6uVa+Sj2VhmWqV3sEVe 6J9iQ5wf1c3QbY2hmRTdi0xs/aL0VQpw8nG/3i77BhMms/h8G9PC6F3xgKiyc31VarfA 2StQ== X-Gm-Message-State: ABy/qLZa6TauVdDpymGqtGrf/7zKLYP9OVissstrZwkZ0Gy0evFvmlBd wXNdsuOyYYmM/7SjAqCxgjKNpQ== X-Google-Smtp-Source: APBJJlEOcD/GenKzzrw8vw5DZ6VZZU8FGH6FFaiD7Z7m5NhSozho296b0yqM5RBCzF2e8eXFhnAh5g== X-Received: by 2002:a2e:9059:0:b0:2b6:9909:79cb with SMTP id n25-20020a2e9059000000b002b6990979cbmr8308978ljg.42.1688408417855; Mon, 03 Jul 2023 11:20:17 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id s9-20020a2e9c09000000b002b6995f38a2sm4946224lji.100.2023.07.03.11.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 11:20:17 -0700 (PDT) From: Konrad Dybcio Date: Mon, 03 Jul 2023 20:20:10 +0200 Subject: [PATCH v2 6/8] clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks MIME-Version: 1.0 Message-Id: <20230622-topic-8998clk-v2-6-6222fbc2916b@linaro.org> References: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> In-Reply-To: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeffrey Hugo , Taniya Das Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1688408407; l=1472; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=viesbfDPZKW9ahGiPob2JBLSqZxiLZQDZKyuYqbzZTo=; b=ISB50XHa+GvfrRMOqhYdMo/UVo1dJsdoFWkSeQP1LpOycDTxnSvD3Uk7LzgTPleZL750EOjEM wY5p0o2x5bFDrPaT2fUtoswPpgixUEuOBZ1XrhPD9XifJHjRvie6ZE+ X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Some branch clocks are governed externally and we're only supposed to send a request concerning their shutdown, not actually ensure it happens. Use the BRANCH_HALT_SKIP define to skip checking the halt bit. Reviewed-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-msm8998.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c index cccb19cae481..ef410f52f09f 100644 --- a/drivers/clk/qcom/gcc-msm8998.c +++ b/drivers/clk/qcom/gcc-msm8998.c @@ -2112,7 +2112,7 @@ static struct clk_branch gcc_gp3_clk = { static struct clk_branch gcc_bimc_gfx_clk = { .halt_reg = 0x46040, - .halt_check = BRANCH_HALT, + .halt_check = BRANCH_HALT_SKIP, .clkr = { .enable_reg = 0x46040, .enable_mask = BIT(0), @@ -2125,7 +2125,7 @@ static struct clk_branch gcc_bimc_gfx_clk = { static struct clk_branch gcc_gpu_bimc_gfx_clk = { .halt_reg = 0x71010, - .halt_check = BRANCH_HALT, + .halt_check = BRANCH_HALT_SKIP, .clkr = { .enable_reg = 0x71010, .enable_mask = BIT(0), @@ -2151,7 +2151,7 @@ static struct clk_branch gcc_gpu_bimc_gfx_src_clk = { static struct clk_branch gcc_gpu_cfg_ahb_clk = { .halt_reg = 0x71004, - .halt_check = BRANCH_HALT, + .halt_check = BRANCH_HALT_SKIP, .clkr = { .enable_reg = 0x71004, .enable_mask = BIT(0), From patchwork Mon Jul 3 18:20:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 700638 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6835FC001B0 for ; Mon, 3 Jul 2023 18:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbjGCSUi (ORCPT ); Mon, 3 Jul 2023 14:20:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbjGCSUZ (ORCPT ); Mon, 3 Jul 2023 14:20:25 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEE4A10C6 for ; Mon, 3 Jul 2023 11:20:20 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b69e6cce7dso73427471fa.2 for ; Mon, 03 Jul 2023 11:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688408419; x=1691000419; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hijFl2QUFFsHhXY1yCqHSNQt/9fhgFqGawyucytFczE=; b=vt5mos3tXUkE80GqbGibWwnnDX1jnTo2f17aW7MX1H5Rs1ZV1Zn+Cqz5TynUOaSQvn b0ZEpblbGjJ+J9BLO/meW0b9tpTx9RKr58bQLDj0v41Lrq/CcSN2cdDFSViGYUYtHVlU xuFkahbIct3Rs9h/M9SAvs1ZjBTLOGV6jjFfg5VAy9rc+HB5y2jlegSvvLWNbYaqAY/1 fjDYLjBW9UpG5zwMzNpDyGhtsncq9AKosnsFn6PgWAa+wwYIyVfEVBUQOF6m2NcQD7LQ dPiNfyypt30gqvFcN3oI6fjb7jlIJLYSwSbe7AI9vF8Cndn+vRI8zk9Y6rjcR4Z3IUNz twnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688408419; x=1691000419; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hijFl2QUFFsHhXY1yCqHSNQt/9fhgFqGawyucytFczE=; b=fJAiasGpF+e0l/ujrRvXZt+O/uw4B3IfovmC5eRlek8xgGhTJKJOsopxc3BsLwJcHI fHLrQKqD9xf1Xyw7JaNY0BrpzCt6aNmAKhZwuO6SfXOZ40Epng0PnZspoDRSCCvbPHRZ sORUdGCkoASplMtyPEt7sNeR7/S7+KMgfQ6hZajptjD26nCeWT6P0/pL9jEOlhqvrHYQ 7gTeZeEI71v8EWHMzUxCbe5omxrpkv2YalNtmLp06sHTXTnVpQ2tR6VzmGgAijzGlYOl mbER0AOQxk5T2CsxMpaiwv3Bt0OTE5DS+Kgmm/18wxgH6YpkI8qWKOT/A016pSLE1P5o h3yQ== X-Gm-Message-State: ABy/qLapeBfc9U2W6sM6DN3smCMhoQVXeC1cIZGb0wCEtp380s0IFvO5 vnZX0qcdytW7gOjojzN4G2NHWw== X-Google-Smtp-Source: APBJJlFJP/hbusGQig3D+lD25i28THHDwjxpVjaw1z/PoqUhvSQGYBYixB/ll81lAjb0k8+sw4NJag== X-Received: by 2002:a2e:9c0e:0:b0:2b6:eceb:9bb with SMTP id s14-20020a2e9c0e000000b002b6eceb09bbmr1833215lji.45.1688408419279; Mon, 03 Jul 2023 11:20:19 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id s9-20020a2e9c09000000b002b6995f38a2sm4946224lji.100.2023.07.03.11.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 11:20:18 -0700 (PDT) From: Konrad Dybcio Date: Mon, 03 Jul 2023 20:20:11 +0200 Subject: [PATCH v2 7/8] arm64: dts: qcom: msm8998: Use the correct GPLL0 leg for GPUCC MIME-Version: 1.0 Message-Id: <20230622-topic-8998clk-v2-7-6222fbc2916b@linaro.org> References: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> In-Reply-To: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeffrey Hugo , Taniya Das Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1688408407; l=790; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=bqBo821nh08iVKE/Ewr81Hlfh17hRb8F8VMbdnAAnZk=; b=hnGnT/+QKMk5tBC41mZER+wx0TcAZ1S/ACQphxhRJ8EjUoBZn/0nGbgZpC+Vep0idptLEkuee T72NIxEv2YWCewN2w6IEYolABdHrMyv95ZOmXJuno4SSraoDS63cVdq X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org GPUCC has its own GPLL0 leg, switch to it to allow shutting it down when it's unused. Reviewed-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index f0e943ff0046..74bd05579796 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1574,7 +1574,7 @@ gpucc: clock-controller@5065000 { reg = <0x05065000 0x9000>; clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, - <&gcc GPLL0_OUT_MAIN>; + <&gcc GCC_GPU_GPLL0_CLK>; clock-names = "xo", "gpll0"; }; From patchwork Mon Jul 3 18:20:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 698800 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34C9CC3063F for ; Mon, 3 Jul 2023 18:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231409AbjGCSUs (ORCPT ); Mon, 3 Jul 2023 14:20:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231299AbjGCSUg (ORCPT ); Mon, 3 Jul 2023 14:20:36 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D075410D7 for ; Mon, 3 Jul 2023 11:20:22 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2b6b98ac328so70717021fa.0 for ; Mon, 03 Jul 2023 11:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688408421; x=1691000421; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bMGOdp2WrmK72JlLnA4GZHmaTpxK++joMT5QYp1sllQ=; b=lhTdDtnHM8h9ePa+Murs4OHPWVomZDeXPgOpnX3OehH26YGjrpqtm70lui0AjPvQtG jaYtgTl041ICwg0AI4Wu/6jmusMI2Acl+N7AmDGsFWGtT6866CWdY9kiiszXiQ16XoFs A9Zwi3qrscx/QnLuDmfkzMKizuAqL6rk2AEMpLN5mHtsCFBTZgXwn4nB87wANtHhph1C l7rty66I47+ALpGD0xCaWOQTSslViZZL5N2vJizbzhkoKG/lHLx6vaQJ0VTebvOFmOcS LgOawt1ww1e0qSzzYnBdCVMLj+ZkF2SfC34Lw2HJJ4ZnNaZjhR/zsnn7qh5S1pPQbFPi da4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688408421; x=1691000421; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bMGOdp2WrmK72JlLnA4GZHmaTpxK++joMT5QYp1sllQ=; b=Wb8TCIbv7kOSEfTibThiOWoSsnxfY3ZjhpLcnZ5FxGj8/UdcjEzGH9cY39+39xBWaf ++c2WiQblFiUeIRRaUXJbYt5TwXISJt1dG5ukNUol5QN057f7JzBYoiCYceTts8HQV5S C4plBh5gAc/y5tC3bhI/5K2Q6bNR8PepcceE+vCNya3Vb2ploHwAGZ2hz82oL3JPryuO GpSqlmYs7mPYQBINanV80bux0H9DxQt4iYp28q9dIUrmtFmRXvB4fYJ7nLsmQT8vGLtE Xnib7Ta7zd1eOvUxE/wqOJRT8a7p8hSq0p9rBaB0iKs+pK09BfW+RWvYmSvcennQaDr/ 2UrA== X-Gm-Message-State: ABy/qLaUe76f4DyNbYzWfmrLjuXhOUOK3+2VIMay349PJCMFDcE+pm5T IfYoX+flB6IFGtEQjBZvH04UGRvmaIIMg0WlaBATAg== X-Google-Smtp-Source: APBJJlE8ny5kSPTUjmQmeDKziqPR0/TUc/91ONsaWaWWKJ4df8Y71rdn6WYsPZtmTayEdfW6z7X7Fw== X-Received: by 2002:a2e:850b:0:b0:2b6:ba00:f733 with SMTP id j11-20020a2e850b000000b002b6ba00f733mr8333259lji.18.1688408420733; Mon, 03 Jul 2023 11:20:20 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id s9-20020a2e9c09000000b002b6995f38a2sm4946224lji.100.2023.07.03.11.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 11:20:20 -0700 (PDT) From: Konrad Dybcio Date: Mon, 03 Jul 2023 20:20:12 +0200 Subject: [PATCH v2 8/8] arm64: dts: qcom: msm8998: Use the correct GPLL0_DIV leg for MMCC MIME-Version: 1.0 Message-Id: <20230622-topic-8998clk-v2-8-6222fbc2916b@linaro.org> References: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> In-Reply-To: <20230622-topic-8998clk-v2-0-6222fbc2916b@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeffrey Hugo , Taniya Das Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1688408407; l=1108; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=rcLA8twyqUlcJD4D43vneN0vw2noKKbjZxFdyfHDJZM=; b=J9qF1k7V2CcK1QdJjF8lyl9xKqY04T25afPjuYYxmly9bH9mpvemJtiRXtaKrrEaWRVNontZE 8X79xc6aeF3D7pgVQuJGJEZIkWOOAAtyaan6pgi66L4r5buBBT1lL5i X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org MMCC has its own GPLL0 legs - one for 1-1 and one for div-2 output. We've already been using the correct one in the non-div case, start doing so for the other one as well. Reviewed-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 74bd05579796..c4faba092368 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2718,7 +2718,8 @@ mmcc: clock-controller@c8c0000 { "dsi1byte", "hdmipll", "dplink", - "dpvco"; + "dpvco", + "gpll0_div"; clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, <&gcc GCC_MMSS_GPLL0_CLK>, <0>, @@ -2727,7 +2728,8 @@ mmcc: clock-controller@c8c0000 { <0>, <0>, <0>, - <0>; + <0>, + <&gcc GCC_MMSS_GPLL0_DIV_CLK>; }; mmss_smmu: iommu@cd00000 {