From patchwork Mon Jul 10 12:36:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 701708 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E70B8EB64D9 for ; Mon, 10 Jul 2023 12:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbjGJMhb (ORCPT ); Mon, 10 Jul 2023 08:37:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjGJMha (ORCPT ); Mon, 10 Jul 2023 08:37:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C603011A for ; Mon, 10 Jul 2023 05:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688992599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=9JvRco+Tgte9aqCDrBBT4Li8b1fghmYlP1pozXh3++c=; b=gHKFuXho+BMBkPpxMXg6qmJxvEJx5V4gkr1C38xnxnbqj3ffhc5PoUrCKswAVigX5308v/ J547eFJcPRTN/YJwB+C7S0Z1vbrqGPxJN5vYMUXEf7lWfQz2ByMZoHaqhcjTuUMwdzA99q n5aoqyrq9dvxWZc3I+FJXOKZVp6RmSY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-391-TM3Q1NqsMPC0TS2GPEi0PA-1; Mon, 10 Jul 2023 08:36:35 -0400 X-MC-Unique: TM3Q1NqsMPC0TS2GPEi0PA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C7D83C10144; Mon, 10 Jul 2023 12:36:35 +0000 (UTC) Received: from x1.localdomain.com (unknown [10.39.195.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id B95EFF66BB; Mon, 10 Jul 2023 12:36:34 +0000 (UTC) From: Hans de Goede To: Dmitry Torokhov Cc: Hans de Goede , linux-input@vger.kernel.org, Peter Hutterer Subject: [PATCH resend 1/2] Input: novatek-nvt-ts - fix input_register_device() failure error message Date: Mon, 10 Jul 2023 14:36:32 +0200 Message-ID: <20230710123633.323937-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fix input_register_device() failure logging "failed to request irq" as error message. Reviewed-by: Peter Hutterer Signed-off-by: Hans de Goede --- drivers/input/touchscreen/novatek-nvt-ts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/novatek-nvt-ts.c b/drivers/input/touchscreen/novatek-nvt-ts.c index 7f7d879aac6d..047e371448ce 100644 --- a/drivers/input/touchscreen/novatek-nvt-ts.c +++ b/drivers/input/touchscreen/novatek-nvt-ts.c @@ -272,7 +272,7 @@ static int nvt_ts_probe(struct i2c_client *client) error = input_register_device(input); if (error) { - dev_err(dev, "failed to request irq: %d\n", error); + dev_err(dev, "failed to register input device: %d\n", error); return error; } From patchwork Mon Jul 10 12:36:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 701373 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74588EB64DC for ; Mon, 10 Jul 2023 12:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbjGJMhc (ORCPT ); Mon, 10 Jul 2023 08:37:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjGJMhc (ORCPT ); Mon, 10 Jul 2023 08:37:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDDEADD for ; Mon, 10 Jul 2023 05:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688992600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4EunXTFPWohHEqIFyvUhfjkaDbMaDEO8C0ZO2BvgWDE=; b=L+geeiz/BgHKKM5xjqWG551u9qmFwrk4/Yc+LHtgfwn+5mKN2GkUuG7Jff1W3agWaHJl88 Mjp3j/M9k/zyThD8/pBa9BplUVAOAeS4fmaCZLSm6VZAGgqUcIvVQudSDpN35xcMvWgm7u 1Wzd5kDCEz7WN4zOGEb+vyqzTU3pu9A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-626-OhA7XoFkP5iB7vZ3DIxJeA-1; Mon, 10 Jul 2023 08:36:37 -0400 X-MC-Unique: OhA7XoFkP5iB7vZ3DIxJeA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF248104458D; Mon, 10 Jul 2023 12:36:36 +0000 (UTC) Received: from x1.localdomain.com (unknown [10.39.195.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id D77FAF66B5; Mon, 10 Jul 2023 12:36:35 +0000 (UTC) From: Hans de Goede To: Dmitry Torokhov Cc: Hans de Goede , linux-input@vger.kernel.org Subject: [PATCH resend 2/2] Input: novatek-nvt-ts - add touchscreen model number to description Date: Mon, 10 Jul 2023 14:36:33 +0200 Message-ID: <20230710123633.323937-2-hdegoede@redhat.com> In-Reply-To: <20230710123633.323937-1-hdegoede@redhat.com> References: <20230710123633.323937-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org A phoronix forum member actual found documentation on what the model number for the touchscreen controller on the Acer Iconia One 7 B1-750 is. Update the driver's description to include this. Link: https://www.phoronix.com/forums/forum/hardware/general-hardware/1382535-10-years-later-linux-getting-a-touchscreen-driver-for-a-once-popular-tablet?p=1384707#post1384707 Signed-off-by: Hans de Goede --- drivers/input/touchscreen/Kconfig | 4 ++-- drivers/input/touchscreen/novatek-nvt-ts.c | 8 +++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index c2cbd332af1d..fb4c23917b69 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -655,10 +655,10 @@ config TOUCHSCREEN_MTOUCH module will be called mtouch. config TOUCHSCREEN_NOVATEK_NVT_TS - tristate "Novatek NVT-ts touchscreen support" + tristate "Novatek NT11205 touchscreen support" depends on I2C help - Say Y here if you have a Novatek NVT-ts touchscreen. + Say Y here if you have a Novatek NT11205 touchscreen. If unsure, say N. To compile this driver as a module, choose M here: the diff --git a/drivers/input/touchscreen/novatek-nvt-ts.c b/drivers/input/touchscreen/novatek-nvt-ts.c index 047e371448ce..1a797e410a3f 100644 --- a/drivers/input/touchscreen/novatek-nvt-ts.c +++ b/drivers/input/touchscreen/novatek-nvt-ts.c @@ -1,9 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* - * Driver for Novatek i2c touchscreen controller as found on - * the Acer Iconia One 7 B1-750 tablet. The Touchscreen controller - * model-number is unknown. Android calls this a "NVT-ts" touchscreen, - * but that may apply to other Novatek controller models too. + * Driver for Novatek NT11205 i2c touchscreen controller as found + * on the Acer Iconia One 7 B1-750 tablet. * * Copyright (c) 2023 Hans de Goede */ @@ -296,6 +294,6 @@ static struct i2c_driver nvt_ts_driver = { module_i2c_driver(nvt_ts_driver); -MODULE_DESCRIPTION("Novatek NVT-ts touchscreen driver"); +MODULE_DESCRIPTION("Novatek NT11205 touchscreen driver"); MODULE_AUTHOR("Hans de Goede "); MODULE_LICENSE("GPL");