From patchwork Thu Jul 20 18:24:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 705371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF062EB64DA for ; Thu, 20 Jul 2023 18:24:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231847AbjGTSY3 (ORCPT ); Thu, 20 Jul 2023 14:24:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231731AbjGTSY0 (ORCPT ); Thu, 20 Jul 2023 14:24:26 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F19CA30C2 for ; Thu, 20 Jul 2023 11:24:07 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2b95efb9d89so17495411fa.0 for ; Thu, 20 Jul 2023 11:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689877446; x=1690482246; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tspcZNQVAOG/ieMod7hnD09w/Zkh9+fCIQ92xXCkBLc=; b=vg8+1CRHxoL5vxPCuBwVapRXpUEpKouHaWSXqSYFr1/UTLahqqiduUJRN0PlZLXR2p Xi/MadEmVMIb6OftU03VnQYYbj6Iy1LEFWQ8ub5fG4P6vN8ZQ91zGt5bryw13HixFkzO FX8qdF/Ld4WFCrBha152saeZ4QghGZflEG3fBBGSVpHh+7utFbCYb8qvFT/9Tgj7zfxq TCISjA1kC7ytMv8uEd0gKzP/MZsQ4B6WVJDqZ/aQlaWUhj6AYjxvckvDKd91NO4x8nMY UCg+F90Mhz/QDubqGOzm016kgkvb4fY2zhOeIZrfVIn1vVVJeQqKWQQln8J+Tnu5UbU3 vdIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689877446; x=1690482246; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tspcZNQVAOG/ieMod7hnD09w/Zkh9+fCIQ92xXCkBLc=; b=E25fN5uJghz8xGT9T7UgD8LQOhVT3RezGgAl0Ryd3QYx8XPbpa0Vi2sQeb0PLR+RcE mTzZn4PB1+mFj3ORTfB9WpkkcyimI4zrLSOgYUvqPZUJDKBaRv0qsIWdLey1+R+4/NPF aBBeb6z/AqrxxWSjGed38IRJFOXNfVCWO2Uj8OwuGQjiGHeWhOYfDizPideNHELZG3nl gCUPbirtoOR5qyhHn8d/4rElYJIyVN4gkWgecto8grW3V/F8Nt9RC/mXONZFagHJ5dsE oBd60iHNYxyVbDgZq4rfmD50lplPGCzHyPUS4lC0U4IGWTt2JY4rSFK5u46t2Ng7y2lF aElw== X-Gm-Message-State: ABy/qLZzIUmazDqL81OJYtKQV3CUcZUEqG3+B4EZyM6LOAd3fLI8qK1u cFaxUHRbN4oZ+ZcJGaEL9IFgBQ== X-Google-Smtp-Source: APBJJlFuZ8olSZ9+XRNTbPJbaoFcV1p1XdMpYAD4No0WSu6ZS1Hi1oYCBrdnRPtJjKzmYYKDd96wgA== X-Received: by 2002:a2e:9989:0:b0:2b1:c1ae:73e3 with SMTP id w9-20020a2e9989000000b002b1c1ae73e3mr2947830lji.15.1689877446252; Thu, 20 Jul 2023 11:24:06 -0700 (PDT) Received: from [192.168.1.101] (abyj181.neoplus.adsl.tpnet.pl. [83.9.29.181]) by smtp.gmail.com with ESMTPSA id g23-20020a2e9397000000b002b31ec01c97sm428304ljh.15.2023.07.20.11.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 11:24:05 -0700 (PDT) From: Konrad Dybcio Date: Thu, 20 Jul 2023 20:24:00 +0200 Subject: [PATCH 1/2] interconnect: qcom: qcm2290: Enable keep_alive on all buses MIME-Version: 1.0 Message-Id: <20230720-topic-qcm2290_icc-v1-1-7f67f2e259c1@linaro.org> References: <20230720-topic-qcm2290_icc-v1-0-7f67f2e259c1@linaro.org> In-Reply-To: <20230720-topic-qcm2290_icc-v1-0-7f67f2e259c1@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Shawn Guo Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1689877443; l=2327; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=M+tTNuP99ZlFEyDR5+8/cKdgpuX5eZVJzdsdG4DBXsU=; b=+hkuq62A1BXLSpnGgub7KQFGH1nrKkS85Db+gSeHpEYzRKijuNd8LBM/pqroBcGtZE52dwU0E NYdDt8T8LO0Bs4PDPwMhfPDs5dNPCfeG/Kgp1MyMx1eoGViYIV/4sz1 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org QCM2290 expects all buses to be up at all times when the CPU is active. Enable keep_alive on all of them to achieve that. Fixes: 1a14b1ac3935 ("interconnect: qcom: Add QCM2290 driver support") Signed-off-by: Konrad Dybcio --- drivers/interconnect/qcom/qcm2290.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c index 3c3b24264a5b..c22354f3e667 100644 --- a/drivers/interconnect/qcom/qcm2290.c +++ b/drivers/interconnect/qcom/qcm2290.c @@ -1196,6 +1196,7 @@ static const struct qcom_icc_desc qcm2290_bimc = { .num_nodes = ARRAY_SIZE(qcm2290_bimc_nodes), .bus_clk_desc = &bimc_clk, .regmap_cfg = &qcm2290_bimc_regmap_config, + .keep_alive = true, /* M_REG_BASE() in vendor msm_bus_bimc_adhoc driver */ .qos_offset = 0x8000, }; @@ -1252,6 +1253,7 @@ static const struct qcom_icc_desc qcm2290_cnoc = { .num_nodes = ARRAY_SIZE(qcm2290_cnoc_nodes), .bus_clk_desc = &bus_1_clk, .regmap_cfg = &qcm2290_cnoc_regmap_config, + .keep_alive = true, }; static struct qcom_icc_node * const qcm2290_snoc_nodes[] = { @@ -1294,6 +1296,7 @@ static const struct qcom_icc_desc qcm2290_snoc = { .num_nodes = ARRAY_SIZE(qcm2290_snoc_nodes), .bus_clk_desc = &bus_2_clk, .regmap_cfg = &qcm2290_snoc_regmap_config, + .keep_alive = true, /* Vendor DT node fab-sys_noc property 'qcom,base-offset' */ .qos_offset = 0x15000, }; @@ -1308,6 +1311,7 @@ static const struct qcom_icc_desc qcm2290_qup_virt = { .nodes = qcm2290_qup_virt_nodes, .num_nodes = ARRAY_SIZE(qcm2290_qup_virt_nodes), .bus_clk_desc = &qup_clk, + .keep_alive = true, }; static struct qcom_icc_node * const qcm2290_mmnrt_virt_nodes[] = { @@ -1323,6 +1327,7 @@ static const struct qcom_icc_desc qcm2290_mmnrt_virt = { .num_nodes = ARRAY_SIZE(qcm2290_mmnrt_virt_nodes), .bus_clk_desc = &mmaxi_0_clk, .regmap_cfg = &qcm2290_snoc_regmap_config, + .keep_alive = true, .qos_offset = 0x15000, }; @@ -1338,6 +1343,7 @@ static const struct qcom_icc_desc qcm2290_mmrt_virt = { .num_nodes = ARRAY_SIZE(qcm2290_mmrt_virt_nodes), .bus_clk_desc = &mmaxi_1_clk, .regmap_cfg = &qcm2290_snoc_regmap_config, + .keep_alive = true, .qos_offset = 0x15000, }; From patchwork Thu Jul 20 18:24:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 704594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD7B3EB64DD for ; Thu, 20 Jul 2023 18:24:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231708AbjGTSYb (ORCPT ); Thu, 20 Jul 2023 14:24:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231821AbjGTSY3 (ORCPT ); Thu, 20 Jul 2023 14:24:29 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18642173A for ; Thu, 20 Jul 2023 11:24:10 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b70404a5a0so16788601fa.2 for ; Thu, 20 Jul 2023 11:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689877448; x=1690482248; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yJbGKInlejV3VBpG5lEDNq2UlayrlJtje9RzPRt66/k=; b=lUXvfFB/TUTP9i4ubj+/XnDoC2z0EeSV4kj8IPHoFxmNTzAZ2sOtVt6ZjpD4AK/Jtr P9yoiJnwNdDYtgeUSadSscna6eWzWoWdj+lT4h+sqUalqPpyf/NtUqpvGxiUMEYiqSc0 e/naKrZE3sJM27pDBT5OEewYfnx7PeO7RsA9veLGYX+9AEeyJY3F4XGVtBNV5vUGkR/C Fz4uD+WVdU+8qH66tX0QJLDnkTv/xV8ohza82S7kTfRDC0pUKH9eS6cKM1g/KRhiaJ7o TaEjOThGah/45S6sfsa8UZdU2XLAmv+CdFt/Z0H0a+0oMMC4a0IxccPphGEpcYst68ST FKGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689877448; x=1690482248; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yJbGKInlejV3VBpG5lEDNq2UlayrlJtje9RzPRt66/k=; b=PAKen3K7yUJRnswvaAEiaEtSzNFKAAw1dJMAOMelir4wILUJpiYaqNLaqK/ECriq+I ABwfydiVLad5juC7I4cx0sZXI0BPnBkhBdzNGqYQmChH8lGfP8zNCi4jNvtyTOPsElRJ VRxOszlVNfy4Si/e0z2nX6nGIdem8iynbwlLL4iwTSGQLgAW3r7hzxnM8IxjUG91CqM3 IUW2ZHQFuPsg88DJMcv+T1Sxj0ZjGu+gRjAI43PtA/cLh1OYsbO+d3zHQM6XUni/ZBUh tyVXtXkXP3jgH3TzQr/mB5a/1Bcpl202MPltbJ8pqHdMknyF1BJI0jZ/qNovOOYPH3mu cTDQ== X-Gm-Message-State: ABy/qLZ+4T7QeR1Pa+hXv9IcC3BeJufhbNoSDFcWat1oqPWkU8ToRspf Wb+vdHQHfDPs7C5acypqmYjvWpWhXcmnc0mXAi6SLQ== X-Google-Smtp-Source: APBJJlHV1QHpzsg80ARmHDESJiKhl5IF5JagGcUDVuYGprI5a6So4BFnkaUdKnPLxqlrI8RqgACZPQ== X-Received: by 2002:a05:651c:d7:b0:2b4:6eb0:2a27 with SMTP id 23-20020a05651c00d700b002b46eb02a27mr3212817ljr.17.1689877448302; Thu, 20 Jul 2023 11:24:08 -0700 (PDT) Received: from [192.168.1.101] (abyj181.neoplus.adsl.tpnet.pl. [83.9.29.181]) by smtp.gmail.com with ESMTPSA id g23-20020a2e9397000000b002b31ec01c97sm428304ljh.15.2023.07.20.11.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 11:24:08 -0700 (PDT) From: Konrad Dybcio Date: Thu, 20 Jul 2023 20:24:01 +0200 Subject: [PATCH 2/2] interconnect: qcom: qcm2290: Enable sync state MIME-Version: 1.0 Message-Id: <20230720-topic-qcm2290_icc-v1-2-7f67f2e259c1@linaro.org> References: <20230720-topic-qcm2290_icc-v1-0-7f67f2e259c1@linaro.org> In-Reply-To: <20230720-topic-qcm2290_icc-v1-0-7f67f2e259c1@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Shawn Guo Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1689877443; l=848; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=2/Oo4HuXZdKRBcTWrVM14eHjkhJTowhQs8f0byzlaxA=; b=2gODwk7mWvcrH5TQAE0U2G2K/SvZ95dPHXuYPuK3g+M4nAEtnVC0r7SxHnKOKLbIiCVrjsW36 WuqFs51GY1ADgmVf+qN+a2iYVWXF4g5plMugYznKlk5iAxPCiI/xHId X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Very surprisingly, qcm2290 does not seem to require any interface clocks. It's therefore safe to enable sync_state to park unused devices. Do so. Fixes: 1a14b1ac3935 ("interconnect: qcom: Add QCM2290 driver support") Signed-off-by: Konrad Dybcio --- drivers/interconnect/qcom/qcm2290.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c index c22354f3e667..5bc4b7516608 100644 --- a/drivers/interconnect/qcom/qcm2290.c +++ b/drivers/interconnect/qcom/qcm2290.c @@ -1364,6 +1364,7 @@ static struct platform_driver qcm2290_noc_driver = { .driver = { .name = "qnoc-qcm2290", .of_match_table = qcm2290_noc_of_match, + .sync_state = icc_sync_state, }, }; module_platform_driver(qcm2290_noc_driver);