From patchwork Fri Jul 21 12:03:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Rymanowski?= X-Patchwork-Id: 705464 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06063EB64DD for ; Fri, 21 Jul 2023 12:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231497AbjGUMF1 (ORCPT ); Fri, 21 Jul 2023 08:05:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231319AbjGUMFH (ORCPT ); Fri, 21 Jul 2023 08:05:07 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF8BD30F5 for ; Fri, 21 Jul 2023 05:04:56 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2b74209fb60so27488691fa.0 for ; Fri, 21 Jul 2023 05:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codecoup-pl.20221208.gappssmtp.com; s=20221208; t=1689941095; x=1690545895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uBmrOOAi8DD4Y+ChseAJhqkrvV1M8DrwtBBmtQH5UuU=; b=GaMoZMOntpMJ8DBNiNb5SMGZYsK+e1IrP3Rx+d++/W33TOIqUIPnVlFH09iTIJnq5c xC+QNRvy1jiV9MPD31OmSfcKrFSgiOfl76RknJwb7aQot20s+W5Tk0gSU492KcyZDtTk p1QVE+4wEYPgT7XjZZrw7Klqk8jULg/OkGaRO+j8gs/IB7eZbGOJCKC8vjiY7PwjIP6Z FzRL4h0uviZ5C7xAHZgWowFVjzp96JCazDcwhW4F6pXpJc3FPxb8ELbJWpajRRqnJPmP AeS4T6sVsjWre9zW4Iygh8C9WKOOgK5ASP2xnO7FyZVzULkYrdgbzorsiT5dEusfzfUP aWZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689941095; x=1690545895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uBmrOOAi8DD4Y+ChseAJhqkrvV1M8DrwtBBmtQH5UuU=; b=E8ivSnN2DLb8XCdzjjowJ6nXWcYzX72gNkYQq1Nl7gFEOHAravPbZXL0bMVAYZJmUp r9FvMdiMiuo3Yj2QCE8RJK/htjZ1zhgwLPpqmZPS9MHGm8UpAE9JORDm7Eble2OFPQau tERXF2XutG//d4xaTH0CVMIu/BSN/VN51dGLScl8ImqfMHwIOS9Cs+Beyv/18XRoQvBe GWlkMgjv8H6yLMSymohP4Y8eBq7GT9HPOaHwxJasKuBsC6rmGxcOiJ1KfqAO5903qKRR jwnouNvnEBaaxz9/eHxWv0XkcYOPyDphGne39cxHScUbBNy/q5Sz2N241aZzPd9xW/9s W9Qw== X-Gm-Message-State: ABy/qLbwtqW/wjOkMEyHP61vMZx88I9nUMwZ9boQdNDTIhY98NSnsiYM ms3GtvrqPA0I/Ump1TPJZpkfQN4Lmv4gB5Dp85s= X-Google-Smtp-Source: APBJJlGYpH5F2kru277WwSFDNiaeF8YRAZK+sJaJ6624NOZdFRhuhiiTrSv/JUn+vMceZBGARLnNPA== X-Received: by 2002:a05:651c:d0:b0:2b6:ee6d:b647 with SMTP id 16-20020a05651c00d000b002b6ee6db647mr1297550ljr.28.1689941094948; Fri, 21 Jul 2023 05:04:54 -0700 (PDT) Received: from rymek.localdomain (217.96.247.89.ipv4.supernova.orange.pl. [217.96.247.89]) by smtp.gmail.com with ESMTPSA id z26-20020a2e885a000000b002b6de6deb5asm907977ljj.2.2023.07.21.05.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 05:04:54 -0700 (PDT) From: =?utf-8?q?=C5=81ukasz_Rymanowski?= To: linux-bluetooth@vger.kernel.org Cc: Jakub Tyszkowski Subject: [PATCH BlueZ 1/4] monitor: Fix adv_handle size in the set info transfer packet Date: Fri, 21 Jul 2023 14:03:17 +0200 Message-Id: <20230721120320.147496-2-lukasz.rymanowski@codecoup.pl> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230721120320.147496-1-lukasz.rymanowski@codecoup.pl> References: <20230721120320.147496-1-lukasz.rymanowski@codecoup.pl> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Jakub Tyszkowski As per Bluetooth Core 5.4 Vol 4. Part E, 7.8.90, adv_handle is 1 octet size and not 2. --- monitor/bt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/bt.h b/monitor/bt.h index 37fcdaeaa..131024e46 100644 --- a/monitor/bt.h +++ b/monitor/bt.h @@ -2608,7 +2608,7 @@ struct bt_hci_cmd_periodic_sync_trans { struct bt_hci_cmd_pa_set_info_trans { uint16_t handle; uint16_t service_data; - uint16_t adv_handle; + uint8_t adv_handle; } __attribute__ ((packed)); #define BT_HCI_CMD_PA_SYNC_TRANS_PARAMS 0x205c From patchwork Fri Jul 21 12:03:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Rymanowski?= X-Patchwork-Id: 705039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2706C001DC for ; Fri, 21 Jul 2023 12:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231332AbjGUMF3 (ORCPT ); Fri, 21 Jul 2023 08:05:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231330AbjGUMFM (ORCPT ); Fri, 21 Jul 2023 08:05:12 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D5DF35BF for ; Fri, 21 Jul 2023 05:04:58 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b708e49059so27859571fa.3 for ; Fri, 21 Jul 2023 05:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codecoup-pl.20221208.gappssmtp.com; s=20221208; t=1689941096; x=1690545896; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DZ+hV81VUwLcZan3YxnT1oGv7b2v/jxtZKXkrhJcy3w=; b=QUsypjJBavJEgtbU0dOkBL+Pki8dqJQ+AfU4FvB1HFIV12l8el9ultxfvWalpWpe+c 83DDJWwK9nfCoXIv58g/hoCFs5eGnCD47sO7Tm8JGjbIsDbcbeHt+brMobwFUi2Ir2XR nvyLBxnfIe3tXtRgO1feqznms8b6wl96dOqEZ4Hc6j3jgGSlVzKqem/RnsQoDOg01OH5 SBEq54m1aNx3CGPZxPHdUwSmmv0PNdmW8pPrJ1iKAb9Ysf01aOICghkPvyNCmlXiZHWc wT20MuPi59nAhVj+FeAg5/zHTFoxjG3ZSq9SumFQwilweec0JMCCXXecvPUxoB1zlrG5 M1+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689941096; x=1690545896; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DZ+hV81VUwLcZan3YxnT1oGv7b2v/jxtZKXkrhJcy3w=; b=MMX2jyqthm2/SZ8Ll5wYYzp/avTggaG+MGgeSKGz7IAViuOBpZQL5oU/GsPQMCU2XJ VclEskUA/xLWcde9Caj9SXohGCohKrscwDIKeYNNdW1rBpcy5ANyO1jSecZ+b4gFTZDG WqRT7FuxZmeHQDQydWD36gz1JYtVfbMX+s4tMKVl4HZ4TiclVImawlETpfFYQjxAfdH+ gOk/YDmIPkhlwsOzttGS+xZjrQyChn9xthm8H/uyCRG+3uL7zoB1I3j1QoENjOjDpbpJ qGGrY1/QF/dom0rD432q46EkwVo8//LfhhwZ+IpO6quPCvdbHYGFjhyhiiAp4jZIWSjG i8/g== X-Gm-Message-State: ABy/qLa/5yrznRnA1MlKEfMnR+h/b4ktcjznhDnyPMMU9N4jnTPXteEh GNeGTVzYZ8xaRHQ1Mob47X54TanX3nET00mi1Rc= X-Google-Smtp-Source: APBJJlFA0Ng06KZkmPrqnK/T/CbcjdFM8gwll9/1y6MuLZvxn4h6p8YF1w1g4n5ULDcyClWIxyjLDA== X-Received: by 2002:a2e:9ed6:0:b0:2b4:7559:32b0 with SMTP id h22-20020a2e9ed6000000b002b4755932b0mr1312338ljk.19.1689941096135; Fri, 21 Jul 2023 05:04:56 -0700 (PDT) Received: from rymek.localdomain (217.96.247.89.ipv4.supernova.orange.pl. [217.96.247.89]) by smtp.gmail.com with ESMTPSA id z26-20020a2e885a000000b002b6de6deb5asm907977ljj.2.2023.07.21.05.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 05:04:55 -0700 (PDT) From: =?utf-8?q?=C5=81ukasz_Rymanowski?= To: linux-bluetooth@vger.kernel.org Cc: Grzegorz Kolodziejczyk Subject: [PATCH BlueZ 2/4] monitor: Fix invalid Create BIG Test command Date: Fri, 21 Jul 2023 14:03:18 +0200 Message-Id: <20230721120320.147496-3-lukasz.rymanowski@codecoup.pl> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230721120320.147496-1-lukasz.rymanowski@codecoup.pl> References: <20230721120320.147496-1-lukasz.rymanowski@codecoup.pl> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Grzegorz Kolodziejczyk As per Bluetooth Core 5.4 Vol 4 Part E, 7.8.104, max pdu is 2 octect long and there is no adv_handle before encyption flag --- monitor/bt.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/monitor/bt.h b/monitor/bt.h index 131024e46..ea24a076e 100644 --- a/monitor/bt.h +++ b/monitor/bt.h @@ -2777,14 +2777,13 @@ struct bt_hci_bis_test { uint16_t iso_interval; uint8_t nse; uint16_t sdu; - uint8_t pdu; + uint16_t pdu; uint8_t phy; uint8_t packing; uint8_t framing; uint8_t bn; uint8_t irc; uint8_t pto; - uint8_t adv_handle; uint8_t encryption; uint8_t bcode[16]; } __attribute__ ((packed)); From patchwork Fri Jul 21 12:03:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Rymanowski?= X-Patchwork-Id: 705463 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 188DEC001E0 for ; Fri, 21 Jul 2023 12:05:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229970AbjGUMFa (ORCPT ); Fri, 21 Jul 2023 08:05:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbjGUMFQ (ORCPT ); Fri, 21 Jul 2023 08:05:16 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B37143A8B for ; Fri, 21 Jul 2023 05:04:59 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b93fba1f62so26864771fa.1 for ; Fri, 21 Jul 2023 05:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codecoup-pl.20221208.gappssmtp.com; s=20221208; t=1689941097; x=1690545897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pq/Ym9K0M1at13oCTYicZlpQJA87B2Yp+rEQ+Rwkc/k=; b=ifU79JtfpixOCL1Zk1chV1bFi2QRPPz5TeEhD85J60e74Dq8hVZ2CUcpDIppZ0g6PM ZEkj0TOMv2clPN9V5/+uk5GXHAF5BM5SNhh84q2qI2hc9bFM5lvjz2hmkI6Sqh+sRSuB QI8qPrV7xH27TMs5Y3SrI2gKdIzTB1bxRc6yiLXz7faKg3TMvuqeZlXVAKMivKVvSZRm ezwy0CsBngNRpj/m9oy3h0vN603yeMwDujjuzPoIdrHS0mU1zO/k1LoSh1smpF2uKQG6 5ROXCxqRBHiruXA0WPPxdkNVS3v1Rd7xZBYE4jr0aJ5qmf7M3v85eWLN0Gw62uja7kag NvvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689941097; x=1690545897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pq/Ym9K0M1at13oCTYicZlpQJA87B2Yp+rEQ+Rwkc/k=; b=O9PIQ+JPjKE7bsmMYO8yyhp7A2dxrCpMMWxjpozGIzg8Utp/orCQF2hXL+4dqUCg5i qh4gwp7EA230j/GicjkmdOyd1oaO2yAGNfuz+enacZbZT76lz1E8OMRWoUfcuaa3PHBf RboEBHqrv/ChofwC17CdABpuzkd+rmuGPsHcvf58oMOTx62C0DY+N/gNXp2xt5vP5WuD 8LOGyFTMPsAqu+Jl78DXt/a8W0jWGwcyFUYCMeeif7vw1ghXRnZAHOcw1bH1NJg48zQx yDlnHwqK6viS3mMHRUlQwJTLeMtnbvupXR9WiMC/YCjrIY81XAZaSv66L5rse/kZoqEN eqVQ== X-Gm-Message-State: ABy/qLawjmMowMzvogndmYB0Iec7Vm4pbw+Q6VZL86nqWp/LS+bfaqt4 H6C6qe7Yl41yNtD0cepkiR6P86lXpgXMptinZ5Q= X-Google-Smtp-Source: APBJJlE7qQAscXqIy+XMgNfRkbrotHr3slYeXFQ/MscdlWF72QfU9uPvuPml5kFn7hP1tch96xbgSw== X-Received: by 2002:a2e:9896:0:b0:2b6:e7ff:4b2e with SMTP id b22-20020a2e9896000000b002b6e7ff4b2emr1359918ljj.33.1689941097143; Fri, 21 Jul 2023 05:04:57 -0700 (PDT) Received: from rymek.localdomain (217.96.247.89.ipv4.supernova.orange.pl. [217.96.247.89]) by smtp.gmail.com with ESMTPSA id z26-20020a2e885a000000b002b6de6deb5asm907977ljj.2.2023.07.21.05.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 05:04:56 -0700 (PDT) From: =?utf-8?q?=C5=81ukasz_Rymanowski?= To: linux-bluetooth@vger.kernel.org Cc: =?utf-8?q?=C5=81ukasz_Rymanowski?= Subject: [PATCH BlueZ 3/4] btmon: Fix obvious typo Date: Fri, 21 Jul 2023 14:03:19 +0200 Message-Id: <20230721120320.147496-4-lukasz.rymanowski@codecoup.pl> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230721120320.147496-1-lukasz.rymanowski@codecoup.pl> References: <20230721120320.147496-1-lukasz.rymanowski@codecoup.pl> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org --- monitor/packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/packet.c b/monitor/packet.c index f2167fb52..fd1e9e034 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -11593,7 +11593,7 @@ static void le_big_complete_evt(struct timeval *tv, uint16_t index, print_le_phy("PHY", evt->phy); print_field("NSE: %u", evt->nse); print_field("BN: %u", evt->bn); - print_field("PTO: %u", evt->bn); + print_field("PTO: %u", evt->pto); print_field("IRC: %u", evt->irc); print_field("Maximum PDU: %u", evt->max_pdu); print_slot_125("ISO Interval", evt->interval); From patchwork Fri Jul 21 12:03:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Rymanowski?= X-Patchwork-Id: 705038 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3689EB64DC for ; Fri, 21 Jul 2023 12:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231402AbjGUMFf (ORCPT ); Fri, 21 Jul 2023 08:05:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231396AbjGUMFU (ORCPT ); Fri, 21 Jul 2023 08:05:20 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA48E3A9D for ; Fri, 21 Jul 2023 05:05:00 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b703cbfaf5so27189351fa.1 for ; Fri, 21 Jul 2023 05:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codecoup-pl.20221208.gappssmtp.com; s=20221208; t=1689941098; x=1690545898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6+l+E6WOqPvLovqraD39twbq8sUliN3bDM6u2bR47Zg=; b=md+50u6T1mYLLk7/fSuFlsN83lkTCuU9FQMQk5gdKPuIoN8uDkuq7XZKZMQmbxgqmz NNRoafMLZcRwoTWm6qHnFfKL3iG9TNl/cmblGnUn8JyIVxuggiTGKEDVm6kVQV+BlMG6 9cWaFBekAonEj+ij3w5ye4sE9oxPPI3tfUkNyYtChrfiN9aeq28EMc/Axw8AUxZAKhMN uzDqobOCorMfHAutZ0pyhrf1GlBJNrwLFDL0y/aRPy7okPIGQElHCeMmgnzbJ4ZUxfN3 e1IXF4dF5VMCFi6IQ+sXSoY+mMbus609bYSOYuGU6Y6CcGmoLTmsPCSU/FMLmgFddnqI XaTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689941098; x=1690545898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6+l+E6WOqPvLovqraD39twbq8sUliN3bDM6u2bR47Zg=; b=BEKq1SE+lz/NQ0fR9+XQkv38FjC7sBLBExg+0+wTrtzJuJ7dC6GzISoQXKZIs9M20F aRFdEu/S8BsnDGpHf7pOJSqo1A2ki6UK87bmx90QSVrsCAQBpgtQi5cRelxJ38WpwGj1 ZP+Bm8RjgrBtQ+evK5yuo1l8VeRGZN8cu9kBwKq1zCCLfXkRbKt+9s4dTb+avLf6PV3e w2juKAcBkTOnAYVs6mmdk4Wz9LQQku0nn4SaMWft8wrJO3XoyriYV/FXshiM7H29deZA LflPft2JLf8nP3yisR53ko700S2djEm41pA2Pm3xusjYBtd8V3wNL9geSq5eD7qixCPs 9/LQ== X-Gm-Message-State: ABy/qLYvpRodhvUwNq3EbjTOKdYV+GQ8+r7QE/WqRsbrQdONeMPJK+Hw V9d9YNu8L1f675KgSgCKU5VzhUBgdSlya0ejp8Q= X-Google-Smtp-Source: APBJJlEqap73uioOLFEd45qF5ZStRoLOWpz11y0W4jQqyAJNQYJnYAhMvLKRPGeyF9sUXnPIRrjOlQ== X-Received: by 2002:a2e:8e95:0:b0:2b6:efcf:1463 with SMTP id z21-20020a2e8e95000000b002b6efcf1463mr1305247ljk.6.1689941098226; Fri, 21 Jul 2023 05:04:58 -0700 (PDT) Received: from rymek.localdomain (217.96.247.89.ipv4.supernova.orange.pl. [217.96.247.89]) by smtp.gmail.com with ESMTPSA id z26-20020a2e885a000000b002b6de6deb5asm907977ljj.2.2023.07.21.05.04.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 05:04:57 -0700 (PDT) From: =?utf-8?q?=C5=81ukasz_Rymanowski?= To: linux-bluetooth@vger.kernel.org Cc: =?utf-8?q?=C5=81ukasz_Rymanowski?= Subject: [PATCH BlueZ 4/4] btmon: Make BIG identifier consistent Date: Fri, 21 Jul 2023 14:03:20 +0200 Message-Id: <20230721120320.147496-5-lukasz.rymanowski@codecoup.pl> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230721120320.147496-1-lukasz.rymanowski@codecoup.pl> References: <20230721120320.147496-1-lukasz.rymanowski@codecoup.pl> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Bluetooth spec uses BIG Handle as a BIG identifier. Btmon sometimes use this and sometimes BIG ID. This patch makes code consistent --- monitor/bt.h | 4 ++-- monitor/packet.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor/bt.h b/monitor/bt.h index ea24a076e..b60263fa0 100644 --- a/monitor/bt.h +++ b/monitor/bt.h @@ -2789,7 +2789,7 @@ struct bt_hci_bis_test { } __attribute__ ((packed)); struct bt_hci_cmd_le_create_big_test { - uint8_t big_id; + uint8_t big_handle; uint8_t adv_handle; uint8_t num_bis; struct bt_hci_bis_test bis[0]; @@ -3676,7 +3676,7 @@ struct bt_hci_evt_le_big_sync_estabilished { #define BT_HCI_EVT_LE_BIG_SYNC_LOST 0x1e struct bt_hci_evt_le_big_sync_lost { - uint8_t big_id; + uint8_t big_handle; uint8_t reason; } __attribute__ ((packed)); diff --git a/monitor/packet.c b/monitor/packet.c index fd1e9e034..f581a8e72 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -8811,7 +8811,7 @@ static void le_create_big_cmd_test_cmd(uint16_t index, const void *data, { const struct bt_hci_cmd_le_create_big_test *cmd = data; - print_field("BIG ID: 0x%2.2x", cmd->big_id); + print_field("BIG Handle: 0x%2.2x", cmd->big_handle); print_field("Advertising Handle: 0x%2.2x", cmd->adv_handle); print_field("Number of BIS: %u", cmd->num_bis); @@ -11633,7 +11633,7 @@ static void le_big_sync_lost_evt(struct timeval *tv, uint16_t index, { const struct bt_hci_evt_le_big_sync_lost *evt = data; - print_field("BIG ID: 0x%2.2x", evt->big_id); + print_field("BIG Handle: 0x%2.2x", evt->big_handle); print_reason(evt->reason); }