From patchwork Fri Jul 28 13:48:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 707660 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95724C001DE for ; Fri, 28 Jul 2023 13:49:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236925AbjG1Ntd (ORCPT ); Fri, 28 Jul 2023 09:49:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236881AbjG1NtI (ORCPT ); Fri, 28 Jul 2023 09:49:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FF162D60; Fri, 28 Jul 2023 06:48:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 022A462130; Fri, 28 Jul 2023 13:48:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9FFCC433C7; Fri, 28 Jul 2023 13:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690552136; bh=ybAewDSIihhc9NHGhos2fH++UkcTbQSngJl7W7DzYpc=; h=From:To:Cc:Subject:Date:From; b=oDxPzCSS6ehCZesw8RUEPFEJvyhTJvVh/bwVCf/zMFZ8ahhmcU1v6L0qxMJrJC2L1 w826i3oZYo16kjtBfSrcWXLvw6+wzJ2+FfBRzoHEUuji3Bv8PjcYMMN/M7wq19U5om pTRClACtk8Rf797gBpL8u1ns1MFtNCc1p/zQy208F+rrB4NmB91JIcbgVi4933dC8U dsVa93vqJe190+Jrf2LYiyNfjf4nPqBs721jYiR33v0p1IF6WIRgVG4e0ltAL9hYdm tH3MGCT6juqTCo29mUJHmtAxdLhsC170M6MBzonGxxguVNCrDMDSXp3MimuOTrf00F fwPwf68IjUrHw== Received: (nullmailer pid 3224739 invoked by uid 1000); Fri, 28 Jul 2023 13:48:55 -0000 From: Rob Herring To: David Airlie , Arnd Bergmann , Greg Kroah-Hartman Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] char: Explicitly include correct DT includes Date: Fri, 28 Jul 2023 07:48:45 -0600 Message-Id: <20230728134845.3224553-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring --- v3: - Split out hw_random, ipmi and tpm --- drivers/char/agp/uninorth-agp.c | 1 + drivers/char/bsr.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c index 62de7f4ba864..84411b13c49f 100644 --- a/drivers/char/agp/uninorth-agp.c +++ b/drivers/char/agp/uninorth-agp.c @@ -3,6 +3,7 @@ * UniNorth AGPGART routines. */ #include +#include #include #include #include diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c index 12143854aeac..70d31aed9011 100644 --- a/drivers/char/bsr.c +++ b/drivers/char/bsr.c @@ -6,11 +6,10 @@ * Author: Sonny Rao */ +#include #include #include #include -#include -#include #include #include #include