From patchwork Fri Jul 28 06:57:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 707796 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C60BEB64DD for ; Fri, 28 Jul 2023 06:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229704AbjG1G6I (ORCPT ); Fri, 28 Jul 2023 02:58:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233249AbjG1G55 (ORCPT ); Fri, 28 Jul 2023 02:57:57 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E4D51984 for ; Thu, 27 Jul 2023 23:57:56 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPHQ1-00087i-Fk; Fri, 28 Jul 2023 08:57:45 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qPHQ0-002eF2-5g; Fri, 28 Jul 2023 08:57:44 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qPHPz-008R2s-Dv; Fri, 28 Jul 2023 08:57:43 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Pavel Machek , Lee Jones Cc: Thierry Reding , Bjorn Andersson , linux-leds@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] leds: qcom-lpg: Drop assignment to struct pwmchip::base Date: Fri, 28 Jul 2023 08:57:39 +0200 Message-Id: <20230728065739.580281-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=998; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=845Cv8LFVOCbFmNAvr+AGvykNh6/RSBGwmWMMyvTQek=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkw2bfG9fFr/jxy1Wo+A2MtDqYOB/Mz+GiwdRHz e63FK9+/1CJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZMNm3wAKCRCPgPtYfRL+ TqJNB/4p74GfdGCN4pf4v0MLm4I2BzKhxdy3/AqILmhrq6rmrSnKnO5yvNDHjL9uih+QzLh5tSX 1aWkjjZkvQBGcBLHbugh844g+Md0urtjdxott0TFdeAh/9RtSOvqOW7LrrgCCoRp9dTKOu0OwCE 9cjezfDm06anuMY+rFaidSho+HrDRO0dp1mHwA7PL+cNA2C89cVv5vv3JhlhlBed6b8pOslFVIP lCy0uZJUCBZgZ+f0MyR9+fhJ0bJaXS87zKpjOuL+31U/eWC6nA/IMuwflGybyUx88fobbWsPCGm Nu6sps0Avb9Bfx94Cg2pFrnRSrHUMzcnnsqKa4VQ5W0py9RZ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-leds@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Since commit f9a8ee8c8bcd ("pwm: Always allocate PWM chip base ID dynamically") there is no effect any more for assigning this variable. See pwmchip_add() which unconditionally overwrites this member. Signed-off-by: Uwe Kleine-König --- Hello, this is the last driver setting .base. Would be great to get rid of that, as I might want to drop .base from the pwm core. Thanks for considering, Uwe drivers/leds/rgb/leds-qcom-lpg.c | 1 - 1 file changed, 1 deletion(-) base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c index 59581b3e25ca..c2fc768eaf87 100644 --- a/drivers/leds/rgb/leds-qcom-lpg.c +++ b/drivers/leds/rgb/leds-qcom-lpg.c @@ -1093,7 +1093,6 @@ static int lpg_add_pwm(struct lpg *lpg) { int ret; - lpg->pwm.base = -1; lpg->pwm.dev = lpg->dev; lpg->pwm.npwm = lpg->num_channels; lpg->pwm.ops = &lpg_pwm_ops;