From patchwork Fri Jul 12 09:37:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 168924 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp630304ilk; Fri, 12 Jul 2019 02:37:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyTosmvClsMsv4/qdmyB8FeTdjrB+hxAwhdd/qSyGYtqu+nyOjxw4U6JEnqZjzUYzSFIvGL X-Received: by 2002:a17:90a:d343:: with SMTP id i3mr10952681pjx.15.1562924251569; Fri, 12 Jul 2019 02:37:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562924251; cv=none; d=google.com; s=arc-20160816; b=R4pMF+WESO50qSiiF7udWlBGu7jFtu++eG0vdMEz+QpiwAnBn9EQnT7wK9H3nNQI/B 8oOEPQrlCwGYn5BmA+BgTE+qtyFUvxCYA5J2CW+vYpQgqyckxCMS3vatz5Un/bjGO+sf nr6Hs0ckGD8ah0xFhQMiwfteTyfZn/8pY8ZuGiEPgD1Q7Q6x5h4+srCGWdAsPd6Oct0j vrPQVAJR8+D3hiHsMmCEVADPSMOfBt1sP5Qp2PuZCuOLZbZVBmqIstFbTcUE74/6lJxS kGRdcbb2ZtFfsIeXniDeB3x5ORHl0voAIbbrJ8xVBJRy1JMsjlYYQJKF2hSk7NB3V/TE wXzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :delivered-to; bh=OPNVf4ili94QgmrvpmIp1mSOQwWv6jY/mjLek6fgV8g=; b=xdKvoLMhzFqpb5THXtIr2qdlk9Q1XgLpS/pyvP160akbgaELag8WvkC9NlEOcUaxLz Zx+jZ6FpEHF1JbQTkgCHCmhDNENqFvF2tIqdVa8JArC4eEJc8mtxyPfkf9HpITCMHRM7 tJsKKoASJsUPWSWA4Jo0hpwWvPZQspbbk7Xtg9QrGMxg9hk2w596HG35Zzs7pasO15QQ xboX3yfqaF5uQ0+f7FV2XjkHi2JDK8xEJyqLuKm9WUBQiQ6qaNTMl+kpkUeW5hZ3iikk 1NUtC0e0zPTyuKOQA7eiAsTSBzWmj+OJlcWAJQqJc1ZnZizxos2Tjgj58ZJZZ8d/0vX/ JCqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id t5si8326411pgr.172.2019.07.12.02.37.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Jul 2019 02:37:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9062F6E339; Fri, 12 Jul 2019 09:37:30 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id D54F96E33A; Fri, 12 Jul 2019 09:37:28 +0000 (UTC) Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPA (Nemesis) id 1MdNLi-1iLCk53jKC-00ZPIO; Fri, 12 Jul 2019 11:37:21 +0200 From: Arnd Bergmann To: Harry Wentland , Leo Li , Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter Subject: [PATCH] drm/amd/display: Support clang option for stack alignment Date: Fri, 12 Jul 2019 11:37:00 +0200 Message-Id: <20190712093720.1461418-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:d225NHDmVD8iHvGnyul/A/ipRUep4hflYOdBban/FHrJgvhxnwv 4MOV5qJc3d5lz4zwHGjhcNI0lO6YeTDm7VaRk9k1YAdyNbsflFi7qPCg/GwFqlbD0OrsWYN FzvL8RHmKRWR1k4HjLX5fBsO5NlMAPZrlHpxcA/UIv+Sl9Iv3G9E7bFJKG7hCU0MpdQvLtR oZHlNirSXwa7UbVjwnrTw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:lTHGrsZeWDM=:JXCj53bNX2jlA8G/jk8q9+ ku8scKecqGHwd//M28KuzmF+Udem5qyLlHQV2zMS1Jg3rBvvg/cNt4x6RrCo5RH6PKIGrSu/i B/Bti/71s2AuQlWoXGqjfoFlxuug3UgBX91WMWnSENAN1bSjgZ0ZemyFsCYG5tvDjkOghoxGS /lDssxfXCq/AfHwMHdJajXPlEkIhVNxuUnssbH56PS2JISYB8pfKvyKYnymBNJcFBMUGvSVuy kqrT+3lW6FHT25MyhMn2IkdYmyNKC70IIoY+rVkZ8YXDd2UDXKt2jvizqLEpk+9RFAxrR4S8B z8Ac0OgVJ+uBz/9k/yLMWNwMsnTp+XGzWX3qEr0PBnXU+JiI1yQzyZe9t0KzBrxqkgPvzL3ia zSePZ2s3kMktRQXEgA7hTXaxOi7u/HnGhkrK3rgKy0nnOji2+J+gIunq7HQoyZUpNKIXQJk8S Cp6eTKeARkhKlWgOF52HoJLP7NGu8FjXF3EuVOTgSSGDLRPpIquHuUDQYwIiWKYikXIP2NNN7 wrnP3dPMWR9AL2YKmn/pVOchHMns4PVWViw8RiufYmdSP6uq3D8+5R7HhuBJYClSZ2mRmowMQ 9VVEiEKk2z8iku0UcsJOZolAmOHxj/dd+7a8zB5dUSgvf/OSVonGiG7c+Zy+L5RzpMLu6RXd9 g8TQse+9URd/yHET2bfxsVwbp/AF2e+qur4ac7cUDBd0VZCEj9YrMHtstMcgxWK0eWHD7BzmR FBtEJaNLWUDMuqMFssmtpEc9hsZPhizIMAx1Pw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Charlene Liu , Duke Du , Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, clang-built-linux@googlegroups.com, Dmytro Laktyushkin , amd-gfx@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" As previously fixed for dml in commit 4769278e5c7f ("amdgpu/dc/dml: Support clang option for stack alignment") and calcs in commit cc32ad8f559c ("amdgpu/dc/calcs: Support clang option for stack alignment"), dcn20 uses an option that is not available with clang: clang: error: unknown argument: '-mpreferred-stack-boundary=4' scripts/Makefile.build:281: recipe for target 'drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.o' failed Use the same trick that we have in the other two files. Fixes: 7ed4e6352c16 ("drm/amd/display: Add DCN2 HW Sequencer and Resource") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/display/dc/dcn20/Makefile | 8 +++++++- drivers/gpu/drm/amd/display/dc/dsc/Makefile | 16 ++++++++++++---- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/Makefile b/drivers/gpu/drm/amd/display/dc/dcn20/Makefile index 1b68de27ba74..e9721a906592 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn20/Makefile +++ b/drivers/gpu/drm/amd/display/dc/dcn20/Makefile @@ -10,7 +10,13 @@ ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT DCN20 += dcn20_dsc.o endif -CFLAGS_dcn20_resource.o := -mhard-float -msse -mpreferred-stack-boundary=4 +ifneq ($(call cc-option, -mpreferred-stack-boundary=4),) + cc_stack_align := -mpreferred-stack-boundary=4 +else ifneq ($(call cc-option, -mstack-alignment=16),) + cc_stack_align := -mstack-alignment=16 +endif + +CFLAGS_dcn20_resource.o := -mhard-float -msse $(cc_stack_align) AMD_DAL_DCN20 = $(addprefix $(AMDDALPATH)/dc/dcn20/,$(DCN20)) diff --git a/drivers/gpu/drm/amd/display/dc/dsc/Makefile b/drivers/gpu/drm/amd/display/dc/dsc/Makefile index c5d5b94e2604..e019cd9447e8 100644 --- a/drivers/gpu/drm/amd/display/dc/dsc/Makefile +++ b/drivers/gpu/drm/amd/display/dc/dsc/Makefile @@ -1,10 +1,18 @@ # # Makefile for the 'dsc' sub-component of DAL. -CFLAGS_rc_calc.o := -mhard-float -msse -mpreferred-stack-boundary=4 -CFLAGS_rc_calc_dpi.o := -mhard-float -msse -mpreferred-stack-boundary=4 -CFLAGS_codec_main_amd.o := -mhard-float -msse -mpreferred-stack-boundary=4 -CFLAGS_dc_dsc.o := -mhard-float -msse -mpreferred-stack-boundary=4 +ifneq ($(call cc-option, -mpreferred-stack-boundary=4),) + cc_stack_align := -mpreferred-stack-boundary=4 +else ifneq ($(call cc-option, -mstack-alignment=16),) + cc_stack_align := -mstack-alignment=16 +endif + +dsc_ccflags := -mhard-float -msse $(cc_stack_align) + +CFLAGS_rc_calc.o := $(dsc_ccflags) +CFLAGS_rc_calc_dpi.o := $(dsc_ccflags) +CFLAGS_codec_main_amd.o := $(dsc_ccflags) +CFLAGS_dc_dsc.o := $(dsc_ccflags) DSC = dc_dsc.o rc_calc.o rc_calc_dpi.o