From patchwork Thu Aug 31 20:11:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 719021 Delivered-To: patch@linaro.org Received: by 2002:adf:e5c2:0:b0:31d:da82:a3b4 with SMTP id a2csp681764wrn; Thu, 31 Aug 2023 13:12:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFk66c7gRX8eQdrPBEr13locDCyE7L1RWn0mtgv6zaamx4uu105Q0q/00B9RpefDLBtBd7 X-Received: by 2002:a05:620a:4045:b0:76c:ea00:e5d7 with SMTP id i5-20020a05620a404500b0076cea00e5d7mr532321qko.12.1693512750089; Thu, 31 Aug 2023 13:12:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693512750; cv=none; d=google.com; s=arc-20160816; b=zsL4b5ocQduj/gZHKjBsYCr9VyzNG623/d587s1VOCenBqIs4uCOyElWYmrDx42A/Z VfOYCA+G/EsEEt9MIxCDZ4w0Zy1+XJBz+0q+ezU5a8d405GqXgxfrikTcyYUbWOjkv96 AYMzvVG2NGkMEUxOwX5ya7WpyOohykZYtDtXgHRJ2FNzRWXU4LiqAEQNK7Aq9BPoHoC7 GXNgOXUZSTaWn4zr5A/NJrN9D8cGmO8BUTQ1Hei0AGyX92+djVCZIq0SVv0FhoLh+7/+ S5lMNI84FosY7vnsZpQJ3tSfsFZ9DxqjT3IhmdivOUtIL6XWJodjkZdJ8eeDXtPR1wEC 2vIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=4v4pNCupIU5kKxCqNO3QPDjJEZxzCp5Jcv4RC0vKsz8=; fh=6us25sHKqcI3nNSoSF+OqMFaSl67rVeC3rXGdDHm08A=; b=a+ULKEA2vzSQOdy9vS+LjmgudNmqtja8eOk+SJQsznW43ZRQC2d0yYiXtlvFVF27zF u9TYXiefASQp0VVjeqVJ4Q2BJvy43N/tNjNU7kKHtEgKQTQ3mrYRWDvMSEY3Hcs2Xvg/ RoKDmjwtWL3x8rRcJUt1//N5Y25EVc5HioQ1wEaGTrTtoSeqC5AGiWH6HAkhmF06JZ8r iNUkeaQKgwLCD6tPQOsUdwj6NGnPMi4CT/ZPdc29NtGxCv6mjZHyayRDlGNPLAZDCnf2 U7buxl0koU+SQ3HCSqDGSPvAGJb7qtEPUgI+UbjkpiLxEdjIF44t74ZJF44TMeahe/Zt vXQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="c/GvylCS"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id qx10-20020a05620a8b8a00b0076d991a05besi1376423qkn.99.2023.08.31.13.12.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Aug 2023 13:12:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="c/GvylCS"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbo18-00087w-Uo; Thu, 31 Aug 2023 16:11:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbo15-000841-M1 for qemu-devel@nongnu.org; Thu, 31 Aug 2023 16:11:47 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbo12-0007AS-Da for qemu-devel@nongnu.org; Thu, 31 Aug 2023 16:11:47 -0400 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-99bcc0adab4so142272966b.2 for ; Thu, 31 Aug 2023 13:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693512702; x=1694117502; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4v4pNCupIU5kKxCqNO3QPDjJEZxzCp5Jcv4RC0vKsz8=; b=c/GvylCSR6pnOhi3ncOSyNrkNq43tsqQYOrrrwJFaw1XQxzvAO4WPOtcesxkQGfjD/ okld6YRT9uBWzMt8sG/k2F8iE5ZLGASxjeUqzZjJVUfQ0rr8SN0cjlOD7FUIETt8jZ53 zCVE+3QjGlNdh5ZQMsJ+B42qtMtVXKl8szL/aAYpVZHHT6Pkq5gTLSsBt0jd49ANgyOX R/pAplQVy1n565GOAjVzlbWzr60+31GPpkWwsVlHcQRY2bo4HSiYyV2qRoGQPWSbn+tq YRJBAoyz2I8MAz41t+1c0mcphIlPqHUHhAjWl3CHUp8gcZE3g3x57yKBVKIheV489zNI GxFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693512702; x=1694117502; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4v4pNCupIU5kKxCqNO3QPDjJEZxzCp5Jcv4RC0vKsz8=; b=hTa9VWUiEThzdMvntNKjuI7R//zVe8hq2CdqJ2IwRrhELQl9T4LfWVpnyuRpt4DA4V Nxz8NzoIGckAqAone1pzAju0HY3jknjwP0kDjETdXBiUxY1JFvkKZCUpxQZqqpkW3G0A cf79B3COVtjtb7pmtIeYMD8AYF2tpj7lz8bu3SjVS4llOxLV6gHJjitugCfi6y+cvsob eqPMRWWp3qsmhZ/vl7A/BOw32b5/IxR0C2cOM894bPMkHFWKSF1sUHZC1tkWvNBD6ayR MDqpoMDUZ82qndhs3qshmgspwp5uZY4KAe4e6xUZT508/Y4hQ/FjB+8Onzqbu5TGOtKA /LAA== X-Gm-Message-State: AOJu0YxqQtobcGHt80hvatg9Fcr4FKMvvbF01hLfHmAdj0HBUaN1vcRi J21C+YCamMRi0SpxJGMMe1HqHf1VLce52LNa5Gw= X-Received: by 2002:a17:907:20f0:b0:9a5:7f99:be54 with SMTP id rh16-20020a17090720f000b009a57f99be54mr227897ejb.67.1693512702418; Thu, 31 Aug 2023 13:11:42 -0700 (PDT) Received: from m1x-phil.lan ([176.187.199.245]) by smtp.gmail.com with ESMTPSA id hb26-20020a170906b89a00b0098cf565d98asm1100558ejb.22.2023.08.31.13.11.41 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 31 Aug 2023 13:11:42 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Richard Henderson Subject: [PATCH] target/mips: Simplify Loongson MULTU.G opcode Date: Thu, 31 Aug 2023 22:11:39 +0200 Message-ID: <20230831201140.85799-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=philmd@linaro.org; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since MULTU opcodes don't record the most significant bits of the infinite result, sign-extending the sources make no difference in the result. Once we remove the sign extension of source registers, MULT and MULTU are identical (as are DMULT and DMULTU). Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 9bb40f1849..e0a76b9432 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -3625,8 +3625,6 @@ static void gen_loongson_integer(DisasContext *ctx, uint32_t opc, break; case OPC_MULTU_G_2E: case OPC_MULTU_G_2F: - tcg_gen_ext32u_tl(t0, t0); - tcg_gen_ext32u_tl(t1, t1); tcg_gen_mul_tl(cpu_gpr[rd], t0, t1); tcg_gen_ext32s_tl(cpu_gpr[rd], cpu_gpr[rd]); break;