From patchwork Wed Sep 6 09:24:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 720515 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3260CEB8FB6 for ; Wed, 6 Sep 2023 09:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236637AbjIFJZH (ORCPT ); Wed, 6 Sep 2023 05:25:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235402AbjIFJZH (ORCPT ); Wed, 6 Sep 2023 05:25:07 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FB1C1707 for ; Wed, 6 Sep 2023 02:25:02 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50091b91a83so5670267e87.3 for ; Wed, 06 Sep 2023 02:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693992300; x=1694597100; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0tTpQvf5esAbjLqRJbk/GJE3MAqg/M3E5kjL+FFGdtg=; b=bUSEFq+BcZ2qUqPIdixv9E76ji9Btbod/rLCxajolaplddyU6wnCkUNf7VG9c92vTe Qbq3LTzHIk8I8sodNR6vSQIMbBf7DPkwSycpyNeuGvy/r7Zzdv53NqyUwT5DNXFQJV62 IBR/WsX+FgeLAJikp0OcEj8Yk62k3B6JY+JvGO+BWrzxfZmFWShi5cgbzlOjUrhyZ4Dr kJoN/xaakJ4HfzJmntCRpD6t2uo4OGiJDqYV2DTpHmWCmfkSMOV3tsrHl7RBAmD8L9dW 7jeoWhNgPA58J50vJcbwOsvjjhzd0R33+oZ9CeTEO2ECwUOOPt9iZsj34NyY3KlgaIWr aVAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693992300; x=1694597100; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0tTpQvf5esAbjLqRJbk/GJE3MAqg/M3E5kjL+FFGdtg=; b=TsXrHs62cR34Ev/26WXUsdJQ53JHgazrv93kGBoOClQBgZzW/B/Qcye8vlcEePHcOV V0fFqKSvzeSCH4PDtLNg5Kv4D1MPxQIv+DGZDO/cTyLMFjdXZlsD9lD8hkUHtcyu6MHn LndPKZredDniMtwEYc3Av2nSK61q+gplX5OOA9LpgX4jB4/dOGh4qnJVo8St70pHSHWR 9uHeZMv0qy5VcZRLS27VKfGAdmulpa1vo15EGD9Sz9g451rawAg759G0IdFg7RsF8vLi HdSxd05RBx4rLHeiHVNOPi7Z5W1JweMf1My4NRnz/vFjC/jtw+USqrDZyluMhF7AOcQT Iorg== X-Gm-Message-State: AOJu0YwJalXpMx1ZmIyHut//5WvrX0JulQYv1DOgrsFz7DJXVw9umUDu 0T7Nd5Gor1zB8gd+k0tfSeX8xg== X-Google-Smtp-Source: AGHT+IHTq09S7UVjLcS9Dvpl6hPbgtJKanFRtWmiqDWBfzu1dweqOXsuDIJ1oTvabzh9hlx4UP5/rQ== X-Received: by 2002:a05:6512:4020:b0:501:c3cd:652c with SMTP id br32-20020a056512402000b00501c3cd652cmr2431698lfb.31.1693992300487; Wed, 06 Sep 2023 02:25:00 -0700 (PDT) Received: from [10.167.154.1] (178235177204.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.204]) by smtp.gmail.com with ESMTPSA id q10-20020aa7cc0a000000b005232c051605sm8096155edt.19.2023.09.06.02.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 02:25:00 -0700 (PDT) From: Konrad Dybcio Date: Wed, 06 Sep 2023 11:24:56 +0200 Subject: [PATCH 2/5] arm64: dts: qcom: qrb2210-rb1: Fix regulators MIME-Version: 1.0 Message-Id: <20230906-topic-rb1_features_sans_icc-v1-2-e92ce6fbde16@linaro.org> References: <20230906-topic-rb1_features_sans_icc-v1-0-e92ce6fbde16@linaro.org> In-Reply-To: <20230906-topic-rb1_features_sans_icc-v1-0-e92ce6fbde16@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Vladimir Zapolskiy X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1693992295; l=6762; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=DqC8ZXzqnHdza8o/7w0SCcfZdCImiHqgYjjXlkoPTAg=; b=BtIBMDq5Tev94GgSuT3C/DuX/o6Oa9eTQ/larFIK8OgJs5GGdUuHdhuUC6wbnT3H62sjd4Wrg puqy+JSHgPFC+74wGLEc0TTt4QXJ9JTQcphcKeaoCRz1kFwb+EDXMFq X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Commit b4fe47d12f1f ("arm64: dts: qcom: qrb2210-rb1: Add regulators") introduced regulator settings that were never put in place, as all of the properties ended 'microvolts' instead of 'microvolt' (which dt schema did not check for back then). Fix the microvolts-microvolt typo and adjust voltage ranges where it's necessary to fit within the volt = base + n*step formula. Reported-by: Vladimir Zapolskiy Reported-by: Dmitry Baryshkov Fixes: b4fe47d12f1f ("arm64: dts: qcom: qrb2210-rb1: Add regulators") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 86 ++++++++++++++++---------------- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts index 5cda5b761455..0f7c59187896 100644 --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts @@ -150,15 +150,15 @@ regulators { pm2250_s3: s3 { /* 0.4V-1.6625V -> 1.3V (Power tree requirements) */ - regulator-min-microvolts = <1350000>; - regulator-max-microvolts = <1350000>; + regulator-min-microvolt = <1352000>; + regulator-max-microvolt = <1352000>; regulator-boot-on; }; pm2250_s4: s4 { /* 1.2V-2.35V -> 2.05V (Power tree requirements) */ - regulator-min-microvolts = <2072000>; - regulator-max-microvolts = <2072000>; + regulator-min-microvolt = <2072000>; + regulator-max-microvolt = <2072000>; regulator-boot-on; }; @@ -166,47 +166,47 @@ pm2250_s4: s4 { pm2250_l2: l2 { /* LPDDR4X VDD2 */ - regulator-min-microvolts = <1136000>; - regulator-max-microvolts = <1136000>; + regulator-min-microvolt = <1136000>; + regulator-max-microvolt = <1136000>; regulator-always-on; regulator-boot-on; }; pm2250_l3: l3 { /* LPDDR4X VDDQ */ - regulator-min-microvolts = <616000>; - regulator-max-microvolts = <616000>; + regulator-min-microvolt = <616000>; + regulator-max-microvolt = <616000>; regulator-always-on; regulator-boot-on; }; pm2250_l4: l4 { - /* max = 3.05V -> max = just below 3V (SDHCI2) */ - regulator-min-microvolts = <1648000>; - regulator-max-microvolts = <2992000>; + /* max = 3.05V -> max = 2.7 to disable 3V signaling (SDHCI2) */ + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2700000>; regulator-allow-set-load; }; pm2250_l5: l5 { /* CSI/DSI */ - regulator-min-microvolts = <1232000>; - regulator-max-microvolts = <1232000>; + regulator-min-microvolt = <1232000>; + regulator-max-microvolt = <1232000>; regulator-allow-set-load; regulator-boot-on; }; pm2250_l6: l6 { /* DRAM PLL */ - regulator-min-microvolts = <928000>; - regulator-max-microvolts = <928000>; + regulator-min-microvolt = <928000>; + regulator-max-microvolt = <928000>; regulator-always-on; regulator-boot-on; }; pm2250_l7: l7 { /* Wi-Fi CX/MX */ - regulator-min-microvolts = <664000>; - regulator-max-microvolts = <664000>; + regulator-min-microvolt = <664000>; + regulator-max-microvolt = <664000>; }; /* @@ -216,37 +216,37 @@ pm2250_l7: l7 { pm2250_l10: l10 { /* Wi-Fi RFA */ - regulator-min-microvolts = <1300000>; - regulator-max-microvolts = <1300000>; + regulator-min-microvolt = <1304000>; + regulator-max-microvolt = <1304000>; }; pm2250_l11: l11 { /* GPS RF1 */ - regulator-min-microvolts = <1000000>; - regulator-max-microvolts = <1000000>; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; regulator-boot-on; }; pm2250_l12: l12 { /* USB PHYs */ - regulator-min-microvolts = <928000>; - regulator-max-microvolts = <928000>; + regulator-min-microvolt = <928000>; + regulator-max-microvolt = <928000>; regulator-allow-set-load; regulator-boot-on; }; pm2250_l13: l13 { /* USB/QFPROM/PLLs */ - regulator-min-microvolts = <1800000>; - regulator-max-microvolts = <1800000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; regulator-allow-set-load; regulator-boot-on; }; pm2250_l14: l14 { /* SDHCI1 VQMMC */ - regulator-min-microvolts = <1800000>; - regulator-max-microvolts = <1800000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; regulator-allow-set-load; /* Broken hardware, never turn it off! */ regulator-always-on; @@ -254,8 +254,8 @@ pm2250_l14: l14 { pm2250_l15: l15 { /* WCD/DSI/BT VDDIO */ - regulator-min-microvolts = <1800000>; - regulator-max-microvolts = <1800000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; regulator-allow-set-load; regulator-always-on; regulator-boot-on; @@ -263,47 +263,47 @@ pm2250_l15: l15 { pm2250_l16: l16 { /* GPS RF2 */ - regulator-min-microvolts = <1800000>; - regulator-max-microvolts = <1800000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; regulator-boot-on; }; pm2250_l17: l17 { - regulator-min-microvolts = <3000000>; - regulator-max-microvolts = <3000000>; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; }; pm2250_l18: l18 { /* VDD_PXn */ - regulator-min-microvolts = <1800000>; - regulator-max-microvolts = <1800000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; }; pm2250_l19: l19 { /* VDD_PXn */ - regulator-min-microvolts = <1800000>; - regulator-max-microvolts = <1800000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; }; pm2250_l20: l20 { /* SDHCI1 VMMC */ - regulator-min-microvolts = <2856000>; - regulator-max-microvolts = <2856000>; + regulator-min-microvolt = <2400000>; + regulator-max-microvolt = <3600000>; regulator-allow-set-load; }; pm2250_l21: l21 { /* SDHCI2 VMMC */ - regulator-min-microvolts = <2960000>; - regulator-max-microvolts = <3300000>; + regulator-min-microvolt = <2960000>; + regulator-max-microvolt = <3300000>; regulator-allow-set-load; regulator-boot-on; }; pm2250_l22: l22 { /* Wi-Fi */ - regulator-min-microvolts = <3312000>; - regulator-max-microvolts = <3312000>; + regulator-min-microvolt = <3312000>; + regulator-max-microvolt = <3312000>; }; }; }; From patchwork Wed Sep 6 09:24:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 720514 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71995EB8FAD for ; Wed, 6 Sep 2023 09:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236709AbjIFJZJ (ORCPT ); Wed, 6 Sep 2023 05:25:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236688AbjIFJZI (ORCPT ); Wed, 6 Sep 2023 05:25:08 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CED3C1707 for ; Wed, 6 Sep 2023 02:25:04 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-52e64bc7c10so2550871a12.1 for ; Wed, 06 Sep 2023 02:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693992303; x=1694597103; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/6p/xZXs900v4vDHCTqR/tX5qKtbr2J5Y6y2wWsKdjA=; b=ApaOGQd9FqXgZftmrsjFERD93alSlyBQfC7VrDm2OYdejxYI5HchDzEAg+mnxUypBu udcs9NfIkuJPtb7uMHvVMnld0KUApqujZ/qqYIxrDu74Bh3kLe8o/Qy0/CQSVqg9zMFd 1R5A+Z+UrZ8O6sy+XSLV4uYqaeQpuZSBJqYyS5vuY87M8EUhKD7tn7/Ldmb435/ZLxMf QVEJae2jruQvRbdk6n/YRXAI2Ok/61ArsfS2iVLR7XPkRU+Tfd43gATRsHmlsb7t75oq aTjI8zXqBhSAmnviR9thMBgf8YPFfz197MW/JhhdSW6ozzbIggArQYBv8hPnLtajowXP ALZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693992303; x=1694597103; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/6p/xZXs900v4vDHCTqR/tX5qKtbr2J5Y6y2wWsKdjA=; b=ILdRLBhUoaCF4Dc0R6qCqddFo598qpr2IPqID+OmMyramaivNuH2OrFLtymjMosIga fYTwMccwQSXZLBHLcFjyd2fp5FTS8Mt2NXlqcv27+GoU8YJfDxtUv9Q0lfWIV2cqC9CN o10ElkVV11yZQC4As34aBrVDw4a8qqhj8UxskciCcpMoKArUutVekHJ+RaE8D8eY7hBW A0oGWR5NtZUXFIxNxh03NMY0ZsS/xMaG3+1ATZF02wGw/flYE8Gc9sTczrp59m+ISIrU uUo9biThveAALqbHRj/wzkSnuaUs2q9Nev5L7Lx7PZm32/U4eDIJAgUO78YbLk84hucT l5vw== X-Gm-Message-State: AOJu0YyvpnWuJJ5LODrb4/Om6yv3fTnI5NjIYq8ZC/qzyQDd7r0Jui4x Kgg1ZPIFgZYIKhPoymWxHkj11FCH+aw/nUBPpEfshA== X-Google-Smtp-Source: AGHT+IFdAEMUz+88edXZb43tzldXC9wcDLVBbqV0a4yyVzNmNROPo4VCN1khS5KFMQ3UGo0caLGccw== X-Received: by 2002:a05:6402:5172:b0:523:2e30:aaee with SMTP id d18-20020a056402517200b005232e30aaeemr1773809ede.32.1693992303456; Wed, 06 Sep 2023 02:25:03 -0700 (PDT) Received: from [10.167.154.1] (178235177204.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.204]) by smtp.gmail.com with ESMTPSA id q10-20020aa7cc0a000000b005232c051605sm8096155edt.19.2023.09.06.02.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 02:25:03 -0700 (PDT) From: Konrad Dybcio Date: Wed, 06 Sep 2023 11:24:58 +0200 Subject: [PATCH 4/5] arm64: dts: qcom: qrb2210-rb1: Add GPIO LEDs MIME-Version: 1.0 Message-Id: <20230906-topic-rb1_features_sans_icc-v1-4-e92ce6fbde16@linaro.org> References: <20230906-topic-rb1_features_sans_icc-v1-0-e92ce6fbde16@linaro.org> In-Reply-To: <20230906-topic-rb1_features_sans_icc-v1-0-e92ce6fbde16@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1693992295; l=1581; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=UuNd8tggE5iWiyJA3F8yW6H2YAWEjVItZbSqtIqrHRA=; b=vlWYHvPSLfOkpmRgpAeQijRsCZdcBV9xDwMZbr3XygAYB4tIIDlFLKMfebwqwlESs2L4oJgD8 7D5yBqy0iY7CyizPLcKGRnj/YaKJeYHUUMtF8ZnPsqnuyR1Z94G53vc X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add the three LEDs (blue/yellow/green) connected to TLMM GPIOs. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 33 ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts index 5f7619518deb..fd45f58e254d 100644 --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts @@ -5,6 +5,7 @@ /dts-v1/; +#include #include "qcm2290.dtsi" #include "pm2250.dtsi" @@ -39,6 +40,38 @@ key-volume-up { }; }; + leds { + compatible = "gpio-leds"; + + led-bt { + label = "blue:bt"; + function = LED_FUNCTION_BLUETOOTH; + color = ; + gpios = <&tlmm 45 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "bluetooth-power"; + default-state = "off"; + }; + + led-user0 { + label = "green:user0"; + function = LED_FUNCTION_INDICATOR; + color = ; + gpios = <&tlmm 52 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "none"; + default-state = "off"; + panic-indicator; + }; + + led-wlan { + label = "yellow:wlan"; + function = LED_FUNCTION_WLAN; + color = ; + gpios = <&tlmm 47 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "phy0tx"; + default-state = "off"; + }; + }; + vreg_hdmi_out_1p2: regulator-hdmi-out-1p2 { compatible = "regulator-fixed"; regulator-name = "VREG_HDMI_OUT_1P2";