From patchwork Fri Jul 26 11:28:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 169826 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp12910016ilk; Fri, 26 Jul 2019 04:28:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqyphymfco2H8LoFZG8dTfjzfG6zMupu/M05d/ihr+iGsukScSOIvUdIKduSpv5yBsv2U2Do X-Received: by 2002:a63:fc52:: with SMTP id r18mr90688952pgk.378.1564140526429; Fri, 26 Jul 2019 04:28:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140526; cv=none; d=google.com; s=arc-20160816; b=rpH1C1iSjY2PooOnYjasXzpkIajLe0z+bFX+uGOHbLhYoOBG+nKb0x6VYLCqLInIAC HphazwfXheOzJzOASfq00kBugcHiWacSlp8HJXTbB1K1qlx/QuP+LOdWR/MG7yfMwDc4 C2HQqFj6vUldx8U/YWC/p1tuMfn/lWNm3qoh7n2VmVLvnZqr7HDLF1JG/np06fV0zmQJ kFQO4LsfnxIi1fbkAue2V6hopgzs7/ov/Q6VKajmG95K8LQ4RPS2WQAJW8P+gH0wKCCi vlKtPtM83MulWIuWkjfeQfXzEz0iq3M+Giuj0Kg/DPngqmn38RmyFca8G5akBvoOoBAX akZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3k2Hu9dgPAg4mXrYLegY3cs+pkVK6DYl+EmmNBVrs0g=; b=z5170/sdPTGCB2Fx8t3Dnzk3EV94lxFgVOxwNMjbltQ3cKcawbP48dQwyunLslSPmt SetQ3/seKjrix3R/WNggOtlvpXbXR7GLL7JGF19YkLrHQ8HYiyZrdCrXP5HxSOSelqAF 0unMU72YCepHw9gOkpWRqDLHHAGB1zHTVSyjkYVmB3x3paZWgm8ny01gM5fzh1riEhC8 1oi9/d6TfLwXO90u2NtUOWlZ/JlTTWEjZRbh8wxbNdT+LK+tJ4gblbQvChIv6n6lyGGd vwXm5YETgiO/sODUORN4N/3Pyu4ucGwXXmN1vO0jMhQXR4YoQKjBgtJHHViJBm/FdMHt fI3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t8y9cuVI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t6si17608441pjv.14.2019.07.26.04.28.45; Fri, 26 Jul 2019 04:28:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t8y9cuVI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727163AbfGZL2o (ORCPT + 29 others); Fri, 26 Jul 2019 07:28:44 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:45219 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbfGZL2n (ORCPT ); Fri, 26 Jul 2019 07:28:43 -0400 Received: by mail-lj1-f195.google.com with SMTP id m23so51068760lje.12 for ; Fri, 26 Jul 2019 04:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3k2Hu9dgPAg4mXrYLegY3cs+pkVK6DYl+EmmNBVrs0g=; b=t8y9cuVI9+Yw19d8Lc6hWctxqxTCLkf+u1eC14W4J2NPPlqR5niIOpj/3Z6d0OtM/Y rTbYPQ30898Z1Dawsea0lsSoS6sks+mGr6HRiwT8DeDLpqq0wygMq3vzAhZkRDBZqFjq O9senNIWyuA3TPlYmPwaIcePkNEFE/HGREu5sjatKCeOvylXVwqKi8UUwcs9GUJLLq1A Fptqlzm0mzopq4E/Zvr2lhTDMd/AGFjNBofA/0xovrBZvfGsH7NK7MICsPtiDdXKjs1E 94HbESg/f9jtKEfzdKW3WRLDb/O2lypJ6taEfpAfmSVV0Zyvo3KJ1rnuwIqFitDzz/n0 gCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3k2Hu9dgPAg4mXrYLegY3cs+pkVK6DYl+EmmNBVrs0g=; b=RAPflS0XlD9vq/O4Qgi6HclDdYNsqhsdimPQDaUkf4Qe8dvnQydw4pJt72+Ol3cO1C SpkdtF7JBndEO4b+tGPUx3VQSnDKhV6Thms8lIyYWzFvvoAb7TpOuRqe0JAcpclWWAH9 c4vyAN6x0EDF7wmhQc+D3/Ga47wIHlgQYwGoe9FJ72Ss9Q/pZ+Rqiio6A5TFps5e/1jq aTVyK3EECUkzqZ7yokMLqVhRxNl+a8oaMfSCD2rOOQhj0bTI5+gxgHe1aodhMAhKCHwZ fEabbq1B+CJNFBvZ7Bz6Nyfy7ZW03WxVze1znn2zKVT83I58gvWkznK4pIykHaRan+Nw DLqw== X-Gm-Message-State: APjAAAX12VWtnhW08qzdTjzSOJh0UAB5BWSljavJysuiY7sQ1mAmu5Fs GjbDAPgYCdW6IJSQFt3Nkn2+tA== X-Received: by 2002:a2e:3008:: with SMTP id w8mr50119116ljw.13.1564140521750; Fri, 26 Jul 2019 04:28:41 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id m28sm9918367ljb.68.2019.07.26.04.28.41 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:28:41 -0700 (PDT) From: Anders Roxell To: b.zolnierkie@samsung.com Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH] video: fbdev: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:28:35 +0200 Message-Id: <20190726112835.19928-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When fall-through warnings was enabled by default the following warnings was starting to show up: ../drivers/video/fbdev/sh_mobile_lcdcfb.c: In function ‘sh_mobile_lcdc_channel_fb_init’: ../drivers/video/fbdev/sh_mobile_lcdcfb.c:2086:22: warning: this statement may fall through [-Wimplicit-fallthrough=] info->fix.ypanstep = 2; ~~~~~~~~~~~~~~~~~~~^~~ ../drivers/video/fbdev/sh_mobile_lcdcfb.c:2087:2: note: here case V4L2_PIX_FMT_NV16: ^~~~ ../drivers/video/fbdev/sh_mobile_lcdcfb.c: In function ‘sh_mobile_lcdc_overlay_fb_init’: ../drivers/video/fbdev/sh_mobile_lcdcfb.c:1596:22: warning: this statement may fall through [-Wimplicit-fallthrough=] info->fix.ypanstep = 2; ~~~~~~~~~~~~~~~~~~~^~~ ../drivers/video/fbdev/sh_mobile_lcdcfb.c:1597:2: note: here case V4L2_PIX_FMT_NV16: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1 diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index ac0bcac9a865..c249763dbf0b 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -1594,6 +1594,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) case V4L2_PIX_FMT_NV12: case V4L2_PIX_FMT_NV21: info->fix.ypanstep = 2; + /* Fall through */ case V4L2_PIX_FMT_NV16: case V4L2_PIX_FMT_NV61: info->fix.xpanstep = 2; @@ -2084,6 +2085,7 @@ sh_mobile_lcdc_channel_fb_init(struct sh_mobile_lcdc_chan *ch, case V4L2_PIX_FMT_NV12: case V4L2_PIX_FMT_NV21: info->fix.ypanstep = 2; + /* Fall through */ case V4L2_PIX_FMT_NV16: case V4L2_PIX_FMT_NV61: info->fix.xpanstep = 2;