From patchwork Sat Sep 30 09:02:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 728365 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45FB6138C for ; Sat, 30 Sep 2023 09:03:19 +0000 (UTC) Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 386971A4; Sat, 30 Sep 2023 02:03:17 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2bffdf50212so233293441fa.1; Sat, 30 Sep 2023 02:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696064595; x=1696669395; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SYSzdY55+CxrxbH3Om6zQQD6TqvfL34vFHdKYeG2ZYA=; b=L9e+6JSJ3Qy6n4kefbNhpoauNqCMWaXKvtUlOA8M4IUCONTj4IabNIMCHvqGdG466K Y8S2kxkw4nFW9kdmGUfgwok0PpJ5FnTrxBDJuVHRLyRW3vg+O9yUS+FxccaJUKC+Lj2y HqtWksUSROhlkjnT3ovfFF+OsD1AGqtG+IdQdgU/cvG6dJYsU1hafskVTd+LhtZWm9VT D4RkSdL8rCJF7VDkPgKZHeWrcbVcp7FXz+edwOOK4G66qzsPe3KPf+nUxf9dTuTHUB4h eD51IoQI+YJOAvFBfSunyx+Reak28BNrB7jX4yqFgOruKEZnlOUgtDRrOauxUaj7aVYx Clow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696064595; x=1696669395; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SYSzdY55+CxrxbH3Om6zQQD6TqvfL34vFHdKYeG2ZYA=; b=YGywBykB7URCC/zE+uqKTKQZRUVhg5ds9m0o9w5nUYMVaMnMedZdTSjyxzpopZkOAz 9TWyrq88UTTPCFazs38gkYZThCFkHwcV7a6qP7RpAwVkcCB0ZQPPfRLGKNqGoMrCZz3p 0/9oUbCzvUuEmImPIDTEFAY5OA8ID1isQUNmOP6MzG+00Bzp1NRq1mS381bkLtriIV4c 2+J9Oyws5WDkcA7D7xU04rWP44VPkcK4Cj6mz5i3DNoRj4rPsxXknunWtBRCmxH8XBFL bO0DnmLiYSww9Xkjcdf6YDZ7BbVLWMLeHzeA4B6AOMxGaMc3PS+lx9xu2Qh/hOxAhq7k Dp8A== X-Gm-Message-State: AOJu0Ywq5BhqF474ogZISuVvALqxuX6tGAV8FORB9mRBdDaLj4ZqRcPj Rao+d+W42x/BRd2syTZvIo2G7eVQ3SABR8ze X-Google-Smtp-Source: AGHT+IHSdH0luyWoKJ4bUEHxt9DqzqMz/aYF1XYSTUy4+HNiFlIp0VCpJLte5ID5dl3YfSnwnrynVQ== X-Received: by 2002:a2e:9cc2:0:b0:2bf:fae2:f97 with SMTP id g2-20020a2e9cc2000000b002bffae20f97mr6101486ljj.12.1696064595135; Sat, 30 Sep 2023 02:03:15 -0700 (PDT) Received: from HP-ENVY-Notebook.lan (81-229-94-10-no68.tbcn.telia.com. [81.229.94.10]) by smtp.googlemail.com with ESMTPSA id z9-20020a2e3509000000b002bcbae4c21fsm4319794ljz.50.2023.09.30.02.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 02:03:14 -0700 (PDT) From: Jonathan Bergh To: rafael@kernel.org, lenb@kernel.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 1/3] drivers: acpi: Fix pointer declarations in parameter lists which included whitespace spuriously Date: Sat, 30 Sep 2023 11:02:48 +0200 Message-Id: <20230930090248.34759-1-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Fixed issues where pointer declarations in parameter lists included whitespace before the parameter names and should not. Signed-off-by: Jonathan Bergh --- drivers/acpi/osl.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index f725813d0cce..29e0005c30aa 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -493,7 +493,7 @@ EXPORT_SYMBOL(acpi_os_unmap_generic_address); #ifdef ACPI_FUTURE_USAGE acpi_status -acpi_os_get_physical_address(void *virt, acpi_physical_address * phys) +acpi_os_get_physical_address(void *virt, acpi_physical_address *phys) { if (!phys || !virt) return AE_BAD_PARAMETER; @@ -784,7 +784,7 @@ acpi_os_write_memory(acpi_physical_address phys_addr, u64 value, u32 width) #ifdef CONFIG_PCI acpi_status -acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, +acpi_os_read_pci_configuration(struct acpi_pci_id *pci_id, u32 reg, u64 *value, u32 width) { int result, size; @@ -816,7 +816,7 @@ acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, } acpi_status -acpi_os_write_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, +acpi_os_write_pci_configuration(struct acpi_pci_id *pci_id, u32 reg, u64 value, u32 width) { int result, size; @@ -1197,7 +1197,7 @@ bool acpi_queue_hotplug_work(struct work_struct *work) } acpi_status -acpi_os_create_semaphore(u32 max_units, u32 initial_units, acpi_handle * handle) +acpi_os_create_semaphore(u32 max_units, u32 initial_units, acpi_handle *handle) { struct semaphore *sem = NULL; @@ -1554,7 +1554,7 @@ void acpi_os_release_lock(acpi_spinlock lockp, acpi_cpu_flags flags) ******************************************************************************/ acpi_status -acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache) +acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t **cache) { *cache = kmem_cache_create(name, size, 0, 0, NULL); if (*cache == NULL) @@ -1575,7 +1575,7 @@ acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache) * ******************************************************************************/ -acpi_status acpi_os_purge_cache(acpi_cache_t * cache) +acpi_status acpi_os_purge_cache(acpi_cache_t *cache) { kmem_cache_shrink(cache); return (AE_OK); @@ -1594,7 +1594,7 @@ acpi_status acpi_os_purge_cache(acpi_cache_t * cache) * ******************************************************************************/ -acpi_status acpi_os_delete_cache(acpi_cache_t * cache) +acpi_status acpi_os_delete_cache(acpi_cache_t *cache) { kmem_cache_destroy(cache); return (AE_OK); @@ -1614,7 +1614,7 @@ acpi_status acpi_os_delete_cache(acpi_cache_t * cache) * ******************************************************************************/ -acpi_status acpi_os_release_object(acpi_cache_t * cache, void *object) +acpi_status acpi_os_release_object(acpi_cache_t *cache, void *object) { kmem_cache_free(cache, object); return (AE_OK); From patchwork Sat Sep 30 09:04:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 728208 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 467D917ED for ; Sat, 30 Sep 2023 09:04:34 +0000 (UTC) Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C86201AE; Sat, 30 Sep 2023 02:04:31 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2bff776fe0bso238624431fa.0; Sat, 30 Sep 2023 02:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696064670; x=1696669470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Bjvj3wwShKStYd4Opu01OitMSwv/jQBV1HVJIIxyVUM=; b=beH8rtf7kTT7aIYMGwheQWuq7U+n/9UmvTUTYZFjLYo58+SyiJxXjWyqpudOgyB9sK SXal8G0mCP7XZfawav/77ZJbaU7lEAUMiCHFDS2MMsRLqfuUD+MLNEXOpkuRQ4MCYR40 yRyLB8Okm+UczNgTajRjHTpAnKAFiGy7FhuIoI2uaswCnQ1QnCSscttPYQDHzamKi641 K6HNsMv+ovZCDYrG69HOkNT6/Vfdppp4yFzaaAtf9IgrgfM+q+vpctQiVdYveW5qCBKp AAdhADqalXF6SjnLq2qw+f1FemPQAGux6Kb9E5L3kqaJASmKu1kVJF8bkpgngcN5c7cJ R2ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696064670; x=1696669470; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bjvj3wwShKStYd4Opu01OitMSwv/jQBV1HVJIIxyVUM=; b=Rf303UWMUIgr5GSst+Pzj20d3/FqWl8u0FVP4EyEuK/geE/BIMMulsK6mgvAHcre9M YXZYaMwCZrXjFk792nhEwdIVJbYwPRse6lYnlCLlu2mApwCVXq23FBa5OOrhr8/Fh/t3 YuTsxupJ+T6kq0cVmj/K7RG7q5MCOUA9TePKf73NAud+1vu1t7JolIT2K4pShDpk702l 4PDUL8iVL+z/QJTtHB7oGeCnem/It3KRCsRNy2YxY4c88XpWMNxE3F0L2aeAiFO0XACe kBn2/k4m9qVKauDtbkYG8wM4AmXCqVtBeXjGPuecDeVtyfnJ3fEmjVlNejXbz+6m0ABz Icaw== X-Gm-Message-State: AOJu0YwWTpNsnNPZjExMgzbWV2LdncGkEv5c3ImQoK1VFrH8fE4ZIgdG bchofXLM8L+DaDWNZ24msknrpoqwk1LOmbes X-Google-Smtp-Source: AGHT+IGLB/o73aeMnlP+QKIKo5OqXRMyYGy1lwRE+yEN/rDnqkzDuoH0Mk89vCSo4ScJfUw7KLY9Pw== X-Received: by 2002:a2e:9856:0:b0:2bd:140c:6d0f with SMTP id e22-20020a2e9856000000b002bd140c6d0fmr5755544ljj.47.1696064669720; Sat, 30 Sep 2023 02:04:29 -0700 (PDT) Received: from HP-ENVY-Notebook.lan (81-229-94-10-no68.tbcn.telia.com. [81.229.94.10]) by smtp.googlemail.com with ESMTPSA id f4-20020a2e6a04000000b002b95eb96ab7sm4350164ljc.18.2023.09.30.02.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 02:04:29 -0700 (PDT) From: Jonathan Bergh To: rafael@kernel.org, lenb@kernel.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 2/3] drivers: acpi: Remove parentheses where return value is not a function Date: Sat, 30 Sep 2023 11:04:21 +0200 Message-Id: <20230930090421.35831-1-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Fixed formatting issue where return value from a function is not a function but was wrapped in parentheses, causing checkpatch to flag an error. Signed-off-by: Jonathan Bergh --- drivers/acpi/osl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index 29e0005c30aa..dbbccb612277 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -1578,7 +1578,7 @@ acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t **cache) acpi_status acpi_os_purge_cache(acpi_cache_t *cache) { kmem_cache_shrink(cache); - return (AE_OK); + return AE_OK; } /******************************************************************************* @@ -1597,7 +1597,7 @@ acpi_status acpi_os_purge_cache(acpi_cache_t *cache) acpi_status acpi_os_delete_cache(acpi_cache_t *cache) { kmem_cache_destroy(cache); - return (AE_OK); + return AE_OK; } /******************************************************************************* @@ -1617,7 +1617,7 @@ acpi_status acpi_os_delete_cache(acpi_cache_t *cache) acpi_status acpi_os_release_object(acpi_cache_t *cache, void *object) { kmem_cache_free(cache, object); - return (AE_OK); + return AE_OK; } #endif From patchwork Sat Sep 30 09:04:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 728364 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A8F7138C for ; Sat, 30 Sep 2023 09:04:58 +0000 (UTC) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B08BE1A7; Sat, 30 Sep 2023 02:04:57 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50325ce89e9so24006819e87.0; Sat, 30 Sep 2023 02:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696064696; x=1696669496; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xeGbiFzFYK1tREaSWy6nrxTkbPQlphBhH17z/+R52n4=; b=R7POgiQfijlPptE0XKY9gH+g79bLPnXq9ECgwY8b/Hm8bmfSA6Can6fe9l1soSPPff RGEGsZ8Ck6Lzb89YwQsyu4Ze8tRqe7Wl3DzA24lVrPDIdn8CugR2Sy/W/udL1jWZnypa hgQuIL67FRDnSzNziGHTMz1oysebVWyoTB3Js39CasQs01j9XxhDnQ94BOF1yH3qZyv/ wVCLEbXjoOE8r76FVueWHLtXN4YKJUWNXJV6Fm6YrU19W8tD0XMSAGqRDWXKbWItHs5P +3hitpkL1R6VRJlui5505xKV2Y5YiAss7UDKyaZIQ3ZY9XrdMrX84+XXVZltXnCBhnE+ U6Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696064696; x=1696669496; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xeGbiFzFYK1tREaSWy6nrxTkbPQlphBhH17z/+R52n4=; b=CCIRpMf330V2vjpy6CtOtnIbsMIjg5w2fV3vTTAXUu4NkHwBRLqdM079SGXK9JYkJs ARAFkel4wCbzoX6ugTcS22mu4nYawBG80KdCKh3NSBa7Sbbzc3hkAT+9Rf8ogTBWggs8 rlJh0d/yBdysMKwQemhtHaPDwpc0wVvLuieN7N6jlyQbbYQrR1u84SAf1ueXhQ+pSEgw hdoIdt3BHdwZXmWX/XIpuXJpdwncZbmYk5qJImA3nWi0POK2JcyH1LNIa0uAKkX05RJu abzpQ8Dg8Q0DNp3sbbzPKN7nghtDnPj5EeWLylqGRraQHEaz8SI6hLX6UIxhGPOIl2Rc KQyQ== X-Gm-Message-State: AOJu0Yy+Hyf9HZSjxZCzBZhInhahweaPzePrJ2OIU/NOSd4O5gT9Y2vi vGPwKlu+jsYIf9LV80uRdzk= X-Google-Smtp-Source: AGHT+IGn+nHzoTYiaz/RWNzHb7S15bcM3hpPDOmyfCnU/j2V8HjHf6SKdEBgmZ8fINa26a9TRYjd4w== X-Received: by 2002:a05:6512:370a:b0:503:985:92c5 with SMTP id z10-20020a056512370a00b00503098592c5mr4791360lfr.42.1696064695892; Sat, 30 Sep 2023 02:04:55 -0700 (PDT) Received: from HP-ENVY-Notebook.lan (81-229-94-10-no68.tbcn.telia.com. [81.229.94.10]) by smtp.googlemail.com with ESMTPSA id u26-20020ac248ba000000b004fbb011c9bcsm3818321lfg.161.2023.09.30.02.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 02:04:55 -0700 (PDT) From: Jonathan Bergh To: rafael@kernel.org, lenb@kernel.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 3/3] drivers: acpi: Fix missing newline after declarations Date: Sat, 30 Sep 2023 11:04:36 +0200 Message-Id: <20230930090436.35851-1-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Fixed various instances where missing newlines after variable declarations were causing checkpatch warnings. Signed-off-by: Jonathan Bergh --- drivers/acpi/osl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index dbbccb612277..18a25429274c 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -1067,6 +1067,7 @@ acpi_status acpi_os_execute(acpi_execute_type type, struct acpi_os_dpc *dpc; struct workqueue_struct *queue; int ret; + ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "Scheduling function [%p(%p)] for deferred execution.\n", function, context)); @@ -1522,6 +1523,7 @@ acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp) __acquires(lockp) { acpi_cpu_flags flags; + spin_lock_irqsave(lockp, flags); return flags; } @@ -1708,6 +1710,7 @@ acpi_status acpi_os_prepare_sleep(u8 sleep_state, u32 pm1a_control, u32 pm1b_control) { int rc = 0; + if (__acpi_os_prepare_sleep) rc = __acpi_os_prepare_sleep(sleep_state, pm1a_control, pm1b_control); @@ -1730,6 +1733,7 @@ acpi_status acpi_os_prepare_extended_sleep(u8 sleep_state, u32 val_a, u32 val_b) { int rc = 0; + if (__acpi_os_prepare_extended_sleep) rc = __acpi_os_prepare_extended_sleep(sleep_state, val_a, val_b);