From patchwork Thu Aug 1 15:09:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 170387 Delivered-To: patch@linaro.org Received: by 2002:a92:512:0:0:0:0:0 with SMTP id q18csp5574068ile; Thu, 1 Aug 2019 08:09:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrAwE9SEX8Szw3+mzh3/fIZrYJe1vDLew6bltnQY33VY3T0DKMbvdYgQscZiFFgJGZTwWg X-Received: by 2002:aa7:81d9:: with SMTP id c25mr54978015pfn.255.1564672194503; Thu, 01 Aug 2019 08:09:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564672194; cv=none; d=google.com; s=arc-20160816; b=HE9t6jO3Pb3skJCFnjj9juSnV4RYt1RMJE5Pl5IzcxU0lyzE5uWy7peVzojoTtEMDE kgME7zjofZzPxZY2kreAIFvm8XL+UZElMR36GHN+jGeEYIWA/A+PCDYrRqobD65/RdGn M7Gxv+sTiPLWLBL98pp9rOrVDjRgf6wnpRNnGemUjtMUxKUEFHe49rvExmM1uUTiagtE H89ptZpPX+e8LSWcOBM8mxefvk3RI+7XXeHI/M6V1bVbjUDgWZoX2CoJMiV6YIzJZz4w 2Oe6Zxf/bhGhA9txd2Usd+F3J0yM3OOHXlauFjUQBIGuReuqFs3UE+MKG8umacFm5En2 b5zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to; bh=kRIJsi5jfsn4Q8W2D6dnJEGUVNi190CBwpKVbi92Obk=; b=ThaDR/ABlBI3VNR7/GlAjOmBYVdPKi8CS4F1UMJKuA8foDXXudDn8ttFQlZRFEW/aB YN3ZzbSMFp5W8w37piMIPtdHX/em2my2ie2GkVaep84sg8Hx+uxuIWKKYhophJaMARZ4 /b6I6wk7uEMQoqv91Ous2QsFh1V0YMu6xdUdd2y4ANkr66Gg8O3cTc0fuCj+Xx0tlLvK b20ZsnYIIDv4gttLtqQp+MbcXIGmOjtW8r9tzdjqMoaIQ6C/lM0t3ib8wsl4ot7n09eR 7njrogCdwnDyaa22Z1E850/PnZ2j4AKU6BFE7mL7uyvo1EchKC7jkBKewiv7In1EoO3z /2Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=aSMrjbmQ; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id q7si4232458pjv.36.2019.08.01.08.09.53; Thu, 01 Aug 2019 08:09:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=aSMrjbmQ; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ec2-34-214-78-129.us-west-2.compute.amazonaws.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 347C87F43B; Thu, 1 Aug 2019 15:09:49 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mail.openembedded.org (Postfix) with ESMTP id D8B107F43B for ; Thu, 1 Aug 2019 15:09:47 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id x15so65036988wmj.3 for ; Thu, 01 Aug 2019 08:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=AkkjdJtwU4LWpq+VpC2djLD2AtP159FqBOITD6wpAaA=; b=aSMrjbmQqefkvXkOSM84crefLLJLVLsHoQtHHVQF2AsP9rJCsraylxraoqM58xkn+V 2L9ntGXvWqoEUUtCFCc5f1u8JMCiZLpluf3QD0l1fKPKf2/vRVOmX6a1bLTjv84xKZjY E+IBupaXnBjTZcZbRHFhlK7HTX7TIeCx4EQcFnuDf+Q3GUJ0dv4+OaVlTy5kGKu1Dpq1 IZESRUMS38072v7AwSNIVMb9pmqVqu0DhMm3U4nQUOL9JU+Tu3FOHlQYcEHBpR8bMuPC QfkPXDuK2LPHAA6XtzWWF6EFn1VaOMPLMTKouHDzL4v+lxE9FRGmf0PZDqItjGZw8ipG bh7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=AkkjdJtwU4LWpq+VpC2djLD2AtP159FqBOITD6wpAaA=; b=K+dHjVFiKQwCRkKLG7yMuJDydjfY1vGU0DQQRuy/vN4ULWSgoW+66rjohFD8/y5NKR CEqZGjC+Unta72JR9Eyumt+GjQ826/iGa3xEWD0ThP52Ik/MZ8nIbPU+/AlHhS+AKPap 17oO2raagjO9CrZXkZfvTgscARGc20EoQq9kt3ylA9HYa5tZ9PTAEiUVgwe7umm4XfyR 4RrjqnGb7OQfekW8nAVVjku2DGf05l1Rv3s8lZEmNRe2bfDCzxbSzEnGwioujmiOqeCx u4jHNLp5sxwerRSL8JRPy6/r+kNYG0ZU8BmLHA5enDKmzeQ7lwx9U2lw3W5pjLOiL3/E hIrQ== X-Gm-Message-State: APjAAAXDZJ75e40at8O46CTWaAx7z+0TxOxQgsWfx1mpRG3uQM19qh1g 3D+4CoobnvjC2rSBRNgyX2asB0TtysU= X-Received: by 2002:a1c:4184:: with SMTP id o126mr114047571wma.68.1564672188120; Thu, 01 Aug 2019 08:09:48 -0700 (PDT) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id v16sm59382652wrn.28.2019.08.01.08.09.46 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 01 Aug 2019 08:09:46 -0700 (PDT) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Thu, 1 Aug 2019 16:09:44 +0100 Message-Id: <20190801150944.26219-1-ross.burton@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [OE-core] [PATCH] insane: check if the recipe incorrectly uses DEPENDS_${PN} X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org Some people mistakenly use DEPENDS_${PN} and wonder why the dependencies don't work. Check for this and tell the user to use DEPENDS. Signed-off-by: Ross Burton --- meta/classes/insane.bbclass | 5 +++++ 1 file changed, 5 insertions(+) -- 2.20.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 891d3a84218..35c4fdb4913 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -1237,6 +1237,11 @@ python () { if prog.search(pn): package_qa_handle_error("uppercase-pn", 'PN: %s is upper case, this can result in unexpected behavior.' % pn, d) + # Some people mistakenly use DEPENDS_${PN} instead of DEPENDS and wonder + # why it doesn't work. + if (d.getVar(d.expand('DEPENDS_${PN}'))): + package_qa_handle_error("pkgvarcheck", "recipe uses DEPENDS_${PN}, should use DEPENDS", d) + issues = [] if (d.getVar('PACKAGES') or "").split(): for dep in (d.getVar('QADEPENDS') or "").split():