From patchwork Thu Oct 12 19:13:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 733728 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEDBCC41513 for ; Thu, 12 Oct 2023 19:17:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D330BDF9; Thu, 12 Oct 2023 21:16:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D330BDF9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697138258; bh=xwTmDUgKWFTMwtx+0fK5FEMjG1SbAl8vZqnnMOVgTzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FJt/Dm38CecbMeW806OKQ8iEOFy6JKg4M0U6Rgmih9J1tIJp0Iq56DtYOeKxcx9Jp ERYmrwdQddJ/CUiFiqxtkFkUw0pUhmoC56OYF/uPszJQ0NoDQvREnCQ/WzVuBfcN+p 6QOJSWB6pC8RYrkQ3+uj9/1fY3BraoEq5+F1asK8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8F3A2F805B6; Thu, 12 Oct 2023 21:13:49 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E31EAF805CB; Thu, 12 Oct 2023 21:13:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B4C97F8027B; Thu, 12 Oct 2023 21:13:42 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8F789F8019B for ; Thu, 12 Oct 2023 21:13:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8F789F8019B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Hs1moqAN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697138012; x=1728674012; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xwTmDUgKWFTMwtx+0fK5FEMjG1SbAl8vZqnnMOVgTzI=; b=Hs1moqAN+OQPo7OxKCRWV46scITc4XGO5d+suZ+gw/iz+Ha3nmSAx0Am UBviF435cNJfum/Q+H3vIal7lMuptE+sHgQZ5ektPjZmdqyFLxlI/2BpR G+xaW+FG2WlVnOsQ9lBVEuAJ+8H2aHDdZlPXjJHdBUKXSQfmxgrnIbtbD mrVnlhLr/5AQbFO0iW9rHtEZvGz+Egh2w3Nmm381zOo0th6yZtV9XkzAI pfKPkOq6E2TDMlXBwSK2FkZDjh1P7idh2ZDF053yViSxDTogDhCEZ4zal W0gwryqznpbxPBnSEXV5BfKaZabHfOQ2Ru/OhistsMbhHdOCLCFao7+Hp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="382249211" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="382249211" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 12:13:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="704295159" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="704295159" Received: from gchoudha-mobl.amr.corp.intel.com (HELO pbossart-mobl3.hsd1.md.comcast.net) ([10.212.114.241]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 12:13:25 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, Bard Liao , Rander Wang , Pierre-Louis Bossart Subject: [PATCH 1/2] ASoC: rt715-sdca: reorder the argument in error log Date: Thu, 12 Oct 2023 15:13:14 -0400 Message-Id: <20231012191315.145411-2-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231012191315.145411-1-pierre-louis.bossart@linux.intel.com> References: <20231012191315.145411-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: JRNLTLEZFORMDJ7GNBWOEUWHKOCBGNDP X-Message-ID-Hash: JRNLTLEZFORMDJ7GNBWOEUWHKOCBGNDP X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Bard Liao "Failed to set private value: ffffffea <= 6100000 24832" is confusing. It should be "Failed to set private value: 6100000 <= 24832 -22" Reviewed-by: Rander Wang Signed-off-by: Bard Liao Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/rt715-sdca.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt715-sdca.c b/sound/soc/codecs/rt715-sdca.c index 9fa96fd83d4a..4533eedd7e18 100644 --- a/sound/soc/codecs/rt715-sdca.c +++ b/sound/soc/codecs/rt715-sdca.c @@ -41,8 +41,8 @@ static int rt715_sdca_index_write(struct rt715_sdca_priv *rt715, ret = regmap_write(regmap, addr, value); if (ret < 0) dev_err(&rt715->slave->dev, - "Failed to set private value: %08x <= %04x %d\n", ret, addr, - value); + "Failed to set private value: %08x <= %04x %d\n", + addr, value, ret); return ret; } From patchwork Thu Oct 12 19:13:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 732482 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78F2BCDB46E for ; Thu, 12 Oct 2023 19:17:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5BEA684B; Thu, 12 Oct 2023 21:16:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5BEA684B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697138234; bh=/t9Tz9FfN1QhWixMWFpN+8BOu45ZEKgkLXi/fx1aH4s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Lrm+FaGxzMKdKvhfCZ36Tu2NDZi9jcpsLnigGAuKQ/hmAhefyWZKXvRtp7xQ+eM1z 4DsUo+/zGxInPbxlcAJ6r1LHojdJJd3Q3vTwal2EapvVFxR74LsK6z5eBckAYzi+EO uiWNkms3ggI5M1UlrobEaM3cSA6QiaJloIAEl57I= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 18888F80589; Thu, 12 Oct 2023 21:13:45 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id AB3A6F8027B; Thu, 12 Oct 2023 21:13:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 551CFF8055A; Thu, 12 Oct 2023 21:13:42 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 38BAFF8015B for ; Thu, 12 Oct 2023 21:13:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 38BAFF8015B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=JQ8+aM9d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697138012; x=1728674012; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/t9Tz9FfN1QhWixMWFpN+8BOu45ZEKgkLXi/fx1aH4s=; b=JQ8+aM9dfIrVen7ZVuINXG1k4I0YLeTAd66V1Jl2smfSf1hy52A0zT4r TB32Vl8hAxA3qVUYWq1TmQNrMREixutT4ZpdfMLCv4M93IomIjhj1R3O5 MOflo0Y4+mM190Ozvus4r0ZS8J6E/trIv8VPcES3ve++R2Hg2dtFsIlvR +OiDHQ3IltIvaZOvwzTyrJf1E7g1wrJ9oTyw1dGf0B3kW9CJY+xOLbQ4d vEAFoQtTJ8of6WkmXslQ3PkURZhIi9ln0R6Xn84dGCX455B4H8L6zq6lX qVnmeV6ToBp7fsnY4QUqqAvqPEg+27g3wea3T/BpcSuKxm3oXpM1QpT6g w==; X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="382249214" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="382249214" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 12:13:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="704295166" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="704295166" Received: from gchoudha-mobl.amr.corp.intel.com (HELO pbossart-mobl3.hsd1.md.comcast.net) ([10.212.114.241]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 12:13:26 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, Bard Liao , Rander Wang , Pierre-Louis Bossart Subject: [PATCH 2/2] ASoC: rt715: reorder the argument in error log Date: Thu, 12 Oct 2023 15:13:15 -0400 Message-Id: <20231012191315.145411-3-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231012191315.145411-1-pierre-louis.bossart@linux.intel.com> References: <20231012191315.145411-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: XWDIJOWAS45JDV3ZPTIFWYS4ZCL754I4 X-Message-ID-Hash: XWDIJOWAS45JDV3ZPTIFWYS4ZCL754I4 X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Bard Liao "Failed to set private value: ffffffea <= 6100000 24832" is confusing. It should be "Failed to set private value: 6100000 <= 24832 -22" Reviewed-by: Rander Wang Signed-off-by: Bard Liao Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/rt715.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt715.c b/sound/soc/codecs/rt715.c index ed0af0213d60..9f732a5abd53 100644 --- a/sound/soc/codecs/rt715.c +++ b/sound/soc/codecs/rt715.c @@ -40,8 +40,8 @@ static int rt715_index_write(struct regmap *regmap, unsigned int reg, ret = regmap_write(regmap, addr, value); if (ret < 0) { - pr_err("Failed to set private value: %08x <= %04x %d\n", ret, - addr, value); + pr_err("Failed to set private value: %08x <= %04x %d\n", + addr, value, ret); } return ret;