From patchwork Sat Oct 21 11:09:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "neil.armstrong@linaro.org" X-Patchwork-Id: 736828 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA0CC004C0 for ; Sat, 21 Oct 2023 11:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230308AbjJULJi (ORCPT ); Sat, 21 Oct 2023 07:09:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbjJULJh (ORCPT ); Sat, 21 Oct 2023 07:09:37 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08BD7D68 for ; Sat, 21 Oct 2023 04:09:31 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-32dbbf3c782so1635638f8f.1 for ; Sat, 21 Oct 2023 04:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697886569; x=1698491369; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=31dDSPmTEwAk2xBEYscYsgGP3NvqtS1pbeFP7C1NdB4=; b=paUT+Q6GNehX6v7fDfPWI+N6Ji0oV3/HMQPAaX9H43AJJVz95s7Mp3LEgjlyTIg5Xm 7sC8QuxgJVHMlLfGE0r6hstkhqzf1CzxDg52bdcll5lq9/l5JJ1D3EZAuh1uvYrYP3jw eJggRwui3Uhq5oyHfNtozVDhuszC0E4WAdkCQf3h12DtU5pzxvsth1M8nx3vl0BG63Ro wFqjcdqF1HOsjr2zv6lvOcEDoEyLHXv9h+Jpc3+rOk304HJPzseintjnCFmmDTyLxwrt tHFKYKF4u3umYnLhCwmkQa7VPCUkQj6iU1I18sTwcUt/lz6rEZXffnnQGpsmjilKAh9B yRZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697886569; x=1698491369; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=31dDSPmTEwAk2xBEYscYsgGP3NvqtS1pbeFP7C1NdB4=; b=s0TTGPHt3bd458ZWqFVfMpty/2sSWprNfHqT1jbhebF1Y1HrCVKoliuRz5S6nBc8lD 5ZjF9vKZIuVnY8mZ3wJemtnFzVR85GSSQhN5TCoiyfuwUEXk6VfwVzRse0hPoSdws5Lo dIY1wq4rtrQfc1m1thLa1KGL3Ci1OOd+5y+YhkcWncADWueZ0cKQ3ES+zBarssFWJsdg P6OVhTFJAfNY6CsLhsYFZRz6z2b0VZMhFyDaIuMUqrARjC5VGUbSalKsOwwXbqePDZRX npgNOmBIJYleAD25xmGjvfk9yXuBsik82O8FPNHdVXlLm7PdacpBlQ0A/hTXzDW7Jwqg G42Q== X-Gm-Message-State: AOJu0YxCM7X9Ng4ljZCrtLSNPFK30eak5ag/rz8sYfbcqf/uhh28uPrw Vm1HoruAZCEpXfGIL0gUwvKhPQ== X-Google-Smtp-Source: AGHT+IGsZ7x8BHYo+vy2M0OBszvsAWMgeJXU297G/jacAZXOAy2Att3vpAYPgVUg1JHbclD7+qn9pg== X-Received: by 2002:adf:9cc6:0:b0:31f:f8a7:a26c with SMTP id h6-20020adf9cc6000000b0031ff8a7a26cmr4516485wre.25.1697886569470; Sat, 21 Oct 2023 04:09:29 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id o7-20020a056000010700b003232d122dbfsm3491096wrx.66.2023.10.21.04.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 04:09:29 -0700 (PDT) From: Neil Armstrong Date: Sat, 21 Oct 2023 13:09:23 +0200 Subject: [PATCH v9 1/4] dt-bindings: input: document Goodix Berlin Touchscreen IC MIME-Version: 1.0 Message-Id: <20231021-topic-goodix-berlin-upstream-initial-v9-1-13fb4e887156@linaro.org> References: <20231021-topic-goodix-berlin-upstream-initial-v9-0-13fb4e887156@linaro.org> In-Reply-To: <20231021-topic-goodix-berlin-upstream-initial-v9-0-13fb4e887156@linaro.org> To: Dmitry Torokhov , linux-input@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bastien Nocera , Hans de Goede , Henrik Rydberg , Jeff LaBundy , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , Rob Herring X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3093; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=sfk9uxvNPIwk9f8d5iBn9m2N4nTZgMQFpRmAil1gnVU=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBlM7Fle5w7ETIsDU2BtBBNqRsY7dZHknpyKPqkeYfN y3rBrpqJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCZTOxZQAKCRB33NvayMhJ0QpTEA DG1ymYyYLzzyNiFGF9G0idaeRqiWulzAW8bjZIq/RRXN7cKDne0zHDmUeepUq5HH0WyT3SVHed9qfI OJPaHN0bxzaQEcdbCVQ3YXqUBCvxXY/t+xHG84PqkCx5j9Y9SRltN0mkmoxOyjanY0vAoTUS5LteZO 3WW5jik0T8maUUg70A84PpEDvHGDb6Q3J+glR9J9hm1cCWHQSEMYBoIWA5YnA7fLfSaFZ+vl3HTZVN miHYcrbItBataHoKL+N50LnS9mvwpnvGKgQRz5lNZ95tHBM04zAX6t7FaMZUNp9mMXJkcP6FRpHR6z MAUakjSuXDKzm1Uroc8oKNdqHvEF6V/QxqJtJYvtr92JeGBH+mQ6S0ZdnZJuPx86Ign9xeYQ+vyKT8 UW/XnGSO248gdh4CFGWT0xhgZA35H/AnMMu48KuSqdbk0GEepQkQw0S5+6Ag7YUshISOCHicgyQ7JX 4cNJFXuTO16M+bsk1OuIdg63nc4H6abcgEcAYbgcCqjcRGujBBEc+MAluWowZsdCW9pp4zjlD5okgy IyyjG2yDOW8qdYeK8KzgyPjM5og7CAY+KocVl/tS2fnjZJZU4Bb4WFRgqRDpU24c/hf2caK6dwb0HY EPRNcyyhjyNa3BkC5PaAfsvoTOLCk1Jz4UHiCe040lRl0zjSODirs89JBDng== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Document the Goodix GT9916 wich is part of the "Berlin" serie of Touchscreen controllers IC from Goodix. Reviewed-by: Rob Herring Signed-off-by: Neil Armstrong --- .../bindings/input/touchscreen/goodix,gt9916.yaml | 95 ++++++++++++++++++++++ 1 file changed, 95 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml new file mode 100644 index 000000000000..d90f045ac06c --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml @@ -0,0 +1,95 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/goodix,gt9916.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Goodix Berlin series touchscreen controller + +description: The Goodix Berlin series of touchscreen controllers + be connected to either I2C or SPI buses. + +maintainers: + - Neil Armstrong + +allOf: + - $ref: touchscreen.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + enum: + - goodix,gt9916 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + reset-gpios: + maxItems: 1 + + avdd-supply: + description: Analog power supply regulator on AVDD pin + + vddio-supply: + description: power supply regulator on VDDIO pin + + spi-max-frequency: true + touchscreen-inverted-x: true + touchscreen-inverted-y: true + touchscreen-size-x: true + touchscreen-size-y: true + touchscreen-swapped-x-y: true + +additionalProperties: false + +required: + - compatible + - reg + - interrupts + - avdd-supply + - touchscreen-size-x + - touchscreen-size-y + +examples: + - | + #include + #include + i2c { + #address-cells = <1>; + #size-cells = <0>; + touchscreen@5d { + compatible = "goodix,gt9916"; + reg = <0x5d>; + interrupt-parent = <&gpio>; + interrupts = <25 IRQ_TYPE_LEVEL_LOW>; + reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + avdd-supply = <&ts_avdd>; + touchscreen-size-x = <1024>; + touchscreen-size-y = <768>; + }; + }; + - | + #include + #include + spi { + #address-cells = <1>; + #size-cells = <0>; + num-cs = <1>; + cs-gpios = <&gpio 2 GPIO_ACTIVE_HIGH>; + touchscreen@0 { + compatible = "goodix,gt9916"; + reg = <0>; + interrupt-parent = <&gpio>; + interrupts = <25 IRQ_TYPE_LEVEL_LOW>; + reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + avdd-supply = <&ts_avdd>; + spi-max-frequency = <1000000>; + touchscreen-size-x = <1024>; + touchscreen-size-y = <768>; + }; + }; + +... From patchwork Sat Oct 21 11:09:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "neil.armstrong@linaro.org" X-Patchwork-Id: 736827 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8BB9C004C0 for ; Sat, 21 Oct 2023 11:09:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbjJULJr (ORCPT ); Sat, 21 Oct 2023 07:09:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230498AbjJULJj (ORCPT ); Sat, 21 Oct 2023 07:09:39 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A9D1D79 for ; Sat, 21 Oct 2023 04:09:33 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-32da9ef390fso1174125f8f.2 for ; Sat, 21 Oct 2023 04:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697886571; x=1698491371; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Z5GSTRd7yWsW/2h2X+KrYHhvI8Ce18nIFifnprRO8h4=; b=s9jhwt+olIgkWhYo7fNs3No8HJfIG67wvJ6ugPHDfNnrIGlpK0Htvl04DFsBT9ZTqt E77KofAXu1ClG9zxI7zWFrLwWYYsJKam8KgczGalsAy+ElquFtOtvjQsvhIjIxlQ8ygx JYQ6HDvdHhL6wo60p/XajlhSEVqgZBNPUGwBPskM7k+gtEA+RHr90rqSsUm8wZjg8vKZ nY2f6x3A7tdp/3xFM9GJielDLIIjqi41IzQN9TOxbyZ2Mo+ZCbKpmUPBwSraX+2o64Kn NoCBluqhwThLXftDcCvmTDmxNjSe+mn54JYuFqhsLeMrsf9w3HSifxEeHNOGkiS3LNFy 7HVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697886571; x=1698491371; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z5GSTRd7yWsW/2h2X+KrYHhvI8Ce18nIFifnprRO8h4=; b=oMXNVCuyXQPJKZCnVLdCbeEYbR+P2J7CiLgo5KoW78I+pXAEVaig3rTdrNTwFsJWox 2iBdK7Bo03B3TU+cY21hFrOZ2s1SuObSoFIewAYYJOSYXML4xZC87d9CjqKBEylqvKy5 mv7b1fBn2lmZHLASfIex+QzsROC9MLI68oKFfasIRqpWwrq0cNRkm1IiqmulP5zIYNqD /bt1JXJnjZaNBJQzBGxFrS3P1/xvQrR3o1XKmSaAe1eXyrGjTjXSinWiwxtRxUj0jpN/ I7smt4UjjQUIUDlkNfoOfxmZ/gYHhVTgEZSZFt0YPIgkYrpc8DUbBIpJhxqeJCheGWsI tmsA== X-Gm-Message-State: AOJu0YyHIO727K9bJM57Sf2inzwEa3UXnw8GPowFQRfHdhseIH9a/v4f zi5sQ6/covuBLK/m9a6itNR25Q== X-Google-Smtp-Source: AGHT+IFUjZCPB0icLUSAb0eFbREE8JU8ih44f0+Y3srkDyrhVVDldjn7+VpGEDJtFJdkIDz1zreP5w== X-Received: by 2002:adf:cf0d:0:b0:32d:9f1a:9f60 with SMTP id o13-20020adfcf0d000000b0032d9f1a9f60mr2982658wrj.61.1697886571486; Sat, 21 Oct 2023 04:09:31 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id o7-20020a056000010700b003232d122dbfsm3491096wrx.66.2023.10.21.04.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 04:09:31 -0700 (PDT) From: Neil Armstrong Date: Sat, 21 Oct 2023 13:09:25 +0200 Subject: [PATCH v9 3/4] Input: goodix-berlin - add I2C support for Goodix Berlin Touchscreen IC MIME-Version: 1.0 Message-Id: <20231021-topic-goodix-berlin-upstream-initial-v9-3-13fb4e887156@linaro.org> References: <20231021-topic-goodix-berlin-upstream-initial-v9-0-13fb4e887156@linaro.org> In-Reply-To: <20231021-topic-goodix-berlin-upstream-initial-v9-0-13fb4e887156@linaro.org> To: Dmitry Torokhov , linux-input@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bastien Nocera , Hans de Goede , Henrik Rydberg , Jeff LaBundy , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4476; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=fvuZaiaDmAw7atVHwbHQLhUjO6UmtXJUopSvbqmyj84=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBlM7FmySGMj4e93PeqOhh/2eEdrxZ95FeLK5NMZEbZ LvAnLquJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCZTOxZgAKCRB33NvayMhJ0YOqD/ wMBrPpSS2lHa6jeFTTPyglqwII5CN87UWAtuDrpHQBTt4jV33AC22Ksr1UQc7SeTj1FsDJRopphnU4 cXYc+AZVEfUFiRq1ZLlTqxL5Z66XzCCEsEd+RKrE+jodoXVg4sGBQVc5EUwvVevR/iff4TrCgJrXDR e4YVEq8eRyQtoH1Svlk0mqlRZ3Kdtt8QMu0fr77ceKOLgIMlM0dI8xKH9KOCC/GYxL358tbysKlhaQ OjKdAh8mq0vw8x6UByff5ezTEhch0TNhl9zzur0o6PQepB7Uqy2VPF4gZUNMRiz/N59OwLU8KvlQGa PQQOz0jEAQLEEt0A7EkfrQRuflzVRmjsX1GPp585Yzfr8FUhnugsXWt+SzUgSciF981eOf5fPZVXH/ eg9y2+MCWxCkpER5z7CMJiTL4pw44zN5uidhZLv7/NvFCjpYjbTZsmYm5G3Ppkkg2ywXgK3FERu1bL vrGS+u2LPqIL3H85ZUyMzQi+mEXMWoKmQ27X+ShiTOYeznuBBoBUaJrYYa7cGneLkqCygdW218XE/1 uoAjOpTnkAGQxMCALwcrnauRDoqjpsr7nh+cr+6+VvpMOnL9LTUAmKn+meQU9mUqerZTPZKvhIkBFj F7uIceqGUgS42JQjk+e/D5G5ko6I/ccbT41dYX1To3zh262TF4Jz7Dv1MvvA== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Add initial support for the new Goodix "Berlin" touchscreen ICs over the I2C interface. This initial driver is derived from the Goodix goodix_ts_berlin available at [1] and [2] and only supports the GT9916 IC present on the Qualcomm SM8550 MTP & QRD touch panel. The current implementation only supports BerlinD, aka GT9916. [1] https://github.com/goodix/goodix_ts_berlin [2] https://git.codelinaro.org/clo/la/platform/vendor/opensource/touch-drivers Reviewed-by: Jeff LaBundy Signed-off-by: Neil Armstrong --- drivers/input/touchscreen/Kconfig | 14 ++++++ drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/goodix_berlin_i2c.c | 69 +++++++++++++++++++++++++++ 3 files changed, 84 insertions(+) diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index 950da599ae1a..cc7b88118158 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -419,6 +419,20 @@ config TOUCHSCREEN_GOODIX config TOUCHSCREEN_GOODIX_BERLIN_CORE tristate +config TOUCHSCREEN_GOODIX_BERLIN_I2C + tristate "Goodix Berlin I2C touchscreen" + depends on I2C + select REGMAP_I2C + select TOUCHSCREEN_GOODIX_BERLIN_CORE + help + Say Y here if you have a Goodix Berlin IC connected to + your system via I2C. + + If unsure, say N. + + To compile this driver as a module, choose M here: the + module will be called goodix_berlin_i2c. + config TOUCHSCREEN_HIDEEP tristate "HiDeep Touch IC" depends on I2C diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile index 2e2f3e70cd2c..7ef677cf7a10 100644 --- a/drivers/input/touchscreen/Makefile +++ b/drivers/input/touchscreen/Makefile @@ -48,6 +48,7 @@ obj-$(CONFIG_TOUCHSCREEN_EXC3000) += exc3000.o obj-$(CONFIG_TOUCHSCREEN_FUJITSU) += fujitsu_ts.o obj-$(CONFIG_TOUCHSCREEN_GOODIX) += goodix_ts.o obj-$(CONFIG_TOUCHSCREEN_GOODIX_BERLIN_CORE) += goodix_berlin_core.o +obj-$(CONFIG_TOUCHSCREEN_GOODIX_BERLIN_I2C) += goodix_berlin_i2c.o obj-$(CONFIG_TOUCHSCREEN_HIDEEP) += hideep.o obj-$(CONFIG_TOUCHSCREEN_HYNITRON_CSTXXX) += hynitron_cstxxx.o obj-$(CONFIG_TOUCHSCREEN_ILI210X) += ili210x.o diff --git a/drivers/input/touchscreen/goodix_berlin_i2c.c b/drivers/input/touchscreen/goodix_berlin_i2c.c new file mode 100644 index 000000000000..6407b2258eb1 --- /dev/null +++ b/drivers/input/touchscreen/goodix_berlin_i2c.c @@ -0,0 +1,69 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Goodix Berlin Touchscreen Driver + * + * Copyright (C) 2020 - 2021 Goodix, Inc. + * Copyright (C) 2023 Linaro Ltd. + * + * Based on goodix_ts_berlin driver. + */ +#include +#include +#include +#include + +#include "goodix_berlin.h" + +#define I2C_MAX_TRANSFER_SIZE 256 + +static const struct regmap_config goodix_berlin_i2c_regmap_conf = { + .reg_bits = 32, + .val_bits = 8, + .max_raw_read = I2C_MAX_TRANSFER_SIZE, + .max_raw_write = I2C_MAX_TRANSFER_SIZE, +}; + +/* vendor & product left unassigned here, should probably be updated from fw info */ +static const struct input_id goodix_berlin_i2c_input_id = { + .bustype = BUS_I2C, +}; + +static int goodix_berlin_i2c_probe(struct i2c_client *client) +{ + struct regmap *regmap; + + regmap = devm_regmap_init_i2c(client, &goodix_berlin_i2c_regmap_conf); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + return goodix_berlin_probe(&client->dev, client->irq, + &goodix_berlin_i2c_input_id, regmap); +} + +static const struct i2c_device_id goodix_berlin_i2c_id[] = { + { "gt9916", 0 }, + { } +}; + +MODULE_DEVICE_TABLE(i2c, goodix_berlin_i2c_id); + +static const struct of_device_id goodix_berlin_i2c_of_match[] = { + { .compatible = "goodix,gt9916", }, + { } +}; +MODULE_DEVICE_TABLE(of, goodix_berlin_i2c_of_match); + +static struct i2c_driver goodix_berlin_i2c_driver = { + .driver = { + .name = "goodix-berlin-i2c", + .of_match_table = goodix_berlin_i2c_of_match, + .pm = pm_sleep_ptr(&goodix_berlin_pm_ops), + }, + .probe = goodix_berlin_i2c_probe, + .id_table = goodix_berlin_i2c_id, +}; +module_i2c_driver(goodix_berlin_i2c_driver); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Goodix Berlin I2C Touchscreen driver"); +MODULE_AUTHOR("Neil Armstrong ");