From patchwork Mon Aug 12 11:23:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 171151 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp511379ily; Mon, 12 Aug 2019 23:54:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqyjsPW0MFJDeSFXz0FJyDzQEgOorRzIUbOD19NNypnMdiXrC4/P8SfwtKtcnlDpOxApmqcZ X-Received: by 2002:a6b:7606:: with SMTP id g6mr18432216iom.288.1565679256694; Mon, 12 Aug 2019 23:54:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565679256; cv=none; d=google.com; s=arc-20160816; b=Ep8e4wIJZV2tR0dUdWZ346yKIlhBdCi4GSkv5cCE4P7/J8H9x2/bysytKz2dVHhAZa ITenGnhxq8WldQTs/4qVu989yftRdW3ecuCbseIVzyTAXY/B7ISX3MSS+/I9rM4RZcjg jfsw3S6EuFXVWH1o1RvYFEPhpgsMXe89RUlerVFsyBkbqp4tQCQVFZKjbM17k0bRZFl6 rXh7Dv3tr5QiM6zpJf4IhPMo12LJE2JdaOLmScTdqBxAEH6Ysmue8cb+oFJ56nItIQ0l 5aQb/eQQzS8hlTtRNrOwlkC/lnX8tty6Plq9X+mzuAIAGou6JJJL25DrIZf5ubUkRT0E YGbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:message-id:date:to:from; bh=D1KATos3i9uBCWRqtjpR8/h5pMU0mk+r7/7Bf452khQ=; b=D/ZuMLsYIxMMl3ye3lKFxJi1pmjmGHnevABp51PWCqax/TLlm29UFLyYcURMi+ZiRu UAOWiGVXeU4Df5Q39mjncCyX4XnJSdnCBA+nV6WOyh+2RYSzy7qAO86+oN1rxikfeU+E k9N2b0spVEm0Nl+NyxWcfIo1sZUPLVBtPIqqCl0Svqvg9zw0GSgbig+skmvh+v99fkSo PEyAozEcq5HAxy1abs0H6KvusWKIv9clsqqP0/DkAyoo9DKnr9gnIU6D8XxwZCImwI4A Fu9U0DA3FG+ROMI9uCdo8gAJqhSjo7KCaljkiGls3rj/aAvmg7GYZSnVYSiJkbxdCpBi N0cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id h6si143550234jaa.71.2019.08.12.23.54.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Aug 2019 23:54:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hxQgK-0001x1-Jo; Tue, 13 Aug 2019 06:53:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hxQgJ-0001wd-No for xen-devel@lists.xenproject.org; Tue, 13 Aug 2019 06:53:19 +0000 X-Inumbo-ID: a8050ef8-bcf3-11e9-a281-e77186e782e6 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id a8050ef8-bcf3-11e9-a281-e77186e782e6; Mon, 12 Aug 2019 11:23:49 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C06215AB; Mon, 12 Aug 2019 04:23:49 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 675733F706; Mon, 12 Aug 2019 04:23:48 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 12 Aug 2019 12:23:43 +0100 Message-Id: <20190812112343.26858-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH] xen/arm: setup: Add Xen as boot module before printing all boot modules X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Since commit f60658c6ae "xen/arm: Stop relocating Xen", the position of Xen in memory is not printed anymore. This can make difficult to debug early code. As Xen is not relocated anymore, we can add Xen as boot module before calling boot_fdt_info(). With that, the function will print Xen module information along with all the other modules. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- xen/arch/arm/setup.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d047ff8e31..7509d76dd4 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -779,18 +779,18 @@ void __init start_xen(unsigned long boot_phys_offset, "Please check your bootloader.\n", fdt_paddr); - fdt_size = boot_fdt_info(device_tree_flattened, fdt_paddr); - - cmdline = boot_fdt_cmdline(device_tree_flattened); - printk("Command line: %s\n", cmdline); - cmdline_parse(cmdline); - /* Register Xen's load address as a boot module. */ xen_bootmodule = add_boot_module(BOOTMOD_XEN, (paddr_t)(uintptr_t)(_start + boot_phys_offset), (paddr_t)(uintptr_t)(_end - _start + 1), false); BUG_ON(!xen_bootmodule); + fdt_size = boot_fdt_info(device_tree_flattened, fdt_paddr); + + cmdline = boot_fdt_cmdline(device_tree_flattened); + printk("Command line: %s\n", cmdline); + cmdline_parse(cmdline); + setup_mm(fdt_paddr, fdt_size); /* Parse the ACPI tables for possible boot-time configuration */