From patchwork Sat Nov 18 17:42:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745076 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KP1RC6Ba" Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9B44130; Sat, 18 Nov 2023 09:42:28 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4083f613275so4951565e9.2; Sat, 18 Nov 2023 09:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329347; x=1700934147; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=KP1RC6Ba6PXsQozBHV4kk/de6pTWwhNQtfegrVKppUJp1i2Gyuj3aeWOT4LKFXXGy3 GClr5m3glaTo1JQECTROzX7kU/tSKtIzRMuyWkeKDG9wFjNXHoBDI3QIIice5Nn2dtmm R/SiBW26QkNiOjejH+fTiYPwXlLsMqBHhhz/E6D9AMt0K6bUz8VLCFqIpFrnL8oHhEPY pF8slpT0whttGTqad3gDSBULnOBjEIK03wuVZInvJBg60V3Q7oYNUPNgzc80y0tjigDh aZrFiCzdpEaVxCbRoXxutteel+bp8inQIXHAITMa/4xwz+QLISDHr6fBlYTNVEyIsBqW KtOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329347; x=1700934147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=DO62MDLveag5BzJNfXmbyJLYIQ5pZr3+JcFNdSeCFCzoCsj59Wa7CZwGOskHKguEec BCiPfQB48CqdLXzmhekcJ6JiGiThRNpvJmOxt/pbm1aPijYE10aLo5NWuzOXypYqEwxM Dxgvg5qs8cYQQGsB+Hio6Q2feyWpxK4hVyNa1XM06MDD6KE+ZDfqC5bh0IyZtUKr1o2t a/hkSMuwoTJtrL/xYNviwAcZg4cB2V1gf4VLQxN3EfXPpvIQ4fW4aBryOvorNsl+WZO5 ww6PDtQaPRlvQslyJz1tkb2zNWE5Ba7f40iuyIg4ewfO6kr5cB/6Avw+2NE56wJhC9Wd RXCg== X-Gm-Message-State: AOJu0YzlzVLV7O6r6BgtM0nOL6tFdr67+FZ/RLnVrpBERbgEtnr/NAcb 9Lfd2+MBYdGHeRkzxQ+LcgQ= X-Google-Smtp-Source: AGHT+IGchLGNn/UTh+TSPBum/ynhaPI5RIfSnYeSODGRmp9mYu+xtswabBOKG8QD70Eu929TNCd0ww== X-Received: by 2002:a05:600c:358d:b0:406:849f:f3cd with SMTP id p13-20020a05600c358d00b00406849ff3cdmr2461814wmq.29.1700329346812; Sat, 18 Nov 2023 09:42:26 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:26 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sandy Huang Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:01 +0100 Message-ID: <20231118174221.851-2-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Heiko Stuebner Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 6e5b922a1..a7739b27c 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index fa6e592e0..7a3f71aa2 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi) init_completion(&i2c->cmpltn); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; From patchwork Sat Nov 18 17:42:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745309 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fg+G0G+S" Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81D8F131; Sat, 18 Nov 2023 09:42:29 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4083740f92dso4666445e9.3; Sat, 18 Nov 2023 09:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329348; x=1700934148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=Fg+G0G+SGdCcEQ5DHHKxhun1akPolQ6Qu9lmdrNWUnIvXC8a1Y5OAC1TVYWhun4kPY AGlkSms0XVm46x6AFvDzLenHPjorUJib17DG4uZPhJE6ZXPfmkRMa0dEvfecmJttnsav To8ZWhM1eA07exKcO5pK0Bv0uLgkMUY/MZs/An+5NWbFMOHP3N1X5N/9/G8In7isc/hb DudZkF3qMSXz+f/EPm59wZKdApSkaTZbtjbuvZsQgi4f0+V1kW8FlzZEUlZXQmRZ6r3q EdnZofQWXhKm75bvse6zqKXZ9K/BZ5Df36Q0d7LgMfU9ctqrocczhDGI2Fo0Kjl1taDV ZyrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329348; x=1700934148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=I9EprR8HHPSLOxLe63m6uaNdWlpGNg2bQ7Li3zFKvruk/HDyjix4B9rc2MZzsGXomK vi3HY7mP8jKwIuPMd7mVPdvv/2wt2TnjDrhYXQ3h0iwOoUBS4Z/4i3uU0I78D0acrpAi fKXqIqlV6xSXtJOCJBc+Hgwnc9mAY9KJ2vB0EjMEjutwNM6AzfuLVGxsq8bDprSA7Lj2 UAqXkCraK59HQMIXLFWgRGWAsmbhrQIG0cNyPRO575iVkuGUNCJmILGfd0jVLQfRUEgu SJipVG4/VZD5+Q0LA8jTxgv31EBv0uSAQ6Nvj7wRCzywLeMyjtiw8bdp0jSW2txzKQKU NVsg== X-Gm-Message-State: AOJu0YxDJ3vFjuRrmpSmRSCscbx/kbAoWoNWESvG/d6ZlFh3kQOmwZB3 Sl2RybbyaHNAv344VjWruVQ= X-Google-Smtp-Source: AGHT+IE+/T5akrgcd8jfoxC+27DJiLMD9yywl/rsoQi2NbXCmSA/211Cuyy0UCxwYrsOXe7kSYSepw== X-Received: by 2002:a05:600c:4f14:b0:406:f833:d853 with SMTP id l20-20020a05600c4f1400b00406f833d853mr1767049wmq.15.1700329347662; Sat, 18 Nov 2023 09:42:27 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:27 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Thomas Zimmermann , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:02 +0100 Message-ID: <20231118174221.851-3-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) i2c->data = BIT(info->i2c.data_bit); i2c->clock = BIT(info->i2c.clock_bit); i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sat Nov 18 17:42:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745308 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S+mei+EG" Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FC5512B; Sat, 18 Nov 2023 09:42:31 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2c72e275d96so37926851fa.2; Sat, 18 Nov 2023 09:42:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329349; x=1700934149; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=S+mei+EGZ2wnXIJQnMifLNK80ndLxmNj3TREd+7hAWgMgmwy/l+KMhFNOwx5DqNzMV 7IvykPon+yNC1jLu8l2nRlmwQXsw/9pMdaUbA/TMbKG8ZULhjvnxSjcYXTSwi7hPvY4W fGe/w1jyE90O5VAC1053C1LpfEo5KNFYIIVtswjOwYyKoUI7eqaib0sH1azGZ4vgigqs 0BW7UQKKMmXev4RgLgQRsSjKLlwHKu5kQIjOISW0Le+Sx7SixkI6L9dIOCpmRVHWtF2m EgLL4xTEXhYC8AHeDOHFZdE3/kk3tLXnA6YFbQgMq4+4VUQY8Ni15M1XxCaKw6KsvYkZ 5w4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329349; x=1700934149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=RijU5H8OGhd+lQz0yQmAsGgBPzVpTG/okvCHI3uWJZ7DYZYN8upPePlJeWmnJdzHQv HXHy/vcqWmn+SzailRlilV2H+ltyRkTAodCzWsV0L157lfJbHnhzR2jjQGm4WMl4tDmL IlKjP66uetRwcD03JXrBNnIq7561bw6ORfPYLnpHtVRM7rPLWDmT8yvIh9r6jZc8RYdt 2iifEDT1k5BE14pL1w8uqbVO3eN6B4JEzWPPSgadKXBtqY3OW14ceDQzU6WJbJNPWUDG AdGqN/6AcIp9dt3wrIuOlzq/P5TcjT9qLx65cNytVZGXJagEHFTVkf9gBqbcSJyce1IR mBXw== X-Gm-Message-State: AOJu0YxskdJE7+4cZBGyOf5kDaRv7j9k1Q/MQL1Y8v7X2YZ8eBA1TJjW 28XJ4yPx+WVdR/wLBPcPwlQ= X-Google-Smtp-Source: AGHT+IHnFgNWvQQzwc0XOhpUWTcrcN2j6CYFonTN+gof5Zy5XsRr775SK97ByQAzYdXjmLv3xio01A== X-Received: by 2002:a2e:82cc:0:b0:2c8:3254:bde5 with SMTP id n12-20020a2e82cc000000b002c83254bde5mr1493466ljh.50.1700329348922; Sat, 18 Nov 2023 09:42:28 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:28 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Harry Wentland Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/20] drm/amd/display: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:03 +0100 Message-ID: <20231118174221.851-4-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6f99f6754..ae1edc6ab 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service, if (!i2c) return NULL; i2c->base.owner = THIS_MODULE; - i2c->base.class = I2C_CLASS_DDC; i2c->base.dev.parent = &adev->pdev->dev; i2c->base.algo = &amdgpu_dm_i2c_algo; snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index); From patchwork Sat Nov 18 17:42:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745075 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHVClbWI" Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9528DC0; Sat, 18 Nov 2023 09:42:31 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4084095722aso5382045e9.1; Sat, 18 Nov 2023 09:42:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329350; x=1700934150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2A7KgJeMP1lI74vlMRztf0ZeAIQKlR0j/L1YwdkkguA=; b=dHVClbWIFrqtDIsILUa03+MNvi4GMqwCifqU6ut3SDKlcbuI4T59uZmKHkiaC3UjfY NQKn+ADjkwXsjnmwq+Oq2gcQtOLmG9zZgFlN1bm1/k3mqz6fOEqVnabZMFVbQ+udTPuv URuA9NZJC5bLQmzD2wqDeqJDyQHaB6Ts2RJUmNZ0WHYujnr46rtzxeLr0GU8/C5DNr7u 17B1MaogtFT0/3faNYmQczqaje85E7nsyfxXLhNiRbrpokwa/M5eaxKPUp/KXjnSrXSd qV1d/qeOJiR16TX1sQ//30fN19VkbUoxcgisxPp2uK5ds1VA9S47HRxLN3Op3dKSqeMm TsEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329350; x=1700934150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2A7KgJeMP1lI74vlMRztf0ZeAIQKlR0j/L1YwdkkguA=; b=Ai/CLLhegzV1I9UdMSmUUhtgtVXXmkKTDRcRTighqm+OLhU4AQkec1zjbrpn0Gs2CO NBZP0TRltJJx/p1arLtv3FjU5da/eInLKvcz116XnyI+7OGZN3qwvCiHSBRL4hQ05kwF /G1XwbXJbq9ng+1Dgiik490NeZF1hyfx7lZza/kI23BjGTMD5TL/cLVfI3+7H+VbTIf8 1WKDTOUdNn2hsKxm+QxUwMgrQkqqWGmzZRqJ/HYEErJBTL+C2nJtgGIkXivZMJMz6n8I 2gjcRotRLdJDlg4b09NvANgw6yXR0igCXrsGFoWFiDdqp1Ea/eCJqz73a4ZZxILBVC8n 80eg== X-Gm-Message-State: AOJu0YwrKGhlxD+Ta768x9PFVCLqN90T5uF4a2PK1oFxswCVg42UOO/v gy5Q1Af3zSigshrcaT2mLAk= X-Google-Smtp-Source: AGHT+IFhcmh+HF8fxApZE0ppjzudwwON5aQtR0W323i40dvMUD5YGJYLj4L/jEO65VvDn1fpwc/WhA== X-Received: by 2002:a7b:cd97:0:b0:408:3b8d:f7e8 with SMTP id y23-20020a7bcd97000000b004083b8df7e8mr2221493wmj.33.1700329349862; Sat, 18 Nov 2023 09:42:29 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:29 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maxime Ripard Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:04 +0100 Message-ID: <20231118174221.851-5-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c index d1a65a921..f5f62eb0e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c @@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi) return -ENOMEM; adap->owner = THIS_MODULE; - adap->class = I2C_CLASS_DDC; adap->algo = &sun4i_hdmi_i2c_algorithm; strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name)); i2c_set_adapdata(adap, hdmi); From patchwork Sat Nov 18 17:42:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745074 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BZhIdi2i" Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C01DC131; Sat, 18 Nov 2023 09:42:32 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-40853c639abso4728455e9.0; Sat, 18 Nov 2023 09:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329351; x=1700934151; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4ibVEHgtEJ5eQu45MMiPygdDJxNCKoN0M/oBQUtm4Q4=; b=BZhIdi2iTZk95IuPPyj80cxyta88+5u6oPD8X2WtkaQgM3FAv3I3t0KaDijvQ5QCRR YgavJelCXjfcEg8VQHP05tXXqwNbrZ8uMQPqcV1cEEcjaJwCEi8AaLU7ir9n0El78vN6 Z4FdfABzp6UDv6uZSMDjRBrAnDwp2Y0ScN+GW9MgFltlhYYf06oWgFOcyotvnUjLXvHn LbsDT2JVhHiyNX7YqkZSu/+aRR/D+wz7utNGqtWxQbRIEAfG71tSmJhSg59dogB9prvM kHIEC0TOUCdXcJEybjeSZA6a3msLmxIcPDoHDgwSRheyJrxK/uAUEDwLgSmP972inkJJ 6v5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329351; x=1700934151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ibVEHgtEJ5eQu45MMiPygdDJxNCKoN0M/oBQUtm4Q4=; b=SLo+jDWjPVIb4a0A4rGpHiCDI1si9dff9QbQSHdTqKE5NpLFodVd9yCqiLIqG9L/vb 5z2sDQ0DYIcTTndfkYsjAN1hklGgDGaAOBaX+reR8QQBKdd+MhCw7QqXjNbRHjhrc5dJ VI5fBOlzEGgS6g1znTDbTlhBeHtn5EIt0V2hAewAoe6loEsUwzTCM4XnOQVz7vOmPFJI Xkx0JzU9yzEf0lbp6mxhWm6zN85iNikx8K/NQ6lP83ewXguMj9zCFlZ+h3pBwlw0fWWJ E4SwczwFL1s77mTCOGUp25/B7DZtF8qDuEk42ME0OXi1qQAXaKkqqcrkuBYjaC5leJRx 7xkQ== X-Gm-Message-State: AOJu0YxzN6Un0oUq3TtpdiYvw3AlgFi3SvK9xIp12daonB9Y07yrYNQ+ kKBUa6FJvsNlVtKwJTKRMUM= X-Google-Smtp-Source: AGHT+IEQSzp6MnzL/fUmwzKrW5jX/twilEpFfjkl7pHWIY4U5ArUWiAEvlzUu/AsvV7T/l2f2LM3IQ== X-Received: by 2002:a05:600c:4e92:b0:401:38dc:8916 with SMTP id f18-20020a05600c4e9200b0040138dc8916mr2681496wmq.10.1700329350876; Sat, 18 Nov 2023 09:42:30 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:30 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Helge Deller Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:05 +0100 Message-ID: <20231118174221.851-6-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++-------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - 5 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index 1897e65ab..9b74dae71 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -163,7 +163,6 @@ static int i740fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = i740fb_ddc_setsda; diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c index e2e4705e3..fa07e1e5c 100644 --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c @@ -100,8 +100,7 @@ static const struct i2c_algo_bit_data matrox_i2c_algo_template = }; static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, - unsigned int data, unsigned int clock, const char *name, - int class) + unsigned int data, unsigned int clock, const char *name) { int err; @@ -112,7 +111,6 @@ static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, snprintf(b->adapter.name, sizeof(b->adapter.name), name, minfo->fbcon.node); i2c_set_adapdata(&b->adapter, b); - b->adapter.class = class; b->adapter.algo_data = &b->bac; b->adapter.dev.parent = &minfo->pcidev->dev; b->bac = matrox_i2c_algo_template; @@ -160,20 +158,18 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) { case MGA_2164: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1B_DATA, DDC1B_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; default: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1_DATA, DDC1_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; } if (err) goto fail_ddc1; if (minfo->devflags.dualhead) { - err = i2c_bus_reg(&m2info->ddc2, minfo, - DDC2_DATA, DDC2_CLK, - "DDC:fb%u #1", I2C_CLASS_DDC); + err = i2c_bus_reg(&m2info->ddc2, minfo, DDC2_DATA, DDC2_CLK, "DDC:fb%u #1"); if (err == -ENODEV) { printk(KERN_INFO "i2c-matroxfb: VGA->TV plug detected, DDC unavailable.\n"); } else if (err) diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 589b349cb..07722a5ea 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -252,7 +252,6 @@ static int s3fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = s3fb_ddc_setsda; diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 22aa95313..51ebe7835 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -1267,7 +1267,6 @@ static int tdfxfb_setup_ddc_bus(struct tdfxfb_i2c_chan *chan, const char *name, strscpy(chan->adapter.name, name, sizeof(chan->adapter.name)); chan->adapter.owner = THIS_MODULE; - chan->adapter.class = I2C_CLASS_DDC; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = dev; chan->algo.setsda = tdfxfb_ddc_setsda; diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 816d40b6f..516cf2a18 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -274,7 +274,6 @@ static int tridentfb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; if (is_oldclock(par->chip_id)) { /* not sure if this check is OK */ From patchwork Sat Nov 18 17:42:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745307 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CPpsSSQm" Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C5D9192; Sat, 18 Nov 2023 09:42:33 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40a4d04af5cso3913925e9.0; Sat, 18 Nov 2023 09:42:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329352; x=1700934152; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=CPpsSSQm6GhTtfEI0/p4dQE9MJuM44aEe4ecCtbWsNZm+C4s9amn8tbp5Fn10NRMDk DbckHsMxmCF+KrqAcxzi1ihcrUWbsRkYavMWx5Bheb4tWvO9XDn4y5Y1igjjtNw0yJ3d KrrJo9VoHJFzG5E8Ux0zMCr+mbSmBDLKbNR//zrjiagBk7Ve5bTgMS8oar6G67sWYxW/ PmJaAhljUW4xzO28qckyzix8niDt19G5IE08FEDussYiQld6WvVaNQVnnXkurzWlzosb 8QkIoLxJJbuuAQEMVhx/7frhkIrAjYCINUicXmDTb9l4l+sN4OKt6ZkkOmDbooPNlMyh K3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329352; x=1700934152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=NvX2C1QdE5pN8Ivrj7eZ/OfkzCEqHTfL+3cmmSjUcVNvL6AZHbHo2mIfkldj+dZiuM VH/0fenczweaPDR0gCkM5tb7oTYrWm5HmQnVVYBIchv0sM6m2E7vxpp2aOFbDoJhSZOF kPpQTmGi7zcht4rlMw2cz+iVoNV7PsWmj8F5XuawRQLVyrsyGV8ngDWPZJ/+Mw1sh76t a9n+9FTUPv5crzo13UF0ht5EqsLCdqS6WVXxpN/PLtKNacLHsG+Szm4Mz8kIXQGVE0T5 DrJuXh1EHfjd4yViFr2hDUAO5GlXbl4oq7+l4Jr+OlRTqrheo3cJKtd/FWWMXdoC5tAW D/Mw== X-Gm-Message-State: AOJu0YzjrAkQm80n3AsygIborPyWecJiyKYUZL/TeThqdkkMDv6vsblH 5WOLZi/2qv9FWxpVT0QXJAM= X-Google-Smtp-Source: AGHT+IF2uuCnONQDkgVMYOEey1RFRUe8GnD9gILj5PaZk9ukHNBactX5XsSTUMsKSBKRWlQHaR36FQ== X-Received: by 2002:a05:600c:35c7:b0:3ff:233f:2cfb with SMTP id r7-20020a05600c35c700b003ff233f2cfbmr2013183wmq.23.1700329351574; Sat, 18 Nov 2023 09:42:31 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Daniel Vetter Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:06 +0100 Message-ID: <20231118174221.851-7-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/core/fb_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/fb_ddc.c index 8bf5f2f54..e25143219 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -116,7 +116,6 @@ unsigned char *fb_ddc_read(struct i2c_adapter *adapter) algo_data->setsda(algo_data->data, 1); algo_data->setscl(algo_data->data, 1); - adapter->class |= I2C_CLASS_DDC; return edid; } From patchwork Sat Nov 18 17:42:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745306 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EWssYaZh" Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD41DC0; Sat, 18 Nov 2023 09:42:34 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-40a4848c6e1so3849745e9.1; Sat, 18 Nov 2023 09:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329353; x=1700934153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=EWssYaZhCnS7AhXOElNbBA9dD8+DJA+frz4w2qhg1j3zs1NlhgKxNzW6SBlQaIKo+t MrUUW2VH0RH76d01ZqNrh2Jr8lD6D3+m7LOVUD3iRiJ37ysMj+qrYHZxCdJaStCIEFOL Ho7WtLD7xJXlApOLcKsbii4XUSQPRilBXXPXEhs/N3CV69d66BFvmRwGeZTfb09LtuPO dVZ2L8q+PqF88AT15oItBUJEfyw5nIZl2o+XVFLCYnDGCwuMwzt6mDVxpsVMXpFN7rix cbuZUldH1L9aefoNWi14bMGhvE2GJZKyAI0R85lv0q4HIdrEL9Y+quoGVnmmxiakfXLW Lk9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329353; x=1700934153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=dem/CAlpSz37uuFGezivk1ApDvL9IFd6B8TX7rB2Ing+xwwbdC62dwieIgX4FksKff YJofNvRDq2OaKaaAq5PSBJ4MDoGDLb36NhuliLZeGBknSqXEhTN6+owpXvyFZQhURs31 g2ylM3cqYVRoZPVRnDdroJGU0sj9ghCbBVsjJ1rByXed7LyIG0LcNL6s4xZ6/EdDBANF cU9nMAeaI4W8ooHJo1G7brYwU4engXfLbpaX3UtyY/UQvr0ZrykeOiBSlvCSwZ6UYudp 3N7OScbzekAIczS2NdM9HYFsGtXIcRvYIrQCAAWfeMR2olT4zF7WOZbxhNE7zY6ERmso jxRA== X-Gm-Message-State: AOJu0Yy31aTjASR1wtV6GNoJM30Y3wcsWjgExzywO+TSJjzd9blq3iZf +C5WBND3kC27qPALpZIIhiI= X-Google-Smtp-Source: AGHT+IH+vVNTNRuNzx5HCBAwdawDR0oj+mid80kQSKCziiwvte/UEe7naf5BwwoyEL1Bwr25F9JxEg== X-Received: by 2002:a05:600c:1f94:b0:408:4160:1528 with SMTP id je20-20020a05600c1f9400b0040841601528mr2146365wmb.30.1700329352609; Sat, 18 Nov 2023 09:42:32 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:32 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Alex Deucher Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:07 +0100 Message-ID: <20231118174221.851-8-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c index 82608df43..d79cb13e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 314d066e6..3d174390a 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sat Nov 18 17:42:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745073 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aPLU3XHt" Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71F8FD4D; Sat, 18 Nov 2023 09:42:35 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4083ac51d8aso4671135e9.2; Sat, 18 Nov 2023 09:42:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329354; x=1700934154; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=aPLU3XHtplIReVL/oaZ3Hk6wuEQOsJcN/3LxE4qv0mZeDWdSGZ08fgBamyuKjfSRqi TdMAnXvuxjs07caaIgudbtgVcBc1CqrstTzrbJHMrU+BOXAFpusYa4IEHeqSjzFFRgJn p5LHhU8BdjuW6rWpW20ncEgtfvSWT0fm+4ifNCTW6cM6mWxTCfpHNfC/H7X+1GBbfl52 o8oLQ2Z9/OV86Xj97BCe1/qT+E0AiTaVyzcXfMZQvi9c0mP0D6fuWGuhZYVwncwkaita 8lAhpZ4fs0137PnKs/9m6DJig8uZO4yG1jpEaih0qm688ZuG9bN9YZBIHQtGkeXGH8na J+Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329354; x=1700934154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=cbkLCld9eOi6sGHb92pqr18geOzOBrf8Za2rfHHA97GvBOZ/S6/o6Gq9OfaZ1iTcXI ST6zFatLglDiztJCm5Z5/yt3Ug4M9bAvilLQLJgEVv/rnjpHq21B5WxBCbTwgkrZV0vL 3dxa17G1Gxb4XQbDJn7OX+kdV8cxGDPWjB4kKPDOMi4hTZQc2AzAdzO26DqUFmC/rxcC F9aIHDjvw0u8r6II1kRtep/7LRCvdiPbYmVgOEhi9HRFdUk/wZJD0mmYZV59pvG86Fp4 fxr/rqSeaJSWANaXlT2Peqz2RX9SEx+brA0Vb8M12c6x9UyWsrp2F4wUAJwqbmOG/rOB NpTw== X-Gm-Message-State: AOJu0YzrAxLg4Dhxb5wSn8YTF0h0pgbCeuFepZSUkI0dy2cUgRQQ0zAW lGF4VgPBPAn0zaQxTdiiQlA= X-Google-Smtp-Source: AGHT+IHFeQem3GC7lyXfhuux3W0nXFchU62Mp5yU1I3tjQqqacuqysAcTGeFS+2WghbyMr4dvj9rxw== X-Received: by 2002:a05:600c:4712:b0:405:348e:aa43 with SMTP id v18-20020a05600c471200b00405348eaa43mr2139830wmo.12.1700329353750; Sat, 18 Nov 2023 09:42:33 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:33 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sui Jingfeng Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:08 +0100 Message-ID: <20231118174221.851-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/loongson/lsdc_i2c.c b/drivers/gpu/drm/loongson/lsdc_i2c.c index 9625d0b1d..ce90c2553 100644 --- a/drivers/gpu/drm/loongson/lsdc_i2c.c +++ b/drivers/gpu/drm/loongson/lsdc_i2c.c @@ -154,7 +154,6 @@ int lsdc_create_i2c_chan(struct drm_device *ddev, adapter = &li2c->adapter; adapter->algo_data = &li2c->bit; adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->dev.parent = ddev->dev; adapter->nr = -1; From patchwork Sat Nov 18 17:42:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745071 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CFDf0ECM" Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FE6AD5C; Sat, 18 Nov 2023 09:42:36 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40839652b97so3845175e9.3; Sat, 18 Nov 2023 09:42:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329355; x=1700934155; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=CFDf0ECMMfTm14EaVtSM3hhI9MdarvbVPU9OwjrfqOwvYTG0og1K2iEuUqmaWwKYbw nwy08OxnHzMJYSmRl/VWE+Mas643cgPCFG49TcgSMJU9V2SX/qMTus01XwodpC7lv+01 0t/+k1007yYL4RfNvX6Xa1ys467+7RE4aDvIsN1Esv7MfboeG3x7Y2H8WjxxzGPoKIDo xA6/Nb0PgNH78v6sRh6faFrpM17blkK2j/ydwr7slud5Lqb1jldEtd9YrZhn20WDpanB eB/LPnFomIgo8THghiB8RJBkpEQJ2np3osYZ26RDF+Oft0k5qXeLnu21Lb5RltyP1x1D sOlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329355; x=1700934155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=IJxoQxq7iEcqq2kP+mJ358lktkgd/rAhxW3Wdy4v/+ddSCEA8SXI+r3hvv4Dt2zBhZ bNWxPxgXJyPF+UZhovx34PVJ79JTs0iwDBeCGz6yLlzO77lGcuVpb6Ed1+PK5Pf90tRw eCvrEm3HFpKcaZ7ORqmUgzlgHN1aEB8C9B+3HJYHtojLLYXFIF4RUnJUKghShhjg8ZQD 0pEGSa67nkc8jZGEAiwX7teKTcK17iXWuOTAVnIT4HLcjD8MdavZQTJBOyRS4lLlGFSq 1/2H9pwSKmI5hYPM4UNiWTr/dowXtgv+dAGHXVNOC9fsXeTAL1xWWY4w2HACnA0eVCuV kGog== X-Gm-Message-State: AOJu0YxMChFWGQGsDDO8h9KoK7Jn9LLAALhXxZn/7u9TibNLScQxcde6 4cAJqyrCwQYjS0x5v26phyxyt5dQZMI= X-Google-Smtp-Source: AGHT+IFq5BOx+Vn0YrjLip0ldY3nSGhqRKbTkmX9+Fy3Wz36IeGI2djpG63W1qV3nbXzFeP/oHp0mA== X-Received: by 2002:a05:600c:154c:b0:405:75f0:fd31 with SMTP id f12-20020a05600c154c00b0040575f0fd31mr2291085wmg.31.1700329354751; Sat, 18 Nov 2023 09:42:34 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:34 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Florian Tobias Schandinat Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:09 +0100 Message-ID: <20231118174221.851-10-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/via/via_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_i2c.c b/drivers/video/fbdev/via/via_i2c.c index c35e530e0..582502810 100644 --- a/drivers/video/fbdev/via/via_i2c.c +++ b/drivers/video/fbdev/via/via_i2c.c @@ -201,7 +201,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter, sprintf(adapter->name, "viafb i2c io_port idx 0x%02x", adap_cfg->ioport_index); adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->algo_data = algo; if (pdev) adapter->dev.parent = &pdev->dev; From patchwork Sat Nov 18 17:42:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745305 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XB/a1LQ0" Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 676F0D62; Sat, 18 Nov 2023 09:42:37 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4084de32db5so5558845e9.0; Sat, 18 Nov 2023 09:42:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329356; x=1700934156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=XB/a1LQ0+iWYpch2WEH4ohtCzIEuJPNRtbR2z7aUuaEeH+AU1KzpkIyVy1b5833GBk BD+utb5aOn1/A/5yl39ka2oKBjbk0XeN5JW24ZMEf6OTStpx19TsthZWE5G0Q2kMOEgE 7SWKUHb8dvcQvdaNmbrDB1fBDsMXNYXZhPJUHhX7dIXXbGH5Y/edlul1iMCA9w2tB3+T KiJx8ZSxOcgmos4cWJyo4M37We8s4Z6OJEeC1ONgvWAOndsheGHJO98XXP2VKi2gORw8 zcMd8FqUNYXj0meU34O4csLufQqkJuVH0S0iBwEb9saswaL+SLcyVf/6/SHRYFhwSUAN vaCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329356; x=1700934156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=ACTSVzlmPb1RvzyBdmn0NV7kKbAQ6guZmrN4SwEBYLXXDeKRi3xK+H7Y3ifnegFtxW 1MSKVhHgCDS3HVj1Pp/dEqY3owSl1As8o7uNH8y2T+2XKPuaatYiWzNZQ7mRcjtfJo6K hOdOuOBq1CEUhOgXg5q05eECZlZc81FOCs5Wh3zDUofQLFc7C425A7QTFQdPnUIOi3oc Pm5QRMl135a/EgVm8VcfqBbtiAFpAED94al0+sZ/Lg9Rn9U0ZoPiWuPtQs6p0KUr073+ YE6L4mKkY+1Pa6C8CrEpdm8TlWKK2p+nPYEa+30LOYMiErwANA3ofmbuZLNQ4Mi7Q3Zu b1qA== X-Gm-Message-State: AOJu0YxQ9v3qX3SVKmH+qj1AmMBD3J0lM3ibm+gr+wIllMTQntOwwcX/ AbzrVmqXdSgvjiEKJLmGRF8= X-Google-Smtp-Source: AGHT+IH/UONni9JBi2RCMivHlBv+H1UGwnLkk3yuImh+ir7/RnEejhHlDGLGWXdlNBwBR0HTwihAzg== X-Received: by 2002:a05:600c:4ec6:b0:409:3f53:c9c7 with SMTP id g6-20020a05600c4ec600b004093f53c9c7mr2232492wmq.35.1700329355808; Sat, 18 Nov 2023 09:42:35 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:35 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Russell King Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:10 +0100 Message-ID: <20231118174221.851-11-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/cyber2000fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 52105dc1a..79775deda 100644 --- a/drivers/video/fbdev/cyber2000fb.c +++ b/drivers/video/fbdev/cyber2000fb.c @@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb) strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id, sizeof(cfb->ddc_adapter.name)); cfb->ddc_adapter.owner = THIS_MODULE; - cfb->ddc_adapter.class = I2C_CLASS_DDC; cfb->ddc_adapter.algo_data = &cfb->ddc_algo; cfb->ddc_adapter.dev.parent = cfb->fb.device; cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda; From patchwork Sat Nov 18 17:42:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745072 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E0XmnWa2" Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6459D70; Sat, 18 Nov 2023 09:42:38 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4084095722aso5382615e9.1; Sat, 18 Nov 2023 09:42:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329357; x=1700934157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=E0XmnWa2S0Biqjy0o2CvvVF06vaVemff5CWbChB1OfNbKBT4oqa/XQgCOlQ520gMPa n6wZ29pYvYEiKOZM7og7O0cqBUdhQah/y5SI9CcImOV9Yxoz7vaOz5ST2IApiHdnXXHb gb61ZZ/hCLeS783lVKwFA8ZevmSKQGWh2d0Jkdc/jwH/5IUsS+wLJ2aU4gQR/I9vuquc YPyG7W47135v9k4thS/fbVNIdCYvX1ynvZUQ94Kk+NUuPhbD2wlEfRimjfDjklmhq6aI 7LdToQpmIXQtrBcEEV0YJa16dZQ1V7SZriMRej7yezZ7QNkiDlvuVOmqRcraI9Pszaks Ku5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329357; x=1700934157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=uXunttRN+KNdpGUCXkcBhXJD6Pmc7ivuXsgRnl3yqul1k0gw3rFzJcfJZBVrYCYPd3 w+HZjaAuhBSTb/C9no/8Fok3iubwLJI2ZOhvQv0x+qQOb6/Ap63qOglMT+YcRSyyi9OC nv5HMrRyuA9j1S9k7o/TZ745lC47ZSmuBia5V5wlqJPLp6gPGm6Q3c0oLdMCPYMGLXGa wPDNiRmNPJugoGt5apzaTzCFeGkMHEL8jc+M/UwYa0P/QkdC/HKsclNu9Hrg4FQywSxW UmAlOjJGyasKMYqB8Ih6e/13mU3Rfn7/U72ap1+6h1k3tKxKNqsZGqFIPf8Ek9vLjpNH pRmA== X-Gm-Message-State: AOJu0YzzOrl3dgSSAoe2Ki/eETSNsPlu/w0jHJ67odyQeweARu0cY5Ez yETirvYRNTjQZXeMDvcyI+U= X-Google-Smtp-Source: AGHT+IEYtipVOmHkmNUNcpfhd7yRWRn/fCm6xuayGvnoz64EspqjxwBcgwutFlkQhj/M1VwINT6WNw== X-Received: by 2002:a05:600c:470a:b0:405:4a78:a892 with SMTP id v10-20020a05600c470a00b004054a78a892mr1927675wmo.9.1700329356850; Sat, 18 Nov 2023 09:42:36 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:36 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Andrzej Hajda Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:11 +0100 Message-ID: <20231118174221.851-12-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52d91a0df..aca5bb086 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->algo = &dw_hdmi_algorithm; From patchwork Sat Nov 18 17:42:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745304 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c26pkZYg" Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF9A8D7A; Sat, 18 Nov 2023 09:42:39 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4084b0223ccso4619025e9.2; Sat, 18 Nov 2023 09:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329358; x=1700934158; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=c26pkZYg7wZk7k7hOdcwer2PiMQ+aEx9vmDbskTFccJmiaGulOx0kHQQDnNvFRkE2j 0RqbJfTrXqzRu9zq13dUtlzOjQWUqfm1kvsehZkpQ5TEbtfDt7Xqw1p52TNti7/Ls7Yi ByvEeVobYdCf331IFVMoffAPxXaKG/ZWNNt+8Z5zvQslI+Luvs03oXKrZKM+2h8Efw4e dRGemaHjI8lBupeszViRNjIAdGxoLyzDxRJOpNsYDM8X8NMYWrsGowERXtdAapXrYGvz MOifr3hcWgW53du7kb0eubh2hP8DZE9gHJd2d6iB0th0dXRBw694Du+H58SIpA+3cuDB rbIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329358; x=1700934158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=u5wKLurX3nxpI8vZhZZKOmSluaxd8jQCQueJDKIzfyIBg5/RPm2TkCi0Ms3PLXxcLJ 3EhOVGdRZ5hgGlUjDiVU7S+90SFElc+jzPjVlRSNyeW1tXrKWWC4Zb8tA8pTvFMtW3VX aMVT+5WRsqklbrnIDpIJshdLOLV4CBiPZWP/W6NSvsgHEjWmm6kkgkF/fqA0h32x3Vsc 1ECIF3o3gy281AXn5UTBHHB53Agvn6CJT3RISTsWK7V+lAcPz/pfqnOZSsOLEm0gQx0J UPCxlitEVQ/7oHmFl2CJYmgoBELFfn2SbeaWS4Bm5u5id5dYCbYjWVlaAl6ZfGE/KVWA 6Tcw== X-Gm-Message-State: AOJu0Yyq8qp0xOvsTd5ecxrumQAC3UC7mXTjWpjv7rvmT2t0GhkZ3B1E y1/A8e+o678iB82mNd61H+E= X-Google-Smtp-Source: AGHT+IE8c5V85RdvcwMzWAbBlQPGXZHeMjHZ0eSrzhGIJjdv16HbHYiNDOuMRSlBwb03Yc7GkrviVQ== X-Received: by 2002:a05:600c:22da:b0:409:136:469f with SMTP id 26-20020a05600c22da00b004090136469fmr2103392wmg.38.1700329357997; Sat, 18 Nov 2023 09:42:37 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:37 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Chun-Kuang Hu Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:12 +0100 Message-ID: <20231118174221.851-13-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c index d675c954b..54e46e440 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c @@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev) strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name)); ddc->adap.owner = THIS_MODULE; - ddc->adap.class = I2C_CLASS_DDC; ddc->adap.algo = &mtk_hdmi_ddc_algorithm; ddc->adap.retries = 3; ddc->adap.dev.of_node = dev->of_node; From patchwork Sat Nov 18 17:42:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745303 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZW5bf1VW" Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D260B10C9; Sat, 18 Nov 2023 09:42:40 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2c83d37a492so38064591fa.3; Sat, 18 Nov 2023 09:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329359; x=1700934159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=ZW5bf1VWQ1/6KGSJyA4v8XvNmEqmb/LmWSqeJlq0dhzfvV6Tsx6nywtBvTVW4ONyMj iC5FOzP8rlNRZhXHhOOKcJdI3tNus2IraGqm4fDwSuo4pnM7Vm206feWd+CYli9Eb3Mt P6pEqlwtCMcEmMI2XIIoay4KxWdEdmiiRO071abCDk9CHEEVgaPDyIW65Jb01tuKVZye 4qb7VnCp1ugWEcGIOdOrEV7Ba0G3yyeDh6YWafLGX1DNG+Zk573h6Lyy3n8w4eSDR9C7 D2Xl9phfuuVsud0wDNOsaOIQ3DpovBeepFq6k8y+IZct46sbL0/nOVmYlnXjxFv42bre a8mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329359; x=1700934159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=I4KdM8yM6yUEAxD7MtTRzjc7SOxZNFSpz3/bbmOPYLkFqSA9jxiAppMkXeJUFBLKED Qe0wTCaYQWDyXaFwtvxS/a7jaQ4xOBd6nRjYhz0r+9bmHf/d7hYmXLmDNVeUuMh3zOhN xauMXeUsE8tX0d42R+pXIpZqZKPea/hAePrMENSACg2g1m2yCptqRV4jYNid+1FPoYBI c87r8JRycanqfS1DZcbOZji40BF3qMM0IeAd6MT3ZB975qYR476fNNCJ6nLOyICXmspU mYCEmoIJd0XGfL01k5rfkRBZjPYI2RkBEmuujs0Yp+vCUwpHEZChR8ESBnW8GOUg09Py Yz5g== X-Gm-Message-State: AOJu0YzEoYv08E2IhUHtvvB8AFEBs8kGCSybDamVq5VuimM0tF4UpEnL gBG2nyx19+9OgKm5Kg2axT8= X-Google-Smtp-Source: AGHT+IEwInUOdyb9JTIvDlzQjDOqKv7guvhmJ93ahOLgFcvY/4Q4hp0zaJwgva0TXnWM4RKYhWoN3Q== X-Received: by 2002:a2e:80c7:0:b0:2c6:f0a0:8bf3 with SMTP id r7-20020a2e80c7000000b002c6f0a08bf3mr2023765ljg.11.1700329358992; Sat, 18 Nov 2023 09:42:38 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:38 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:13 +0100 Message-ID: <20231118174221.851-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, chan->reg = reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class = class; chan->adapter.owner = THIS_MODULE; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) dinfo->output[i].type = INTELFB_OUTPUT_ANALOG; /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"); i++; /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type = INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D"); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E"); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type = INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++; From patchwork Sat Nov 18 17:42:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745070 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U6X3mAMq" Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93DA910D4; Sat, 18 Nov 2023 09:42:41 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4083f61322fso4646715e9.1; Sat, 18 Nov 2023 09:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329360; x=1700934160; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=U6X3mAMqSzGUlR+br0BU2wV8ma1LrV1Ki0OToS28YHzf+a0ru8f+9JrtmIWnG/cHzF ejD5kkoR+nHksy2AoQ7c6GaZIgYz7d0wwgH2zv9nlCE5HcfUINUXzgOY+zY1yhzGUfqd KnWqZs6Db+VakbAS2N8hEEkHhYjLGVf0HZpET1ApRzZI1HE0rBFA4FsI8UTI76NCQiiH jaJMwsd7q87xq2iCJ2p22pNiiMU0cQIS5OYoRROOSI1bVd2vFZFIRSJydGhGCAD76Etr iID1Eoz8r0/eVPfk995gE5C0u7BV8b5xqsPRFPQ6YOisHSGhqXFOrlCB3cTjc4JTYDBS V1AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329360; x=1700934160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=rFtn4KPGsoxnncq0waTfEHPr3pdVkkFW5OcMqwlp3z62eFipWYi8fVP/IXfHRXATNh rtEdNuIkegK9yaH5kXFKJeWU9j3QGMR91Rse8BE+HX0k4fSHyUhQ9xhXVq1Z9CgdXJR+ 88SHMASpEaghU3QVPsQ7ZTqaZ7eRHf+W+Cs88/dBmTD9qshMIVaLoRn8MUZ4bT4zqD59 m/MSrCE94w55loSPjwPRP/jwJgIUPUh7vaY4f6op1n6OrbFFgWc6VvT/NxK68AH5dV3p LYyMYfVFfhdWED+U80EAyYikxQDAlGcdLCqNbk7Sr6qy5f6urhu6ocBI1qa7Lkpsl3+D x29A== X-Gm-Message-State: AOJu0Yw3RQgb5kW3uJtPwTJD1tdA5uwP3O7EsLrs0q+pUWQQWcAcORYG 0IhFv9CVrcGJu5ex3oiAyGI= X-Google-Smtp-Source: AGHT+IEDEAp2JxX1TrsPD+58kjm/UMuphpwbs1HtNIKAuhJlTjYYuA4bjSnwRduobt/RGzGOZOWLeQ== X-Received: by 2002:a05:600c:4f01:b0:40a:5b3c:403 with SMTP id l1-20020a05600c4f0100b0040a5b3c0403mr2242232wmq.14.1700329359934; Sat, 18 Nov 2023 09:42:39 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:39 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Rob Clark Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:14 +0100 Message-ID: <20231118174221.851-15-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) i2c->owner = THIS_MODULE; - i2c->class = I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent = &hdmi->pdev->dev; i2c->algo = &msm_hdmi_i2c_algorithm; From patchwork Sat Nov 18 17:42:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745302 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gJHfSzf7" Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C225A10DD; Sat, 18 Nov 2023 09:42:42 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4083f613275so4952805e9.2; Sat, 18 Nov 2023 09:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329361; x=1700934161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=gJHfSzf7SHa+hRLm5XImcbhng8GhNjNEGYAtxgzGbcV47g2AxA2LvzVJjfaiq/QFQ3 lsXboH77POZHUwM73s2Jjn+yZg64+r3tMbRuxShUMuRY8+PWOZQ0TbstKj+lEunlByi6 6cvryysQCABci7n8/PO9wdxf6JJcAsQC9N1WybQEhz9eI9AsvavZCLXGiActDtR58fzs IXn1UJOnLiq9ltnDL/zI7vu5l86vBobVrNnqLRC85ebzWcPhQoEYMcS7je+E1Luks+Li xTv+1yxIY60vKOb/vUH2B90xn3y4XZpcdpVewT5xqg6NR7rf/jycRiVK+Zli/L9FpWB4 xK1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329361; x=1700934161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=oNR6tQDdDq0jUela4RjFiJ4zHI07xUhRQg/k9/ERvzx8DkEmOt0awerVyJX5DAU8a4 lSAxcRB2GdTqW0fF6NhTEHUv3iUbPPAkE0oaE0VpyRGQIKpf0zmU3vc4HXJKhrR577ut TwGYE0tWqQBCr4IDubnCaKmyK3K6oQOvewVa7bgw5l+RJgmK/8OPGj7YYQy1mdSzQuYg damTI2VHLRM3EDsVwEYg3Uc/10nXdVcvd0jkUNX8irvkX9MKShHsYOdExBp7BVtBIgcZ +fK1wIzTkJn4t+GldM8vb2JePi9PCfjTlxLaVYfKF+QO9VF2EENR2Eie09yxmy2ClMSV 14Rg== X-Gm-Message-State: AOJu0YxZJxf2BzOWsyc2B3wMWV84NnB5dC+i3YEARMnW16E9jwAXNibn Vs3fTSX299LAZ2xClhWErRE= X-Google-Smtp-Source: AGHT+IEkxDeGvExBagSpF2r2LyZYIYynbcTphCNzYg+c+I50dSmhTAOksLkHYQ3bRD9pqUIHOvui6Q== X-Received: by 2002:a05:600c:35d6:b0:405:95ae:4a94 with SMTP id r22-20020a05600c35d600b0040595ae4a94mr2254158wmq.5.1700329360770; Sat, 18 Nov 2023 09:42:40 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:40 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Jani Nikula Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jani Nikula Subject: [PATCH v2 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:15 +0100 Message-ID: <20231118174221.851-16-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jani Nikula Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 40d7b6f3f..e9e4dcf34 100644 --- a/drivers/gpu/drm/i915/display/intel_gmbus.c +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915) } bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "i915 gmbus %s", gmbus_pin->name); diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index a636f42ce..5e64d1baf 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc, ddc->ddc_bus = ddc_bus; ddc->ddc.owner = THIS_MODULE; - ddc->ddc.class = I2C_CLASS_DDC; snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d", port_name(sdvo->base.port), ddc_bus); ddc->ddc.dev.parent = &pdev->dev; From patchwork Sat Nov 18 17:42:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745069 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bre9X7ds" Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E89DBD56; Sat, 18 Nov 2023 09:42:44 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-407c3adef8eso5431685e9.2; Sat, 18 Nov 2023 09:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329362; x=1700934162; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=Bre9X7dsgjthlFFj+Ve4LCcUUarXshJHNTg3IcKAmpT5T3GbwlikEVDqYTalhFlXtH MdUvt/inE6MCvhlGJND+GlDc2Tc//bnHb4Z3m9EODIUC+Wan97+uXalA+mg2+oU+Xy8y PaRRgb8FjugPmpeCSG7BgK0hcRiMLDZdhUCeu0piA/ax+ahbOe5nK2RNJ9W+wb35FDdo nWXuvKfRvNAuRIdlRfKb4Cd0/sgr20OvBKYq60E0HllYCKIgumPFh5EEPZRGb5xPQxkc 4r6HDwrEBTC0T+0I9qTyq+xSwKv8qDbHewoiPax8yWa3JVwYwnkJvB0dIfg0yljkQ3lW KEUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329362; x=1700934162; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=Sg/K0UCsf7ubNDPemSrOlaZz4m760vywWb+5ApGaCaJ5esVvgLZ42h5wdeTv79MlOW HdpDHjV/MJxvLMg1iM8GdMM6GkzqPYLtKVl9zUaunUCNR58i/yJVo5+spM4jUy/oPvZB tCvxi73Dh6fRe0ryb9xhoLYUVfJlM0CGikQ9JxKOf6PHyBZf82AtOGzx7H/n13uJ6Z5e ikon8F6W60JQPCsdilAznfoaeEe7vb69V2X4zpi46+DEi4TROm7HV1xmLKH0s8XlrwVJ i1Cq8JXcnr3DDdx6zJrD2UlctLw8rAsHZw/tzXskcXg4Jqm/aEQSbpUaLezM0lix5JP0 /6wg== X-Gm-Message-State: AOJu0YxrUs4p5uOyfFUWf1ottChM+hSDYDVS9+AcLOL2PVzX1VP/KZli jqHWdxfVzqrX13ypjosYKdQ= X-Google-Smtp-Source: AGHT+IGt7l6o5PwKsvFViCwmf1r0WoQMwWrQxBmVxuyxOMjlfRS4f3YKQ2XLunb2gXYw1covaoaGKg== X-Received: by 2002:a05:600c:468f:b0:40a:4429:a994 with SMTP id p15-20020a05600c468f00b0040a4429a994mr2234920wmo.28.1700329361729; Sat, 18 Nov 2023 09:42:41 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:41 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Xinliang Liu Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:16 +0100 Message-ID: <20231118174221.851-17-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector); From patchwork Sat Nov 18 17:42:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745301 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M/yAZAMX" Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F1781702; Sat, 18 Nov 2023 09:42:47 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4084b0223ccso4619605e9.2; Sat, 18 Nov 2023 09:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329363; x=1700934163; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=M/yAZAMXSLO6BWy6Iqq3wPJp5KeBz9v3vLFTXb/zPNHdxeTroHs5V/+CPt7HzBVICC tJwP7h0zmcGQHSuM4jSkg10VGqlGRJQVgEovIYtcwT/fiz4HOJsJ8OqWw2MeamaPTK/v fsnDyjHh5ZS1snvhLwGMuLL5Ph5OTEy76uHURYFthiNsIdrPyA1Pz/MGb2cuw+c78gAa NOF9CFkvvdStRE1Yrg753L5v/hJuVFR3PzUXmQvwjMT4CZfHlJ4nteWHYEuQd9UXZHof tsviM8qxDVsTTgVnwR1dvn1lj6u82n/sxMVkqdGSFcjUwj3izJgsj4qlpYg4G0q+fF04 VDVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329363; x=1700934163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=G1qdEAlcG/NQaktSvXwdKEKyNWLeoFrFkyhTP3RrFxPpfJ8EMH0JsPggABW7fcSllQ zJtonnv3w1EXVP6PkiYo/UeXnBULfknHt8DTU0V26fGvibRAMjduacGFdHeKXEpyR92a ORtG/R5ISFJY67wWP9eFJvDlD1GzwSchMu+1YwLZUwOdQ9h1bHeWfBs7d5N1s04cERWd bQm4F+c0LfO3uvfoEPwBjSrOmZOu38IyPLRHmYMHLxH0tzPre8eYQ+9hYXywv3urOfsd a73U0aBHBUzEzqu+pmHga5yGMRdRYplTaJq3y+bnEOJX7THfB7E3glnwZMyYHHVHImED aVew== X-Gm-Message-State: AOJu0Yxll8uUEv8vwGXb4raxByTd1BAtaRFX0AizBH73Ganyz7MvVOFw D7d2bWrMF76Q6GWdKR4PybA= X-Google-Smtp-Source: AGHT+IG/rpSoscDMsjiZahKHW5DKav0OGOlQ6bqp04xYQwKcY1sQ1AOt05hiLcK74Hz4Jvo+yXtCJg== X-Received: by 2002:a05:600c:3542:b0:408:3f64:6553 with SMTP id i2-20020a05600c354200b004083f646553mr2565974wmq.16.1700329362877; Sat, 18 Nov 2023 09:42:42 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:42 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Thomas Zimmermann , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:17 +0100 Message-ID: <20231118174221.851-18-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/ast/ast_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_i2c.c b/drivers/gpu/drm/ast/ast_i2c.c index 0e845e7ac..e5d3f7121 100644 --- a/drivers/gpu/drm/ast/ast_i2c.c +++ b/drivers/gpu/drm/ast/ast_i2c.c @@ -120,7 +120,6 @@ struct ast_i2c_chan *ast_i2c_create(struct drm_device *dev) return NULL; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sat Nov 18 17:42:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745300 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iO56adCT" Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF0721707; Sat, 18 Nov 2023 09:42:47 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-408382da7f0so5043895e9.0; Sat, 18 Nov 2023 09:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329364; x=1700934164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=iO56adCTQ6IlcPzaJrarrEknImjsxoKOsdVUfZoJ9mP2iKCIwzW1x59vSNnEscAl9y vMcQd85i+f9RoGQbyfHWLjldPJJ8svJmOTybNGyLDaelB3LTjH3uEammmfQdYxTbJw5o Kud1XLASqqsATkzAqmI4cudB61KY07VWz4qaTsLytxoRo2UVaqFUN+MYrGHg5tqhLJwg I3kctrQbIG7Fq/U9xuSPj18x7Hk5HJkdyvlS5dTM23DjexilU8GzK//A2FlhNAtShyBv 6DN6EjGS7CcKuamJyYIi/2LaieA7cKPrAlptZYFdYDVpFdE8CRPCtH6C/DorqAxcMRXK 6JWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329364; x=1700934164; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=SaY0d/pv3rHsHWSuPGplYwiboTQOApteqvG2MRyHr8fnfVLNM26P/Xjh3/r5+2g+NO Vi0v8zURp89XcM3xh0J0/i3pBihWs6MZHR7U2cf7+6r+qsD6UB0St6PeHdB7u7WsxpzN 3O4POq+9+qUH0Bh33OcQi5pervSTtra82/cHChw3jS/DY3hAWfNm1lc6s6CnZyrNYDTD iDZY0QrrwzbS0kJnsJL9fAcXABU9mu9jtuFTZhK204vQ1hqyZKO7Q4HTtGtPpo5xQFtx ItojZsx3nCPg8KPUniAu0k3DPiO2HvNC8A8bhCQdpYk2Okzweuj68RNQVPJRPMSdOT0S RhdQ== X-Gm-Message-State: AOJu0YzyCVq1ismXQstR7Beo6vzrBHX9rBPcMwpX6oneK8VhElv13GhL lb/jW4iG2utQg5NLWprhUr4= X-Google-Smtp-Source: AGHT+IE0BbMsvTSWTVOENdiMPkZHzodITfzmcl8KlNhZRnTozdLCx9oIUql/Zj2eZN+2ewtb0OZtew== X-Received: by 2002:a05:600c:198b:b0:405:3e9a:f1e3 with SMTP id t11-20020a05600c198b00b004053e9af1e3mr2171546wmq.11.1700329364007; Sat, 18 Nov 2023 09:42:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:43 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:18 +0100 Message-ID: <20231118174221.851-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner = THIS_MODULE; - intel_dp->adapter.class = I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.algo_data = &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus = &dev_priv->gmbus[i]; bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter = { .name = "oaktrail_hdmi_i2c", .nr = 3, .owner = THIS_MODULE, - .class = I2C_CLASS_DDC, .algo = &oaktrail_hdmi_i2c_algorithm, }; diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *sdvo, struct drm_device *dev) { sdvo->ddc.owner = THIS_MODULE; - sdvo->ddc.class = I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent = dev->dev; sdvo->ddc.algo_data = sdvo; From patchwork Sat Nov 18 17:42:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745068 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cPj1IlFA" Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B08331709; Sat, 18 Nov 2023 09:42:47 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4083cd3917eso4656345e9.3; Sat, 18 Nov 2023 09:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329365; x=1700934165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=cPj1IlFA6jAk9zvI9Fd2gxNQPCz1EcTKleiQXvOsABIucpRqxx5Bw+AiubRGof63yj V0obsl4pye97YLujhygqtobxJHZhVA0m/pxhHWql0NVfM7yQLztAidQE1WwhII/yHBUd o3J83i7YJITzqeUkSmwBf+bR2Db2j+6Ork7Meqc/wUtYkd2BhFxGyqvWyDEruNI25U03 v3iA/c03CIEs1nr2XUVJ5Sz58nfP/seUiK86lIdCUXSY5hqhXmH14SofhKsU127GvVPH d4fatJTo/UZ97qzX9A/jwVFYl3wDlP+Hr0hj/ejdwU67ZoJaNeLVhroBEyaRMwC03ZWo vs+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329365; x=1700934165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=ihKF/vC+35nV02NCHmvuMjYy7vDs8zwHCxd5zi02falfibsJhfH/2dfQTSvq/zZWQ+ 9naJbdcznx27+cuCuBWT3g1DwE/n5Ffh+jcVxA/MvKsN6frJ7WiCT20hhb4BvEJd5XsG qBfmF3YHwijVA7e0eowJxyY1xkoYo+gjSxl8ozTe0z5BISi2ZbNCtMx5wgzk1/xodOG2 ouL6+0JI4/0on7PjFkGnXHzso9/YQeJNKsdxPVRty1XJXV0TaDgJo+u83bGSodeDt7oL /q4VPiwLtpkAs8vEURZQqKGhRXBVqcvy40+CrIvozuBiRLtFKpces+X/n6j+75gpOvoW +WnA== X-Gm-Message-State: AOJu0YxElITbzC9K54aHCmnXaO8vd9/Ys3ldZLVjeHTjxqbonXfwmm5W 8V8unzfwuO9mEBgK1zKg/p4= X-Google-Smtp-Source: AGHT+IG1bPAOgl9NUb3ZPEvQdEyTHO+knTlvlp83e0Ttem8msHJ/hnBaJ5EBV2Fub43robL8FmGQHA== X-Received: by 2002:a05:600c:4ec8:b0:409:5580:bc9f with SMTP id g8-20020a05600c4ec800b004095580bc9fmr2199231wmq.34.1700329364830; Sat, 18 Nov 2023 09:42:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:44 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maarten Lankhorst Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alex Deucher Subject: [PATCH v2 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:19 +0100 Message-ID: <20231118174221.851-20-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index f3680f4e6..ac901f4b4 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) if (!aux->ddc.algo) drm_dp_aux_init(aux); - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; aux->ddc.dev.parent = aux->dev; diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 0e0d0e76d..4376e2c1f 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port) aux->ddc.algo_data = aux; aux->ddc.retries = 3; - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; /* FIXME: set the kdev of the port's connector as parent */ aux->ddc.dev.parent = parent_dev; From patchwork Sat Nov 18 17:42:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745067 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S345bEvs" Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C64DD61; Sat, 18 Nov 2023 09:42:48 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40806e4106dso2722565e9.1; Sat, 18 Nov 2023 09:42:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329365; x=1700934165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xoOuxVfYX3lHdi36PKjYbl3tsLm17OpynR1y+9rBRUM=; b=S345bEvs9q0MqPOtaAOcFjLkuKJYcZuBe9+JHYMUOJ/aidB/fA8FAwWff0YZn7Vld5 DAXfGYN1AL4uDos8ZAOjWGzbccx4ihr+ljiDm71OcTdhbptVH96J6eCudD3bpEBrlSJ0 rB+USljCL3nLz9tJ4oVmoo2IHVoy+pTPkjlFqt2MTk+BO2RAlivRgFB7udVuU3GoSCO9 Mc5O7zM/M31VxOb3cMOfegY+beqWdx7LnDKCqcG2eMwIOaESYwecQoP5dZm5pICuKDQq ceTznY3dSIV/VeKhfcxD6NXFNVUVlC+VRTnIW6pLfXWF4Qo5xFR4mxYt+FBUHVEZCPZv T2iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329365; x=1700934165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoOuxVfYX3lHdi36PKjYbl3tsLm17OpynR1y+9rBRUM=; b=XUNJdvD0BFcFJ5f7hGSqOserz6eraMqyNXI+7A8r2aotfeMQfuHdWoKpY5yQBTTnK1 2zBIU8BwZ0O6xkbR4MLxERYccj0J5jHuZIHb9mO6dZOVPNSuVoL0AJs97rfPqn6rzw9h QgAA7aYPu+gciCNJI1LawmTQLqhfZO1g3wdPqpY+oJX2AuiBkqSONccrMhPHjPgDC1AH W1w3X7GVP2+fJwWu217WLz/3ENV/t7CsH/PXMduov6BdQMFF/5AqCOxVh7RatTtntqod uO/P2vWUyrap+CKepFnl0nQDRjRjCb5+OMJiEUDbNw7PcOZhtzXzZM22zhXbypfqR89u UkOQ== X-Gm-Message-State: AOJu0YyZ+MTkA/RnrRk2pBMY9zAV9VumrV6axJ79gNaBEdMmkLti3dd3 PIO9S4JVbH1Wr8h5nWQOLNg= X-Google-Smtp-Source: AGHT+IEfGC11GbAgY9a3iwog8RZFBCmOzsqpJ0VCuNPTs77rF0/5JKKRTlqJUA+zSfuaII4HOyGD2Q== X-Received: by 2002:a05:600c:4f56:b0:3fe:1fd9:bedf with SMTP id m22-20020a05600c4f5600b003fe1fd9bedfmr2222060wmq.11.1700329365491; Sat, 18 Nov 2023 09:42:45 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:45 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , linux-kernel@vger.kernel.org Subject: [PATCH v2 20/20] include/linux/i2c.h: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:20 +0100 Message-ID: <20231118174221.851-21-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- include/linux/i2c.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 0dae9db27..d029aade3 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -850,7 +850,6 @@ static inline void i2c_mark_adapter_resumed(struct i2c_adapter *adap) /* i2c adapter classes (bitmask) */ #define I2C_CLASS_HWMON (1<<0) /* lm_sensors, ... */ -#define I2C_CLASS_DDC (1<<3) /* DDC bus on graphics adapters */ #define I2C_CLASS_SPD (1<<7) /* Memory modules */ /* Warn users that the adapter doesn't support classes anymore */ #define I2C_CLASS_DEPRECATED (1<<8)