From patchwork Sun Nov 19 11:28:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745282 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XPic1rlS" Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74E38E6; Sun, 19 Nov 2023 03:28:32 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9f27af23443so482242566b.0; Sun, 19 Nov 2023 03:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393311; x=1700998111; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=XPic1rlS9RsrsKZJxF8iWj/rxcj1dVksuJ84g9vtpLJduXR/w6ZL3LrMl7HPYnLNsg 0ivNUGoPYg9Ap3rfLedjyTnu7nceJ2Y2hjeWr3Gg3/C4RHhi411VjJ1PimM+AjMeJO13 UKqPy4DR9TIsbRNUtFV0D9nZlqbr0/MFnuk1ZRMLxAMjFaR2m5kN2eqM6Y6dYZTO8GG9 wXRWctqDil+98iwQpJkvxPDpub5OWG2DVxlZvfLrd++Z85Eph3AoxI3HHYEHBe7ztJ9i AxcmXj+WlxIEaLxtDNTBxwXmOltvCHN0Jmsg/IjRGioeEznhG5YXzhCfhKpBsVv7RgFn DaiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393311; x=1700998111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=TRZOkBik6YaQNib/e2N/npjsERDg7dBhmQDtqYWRfB9CHPwD+9EAzr8worOHw/LiTp ctoW2To3q66rIJ6XugBQSfGx+iXNk4vdSZONsIdiTksvHmfdZdJZ+0toXIDhM5bDbJGe UOPsh7i6nR9l4Rxh8iwlCdS7XvKqQvDxQgeMvW14tDaL1nCFJMXEcBpNRNMXPNeRY2Dr sRBO6b3NhQ/xNSaburjgzfezejawrOS4HiNqpTHNSCNC2TjIfMRYA9lwmjYmQ6zZT256 dOkWVxKxncADC/o8Y3DP/uIjICXZBFLgiMLfIGtngnJq5woSkSduM7ZdVx78GNB6ETfu rxSw== X-Gm-Message-State: AOJu0YyhLmVlm8wceuYoKFlWh6WWNXi8U/ZrGmoesJE2BKvy3cKG7MdX HE6p3HYjzG9cNSv7eeiKIn4= X-Google-Smtp-Source: AGHT+IHPtJDz6Y9TbEJbQOyBB/Oo4sosA/jONsRYvNjJizHcLos8hKdg2Z5bR3z0yhjciXL0cwqKOg== X-Received: by 2002:a17:906:309a:b0:9df:2fb1:1a83 with SMTP id 26-20020a170906309a00b009df2fb11a83mr3398055ejv.39.1700393310552; Sun, 19 Nov 2023 03:28:30 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:29 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sandy Huang Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:06 +0100 Message-ID: <20231119112826.5115-2-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Heiko Stuebner Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 6e5b922a1..a7739b27c 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index fa6e592e0..7a3f71aa2 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi) init_completion(&i2c->cmpltn); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; From patchwork Sun Nov 19 11:28:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745521 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jpgBkGWJ" Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C5EFF2; Sun, 19 Nov 2023 03:28:33 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9df8d0c2505so656999666b.0; Sun, 19 Nov 2023 03:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393311; x=1700998111; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=jpgBkGWJLNfEHGV59dqvMM5JpWunYMkuELAYzJ+EzVCosANHXSrjMN+HEc3miQtqbA feFw8R+imHJ9F4iEW401Q9LYPNbU0ylpws3xJ/yRMy+R+7mELyHEocNJLjjoHNqzHdRm kcL870MtEB0i1ekNcGYUN+jz5UfqFHQjAn/JeiA6ro0IhMkjzYCPwPuWaE29gD+GKm3+ PQgcs5iVE04kXphCjv4BqluPfTKZR94hD19hkuW5dg5mJS1TTAhvRYl3dl6rx2ju2yaK DJW0AP0lzpXhUTb9zaX47U/nSyK4D6bAshcHA3uQI4jv4hrDnHNOw7XXPjHDCvtQIVOt ibbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393311; x=1700998111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=Qqy78k5pLgZ2j1zoPrHW6d/nlY7U3nX5igSZSbk8K+3s3sQ8DBM6zTiw1SwUh1wdTo eMcDZVsdN2RwR0hsM+gsAUd0thPoDCoL2LIdND/JxG51s3AR1dCxyrxavD/hUvf9zcQT xTD5XWtDiiECmoL7+/aF3YQYFz6Ho+lhY4dccwv7sOPHfJ9ZtBSM4Avzv4UKzOMU3E0b PdQjQWqQduAsv7+oTSXw+ZdIJQaN6yd9ou3kvMVGREyPK9ZIWYBseVcO5CBar+GU/TyM AMuLeJ4yNzsLUPYUCT3VwNxKV9fCJta3SvwoIEM6uwMBW7mqsmzvPS9o0v0lY0s1nEaf FKnQ== X-Gm-Message-State: AOJu0Yy7+EH76OOvNZndic1fr324xI6p0JD29HDjCCDZTRM1uptf3oy4 EP+2wWOnToys8x8cABsXwy8= X-Google-Smtp-Source: AGHT+IEolPQnFux6ptEBdIgIWLfFvK+a9fTJaZAE2jvnmd47z8KPXEbmFvRb3A0Nnlw8LWex2IJNnw== X-Received: by 2002:a17:906:2215:b0:9a1:f1b2:9f2e with SMTP id s21-20020a170906221500b009a1f1b29f2emr4088533ejs.2.1700393311373; Sun, 19 Nov 2023 03:28:31 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Thomas Zimmermann , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:07 +0100 Message-ID: <20231119112826.5115-3-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) i2c->data = BIT(info->i2c.data_bit); i2c->clock = BIT(info->i2c.clock_bit); i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sun Nov 19 11:28:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745281 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cVy7E2Gv" Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8062D8; Sun, 19 Nov 2023 03:28:33 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9e623356d5dso473536866b.3; Sun, 19 Nov 2023 03:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393312; x=1700998112; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=cVy7E2GvU1UY7C2ylKxcRaKGbjhm5quJksSnVTY1dRmTx2n/y4LTSnrmQ3gphXkdP9 /+GjjsqHG/UsADL8fKfakE4R+0vmfkCFe53axp68BnOhXaOOgRc7d/v1CCnDESzKfxW3 dibBfI1qWpbmwuV9RD0kU7QaDo7+oMRTry6salcit72edkn0VEf6kwC4n2MfhWjr5ZBO Pc4QO/i39ahPGxhTPRjSJvjy8KB4v5rjNpH5NU+yUmDJQ4LvVhvPOD9pbBh0jlc9Wbqz wriRlWQc0LrLPGQOftJUiqCsbtzGJjKZKZtqeKInmSYj+VDq7/3b1EvubOEGlOShHpVp E4KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393312; x=1700998112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=OCQtfYH5T4sBdhIxj22qFENLm+EPMTbC4fBfbvt6Uwys7ZwTs54plX5KjTl9g8qXKI n5yZdsbY7uKp/mqG9ZthmDPLaox62vP8yxMXxMzPIlLTkerNYUdbDkkQjW5z3reuI8uB MkDvlfcRPR0DP8aT2e0rfHDksr72wNooVBqxNODGa2uvYrtvIAKpuWSVQESeC7IntKnv wNSHFXxYZYztwQG0Cc3bA4E4lwrMMZ5XUi09SGxol/P2KLE8K3GfIqy87K6xMxUmWyTW lKCCItmhiEqSo7fqEbvTqb5y/OamL4m9p0Vo+rOdAxAUG2pvEel8d6uuGPgd7YjzdzrT uwnA== X-Gm-Message-State: AOJu0Yy+Y1XD0pnusUehRCInJ2+Q6cylB8ckCM5mrSiFsUpQsj0lbd49 eWtyTJ8mPFdPKgom/JQbONE= X-Google-Smtp-Source: AGHT+IHCBymhmMkLDgf8c72aSm6rVzHfrFKwC46JDn+N6dKLAc0aMYGmFbO3t7kmKygycOOk6QrJ/A== X-Received: by 2002:a17:907:6d0a:b0:9a5:b878:7336 with SMTP id sa10-20020a1709076d0a00b009a5b8787336mr3794771ejc.7.1700393312239; Sun, 19 Nov 2023 03:28:32 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Harry Wentland Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 03/20] drm/amd/display: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:08 +0100 Message-ID: <20231119112826.5115-4-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6f99f6754..ae1edc6ab 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service, if (!i2c) return NULL; i2c->base.owner = THIS_MODULE; - i2c->base.class = I2C_CLASS_DDC; i2c->base.dev.parent = &adev->pdev->dev; i2c->base.algo = &amdgpu_dm_i2c_algo; snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index); From patchwork Sun Nov 19 11:28:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745519 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mZlvyuBl" Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193F511D; Sun, 19 Nov 2023 03:28:35 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5431614d90eso4906667a12.1; Sun, 19 Nov 2023 03:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393313; x=1700998113; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=mZlvyuBlW7GMvNyFJxq6yeqa5cl4Leuz+ikQEWTvNzeSCcK0on8gFi0vPdDls2YZ0M cpb3Gl8YQOSTgzpnGhXggHS8se9dKbX19G2XcMhQAmMqlyOj4VpGTs8H6/EkW64Nm2Y2 GLvCTIxPnn4vKePnXXSwXrmT5v5O4ELIec+BXRZ4NzH29bkJi6t4ccg6lVJXrgqc6lVA ULC1fC3RChxlSFwQ6yYpODLrbNjR0cxcEOFDEUDmyX6CLXLEnP+abId1/drQGqgurtFj HtMAMkpsaiM91row+3LHePQPuBd+TcjbAE23tW/dB5yiWfneDhK+g+bZIQuJv1qpBgqY ei1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393313; x=1700998113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=EE/wgCyZyfL6RPD+SqEtJUFrDyfpWg3efIzLDYKIbZoWoR8YkA+kym5snSSgRuquuK mIX8i8J825z280YpyF/OeMZW2CjX8mIpqAObirBFD3ixHGZD43WNsuRw8TtbW8BnvDQK oljT3IbnYgP/OfHoFzz2nv2mBEl5ViwbxhTIAveOQE+1Nl15CuV8lworqvdYqr5zC+J0 BUu0I/rcFv4KGYdMAWgEmH0HRITM8mp06EB9TLW5SGB2yvQykb6PrKc7d7t83ZplgKtR rCEkO9zKKSyOgbX9rK+5PBn4fZqBhfBiOoYVbN2ZFw4l1jM/+44Dfjj/kAgML9kuYjhq 6bjQ== X-Gm-Message-State: AOJu0Yw1oGyz9D1V0L6pNLXpR/JuCIgIGKMNbe5jU/Dz0Sh/SrtDaSgk CU/y9X5XrO2xAGgrK3/E48U= X-Google-Smtp-Source: AGHT+IGsco/wc6xKX5vo5lzmFcA2w842hBPgh5O17c6HmrxwSBPZRu/jKD563TwiQ42AUE9ZznEjpw== X-Received: by 2002:a17:907:8b93:b0:9c7:6087:49a7 with SMTP id tb19-20020a1709078b9300b009c7608749a7mr3289054ejc.43.1700393313184; Sun, 19 Nov 2023 03:28:33 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:32 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maxime Ripard Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:09 +0100 Message-ID: <20231119112826.5115-5-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jernej Skrabec Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c index d1a65a921..f5f62eb0e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c @@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi) return -ENOMEM; adap->owner = THIS_MODULE; - adap->class = I2C_CLASS_DDC; adap->algo = &sun4i_hdmi_i2c_algorithm; strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name)); i2c_set_adapdata(adap, hdmi); From patchwork Sun Nov 19 11:28:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745520 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OfH8qvfC" Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A50AFE6; Sun, 19 Nov 2023 03:28:35 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-53dd3f169d8so4670451a12.3; Sun, 19 Nov 2023 03:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393314; x=1700998114; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6DB25C7bMVd6OfgWCKQSEO94Aa30Zg5F+mwrgxtdXDA=; b=OfH8qvfC+y7ShrVdEefLlwn0YHgeAsUuvqvRxPla7vIXXXW62mvlaOFVeZ/GaSzKPD HEEvFyAaUYA6DgYCuzT+lIcG64sBJPHxnt8qLQzZYHvkEj+6tMIkP0FzmWajRCsx7QE7 eK26QtRmK6bmJr6mQyE1HSPXokDA74yHkfRE47P7TrHwZetJ+kIiUPf7lqAh5laSKXf9 VndFA1l2MJl0yG1AHKFitQT/iGSVqUK0OFMYqJ6gMyxi+4EFaL+uxx5AAyXs47DUpAo9 9IrtbSN86TtPfiUJ2Df2g9O3uUYldRGNbj5YHshNM6vFww3iGaogV6OLflW65gVq9oy5 rgXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393314; x=1700998114; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6DB25C7bMVd6OfgWCKQSEO94Aa30Zg5F+mwrgxtdXDA=; b=m8Obgs5f4PBZEWKJf6QKeFLvZipE0FJk1KTE/9gvXHD9AGzHpEutRAitPQGFBEwdyf jrTuGTqFzxkulqc9c/e64b+lhA3W5pI4vhD5qPn/JfBbIEaYc5ky2tQubGCvCq79Snjk hyQ3zUfjrygzTMbucWohtcBHoccUGR/zEXnbgQAtNu94xNsA/n8cJ22s9xhdbzFQdlNV hW+PLlDlZzMzFwjUVs3RaaJ+AbrZTRDuaNSEkjfTWevVJ2r/dM1mL7xFjj0hb3dYcE4L CEZl1V4t4ZxEol1WyP2V5n4dlkJNrOCVietN3p2zOW5h+gaH+qISx+ueicTC7UqJmOuE 9E+w== X-Gm-Message-State: AOJu0YzUG4954vFlZH2w9twgFceVp/PYvLk6XMl5iSELw9jZ1+3agy0m 8h7Vz9Qt7syWcb7J6/0iuiA= X-Google-Smtp-Source: AGHT+IH2fnvLE9Y6eVfFKztByCM9+1ZwApSr8kek3DtNxua0cNXLNxfmHPPCiBsAptA+rR6QXC1RVw== X-Received: by 2002:a05:6402:885:b0:540:9d0c:75fc with SMTP id e5-20020a056402088500b005409d0c75fcmr2974587edy.26.1700393313913; Sun, 19 Nov 2023 03:28:33 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:33 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Helge Deller Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:10 +0100 Message-ID: <20231119112826.5115-6-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- v3: - fix compile error --- drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/matrox/i2c-matroxfb.c | 15 +++++---------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - 5 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index 1897e65ab..9b74dae71 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -163,7 +163,6 @@ static int i740fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = i740fb_ddc_setsda; diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c index e2e4705e3..bb048e14b 100644 --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c @@ -100,8 +100,7 @@ static const struct i2c_algo_bit_data matrox_i2c_algo_template = }; static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, - unsigned int data, unsigned int clock, const char *name, - int class) + unsigned int data, unsigned int clock, const char *name) { int err; @@ -112,7 +111,6 @@ static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, snprintf(b->adapter.name, sizeof(b->adapter.name), name, minfo->fbcon.node); i2c_set_adapdata(&b->adapter, b); - b->adapter.class = class; b->adapter.algo_data = &b->bac; b->adapter.dev.parent = &minfo->pcidev->dev; b->bac = matrox_i2c_algo_template; @@ -160,27 +158,24 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) { case MGA_2164: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1B_DATA, DDC1B_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; default: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1_DATA, DDC1_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; } if (err) goto fail_ddc1; if (minfo->devflags.dualhead) { - err = i2c_bus_reg(&m2info->ddc2, minfo, - DDC2_DATA, DDC2_CLK, - "DDC:fb%u #1", I2C_CLASS_DDC); + err = i2c_bus_reg(&m2info->ddc2, minfo, DDC2_DATA, DDC2_CLK, "DDC:fb%u #1"); if (err == -ENODEV) { printk(KERN_INFO "i2c-matroxfb: VGA->TV plug detected, DDC unavailable.\n"); } else if (err) printk(KERN_INFO "i2c-matroxfb: Could not register secondary output i2c bus. Continuing anyway.\n"); /* Register maven bus even on G450/G550 */ - err = i2c_bus_reg(&m2info->maven, minfo, - MAT_DATA, MAT_CLK, "MAVEN:fb%u", 0); + err = i2c_bus_reg(&m2info->maven, minfo, MAT_DATA, MAT_CLK, "MAVEN:fb%u"); if (err) printk(KERN_INFO "i2c-matroxfb: Could not register Maven i2c bus. Continuing anyway.\n"); else { diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 589b349cb..07722a5ea 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -252,7 +252,6 @@ static int s3fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = s3fb_ddc_setsda; diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 22aa95313..51ebe7835 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -1267,7 +1267,6 @@ static int tdfxfb_setup_ddc_bus(struct tdfxfb_i2c_chan *chan, const char *name, strscpy(chan->adapter.name, name, sizeof(chan->adapter.name)); chan->adapter.owner = THIS_MODULE; - chan->adapter.class = I2C_CLASS_DDC; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = dev; chan->algo.setsda = tdfxfb_ddc_setsda; diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 816d40b6f..516cf2a18 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -274,7 +274,6 @@ static int tridentfb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; if (is_oldclock(par->chip_id)) { /* not sure if this check is OK */ From patchwork Sun Nov 19 11:28:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745280 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QO/WlsLW" Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5E94D8; Sun, 19 Nov 2023 03:28:36 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9dbb3e0ff65so466607466b.1; Sun, 19 Nov 2023 03:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393315; x=1700998115; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=QO/WlsLWhy46Ra/Qs3atyPrxHzx9yQS7nfygUrCEBwk+lT+3B+d5U9XAs+V/wBia3t rxBYcW3hQFWwCQSMPu04omsUA4/+kE7WQawGmDwUrZ/hJYHQd4BnKIXuLRfo/jNonHAq Y/50eQEaflrsLajjO8u1ZbAmw9sQKIVsIZGxzESi7HoKsid9IJ1zt6nD3/jWWfwsRQhq Fy+jVtRIQ2X4XCpYASY0IutRmjNT93ga3kC4NMzwi13pctg0xrlehs9HekL/p5bfhDY5 mK+O7xX0dbzp5cmeCYbHiIQuSLK1TnSwHDRIZ6hoAYYmzejgVoWR8LJBFFC7vw4IHEpy pHMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393315; x=1700998115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=oCeZWGF4kvtOUbdQDHflhlviDExR4fUGVqV+GXTHSWa+ScAUx5i87JkJkLFNRKJjRf 1fPHzqaOUuMcn1XG1CqMCR5/XPznWZhLrpp3L4337+ZIdC2mmUC1NfsrfmMhWswst/oE Ri0sD6DKlQvlcuPcjLTiTE+R55zehmzEpPtpFdjbfullogTRocAjiZ+OpzSzEXS6YdX/ dd7zGFlCjp00w179x8eqsIfoS9UsEbMs0z5ZlUTniTpo13bA7P1vAcTqLcvznutLHhvW 8cdS+idHyChrg9tuf/hGbbtoFGQKVQmBe7jVgHvQ+VHxX7ZyV2IBi+fRQDMbuRTcXlvS qnaQ== X-Gm-Message-State: AOJu0YxvXkf4+hfDp55CRGVxSinVkdg1oj3KuTYt/++AV68RRF4ti/Mi c75DA3wiNAcQPCl4/iVIbY0= X-Google-Smtp-Source: AGHT+IGjalgverwn4S+5/ObyVC+zY2/IsZIJGBRuqRZihGBcwWfCh8FC+wiaF3tbr+HAjd7T9RyHjQ== X-Received: by 2002:a17:906:1b:b0:9e2:af56:c380 with SMTP id 27-20020a170906001b00b009e2af56c380mr3594717eja.6.1700393314983; Sun, 19 Nov 2023 03:28:34 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:34 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Daniel Vetter Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:11 +0100 Message-ID: <20231119112826.5115-7-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/core/fb_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/fb_ddc.c index 8bf5f2f54..e25143219 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -116,7 +116,6 @@ unsigned char *fb_ddc_read(struct i2c_adapter *adapter) algo_data->setsda(algo_data->data, 1); algo_data->setscl(algo_data->data, 1); - adapter->class |= I2C_CLASS_DDC; return edid; } From patchwork Sun Nov 19 11:28:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745279 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZIHEUfjx" Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67069129; Sun, 19 Nov 2023 03:28:37 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-53dd3f169d8so4670468a12.3; Sun, 19 Nov 2023 03:28:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393316; x=1700998116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=ZIHEUfjxh8WbOt7CBeHQ9B8KAefwXqAuaSdr8gS8TOQcG6C0eE/ly7RzKNwleiHg95 a4VMqzMip/ycqa+28Y35rBR0RpLZwPkq6486YXBOXvA3Ck5OcvPqJYbjouy/LG3AFhKP wrGhEwLmkf3EuIiZMJKBSlglg57AU1IT9zGgfan1JPRQqkptM48jr7wwDXeQN1GuyNhf QGf+dFYnlPwZTXAsuiQ6nv0GbAmliQezCXPaBHS3O3YQSgvzNbP3Vhe1KIBCyYqntY+V 2sYxkXmXRvui8Mq9LAjhvyru1bBq5WnOs1d/Y9gEqeEBbV4Nl3qL5xfXZX2dZw4KHN4L eDww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393316; x=1700998116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=Xm+UfIMEys6QjPYC9drBAt2mLOekLa2hZxGuk35Fqq/oaHPlmxVw+TltgdyV5YaPBv YoOq85TzTa/2Ld4kei5fR+qnr3M8fqGY9WdwGe5EV99f6by9hLYGATZCTiEutElf2iVc FIC291cX6XFAykk8gtI2DVj4cQBBP/ASSxcsd8OYkCiO4DMaBQqnsRgtmVMXU5ePY2UZ 5ZaZfafmVy2adpvKdMcQUaq1QJo5CTaChmFymtRE08ndFa9tHdPGQ/NoGfTbtN5bLjR9 8lGNDbGj2wRPiEPypCFBX1QQBiB1WFOijNyMlHJ3MdfRP2J0rO/aJ6ldLnVJ/lx7S1+w izOQ== X-Gm-Message-State: AOJu0YyyyZ6FXS9no9CQ7duYPCLDVN2/oHVwXMRnBkTbn8DAM09Ev8In QLwldXT/v9W+giOGWYLJBoQ= X-Google-Smtp-Source: AGHT+IHI2Q6G5KgXpMdvYcK+AMXMsl9sksekFidT3A1JwDhyvE5DtqVUCJVruR3PsUB6x6IR6xT6Zg== X-Received: by 2002:a17:906:74cb:b0:9fa:783b:c197 with SMTP id z11-20020a17090674cb00b009fa783bc197mr2843048ejl.13.1700393315790; Sun, 19 Nov 2023 03:28:35 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:35 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Alex Deucher Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:12 +0100 Message-ID: <20231119112826.5115-8-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c index 82608df43..d79cb13e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 314d066e6..3d174390a 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sun Nov 19 11:28:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745518 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OF8FpONY" Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34C13192; Sun, 19 Nov 2023 03:28:38 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9bf86b77a2aso469973166b.0; Sun, 19 Nov 2023 03:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393316; x=1700998116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=OF8FpONYZHEOx/jjiWm8SSrPA0CTusZ33hBQP9zwf8yE6mhLeskUmrs5oytVw2K4ZJ mBhNGeAex+xxZyY6gNPY/R6R3rxFNL1f7k1jE+HPWZgfHMga+kqF5WlvCHbgU2yEvnOI iUXnOL7f1W62O1yV2/SGbAEzEGrwdmIwhj8E/GdLOKXko87mNRmVqKndO7JS9qK+hREI 8H+ncP3n+SW1cv1+ZbDxExco1VlxlgR4NhXJ4UKdSt9LqaY+kWePskruEpuuUmp6vWoQ Os4QdfhBYfWIkiVEKbhV9havlA8PIcTVPSs7lbTpGs2JS0BB7jXKBz7lpc666fUYcJ+H IxDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393316; x=1700998116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=FcbBbupsFkhAw0KfyEpLY1FSmUbIfw+kItBvchSeNYVT7oG7KNMUpp22TfCZ1pWATu SywHTgwBG4ugLWaWgZtxyG+1YGcyYhKGmgUDyD87yk0XJJa30q3rWHbC/yTOXx0RJbaA wByFGALJUSMw7LeAOjCSN5shyNEm1dzefa7rPvdw/u8pWyL3bTKMFRSR+yMf7whphygv kdYGbIVZwo5G5d/s1z+u009R3Rg6zm1JrqaA8XLTICx3HfQs11T5m8Jf5MpcNcskDT6X 25FIGRiUXJ6c2XCVPGprKA0uSz1mO+6MOsUVqLKXW8fXxzIRyZHDVeigmPD2deRbv+kI waHg== X-Gm-Message-State: AOJu0YzZStPQbLdbNDRI40E7sMW9PYc8MdK4M4GAA4ymGSU/GwQI/DJW eAY5fN/cCzy8d0/booYVOGhHyR6sEc5NAA== X-Google-Smtp-Source: AGHT+IFAzJyXCJEw3gxpP4VAZc4O/kxe4jDCoc7MCgJsBx9nZyrHJVYwUkbM5vIdYXckmNcBLAEJ4A== X-Received: by 2002:a17:906:51c5:b0:9e7:2d0b:8c41 with SMTP id v5-20020a17090651c500b009e72d0b8c41mr3246047ejk.0.1700393316640; Sun, 19 Nov 2023 03:28:36 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:36 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sui Jingfeng Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:13 +0100 Message-ID: <20231119112826.5115-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/loongson/lsdc_i2c.c b/drivers/gpu/drm/loongson/lsdc_i2c.c index 9625d0b1d..ce90c2553 100644 --- a/drivers/gpu/drm/loongson/lsdc_i2c.c +++ b/drivers/gpu/drm/loongson/lsdc_i2c.c @@ -154,7 +154,6 @@ int lsdc_create_i2c_chan(struct drm_device *ddev, adapter = &li2c->adapter; adapter->algo_data = &li2c->bit; adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->dev.parent = ddev->dev; adapter->nr = -1; From patchwork Sun Nov 19 11:28:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745278 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hYKRM9O9" Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 421ABD4B; Sun, 19 Nov 2023 03:28:39 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9fa2714e828so160026466b.1; Sun, 19 Nov 2023 03:28:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393318; x=1700998118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=hYKRM9O99tjQmagsfGQf4vdehfOpCpAO2wBU55AgRlIOpp2LpvtWb1V+0WobaLifcd JXkNdsaDYVM24jqmdcEUKEsJB3kPOTwNF1jaH1LURfpCHZDrdXXwlYUABXVCN7JVyYpz Fc0VWK1kqn+2c+IndaQ2JnkbcIQs0LAmoBDoiy+59ZQpsBiNDSAUr8KIDBO5lEwPQjIl sp435aaN9X4UOet/P8DXCeopdi4IXXjT+JAiU+CWHpflS247AJ8axMi+n6r78P5oS4tE iAllEzArJW8/zO1BIpnQZY+zgC4Tvle+XCU07vH3N0lgd81YuBR+9IJxxDGyKcqiN4Bi WTmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393318; x=1700998118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=IahFmxLf6hmigT6k6+onztfhdm4ZQcDXLEheEbQB+mHWq9zRphDb5lgmlcMccSyiZj oh4dE432T94ms1VncpcmCQ+Nh3wgsNWGNMlcOSh8M3pouMwiwzTKD0CIO17iX1kE+UG8 LcjlWT25wags4gepkVnf49vKRyeYDZhwNMevcbWx2S3EcVWBN18cyuvfHDoAWax9jMEA DbGAv639iM0rKdpxZ0oMzSaLNce20pWyCewxMTk03ZTcQ5p7WdL7QyM4JU1bHRBn3zg3 X1BZ/j5Od+8b2cEh9/U7oo52qJfkkLKyqX69IDA48lZUVQ/ibQIEi0OFdw2f7E/is+CO v6BA== X-Gm-Message-State: AOJu0YzTJ6VdMuHIhGQ/AW+QmRq/PtvWGj6qtxn1qiyk3q59szRYu4Z9 nHYyTXSVdvKOC2Ongq3LK/Q= X-Google-Smtp-Source: AGHT+IEnmNpCAkcRrOzwrSosgUk4OeD4St9qXEp+f9gvbMOTGQeLWy9ztO80popOTUrnH8s4A6uwug== X-Received: by 2002:a17:906:520b:b0:9e6:38f2:8439 with SMTP id g11-20020a170906520b00b009e638f28439mr2984313ejm.60.1700393317363; Sun, 19 Nov 2023 03:28:37 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:37 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Florian Tobias Schandinat Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:14 +0100 Message-ID: <20231119112826.5115-10-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/via/via_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_i2c.c b/drivers/video/fbdev/via/via_i2c.c index c35e530e0..582502810 100644 --- a/drivers/video/fbdev/via/via_i2c.c +++ b/drivers/video/fbdev/via/via_i2c.c @@ -201,7 +201,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter, sprintf(adapter->name, "viafb i2c io_port idx 0x%02x", adap_cfg->ioport_index); adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->algo_data = algo; if (pdev) adapter->dev.parent = &pdev->dev; From patchwork Sun Nov 19 11:28:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745517 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T6ESpNBD" Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AA73D54; Sun, 19 Nov 2023 03:28:40 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-54394328f65so4735711a12.3; Sun, 19 Nov 2023 03:28:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393318; x=1700998118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=T6ESpNBD+BilFiIBbXODWPBXtiLXQMhZzVuKaBd4gsf7x9fV0hvxf+mG8X5+pv6C+l lECeXi/AY/DGrslulZtqbJN6S5AX5sOBdZzFNdFDwykwav8AMNkeyDhOCNmg2+tWdv7b 0tOXpbT/HVBzFuRveR5+UjN6seaFsJ76Z4MSeiZD4ApDKUwrlNU9yzR0MxYt8hkEAeLP 6hjqIi3/2mebqxFVxdXGdHORfMxW2ax16vX+jRi4a2IUtnO78tDt2mIXksZxCLmqBfYA iyZn1KKpiIykU786No+AVEn3tosgoXJMJlX/nmsXhHBTOOaCss+BHk3HCGb7/8Zps9WQ bDAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393318; x=1700998118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=rodd8xXFJvy/fZgkLpyk/9DjUGc6XMwWGT33JrFm938KBCqX0wU2+lV/TVe64ueCRw MkhigGWTU247fKMr1Hzl3atpybmVMg9wmyZKYHpTo9zTM//sM5ScSW9Ui6KZ4eD0Qedb VGz+5msz4sMoYaN1Z88uhaD5KBLgtxsXOZgU/0WrV1dFSfpfo8BZOxreNweI3zYjf4mE +A94y3TEUkapFl0f+YCBQ6DEqbVEFBydPV8RY1+CJlhHd7m3hSkDIAt0Z/aqltNkJHLI P+jTDgzt0l/HuRbmwuV6ziTsvFYwEXbhKRAGD1/rP3Mn1QUqkeL/LC21FQ1vbIFeKTd7 hW1Q== X-Gm-Message-State: AOJu0YyLUB8rvm4EgaH6M2fIkCNz4TjmqH9+yzAOVn2uFjzveCXS/KKh X+4aMEXuz1nrauTxX1fFH/E= X-Google-Smtp-Source: AGHT+IFZggot9AqS3X6Qt+Jt5dcuKalJ7+U5FRGLkcM87LKer+UjD3CjY5GltxnAdA4qRjb5SMpr7Q== X-Received: by 2002:a17:906:10cc:b0:9fc:1236:beff with SMTP id v12-20020a17090610cc00b009fc1236beffmr1696210ejv.65.1700393318307; Sun, 19 Nov 2023 03:28:38 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:37 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Russell King Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:15 +0100 Message-ID: <20231119112826.5115-11-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/cyber2000fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 52105dc1a..79775deda 100644 --- a/drivers/video/fbdev/cyber2000fb.c +++ b/drivers/video/fbdev/cyber2000fb.c @@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb) strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id, sizeof(cfb->ddc_adapter.name)); cfb->ddc_adapter.owner = THIS_MODULE; - cfb->ddc_adapter.class = I2C_CLASS_DDC; cfb->ddc_adapter.algo_data = &cfb->ddc_algo; cfb->ddc_adapter.dev.parent = cfb->fb.device; cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda; From patchwork Sun Nov 19 11:28:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745277 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KODpKWh9" Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3FF1D5C; Sun, 19 Nov 2023 03:28:40 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-53d8320f0easo4884616a12.3; Sun, 19 Nov 2023 03:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393319; x=1700998119; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=KODpKWh9IwFZL6jV1FkUv0prwqI5uIO94zxFgHtu35xD2/LK8aqx9xQu1t4+OKX1FU EWNBgzayIbQvzsqsqs4jx0OV223e2LjC6TDjm0UqqH2zYySoXL4cOLSCaLJCyXGm7TjZ C/FZmljZDX5dYyoCFY9TMZs36V4lpVyE7vfIB+IGj8+v25mzwHEe3dkbIzCIJ4AmT94A yXnK7UDxGxPw+wEy/WWRqvrzJfqIVLm1IYQnJwlGogQxU3drhw6F0B9+IUVcZFaGqg/o 5Nm+5xnckVLFJhbFrbbmQTgFhB37JuAA+yeb9ye8nw2cOHTqlWsLEq6f7K5I94FlJWGF 7ruw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393319; x=1700998119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=LMz1R9geGFhefxIKnvK+t7Hfz2SWiGsSCr8587DG1V5rvtI2U1e3UBQ49YVirvC9OK jZVzFVRfpVqXM6P2ZO5xAQovN8XNKv+lrHxPGO3iMDgmqopSEfsgF1nJK1Afr8zkCn8P rVaYmujce+U54eNq5Vf4USNlq4nUpHEs/l76NY58YXXghUtHb47iSDZC5Z2PnKbRoZZu Ig4vcpoTQ2MA54BIQ6fryzI1sheK/HuoOieaHdhVFuBhD8qlCA/LmKe3/aJlvHeZKp0Z dvMRox7rB4sibX+uUWwq8VWau1xc78lGKuo+i949IPdyW2xsI++7rTDVKMsvLAMaRS3y sQbg== X-Gm-Message-State: AOJu0YxVSvf05o7O3IC9xsfLY5CB1zpXL5jjTRFDQYF1o6hwk/o1fizv OWuhuOG2uQJPreCyIpFXBrw= X-Google-Smtp-Source: AGHT+IGW8bdZ2RS0eD/PKhlU2KiBuoc9GKfQcR1+tjuS9TfpWDLNx8Ift2fVRfhA8+J2YatXx72CBA== X-Received: by 2002:a17:907:3f8a:b0:9b8:b683:5837 with SMTP id hr10-20020a1709073f8a00b009b8b6835837mr3412002ejc.46.1700393319210; Sun, 19 Nov 2023 03:28:39 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:38 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Andrzej Hajda Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:16 +0100 Message-ID: <20231119112826.5115-12-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52d91a0df..aca5bb086 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->algo = &dw_hdmi_algorithm; From patchwork Sun Nov 19 11:28:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745516 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hptP+jIN" Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02261D61; Sun, 19 Nov 2023 03:28:41 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-545ed16b137so4712227a12.1; Sun, 19 Nov 2023 03:28:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393320; x=1700998120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=hptP+jINdt6iLG3JZ5XTCKrrR85ub3oeba6+pQqzIHRe3GuB1A5PasGMgtxPbytOx7 mvhHT+njmKxo+YY7eQxtAY//fOHBWwBGeYIoqbreVIp/eWOQV5XshaKJ88Bw6s9DgY4j u77EJOxIUQ27N7MocJjP7phC4ZtCIAjkyGmqVnQKWrEnLdeQuLOcKHOFdEKzcYrWvhJD bQLe830JxrazWpYqIOmDhax278abiOiOFWKUU+xOARVARIbpunsTKTTwg4ffKi32JB1l QDy9TPNAG0uhZw6+lBQsQWQ3mcUPaIVFEhtq62cvvylms6kWX9ydM6TOiMMizakOjInR bF+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393320; x=1700998120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=R4Tr20nJBxPdl/2n4slYUPdzUIhkzQNRL26DKUTre8UrFgvIEC115dmvRd2Por0qEM Qq99Ude9sriiwikFCwnLP6St9Y2wQOP26D3+sgmWNZqNgMo4Tu3gnz2esXadCdXUEOqN MaC/Oea6MZ/nq4BgPzF7KjITJjHXR4GEGG1lhKW5xLeg7rWlpCC+aGSUAOg7BFyOL093 sXnYiQrvb7AJYcXHFLtHIbqTnYm4g8MGAswvan4j02u39Hd5UGMkBduZmqHwauWqWSCw AdqEqXVgLlI0tVyO4sZ/UoS2S84/1zTV8P1Ww7kJgPjRI81chdrdwNkxiWRu+yIXI77Q 2pUQ== X-Gm-Message-State: AOJu0YxAQ9p/5R2/WG6/acsilRAWUUI5M26J7HEbGQ0+1vG5vSrDiYze 6KSNHW6updnB/eB5AyEFy8Q= X-Google-Smtp-Source: AGHT+IE+w9pgQvDl2Y3wxx8qGfyopeIAjzUYE/Lxfmit0zeTDVBO1PBeuPJks8PhZkZ7FJV0jaU+YQ== X-Received: by 2002:a17:906:7396:b0:9fd:8da1:5c9f with SMTP id f22-20020a170906739600b009fd8da15c9fmr571228ejl.15.1700393320105; Sun, 19 Nov 2023 03:28:40 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:39 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Chun-Kuang Hu Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:17 +0100 Message-ID: <20231119112826.5115-13-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c index d675c954b..54e46e440 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c @@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev) strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name)); ddc->adap.owner = THIS_MODULE; - ddc->adap.class = I2C_CLASS_DDC; ddc->adap.algo = &mtk_hdmi_ddc_algorithm; ddc->adap.retries = 3; ddc->adap.dev.of_node = dev->of_node; From patchwork Sun Nov 19 11:28:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745276 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YrfThuXA" Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAB84D65; Sun, 19 Nov 2023 03:28:42 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9c603e2354fso655277466b.1; Sun, 19 Nov 2023 03:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393321; x=1700998121; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=YrfThuXAeUShmEjxj61tmH0kT5nCZyzp+ByN7NdfTXr4QN5tmUAcc3P2Vg2h2p7HaI R07ak3B+Ema1bIbDUfAsW0p0yKDELKUjPbaUiDPxSdsSI9D0xO8gGxYMHT2KRLIMkNkr lZaeAe8/X+E+UxwQCfRjh2UjgCsa85rxbIRRQH8CZ2wg24UQtLHvbdgAZW8k7eqnVFvk HdiDE4HwrDMTVgXgACicPJZBoZdkDDqozOp1LGFoGNuL7YlWPwf8DuXvI7FF63OHL8RL uTivVnYASGWj1kP+z6h9RNpfiBJtFJCWL7XvW0JAjfawGcJyC1p7a7q5tcHVFKwekmei e0Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393321; x=1700998121; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=A7ziA92w+WQ0Nj0QWaJJ2NjgoGqQXfW2vDhyzvKovGobcwOeDD9HWtGEoU9i/GEP2y v5V5fWMQtHpm+m2yxQfZPZ/+gcmArOctUGCurJN88lpQrxVBX7My9l69y3FI2Nf3Pmx7 xBmNNCwH6aFHI2HAqnXpNzsG4KCLSQ7/aPFF9ThxkoHx98M167GMQ35qau3CABb9OHHb y90BjKXBhiA5zDJrNdRhDgKEWSWvF8L+sB7+kLAQcTmktdZgzmUJ7ubWOJqwOiBEHJHS uZR6Tywae8XEqA3Pcuog/pRcpRP2hSStXMnVmb3YZ7az8k0N6gTO2ioCkAHKfe8E3yUI y1zw== X-Gm-Message-State: AOJu0YwaK6vEdYmpLmJ2kfrKk8Mbi8oTOV3wTUfV9cOopT/JkHIi9etW qDyaUEzQz9FiEg1quJqQDSgJNlo8uGtXHQ== X-Google-Smtp-Source: AGHT+IFOQx1CLu4gRyNAZImWfbKRXYxuIkAJlM3SnSjaoqSkAxs60CqJJdA60K/QCwcTb894UlOqCg== X-Received: by 2002:a17:907:d21:b0:9f4:1bd6:2d26 with SMTP id gn33-20020a1709070d2100b009f41bd62d26mr12971501ejc.0.1700393321074; Sun, 19 Nov 2023 03:28:41 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:40 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:18 +0100 Message-ID: <20231119112826.5115-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, chan->reg = reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class = class; chan->adapter.owner = THIS_MODULE; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) dinfo->output[i].type = INTELFB_OUTPUT_ANALOG; /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"); i++; /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type = INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D"); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E"); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type = INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++; From patchwork Sun Nov 19 11:28:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745515 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Clx4z0E8" Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1A17D6D; Sun, 19 Nov 2023 03:28:43 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9e62f903e88so451517266b.2; Sun, 19 Nov 2023 03:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393322; x=1700998122; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=Clx4z0E8CoQF5EKOlW/9+L2J742/5lMlBEEpbMg+5c2MvLcSMOj2XzqGYraXCMrHXy MFszHM+Wl8LSACOlC31i5Il+k3M+Ax4h/aCjybCvXewGcM00urY9gU5eGLVMmbIgdsdb fVA6VMpz2DGrNx+5tLiwLii4PwFzgu+FEA0Ds+CuoW36x3K8MQq1MaYxFJWkkFGx5Nen hC4QkWykI3H6bgRdFS4ueYcSbA+tpdXAGY5Pzc3lF3mPUzXr1cA7DNtx4W0Hwhcr8i6q 0orA5JfrUAKHZT7M4MZ6g3zJxvuS2fOr0ricTqFptjEHbo8KJh8/cCR6B+iNxpjbzR53 wTQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393322; x=1700998122; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=C/pJ3eYLtRv+GYXj8gnFAWDk8UD5kBjUnpTo3yPi6QnkJoAl9X3DsddgaR0EjFUpRo EQ1hNykpoZXoLOxih8avriApftVJyNUTLOZxKtFf/csq5iOK+ZDRGQmaGztqajYHjrG5 RawTMMwprwF1FWpSmGzQW6rNnqXIg3uCo+dANAqw6P1WLEXtfnMmJE98fS1UNxuN18Dt hAHpJzQ7T/ZD2b89AYuRTPVh0vWp0TEwB0cVJ21RqhaCNDgB2FKcpeTiurJV+X21U+0S QWKi9E6QKAVZUxsrYCAf3KNsBCzmWMCpvqfwbwr+ieJoJXOSp50ZeaomS9zbqbcUToE8 xvrQ== X-Gm-Message-State: AOJu0Yw8/fb8QhpaSPVdPKteBFrmNsrvbwUCa0dDmfBd5akI4vkNOAJB kWvvilzuU2cHI6nwVToB7o8= X-Google-Smtp-Source: AGHT+IErpTouVgXqlh3TisiJyv9Y7lrxQ2t5uB7O/C5V8sCHaKfqSNKhBvmGLqTZ7BYeJj6wkdbyzQ== X-Received: by 2002:a17:906:1099:b0:9fb:d7cb:6e03 with SMTP id u25-20020a170906109900b009fbd7cb6e03mr1924992eju.20.1700393321970; Sun, 19 Nov 2023 03:28:41 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:41 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Rob Clark Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:19 +0100 Message-ID: <20231119112826.5115-15-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) i2c->owner = THIS_MODULE; - i2c->class = I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent = &hdmi->pdev->dev; i2c->algo = &msm_hdmi_i2c_algorithm; From patchwork Sun Nov 19 11:28:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745275 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nr0bOBMc" Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51EB7E6; Sun, 19 Nov 2023 03:28:45 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-548a2c20f50so463692a12.1; Sun, 19 Nov 2023 03:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393323; x=1700998123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=Nr0bOBMcw3x7yEBx+1+tPww4WvLdtIfve1DRcHMZYniG7MLlJ47/jME494jgGvx6ad OIYEICa2bL+SdkqbOHC+wnjpMyMrg7fTw17FYws0NNy1beTZMB75I25E/3osHM2kdqCB wcKCZZOmHnfNIVPSdjINzFrXNpGFjx6+Ql3c8VPi0bhYsQ55+aS0Jy8hP3R7nULyZuxq p8WwMwnewtgNPrVP1/1tqvHWZBXPMa8v60HpkrygjnXhZssYtXtIceVkaIzlbwhhrycQ Laan7nhYlWMYv8607nngqRx5D7qROm6jJ6KZ9o3OdmgFjeNV7YKS8y2nEEKnXFhMbBMT 4BCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393323; x=1700998123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=RnM7OLKd80GpbYD+KdeXCuN0GSH33C0Xy5piJ2wPvq2B3fwNJARYJzdwAufcjpeVjM zdhVkpzcOOQ6k4gnXi391oxOTSMSCvfcAOg2P636uydKksDiPXP+wNbDvvJMmoXinv7c 4SFcF/RYiq7GreV4PMpzd9prM3n3ftzUrZVeMs1TLeEZUJV7OBTingRej1xd2H6EgeIH +SrIPwU8Fd42cwvCqg3lJYX1eBTrR215nYEn1d8WsxLF5aQEfpajINm4W94ZpftFv2AC 1l8unwhAjAuomOZX6ty+PX0v4ldaEA6DGZlhA1hJXNMKG7uTC3MD8CXuGKN64Gk21kFa keLw== X-Gm-Message-State: AOJu0YzSCkhPF56r5qrNS4APP1gz/cte6T1dLVNY85C78qRR7YW39iyu uFv5PrDGf+l17zLikakzcCab0nnOnXUwDQ== X-Google-Smtp-Source: AGHT+IF98s8aEn0w1sgMJYs8s2hcKMxZPSkooSx15XAU5tgESM/m3QK98+ws4NtnHf+xbrajq9DL3g== X-Received: by 2002:a17:906:1859:b0:9e8:2c4d:40d4 with SMTP id w25-20020a170906185900b009e82c4d40d4mr4394226eje.30.1700393322803; Sun, 19 Nov 2023 03:28:42 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:42 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Jani Nikula Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jani Nikula Subject: [PATCH v3 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:20 +0100 Message-ID: <20231119112826.5115-16-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jani Nikula Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 40d7b6f3f..e9e4dcf34 100644 --- a/drivers/gpu/drm/i915/display/intel_gmbus.c +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915) } bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "i915 gmbus %s", gmbus_pin->name); diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index a636f42ce..5e64d1baf 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc, ddc->ddc_bus = ddc_bus; ddc->ddc.owner = THIS_MODULE; - ddc->ddc.class = I2C_CLASS_DDC; snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d", port_name(sdvo->base.port), ddc_bus); ddc->ddc.dev.parent = &pdev->dev; From patchwork Sun Nov 19 11:28:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745514 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XMXLYofp" Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BB8C10D7; Sun, 19 Nov 2023 03:28:47 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-548a2c20f50so463705a12.1; Sun, 19 Nov 2023 03:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393324; x=1700998124; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=XMXLYofpTs4gBA9PYGUJgVYlpzmC0xTSI96qAH11s3ojGb+0KvPaCrn7GqYl0Fvyea hUpChstgVq9XdIotHdC1QuWSQ1wQDl2cxBSgI/rwYB/eGtBWqxRgxA7xS3jQVj+azKzi 5N3eHjn7L3JGHBdbRDJEyldMKXZV5ssiSr7HJwp6iOscJJtXdPIuxgXrj1w5gjQnO5OC alkpxe71bBdtl6zFLItXlffyXQzkbb+pv2mlaP+VAVEgKA5zF0AziqX0xtKCjsBMOR8j xffSJTedU+hKWH62cqirPt8htlcv278XNRgbi2dZNZK47vebro6dRAogG3yNOaTJlsJK HarQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393324; x=1700998124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=sA29QvRSVrAix6epP16/elx7ltvWcP+Z0aZq2XPQa9IEwyrvz5dYB5StpkmL93QjHC wXg9wqhZOpnz5hUn3gGuI3nTlYMeM4suIu3iv/Dd/Amgq+6TbWHOuHu0Y0Q4/0APA7Xu n4SxyqIUTCLSiA+cxafDPgMxtIFeRBl1tf2pPfvUu6+9vvotIHXNoBiqcojipl66moZK 3Ur/xSb+DkiHDu9OLS+bPETK77IqDkeidXYaRAU4XkWrmMmUtTIqeL/WyTTcJrOGURML /Eor0EG9FqLrBipQTK0XPeLXvNj+dhEhnJ32nAqbVfL8jEdutsyQL6HmMrWqFDcSZbPO N11A== X-Gm-Message-State: AOJu0YwqxWwXomdBEdKe99Kg0bXdoh/i5ZM7TvMRIIJK8IbYGszXYVc5 0ib6/rqXrTnh3FH9JqkHgPWO38M9h+GEow== X-Google-Smtp-Source: AGHT+IEvkXiyvHrlLOpdjdZVnWlbUgrD89NC8HGpVTBiL34yZJObBE5/8pr84pk4cSZoZHrmT9MXOw== X-Received: by 2002:a17:907:1ca4:b0:9c7:5200:e4f4 with SMTP id nb36-20020a1709071ca400b009c75200e4f4mr5046586ejc.41.1700393323809; Sun, 19 Nov 2023 03:28:43 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:43 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Xinliang Liu Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:21 +0100 Message-ID: <20231119112826.5115-17-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector); From patchwork Sun Nov 19 11:28:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745274 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QvyUB/T4" Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E88B810F7; Sun, 19 Nov 2023 03:28:48 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-53e08e439c7so4933697a12.0; Sun, 19 Nov 2023 03:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393324; x=1700998124; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=QvyUB/T4bkulU4stWcp9gggfkRjiqR+kiq0guBAXbDZJ9PTljx1jzadKjNf1zx5KfY CCEk6dGcQgvP6+cGj+FkPv1hWC/oKGqfZIO9tY8VstBYwrR9qd0EVR2JBu0Ory9Q8Fv5 O68EGmHfuCaZvyRescHiYEVbkJneBWLmCa3+PVCkIex1DphjGMqaA5hq426WwPM3jsqW 0wVrgsT2yw33QYlYb6MWPhg1UzTFdplI8I8vM0BI5rAE4KFYO12SvmfB+2hhB9ho15HN pkQj/uBFWmLXX5kK6XbLXVls0WLiNHdpdLIXFoAjTqnHHUURTS8KYvJG/2SFh4H27mIO wJsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393324; x=1700998124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=TiluqC6lYjjcbmATYkmEAIMYmRY31lIQFGdGtex7K/Qj0Jicg3QBBGg8Zvjm8CeZpA WJPveWtrANLp1kX+0eBlkTgbrbj4DUgklPFqmqpcCI8/Ws31bFyAOWhB2XGh0RqJY/7c HFPDnpprT1LXURAgxX2XGpGmhwGZesOtVGh05AaYqWwXgIM7IHlIe6LJbM7XeFobbnrE fL4IVuZOYW8JTxMOb/9NptGfPO7dJHim9yz9uOzJRRUFTBMqE+slnQ2oUZj2bOGqLqIA CwQV5MUkdj/PYBS/lDOUjfSEWuNPpsRKjS+wkmJFSHrcitPg+6JsQMqFpByBhZYb6Q4Y el2g== X-Gm-Message-State: AOJu0YzFUmMHDie6juxkkvuvJW19x1sHLrzdw1RYrnUNbQ7mwM3SuDw7 RhOTNg077VHzT67GvXwrEc0= X-Google-Smtp-Source: AGHT+IFb7FJqtaozsUjTf6lsnbfpB7UGN4+3ECKCKWY6V95FP/oQIeTwzIueiarO6eHMyVbgM8bRWg== X-Received: by 2002:a17:906:446:b0:9e7:3af8:1fd2 with SMTP id e6-20020a170906044600b009e73af81fd2mr3244286eja.58.1700393324637; Sun, 19 Nov 2023 03:28:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:44 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Thomas Zimmermann , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:22 +0100 Message-ID: <20231119112826.5115-18-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/ast/ast_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_i2c.c b/drivers/gpu/drm/ast/ast_i2c.c index 0e845e7ac..e5d3f7121 100644 --- a/drivers/gpu/drm/ast/ast_i2c.c +++ b/drivers/gpu/drm/ast/ast_i2c.c @@ -120,7 +120,6 @@ struct ast_i2c_chan *ast_i2c_create(struct drm_device *dev) return NULL; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sun Nov 19 11:28:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745512 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k6lcmgeR" Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D2D610FB; Sun, 19 Nov 2023 03:28:48 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9e623356e59so468896466b.0; Sun, 19 Nov 2023 03:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393325; x=1700998125; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=k6lcmgeREr5EjnCoxPGiWBPAcj/PIINnUtes0R5MvERFHzNfUiHG1By0ncxUzcENpt IX3/tjBRlbWzrNE/Oi3J7Tvsz4lBlCgJLwLXzKgxYsBuj1hx394Ky+mNT9z6CUVOEcvp VsNqtuYxvi9m+DpbzqSZoW0jnI9qdDNoGXXEGUJxLu6/z99KJ9XM8lxb4ls5RbwOa1lr cqBJ9S+xIGnOw4oO+A7gtL6uMAFUFxl4bMocdi1JCJmQM/wf9FEopMF1M93cO3lTpVSB xLQ4/uK/k1fjToyZsDHRqfhslhcvzCf7cMgtXjhc3vi9PyiBR1wnW1/XVLtWNqxHxbqj ZxZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393325; x=1700998125; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=VzfVlL5c/0mdIoL7LDTuMKDcaz9HNZr/KuiY7HpzOWHp2QBiNIsinnkGCcR/uFv55b VZdjmvSHTFOr5BHV+iaIWoLKkElc1mgWonvRuseqMEAA5Q8s3QDhOxYOK6c1MItoaOZz gF7rsypBjIHwW95OM0y1fIw9ODIqrvKmt2RC6WKKWJYMDnhDJUQezPLmgX0oUKWjmmHt e+0LL0bV64UC/tiqYZkiDE6lz+Bqeg732l8W4f9lVW/UPwPPNrFwGZNWU9sCy2f9Dz6S pOTXaTjX2yoI0W0ipGTzCHiZnsif6FHzG5DTswSErAA0T5irzySOO07sSxfr2Enl52D8 +u6Q== X-Gm-Message-State: AOJu0YyYye3OPeH/VIAMKJpPY6edDALJJs/wTrCmg7Wils0CgaJZ1HZS ot/YxuJMA/4aXlAkSzG7wgU= X-Google-Smtp-Source: AGHT+IEpB5ZnqGJppm4SyfFOjTFFzlNbJ5j1oKwnqCNhlB7TTiFFtmEVrL1Fkxgp4PWg2oSUQjk53Q== X-Received: by 2002:a17:907:9394:b0:9d0:2e6b:f47f with SMTP id cm20-20020a170907939400b009d02e6bf47fmr3500186ejc.36.1700393325493; Sun, 19 Nov 2023 03:28:45 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:45 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:23 +0100 Message-ID: <20231119112826.5115-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner = THIS_MODULE; - intel_dp->adapter.class = I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.algo_data = &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus = &dev_priv->gmbus[i]; bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter = { .name = "oaktrail_hdmi_i2c", .nr = 3, .owner = THIS_MODULE, - .class = I2C_CLASS_DDC, .algo = &oaktrail_hdmi_i2c_algorithm, }; diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *sdvo, struct drm_device *dev) { sdvo->ddc.owner = THIS_MODULE; - sdvo->ddc.class = I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent = dev->dev; sdvo->ddc.algo_data = sdvo; From patchwork Sun Nov 19 11:28:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745513 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W1fNgBpX" Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DA6E10FC; Sun, 19 Nov 2023 03:28:48 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9e1021dbd28so477069666b.3; Sun, 19 Nov 2023 03:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393326; x=1700998126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=W1fNgBpX/ahU7SgsIFClqJtLpSBkujxH5re2v1pqmEUNIKs8NMYipyw58T95Elxpde tg3YF5sduyAJPsa5Gk8wYE5eWUEG3pe1A4namyDoW6APse2R/ss+bTHR4B4CM/g5Glhk gLr9QU6s1s7z+jcShhKE614FcWUUMNOrtt0o3qC+7bKSJtVppmJxK3ivM9sWfxBp7p2M l8QxdwHxUjaWsEpWBWGA2GFja4JpCMjV+KLF7kCi9FhqXTPy1BaDAhAHUmo3I3Xr4R+g Mgod73gvFfuI6DM1cY3s5MMrPpME91Ta59XQUy7Tm0ho4CKJP3j6rX7yTpZ8LZiEEE/5 J3IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393326; x=1700998126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=PQpf3/0mgKmioDzjh8FEyoZG1dGHJU9UA4d4rKQLG3DqEo2E9oPYLd/s0MZQz7qWTS DaGugyZNqvDOs+uVe3mdpGpL6nyNyGd+E/W+3loCZyA/YXwenNnfrOkqFZoBYlyWafTz 3YiCfV332xuDI9FMrG5Nkkg0Ni+juLCduUF1iRBqoC5dlAaBK7cXZ854yKcuR2xxfMEo xgHFmbAkXgqPxFR9XQPPHidZK2mBZ7Hw+xRMebYZd3riMOwvAmBvsE1ZCb/56AhPvFQy bHuoGy8Un+L7kkre13HsZhNhazqBOpcu55neawuTUHBdRv35Y5autIdMjbMEpT6R+w6t Bnbw== X-Gm-Message-State: AOJu0YwVJcsDlLPWiwAbn2K+GuCEp1KgZV5CmQWI4+pQgt3nAny2mGuq kFuMemyhEX1zZThULMSQmQQ= X-Google-Smtp-Source: AGHT+IHKw/gC9gJLG/4vNKZ0Qe1xoAFlXwe05kjZcQmwp8jadVTM2Ill34LRBvmTqhTjC6YBAI0o8w== X-Received: by 2002:a17:907:11c9:b0:9be:30c2:b8fd with SMTP id va9-20020a17090711c900b009be30c2b8fdmr3210885ejb.66.1700393326334; Sun, 19 Nov 2023 03:28:46 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:46 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maarten Lankhorst Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alex Deucher Subject: [PATCH v3 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:24 +0100 Message-ID: <20231119112826.5115-20-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index f3680f4e6..ac901f4b4 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) if (!aux->ddc.algo) drm_dp_aux_init(aux); - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; aux->ddc.dev.parent = aux->dev; diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 0e0d0e76d..4376e2c1f 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port) aux->ddc.algo_data = aux; aux->ddc.retries = 3; - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; /* FIXME: set the kdev of the port's connector as parent */ aux->ddc.dev.parent = parent_dev; From patchwork Sun Nov 19 11:28:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745273 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DaKm0WFp" Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6355C10FE; Sun, 19 Nov 2023 03:28:49 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5484ef5e3d2so2689429a12.3; Sun, 19 Nov 2023 03:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393327; x=1700998127; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xoOuxVfYX3lHdi36PKjYbl3tsLm17OpynR1y+9rBRUM=; b=DaKm0WFpw4PtuyW50BcNwa8kUrDaTwYYr1CQlZAj9eJdibdWWJ67dKTENpbRoVTQpQ GYHo1dQY5j6Qihfxkbd/YzlEvMWeJVMomZUXC1qOhVp0mf9jEle6VMA6ZsbVToBKe3+1 mvoFxtOgHOJEkmL23D0aypRezsZRBsQoVX7CRn6xpJzJbSbgxRXLDDVfB2mPC/KNzeC2 imqbD66+H1e2N5DNuYTs2jTrujMQ9ChfzqVilgIp3vTjBU7pIHwjEappI42aJWeRuuJd KfBkPzF+Qdvt2b/XG0RbiBa8EjY30dJXH0OCHphd+pMxPh6DrGy3KCF+fQqbBz9/ibcQ Syzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393327; x=1700998127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoOuxVfYX3lHdi36PKjYbl3tsLm17OpynR1y+9rBRUM=; b=n4lPx4I3PnHPESx0UpnHmTgjrr1AOFFxyCMJATwaDIhMzoHJq9VZKS5YRRIZze8VvT SESZOaO10G3g9P9erl/LwJEpAOdXQDUGFI+dlcok7z/AbRZWyRFfxa95Y8mx6jbtyazU GDYfQE28Z8laPkNnA3+1aeY80HPE1iVUy2BcEXLNYea8a9OCb/dwd7yY95gZ22PWtrx+ mteuZW7f1WatSDnZH/WPV6F3Ee1WgwfbFEfji5F7jouLrZztNAIHJiRxY4p7z/G9nket QDtp+efIvMj7yBKOY98v6CMoNeTMqpzGTk4XhedspCHi+P/IxrAUtPWEHTl+Cqs8O5XA 6QPA== X-Gm-Message-State: AOJu0YyfOpvnu6Xu0F7xk5okZNiqm5lcweHqqyHio4UXC1jQfjwiRAzl gFLgA26w7mlGThivUTpdAJ4= X-Google-Smtp-Source: AGHT+IHfngVXlSW4LUIjnlkKJhW6cPwJdp2SIROIb9ruMWWShNHesG1OZE+QGCvwGdrnD4kqvy0Bvg== X-Received: by 2002:a17:907:2da7:b0:9c6:1143:b52 with SMTP id gt39-20020a1709072da700b009c611430b52mr4489746ejc.55.1700393327195; Sun, 19 Nov 2023 03:28:47 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:46 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , linux-kernel@vger.kernel.org Subject: [PATCH v3 20/20] include/linux/i2c.h: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:25 +0100 Message-ID: <20231119112826.5115-21-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- include/linux/i2c.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 0dae9db27..d029aade3 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -850,7 +850,6 @@ static inline void i2c_mark_adapter_resumed(struct i2c_adapter *adap) /* i2c adapter classes (bitmask) */ #define I2C_CLASS_HWMON (1<<0) /* lm_sensors, ... */ -#define I2C_CLASS_DDC (1<<3) /* DDC bus on graphics adapters */ #define I2C_CLASS_SPD (1<<7) /* Memory modules */ /* Warn users that the adapter doesn't support classes anymore */ #define I2C_CLASS_DEPRECATED (1<<8)