From patchwork Wed Aug 28 16:52:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 172407 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1038789ily; Wed, 28 Aug 2019 10:11:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqw12cVJZgD1ZoNMkarfYM5cl9AGnT1i6A7wivvCV9uouZaIAMQY0xfHK20EOMLWjMJTjKaP X-Received: by 2002:a17:906:f2d0:: with SMTP id gz16mr4081880ejb.21.1567012311439; Wed, 28 Aug 2019 10:11:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567012311; cv=none; d=google.com; s=arc-20160816; b=HDQOP9HK7Rx7Ze+9crzEqIU9T+nbyCSnuD90ROEORT+2HcjPKh5c4+NrvNetGc7SAy BvPHIGsT//fBxEVOZInr+gVmKHviu9lUQ4uwQ32TVmFajXQwkMjmDFbpABQ5Yilis18t ZKSV7f8SO8pAZzSjCwqxNeJJpgAWpKuhw8PZBlNKq5oEG7qZuYMYzvE5DMvUjat5zsW2 k0w4wI48n8etQ2Hm8qL4hvzfIoMY8eOSI1RlyOWLn6TW6H3ItHIK9hwp+g31cgx8uAnv pzqT9Akog54KAGnHVLHI0X78zgUj39aPEG9dlot2nHzIn7XdHKTGxV2TZ9hdbAbzlW8p CpCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=+VsIgRrN67nvrM6dUapwHSRZMRTN8JnYHQijkeU8PPk=; b=MYodTt09hoIboDVaWgGZXy6ZtfeI48hRenpPTxjkm0BIPMFid2vhy7Uu8ielO2++xK 0PBF0Cz4ayBSAcadfxutHqVZklOmP6LPWEP35SSWNLgz8DGj+jffptxzl6eATxrtrd5a gz29vv87A8BzzSZHrv/4JrHrMNtpzPJuFogpdrrJ4RixFgQt9exYp+kEgdiL7PWXnQAf R9NhJHLAS3HW+Ng7VY2tWZrHE5HSJjv+cfjRSydGNteB0+er1rJfs82C8RPBmsxnRZaK tJembBYvnKmkAMUyUjKR1Y1wj9OzGJSaXDS9oZavO+ZZ5/0Ey0pYkCBXG8NlEOa6lfhk Fujw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lCK8FqcR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v8si1569142ejh.248.2019.08.28.10.11.51 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 10:11:51 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lCK8FqcR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31U6-0001Uy-8U for patch@linaro.org; Wed, 28 Aug 2019 13:11:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42344) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31C7-0007eN-Gq for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i31C2-0000p5-Tl for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:14 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:36223) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i31C2-0000nz-LP for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:10 -0400 Received: by mail-wm1-x32d.google.com with SMTP id p13so811719wmh.1 for ; Wed, 28 Aug 2019 09:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+VsIgRrN67nvrM6dUapwHSRZMRTN8JnYHQijkeU8PPk=; b=lCK8FqcRx51jauPL29c8h2ZpVZ+o8lpBXnxS3n4EUFkrQXU2X2FXwu6cMwxOrkxl/9 M+ZVSrgojBpnjbjgNKDYTJ/KUYOE6qYK04ZykcpORYGup5T0oTMJgX3RpoJfPLt0xxj4 Y8moF3p7wFzxureUrdsr4S4ot5w5uqDt8GL1WVE14W/vqJQxdbMlzlaMHfQ5C9qlJ4P1 qm+2hdCKaCSfLZS6aiJjdFIEUebEOog6X21fZ8ddyXq5akBxgs2revDAi+AtbY4+NIdz sD32x0m/iF5uRs9pwJEVcNCy5GzVG8LZtb82I0Kzmt+IO4GH95bLgP+jnavVB/2Vhvdp xkpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+VsIgRrN67nvrM6dUapwHSRZMRTN8JnYHQijkeU8PPk=; b=MT9rHkyhRv/0BG3mIuAKQy0nJsFjyVddkRuTToD3YJDT1NoLeJAA5OW2/i67CBGau3 ycSwfJBm/BqFoL4JpsSMwOVy8mi//9KOyGEzW8I9P4MLdmIBLRQaJqKVh6APekD0645C gMZPf8xH9v7ppwPLVh0WIQjTh8U6HsAKs2QGNY6gIaACQawgr+1RAp4ROgi+68hmCpyh 1SPEX5iemFpomYsuO0ktvSZX5j0Ftqp0RCWOaHAUzgVzuhymDFfLvtjH5v6DKHganvS9 bbdws/Mx63w9eNFGHQ/bF+NlwshyVVn5wGG7D6B+E6xtjUEc+XTAiysGfSXSjEhB3ycI ucqw== X-Gm-Message-State: APjAAAU7bGQ7xs9nIVDEEvmSrr1qG1AWm0U/om5WCmR3keYIZWfh8JI0 EanWO7seuQOgVjOhsN7JFiDtBA== X-Received: by 2002:a1c:1a4b:: with SMTP id a72mr5066400wma.44.1567011189500; Wed, 28 Aug 2019 09:53:09 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id f197sm7699042wme.22.2019.08.28.09.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 09:53:08 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7D8541FF8C; Wed, 28 Aug 2019 17:53:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 17:52:59 +0100 Message-Id: <20190828165307.18321-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190828165307.18321-1-alex.bennee@linaro.org> References: <20190828165307.18321-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32d Subject: [Qemu-devel] [PATCH v1 1/9] target/arm: handle M-profile semihosting at translate time X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , "open list:ARM TCG CPUs" , =?utf-8?q?Alex_Benn=C3=A9e?= , Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We do this for other semihosting calls so we might as well do it for M-profile as well. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/m_helper.c | 18 ++++++------------ target/arm/translate.c | 20 +++++++++++++++++++- 2 files changed, 25 insertions(+), 13 deletions(-) -- 2.20.1 diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c index 884d35d2b02..27cd2f3f964 100644 --- a/target/arm/m_helper.c +++ b/target/arm/m_helper.c @@ -2114,19 +2114,13 @@ void arm_v7m_cpu_do_interrupt(CPUState *cs) break; } break; + case EXCP_SEMIHOST: + qemu_log_mask(CPU_LOG_INT, + "...handling as semihosting call 0x%x\n", + env->regs[0]); + env->regs[0] = do_arm_semihosting(env); + return; case EXCP_BKPT: - if (semihosting_enabled()) { - int nr; - nr = arm_lduw_code(env, env->regs[15], arm_sctlr_b(env)) & 0xff; - if (nr == 0xab) { - env->regs[15] += 2; - qemu_log_mask(CPU_LOG_INT, - "...handling as semihosting call 0x%x\n", - env->regs[0]); - env->regs[0] = do_arm_semihosting(env); - return; - } - } armv7m_nvic_set_pending(env->nvic, ARMV7M_EXCP_DEBUG, false); break; case EXCP_IRQ: diff --git a/target/arm/translate.c b/target/arm/translate.c index cbe19b7a625..259c4669b4c 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -10889,6 +10889,24 @@ illegal_op: unallocated_encoding(s); } +/* + * Thumb BKPT. On M-profile CPUs this may be a semihosting call which + * we can process much the same way as gen_hlt() above. + */ +static inline void gen_thumb_bkpt(DisasContext *s, int imm8) +{ + if (arm_dc_feature(s, ARM_FEATURE_M) && + semihosting_enabled() && +#ifndef CONFIG_USER_ONLY + s->current_el != 0 && +#endif + (imm8 == 0xab)) { + gen_exception_internal_insn(s, 0, EXCP_SEMIHOST); + return; + } + gen_exception_bkpt_insn(s, syn_aa32_bkpt(imm8, true)); +} + static void disas_thumb_insn(DisasContext *s, uint32_t insn) { uint32_t val, op, rm, rn, rd, shift, cond; @@ -11511,7 +11529,7 @@ static void disas_thumb_insn(DisasContext *s, uint32_t insn) { int imm8 = extract32(insn, 0, 8); ARCH(5); - gen_exception_bkpt_insn(s, syn_aa32_bkpt(imm8, true)); + gen_thumb_bkpt(s, imm8); break; } From patchwork Wed Aug 28 16:53:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 172401 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1020413ily; Wed, 28 Aug 2019 09:57:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqyL/mwfE4ZQv04p42+vHGGfix4aK3DD5UYK8vLajiaHFHtADd9QIcBIGt2+xyMo5cq5EYLP X-Received: by 2002:ae9:edd3:: with SMTP id c202mr4919723qkg.347.1567011479490; Wed, 28 Aug 2019 09:57:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567011479; cv=none; d=google.com; s=arc-20160816; b=ZsFbpRH7YXhbHEXERtNvsC750m9ZesXoGhRtZiIVdb7IJXTPyU5jjR8T2p0GEgEg4C G5dX/wuioKnC8it46GoxTL+utGBmMgs+GNC9czf6swz1bMYeWtReM+R2ZR1pnN1c4qH3 3RWIM7PNVc/z1K15+hB5capYjpKX70WrRMWKpQjfiF/sjFwp45W1RGpEErD14NISRv1D eiGlu2Qb6P+lsU2E79HnzBxagKgz2u508YcmW8sNRKy6uOlrxQ+0O4qnKMsWkMNilE6F Ui5FMCwCrO3PApDJF8mHshdNdUm8pFzqNzdplFWYJ6klhVBtuXZHTh2G/Egx/00FPiiN +aXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=AnLfjJ532pnrQLEmB2HlY+ej0qh5jfVOAVC2UPBUj4M=; b=Ko4scxnToUv66xY9N6AKt6BjN0zHqaUg9l9ZSU1+CCFTbUUM3/o7FlRQxR/c+vwqZm AGsA21xFifYgt1Q6RuJMf3UxT0cesv6eT7xKwlwYqJ5GPArRHj69LMMYNJMujGucS0Hu 3MGbC3Vewl+F1dvjOH0QoP+0ab7P7R9gfU+1t91AqP3uGPtH9OOSh400sr8YvW/xiDlS iJqvaDyrKpzb/MsTNBsTIaMJG4d635F2+uNngtD5pmsuXZ5+x9bzq6snOUZ6maYhrRJJ xvCwbwuKQxQ9KOwkVaRadSN/7hcWCKFhBC/bqr0NAGVgHMmqRZSpQz2bvABpVUqWlPws 46NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=WfbUbqj1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w140si1889339qkb.107.2019.08.28.09.57.59 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 09:57:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=WfbUbqj1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31Gg-0002rc-KB for patch@linaro.org; Wed, 28 Aug 2019 12:57:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42349) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31C7-0007es-HA for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i31C3-0000py-FR for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:14 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:40179) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i31C3-0000oY-4r for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:11 -0400 Received: by mail-wr1-x441.google.com with SMTP id c3so510795wrd.7 for ; Wed, 28 Aug 2019 09:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AnLfjJ532pnrQLEmB2HlY+ej0qh5jfVOAVC2UPBUj4M=; b=WfbUbqj16CnAz/CEkYfPWA1keOmaBBfTX527aWNTS/xEcaL+eD3EYrQ9F19uvOTOzV TbCT/0lqk0y1GvwYlFRJH5DxnZV3vLSNsg4od3tmoBWbxN2EKLLB7LL8Njy35/gbWY9E L7yF3+X3ViwEw9zgqX6/1TI3bG3mr1dY4PHcy1ako0BTgDu3GjpgL0xWde/e2VJcQX3D imJ3inP32Pzg8F2LQX55Yf+o7SrqGXKbNPOmxSZ3gX3/WAd7RT1bKQjIBPL8Mgn4XoAB FcRHoZkPtAtGqFTD2egFKK73uYhFDKaKOyQR1RDhmz1CraVk9EoeYIUsabELxkrzpkaJ OrZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AnLfjJ532pnrQLEmB2HlY+ej0qh5jfVOAVC2UPBUj4M=; b=PSrFxH1fwjZby6DjFO/DMFP1DYUBF9ek9jqCn2kXMJxzZ4+FsdqeupO2MIqmZssguM jvetFe33/NsK0pSmWwJEIQrH2P1rt0aN0sgm1Gu3XZZ6FxPooVZIY821tI0FuKebgYVn pAl19FgFUZc68kPb92Jf5B4Z2d4o9FBUvYc1T8APzrlnpD+0yCzRDQvH/RB9RQCCedSF ZQS3kNMekn58yju5+LxwhGi/O7N+12R3kQ+rPuGw/9xWpcBqdDmbUD0zfRGMAsu/7tbh 19F1N2AidHnxqEkJhJiaMR7VheFlMOHFZ5GZgb8St/jtFQ4xDomiup9aW0WFqsTTjNUl psTQ== X-Gm-Message-State: APjAAAXrtrZn201N6kEAr33nJ+vaDE5CGY9oksBGQlVhXQ3e4WduwIya GgmN3qlmK1rUr8cIurrz06I0GQ== X-Received: by 2002:adf:a415:: with SMTP id d21mr2253900wra.94.1567011190025; Wed, 28 Aug 2019 09:53:10 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id n12sm3391799wmc.24.2019.08.28.09.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 09:53:08 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 908201FF8F; Wed, 28 Aug 2019 17:53:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 17:53:00 +0100 Message-Id: <20190828165307.18321-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190828165307.18321-1-alex.bennee@linaro.org> References: <20190828165307.18321-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v1 2/9] target/arm: handle A-profile T32 semihosting at translate time X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , "open list:ARM TCG CPUs" , =?utf-8?q?Alex_Benn=C3=A9e?= , Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" As for the other semihosting calls we can resolve this at translate time. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/translate.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) -- 2.20.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index 259c4669b4c..6157e9f52fc 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -10907,6 +10907,24 @@ static inline void gen_thumb_bkpt(DisasContext *s, int imm8) gen_exception_bkpt_insn(s, syn_aa32_bkpt(imm8, true)); } +/* + * Thumb SWI. On A-profile CPUs this may be a semihosting call. + */ +static inline void gen_thumb_swi(DisasContext *s, int imm8) +{ + if (semihosting_enabled() && +#ifndef CONFIG_USER_ONLY + s->current_el != 0 && +#endif + (imm8 == 0xab)) { + gen_exception_internal_insn(s, 0, EXCP_SEMIHOST); + return; + } + gen_set_pc_im(s, s->base.pc_next); + s->svc_imm = imm8; + s->base.is_jmp = DISAS_SWI; +} + static void disas_thumb_insn(DisasContext *s, uint32_t insn) { uint32_t val, op, rm, rn, rd, shift, cond; @@ -11658,10 +11676,8 @@ static void disas_thumb_insn(DisasContext *s, uint32_t insn) goto undef; if (cond == 0xf) { - /* swi */ - gen_set_pc_im(s, s->base.pc_next); - s->svc_imm = extract32(insn, 0, 8); - s->base.is_jmp = DISAS_SWI; + /* swi/svc */ + gen_thumb_swi(s, extract32(insn, 0, 8)); break; } /* generate a conditional jump to next instruction */ From patchwork Wed Aug 28 16:53:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 172406 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1036792ily; Wed, 28 Aug 2019 10:10:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEblDNkKnnJUTLnohQ8spFB2oxvpssx+ESQ88TnrJpioo/3whh/lHSfESsz62TmBeuztRs X-Received: by 2002:ac8:3d41:: with SMTP id u1mr5200783qtf.85.1567012220623; Wed, 28 Aug 2019 10:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567012220; cv=none; d=google.com; s=arc-20160816; b=A/OQk6iWZYWWT26iyPFa4yr6p8XsJMMOIM4FsRpReSYRlt2EZiRT2UaoaFhCnS4flh d0x/RzLLnWU7zjLyq4s8T/G6uUsUANgN7xomGRTG2PaVZAg6gPwxryQm8biTj9VQvF3G tUoqUEnJyKzOI5KbRCFygCdkbbA1zdH0y4w6tmmf3vWeba9Wqoi1AG/eEqWzvrFalQVg Lr9lqIdrLZUOdnTuCZhPkhaL3oIBbvmoNUg44tHqYsZPDcYe2cTMw+mVVI7lTQjdfM5h EwouzWf3rYWqnQtff1hwHQMYpfDI1MZMDiEllofuQfgfrl3/fc+7GC4bT9Z8I7B8W2Ux psZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=b97onG7/lnQlcwo4RqOnNFf+XJUP3+kZkC9XBhFAYJI=; b=LB3Yb2Gi5tD5x6ID0lBZcXdScVtvB2zr71ZSI5Hznl8PM7Jf+scYD/j9ihuale4YH3 b9vBW4XBwTgYHqY8andAk/kVue8M3luBV6mXcl60QWEVIZ283B5p/EIT8hBt9biPhyHM G18nxoPcPf1o2tj8MvKA/G1Y9nK2GMIOxoJKb4OB34eQDfdG0xqgHi7SlT8SulOwzUK9 4mUNw3sVxyyKGyabQyTKDnCjzlD0BMXAy8jO9tiOsY7QJY2tpXcTX212HyyRVKGPUE0f JRQWnOTXFYMgBfihKS9fY3gwwlQxiWUFWxGVAMZS27BW8UsBmEEQxM3SweSlN08/+cB2 Zw9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZH72THi9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h54si2172476qvh.150.2019.08.28.10.10.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 10:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZH72THi9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31Sd-0008FZ-Po for patch@linaro.org; Wed, 28 Aug 2019 13:10:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42345) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31C7-0007eO-Gg for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i31C4-0000rN-Ct for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:14 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:40180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i31C3-0000pb-U1 for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:12 -0400 Received: by mail-wr1-x442.google.com with SMTP id c3so510836wrd.7 for ; Wed, 28 Aug 2019 09:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b97onG7/lnQlcwo4RqOnNFf+XJUP3+kZkC9XBhFAYJI=; b=ZH72THi9x/W/YObwy4Qpze1epX+Kk+NJPpiVhuPYlxtFOWMKpH0qeG5tB7sU5hoXco FG++4ECrZUM+mkwNSaN90j/VeNt85IuG2zKK4MBYAksgxWDlCvy2rkNQayZjOoILI4vA 4P3ICYE/eLxkJtloKi90VdQBNOBvV4C7tpRl7SJMJPZ1bedH9R1w4Vt6FjgZIRmWJnT2 UNvaSuwMpZ43McdD5E6QPZjN1t0nUTn+w2FvvUO1OqT5Rx1S+f+5ZuXYM3PRghfbA59B rDFrAbNGDsFNOVSmJuEaQxFeQEcubyOCTc3c2RuCYnPyYr4pxUd/KEhvnFP/jBzt2HP6 V04A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b97onG7/lnQlcwo4RqOnNFf+XJUP3+kZkC9XBhFAYJI=; b=DaWomsiIHJVJg1H7/v/uOIdAa557nulpnBqicLQ0NGhECZNa+BKDs/jTrZZeEe9VFB aJ2Aw6pTJPd7uA4eIip9JsBDrqfOWuXiwN+Hb7p7WkokcY3mRVOjLpdAuI1yftgYn+qa +tFL62xRkVJEp+PH/Dym8NqKXsNEVmlm7aAdSW6y59V8Be7rNziBX25hSDOviMkNxa+1 tLmjPijXiOYY+NUCnzt0PH7WdIOG42U0+XLhGoh8pKNy3cUWGige1VGRQueHwCCeT9NX iGPuRJPMNRR1Eb0yCM9mzXtnQqephT1nNuAcg/Z1Nkclj7FG6bTwk+RMcILQVgR1JE/3 i44g== X-Gm-Message-State: APjAAAXT38xdXPWuUk8WHG12ntulD//F+LE9w7SYzDhSNOX6FhiCrvgZ aG6Tx+aWgEzFM53AIiraKyoa3Q== X-Received: by 2002:a5d:4108:: with SMTP id l8mr5822642wrp.113.1567011190801; Wed, 28 Aug 2019 09:53:10 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 24sm2124289wmf.10.2019.08.28.09.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 09:53:08 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A42D71FF90; Wed, 28 Aug 2019 17:53:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 17:53:01 +0100 Message-Id: <20190828165307.18321-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190828165307.18321-1-alex.bennee@linaro.org> References: <20190828165307.18321-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v1 3/9] target/arm: handle A-profile A32 semihosting at translate time X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , "open list:ARM TCG CPUs" , =?utf-8?q?Alex_Benn=C3=A9e?= , Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" As for the other semihosting calls we can resolve this at translate time. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/translate.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) -- 2.20.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index 6157e9f52fc..9dc7ec78061 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7657,6 +7657,22 @@ static void arm_skip_unless(DisasContext *s, uint32_t cond) arm_gen_test_cc(cond ^ 1, s->condlabel); } +static inline void gen_arm_swi(DisasContext *s, int imm24) +{ + if (semihosting_enabled() && +#ifndef CONFIG_USER_ONLY + s->current_el != 0 && +#endif + (imm24 == 0x123456)) { + gen_exception_internal_insn(s, 0, EXCP_SEMIHOST); + return; + } + + gen_set_pc_im(s, s->base.pc_next); + s->svc_imm = imm24; + s->base.is_jmp = DISAS_SWI; +} + static void disas_arm_insn(DisasContext *s, unsigned int insn) { unsigned int cond, val, op1, i, shift, rm, rs, rn, rd, sh; @@ -9195,9 +9211,7 @@ static void disas_arm_insn(DisasContext *s, unsigned int insn) break; case 0xf: /* swi */ - gen_set_pc_im(s, s->base.pc_next); - s->svc_imm = extract32(insn, 0, 24); - s->base.is_jmp = DISAS_SWI; + gen_arm_swi(s, extract32(insn, 0, 24)); break; default: illegal_op: From patchwork Wed Aug 28 16:53:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 172403 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1026080ily; Wed, 28 Aug 2019 10:02:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYZzH4ofzSQhbBUlz3NpWuycKYyFE5mgiIeg2yKTTOOmOy5pJFtHBCG2u2cTzJmG/Y61QS X-Received: by 2002:aa7:db0a:: with SMTP id t10mr5089184eds.17.1567011752496; Wed, 28 Aug 2019 10:02:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567011752; cv=none; d=google.com; s=arc-20160816; b=rKSmwszkN6+MJpzSJO9GOcKtgaR5BNwiHt6fNl5m7GjM+ypZAd+9dAAwx2HKlyhX8I FlqSM1NwdMPgYeEIquvf3fV9bINdWg0Z/7/8LSSJ64p2PJqB4QZElUW+Tm+0GE0OiOzf 06HrE4PdGYDSMjjmcgt1cABt6WchUUQQUPTIMIqG8CqRAVD5MIrcvFEVBhm5NmESHogE 9EpuMFgcJFS9G/sMHsq4avZLWxs9JkLiAyUamLcjilVB36DO9MZGVVoE+RY0egQWSCo7 eCUGj3XGZj7ZUqeYRWO4JFnpHNv73uxAParasaKWXosW6zMpcjtwb5pphoJaGOVDT454 d4TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=IKUnc62WPCnJEius0PuJ3RtShM/DcMqSkoHnSUf3aGs=; b=dM+L+vNReLI05d/vgADwA/clcOv3OC/7kQAsPELYdMdp6eZ5wv0fvUwfvqDB+p1xMM yV7ZN+0uleUPACkhlF+YFYHzlk85IXGw3uUb28VAxDocte2JWf4KJ3CyXxQ/7stsi5Xs 1ql2Gc67V/k4pEkGuC+W322J1U5QFDuYqZdb6DYIQI9HGZtKuk7CfkOuglWjDEB4Xr5x u5ZHgPBhPyEtraQAXg/ESF+RFLkN2W/0OYmhMbNm+DRF4VAA1y0vdZw6pkgXeF5sWuTe Plgwo53XVKzMwaFiviwvQl4KBKo2rbNx7I4eUliXBYS94iBKsOI208UPkRr+rW0asE/2 CcGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=OkI8cpgy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o16si126976ejr.190.2019.08.28.10.02.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 10:02:32 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=OkI8cpgy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31L4-0007M1-Ls for patch@linaro.org; Wed, 28 Aug 2019 13:02:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42502) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31CH-0007mO-RW for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i31CE-000108-0K for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:23 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:38548) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i31CA-0000sK-3O for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:20 -0400 Received: by mail-wr1-x443.google.com with SMTP id e16so526336wro.5 for ; Wed, 28 Aug 2019 09:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IKUnc62WPCnJEius0PuJ3RtShM/DcMqSkoHnSUf3aGs=; b=OkI8cpgyQWYVIcR1qSNOPUNK2TnHo5UYwOiNCuJs6A8w//3e/P8iOnC3lWUYadpNnG xT5nhOZ/Ig/pg/SiEkAUwvh+lta2PVPcseAgCPIAGM509Gok/gLqr41iSznXfJxQNvoJ bjE+1iC0c+CuSUJgS+E40YD8deF9CbY6obeyQJY0PrF68/E1JpW7imdC6+8SPHGkRPiu +2Fp4GMawkC3E06GC7y0fIkYQvT0zvP1IM2drX781ED2qxPQGq4QEiK7bxSnIRw5KAZo QoQ+zCXdIyMOiggvG6dspkKm8aM2L8oadBFgl0MnBcPFDdvNPBJGhEimbhvdxFCim8SP mptQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IKUnc62WPCnJEius0PuJ3RtShM/DcMqSkoHnSUf3aGs=; b=l+JcnGtqYky3V8roms1oYCMbZsdehn5VmcYonqT733ppLCYnUct0PWBX9+s+xB5aLt GtVE3jGq23E7jp8QOzX5cLNH+f4c03g5ZybcsaksIByUT03dmUAG/Zn6zk+/GRTS+HkS vEz0OBgenMZmRpKY2Z17dlPnwl8M8oGxpK84JUSAVh3hNrm5KYgFRepq+cO+a6GZjvIS XhSoYQLHaMYAN0jyj/XHWtCB7DIK+qG4RpdW99Ji/ZIsdags3aM0Gw+TrkQASlCkGPnT 1c316ic6gZ+e/EMd3aQDDuUSLXq3C5+twJoFq65XR4pWVPKI2xKDMW7lfsjrEpQLFNAZ T2jQ== X-Gm-Message-State: APjAAAWO+0Pakn7UxqwJnEKY06/OlJwA2cz4tJjKAAfyolQwFO5YMBUu hUV/yPS8d6n/S2vcCod0/QOPiA== X-Received: by 2002:a5d:658b:: with SMTP id q11mr5538897wru.211.1567011192599; Wed, 28 Aug 2019 09:53:12 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id o2sm3717448wmh.9.2019.08.28.09.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 09:53:10 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B7F2F1FF91; Wed, 28 Aug 2019 17:53:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 17:53:02 +0100 Message-Id: <20190828165307.18321-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190828165307.18321-1-alex.bennee@linaro.org> References: <20190828165307.18321-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v1 4/9] target/arm: remove run time semihosting checks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "open list:ARM TCG CPUs" , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Now we do all our checking and use a common EXCP_SEMIHOST for semihosting operations we can make helper code a lot simpler. Signed-off-by: Alex Bennée --- v2 - fix re-base conflicts - hoist EXCP_SEMIHOST check - comment cleanups v5 - move CONFIG_TCG ifdefs --- target/arm/helper.c | 96 +++++++++++---------------------------------- 1 file changed, 22 insertions(+), 74 deletions(-) -- 2.20.1 Reviewed-by: Richard Henderson diff --git a/target/arm/helper.c b/target/arm/helper.c index 7e0d5398ab8..c54d4768e1d 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -8262,88 +8262,32 @@ static void arm_cpu_do_interrupt_aarch64(CPUState *cs) new_el, env->pc, pstate_read(env)); } -static inline bool check_for_semihosting(CPUState *cs) -{ +/* + * Do semihosting call and set the appropriate return value. All the + * permission and validity checks have been done at translate time. + * + * We only see semihosting exceptions in TCG only as they are not + * trapped to the hypervisor in KVM. + */ #ifdef CONFIG_TCG - /* Check whether this exception is a semihosting call; if so - * then handle it and return true; otherwise return false. - */ +static void handle_semihosting(CPUState *cs) +{ ARMCPU *cpu = ARM_CPU(cs); CPUARMState *env = &cpu->env; if (is_a64(env)) { - if (cs->exception_index == EXCP_SEMIHOST) { - /* This is always the 64-bit semihosting exception. - * The "is this usermode" and "is semihosting enabled" - * checks have been done at translate time. - */ - qemu_log_mask(CPU_LOG_INT, - "...handling as semihosting call 0x%" PRIx64 "\n", - env->xregs[0]); - env->xregs[0] = do_arm_semihosting(env); - return true; - } - return false; + qemu_log_mask(CPU_LOG_INT, + "...handling as semihosting call 0x%" PRIx64 "\n", + env->xregs[0]); + env->xregs[0] = do_arm_semihosting(env); } else { - uint32_t imm; - - /* Only intercept calls from privileged modes, to provide some - * semblance of security. - */ - if (cs->exception_index != EXCP_SEMIHOST && - (!semihosting_enabled() || - ((env->uncached_cpsr & CPSR_M) == ARM_CPU_MODE_USR))) { - return false; - } - - switch (cs->exception_index) { - case EXCP_SEMIHOST: - /* This is always a semihosting call; the "is this usermode" - * and "is semihosting enabled" checks have been done at - * translate time. - */ - break; - case EXCP_SWI: - /* Check for semihosting interrupt. */ - if (env->thumb) { - imm = arm_lduw_code(env, env->regs[15] - 2, arm_sctlr_b(env)) - & 0xff; - if (imm == 0xab) { - break; - } - } else { - imm = arm_ldl_code(env, env->regs[15] - 4, arm_sctlr_b(env)) - & 0xffffff; - if (imm == 0x123456) { - break; - } - } - return false; - case EXCP_BKPT: - /* See if this is a semihosting syscall. */ - if (env->thumb) { - imm = arm_lduw_code(env, env->regs[15], arm_sctlr_b(env)) - & 0xff; - if (imm == 0xab) { - env->regs[15] += 2; - break; - } - } - return false; - default: - return false; - } - qemu_log_mask(CPU_LOG_INT, "...handling as semihosting call 0x%x\n", env->regs[0]); env->regs[0] = do_arm_semihosting(env); - return true; } -#else - return false; -#endif } +#endif /* Handle a CPU exception for A and R profile CPUs. * Do any appropriate logging, handle PSCI calls, and then hand off @@ -8374,13 +8318,17 @@ void arm_cpu_do_interrupt(CPUState *cs) return; } - /* Semihosting semantics depend on the register width of the - * code that caused the exception, not the target exception level, - * so must be handled here. + /* + * Semihosting semantics depend on the register width of the code + * that caused the exception, not the target exception level, so + * must be handled here. */ - if (check_for_semihosting(cs)) { +#ifdef CONFIG_TCG + if (cs->exception_index == EXCP_SEMIHOST) { + handle_semihosting(cs); return; } +#endif /* Hooks may change global state so BQL should be held, also the * BQL needs to be held for any modification of From patchwork Wed Aug 28 16:53:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 172398 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1017266ily; Wed, 28 Aug 2019 09:55:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFwupgkj7X1mTagFrI3bzkbUv2oJor+mY5vbL94i7x+lXr93JHAg6mqwfHmU3p5/iSJnpF X-Received: by 2002:a05:620a:1391:: with SMTP id k17mr5061632qki.437.1567011305830; Wed, 28 Aug 2019 09:55:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567011305; cv=none; d=google.com; s=arc-20160816; b=BmOPgqKyRLCjtjOZYVtini/W2Bv7OoD52pbDOX20jPFMLVyhbHdyqD9BsZwm/FiCK7 MyxtSy9YhPYSuuO3vZ4YserIo+e5+vqmQIyInfI+/dyeWEaBhUHu0wnZh7ASUY23PYJj pvsmUt/cZjabsSRecPuFRG4l2lKnhtWtUX1IVRMDCnA7US9IPfWGOfNHMdtnPDGlv/qk FE/zmyOaT+jTLclSZ0+0OvJwO7AmnZvYVvUgQ3apHgKu+WRb6hqbXxJMpn7ujRrGaXQV IeD6c84Ng/MNkGj1bIdU3ShO+Uh5u7vlNTVKK9c/h7PjqaWcxUSIV1pqnEHVNfnrxk6y 4KIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=XYDil4p7u1BVyZvi3vGSRuZatnO0Tk5MNRsRKlBY+Xo=; b=Lm6QyeR9M2IpP3bTSsoYLCws665+YQU7YEt20R9fwUtRaOnvySCDPed7XtFNIKa8yd C8B+4WO83x//DGtNuUzPgJOByN1D2MGcndu9EIuhm5bS4AvqKEipGRCTALGfVx73srrC jOYe/+j4iNS8Notk8kfPZslQVsXbxpeIAHnbHIcUZEA7RJ+49bkJtAXRosil68O232BP XlKeaXQDwb8mIZQKv0Cr57hKzoOY0eAENmLMYIUkqJYu2rArWeWQqm9N41RQRlXHS4Ei KSUji4btn5jnj/lFTq0J+hDNwOfYJI2qy18VO44h5PRVZ7hneglToC38gzGOkmd1PRJL Ohsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KG6G42am; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p7si1976254qkm.284.2019.08.28.09.55.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 09:55:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KG6G42am; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31Dt-00082H-0Y for patch@linaro.org; Wed, 28 Aug 2019 12:55:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42456) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31CE-0007in-2A for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i31CC-0000yN-0i for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:21 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:38574) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i31C7-0000qo-1E for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:18 -0400 Received: by mail-wm1-x344.google.com with SMTP id o184so794115wme.3 for ; Wed, 28 Aug 2019 09:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XYDil4p7u1BVyZvi3vGSRuZatnO0Tk5MNRsRKlBY+Xo=; b=KG6G42amMcs/3rRJ3gU2YP8WFdCEfyvNT9hc3pW5f7YxUqssWebEjiQv1Jen6KXAkD k7JUtKzbbF6JFZ9zyG4GkWYoeqIRgX86+TJ3MXcQusmskWnC4mPfIIthmeL7Et6/QsfF w3z22DvOxsw1yW4Gew3c/EcjzAYlcdpulwLAdynzEi2DsFLY7aMETuxOPwJ9CQBAW8eA WTH6cnFyjCjrshRPfc2P8P0wyO+S1pgD2ZHfqUpuB9pL4w2vulPlil2Y0kagHVkMROsE Y70Ut2mMEo/l2+6T8yxOmxx9LUchnfPWsiIjjVWzSJ4kv8up5RwCpVwoCQm6+BV0Ki5+ 7wJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XYDil4p7u1BVyZvi3vGSRuZatnO0Tk5MNRsRKlBY+Xo=; b=Uo2WWRrpr2znGa1cmtowGJqeNm6nwQtFoDYfeuj2orQwfP+g3zjzqxHvDC92x3giFn SSAsikw7wQ4lnw4ewdbv36SC6y2FOZGPIQ/7wN58dJ3JCrtmE/KaSrXK0VwLGln5+5hw +1pJc1icYwz9XwKghPyb/K3C9Ignp9owoMSfUEaRJcDw/GGWMaouDE7S/vyJs/Kdr52X rvXLE4ZCcXA9p/AguOf6MMZBaL6c5WHoDleVwK4WI6LGTKaZxThjsJbzSbTozfVqm5Nz mvFqbYUY3JdMfyhJjG47oz5oyxaxRjo7kgM92wzz6g3LWzKBYKSc+c2yiFGxEUX1elsn N8Kw== X-Gm-Message-State: APjAAAUhNO6RTuhMspSqQCsXmHzO0hpO3p3dooBjv2vrt1+PSBI2yS/m /VMKZtwtYmXG5Sc+IFHYVcdLe9dRpi0= X-Received: by 2002:a1c:f007:: with SMTP id a7mr4465376wmb.172.1567011191456; Wed, 28 Aug 2019 09:53:11 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a192sm302176wma.1.2019.08.28.09.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 09:53:10 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id CABC61FF92; Wed, 28 Aug 2019 17:53:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 17:53:03 +0100 Message-Id: <20190828165307.18321-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190828165307.18321-1-alex.bennee@linaro.org> References: <20190828165307.18321-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PATCH v1 5/9] includes: remove stale [smp|max]_cpus externs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Like Xu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Commit a5e0b3311 removed these in favour of querying machine properties. Remove the extern declarations as well. Signed-off-by: Alex Bennée Cc: Like Xu Message-Id: <20190711130546.18578-1-alex.bennee@linaro.org> --- include/sysemu/sysemu.h | 2 -- 1 file changed, 2 deletions(-) -- 2.20.1 Reviewed-by: Richard Henderson diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index d2c38f611a3..44f18eb7394 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/sysemu.h @@ -42,8 +42,6 @@ extern const char *keyboard_layout; extern int win2k_install_hack; extern int alt_grab; extern int ctrl_grab; -extern int smp_cpus; -extern unsigned int max_cpus; extern int cursor_hide; extern int graphic_rotate; extern int no_quit; From patchwork Wed Aug 28 16:53:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 172402 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1022905ily; Wed, 28 Aug 2019 10:00:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqyEEPu1o+lrgvv4RMIM0si1WeRxvzAUhxcoiCFf4VDubNCoGVMYqvxGUkGxeecQSTfMePKP X-Received: by 2002:a17:906:75b:: with SMTP id z27mr4195307ejb.67.1567011618958; Wed, 28 Aug 2019 10:00:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567011618; cv=none; d=google.com; s=arc-20160816; b=Ycavs6zXyjCkyYkEUlUp3IjnBIcSqivUo3VQsi4HqZsOuOIPGvNSs8hnkRaxEtP+J3 v3PKPFCqOMEp4MirLSrKEBrlMDqtvTmQWHnDOblljApK9aDPVq1CE2qtf6j/pokXJaKD M8hrVtU5KgWWhbPCupW40Wa3WrEnQwdTFiBDTJ9SCyT9RG3uEjrV2F5U071k0/cflK82 5FkekduZ4LuWdfzKsaKCQ6Fmww2vVu/uuQ0OhEM1PBLx8EjGGhJQL1K/Fk20ge38BItb YcfEwKd6Vze+qskug9+m8YcGXQ/x3hWBsb56HEtsj/uIFc6dS9SYO5e9vFO6Tf8E725l xozg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=HmgqT/HIUKoP+z/2ztUMKoEQehWucsoXeXun56Y0Jjg=; b=gMZwd1ywGs7N5Ni/v1SRK8CRDm+QFCXCm/FS5aMNcpwOwPM89A+XENXu3JBvi500JX X8f13mmW54H4PtlOPzlyY3XXgumIe5Vah44+RxCpR+Ad9sEFFlfKZ9ijbXm+VecxI1VS F4QEuRRciSxoGc0GBd337lOCLQoKDxs5BVfOJP1D5F+bgVxQm+RuJNuZHdQAFE7HNM9p iB0hyz+BNapc1fIu11O6UzknTuVMHgb4bagQQLEkKCDmxbDjW7jhv0qzFvU2M59r4Em5 1OzbOMedrXJJ4jfFV6d6YTNnWe0603/UWSY3UeOXp42D9/4+NtVe4+TXR/Mmh6paToOA lRdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=iOveHdMf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m22si1521937ejx.164.2019.08.28.10.00.18 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 10:00:18 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=iOveHdMf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31Iv-0006pm-2J for patch@linaro.org; Wed, 28 Aug 2019 13:00:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42449) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31CE-0007ii-0U for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i31CA-0000ww-4f for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:19 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:34644) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i31C6-0000rm-B2 for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:16 -0400 Received: by mail-wm1-x32b.google.com with SMTP id y135so103936wmc.1 for ; Wed, 28 Aug 2019 09:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HmgqT/HIUKoP+z/2ztUMKoEQehWucsoXeXun56Y0Jjg=; b=iOveHdMfubhWEClABqTNbEnkLUAAZdKqSKIkZmQA0Wl0Wx9+coWlIO4eA9Sj96DyDf xmFw0GW0vbfBAvcn3ehVTSp4pqifLqsLHWUEzW6tqp9CRfLIuwBvSvsahSYDBEfQ0Mw8 wcFh75B/B4KBroW7c408iv5S+hdqzKdNA+azcFc0jghXQEFvoUoAd1UROFo0lNqrp54d OW5eP1Hqb8Zylfrw6/9aBZldUz7XP081tspSMi5QyBxdFl7e26CgtWCPFvni8L+dY3m+ RaoqFvl1ouy9kj4QBS8/wn4QY4P4i+Q9pTTd9WFyagPZVqsdEPvUb0wd7c1hneacqumU hcQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HmgqT/HIUKoP+z/2ztUMKoEQehWucsoXeXun56Y0Jjg=; b=debOsNX9v5uXZOk6NmgTeXKCI3KIeHKIH9BNCNwiQM5/CTIoreQpkqYrX3+c9Y0+JH YmYqnHlbTQGkgGOwTUketPcVDOKLbPynB1aUV3P7jwRwxk/bQ1uOYWzM8Md+TW0EUh8o PClB9zQr1PvzozDxuy/8h8Pw8OE575Ykh1qngmUGWiwTr0Dzq5Ncnd4HgY0wRf/Mzd8P tAGjMkG1zoMI5hFtKOFyn/nNmwPc4SjxxSwo6QUJOGjTPqCp7Rq+on9w4mVnCNjpAoTS vOEUQpvLGO1xBCIoTaCcwzQRP8nbz7GnS3lQ6ANS95hk4V4UowCPyzNYMgMEp3tOB4j6 X1mA== X-Gm-Message-State: APjAAAXA1kabFriYKy0CxAGnGQPka+P6lWw3/P6a8CV0wlt7SF/c/kxd m6ArqR/iLalxHrueDa448iGwOg== X-Received: by 2002:a05:600c:1087:: with SMTP id e7mr6103029wmd.19.1567011192043; Wed, 28 Aug 2019 09:53:12 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id r16sm6048320wrc.81.2019.08.28.09.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 09:53:10 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DDDB51FF93; Wed, 28 Aug 2019 17:53:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 17:53:04 +0100 Message-Id: <20190828165307.18321-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190828165307.18321-1-alex.bennee@linaro.org> References: <20190828165307.18321-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b Subject: [Qemu-devel] [PATCH v1 6/9] tcg/README: fix typo s/afterwise/afterwards/ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" Afterwise is "wise after the fact", as in "hindsight". Here we meant "afterwards" (as in "subsequently"). Fix it. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tcg/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/tcg/README b/tcg/README index 21fcdf737ff..ef9be5ba90e 100644 --- a/tcg/README +++ b/tcg/README @@ -101,7 +101,7 @@ This can be overridden using the following function modifiers: canonical locations before calling the helper. - TCG_CALL_NO_WRITE_GLOBALS means that the helper does not modify any globals. They will only be saved to their canonical location before calling helpers, - but they won't be reloaded afterwise. + but they won't be reloaded afterwards. - TCG_CALL_NO_SIDE_EFFECTS means that the call to the function is removed if the return value is not used. From patchwork Wed Aug 28 16:53:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 172408 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1040278ily; Wed, 28 Aug 2019 10:13:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqyfkOPDmFZ2JRc3e2gPpSDOS/AygJUEYOSOCITDD2eo3SwKd2AqJa8d+dsIl16gDPIO1l0a X-Received: by 2002:a17:907:447e:: with SMTP id oo22mr4092815ejb.169.1567012389915; Wed, 28 Aug 2019 10:13:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567012389; cv=none; d=google.com; s=arc-20160816; b=XYDUKUQmrbUWawtZcx2sLrXw759jLeSzJPg5Tk4fyVcGLyPwpVYIK7j45vgexzPvGv IYZBSVJQTkH3b/CyTBUSfEQ6xy5exKbheoqM43Ph3WXrnDKgajz8C8fIoGogU7YqHl0b RjMNRvE1AfcL49hVHsCiMBMMiFH3BO1eE0CS9N83d3+xSsHERE1br+9TO5PkVV1e5Ka/ 8khvOZBJyux7bPZe04exFJFtAHfA1GAAwlhKvIZ2YBWYsxWFuEgde7Qb1AZV+1nEjzEH yCudgtdq4lMXw5VlXtXXAOJwcGZJw+eeE9Lq7vbb2Ti1OId3ZIbXrteneTp0FAFVnUJQ apZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=TNq2/tF+Veu5drl4HTIh7J8EBOeTUQN0G+PECJ/ML98=; b=xK84MhsF2PWSab99IAHRhZ45DJMgW+9hivW4GNGSJPYhVBk0caHN6NjY2bX+AGXoil rrMWLr93hh5QcQpJrzMYdMAplbMAYufgkWTD8t6izxIA+RmLFe7ZhVus23CTQznQzAfD OljLN9pPIRmYHfNhJD8eaBh4V4kKgMvodNLcCiMY0KsUIOEnhQB0gLW4f22Hqtf7bIwv GKtcPVRZvvVxI1FHS5FDLNcCcfVwY6oSoVrrNckU8iKOrR9A0WSWxx3ynmLoO18WBUsv oBtLF86mZf3fYfNwrDV4DPQY5nhiCs5Lc2zfUja1LeMj9fV8SX0GIxhel96QmlKaWgzp Rssg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=yBV4k3Xw; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x16si1584789ejs.73.2019.08.28.10.13.09 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 10:13:09 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=yBV4k3Xw; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31VM-0003yc-N7 for patch@linaro.org; Wed, 28 Aug 2019 13:13:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42499) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31CH-0007mJ-Qo for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i31CD-0000zu-Uj for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:23 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:40852) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i31CA-0000sw-45 for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:20 -0400 Received: by mail-wm1-x32b.google.com with SMTP id t9so779838wmi.5 for ; Wed, 28 Aug 2019 09:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TNq2/tF+Veu5drl4HTIh7J8EBOeTUQN0G+PECJ/ML98=; b=yBV4k3XwPkPv3BmsFIJI43dN9JmuPkXBbqQKjEdxbXeXAOlo2YgRnOONdcsxxToOD/ twgyS2kDOYEQD9swGz5jZfRNObI9KNozwhf4sPo5Fz9JBz6GVKvx/qtIIt0kgzBB8rOR 6IiYIdNIQ2GfhTzZ0CqSOwhs05MvXZf9w/uie4QteMBoSfYE0GrW9A8JIkDfHv86AtGu NuVTIVpCpSC17Xg7N/NQIMAJR8j/VhnKAjkRYlGzoKxxH3D5HP0Q3oHrEsC/qazxsg8j rAjrUpZIRrgUszdPY97MfAOpPuO9gKEK+fUOJezUsXMQA1QPdPOWLF9bLydD/z1FLsUc z4hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TNq2/tF+Veu5drl4HTIh7J8EBOeTUQN0G+PECJ/ML98=; b=seFL/86FvbIsMF86jyR35pfD4H0b+43YXtRdpDxiCuSG/EOn6IjxwIZXwoYGYdONtS T/3Il1qB2+qwRnDcA5d0YhlpnQCk7IbOawgLczDJMPlPyUixpUv1eL4WkzUtcTGa5fUv FFHxIe9795YlufXmCrYoznPl7a7mAcxn8WGU84axBCV96aspZVSP86eBcAZIh82fUs7G x4uXGaGMcZaU7jnsmYbX4hA/QBQZKdJo9SV+ABgMfqOaixnNXQLmmXXdFIVmRe6IKMH9 avDZebmCmmC0wwP1JwLAMRoi+5hkPX080i7a2Ua4Y3WNgORZLAuIZqeDIG205desgqV8 7dow== X-Gm-Message-State: APjAAAVMudeBM7e6PSBDdHR3GDyLzuFkQbdWV2Jqc03MCu6bd47DHsZ3 fm7E1J+fUfCU3g6f3kEnyTb3Jw== X-Received: by 2002:a7b:ce0b:: with SMTP id m11mr6399307wmc.151.1567011193374; Wed, 28 Aug 2019 09:53:13 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id r190sm4593984wmf.0.2019.08.28.09.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 09:53:10 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id F214D1FF96; Wed, 28 Aug 2019 17:53:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 17:53:05 +0100 Message-Id: <20190828165307.18321-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190828165307.18321-1-alex.bennee@linaro.org> References: <20190828165307.18321-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b Subject: [Qemu-devel] [PATCH v1 7/9] atomic_template: fix indentation in GEN_ATOMIC_HELPER X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- accel/tcg/atomic_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h index 5aaf1862539..df9c8388178 100644 --- a/accel/tcg/atomic_template.h +++ b/accel/tcg/atomic_template.h @@ -284,7 +284,7 @@ ABI_TYPE ATOMIC_NAME(xchg)(CPUArchState *env, target_ulong addr, #define GEN_ATOMIC_HELPER(X) \ ABI_TYPE ATOMIC_NAME(X)(CPUArchState *env, target_ulong addr, \ - ABI_TYPE val EXTRA_ARGS) \ + ABI_TYPE val EXTRA_ARGS) \ { \ ATOMIC_MMU_DECLS; \ DATA_TYPE *haddr = ATOMIC_MMU_LOOKUP; \ From patchwork Wed Aug 28 16:53:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 172400 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1019985ily; Wed, 28 Aug 2019 09:57:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzs5Sjk1WgFwaZTcGZU0ej1JQXMkMDhossMt1g2vclbIIJM5JbykqfBjXfb6Ia4YSvMZoVF X-Received: by 2002:a37:8c07:: with SMTP id o7mr4914352qkd.491.1567011453787; Wed, 28 Aug 2019 09:57:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567011453; cv=none; d=google.com; s=arc-20160816; b=SWkjwKS/OiL+qPBa4OXocF8aSzhMEmcq8UpwbXeOZp/2tFK/XVEHH07BOH2PWUFtyc 8nyRObdG85rGFo1RgIuEYY/nPo8hz08nHNfX2woXXYN+AkTGV0/xtmgX1VrkWJdXnhA1 57Vw5dRtcVT7HzrMMC6JzWXB5Bpb0lY000VNoZg12+biC2L8FVst7uwPaOBuwTRobz75 jxnXDMHdd11V536B6USRuvwS1Yt47uTQNMs/H4uu7UeNOlqvkY/aU0K8DIcwXMMW8f/x 7/vlAIaCK2j2ZrazE/eYbTFxaLql6/UAKR7w1Amxlq64VAD9TzyzKUZg/TTHCIIWrRxe Btjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=xJKTf83Fi+RIXDJqcB6eYqb17WqVXupOn4gsH5fbN8M=; b=EUPPkPVZvtFomW7upzPcv+4O9om71hFwrlHJZCrfE9VFcenHqIv9QfwTiDQEjH2HUX ZfXgI+g9sVZBspNxN9fRYOQkuYUPGherSqqDnZtWSxxk9b2s/yp3IoI9QYg4XXtvkb+Z hmYcpgw+Yj3NPCwnGb4BoaxJOFVEj5M/iQ5WuuHcmVkdUITHLf/DVrTY48yC6YM5A1Kv 0PRaMN2gkKD4tPKk6SwRGtIntm1O503/BcAtqK73HkzKdeiPQ8PmNQnEwJ4LFcCrZ34X o40ZeO7bQIqpnFZOWuZ9DjsfFlN/pe30yM3qJco4sSbUWwEpiJM1Ed69YSyin8JlOPIj fWlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=rK23+Fso; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d47si2024230qta.287.2019.08.28.09.57.33 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 09:57:33 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=rK23+Fso; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31GG-0003Y2-Uw for patch@linaro.org; Wed, 28 Aug 2019 12:57:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42500) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31CH-0007mK-Qd for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i31CE-00010K-1l for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:23 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:39830) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i31CC-0000uK-1L for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:21 -0400 Received: by mail-wr1-x429.google.com with SMTP id t16so515821wra.6 for ; Wed, 28 Aug 2019 09:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xJKTf83Fi+RIXDJqcB6eYqb17WqVXupOn4gsH5fbN8M=; b=rK23+Fsok4aQ6bzSQKkw32xGCJRE8f5yWevl5C5P3QYoMlvdRfqJ4sfdHK7C6Ir0vf wr5AkX+ZuqiNVyEXv3S1dnb6/iGP2gYxuD1Zb1vhYj8QLCY6agz0MuT4qGFhxzP2M+3W Wi0httWSsrlimF69cqLGcl2B5RNQugkvTYumKT64pgVeCKFZhahRSbaPZntqgn3uKWaI c6qqk6Iahw/WEVRHziWmeSnieoAHAR01DurgVFC7RRYJZ50V7T934PFNv4z+/22SIOjf QaC0Pi97gwO9VG3WeT5UkRCOVyKDiMFFGq9B3ozyUlNeltlzSFYTjuY6gl0L+aaCd/bI c6eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xJKTf83Fi+RIXDJqcB6eYqb17WqVXupOn4gsH5fbN8M=; b=O/h8H43w6cQ2eRm3eyIkJw0EYgT9DIKQj8tcZo03ZYzoX2TrCretuIBJhSprIXIFjq jBVx/VCB/OVh0jBCg5Ik2oyjCzPWPQTBaSgRA4xebgEw3kvTyJ4k3EObtBgAWh5P961A ikkHWXkX482Kl3n7mEdJi6/DVjrVuuYz61FQgD6Ox+/TzERFCWC7gRs9EnoqH8GXPB1F 80+Bs3AnLJhbJDVJ/besGOEoZn7sLI3SfA/SsyEKco5hX3pbGp94qCUk8vFmhFFsvBAQ 1Q1FMZ/yl4EgyjAguq+spjpAsrEaiGB6SxWrR/HPIDFXDaWWBUB62SCQc9ns9UzGKG6j /8zw== X-Gm-Message-State: APjAAAUG2MulBPkNXO+MdEEn9KVxToRjqWZLDxmlKGne0bVsB+P0Mt54 s2nKSDCNnGhC/FJxdgyOCaqIJw== X-Received: by 2002:adf:f0ce:: with SMTP id x14mr5917017wro.31.1567011194603; Wed, 28 Aug 2019 09:53:14 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id e13sm3283315wmh.44.2019.08.28.09.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 09:53:10 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 118861FF98; Wed, 28 Aug 2019 17:53:08 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 17:53:06 +0100 Message-Id: <20190828165307.18321-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190828165307.18321-1-alex.bennee@linaro.org> References: <20190828165307.18321-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::429 Subject: [Qemu-devel] [PATCH v1 8/9] accel/stubs: reduce headers from tcg-stub X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We don't need much for these. However I do wonder why these aren't just null inlines in exec-all.h Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- accel/stubs/tcg-stub.c | 2 -- 1 file changed, 2 deletions(-) -- 2.20.1 diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c index e2d23edafe0..75b10ab54be 100644 --- a/accel/stubs/tcg-stub.c +++ b/accel/stubs/tcg-stub.c @@ -11,10 +11,8 @@ */ #include "qemu/osdep.h" -#include "qemu-common.h" #include "cpu.h" #include "tcg/tcg.h" -#include "exec/exec-all.h" void tb_flush(CPUState *cpu) { From patchwork Wed Aug 28 16:53:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 172404 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1030647ily; Wed, 28 Aug 2019 10:05:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqymXVBOGoRn22HudC2h2OIt14d1YEW1weNLKA3W9KVc3PBMOxp66D6zbLdnxeY59AeHeQvC X-Received: by 2002:ac8:38ed:: with SMTP id g42mr5453027qtc.24.1567011949391; Wed, 28 Aug 2019 10:05:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567011949; cv=none; d=google.com; s=arc-20160816; b=0vUHZGE6a88hqFVtn/w8g3E5Vsj9dSyZQmzm00L70q0GN4IBReMM+wBuBCbB09aICQ v5rNiAOsoOZGl5B0v8vN+hdS24cab8C4tzgn/gwT4JbZ2NrfBdlJHOSrCMdQGGlk3lm+ dKolaM4AFhVgEB91n/5RWFSxwbqC/T/q7JvJNiCozIxkIaIuDePlRo9xMr1Doer8fT6b mkB7c6lMJ1lA5fSKNCP71M6s6e0KpoGn861S2qTSvGG6BCH2AEvhN0gWPv5/9LaODBZo Gd23JRtUEKJS7PqLjuJVkfFbMokriR/WFltPsG82K8ueamBNhplFV8RLy//Xg/SIYWGl wqZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=rVdkSzu7T7YfYwM2o/2/4ishC2eiSSFgkpF8Efr9l+Y=; b=Jd8MntoMgInKUAy4Qprib5/xxpErxvhLf1yh1O62SViStrGhZXUxT5lx7E9/1neOJT Tdxbe0MHVmLNDRvUo5DTe2X4zEIwi0xtcwinXk50nrWWhj9+yyKq/WuFpQ+49IyZ0IIL inw0v/CHN6RiGR5/phYM9pDWPA25I9DPWiq8xSIpa6ScCUhZ8UwPsbbt38vZgS19NXZV z2SQssV7hDC/lhW03hdGoZMEfd3p24pBBO3nstTeRKd5l/jbDn4ANNm6nUAPD6O54m0c +i22Ebv7f85NQ89W4oKDF5eyg7AO2EZmfPc2McON0WkIg7rJzH51Tq/sVFP8mE/hTXaY V81A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Ajhz8MJe; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x45si2157469qvc.114.2019.08.28.10.05.49 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 10:05:49 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Ajhz8MJe; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31OG-0002l2-OV for patch@linaro.org; Wed, 28 Aug 2019 13:05:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42540) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i31CJ-0007oF-1c for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i31CH-00013b-QF for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:26 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:36828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i31CD-0000tM-VB for qemu-devel@nongnu.org; Wed, 28 Aug 2019 12:53:23 -0400 Received: by mail-wm1-x344.google.com with SMTP id p13so811955wmh.1 for ; Wed, 28 Aug 2019 09:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rVdkSzu7T7YfYwM2o/2/4ishC2eiSSFgkpF8Efr9l+Y=; b=Ajhz8MJeMhcs+hycgsyyQxLquHNoG0UiYZlogabY7dFPNezTIO13LlAyOumozOMSsM kkpniY3O6nie1ScKOp5W2Nl7JDKtlTyptboSAl3ZBeGQl5gsllIfIy7Uv68jO0zYTA1M bz2gbwYOMlJRn6coycdU1J9QeYqKmT+Lb62ehGWlAx5aXgr4hOyFlA5bkpSYAAyr5NNX h8u8jD+lr986kn3+wyAMLPSCzkU3kaamnqqwnm9MP44jf/Er7bJaIViSadw7/siDGwnz GJN9wKrswc88H8wjNXfJmHi/UFLtEtMGfPh9jroNH79Oryjdbao1q7vnVc4Mow7j5L41 tc1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rVdkSzu7T7YfYwM2o/2/4ishC2eiSSFgkpF8Efr9l+Y=; b=INZBS+L2IX/kN8iHKPQzTqut6V4MXk6M0C0SVnZJkjmWLM5/D2aD3ITtW8w5A8YHiM Nu/7i42vdWBhaY9vL3/ENqL0MG26YXboV6pUEHqZX6jD93TvjndzYMFrSKCbpCoGocYv PNl1C58wItIZLw9nvjjTeJLayfk/bjLB0McBPojRES2lSydcgHQBI/iwTzW96JYEq/nh 1bTNYqCIP/mWD6w8V22xVoQmQjnj3aoB2Ps0TqcQC9xrWgeCiyGoOVCXHxikB/kfAF0q rrZHMFAxbqW/gK2S2f4TlOcrMRndFIPFkA0OdkMVL1GL4OKJ81I9mEDwhl12JYXkGrI8 9Tqg== X-Gm-Message-State: APjAAAWNr5CrdNcWGLaTRFTGVPjwm9v6nNR+Nh667+pGA/TOR1tRnYR3 XgZAAlu1qH5kUOafmWlcD6L9Dg== X-Received: by 2002:a1c:ca0c:: with SMTP id a12mr5860465wmg.71.1567011193875; Wed, 28 Aug 2019 09:53:13 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id f10sm1962046wrw.16.2019.08.28.09.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 09:53:10 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 254D81FF99; Wed, 28 Aug 2019 17:53:08 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 17:53:07 +0100 Message-Id: <20190828165307.18321-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190828165307.18321-1-alex.bennee@linaro.org> References: <20190828165307.18321-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PATCH v1 9/9] include/exec/cpu-defs.h: fix typo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- include/exec/cpu-defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h index 189709b6deb..be946ba1ce5 100644 --- a/include/exec/cpu-defs.h +++ b/include/exec/cpu-defs.h @@ -231,7 +231,7 @@ typedef struct CPUTLB { } CPUTLB; #endif /* !CONFIG_USER_ONLY && CONFIG_TCG */ /* - * This structure must be placed in ArchCPU immedately + * This structure must be placed in ArchCPU immediately * before CPUArchState, as a field named "neg". */ typedef struct CPUNegativeOffsetState {