From patchwork Wed Dec 13 17:31:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 753998 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDAF03307A; Wed, 13 Dec 2023 17:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CG0jUACS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 926BAC433C7; Wed, 13 Dec 2023 17:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702488711; bh=0lSIsKw57fQKAbIpEwj2SrlosSdAJSq5HP2yiybviRQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CG0jUACSvZre7kYHHPdmX45hiGSCQ7lutou/ZdXrHPYrIp8zPVi1+uQ8YIDMGHaT4 liBBO2cHs4raP0yXIHvJQFrahSHcLRUXnJM5jdwhCh3/LSyzarOynXG/UoXPw/Muer K+kWZdaBrIN6cYgdqtrZYGUUsfqBpHdKNL51BI97h+TVBuu5nJTByUPtCSQ125PmbD EIWA4H9U5bJC7ria+4FhB3bgoS5H0r5rQKQFw3hZfKdewHEe2wgXtpBV13l33ET+rE NhgEwbIX2/Wr3t7+wWgXUWD4IsE+5eh7OPbScrPv6YYtdmefypT2KFUzqkPD84PdiS wcfWfnwkB2L/w== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rDT5J-0007f9-03; Wed, 13 Dec 2023 18:31:49 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 1/3] ARM: dts: qcom: sdx55: fix pdc '#interrupt-cells' Date: Wed, 13 Dec 2023 18:31:29 +0100 Message-ID: <20231213173131.29436-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213173131.29436-1-johan+linaro@kernel.org> References: <20231213173131.29436-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The Qualcomm PDC interrupt controller binding expects two cells in interrupt specifiers. Fixes: 9d038b2e62de ("ARM: dts: qcom: Add SDX55 platform and MTP board support") Cc: stable@vger.kernel.org # 5.12 Cc: Manivannan Sadhasivam Signed-off-by: Johan Hovold Reviewed-by: Manivannan Sadhasivam --- arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi index e30dbf12990a..0864c99a3da1 100644 --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi @@ -612,7 +612,7 @@ pdc: interrupt-controller@b210000 { compatible = "qcom,sdx55-pdc", "qcom,pdc"; reg = <0x0b210000 0x30000>; qcom,pdc-ranges = <0 179 52>; - #interrupt-cells = <3>; + #interrupt-cells = <2>; interrupt-parent = <&intc>; interrupt-controller; }; From patchwork Wed Dec 13 17:31:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 753591 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDABC3218A; Wed, 13 Dec 2023 17:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kYASBm6m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 873B3C433C8; Wed, 13 Dec 2023 17:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702488711; bh=xSe1Jsu3GOdkOTtJbp2Lh+/h7FFNNW/h3W6k5JjfVMs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kYASBm6mT+FY45+m24m+AemNhaaX/5qyYUr8btsfdovQW6TkJD2QTPb2HCp51cdD5 oLZys04mr2u154P9bP3D35oR1FRHbNoHuAWbRmH+OaVwn1MyS6e2PnOsGF4UGDhl2b cKBcZ6kWkQ2QyttQZugLNrw7h2oUw56MNcRob/CVPWMHk5Bw2KlncEstMmGQbYQQ2M hULobbeFx66fguSsBIbpCf/JwhLk/Js6E0pmBAwZEjvQYx7Twt7SaLUNnPKHZknurd LFTkzYZ2++Q8UO+Wr71yugFj81W7XVEKp8OUPJ8er3mNzUUt5nUMm+2tTAf+TEd9Xo UIfUfYuwcVGcQ== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rDT5J-0007fB-0L; Wed, 13 Dec 2023 18:31:49 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 2/3] ARM: dts: qcom: sdx55: fix USB DP/DM HS PHY interrupts Date: Wed, 13 Dec 2023 18:31:30 +0100 Message-ID: <20231213173131.29436-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213173131.29436-1-johan+linaro@kernel.org> References: <20231213173131.29436-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states and to be able to detect disconnect events, which requires triggering on falling edges. A recent commit updated the trigger type but failed to change the interrupt provider as required. This leads to the current Linux driver failing to probe instead of printing an error during suspend and USB wakeup not working as intended. Fixes: d0ec3c4c11c3 ("ARM: dts: qcom: sdx55: fix USB wakeup interrupt types") Fixes: fea4b41022f3 ("ARM: dts: qcom: sdx55: Add USB3 and PHY support") Cc: stable@vger.kernel.org # 5.12 Cc: Manivannan Sadhasivam Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio Reviewed-by: Manivannan Sadhasivam --- arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi index 0864c99a3da1..49910279cb71 100644 --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi @@ -585,10 +585,10 @@ usb: usb@a6f8800 { <&gcc GCC_USB30_MASTER_CLK>; assigned-clock-rates = <19200000>, <200000000>; - interrupts = , - , - , - ; + interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>, + <&pdc 11 IRQ_TYPE_EDGE_BOTH>, + <&pdc 10 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", "dp_hs_phy_irq"; From patchwork Wed Dec 13 17:31:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 753999 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDA7D22081; Wed, 13 Dec 2023 17:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UyRL7vxR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 907C8C433C9; Wed, 13 Dec 2023 17:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702488711; bh=pvfAZ2jWOf3ivNxGlbKupApmdVeEyh6B35IYVxGAQVk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UyRL7vxRdK3m9bfIoxioogLX62bouo1KuletWAv2bRccseP4Cpu3BuhdYCqWnelFY l2pUeV+hqoOMm9OEokUCFUWDmJEvRs+8mAsdoUfPVEjkX2GifjrxfgkE9EC4J6m3kf keNGhxSAiVbsszucmnUeg5Yoonn+Ait6UFO/2vefRSsnEOq7kUmcv2YFs0ApPY98+E 1gSWY53DiUHMQDVRWxR6S188uMOF+cBm6G5xMvxBjJpKxP1u82UWCK+9MItv+7oV1d eQuz4dE4x+ItycgyHd89GIOpvOMCCShbBJlN4KLe9i4N+QXojIdNESHmLdIQNS7IsU RrUtvtIjYZnyg== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rDT5J-0007fD-0d; Wed, 13 Dec 2023 18:31:49 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 3/3] ARM: dts: qcom: sdx55: fix USB SS wakeup Date: Wed, 13 Dec 2023 18:31:31 +0100 Message-ID: <20231213173131.29436-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213173131.29436-1-johan+linaro@kernel.org> References: <20231213173131.29436-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The USB SS PHY interrupt needs to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states. Fixes: fea4b41022f3 ("ARM: dts: qcom: sdx55: Add USB3 and PHY support") Cc: stable@vger.kernel.org # 5.12 Cc: Manivannan Sadhasivam Signed-off-by: Johan Hovold Reviewed-by: Manivannan Sadhasivam --- arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi index 49910279cb71..5b69219170a8 100644 --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi @@ -586,7 +586,7 @@ usb: usb@a6f8800 { assigned-clock-rates = <19200000>, <200000000>; interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, - <&intc GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>, + <&pdc 51 IRQ_TYPE_LEVEL_HIGH>, <&pdc 11 IRQ_TYPE_EDGE_BOTH>, <&pdc 10 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq",