From patchwork Thu Sep 12 07:40:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 173678 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp1780097ilq; Thu, 12 Sep 2019 00:42:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqxg+x8vbyqUPjBMlQB0QPXuCR0s2SwNM0c5S7iWsmLgE60yWUE1EZ2zeqCOxAVgzZKj/3CB X-Received: by 2002:a17:906:804d:: with SMTP id x13mr32854968ejw.134.1568274158953; Thu, 12 Sep 2019 00:42:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568274158; cv=none; d=google.com; s=arc-20160816; b=zeKOcXYW8ibmG1Bf8wJoF5eYacBCB88hIQ07cRwNvibST5iqGCm2bSJPMUfhetFWI/ wcf6jX04gAkigzYqM+JLMjtFvAMiW8mF9Ei/6YbQbDnUGexE3p3Wtx3aJo2KHZ0Oy9lq /nxT6uk3If5jLLQZbp33IAPGJwEy2fTgzN+utfByX2aPXhwIKRMCmTqe8D7SrouJ7CPe sCw7aLDje9DfvkOoDTmODfL5XVx/CtSPHg8AbwyBMDbjZTFF2micvyoO10Uo4CInAW2T /OomnM8fFSdVBigxZ9XfFooKx/kkXD7hD4+FA44VymmSE0EvpHMwLIhOl5+/95RkOQAp 9wfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=tYNGmUKDdlHdaYWdH5IidgIolcOzTVD5cgXor3vQ83I=; b=Z9Jn+6Ob4IHg7iuMsgAv1A+hKYEwW5sJK99PTS+eGXrphr3My/7+2PH47Z4pIG3hsW L3+eNZp135cFc6jOdFMOQMv9/yxxVM0KB2Y8WHMPbJwzn1sRU1ztBtw0P3QhsHCn4oX0 nuS7W0JiTJD6k7dCdMIJrooWK1v9nWM7swWYEWa/E3IN336WKkYXzUzDuM2M/2AZaDkW h3zgwrWO6FSYyP+88LJOtQp2hJl3H6KVTzWDOjkuhOhqLwoqgQYlNEAPS3SnKfc5I/ep aP7V+vf8dSJ1QzdeyVOVoE+zyOf9276LybPm5a5noo9PSv/H2mdsulctNnVa+kAAlJcq BMoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=b5zTIocn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qw15si12680843ejb.11.2019.09.12.00.42.38; Thu, 12 Sep 2019 00:42:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=b5zTIocn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729916AbfILHmh (ORCPT + 27 others); Thu, 12 Sep 2019 03:42:37 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:37658 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727186AbfILHmh (ORCPT ); Thu, 12 Sep 2019 03:42:37 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x8C7edBo002482; Thu, 12 Sep 2019 16:40:39 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x8C7edBo002482 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1568274040; bh=tYNGmUKDdlHdaYWdH5IidgIolcOzTVD5cgXor3vQ83I=; h=From:To:Cc:Subject:Date:From; b=b5zTIocnN33/DdUDcjaMeyjFzoTtbxCd5868rKO0xNO0s4hj4TNzpDUOblkZcIN5s blwV1MedYVuH8L4E6jhrG9tGRK5B6XcHeO9hj0vbKerkxkYHo2Ide3IG4M/1a7c4bX 1PaFV6ym3Hz6Rf1JatWU/532qvHQvpov555Eto+SN0h143gBLKQRZ81xTz1moDF4q8 PIRr9nPjvDy9VjennU0QLC/d+55xbxsG5lX6PE7UvoAwocoen+R8QD/u8uMmFMIzBi yEL4RALzlrR3T6bfH2CDH66vDOel/m3mCNo/vLZ6dB9qFtFdxrTaTKOewUmDQU56i6 cURS0DcBm/zvw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linuxppc-dev@lists.ozlabs.org, Michael Ellerman Cc: Masahiro Yamada , Alexey Kardashevskiy , Andrew Donnellan , Benjamin Herrenschmidt , Christophe Leroy , Firoz Khan , Joel Stanley , Nicholas Piggin , Paul Mackerras , linux-kernel@vger.kernel.org Subject: [PATCH] powerpc: improve prom_init_check rule Date: Thu, 12 Sep 2019 16:40:37 +0900 Message-Id: <20190912074037.13813-1-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This slightly improves the prom_init_check rule. [1] Avoid needless check Currently, prom_init_check.sh is invoked every time you run 'make' even if you have changed nothing in prom_init.c. With this commit, the script is re-run only when prom_init.o is recompiled. [2] Beautify the build log Currently, the O= build shows the absolute path to the script: CALL /abs/path/to/source/of/linux/arch/powerpc/kernel/prom_init_check.sh With this commit, it is always a relative path to the timestamp file: PROMCHK arch/powerpc/kernel/prom_init_check Signed-off-by: Masahiro Yamada --- arch/powerpc/kernel/.gitignore | 1 + arch/powerpc/kernel/Makefile | 14 ++++++-------- 2 files changed, 7 insertions(+), 8 deletions(-) -- 2.17.1 diff --git a/arch/powerpc/kernel/.gitignore b/arch/powerpc/kernel/.gitignore index c5f676c3c224..67ebd3003c05 100644 --- a/arch/powerpc/kernel/.gitignore +++ b/arch/powerpc/kernel/.gitignore @@ -1 +1,2 @@ +prom_init_check vmlinux.lds diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile index 56dfa7a2a6f2..07bf5a45f176 100644 --- a/arch/powerpc/kernel/Makefile +++ b/arch/powerpc/kernel/Makefile @@ -184,15 +184,13 @@ extra-$(CONFIG_ALTIVEC) += vector.o extra-$(CONFIG_PPC64) += entry_64.o extra-$(CONFIG_PPC_OF_BOOT_TRAMPOLINE) += prom_init.o -ifdef CONFIG_PPC_OF_BOOT_TRAMPOLINE -$(obj)/built-in.a: prom_init_check +extra-$(CONFIG_PPC_OF_BOOT_TRAMPOLINE) += prom_init_check -quiet_cmd_prom_init_check = CALL $< - cmd_prom_init_check = $(CONFIG_SHELL) $< "$(NM)" "$(obj)/prom_init.o" +quiet_cmd_prom_init_check = PROMCHK $@ + cmd_prom_init_check = $(CONFIG_SHELL) $< "$(NM)" $(obj)/prom_init.o; touch $@ -PHONY += prom_init_check -prom_init_check: $(src)/prom_init_check.sh $(obj)/prom_init.o - $(call cmd,prom_init_check) -endif +$(obj)/prom_init_check: $(src)/prom_init_check.sh $(obj)/prom_init.o FORCE + $(call if_changed,prom_init_check) +targets += prom_init_check clean-files := vmlinux.lds