From patchwork Mon Jan 29 17:00:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 767423 Delivered-To: patch@linaro.org Received: by 2002:adf:ee41:0:b0:33a:e5bd:fedd with SMTP id w1csp987382wro; Mon, 29 Jan 2024 09:03:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8qu5yP9JY4qLYk/RHbx4AO9uxJZxWjU1qBVYtbzNJLaa8J0tDEK7D8eKW+I++R1b/o3kw X-Received: by 2002:ac8:5c4c:0:b0:42a:b1af:2c9a with SMTP id j12-20020ac85c4c000000b0042ab1af2c9amr301956qtj.125.1706547803896; Mon, 29 Jan 2024 09:03:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706547803; cv=none; d=google.com; s=arc-20160816; b=MAZn4ER60YNlOaheJVC7/SKzYvx58puDzGcBsT5NxxtcYqs5+1eLrkOu4awDIVLU80 JqAAYpB2gQ2QC7NFkwfQG8eCBLZoO18yJmMqfYymm2+ZDH4FTU067AAkd1kIyERYotlN Ip9B4KHJT5cyEL+mduFuJZabYlMChQOSy7LyB5mSx+vcygz8ysXyyNmI0UyBXud4jQOJ 4lZAdqFTEbhUWab/BCN6jtpWOm64M7cpslNYPnnBAVhJRd6V93eOFjXqdc6hBfhUBtfA HuvmJqTqBQTiTtJ6AUA0zRsYOu/8mueeqwcpdxLGLkIxJOjQEBBp0rJ8JFpe6+Lw+cF/ HQBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=GusI8HUqXqctRCLaiBIZ31PVThLOe2s7yLwU52A1msc=; fh=cZjg3nIhFSiKB8Nyg8pnm3QGJ/LNPcbCk66wtmY9nCU=; b=ui7G+JTVT4yjXol/Lm5atYvXA0LBRd+Oe09Lm96tBPSFoolJ51tAq8ADrHxWDF6wWL ztnpoQFTVEsov8GmVn303GOW/r5vwduH4Ve8pTGePIJZoQ2fQCEolimFH62RjgQptp+x NZRFVn1fWrERyCPTdC9P7vZP7NTZjy4q3BDH7Yp/KRBd0d6tTmyGosEzlK6y4Ro46eP9 GHJ79NEjfXqDRK5oKvGNAWbTR673qzhBhRMEfBo5NrljqB2/ifCHYVl+WJIcvH/462Qp 4i4EdSMVjUZ/YEsegvYN20f9tDZckTJzGfgxRh4OLcxZfG2Af+ndjFaSmOM+J1Zvm1yH yvew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=e6s7wYZQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y10-20020a05622a164a00b0042a084929d8si1227342qtj.787.2024.01.29.09.03.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jan 2024 09:03:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=e6s7wYZQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUUzv-00038f-Vf; Mon, 29 Jan 2024 12:00:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUUzr-000362-Ez for qemu-devel@nongnu.org; Mon, 29 Jan 2024 12:00:36 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUUzp-0007NI-3i for qemu-devel@nongnu.org; Mon, 29 Jan 2024 12:00:35 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-339289fead2so2460859f8f.3 for ; Mon, 29 Jan 2024 09:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706547631; x=1707152431; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GusI8HUqXqctRCLaiBIZ31PVThLOe2s7yLwU52A1msc=; b=e6s7wYZQGc7cZirW8LtJDqlBpUUD4CTHIM0ItxZlnu0u0g1pCiAAtujFxwJuGIC4Xs i1034mHwUdvWo9+c+Nd39dVcNqfVP2rtvaIKd2bup2Xp/tADN4dE1rM1Wdl0fu2z1Nye XmeqK7tKYPGsz4fUigMQb6cMkwsmUlupvgFP8PIWjPxYHHJL4B2fad7UDVU9UCAZb6qM qm3yHtp7iebrMnxbXILgAhGekf/kcKLObX5oOynQXGpsyWvy4VEqV0iutst8hMu7KWMS W4CbM9eUALe2Aivq5/VHFj5Wxr5wb/p7CFjqteKfsr74+0zEKs8qAjAnmPyk1DzDaGo3 rGZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706547631; x=1707152431; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GusI8HUqXqctRCLaiBIZ31PVThLOe2s7yLwU52A1msc=; b=ltePpcoGB8GEbKiX5QMIR3zxw7WvVQT/rAKmxFxf/uECfaSkDG5WxdBDmrn/sda9lJ EPAZXrXWc6D2BR6zr60pIRY8LqAl+AjT3+z/M6ZyHWAPaV5U1FKMHtbL7S1LRZnqAMPD YBpnE9/pTnusCKQxAbS2G1hYWYPM8PyvVsF4iQElg61ZaLBT3s27tBFqDTafSKSPD9M2 Xq9pUDXVbVHcTb0HdRK0mU79x3Fg9nDGRuOmJMh5apQtmxjximKwZVLWG+ZJFU67Zc+p Adxk/IMw2iPSBC5vuGYtx1y2cDyFt6L+PAvSOBLdEV6mutfRiS6i8erjYK4zV3EdCcsR XEMA== X-Gm-Message-State: AOJu0YyatDyLgQA+6JyGVmL7UYxPo/eywVANH9r6ExYjyHWKazAw/+JQ MV4aBwC1Ij5wDovQ5kRkzbFvTAPvDE2riXGX0wO7D8wMJ4Up7moa8TYOsvmxemk= X-Received: by 2002:a5d:5cd0:0:b0:33a:df0d:98db with SMTP id cg16-20020a5d5cd0000000b0033adf0d98dbmr4261302wrb.5.1706547631087; Mon, 29 Jan 2024 09:00:31 -0800 (PST) Received: from m1x-phil.lan ([176.187.219.39]) by smtp.gmail.com with ESMTPSA id cx16-20020a056000093000b00337d5cd0d8asm8519505wrb.90.2024.01.29.09.00.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 29 Jan 2024 09:00:30 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Roman Kagan , qemu-devel@nongnu.org Cc: Thomas Huth , Paolo Bonzini , Anton Johansson , qemu-block@nongnu.org, =?utf-8?q?Philippe_Ma?= =?utf-8?q?thieu-Daud=C3=A9?= Subject: [PATCH] hw/hyperv: Include missing headers Date: Mon, 29 Jan 2024 18:00:28 +0100 Message-ID: <20240129170028.74012-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Include missing headers in order to avoid when refactoring unrelated headers: hw/hyperv/hyperv.c:33:18: error: field ‘msg_page_mr’ has incomplete type 33 | MemoryRegion msg_page_mr; | ^~~~~~~~~~~ hw/hyperv/hyperv.c: In function ‘synic_update’: hw/hyperv/hyperv.c:64:13: error: implicit declaration of function ‘memory_region_del_subregion’ [-Werror=implicit-function-declaration] 64 | memory_region_del_subregion(get_system_memory(), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/hyperv/hyperv.c: In function ‘hyperv_hcall_signal_event’: hw/hyperv/hyperv.c:683:17: error: implicit declaration of function ‘ldq_phys’; did you mean ‘ldub_phys’? [-Werror=implicit-function-declaration] 683 | param = ldq_phys(&address_space_memory, addr); | ^~~~~~~~ | ldub_phys hw/hyperv/hyperv.c:683:17: error: nested extern declaration of ‘ldq_phys’ [-Werror=nested-externs] hw/hyperv/hyperv.c: In function ‘hyperv_hcall_retreive_dbg_data’: hw/hyperv/hyperv.c:792:24: error: ‘TARGET_PAGE_SIZE’ undeclared (first use in this function); did you mean ‘TARGET_PAGE_BITS’? 792 | msg.u.recv.count = TARGET_PAGE_SIZE - sizeof(*debug_data_out); | ^~~~~~~~~~~~~~~~ | TARGET_PAGE_BITS hw/hyperv/hyperv.c: In function ‘hyperv_syndbg_send’: hw/hyperv/hyperv.c:885:16: error: ‘HV_SYNDBG_STATUS_INVALID’ undeclared (first use in this function) 885 | return HV_SYNDBG_STATUS_INVALID; | ^~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Manos Pitsidianakis --- BTW who maintains this code? $ ./scripts/get_maintainer.pl -f hw/hyperv/hyperv.c get_maintainer.pl: No maintainers found, printing recent contributors. get_maintainer.pl: Do not blindly cc: them on patches! Use common sense. --- hw/hyperv/hyperv.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c index 57b402b956..6c4a18dd0e 100644 --- a/hw/hyperv/hyperv.c +++ b/hw/hyperv/hyperv.c @@ -12,6 +12,7 @@ #include "qemu/module.h" #include "qapi/error.h" #include "exec/address-spaces.h" +#include "exec/memory.h" #include "sysemu/kvm.h" #include "qemu/bitops.h" #include "qemu/error-report.h" @@ -21,6 +22,9 @@ #include "qemu/rcu_queue.h" #include "hw/hyperv/hyperv.h" #include "qom/object.h" +#include "target/i386/kvm/hyperv-proto.h" +#include "target/i386/cpu.h" +#include "exec/cpu-all.h" struct SynICState { DeviceState parent_obj;