From patchwork Sun Mar 3 07:39:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 777647 Delivered-To: patch@linaro.org Received: by 2002:a5d:4b84:0:b0:33d:f458:43ce with SMTP id b4csp9784wrt; Sat, 2 Mar 2024 23:42:18 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVolX+FbcCRWOXRUJlUun12vCbpZy8a+GN20985gxQ9ybLul7DqRWCSJYOK4HTtboLbSLyPDNkzB+qqh40gSAOL X-Google-Smtp-Source: AGHT+IH3arL6cB8VgdA6FW26QoK5alGjVzbAWxz1pMRenlQgf7D2otRb36SuXIwP3JtDll0ImlzD X-Received: by 2002:a05:6870:f108:b0:220:1e14:6bee with SMTP id k8-20020a056870f10800b002201e146beemr6311166oac.21.1709451738112; Sat, 02 Mar 2024 23:42:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1709451738; cv=none; d=google.com; s=arc-20160816; b=n0XawKp76F7a3d9HLf12oLNgPE732o2lOEGDR9NOopaoEvOIKY16ktnYJ8E4CrDRaJ WHKWgB9sDe7RWsDS48LfRMgQfBofL1Vf4GKM6EDqgWYaepoS2umbZcLHIWvbcJMucToP x3bZiiGHGppNgzacoDhiAxyq2oanZ6BtE0cGkTeAGEqZHX+Ph3Vz5g3ilAm1Otr4SF1R EV0Zjz17AriWctEWxqy+JnPCOkuFXzXM5QSsxNDmHF+1ZyMKWs4A+f7g7BKIRHkSYyyd 0DwjuKwlW74miv8PrWIzbWWxJUqOGn7got+OG9oJX3la3DGZ/HiCRXRSTqieCf/MxeZZ 1sBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=PP9/4HvWgjD9HmLif2UoHAoQNGaiaNjSmLJc1swp0OE=; fh=uU2/o+iea051wrZyurzaBewg07/rrSKUH+47oCShOJ8=; b=JcYGCT4ife2QIv/hjnCDKFWYuiIVwYZhdnnqHTELCAte2yc9mtXHF/xXQ734KBJCN8 59sqiDv3MuwQL/RoQng4LPIYMtFPUhoSvAzZoAi8azQ4/hjjCE3S3pI+D5i0sfnCth+i H+fratzMJlujEpS5na6jrxXhayw+SVBIQEtnDj5OJieLRqQHxvaw2pMFeaSEHSVEwrFG eleT8KNQIFWAJ2wGkNnb/iB1av+ooWBM9+iJSOwkN8ZxUxN2Pzi3WrJMx6usrv8zszqS /Mmg5hNq6rM7+7+CRyBZJNc4HWGVRGPBad+vDrWoaq5TJhyApFuv1Zus3gnoMiP+2PeF ZppQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k8-20020ac86048000000b0042e6d8b57f3si6758517qtm.763.2024.03.02.23.42.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Mar 2024 23:42:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rggS0-0001rS-08; Sun, 03 Mar 2024 02:40:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rggRy-0001qb-7H; Sun, 03 Mar 2024 02:39:58 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rggRw-0001lf-IF; Sun, 03 Mar 2024 02:39:57 -0500 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 5678A5275A; Sun, 3 Mar 2024 10:40:18 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 02EB68E84F; Sun, 3 Mar 2024 10:39:35 +0300 (MSK) Received: (nullmailer pid 1350616 invoked by uid 1000); Sun, 03 Mar 2024 07:39:34 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Peter Maydell , Thomas Huth , Michael Tokarev Subject: [Stable-7.2.10 53/54] tests/unit/test-blockjob: Disable complete_in_standby test Date: Sun, 3 Mar 2024 10:39:32 +0300 Message-Id: <20240303073934.1350568-6-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell The blockjob/complete_in_standby test is flaky and fails intermittently in CI: 172/621 qemu:unit / test-blockjob ERROR 0.26s killed by signal 6 SIGABRT 11:03:46 MALLOC_PERTURB_=176 G_TEST_SRCDIR=/Users/pm215/src/qemu-for-merges/tests/unit G_TEST_BUILDDIR=/Users/pm215/src/qemu-for-merges/build/all/tests/unit /Users/pm215/src/qemu-for-merges/build/all/tests/unit/test-blockjob --tap -k ----------------------------------- output ----------------------------------- stdout: # random seed: R02S8c79d6e1c01ce0b25475b2210a253242 1..9 # Start of blockjob tests ok 1 /blockjob/ids stderr: Assertion failed: (job->status == JOB_STATUS_STANDBY), function test_complete_in_standby, file ../../tests/unit/test-blockjob.c, line 499. Seen on macOS/x86_64, FreeBSD 13/x86_64, msys2-64bit, eg: https://gitlab.com/qemu-project/qemu/-/jobs/3872508803 https://gitlab.com/qemu-project/qemu/-/jobs/3950667240 Disable this subtest until somebody has time to investigate. Signed-off-by: Peter Maydell Message-Id: <20230317143534.1481947-1-peter.maydell@linaro.org> Signed-off-by: Thomas Huth (cherry picked from commit b6903cbe3a2e3feb7204636209b5607e70fee998) Signed-off-by: Michael Tokarev diff --git a/tests/unit/test-blockjob.c b/tests/unit/test-blockjob.c index c0426bd10c..a130f6fefb 100644 --- a/tests/unit/test-blockjob.c +++ b/tests/unit/test-blockjob.c @@ -531,6 +531,13 @@ int main(int argc, char **argv) g_test_add_func("/blockjob/cancel/standby", test_cancel_standby); g_test_add_func("/blockjob/cancel/pending", test_cancel_pending); g_test_add_func("/blockjob/cancel/concluded", test_cancel_concluded); - g_test_add_func("/blockjob/complete_in_standby", test_complete_in_standby); + + /* + * This test is flaky and sometimes fails in CI and otherwise: + * don't run unless user opts in via environment variable. + */ + if (getenv("QEMU_TEST_FLAKY_TESTS")) { + g_test_add_func("/blockjob/complete_in_standby", test_complete_in_standby); + } return g_test_run(); }