From patchwork Fri Mar 22 14:43:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 782227 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 456EF4DA14; Fri, 22 Mar 2024 14:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118707; cv=none; b=Bc9+e1zoVd6rV4J7VNR0JhEuPtcUUAxp00O7hjUzhTm9hb//ISRs1jNivH6hFMqWSVvlOvOg++ioNFvmTz8F+bsdAax8J53oTNnJsxFtfCrw9pJTctPcsn14oJa9xxXsSAP04WbIbBxJYzbCjy59mvRbNLo0LQ3mDnoGHNTHCA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118707; c=relaxed/simple; bh=z0Q1447+VXQ1c95jXZFQ+x38c2pAXex+0RvwMrg0i0M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nK3A5lGjhRY5fztww9ikV+XG0aE+xSfIO9L/l3yLKaV86R0mJtLdVsRXahBFKAYKhdfe0sOcCyGel1Hpf3OxNofTBZCjFj0Uy/tpJm1fZI66ok1egKn4oNPK9wEPSeXZms3TwiFE6E5TQW5XYTZhEjH+kMwkkOTJkSzE2TnAy4E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=APVllpdS; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="APVllpdS" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2d4360ab3daso35447681fa.3; Fri, 22 Mar 2024 07:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711118703; x=1711723503; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TciX4HiN46XXmyc3hzy4hKoPSxTKgXcyydo7DRa6ZT4=; b=APVllpdS+Xp+OF/dr45CJJhoaxWv/iy73NN2Ojc1jMbW2N4AY71KNPh6NQUb4Uh7rs 95I8XlXGWQ1a3RKGvNsJMQturnalKYPWxTykUJajpG1bOsJONJWpnnhPWg8TLSrUuDQP sXX3m9G8Bpnpdm/JoK/95AhDnAm+IqCz2KFz+dGci6EdvSQz7moIoHaaCE7nP5RdelxQ 8qKtvPHwe3N/FyMN+2QGiXa+xA1wsxRDvnJ+nNIPx8hi0HngmR6OLxj+UfrGw8pnhomZ sX9OctlUFVtxdEp0k4h6IzvgBDKkGpDkJNg19LK8hiwNIEHWot+Gyyzlx6RPa60eGqZw +zjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711118703; x=1711723503; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TciX4HiN46XXmyc3hzy4hKoPSxTKgXcyydo7DRa6ZT4=; b=jfxdU9YJhwXwRIK5R2ZBQVzzvJJTWLC9Vf5TYz1gIug9gz1RF4un4FenjmugnP/EUO rZFu/VNGGIgIOxL/nV3Na77UdDdc7xG8gT5hpb6QNqo4yB+F14r+8qPdH8am5jwxNu0c xarS7/RcYa38H6kD+q9SDl6dBSqjjHJnzeZNn7PQNO1DJIKumNHsWtJktXlQ6kCwjQPZ X0WellmR1oeFZLY/lSXFWzoxyQyMlMRowWQ8Y4gADX2d4zdYn+jJIO2xmLflfoA136Jp JQkvEYHtumYbHunwFOB1T2+ejZk7cdrSzt1bl29T17R/nmHDejjs3IQkKySpDXBQ4Lfn ltSg== X-Forwarded-Encrypted: i=1; AJvYcCW26NTqM1fWXBUjWIKWua352LcPPLHP4B0CRGMl9rau/CqupmhuguSgPOufPp6GMJOPxx3D4lhn2TgUeZcnBo7ZLggLHpVprbDRzLOL9LI+R8q8hAQ+AnaVZs8jga1LgkvH72Fb68Pobbz/oCbXiBTtEMYRKDYLKsufq+SdkpTvKmuGHdJBegypt5T/ X-Gm-Message-State: AOJu0Yyrb1rW8guUkGH3pS/T3WpDCsaYCi62QPvN1SdxeICCmrr9aQAc rRXl6DZV7C1y1Balzc2kKHQ7b0bo+AP7k3RYzB3JhZFxSmIOwI1g X-Google-Smtp-Source: AGHT+IFlVfO/3rSmnSFfsEbaTWG/rvRuZ6WdzzXtqSIhfCKde9Deb9cwHUkTZlWfUdAhPQOcipdW4A== X-Received: by 2002:a2e:95d3:0:b0:2d4:49d0:d20b with SMTP id y19-20020a2e95d3000000b002d449d0d20bmr1873600ljh.5.1711118702855; Fri, 22 Mar 2024 07:45:02 -0700 (PDT) Received: from prasmi.home ([2a00:23c8:2500:a01:7b89:721b:d6b0:d7e8]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c45cf00b0041466e03e55sm3911117wmo.0.2024.03.22.07.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 07:45:01 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Fabrizio Castro , Lad Prabhakar , Krzysztof Kozlowski Subject: [PATCH v4 1/5] dt-bindings: serial: renesas,scif: Move ref for serial.yaml at the end Date: Fri, 22 Mar 2024 14:43:51 +0000 Message-Id: <20240322144355.878930-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar In preparation for adding more validation checks move the ref for 'serial.yaml' to the end and also move reset check in 'allOf' block. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Krzysztof Kozlowski --- v3->v4 - no change v2->v3 - no change --- .../bindings/serial/renesas,scif.yaml | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml index 4610a5bd580c..af72c3420453 100644 --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml @@ -9,9 +9,6 @@ title: Renesas Serial Communication Interface with FIFO (SCIF) maintainers: - Geert Uytterhoeven -allOf: - - $ref: serial.yaml# - properties: compatible: oneOf: @@ -160,18 +157,21 @@ required: - clock-names - power-domains -if: - properties: - compatible: - contains: - enum: - - renesas,rcar-gen2-scif - - renesas,rcar-gen3-scif - - renesas,rcar-gen4-scif - - renesas,scif-r9a07g044 -then: - required: - - resets +allOf: + - $ref: serial.yaml# + + - if: + properties: + compatible: + contains: + enum: + - renesas,rcar-gen2-scif + - renesas,rcar-gen3-scif + - renesas,rcar-gen4-scif + - renesas,scif-r9a07g044 + then: + required: + - resets unevaluatedProperties: false From patchwork Fri Mar 22 14:43:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 782034 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5695C4DA04; Fri, 22 Mar 2024 14:45:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118708; cv=none; b=Xn43K1drMGUe8UbNDwx/HCqVGYIfxeaxc3IvhiHY0NYZr9RLn/lUd0SfQ6MmubWdVGBVK0npWycjjfIRR0GE44NLWJSBjFWaiuxlnR+BYdmWZS1S2kEhqBNTvr6IjMUsgZvBdYYSlFZrTeWhqwB4qJapomTA5vt88ixaNQQaHh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118708; c=relaxed/simple; bh=nQMrjmx7lgvEYfRwPyMU/m3B5DVzZbErmWc3hp0SIdM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ToAQsa08M1XGjdeuprGdzznhTILTOpU/GfRlUyNNLRgQNCXT9i1PuuM8dMlTWqzipzWFOI/mx9FPJYh2asichELQwtCQlgYLUHeQSbiEKSPvGllvpKqsMMbxjt+NOvRfCjGZbmQTVajumuxW3+7ydhkN/9Bi+8DNV3RdB+XT5Nw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g+AzHnAD; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g+AzHnAD" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4141156f245so15909135e9.2; Fri, 22 Mar 2024 07:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711118704; x=1711723504; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=730autSsxHiNL+j8Su0BEnmYSpQjBiOSWmu8ipKoYuM=; b=g+AzHnADdT+qrj6Jc2IsLiz5p1t9dGCpVFxYUH68uKtiqBoVtJhmums9SZSGn6subr 2XcuOxCTfXWXaq24bPmJMOSC74uRO/bGpp88lX2ZsrUXN8WnbFeYaVwDa0Y4jutAOVF7 OicMXH66Pp6flEtLQSriQ37ZHcxrguMLnvvxibzrliuJncn7PD3vpbk02P6OrV6qpp6L oEVehc9kI+VRsygF1ikDTQoJB2SYii3L50cWr0/J9OacyQBHFK6JQ9W953+jIRsUf8KK dpW87QNk+WCGuLi0DXi5vuBllceSYn9fAWwJi2xreu5jWTsa4euq6bfe+qne7ZuDpvoC xT1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711118704; x=1711723504; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=730autSsxHiNL+j8Su0BEnmYSpQjBiOSWmu8ipKoYuM=; b=KD7r6UfEZvLadLjuPKOoL+58yCC9RdFCDrb9klXbLuV9ixlYcEt/Kuj0RM9Rl/cNnU v6Fjs6ABep6nP9A5xqTmJ9Jpgk3Af04HImMVjwN2gZjECpdjdNKnbqKeVaUzt3JfCJUo hPbo2JVlK2VqtfZUbq2yfnCTT7XGcwksIG2UgdY2xA4ycQuwCh89Fb8m2ISpbaF0TGjJ nYEFQuHHdhELhLAWWL22HHjL9am2Z+shtujox/rP3mfhS2kciQMOPH68wSC3IJhtXtqO xYH0ycfWq9I3sAksoifMtHpxJVrlk71QRFH5Zq6pxGShShfysHS961ATJrC7MsZRsjkk x9CA== X-Forwarded-Encrypted: i=1; AJvYcCXtlIdTLVgLqJZSa7w29QgSLfAAS/6Y8Oy4CI0Cr/qKetxZweaThu43aiyo1OwASr1FSc+wLlKrzKFOfieZ0DO5rWMxQT5nWt9i7SPgqU0R7XLB7iuqJbQ7cWL+ApDAflz1hCJo4GfkBSy8Z0GidWy44NijO6a3gau6SVs3SYE09UJDNRq8NTGE35SE X-Gm-Message-State: AOJu0YxjWBT2+F3VJkgZP7unCtrvWMxh7lGbpCdbIb8WTdXQ9sMh+FHQ vQGFvT1imM8WLQzvSKQuR+5TDJr3RqWJYK3hmVIYBfWYIwPa1HwR X-Google-Smtp-Source: AGHT+IFt3u0l3sCLK1UPGdOdEjuEY+q9T7jOioz7zsCtUYJEa2Gsr1vYuNcs4ULg4z9cXjzTf99gsA== X-Received: by 2002:a05:600c:1f81:b0:414:a6d:52d8 with SMTP id je1-20020a05600c1f8100b004140a6d52d8mr1737187wmb.17.1711118704327; Fri, 22 Mar 2024 07:45:04 -0700 (PDT) Received: from prasmi.home ([2a00:23c8:2500:a01:7b89:721b:d6b0:d7e8]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c45cf00b0041466e03e55sm3911117wmo.0.2024.03.22.07.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 07:45:03 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt-names' Date: Fri, 22 Mar 2024 14:43:52 +0000 Message-Id: <20240322144355.878930-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar This commit adds support to validate the 'interrupts' and 'interrupt-names' properties for every supported SoC. This ensures proper handling and configuration of interrupt-related properties across supported platforms. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Conor Dooley --- v3->v4 - Reverted back to v2 version of the patch. - Used suggestion from Krzysztof for interrupts - Restored RB tag from Geert v2->v3 - Listed interrupts and interrupt-names for every SoC in if check --- .../bindings/serial/renesas,scif.yaml | 73 ++++++++++++++----- 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml index af72c3420453..eb2aa5e75e02 100644 --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml @@ -86,11 +86,6 @@ properties: oneOf: - items: - description: A combined interrupt - - items: - - description: Error interrupt - - description: Receive buffer full interrupt - - description: Transmit buffer empty interrupt - - description: Break interrupt - items: - description: Error interrupt - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: - description: Break interrupt - description: Data Ready interrupt - description: Transmit End interrupt + minItems: 4 interrupt-names: - oneOf: - - items: - - const: eri - - const: rxi - - const: txi - - const: bri - - items: - - const: eri - - const: rxi - - const: txi - - const: bri - - const: dri - - const: tei + minItems: 4 + items: + - const: eri + - const: rxi + - const: txi + - const: bri + - const: dri + - const: tei clocks: minItems: 1 @@ -173,6 +164,52 @@ allOf: required: - resets + - if: + properties: + compatible: + contains: + enum: + - renesas,rcar-gen1-scif + - renesas,rcar-gen2-scif + - renesas,rcar-gen3-scif + - renesas,rcar-gen4-scif + then: + properties: + interrupts: + maxItems: 1 + + interrupt-names: false + + - if: + properties: + compatible: + contains: + enum: + - renesas,scif-r7s72100 + then: + properties: + interrupts: + minItems: 4 + maxItems: 4 + + interrupt-names: + maxItems: 4 + + - if: + properties: + compatible: + contains: + enum: + - renesas,scif-r7s9210 + - renesas,scif-r9a07g044 + then: + properties: + interrupts: + minItems: 6 + + interrupt-names: + minItems: 6 + unevaluatedProperties: false examples: From patchwork Fri Mar 22 14:43:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 782226 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13B8250255; Fri, 22 Mar 2024 14:45:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118708; cv=none; b=lRo03ezc/1IEapFOIrUqOfxn/oSc1FcIHcwBNTDi3MDwFN4zeG2V5evxFLMhEQYaJaIpiHXuR9APweoxkZscX2A0pq1ts3yqshifBdVqikETX49mwAxQ2NFG2myQm8KvXV9iY9N4KlU2SpS7Up/iuS6JGX3x3YC46Qag44D3nsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118708; c=relaxed/simple; bh=pk0bhuxbVWLKZLYkS//DIr1PzZ7X1d8HhGL4EDlpJgA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GiWwXqQvLyKAWozKdGz8YHdVnwy9JBVLayWHhuJk1mgZZSjQv2RjhzTvbsNJwDQvm2NZ3CoKI6b8JqxF+AVP9HMVZ+ffFTqy0PVKGYW4WTZvko++Nb0gt39sZeS1tA2UKZ276Q1MibfTbrcRP4uAWTn7DQl8Va9dDI096uzkVOA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AwjdgMmA; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AwjdgMmA" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4147e135f4dso3325485e9.2; Fri, 22 Mar 2024 07:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711118705; x=1711723505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4uAQ4C9kulwxZznVlWW/8ebBG259lLBKIIu3Q2bFtY=; b=AwjdgMmADANnmvf+1nxf4Ht8giXSyyV+g5+H+XX8zlTz4ISbxVQzotJOxnZZjYWSVY QGOnoUMZjbbfEUvul9gGC7i9RLSvEW4vWR3RgqekY9CNVdpmdS0iwFJWznMptOaj3s5S UMIvH6NnEOmzPIcmxFe7nD4qa1HvUa0sQYmORES9GX2QySVBWxaYI3+J/VTyhu8qHYns udCS608+LQBm2yU2UnMpDBgWsn9vSujJL0dTqPZRRwxDs9Wmg3GiekBdDv/LgPDiZT5A IvAgQRLQNWwAtXAZWmvPEeYtKCB8rmS3Np3i0/FxZn7vNo+BhGHNiIVdtHl8PwkHOWwC aJog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711118705; x=1711723505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U4uAQ4C9kulwxZznVlWW/8ebBG259lLBKIIu3Q2bFtY=; b=T5xdbGrfV5rQeGNxpGw5i4rKmB+pTYwMhb6lOnJpmtyKa1IycnD36OIBfBpj20TVla eJiaonUla8lpb/jUOYY+53ZSm/5Y5nZMVttAaHHeLkdgNqB5yFgsuPbpcBpSkcYX/buu XdB6fJ8Sjlnvr0+tZLUuQr0VotmhLPza/XvDKfo7COUbkD+6PndBK5VitWo5L+iY2SZI 5m7LJPkry8bymRYCOCmYPPccaaWQqnuJE1GDgN3Gk1uTsMrYN95p7/7NhsgeNFDIf1v+ vm/F1z+i1+gufmKgVy/wS87fdK9mlSvsK15UmJ77wf1PlH5G6nDyI2An2UWuWelonA42 jUYw== X-Forwarded-Encrypted: i=1; AJvYcCVcFwbXkMxfm3iyhSgiBWZUfAA4Xs2agF7ipvf+4fgLa4ZEfWtwKdYzH5sklM4NOeX8SE+tFn3ebBFIPAJVGca5ilBYNJb3Ka/4BsJk05EyFhPyEpIj8NQlOgl4wFaHRKOnaaKHnFe9vzFWAKL0coAK1GMHd8PlOOPmhrxR54KSXMPlv+zDm5Dvi9pb X-Gm-Message-State: AOJu0YwMP2eKiBQN4Kk/q0Q3BiGqjzybhgaGKXvwsQtUVt73DpT6Ut0Z MgE7oM50EVpJOzf/Qtt30gbX60BMF2DKL7uEtCpvNDa+l+xxWzec X-Google-Smtp-Source: AGHT+IGsrDk14rRDiD9xfpqQ3L+sJLzhHcEk40nAr7Q2VFynMk7I/HH3yiJpFgIkH85Gg0jC02iVOg== X-Received: by 2002:a05:600c:1395:b0:414:7ddd:b92e with SMTP id u21-20020a05600c139500b004147dddb92emr887641wmf.39.1711118705493; Fri, 22 Mar 2024 07:45:05 -0700 (PDT) Received: from prasmi.home ([2a00:23c8:2500:a01:7b89:721b:d6b0:d7e8]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c45cf00b0041466e03e55sm3911117wmo.0.2024.03.22.07.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 07:45:04 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 3/5] dt-bindings: serial: renesas,scif: Make 'interrupt-names' property as required Date: Fri, 22 Mar 2024 14:43:53 +0000 Message-Id: <20240322144355.878930-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar As all the SoCs having multiple interrupts have 'interrupt-names' property in their respective DTSIs, make 'interrupt-names' property as required so that we can validate them using dtbs_check. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven --- v3->v4 - New patch Note, we need patch [0] to be applied or else we might see dtbs_check warning. [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240318174345.46824-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ --- Documentation/devicetree/bindings/serial/renesas,scif.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml index eb2aa5e75e02..c13b31c28049 100644 --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml @@ -179,6 +179,9 @@ allOf: maxItems: 1 interrupt-names: false + else: + required: + - interrupt-names - if: properties: From patchwork Fri Mar 22 14:43:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 782033 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F08B8524C4; Fri, 22 Mar 2024 14:45:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118709; cv=none; b=KLZwQHcK+LjDnGCGrUpHJAS0oPKcID2+QqQ7oHKKHtRB0j7g3UDi6gEpwTlBKUiTp37DwlHgskSl9fdRp0UCrTzaM1Qz1w4Gtw1JZ5Px0TUSTrsqghxTyiaIPwKBx3UcCq6L20q4hLvp7lVqwAGsv2ThpfqhhQkRrHW3qr805Oo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118709; c=relaxed/simple; bh=g+RQD8J0qS3SytRNhm+UmAr7htbucfmWhB9EAuKMhvI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iwstUXvzK20peIU3G81FjWNv0v9rgdSxYj2qFIv9myL9khRLXuTRbInZaMnCasrRYBtGBLTV6XvrMNj72yWYT8PtuyVxrS2bHVPeZgr/bsJCvvYBXZiu6J4ORR9g2EXg8ZuXVKEcWvDZZAxTSnOMwAdfJZmypsGwQUihXB59BTQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LJXvxTBN; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LJXvxTBN" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4147e283c4cso2675185e9.1; Fri, 22 Mar 2024 07:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711118706; x=1711723506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kLns8RKM6yyrwkzL4avpb8ODJ5XJkQjW3psT8hjt2To=; b=LJXvxTBNzdGJyVD7s4pwlW51b5jCFHVyiFSPzt89EpyWEi7rj/f4l0B3WZr2b0MdkU oaL8/xMgpH+z8u/mNaoBo5on91Z+8BWqOAv/vSlrViKICGeScuS3Pfc7w1Bbngmd/ixN 4hfDpmXTutmex3eDv9OMAsW8WInUMlq5wULs5gPVAkAPzzPTKxp9/maakzIOraBkxk78 yRV/V7DlYW0JdiiGVsGaEXczwPm+dLT7Ukpds8mcudWyvvpiMQzUEGrzhfu+xnWLuLqy oPXtrY+ALrIqnlBRaD9+vXy1AtKuSkr1jXY6Af6WVeGnevsal6igK5BHUCP8j/L9izlL zT+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711118706; x=1711723506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kLns8RKM6yyrwkzL4avpb8ODJ5XJkQjW3psT8hjt2To=; b=WUvqsEpIQInbpMbHanjHYUXA5yIiDLz4Ih+UHYtW4IrwoCJoExPijyVU4Hp8NW9/Q+ FgAm8+TxbgY3LXOrvAdO/iMqwgirA05sR4Y0XDd0MFqlrBGwH4FcoHfyErfiPYaMOAhC OrdV6NyGDix80UYzEe4NZY5GZ9bqBDEv2g5y5vpHKViztr+gxKiSdLsdPjzTWHg+UffB 20RIh0ALDf+eSEZ8HV21EBMMGV91z5/PpI8uaLVm4dl6313wwHqZkVdlEq5w4tf+hEA8 ey8pm/pXk+P0UWoXrgFWyPpcKh+e1U2UwlAdlPaYkDYGZ0S0ARdOvUYGes2UVEHTn3/3 fMRg== X-Forwarded-Encrypted: i=1; AJvYcCUv/K/5uV5mT488VweajDk3uxm2135DiSe08EHPTE6UtN+l/kwxIshBPh/DgjZKHwoMyvJh9SicsO0c6ckvb0Kis1hEXbfj1J9HMvBqqaJ8IT/msWCE0BhitooSGrEbJpCuHH687Dw8Yz1XN7pPr1Snv1PGh71pfrah0g4O1cv1NuMWGfvLgT1wjQbu X-Gm-Message-State: AOJu0Yyxo5qlauWEsf/GNbwXJ2+5sGqsVUH93iCnocqFizdZs4BvJRe7 P0gtRpWBRL82n13JNozr4RqemB6oUZZgRrRhsAJ0gm6zsd/pN0lv X-Google-Smtp-Source: AGHT+IGTZPV12v//RdDHBXpoYNpVGnnaOFZ8Z5wA7EFDWWyCOePwwkT3bh6ponH+9B0fEMDg/9o9Hw== X-Received: by 2002:a05:600c:5190:b0:414:7e94:b33b with SMTP id fa16-20020a05600c519000b004147e94b33bmr668860wmb.17.1711118706397; Fri, 22 Mar 2024 07:45:06 -0700 (PDT) Received: from prasmi.home ([2a00:23c8:2500:a01:7b89:721b:d6b0:d7e8]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c45cf00b0041466e03e55sm3911117wmo.0.2024.03.22.07.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 07:45:05 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 4/5] dt-bindings: serial: Add documentation for Renesas RZ/V2H(P) (R9A09G057) SCIF support Date: Fri, 22 Mar 2024 14:43:54 +0000 Message-Id: <20240322144355.878930-5-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar Document support for the Serial Communication Interface with FIFO (SCIF) available in the Renesas RZ/V2H(P) (R9A09G057) SoC. The SCIF interface in the Renesas RZ/V2H(P) is similar to that available in the RZ/G2L (R9A07G044) SoC, with the following differences: - RZ/V2H(P) SoC has three additional interrupts: one for Tx end/Rx ready and two for Rx and Tx buffer full, all of which are edge-triggered. - RZ/V2H(P) supports asynchronous mode, whereas RZ/G2L supports both synchronous and asynchronous modes. - There are differences in the configuration of certain registers such as SCSMR, SCFCR, and SCSPTR between the two SoCs. To handle these differences in the driver, a new SoC-specific compatible string is added, ensuring proper handling of the unique features and register configurations of the RZ/V2H(P) SoC. Signed-off-by: Lad Prabhakar Reviewed-by: Conor Dooley Reviewed-by: Geert Uytterhoeven --- v3->v4 - Appended the interrupts instead of adding SoC specific - Added restriction for clocks and reset v2->v3 - Added SoC specific compat string --- .../bindings/serial/renesas,scif.yaml | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml index c13b31c28049..93fc7b75e2e5 100644 --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml @@ -79,6 +79,8 @@ properties: - renesas,scif-r9a08g045 # RZ/G3S - const: renesas,scif-r9a07g044 # RZ/G2{L,LC} fallback + - const: renesas,scif-r9a09g057 # RZ/V2H(P) + reg: maxItems: 1 @@ -93,6 +95,9 @@ properties: - description: Break interrupt - description: Data Ready interrupt - description: Transmit End interrupt + - description: Transmit End/Data Ready interrupt + - description: Receive buffer full interrupt (EDGE trigger) + - description: Transmit buffer empty interrupt (EDGE trigger) minItems: 4 interrupt-names: @@ -104,6 +109,9 @@ properties: - const: bri - const: dri - const: tei + - const: tei-dri + - const: rxi-edge + - const: txi-edge clocks: minItems: 1 @@ -160,6 +168,7 @@ allOf: - renesas,rcar-gen3-scif - renesas,rcar-gen4-scif - renesas,scif-r9a07g044 + - renesas,scif-r9a09g057 then: required: - resets @@ -209,9 +218,30 @@ allOf: properties: interrupts: minItems: 6 + maxItems: 6 interrupt-names: minItems: 6 + maxItems: 6 + + - if: + properties: + compatible: + contains: + const: renesas,scif-r9a09g057 + then: + properties: + clocks: + maxItems: 1 + + clock-names: + maxItems: 1 + + interrupts: + minItems: 9 + + interrupt-names: + minItems: 9 unevaluatedProperties: false From patchwork Fri Mar 22 14:43:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 782225 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 324A154BD3; Fri, 22 Mar 2024 14:45:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118712; cv=none; b=V9/JKcx3EIkn60ohFWn393N/pcJr7J3wwURBysBzeGlkJ4HF0P7Ki6J4MQoKC0P57SgcQFUA4tgYpn7QI4pU+82/V9UD5hL8BAYig1cQPKVPvyIOGlNE5CDG5cDycXYRPPxrSa3rUHkH2O5/SsnxSu/L5CerbHuSxv79tYWZP9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711118712; c=relaxed/simple; bh=veb2SWtHL0Ox9QO3zZylkMTzcpBgXqQeJZKsGDwqEUg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=J1ycfjqDeRnOpAABg+oQs0p3iwxDQvSAA2AxqnRp4znDBqXp5DAQckHe5r1Ve4nQDSzTsSI1qXQrfvUX+S4XWGgZrhB0/XQNvdl44OqBg74RyduVACkxvRkwhhvc40UiFMXkqedx+PsZJYjN06WwJFBkDYElViycr63L/8cRlQ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GxmfFUFc; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GxmfFUFc" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4147e3e4d3cso2484845e9.2; Fri, 22 Mar 2024 07:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711118707; x=1711723507; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GWuEvV0rvpO/l7LvIGHT/JLAEhFTYoLZLqtwl5iRm64=; b=GxmfFUFckVSHvrdQKxawyNBJ3Am2rTfgeAXR+PLnVUERvsp973ZE6FtoJyOzw2N9ZQ tBCRhUf6d2ebKV/exxX365IiUdU6vrqVakHVFOcgrLQ3FoMSdXSWexBIFvkbvXyZgPck XHz1RQMuFWZaY2r/lzlvu55Lb17/Ehd5T4/Qa5L15zOQjFQQbNkDcaM0cOZENNUTy8Kr 6PoVzJg0K3BuJaMACogkI+PVQBxqmJK8ahOTbrLQ11fY8qjAQJpM6aG7PTuckien+HHC zb3FQ2n3iVU8IOu8S0roubqqEYFcPRQeGr4vr+pcDMQUro17VxD097MbfSNyt2NwIwMe hxjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711118707; x=1711723507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GWuEvV0rvpO/l7LvIGHT/JLAEhFTYoLZLqtwl5iRm64=; b=pFlVODu/GlxaZC/5ez+XR8UT3TYson36FW4wUBKoKyJN5Udad/vqmaVpT/XdDOOeNp ++lgicMhaK/gY6K27Qyc8CLAJvgx/RnYMTxMrkoiLFebHszBN5vhPlaphKtQlaDRthJX u6zeVVwY1b5wLtIHBgCP6k5SmzQcbFCB4lGJozzFhLkLsJtlFZVmEIjdXEgQmUEZSvDD E98QARyOwKuoLqZqgXsOJ1Iv+2CRpbefT3l1B/HaK7CrZReAuNimWeArIT1Xmc5JKyv9 L3t8/hzWeoRMnqqjMW3Cj3rfym7p5Gk4CERw2kv1HRQ1cEMxFxxG5pyxZyn2fwvELQcF Hx0g== X-Forwarded-Encrypted: i=1; AJvYcCVXgJqJGXKKke03JpsvECXRSIqvMqTBIsMCSFtYSJZcl0BKpD5S+SoHOywU6ZztO4cJYQZD/aFPnWczJjjUWgQGgQt/thOO+D+ZOQ0WST4EGXUA/zyIwZ18m09Wm2qRj0WwiJDgzHQPOxbG8KgSbM9xuDNsHwSrjkMuBVTgSxM9rQUsHZL9KF4JNQAx X-Gm-Message-State: AOJu0Yy+7YLsGun8nSnOdPpo5vuK3t+TpZW8wOvFKPI51OLIXHNnbaxT 5Ega546BE9dRZsHOgRYtNzY94qTyTAY/SMdUIYQ0+qJ3MUBbppLA X-Google-Smtp-Source: AGHT+IGjPztaqKpu596k3blnST+nfDPu+lVA/PnAdQ4mezi8JzRKgF2wtriu9oc4aDkqJvhuMV83+Q== X-Received: by 2002:a05:600c:6a85:b0:414:6638:4507 with SMTP id jl5-20020a05600c6a8500b0041466384507mr1723116wmb.16.1711118707528; Fri, 22 Mar 2024 07:45:07 -0700 (PDT) Received: from prasmi.home ([2a00:23c8:2500:a01:7b89:721b:d6b0:d7e8]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c45cf00b0041466e03e55sm3911117wmo.0.2024.03.22.07.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 07:45:06 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 5/5] serial: sh-sci: Add support for RZ/V2H(P) SoC Date: Fri, 22 Mar 2024 14:43:55 +0000 Message-Id: <20240322144355.878930-6-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20240322144355.878930-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar Add serial support for RZ/V2H(P) SoC with earlycon. The SCIF interface in the Renesas RZ/V2H(P) is similar to that available in the RZ/G2L (R9A07G044) SoC, with the following differences: - RZ/V2H(P) SoC has three additional interrupts: one for Tx end/Rx ready and two for Rx and Tx buffer full, all of which are edge-triggered. - RZ/V2H(P) supports asynchronous mode, whereas RZ/G2L supports both synchronous and asynchronous modes. - There are differences in the configuration of certain registers such as SCSMR, SCFCR, and SCSPTR between the two SoCs. To handle these differences on RZ/V2H(P) SoC SCIx_RZV2H_SCIF_REGTYPE is added. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven --- Hi Geert, To keep the changes minimal I've added a new regtype instead of port type. Cheers, Prabhakar v3 - > v4 - Added SCIx_RZV2H_SCIF_REGTYPE to handle the differences on the RZ/V2H(P) SoC v2 - > v3 - new patch --- drivers/tty/serial/sh-sci.c | 55 +++++++++++++++++++++++++++++++++---- include/linux/serial_sci.h | 1 + 2 files changed, 51 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index a85e7b9a2e49..297787dc5c1c 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -317,6 +317,37 @@ static const struct sci_port_params sci_port_params[SCIx_NR_REGTYPES] = { .error_clear = SCIF_ERROR_CLEAR, }, + /* + * The "SCIF" that is in RZ/V2H(P) SoC is similar to one found on RZ/G2L SoC + * with below differences, + * - Break out of interrupts are different: ERI, BRI, RXI, TXI, TEI, DRI, + * TEI-DRI, RXI-EDGE and TXI-EDGE. + * - SCSMR register does not have CM bit (BIT(7)) ie it does not support synchronous mode. + * - SCFCR register does not have SCFCR_MCE bit. + * - SCSPTR register has only bits SCSPTR_SPB2DT and SCSPTR_SPB2IO. + */ + [SCIx_RZV2H_SCIF_REGTYPE] = { + .regs = { + [SCSMR] = { 0x00, 16 }, + [SCBRR] = { 0x02, 8 }, + [SCSCR] = { 0x04, 16 }, + [SCxTDR] = { 0x06, 8 }, + [SCxSR] = { 0x08, 16 }, + [SCxRDR] = { 0x0a, 8 }, + [SCFCR] = { 0x0c, 16 }, + [SCFDR] = { 0x0e, 16 }, + [SCSPTR] = { 0x10, 16 }, + [SCLSR] = { 0x12, 16 }, + [SEMR] = { 0x14, 8 }, + }, + .fifosize = 16, + .overrun_reg = SCLSR, + .overrun_mask = SCLSR_ORER, + .sampling_rate_mask = SCI_SR(32), + .error_mask = SCIF_DEFAULT_ERROR_MASK, + .error_clear = SCIF_ERROR_CLEAR, + }, + /* * Common SH-3 SCIF definitions. */ @@ -758,7 +789,7 @@ static void sci_init_pins(struct uart_port *port, unsigned int cflag) } serial_port_out(port, SCPDR, data); serial_port_out(port, SCPCR, ctrl); - } else if (sci_getreg(port, SCSPTR)->size) { + } else if (sci_getreg(port, SCSPTR)->size && s->cfg->regtype != SCIx_RZV2H_SCIF_REGTYPE) { u16 status = serial_port_in(port, SCSPTR); /* RTS# is always output; and active low, unless autorts */ @@ -2120,8 +2151,9 @@ static void sci_set_mctrl(struct uart_port *port, unsigned int mctrl) if (!(mctrl & TIOCM_RTS)) { /* Disable Auto RTS */ - serial_port_out(port, SCFCR, - serial_port_in(port, SCFCR) & ~SCFCR_MCE); + if (s->cfg->regtype != SCIx_RZV2H_SCIF_REGTYPE) + serial_port_out(port, SCFCR, + serial_port_in(port, SCFCR) & ~SCFCR_MCE); /* Clear RTS */ sci_set_rts(port, 0); @@ -2133,8 +2165,9 @@ static void sci_set_mctrl(struct uart_port *port, unsigned int mctrl) } /* Enable Auto RTS */ - serial_port_out(port, SCFCR, - serial_port_in(port, SCFCR) | SCFCR_MCE); + if (s->cfg->regtype != SCIx_RZV2H_SCIF_REGTYPE) + serial_port_out(port, SCFCR, + serial_port_in(port, SCFCR) | SCFCR_MCE); } else { /* Set RTS */ sci_set_rts(port, 1); @@ -3224,6 +3257,10 @@ static const struct of_device_id of_sci_match[] __maybe_unused = { .compatible = "renesas,scif-r9a07g044", .data = SCI_OF_DATA(PORT_SCIF, SCIx_RZ_SCIFA_REGTYPE), }, + { + .compatible = "renesas,scif-r9a09g057", + .data = SCI_OF_DATA(PORT_SCIF, SCIx_RZV2H_SCIF_REGTYPE), + }, /* Family-specific types */ { .compatible = "renesas,rcar-gen1-scif", @@ -3534,6 +3571,13 @@ static int __init rzscifa_early_console_setup(struct earlycon_device *device, return early_console_setup(device, PORT_SCIF); } +static int __init rzv2hscif_early_console_setup(struct earlycon_device *device, + const char *opt) +{ + port_cfg.regtype = SCIx_RZV2H_SCIF_REGTYPE; + return early_console_setup(device, PORT_SCIF); +} + static int __init scifa_early_console_setup(struct earlycon_device *device, const char *opt) { @@ -3554,6 +3598,7 @@ OF_EARLYCON_DECLARE(sci, "renesas,sci", sci_early_console_setup); OF_EARLYCON_DECLARE(scif, "renesas,scif", scif_early_console_setup); OF_EARLYCON_DECLARE(scif, "renesas,scif-r7s9210", rzscifa_early_console_setup); OF_EARLYCON_DECLARE(scif, "renesas,scif-r9a07g044", rzscifa_early_console_setup); +OF_EARLYCON_DECLARE(scif, "renesas,scif-r9a09g057", rzv2hscif_early_console_setup); OF_EARLYCON_DECLARE(scifa, "renesas,scifa", scifa_early_console_setup); OF_EARLYCON_DECLARE(scifb, "renesas,scifb", scifb_early_console_setup); OF_EARLYCON_DECLARE(hscif, "renesas,hscif", hscif_early_console_setup); diff --git a/include/linux/serial_sci.h b/include/linux/serial_sci.h index 1c89611e0e06..0f2f50b8d28e 100644 --- a/include/linux/serial_sci.h +++ b/include/linux/serial_sci.h @@ -37,6 +37,7 @@ enum { SCIx_SH7705_SCIF_REGTYPE, SCIx_HSCIF_REGTYPE, SCIx_RZ_SCIFA_REGTYPE, + SCIx_RZV2H_SCIF_REGTYPE, SCIx_NR_REGTYPES, };