From patchwork Wed Oct 2 12:25:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 174990 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp689358ill; Wed, 2 Oct 2019 05:26:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqyAK16wS25pQcSamNoASNtHrk+5PZUHGtEI/DkgJL03b49MglUTc44WWvpYtdNNlPfyBOjq X-Received: by 2002:aa7:df14:: with SMTP id c20mr3423419edy.133.1570019173645; Wed, 02 Oct 2019 05:26:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570019173; cv=none; d=google.com; s=arc-20160816; b=yqWkagwhBJoqX4xjlt3DEZRAcreNTMMrInFYnzadDnDLRLfqwPTwQIu6Rg4EHVMfV/ MioL7QWbr2eTZV6IpJJyd1KKINFwO4PRwxD478s+3KuRJ+0Mhdy6gEWGj9Byyv1pXyCn fYyJlfvyQk18Xj5RsS5otfOolVqHgwzcZQ1Ld7qvtv5IVVKT2d/UHaPog/PLGSe2KYck E8PUZtLuAiM9DugiRBvtSMohQrQ3BUGE6sC3labF1FqrM7YPIoLCEXo0OLOl6nweXa6c drAbb+yBFIg6ytAZAIo/ZEQM9azP9k6u1Wmd/jjmDJqDQ1axbNsPh3EMJZZrxes3cvOO QAlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=EDYFrWfYHk5McenIprwnW2MZAkgJrfgPI50SZBwt2Ak=; b=tmSfmDYlOXAeGZhbTaKAEuqCw5dxRM6IJlLeOrqSQ492dXDh9Fr3TFyOIylOw09tVe 6te0/YKX521BupTV5mAs4O20Mb/x3LkGNRe4mqsnC4iu9cNTi7z8RtVutePW0nBXuB/i vs4rRakNhi3GxEeySfk0XqecJCR39dWNXbTMnagk/a2qp/bwfYjsf9ZFhcwfKPVLrF39 9QylF+HHbglmLALja4LfO4vU7MyuDo19bVBn0UPSm0sLVOjeSW3AvOEha0D3TGY8Nt5M LYUkqCzXaxF7x+k7bIN4ElKszlIjZfPcfgvLCOt3dWXB7RUOqKBSebRWmfmos2VoGht2 Mnkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=B0sleF8C; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j18si10619185ejv.201.2019.10.02.05.26.13; Wed, 02 Oct 2019 05:26:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=B0sleF8C; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbfJBM0N (ORCPT + 14 others); Wed, 2 Oct 2019 08:26:13 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:33190 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbfJBM0M (ORCPT ); Wed, 2 Oct 2019 08:26:12 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x92CPxJx073005; Wed, 2 Oct 2019 07:25:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1570019159; bh=EDYFrWfYHk5McenIprwnW2MZAkgJrfgPI50SZBwt2Ak=; h=From:To:CC:Subject:Date; b=B0sleF8CLZS8WkFm0/QCECxFDGUTuy+0CYJ6QkvIiCQI+y/WMvo/RQLKn6JSGc2Bu W2KhAmDmai4/1lbVQkO38S3Ige5V4doXMW1HzyUZTUmSN7hbgArWkOSMij49khBchf OvAzJeBOV4fLagmSw+dzlnGnvLxERnX5XeGg4B+w= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x92CPxgN120509 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Oct 2019 07:25:59 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 2 Oct 2019 07:25:47 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 2 Oct 2019 07:25:47 -0500 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x92CPu7F109850; Wed, 2 Oct 2019 07:25:56 -0500 From: Tomi Valkeinen To: CC: , "H . Nikolaus Schaller" , Tomi Valkeinen , Adam Ford , Subject: [PATCH] drm/omap: fix max fclk divider for omap36xx Date: Wed, 2 Oct 2019 15:25:42 +0300 Message-ID: <20191002122542.8449-1-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The OMAP36xx and AM/DM37x TRMs say that the maximum divider for DSS fclk (in CM_CLKSEL_DSS) is 32. Experimentation shows that this is not correct, and using divider of 32 breaks DSS with a flood or underflows and sync losts. Dividers up to 31 seem to work fine. There is another patch to the DT files to limit the divider correctly, but as the DSS driver also needs to know the maximum divider to be able to iteratively find good rates, we also need to do the fix in the DSS driver. Signed-off-by: Tomi Valkeinen Cc: Adam Ford Cc: stable@vger.kernel.org --- drivers/gpu/drm/omapdrm/dss/dss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki Tested-by: Adam Ford diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index e226324adb69..4bdd63b57100 100644 --- a/drivers/gpu/drm/omapdrm/dss/dss.c +++ b/drivers/gpu/drm/omapdrm/dss/dss.c @@ -1083,7 +1083,7 @@ static const struct dss_features omap34xx_dss_feats = { static const struct dss_features omap3630_dss_feats = { .model = DSS_MODEL_OMAP3, - .fck_div_max = 32, + .fck_div_max = 31, .fck_freq_max = 173000000, .dss_fck_multiplier = 1, .parent_clk_name = "dpll4_ck",