From patchwork Thu Mar 28 17:36:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 784482 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09DEE446A5 for ; Thu, 28 Mar 2024 17:39:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711647582; cv=none; b=TA41RIAsxGVPi1Ch7KzJlO9orzE3w5R33gRgIsbKmYoT191U9tZq8SKrWHEHW+An+VopUahFST+6w/VJlohIsT7xf+temdmgt3YsPn4l6t1H67yEgPJamYjv+SK+YDcWTGIm2LYkskbrejb8cTOy02/gbaVFTR2ABWrOB+tNLWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711647582; c=relaxed/simple; bh=cBrfrQiFvoFDuBlj4G0fb4q9qQbWu3wbg1FHrBsVYcU=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=kQy4AeTw+PUWcQh+V+syD61DYqj7ChgJ4DBOzPNFEzhExKcCIldFZCvctCwqZTrLkaExf8ak4yPTLoI229EfWNFh1w0wSC1TJGHguec8WB+SeF88airmsbLeRVQ5TA00RBm2LFy56PmpW6WySRByhwDwPi7MSteMWYpnTyoUqn0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr; spf=pass smtp.mailfrom=freebox.fr; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b=ekDE738L; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=freebox.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b="ekDE738L" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d476d7972aso18997381fa.1 for ; Thu, 28 Mar 2024 10:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebox-fr.20230601.gappssmtp.com; s=20230601; t=1711647578; x=1712252378; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5+f/pRvSBwUdMhwHshcL4qVDbpYUW3TaHUiQYZdgH3I=; b=ekDE738LvzLTzlbZBNxWEamtTP1HWEg8vpYfcFee6UYcav51y/ApzbGDlrvaCJ6Sx7 8TtZ+8R2/uljKBoHQ0Q3QlOjVOQBivKTGPuW9ZIsek1asrqr/xnfYHpIXjkYg7y8ZyH1 /NYAV94Hf1TsD5qEmwy7sw8fa2KbQlX3l5RB6CyGydkN5bzqvJZI4oTH3QuiqLGrBbMk VaAR6gmLfX8ekfHK9fDheLOd4dkOKsk5rteWHENZQMl5KvKyyCP6ibioXXlYJQG0RBW4 BB1APMrF79N7NT7uVhfSgHFul5KNwxEWNhhNXIod4+q97JkFH7Fr6wuPXnsfRsDRs6UL BRqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711647578; x=1712252378; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5+f/pRvSBwUdMhwHshcL4qVDbpYUW3TaHUiQYZdgH3I=; b=w1Tx+8UI/t4PBGVEnjtb5Agof/lN4fbByl0RTjBmC3bOAUn41ThXZ6v9P/SGw8D42Q A5VtYp+7aScJlKcHTKf2ZxF4p1Y43Bwltg/C9lkO9VnOlEjNb6BA5ojJB0ksd6+k6Cxg 7q/lMxlZEypcHhVzgJulPWOLM0+lkKn3jFzpYgNHurMeRygni3iDK8EDRZ5YHFujO8TA vqNOZ6EB0zR0d/X25ij64uuiaMRxWudpbPu8h7gG6UdXWKJUBsSAc2yPbbXrxsSCPMtR qF/X7ANa1ujGvJIghHnI0wznWD+zuuouoBzWGAC0ShOZkZdgxlhRHaOLNe1J0shE2UKf JJ+Q== X-Gm-Message-State: AOJu0YxDjP8+eRlncmQGUX3+eX1nBY9VLsChvo34pqGic9NrMthbZFTG OziTC6bDHcb/yyRjBFyeOuVTKNoRqyB22PjizkarUyxehWxT88U6x/ACllvpajk= X-Google-Smtp-Source: AGHT+IFQBU18T0uIaawzs7r5eRFygg/fKL4VZsh6uLptoa/iScmPmWB9yGQE9bSbSrdNC/yyfCQCNQ== X-Received: by 2002:a2e:960e:0:b0:2d6:e0a9:9981 with SMTP id v14-20020a2e960e000000b002d6e0a99981mr2780077ljh.9.1711647578125; Thu, 28 Mar 2024 10:39:38 -0700 (PDT) Received: from [192.168.108.81] (freebox.vlq16.iliad.fr. [213.36.7.13]) by smtp.gmail.com with ESMTPSA id o10-20020a05600c510a00b004148a5e3188sm6066643wms.25.2024.03.28.10.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 10:39:37 -0700 (PDT) Message-ID: <84f20fb5-5d48-419c-8eff-d7044afb81c0@freebox.fr> Date: Thu, 28 Mar 2024 18:36:48 +0100 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop Content-Language: en-US From: Marc Gonzalez To: Kalle Valo , Jeff Johnson , ath10k Cc: wireless , DT , MSM , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson , Arnaud Vrac , Bjorn Andersson , Konrad Dybcio , Jami Kettunen , Jeffrey Hugo References: In-Reply-To: The ath10k driver waits for an "MSA_READY" indicator to complete initialization. If the indicator is not received, then the device remains unusable. cf. ath10k_qmi_driver_event_work() Several msm8998-based devices are affected by this issue. Oddly, it seems safe to NOT wait for the indicator, and proceed immediately when QMI_EVENT_SERVER_ARRIVE. Jeff Johnson wrote: The feedback I received was "it might be ok to change all ath10k qmi to skip waiting for msa_ready", and it was pointed out that ath11k (and ath12k) do not wait for it. However with so many deployed devices, "might be ok" isn't a strong argument for changing the default behavior. Signed-off-by: Pierre-Hugues Husson Signed-off-by: Marc Gonzalez --- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml index 9b3ef4bc37325..1680604cd1b7e 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml @@ -122,6 +122,13 @@ properties: Whether to skip executing an SCM call that reassigns the memory region ownership. + qcom,no-msa-ready-indicator: + type: boolean + description: + The driver waits for an MSA_READY indicator to complete init. + If the indicator is not received, interface remains unusable. + Pretending we received the indicator works around the issue. + qcom,smem-states: $ref: /schemas/types.yaml#/definitions/phandle-array description: State bits used by the AP to signal the WLAN Q6. From patchwork Thu Mar 28 17:38:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 784057 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0F237E788 for ; Thu, 28 Mar 2024 17:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711647582; cv=none; b=MAxAvMoq1Gz9Gxjh5Oy06xD+2M7fNnd68+06tNknPHFHg6119j4prlq681GwvDseEd9NKNzdodwKSDt1PBuEtwE/GYi2Eewmk1ENQ0zYGkHpF0kNR/CE1L30WvovEZdBJxfxoFBUBa0ukYMmank7Ir4HBy5XZXagdj85zPpGNhU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711647582; c=relaxed/simple; bh=49DbNazJb+51HgY87AZJqtIUYIPq9q2er45xmqJbnUs=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=PMs//ocGAodfffU50+aCOlTL9gHrCKKkcBxDI2MtrkEC8BcLVM47DqrR5zknc0Q0OGc66Q1rK2DSQxYn6X7pFjwKUYEwgEllf4IQeP+IJNFycmTj62ZFDZYcZbWZn2uu54YkxcCL7sSs0WekX7WJQvN553ancglwZs4lzQ5FcxM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr; spf=pass smtp.mailfrom=freebox.fr; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b=Vw5WMXx0; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=freebox.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b="Vw5WMXx0" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-515c198e835so1397295e87.3 for ; Thu, 28 Mar 2024 10:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebox-fr.20230601.gappssmtp.com; s=20230601; t=1711647579; x=1712252379; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SfZaLSH9sfGg1t8HLxW0Yvj6/ynr0oCl38jYR5QeVdw=; b=Vw5WMXx0HwaFvfiTGvTbQqs0YMmpiTpPAie7+/UtgOyX3JLDYqX0aDCiQmHiKibX1m 0T/KM7kTu0ZuNkr3URc8htunOoWX1cU7mkKs2brWS95jyeO9FmcDj/SYiU4GMgqArfSq q5f4gLHgdyfDa+XXf62Hb+pCIDLFQifFvSSdIz0WffYYHZxBmhhOxVUPn+EHnRshvTyC Azn8mNujH8sreDxZw/XhPncMPpCQkgTXpwf5fS7ht2neC2uzKx7u3dFSSSUdOAIANE/W CxBuued54aAiF5p867SMfObS+ER3wFhzCWr2qzN0RQUz56tzxMifvBiRD0i1CnRpo2gh v3ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711647579; x=1712252379; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SfZaLSH9sfGg1t8HLxW0Yvj6/ynr0oCl38jYR5QeVdw=; b=vJh8ijq2UsNMQSr+AmVryhgFxJKfjcbGV1oTWfztanUoVNPxa2ztTqDSKIJo1zVdx3 4qcLLIS75ERwbVY0h6JG5V3m2phFA98bC99cqUAjEqeHRIC6nm04zO98gnazqO5mMZvg VXbPtgP0oxJAuRzKd0uz5wll+I/7v10vGSXENDpzK8d209VAac1OCKnF8l/PvGGhQS1t ZyzDPmOxqXIc3Iml+VcItNINQDvu+Ccwmilkhk8cdVNi9fehfYOuqvuaI4S7FeB9IiUf VBl/3tfpAEg0fMCH2ezoDqqRre8/YVFtNQ1Z2LTTcD5FYRjf6y/OOWyxIVzqac5m6ME3 K8kA== X-Gm-Message-State: AOJu0YyBanspqEZHpnr/ZRCz0bKaSv/RGMAgIp29NiiWHYlQTgmIKBHD pmJMu0JUkNAx5zggkyqI+Jy3Oi/npYGPns26ejaP5zTcX8VhHTeiaOiVWr46k70= X-Google-Smtp-Source: AGHT+IHJtfFGSxBmjD4dNUNq1FwHZ5u75l7O+jY6a7/Z/DevlcIO9iRfXrTDZupUiLsfoB+TOXi3tw== X-Received: by 2002:a19:2d4c:0:b0:513:ed0f:36c9 with SMTP id t12-20020a192d4c000000b00513ed0f36c9mr84250lft.45.1711647578797; Thu, 28 Mar 2024 10:39:38 -0700 (PDT) Received: from [192.168.108.81] (freebox.vlq16.iliad.fr. [213.36.7.13]) by smtp.gmail.com with ESMTPSA id o10-20020a05600c510a00b004148a5e3188sm6066643wms.25.2024.03.28.10.39.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 10:39:38 -0700 (PDT) Message-ID: <45448d42-bc48-4b9e-adca-59a47e0674f5@freebox.fr> Date: Thu, 28 Mar 2024 18:38:15 +0100 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 2/3] wifi: ath10k: fake missing MSA_READY indicator Content-Language: en-US From: Marc Gonzalez To: Kalle Valo , Jeff Johnson , ath10k Cc: wireless , DT , MSM , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson , Arnaud Vrac , Bjorn Andersson , Konrad Dybcio , Jami Kettunen , Jeffrey Hugo References: In-Reply-To: The ath10k driver waits for an "MSA_READY" indicator to complete initialization. If the indicator is not received, then the device remains unusable. Several msm8998-based devices are affected by this issue. Oddly, it seems safe to NOT wait for the indicator, and proceed immediately when QMI_EVENT_SERVER_ARRIVE. fw_version 0x100204b2 fw_build_timestamp 2019-09-04 03:01 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0-01202-QCAHLSWMTPLZ-1.221523.2 Jeff Johnson wrote: The feedback I received was "it might be ok to change all ath10k qmi to skip waiting for msa_ready", and it was pointed out that ath11k (and ath12k) do not wait for it. However with so many deployed devices, "might be ok" isn't a strong argument for changing the default behavior. Signed-off-by: Pierre-Hugues Husson Signed-off-by: Marc Gonzalez --- drivers/net/wireless/ath/ath10k/qmi.c | 7 +++++++ drivers/net/wireless/ath/ath10k/qmi.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c index 38e939f572a9e..50e28fa37e430 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.c +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -1040,6 +1040,10 @@ static void ath10k_qmi_driver_event_work(struct work_struct *work) switch (event->type) { case ATH10K_QMI_EVENT_SERVER_ARRIVE: ath10k_qmi_event_server_arrive(qmi); + if (qmi->fake_msa_ready_indicator) { + ath10k_dbg(ar, ATH10K_DBG_QMI, "qmi HACK fake msa_ready indicator"); + ath10k_qmi_event_msa_ready(qmi); + } break; case ATH10K_QMI_EVENT_SERVER_EXIT: ath10k_qmi_event_server_exit(qmi); @@ -1077,6 +1081,9 @@ int ath10k_qmi_init(struct ath10k *ar, u32 msa_size) if (of_property_read_bool(dev->of_node, "qcom,msa-fixed-perm")) qmi->msa_fixed_perm = true; + if (of_property_read_bool(dev->of_node, "qcom,no-msa-ready-indicator")) + qmi->fake_msa_ready_indicator = true; + ret = qmi_handle_init(&qmi->qmi_hdl, WLFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_MSG_LEN, &ath10k_qmi_ops, qmi_msg_handler); diff --git a/drivers/net/wireless/ath/ath10k/qmi.h b/drivers/net/wireless/ath/ath10k/qmi.h index 89464239fe96a..c68526aad8946 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.h +++ b/drivers/net/wireless/ath/ath10k/qmi.h @@ -107,6 +107,7 @@ struct ath10k_qmi { char fw_build_timestamp[MAX_TIMESTAMP_LEN + 1]; struct ath10k_qmi_cal_data cal_data[MAX_NUM_CAL_V01]; bool msa_fixed_perm; + bool fake_msa_ready_indicator; enum ath10k_qmi_state state; }; From patchwork Thu Mar 28 17:39:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 784481 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1502126F19 for ; Thu, 28 Mar 2024 17:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711647582; cv=none; b=MpJ5hn0CGNcw5DFBE+c1dPMPgvCf57WUlbGjbLkd4GQ1ytruPpfCdYRM9wnWB/PWVHv5BNmaCPkSsBDJRrqhSRFFWBg5U9PIzYftaimnmsThHZGWm4tbIX4bWNqMgQnVkcIUjfbZ5apb66dAA0XAFgkwxM1Xv+CBhaATTId9bpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711647582; c=relaxed/simple; bh=n9AZLgNzUWhIouE9WldfNOkBR0VBSzrpKYlVGIWtLck=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=soEvnXxRXJudCxX9E8/M3rCfhHDz/uiYkx4aYMAhwhEI0F56PxOVvqWpVxmJROM4BbMQ48mIhpheAbgV9LhatQIyj1ZM0EZpz2wrZjUzTzoQudeHkMFLJ1nx68AFnRzx9GKvNGHmVVkBB8NmZFet+MDN9hohsIuNPpQFvR0dTRM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr; spf=pass smtp.mailfrom=freebox.fr; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b=2ksCpSdO; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=freebox.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b="2ksCpSdO" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4154614b47eso4713375e9.1 for ; Thu, 28 Mar 2024 10:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebox-fr.20230601.gappssmtp.com; s=20230601; t=1711647579; x=1712252379; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hBEyfkaUFeTURJJG6e68DKf7jzMPW6cXTRuGJ56eTuE=; b=2ksCpSdOeWSy4yRcxR1JD6VmfV0+VVxya3AXsPU8+jn6Dp1ukEb7zaxlT4KSL2EZ+t u6LXizB5GK4T3yHScXDLN3fTPCvXdWSj5o8FK3yQNs5kiJi+3DueXtlPaHsA/mit9Oi1 S2fX8Rd1L/3JqEqVWf5DPMWm/dTJR3NNSzisEmYnxPDVMD42yitwVUyNpgwC9DhqJBXg sfyUlJA686CWusVD2daRszqAMNZSTkfO2OP2ERffjlD81zs9xw8tMdDWl+FDLl6v/c+X /Bd0COoZUYvrk7hQ92owg8z5aoiALffysl4AtcHRcijgT3NuSitzqOuli6yiHWrYLDPQ 1sug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711647579; x=1712252379; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hBEyfkaUFeTURJJG6e68DKf7jzMPW6cXTRuGJ56eTuE=; b=pUcRHS93YeEhM0UnR9WzaWGMB2znRapprkn3TW9fjWp8y/RM7dCXxcYy2sHnmYgKjq WqIEOYlkLra0F7oa/Jhg3RyoQM77eye+VXgi+JbGI3yAmT0h0RBUkKNfoeuDLczUx31r KY5PDTEBJZDlnxT7hRS0cAzTjOtitL+/3TuFWq0xcYx9LsStNj3gD+yzIV5MiDMzP2Bz LkNQ3uODq5mtIhFeFoYZXB6TniEOJRxZ76hopJCXz5AAHkcAwOYYVby/pDbi2teEYabV ylB9IbcsoVsHmuScqK6I9HSaGldNorDsT1+RI6GnAexrfbDCA+zp+Gr4b1Llc8fJwefa Bz9w== X-Gm-Message-State: AOJu0Yx1caUOOuxlqU+v57Y9KyhBvuqBQrD6LLs8Ljg3xbxjgYoHoe4A QfFXflpTDjgV3Sl3tYCKwOMjrykQAcxnBoICG2bH2Dl90pp6/Mwh0/zE/jDf6vw= X-Google-Smtp-Source: AGHT+IH25UGpyUTZwfKMDNxOvtNvgGwcgB3GGZLR9PbX+P1XJKMoLJl5lW9dzk5XDs/O2Bg89Wim0A== X-Received: by 2002:a05:600c:2285:b0:414:5e9d:ad31 with SMTP id 5-20020a05600c228500b004145e9dad31mr102964wmf.13.1711647579570; Thu, 28 Mar 2024 10:39:39 -0700 (PDT) Received: from [192.168.108.81] (freebox.vlq16.iliad.fr. [213.36.7.13]) by smtp.gmail.com with ESMTPSA id o10-20020a05600c510a00b004148a5e3188sm6066643wms.25.2024.03.28.10.39.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 10:39:39 -0700 (PDT) Message-ID: <5cdad89c-282a-4df5-a286-b8404bc4dd81@freebox.fr> Date: Thu, 28 Mar 2024 18:39:13 +0100 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi Content-Language: en-US From: Marc Gonzalez To: Kalle Valo , Jeff Johnson , ath10k Cc: wireless , DT , MSM , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson , Arnaud Vrac , Bjorn Andersson , Konrad Dybcio , Jami Kettunen , Jeffrey Hugo References: In-Reply-To: The ath10k driver waits for an "MSA_READY" indicator to complete initialization. If the indicator is not received, then the device remains unusable. cf. ath10k_qmi_driver_event_work() Several msm8998-based devices are affected by this issue. Oddly, it seems safe to NOT wait for the indicator, and proceed immediately when QMI_EVENT_SERVER_ARRIVE. Jeff Johnson wrote: The feedback I received was "it might be ok to change all ath10k qmi to skip waiting for msa_ready", and it was pointed out that ath11k (and ath12k) do not wait for it. However with so many deployed devices, "might be ok" isn't a strong argument for changing the default behavior. cf. also https://wiki.postmarketos.org/wiki/Qualcomm_Snapdragon_835_(MSM8998)#WLAN Signed-off-by: Marc Gonzalez --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 026b6b97785b5..681a80f4dc9db 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -3185,6 +3185,7 @@ wifi: wifi@18800000 { iommus = <&anoc2_smmu 0x1900>, <&anoc2_smmu 0x1901>; qcom,snoc-host-cap-8bit-quirk; + qcom,no-msa-ready-indicator; }; }; };