From patchwork Mon Apr 8 00:04:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 787129 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E20AD32 for ; Mon, 8 Apr 2024 00:04:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712534677; cv=none; b=gfBrhQQ/3gZ5EwRGZmaPN+2uI5vWcGqlkllzNTbXe3M4hub1ywHuO60yrIvU6o6cYiFm66oQA1/u5PKjJfX67KLDz8pJ/i9HnsVkLP+W2VNrgrLdfuYiJz5hm+EINz3MlnKPYvYiQbrNdWg1H39Ma5AuNnAdr/VyGlIZWFsy9VA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712534677; c=relaxed/simple; bh=4uJRDTqomRDGI6+FwBgmpcca266Nn8+WZpUZNQ2q9OE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UHtmRDtFH7YVjmoE7XhaXfBjcC1OqCiSqVtd0DHTC4TQujH10EqkUvEDAr0asZTkNZ2KVxHM2S0NeVTu5jBakS1m8ojzIM0MVw4NA/NMbK8jOuKLTRdaMgJUVJXh0IWovYnkf4v2aVXveULa/WNbAXnODlxQ31MfswXCrvzYApc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tI+bLgJr; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tI+bLgJr" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2d8129797fcso51367241fa.1 for ; Sun, 07 Apr 2024 17:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712534674; x=1713139474; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QLVDlCqxm2w8y5sxQgQ4xPnx/VTicbelMsxwHzT78bY=; b=tI+bLgJrkDmsTew0RwbdqOfQnJ8xz1SV4rQBgBAo4V+zdpNWGX4IEqpChGcF6sstVn Uc8vd8RfmtJoDgC2s9kkYGUsLRx+zeND1BZoEACMXTKtgC+CqOAIh/GvA6dMUA7DMBIe wlNXmVqNd1rnnbvc9FF9DxkV87eUFwLO7QDOplUXy0L0QA9NRaVhq14B8XZznH9AxGyW ZpgPgDGFbamf+ehgY63zwNRwtKYICsNUhRk5ajaOiTKDxXOvM3+/6DXDg8PylGvQjQk4 wVq5jJT7o/6mIyw9/0ivN7Q43VgwRc+b0bAvIC2vwLkoK597i5baW+AmzTinHiQ5TR2t /osA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712534674; x=1713139474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QLVDlCqxm2w8y5sxQgQ4xPnx/VTicbelMsxwHzT78bY=; b=Ksv99BKRG/BzeAMM4II4k/KBusnUDG/FGuYC1I/1wGJlq7Z0EHHUxPqRqnn2uACUuD yc+1gK+8rZEbBw9BHViU7vQ7EnOM3SFOpRreh+dq9pEysCPmoH/iqa2M0Danc9Rzx/eh uTvKou49cm2+TKua23V24MPDatLvw0WIqEEwSIeRSsGBreU+Yg+GniqzzOb4xqWF0EdM mfonozV9FJ2zgisgYQn1hpNfJzejx6Xc39iiriedqI9vUVU/dLMx2NRQxTMV3WfyKsal mdCrOWF+jPVkwrafSaA1l73qif6zwojv86pjByghQ/fXlwMuXwKDDSsaJw/NufJwanpR 065Q== X-Forwarded-Encrypted: i=1; AJvYcCVSAXrGfg0uHxKZVkqQjIjgUMdvnf1dHfUaKWw1K4CPnI8S4RFM7xfrbdJxUCsoW62VjarVAUujunMebMIz98rIg/dIlkJb8KKzPA== X-Gm-Message-State: AOJu0YzDyE2vD/tdcZA408eUsX6VGrJB/G0hVQKz2ATDZQXZeVx+vJiF LRA1sC1Mz6Gt4ZecoJVoiBVa0Ae6EWqkBcQT2kNz/axrbKX37h1rH5rUEtKK45s= X-Google-Smtp-Source: AGHT+IHW3sdJ6TUbTTll+xXKNsdF875DFyKpTcnrTzv2BMPtff7wbojcshPy2RGOFoHJT3wMwyaDiw== X-Received: by 2002:a2e:9b8e:0:b0:2d8:58ca:39ff with SMTP id z14-20020a2e9b8e000000b002d858ca39ffmr5455039lji.9.1712534674282; Sun, 07 Apr 2024 17:04:34 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm947077ljj.92.2024.04.07.17.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 17:04:33 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 08 Apr 2024 03:04:31 +0300 Subject: [PATCH v4 1/4] arm64: dts: qcom: msm8996: specify UFS core_clk frequencies Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240408-msm8996-fix-ufs-v4-1-ee1a28bf8579@linaro.org> References: <20240408-msm8996-fix-ufs-v4-0-ee1a28bf8579@linaro.org> In-Reply-To: <20240408-msm8996-fix-ufs-v4-0-ee1a28bf8579@linaro.org> To: Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , Nitin Rawat , Can Guo , Naveen Kumar Goud Arepalli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1101; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=4uJRDTqomRDGI6+FwBgmpcca266Nn8+WZpUZNQ2q9OE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmEzSQIK6fMWhogvncnT3r0gvhh6Q4N2FAMxz/f hTNsKTo5DSJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZhM0kAAKCRCLPIo+Aiko 1b95B/9bDJ/aYI/5iyuzUbZIznl3vuhJ0MUupGmy6mU8PZtPz/bXXqReevRONuIzovVVqOamvof 40QgDbH/KKdYz2Nt/qdndxg3HmXowhS9jEKSVSFqXumDSawT4QREyKBdfI+qfHPt9WIBJf6+ufR H93JT6XKDss1PaSnOfWqkEwePjvtOU51PaQdrz87ZVp1hQXRafsal3IL2/AV99unhWscypS/z9L J050x4QKLw7j2+xE72112TOcgQisFTcyP5K6G+WFpsN6pTKlpy2iKqlvJFUUAy6W8MoQ5x30XAR F4vlI0Vrm9smGkYVo6e/pe06gdah04VW9HwyQ0s33Bw8+cax X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Follow the example of other platforms and specify core_clk frequencies in the frequency table in addition to the core_clk_src frequencies. The driver should be setting the leaf frequency instead of some interim clock freq. Suggested-by: Nitin Rawat Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") Reviewed-by: Konrad Dybcio Reviewed-by: Manivannan Sadhasivam Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 1601e46549e7..42ad4872f94d 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2072,7 +2072,7 @@ ufshc: ufshc@624000 { <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; freq-table-hz = <100000000 200000000>, - <0 0>, + <100000000 200000000>, <0 0>, <0 0>, <0 0>, From patchwork Mon Apr 8 00:04:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 786848 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5031AD53 for ; Mon, 8 Apr 2024 00:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712534680; cv=none; b=a535b2I2Xv3Fxx5X5HT8HA2yNL3ypegFYgT7AKKDgMUipOzcgTvPGHXgVexRVxsDbKDCQ7KJ6S8yPtmxVcuuBdlCcofQgAXFP4yCBKfkMxgrUF7/YRMcUxroq6Uq+PceHkizy13b7/XFDHJfo/sXGiOdvrQt5+fR82wzx/CNvCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712534680; c=relaxed/simple; bh=aRYQeL4Y8toOXnkm/Yr4Y1fKV2VEuxZ++Bc+tR+WFvg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gilB0VucEYZegQMsUT9q9Kp86w5LLjKEt+5ulRHBZDxh5LBImig6uuZgbRD0nu8Kgp4gHwT2WjhyXzhimTq8asOqU6FKtGnD8VAHA4A7YY06qHJHrzAkMxWzObOKpFlKG+tkYLgnQMJcaQJ8Tcyi+Fw76SR7UA9MKuB57ImGS78= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nKw4Fguj; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nKw4Fguj" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2d87450361fso21345871fa.2 for ; Sun, 07 Apr 2024 17:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712534675; x=1713139475; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2V4YfKJutpGTD3SdZOEw66m0js5pB+R1nvu58HzXs+g=; b=nKw4Fguj3hDWIcB4K7q2fC0wgUwaPVwLAkwDMYmE/uK/HnCLn6UvGmaezFkBBIu6gJ PqLkkr/eFlPT+W0Af3hFPVFHmWFo8FyVyMZzYcF8/RaImxlTiSc2pqnDndYSpnViSJWu CrvTNVVueHg7YLA91tyCMTFJQn07NgERWTnZMj4Qvd2BOsb5okUmFUnTHJ5hHeu+T579 CBHbzEOQ2X/7OlfOY04eYaS1zKswcgZwcAIO5OvM9HoZNqHeYNuB2TxNKVCzwstWygoV BtaQ2KD/JdZjhtrtRFDOPvZoq72jgLtaSqBFLMNaPVBWtvuU+lkOu5Ys8oo6uWxgIKcs fIYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712534675; x=1713139475; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2V4YfKJutpGTD3SdZOEw66m0js5pB+R1nvu58HzXs+g=; b=Xl1KS0Oce9WKjwRY5PkoZwOp6RSSmfIuZ4XiSQl6pMlh392uuFikJC34p5fsD2GqCk A3Zn/hjOYXLl1nWoO7e+jR/uvDO4KaEtWn2so4S1kYLCt6aiGZEguA3uc25zdDIZIizj I+RjSq0+tIxgMFK1Lh485eM2C9wwx7U5dRL5/pK75zOP3OGlsQeg85tcUmCCLS5zHygO kROW/E2DA9dLwxw+gZwt7s0vZt52ZJhc23dnB3vhrSu+vuOrjmFGhkpRUnkzfkZIs7o5 uuIp9Pzkz12JUbTwqhPhHtP3SthUZJ19niYRiatae6QkieLkGW1r0zFNX6NkAKFyGqwL cc1g== X-Forwarded-Encrypted: i=1; AJvYcCVKubdJCo+vpTop1PcYVU5FKWQpq2NbF/n//KFvjxGlE9uW9FDN3tzF+NsoZ2p7tBhBspi64YfTL97Z8NpXBFQCyxotxKb5Lybp+g== X-Gm-Message-State: AOJu0Yytr+aHQQ1LZfg7iff/By94tyhTTXHycfUnIub4AspN65XhGx15 /M03s4g/rbqzCh/1Htbdt3pb7xKfOb7vkptidiEJZhg0q9PoZfk+jKvbl7ZnUcA= X-Google-Smtp-Source: AGHT+IE1D88d7O3vSYCxcmI0nBH04P0LNMhxQkl2m/MX0jIwy+GxEwOEd/jg3fCEUyILlPuE3VofGQ== X-Received: by 2002:a2e:b17a:0:b0:2d8:2710:c64c with SMTP id a26-20020a2eb17a000000b002d82710c64cmr6077212ljm.1.1712534675071; Sun, 07 Apr 2024 17:04:35 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm947077ljj.92.2024.04.07.17.04.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 17:04:34 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 08 Apr 2024 03:04:32 +0300 Subject: [PATCH v4 2/4] arm64: dts: qcom: msm8996: set GCC_UFS_ICE_CORE_CLK freq directly Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240408-msm8996-fix-ufs-v4-2-ee1a28bf8579@linaro.org> References: <20240408-msm8996-fix-ufs-v4-0-ee1a28bf8579@linaro.org> In-Reply-To: <20240408-msm8996-fix-ufs-v4-0-ee1a28bf8579@linaro.org> To: Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , Nitin Rawat , Can Guo , Naveen Kumar Goud Arepalli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=930; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=aRYQeL4Y8toOXnkm/Yr4Y1fKV2VEuxZ++Bc+tR+WFvg=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmEzSQv043H5v3I8wskLuSYpY4T5Q0DSjfkySq3 7WWrh+dVVWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZhM0kAAKCRCLPIo+Aiko 1efiCACtQV4p+1ZDOD2mn5pK/s4Nt7O9hVrFenLdII11PAOU2E18yOzudBiHJX66LFujZeKJeoC ux0UBI/gE0RNAD54vq2eaHI9sF0fIVZvLxxMJn1/RTOhUJXIyLx45fe3uf2l0eLFtGM3AYs5LRP yhaQ8UOWmJxYIRmqPLI9nYUwxqPSPSFjY+rwRgDfsZXcTQOjQBehmLa4Pfv1mS5sg7CmG/Pla/k avqtbJoIIktc6EMR6cb+cMARXHm1w1dCGBPEIkPWxbQKs+qEPRgy9A8s9MUo4nOtQT7YGIiLop9 iEA1wV+z10uSi7mZ5BYvE5M+sW1P881XmyIUQWW5rFYkRdIR X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Instead of setting the frequency of the interim UFS_ICE_CORE_CLK_SRC clock, set the frequency of the leaf GCC_UFS_ICE_CORE_CLK clock directly. Reviewed-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 42ad4872f94d..da7f599bd2a5 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2076,9 +2076,9 @@ ufshc: ufshc@624000 { <0 0>, <0 0>, <0 0>, - <150000000 300000000>, - <75000000 150000000>, <0 0>, + <75000000 150000000>, + <150000000 300000000>, <0 0>, <0 0>, <0 0>; From patchwork Mon Apr 8 00:04:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 787128 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4644B662 for ; Mon, 8 Apr 2024 00:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712534680; cv=none; b=D64eNMkl9M6fEQ4EptGJTEB0eqjSlXsG617xm6exxUVhRvx4ImmaWpGHPQdPLE48Mr0mP3XzdWqf0pT5ZxlNk/hqbo271ooIGVWZUjQ8Er3w+ZLVMrwHCZjOLOPPFjtfioFwXKXMHfsgM/ld6XGTQXAr/CtbRLyuDe8un6U0dI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712534680; c=relaxed/simple; bh=ujbZGwCQVSFicv5U4QZnOYsJOvN6YgwCkXPaQJFXvlU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WHI5rCpolccyx0U41RKuGo9IrQbyH54U5ftsaOHn+pJ/vt036JNG1YpL8ti6ce0DhdoHgxozXDv/ctb4Wn+O02mSq62NkjzwAJvbTQH2lNjn5XMoyh2kSQfJ+WOA1rzB4S3/HofEUIIel78m5vQMWvsP3j/L20LHQv0mNePPpOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BZ8KdP2x; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BZ8KdP2x" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d87450361fso21346061fa.2 for ; Sun, 07 Apr 2024 17:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712534676; x=1713139476; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TppMUcMr2yR9W38oBDScEa1smGAMohoFGiEc810Rdso=; b=BZ8KdP2x47LaF0mTQXdQQzZTKIEcxS2u5ISO4k9c+JMuX/cwv94/xrKb0aLTIVoXef ZBVA9jNbfJOKxvOm5ch6mS17nbOqsJD1h0mue9TNEeOEJguPo8b2584cQ0mvTmsEloUZ 6whbT4p+crZs3abhpqGLdDJ5oENyEmdxUIX26h7Oj9NLGxoLnAPpzPpSKeJlsV/x+F9V Z+mwMS3VEizAKR/68rYl+AfZLuszjofTNVMq3mC0ojSF3+s3gughk7E0FuI8ACefqVMW +GExZcVj1xGoP8iN0KNyjYNr7Ltj+OwEfDR3foVO8Y8FzNLws2eLQykQ6h6NfiecNSzU kz0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712534676; x=1713139476; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TppMUcMr2yR9W38oBDScEa1smGAMohoFGiEc810Rdso=; b=RTfr0szJMJUnCuIBOLlb7zbsxvY71Z5rbRUadK3que1ZmnOp1FvKUANdfbnF/FCKGI yjrB2JO7fyb08lFdxQVEYaObsZgSKezWIaQtUm93C9EcpEHtoFmBtOIc9jF++ZHoPJs+ hfSILHyrha+GfLHkLQj3UdxvNE9ctp7P86K5Mt3e/tEvjhPINLji2N9NnFg9bZs1tuze 5ZVN3juWo9jtJUg0OThCGU2JD4lmafhom148922RjwNJkgSdQSXSlCi4Z0MtBKtZFzW+ 5b+phdWI0KuRpIkWVOanWTO5ZXTK7tI7s32E4ytkXXvFqq9dtNf5jFes5TH9N2ZlorjI 3Bkg== X-Forwarded-Encrypted: i=1; AJvYcCWZHu2aPluYQNTelX73p0VgrvBtRhswcV4BxrJ74Toe/d4wNAJkHVrmfgDU42ophmoqrbVjwSUtcn5Ckkgf7dOv9xq3EjqXp6TnNg== X-Gm-Message-State: AOJu0Yxb/6KDWkVtz5fPFeNDClBwoUKp09/e3M2w4v4Fjc+Zu9gPk31F ZuexOmLU0IK4Zx4PvlFSa/p8BT5kqiwHsPiCRulS/XX1ECPg5wvJHUMEU59ndzc= X-Google-Smtp-Source: AGHT+IEgdX7SagcjwVcbNloa6iTiQ87oY/sJXKXIqyU+ATaBfwmgr/P6/KvV8I2jBX09PBLSujG4fg== X-Received: by 2002:a2e:86c9:0:b0:2d8:63a2:50d2 with SMTP id n9-20020a2e86c9000000b002d863a250d2mr5580332ljj.6.1712534675849; Sun, 07 Apr 2024 17:04:35 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm947077ljj.92.2024.04.07.17.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 17:04:35 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 08 Apr 2024 03:04:33 +0300 Subject: [PATCH v4 3/4] dt-bindings: ufs: qcom,ufs: drop source clock entries Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240408-msm8996-fix-ufs-v4-3-ee1a28bf8579@linaro.org> References: <20240408-msm8996-fix-ufs-v4-0-ee1a28bf8579@linaro.org> In-Reply-To: <20240408-msm8996-fix-ufs-v4-0-ee1a28bf8579@linaro.org> To: Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , Nitin Rawat , Can Guo , Naveen Kumar Goud Arepalli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1735; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=ujbZGwCQVSFicv5U4QZnOYsJOvN6YgwCkXPaQJFXvlU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmEzSQH6Xu+f4sKTcOZgOBk88mBu3dwm8nIQgXZ KjzQz592N6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZhM0kAAKCRCLPIo+Aiko 1a/sCACqSzi0I0S/2zfYNr8MFZkwVzw/aGSqUhxhzw7U886308UpRqwsu9EfwToW4SfHKp5MG2I zqxOnQk+bqi+clAXD7z1ngxa+ZcfhSrWlReV2kAFwuvALByRm2NOAHxwyUs3JrWP/m783/ApoEE qYqcDdKq8qmroZMprGvpCL/DBUawWljMq9Lo/HxIVdd+BBJkKnQS+4LT1aafFaKPkDS6gQSH70Q 3d0IuPMf3+G+oUBTSnFbM8bxQOW3x/D1B9eJlUlsl90PybL2roZ6jtQoZaPSBR9R9DmOmjVpSJs gBAFx/2JEOJdyF7pjJG3jvwPpy1I+IOE7BP2SxOH/Uce/5/W X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A There is no need to mention and/or to touch in any way the intermediate (source) clocks. Drop them from MSM8996 UFSHCD schema, making it follow the example lead by all other platforms. Reviewed-by: Krzysztof Kozlowski Acked-by: Manivannan Sadhasivam Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index cd3680dc002f..25a5edeea164 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -46,11 +46,11 @@ properties: clocks: minItems: 7 - maxItems: 11 + maxItems: 9 clock-names: minItems: 7 - maxItems: 11 + maxItems: 9 dma-coherent: true @@ -217,16 +217,14 @@ allOf: then: properties: clocks: - minItems: 11 - maxItems: 11 + minItems: 9 + maxItems: 9 clock-names: items: - - const: core_clk_src - const: core_clk - const: bus_clk - const: bus_aggr_clk - const: iface_clk - - const: core_clk_unipro_src - const: core_clk_unipro - const: core_clk_ice - const: ref_clk @@ -287,7 +285,7 @@ allOf: maxItems: 2 clocks: minItems: 7 - maxItems: 11 + maxItems: 9 unevaluatedProperties: false From patchwork Mon Apr 8 00:04:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 786849 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ECAFBE47 for ; Mon, 8 Apr 2024 00:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712534680; cv=none; b=UJ8VC9JBls1wNgIEMVwMlNbvb5yBAVDCrGkt+ymWoFB+dsxzIVXHW1QVbgiUaF/BQS2cNm1m3b5Pkf5wIKsqttrL0Sg1Jg0XhLKne8o/eIsqCUGD3LQ4lC4/Nnd6vLcMaSSDrF+dZPKWRq/DQPw19D4wkEarNhQXdNqkvrbLCHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712534680; c=relaxed/simple; bh=nAYKKMjqM3Kb8RFCha5OI1S6EWj+PTGtIqzAtlEkxmQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t0rGO7o5izB3Jt1O8OZJp6R6MTpdBiQYHeIXPQH0fzuETqfh2YIbwJeaizJ2u7xy/23lehSIQGcodHMz3+FZieOTpU39jmL/5YLsx3Vmbx4tycnR0wXIGEQR/qjrgNHwzICOiqHgQGuerWUjt5T8LT9GH7KRdI2lOHHjfe4RweA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=D8hah39t; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D8hah39t" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d71765d3e1so46881011fa.0 for ; Sun, 07 Apr 2024 17:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712534676; x=1713139476; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5fggAFWGtjVvdqtakB0C83EFk680HhcCQBgjQ4syqX4=; b=D8hah39t3me/eolUfdcYzoYDSrXHDn48l1UF0m2cDlEMLeItwpDKID8OyM9A1mDxWq YqJ9IhI2jEGWpdguT50zntSydCeM9YwF/TpAULZJ4T0wcd13+n0unuuDt1FwEPfnhodk Dq+6brtcpORv77/GrPd34EqJ6tr28Yy+CpIOvf0CRjE3b2GdhOOEnQXSzULbur/zqck8 FFStulYg2SkFyX1lvNFbZq/tF7ezzJH+0daIgD/CHL8jpxnfqzgjgMbztKssctD6FG4u NzHSJcWOUahQSwjse6vXIcYDYiT8D3EBphvXhyfaXpIXABB7hbktP1A4sisuYOyagGPw ao6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712534676; x=1713139476; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5fggAFWGtjVvdqtakB0C83EFk680HhcCQBgjQ4syqX4=; b=cIQpwmrFsv4tbRTBa2Ce2y5I4ZkcRFBleX3hHGNAsTAPAW6xyRz9Dmia+Bj0n6Ff6G tPHtH/JYgvvH6x2dGW2/M01cREQAVeWHIk5GpCcKa1V0t4EU1nauhooBQoouB7kp9RPS H9+3Vf6VN5Ctm1OmRb87uobYyI3mlG3Ixe+6Ge2P8YDUuKIdswHzARpzlwW7giFz5L9F nBUpJxWj5tIGAzhlCPjcgmYWLXg+SnPSyfwzRpL07HlW5wVCWJqnNOU/6iCOKEMc5oEW ag0MMN2Ctrtjb6o4Wi5Rb5w/zq9kmPuy8XzC+CG/B3Lhzk2j2AqKZC1OsyBtavJgRi1e 17tw== X-Forwarded-Encrypted: i=1; AJvYcCWoPj2puqB5nD5rLLE9ptV5B+6Ef7MLt1mSoMmaSwTNKxbo34Ki5Uptu/t8eNIO3lkV/z+58dapPhlnzC7bLD3Dy9l1qDifmk3l6Q== X-Gm-Message-State: AOJu0YxreexNh89u80DBg96UnevZvUerPa3K+2xxdZ4cBOebltexbUDD DSw3keKNvCvyROYoE1v0hswPx9pGGBrMTytdfNcAbYWEZulyYmG4xbbL+dpIinQ= X-Google-Smtp-Source: AGHT+IEYyEqfmWIUKG2Y+ruPQ9Io2nHHG5li13pYUOchjuJ8qo3zDn3ISkVLwm5t55YYTxTWAvHfSA== X-Received: by 2002:a2e:8557:0:b0:2d4:69bd:77b2 with SMTP id u23-20020a2e8557000000b002d469bd77b2mr5818267ljj.36.1712534676623; Sun, 07 Apr 2024 17:04:36 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm947077ljj.92.2024.04.07.17.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 17:04:36 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 08 Apr 2024 03:04:34 +0300 Subject: [PATCH v4 4/4] arm64: dts: qcom: msm8996: drop source clock entries from the UFS node Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240408-msm8996-fix-ufs-v4-4-ee1a28bf8579@linaro.org> References: <20240408-msm8996-fix-ufs-v4-0-ee1a28bf8579@linaro.org> In-Reply-To: <20240408-msm8996-fix-ufs-v4-0-ee1a28bf8579@linaro.org> To: Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , Nitin Rawat , Can Guo , Naveen Kumar Goud Arepalli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1595; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=nAYKKMjqM3Kb8RFCha5OI1S6EWj+PTGtIqzAtlEkxmQ=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ5qwyYTVklLe1943zd6sOMNEMdP4517zT+lm7tall/p/c nx5KqfayWjMwsDIxSArpsjiU9AyNWZTctiHHVPrYQaxMoFMYeDiFICJOP9j/6clU7YoVvTI7sIw tT3VKpG/M+NVbm5sE7p+cQ/3NJulTcKGy5pmhn8RDbgo/rrTcXvjjbokFuWennMTF3xsXpah2L9 VZ1HwlZI09mM3WY8F/aiIn7OjMuMJyxFRr+rzdQWMD+MesmZ5HePy9y9njNkxmeW9nvWXRRd9mw 5ul1or1Wwcwnf6G9/eRN0wJvY105/qOC5r3MiRly8dte9oWYVD5PM/hfuezj1360tAoGhvh+kBk /d73k6vOj21fl1ke0/G5ofWvIa7bTpn+rRfjo39q3ujVdLp2IPORi/9J8J3GpMYmOw6iuy/PhSK y9srcmWj1z854TxpcXeHyjYfgS5LJ4GVrw2N8t5vtngDAA== X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A There is no need to mention and/or to touch in any way the intermediate (source) clocks. Drop them from MSM8996 UFSHCD schema, making it follow the example lead by all other platforms. Reviewed-by: Konrad Dybcio Reviewed-by: Manivannan Sadhasivam Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index da7f599bd2a5..708f797f1b44 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2047,24 +2047,20 @@ ufshc: ufshc@624000 { power-domains = <&gcc UFS_GDSC>; clock-names = - "core_clk_src", "core_clk", "bus_clk", "bus_aggr_clk", "iface_clk", - "core_clk_unipro_src", "core_clk_unipro", "core_clk_ice", "ref_clk", "tx_lane0_sync_clk", "rx_lane0_sync_clk"; clocks = - <&gcc UFS_AXI_CLK_SRC>, <&gcc GCC_UFS_AXI_CLK>, <&gcc GCC_SYS_NOC_UFS_AXI_CLK>, <&gcc GCC_AGGRE2_UFS_AXI_CLK>, <&gcc GCC_UFS_AHB_CLK>, - <&gcc UFS_ICE_CORE_CLK_SRC>, <&gcc GCC_UFS_UNIPRO_CORE_CLK>, <&gcc GCC_UFS_ICE_CORE_CLK>, <&rpmcc RPM_SMD_LN_BB_CLK>, @@ -2072,8 +2068,6 @@ ufshc: ufshc@624000 { <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; freq-table-hz = <100000000 200000000>, - <100000000 200000000>, - <0 0>, <0 0>, <0 0>, <0 0>,