From patchwork Thu Apr 25 08:07:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 792566 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2054.outbound.protection.outlook.com [40.107.93.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE8C0757E1; Thu, 25 Apr 2024 08:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032505; cv=fail; b=QNgkEkdEgHQZhSAppKE5Q/q8r1qdJOZf5OT7yaMdk6jZUkvxYAg/JcSwdIEMB1C+kyBumLCl4+6eCsXwtiX8boVtOOFcgW4klMnhsoinbdwb8cD+/D+cnujsp+V8mzCp2bJFQBfAR4G1GXlpDCg+IhJH2U7QbUw+8Ljn2gZVonM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032505; c=relaxed/simple; bh=LUaCJ7ztNyvppYDBnyBW5x7KvW39abmf54w03poljfU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q5Pw6do1HZUauuaCO9sjoNQmSrvp74clKAvHIaqBPVhwxhktY7xXozT7odtd+EY26Lzq73PLcC0Ll+Wa1Wc4HeLiAIGfK7FH3UDmnrcV/xKEFdBuxEM5uj7iLua+L6NPmCZPJ8I2RE1ZlXoW9D3SsJ2mYEh8Eej6vtoBrc1/fZ0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Ir9wHI3a; arc=fail smtp.client-ip=40.107.93.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Ir9wHI3a" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ea4dAFRVlCSmNT6mjePsq9mKqHE0HT/RSdbDGijJE++b/cyGvHgSPxFCzoQ3AlxX4aAVfNaFGWlqoF4ACwnsBlmoEswIw1oYV92R3VMMfxmT/P2irr5MANY2NDXjFLCzMCsuARpnwtsz5mfutDOn4eMGbFlRHFZRH9bNCQwn4vlbNQ4s8Fg2yBPP70JsK8S2jlT+scx0aA/Xurk2LkfBlBDkUIefBKlGZ4uy/hv4GZ1meKFZsxUsW7fQTGViqqkyPmT0xYy1KBc00Hl/y2vWd48eSuF7gcUNbyt12AFFpch56znSPoCjjlkh5oAJNyBZaRuFeNR44Xeqt806ZtLoKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xf4HrOdoNdR4aiMHQM4TVsOCXDzBuN4CwAHp7G4aksc=; b=EfM8D5NIhg7Y5k5ysjFYakvPDXtFu4OfBcALbqFWBwDkvkw0oIh74yTlbauiO67RQ4bsNpfmdsuO8V+fWcCADS9eYSXOXpoQU+cIPnElRdwGoRyr1twmaRz61rXWDls5NLGuSWgrxsum1elzC8uF3iTlnFvIs6X56PE9pXCQyzufw0JE2WjPF8CgFyLx/2oxcJTuBaz3UYK3YvbTuQy+foqn6UwpxtA4oEeVnuBpOOqW+Dhu8dXjP41VjFtsd7qiZFS7k7nUSNm77uFFiKe3k6ErIrkD/s0ZWWeiXvRjbxjv9J66czwB+1sJ8XAHxsen4jkzC2yOxRO0IZS4yhEY4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xf4HrOdoNdR4aiMHQM4TVsOCXDzBuN4CwAHp7G4aksc=; b=Ir9wHI3a97DKirZwyNgYVytVd1XwZh51UHDuxXg6sm/6+HlOShKQgIllXiNSlqRx0vR3J57TbKc2ZhZEdgrr/wpk54Sam401y/NXr6HVOn9EtBBgkhKd3c7hjkPHMWSn0zHWOtiIoQduvZCVXIq+oeN8v0e0ziI6K3QtoAptgKE= Received: from CH2PR07CA0049.namprd07.prod.outlook.com (2603:10b6:610:5b::23) by CH2PR12MB4293.namprd12.prod.outlook.com (2603:10b6:610:7e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.24; Thu, 25 Apr 2024 08:08:18 +0000 Received: from CH3PEPF00000011.namprd21.prod.outlook.com (2603:10b6:610:5b:cafe::69) by CH2PR07CA0049.outlook.office365.com (2603:10b6:610:5b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.37 via Frontend Transport; Thu, 25 Apr 2024 08:08:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000011.mail.protection.outlook.com (10.167.244.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.0 via Frontend Transport; Thu, 25 Apr 2024 08:08:18 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr 2024 03:08:14 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v12 1/8] cpufreq: amd-pstate: Document *_limit_* fields in struct amd_cpudata Date: Thu, 25 Apr 2024 16:07:51 +0800 Message-ID: <1d984381f253bcca53bc2fe871cff17ec7770fc8.1714032153.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000011:EE_|CH2PR12MB4293:EE_ X-MS-Office365-Filtering-Correlation-Id: e309fdc2-dc2f-43af-f9c1-08dc64feddcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|1800799015|82310400014|376005; X-Microsoft-Antispam-Message-Info: fFmD3TJq9QkN3wjH6oO16/RjM7kyTbM9gfNqfzUoyPhgP6bc59RALqUOIH4TKigDeP9A5g14HFzLcjtiV91uyWBYECj2CT3QEROBHDjLwSpdthCe+7fc0EIZIVcv056z32QqKPU29+9IoIYXT1z12WVfefvy6mYxIn1H638I7IZNSmSdVC8bfHv4dwT+N2gmbvuzwCc57a8iyYxfMd7FEwZaGaIxbQ9bO4Q5NDIRik3XpRbR6qTfZS5kareb5fjg8bYbBAwoIZBfc/pD0MupzQSU/7p/Kf9uyNw6CK5bn9ZS4mdLkniuFEBGi9ZShFeYiAUQwIIYYN10KFN36FLwjCrYXJpxd4yFpf/t4AlZ1lbxF2BMVZuTjDeUsZRp3ctL2yTPtBMLjjXtDCbzCQbkYWcXTKivIJe7A4KY69y9erIVMAhG/RC0bc2UxPoPKYvyj4aEQuLVG8gXSMORE4bPfZQdRHsl8aZbQnQCL+yPAO7i9IeyHfZwKLwNmK9jav2pNcjrz+fNfFXe2srPnL9mx3QTYVxlCAvhmhwucw4JpsdVD/04bF2KyZw9cn1rfOJv0Ml6tj1w5ZIIKIuGq7GZvJl3X6fNY1Go0nhi7k/f+DF3F2saVjk/gwl3dZ24CYjVk7daSXcKedkzbXvO6VpBJ8+9x5fAMLNduI/hoR5iN4bv0f+f2Gsln4EX5yuzDfCv8TvFoIUJJD7uieci4feQoHyhc9dYZ8b5H2SDcyvQaT1WBsftRT8A5TeX2kKOXLBq5qoAbz5ZKCfRfTBvKOyf2TJ0rorEtZ28+d2K61LR7vYe+qUvkPcldVw61tjfW5V7pm/A8zHEtD7/LNqjBQ5iy9AcLHbOMtEwgQ+PyHn1Ezp45hbA+422nq4wLQxbLCCLGM/2tnTQe1c9JXjCR491Tsj8N64ZiaJj8k/hHdpjEyUhKFQHb+DhDuwOoKrZtvUZHPwIJfVQVBzUJTd0ACSHAuwZnuUdO5rJZ2F203oi1bHkcsims6iMNL0dnBMMUZwOdQCIdKe4jEaiamp8mwp5DfTuTp6oT/AcHld2WmmL8iUPeRetv/xf18sWAF2upvlurhgHfg+kOcgK4S0E/Dz1z0mBTHSQ26mvhdrlvUMqocJA2xAnX6wnrBWlPvZVapeXtdrC1SDA05DhFCPniBUdd9o7Y0C6EkKBsjWBt+2A0NjG3+rl7jOkU8Om0tHXL9jclVQ1JE15+TOvPRF03R/lcxXbyfGhcKoGl1mDtUnBvzRMWB3CsxJ5Fo/QQqVEKqBcyiHthiv6ESz6lL1W6LO8mYC6TFgVHrlxoxdzVPKeGWuiXR6dn5OoT2SccaXu195j14GgYkNVduLiRStT7Fk/d9Av24ZbS5kgYX6w77XOJ5ZhphI7M4YPGD9vNMlK2vks X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 08:08:18.4695 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e309fdc2-dc2f-43af-f9c1-08dc64feddcf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000011.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4293 From: "Gautham R. Shenoy" The four fields of struct cpudata namely min_limit_perf, max_limit_perf, min_limit_freq, max_limit_freq introduced in the commit febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and scaling_max_freq update") are currently undocumented Add comments describing these fields Acked-by: Huang Rui Fixes: febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and scaling_max_freq update") Reviewed-by: Li Meng Tested-by: Dhananjay Ugwekar Signed-off-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- include/linux/amd-pstate.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index d21838835abd..83fb3fc647fc 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -49,6 +49,10 @@ struct amd_aperf_mperf { * @lowest_perf: the absolute lowest performance level of the processor * @prefcore_ranking: the preferred core ranking, the higher value indicates a higher * priority. + * @min_limit_perf: Cached value of the performance corresponding to policy->min + * @max_limit_perf: Cached value of the performance corresponding to policy->max + * @min_limit_freq: Cached value of policy->min + * @max_limit_freq: Cached value of policy->max * @max_freq: the frequency that mapped to highest_perf * @min_freq: the frequency that mapped to lowest_perf * @nominal_freq: the frequency that mapped to nominal_perf From patchwork Thu Apr 25 08:07:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 792231 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2069.outbound.protection.outlook.com [40.107.93.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E8FC75808; Thu, 25 Apr 2024 08:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032507; cv=fail; b=jh0koCqY43GJDQD3aYfrmrSoUoDtDGFGfDEst7GoISA0HVznPtNC03/d4x6MUgdGxGjj0jlnyWq3ok3Tucahjr9gUcW4PyVjz6zRdO0l0L2/TfUXaX4LxlP1gxGEsASv4qHMjN5QnSS8KAM0GFEIulfUUSdMVd8vDjIuHDmr/0M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032507; c=relaxed/simple; bh=AvIG2FhDdHY3ZHVuKnfGKa8TZtGrwrKZmlBslmAR6ec=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MdnO9SL5QTd37QFS63/TvaO2WosSiGUJD2wnVrIz4k3kfrgkki9amh5r3By6m19ig5MvYmfHpap+x51Ad4Kb7HZ8QwXjnc6Yk9I5zaU2LYRabOoOLmyEMx5mROGPefcBTlmLt4ZsnVpSNWn1KCw5CqrfuHhPdZBfhwbj1yqACb4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=W2Aa8wPF; arc=fail smtp.client-ip=40.107.93.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="W2Aa8wPF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CUI/osIzO+fyfAW6wCGVm5FNOQR8MtsQGEZfuhY0t8AFOhCDnkFIXucyYSew2YZNAKC1QCtER4wVRhCMeiDYI+hnUC32zPRlUQbVQ/PUB+mCJY6oolwHcJR8zPq8cgxp/jqlrjMVKmPthl8ms2EJ2AOM5U5sS0a6MbIUYS+iLF/KQ7BolJgGzmqOjRCxsk07kKdvP50OVhUs5kwrwK08oDsGCNclbWICT7tio+3aLQlnTimwUZZ3L3b2NLWFwhyjMKsO2sLPVy353bKuby55xNRkb0rF//Y1a7pooKUR37PtykIsLdz8Mbu7VlQC7NleSI9womWOdEhZsZBPsKmLVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AsmTbquJ9BY+dgfDmlFkoA/xm+DY16dXBsdnIdf6d9I=; b=H/Jk6e6mCW5ccXQN+sJ86MOsKkaYIvwaK035PsjPxcOiTN75R6Y/vjy8UQkMNwLbJeSdBk5Vujy/haCOdmUXk8HE0+WpFcW1EsNfkP2XNGt2Cn7T9ecUrmK7FzIiAHizBFj6lcerL0ZEE96p3Afkwi4RigicoYvMVSIz/olaVEKb0h8KZUK+I0y87R+iFFY5fWqSQstvRAj0l52zW/bydiEuXLLc4818P8dTZPi65znsmHckIx0wUBp6RftfuPeD9MMYBnv7aoOD2JewwQvQJN4wkeqlNpoT+HD/v0dSqFBv2Qn7harZ6JFsKeEkwjZmEAm/kWsaKzNBB9824QJj8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AsmTbquJ9BY+dgfDmlFkoA/xm+DY16dXBsdnIdf6d9I=; b=W2Aa8wPFW/UVElkNgb+GFeaxDo0hs2nHZi1GnxvINQNTI/rSZIQu6yZRkR+Dpy1z47iOIEVWec6YQPVl3yRZUK9GvucAu2aV39B4ZE+/H7xXyGWNtsfET7eTfoeZYnbctePzya6Nf/jkOnQ6D+KxE6floMLF2cSiqDB7THDlP5M= Received: from CH2PR07CA0055.namprd07.prod.outlook.com (2603:10b6:610:5b::29) by SA0PR12MB4446.namprd12.prod.outlook.com (2603:10b6:806:71::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Thu, 25 Apr 2024 08:08:23 +0000 Received: from CH3PEPF00000011.namprd21.prod.outlook.com (2603:10b6:610:5b:cafe::ec) by CH2PR07CA0055.outlook.office365.com (2603:10b6:610:5b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.23 via Frontend Transport; Thu, 25 Apr 2024 08:08:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000011.mail.protection.outlook.com (10.167.244.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.0 via Frontend Transport; Thu, 25 Apr 2024 08:08:22 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr 2024 03:08:18 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v12 2/8] cpufreq: amd-pstate: Document the units for freq variables in amd_cpudata Date: Thu, 25 Apr 2024 16:07:52 +0800 Message-ID: <102336d846b82a91faa09240f1751635b2d9d7cc.1714032153.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000011:EE_|SA0PR12MB4446:EE_ X-MS-Office365-Filtering-Correlation-Id: 0094c119-6d2d-4b0d-b5ab-08dc64fee053 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|36860700004|1800799015|82310400014; X-Microsoft-Antispam-Message-Info: A1R8XV7SUDXGFfVNddXsbOSGEDcTAz+IVIsZ8ndsYC1yuRVocYTTv+rxqFv6m4RUNGCrBKvVJqkvZldhsf1bRkeDvxb7rpyyQ8RUDkz2XVL/CRMaIqH1AzA5yNuAhw58usH7XebjL1brJ6xd97JVn4CVETsNCTjTkZVQsac+IbCajgCBU5u5SYmrjITrqNLYwQ3ezA9mbUEsS9pYyHBYGr98dfpBy20GqZ/F5cd62mqVYq/bu13CIwpmiWzWEtpzqnTPnqhMxmjJGnBsMI/j3IWJgt0QaZhtEmk3W/yHB86Rl/jMzpMZfqyVSfcP4P/678whRlUM6pAMg3j392/kX+c4dsYrxEn9YDnKX7UdG3EpqrfOyjSLvhiLVZrzhKNiAux8COUCaUXEFjz/fQUDmRk+talEIyITrxmGZ5mcFmzYZLVEW6HYC6A0yyZsjtyxYOzLlBSZbWr4qhX3Luquyk+c54eS1wW0CZJmUYO2vuJQWHcbkvn5wLD54KbVZb/1Y/Ez6alDPQKYqe4ra1xehnxORUelbxw1ysv9RgJCBlA/nUmtOQgjobRdztvjzhBgwP4FMyPOwcXASVht+8mq80npj5KP+hVwamcl4ixyee+/yb/LJonIH5+MqCc0YNy3ysmf8z/a3ZY/P1v5tKoIbY6lPT37tYg38ouHgB7iqkSEcMdNzPirwPfpdDZGertiwHDvbGG5/03GwAQsHbNXjCTtIs/KC/5slLaalk8IGE6JlZvHzGZG1dS4EIFMv+ZzxrcS3uYVolYJKHNFXyGC+ECb74YCVIB8eRvSd3ReZZVdutrsFe3Qss8R5iyzXUbZzOZJAxM+hxgXVq+ea/uMXt5StxHz/1phFNk9DY7lGVv/Owx5WC8v89unyv2Z0d3jFyKqqlWnCxYMP5+otuqFnDmwp99XLNcMqqO/H1a72S/L4fJkWg+iaLqmmwVUhnO2ENHswcqE8ECwtoQf+hLQbTcpWO8plS5Hf7j0M6VbJUhYXH1Oe25VTdH2OVxzBJHkE/ibv2iAFX+fvx9b4mtw6dQ0j7NNwej8G/gCtQk1Ob2Jiy5HXiTMz9U9nCin6tOVxeYdjmG25Nx1aZETkxu2WevFCAabSW7BBEQjcJAARg3sGxi8Ia96Uv5AooktX4Sc0W68GV8gIfKEPxlmT9CmgGV2nZzKRY1hvb3hHjnS3ANMg5DJRwps3bDJsb3f0/0Ph9yfWvEjmon90hNnH8mODajLyV6YegSlHSmNZcKpS1wGN5aHoIlRpN8r8Cqufb1dpkWM9J32UWAf7s+Tw5sKHsnninaR2pBSZT+NaTr4kIhTlMnY+fXD+2Txq/nkwxrhg38vo/U/5JgWV6UsgN3lXCxmnmVvOiOALFx3+If1OHt5ueIIN7ah+WMBMv3yf+YZ X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(376005)(36860700004)(1800799015)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 08:08:22.7195 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0094c119-6d2d-4b0d-b5ab-08dc64fee053 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000011.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4446 From: "Gautham R. Shenoy" The min_limit_freq, max_limit_freq, min_freq, max_freq, nominal_freq and the lowest_nominal_freq members of struct cpudata store the frequency value in khz to be consistent with the cpufreq core. Update the comment to document this. Reviewed-by: Li Meng Tested-by: Dhananjay Ugwekar Signed-off-by: Gautham R. Shenoy Signed-off-by: Perry Yuan Acked-by: Huang Rui --- include/linux/amd-pstate.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index 83fb3fc647fc..ec0b0fa3e9bb 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -51,15 +51,15 @@ struct amd_aperf_mperf { * priority. * @min_limit_perf: Cached value of the performance corresponding to policy->min * @max_limit_perf: Cached value of the performance corresponding to policy->max - * @min_limit_freq: Cached value of policy->min - * @max_limit_freq: Cached value of policy->max - * @max_freq: the frequency that mapped to highest_perf - * @min_freq: the frequency that mapped to lowest_perf - * @nominal_freq: the frequency that mapped to nominal_perf - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf + * @min_limit_freq: Cached value of policy->min (in khz) + * @max_limit_freq: Cached value of policy->max (in khz) + * @max_freq: the frequency (in khz) that mapped to highest_perf + * @min_freq: the frequency (in khz) that mapped to lowest_perf + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_nonlinear_perf * @cur: Difference of Aperf/Mperf/tsc count between last and current sample * @prev: Last Aperf/Mperf/tsc count value read from register - * @freq: current cpu frequency value + * @freq: current cpu frequency value (in khz) * @boost_supported: check whether the Processor or SBIOS supports boost mode * @hw_prefcore: check whether HW supports preferred core featue. * Only when hw_prefcore and early prefcore param are true, From patchwork Thu Apr 25 08:07:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 792565 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2049.outbound.protection.outlook.com [40.107.212.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D10B682C8E; Thu, 25 Apr 2024 08:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032514; cv=fail; b=NWGdDNNKnXxGHJBMtDjdwRMs6RpCZvDtUdqBc2hxgbho1ZofAk7rauEc4xTMwkod3GrL3PKHuzaem1MjHpUeJAQJwYnieXoWxAeoNa/wcFPvO+Jwl4hj/A+eANIdK8ua1n0/Nz19c4RnuFe0PWw7BnMeT56FjBc8omtSXTZOp3A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032514; c=relaxed/simple; bh=LtDBJFN9mt4Ghp8tKeZFaX6vbLB5XW99XgCcPx3/nXk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e+fVQ+UV84WL9pTZwNctLWOEyRkjfWJpEjrXBh3kI2VKO8FZHek/NbfP+z62Qe5Q6hM8s2kAvgCQg0WVbsd1GJSx3ELB7D8w89xp91qNA26z9B8Nix/08IRMsl5MLn60i7K4kIxiYoQf3V6c4yzWCztHickaG019SObokYvyvrA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=J8dx/KIP; arc=fail smtp.client-ip=40.107.212.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="J8dx/KIP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mSB0JTTBLDaLd/qQKoY9OPqDXHh4Z0sopHtnAabZ0WZtlclPmNiUE/wIEnO86R2kNumnx6yjbeafGQwoRW4zxFj92L7Iab/9VoMhbPb9hJ5iM+fs2maBCrgWfIf6/8BR/C9/F50ysbfrJLbx1XJkPSvXUe+tnXeecvrlogmoyF/Kww2U+OoyAgJK8uFxY1zJ0UokX7jpj9lmsOs+9YxcZ9R/9zgOy9SVRZeFGD+Mnizy03G6DtRB3/5Yv9a9IHGtsQiKG/8E8aUAbwQbAhl8qqQVVGIyd8H7KndKBqLl+FgIoFewsVfYtbZyG2xh2pHee7Yeaa7I1xN7FTPwqTa3Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qMBDLDmclriccSsNVlKFKkaYu1FJp1/xBHkw9sBTVmM=; b=Lb5Yu5Fk1lfmB/DMMD37DuYfNhQibFEkMOmWkn3IaRKHPE9UX2Uoz7uIzal6ZGaPhR4RvyclGl7YCVAGhMw/+jJ5+PowV2RxjPfwTMo9nnVsMLSxSJqQefVXo7j9GhVRFcsmdPDSZEk45vHEED49WUl5oZN4AI+ny3CdzQMcr9+kl4tWoUOUrnV6G1f9GapdxEdCR2Q9j0kOoTJn9C8pPelqmxT9zRhGIwK4rRmTnu+A2rGljEaletC80+wlQJHMTPWDmSJPkW4wmNbOwHEBDVjOOx4m840Lk2Wuy/ECC3fNZsiMETQqezesyQ6QyPhU6zDHLhNRT9I2/htpXNdZmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qMBDLDmclriccSsNVlKFKkaYu1FJp1/xBHkw9sBTVmM=; b=J8dx/KIPNezgAUrK2P/v+R176VO9LqcZFHfyQgsthHfIZoM6UilgfXWo3WsQz7btKo2V2U2pXsTjK6KEKCy/34gUq45Oz8tZO0P6xHIV9FSzsOGqRC8gp7YEjoNsRH7bV7XdQqbY0xSUl/CjyUsa2gadcveecSBzaJcCazgp2VA= Received: from CH2PR17CA0029.namprd17.prod.outlook.com (2603:10b6:610:53::39) by BY5PR12MB4211.namprd12.prod.outlook.com (2603:10b6:a03:20f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.46; Thu, 25 Apr 2024 08:08:26 +0000 Received: from CH3PEPF00000017.namprd21.prod.outlook.com (2603:10b6:610:53:cafe::53) by CH2PR17CA0029.outlook.office365.com (2603:10b6:610:53::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31 via Frontend Transport; Thu, 25 Apr 2024 08:08:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000017.mail.protection.outlook.com (10.167.244.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.0 via Frontend Transport; Thu, 25 Apr 2024 08:08:26 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr 2024 03:08:21 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v12 3/8] cpufreq: amd-pstate: Unify computation of {max,min,nominal,lowest_nonlinear}_freq Date: Thu, 25 Apr 2024 16:07:53 +0800 Message-ID: <9b9771e703a0840595f6a871b6956794f3c5a4fe.1714032153.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000017:EE_|BY5PR12MB4211:EE_ X-MS-Office365-Filtering-Correlation-Id: ca88998a-9f50-4732-7bea-08dc64fee2b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AqnTEmtbMxUYHUEzpFu0NJznesY04gMMGF665iSQKyuAKGaf2/G/jMIDnFAfUM0GhL2k+LNR0lzTxkmqmJ6fv7o/xu4aspmQrvsaoZM8wid5hUwId+GFsnVqwduWbcCpdlH7hlG3OxCIduD+jLtlOKzV/xzFz1VDNhI0mKeUHE73u79hXANzuTmeiD/VAWz9YlcRWcf/MSOAT1zvCqhg4OEY2WnEN4kkPdL6pQm02kKT3+vz+LLW0Euk0cT0dZ3LUyq4sTZbhYqhsKhspIwgqDuvlsaGfwsQWP8at0PeJVRPdLTIY+TFwRSkgoImXUVl5ld0LWsArL6QhDF/3UAM55qZj3rEF1llppJRZtZVSQQVAKSIFYfR42psCH2MAufp7TemwVx7nSp7mxZlfn/l0pHgfGI63FlaWJ0ti20N3mIsZXdmI3hIMKQ4MC1/AKxjZt+LKKYaMEymrjhLaZzW4NK+mlfqj3REwkxn+8fds2CI3eWu//eDP4fMnz0pUd20092EtDQMNUjbWh0z2B7JTgXA+dspfVekETYf3uQheTq6KX0WiNqJfxI+8IcpQSbJF0ohUDnasuDNCZWz/V1q4io7b/678uNUlLu0EvbSXYljwPEe7TrjhveRWW1YjJSTte8vRRI/4s6TuZRRMnb2aZN8R+m4V8rDz3xtqepTD2y1rE0X++KoNnKz2xHeH52zxn2o01sh/POcsxzvR3J6wNzgsTkDhrZfQ8ElcHdjKkN60EKBWjSjpS2opqCp9yv538WxJC2RC1VpFY5ywBVUtuFLj4/kcg4gLVOJsBvg++6nfp3F7+rTYC7BqH0X8M2FwrlmkuSZmYtkF+zi4bgoy8vS9VnMGp4foFL1tvZrWXYw/rp/6FVTqLaUGsqYPQhZyC3LyV51ouGorFz2sg20pOzEUqlv7qd4kRaWn99TKJiTiHCsTG7wRPJqYVE1JUF0rPbXJ0ff/bZXMJk0arv3LrzSb7GqR4ckosZWvAJKS0WoZFdGWchxp7U0YFz4gHDT1LpaORGnEQ6v05vOJgPvOGPbYRwfohhxd41AsJMLFqtBCcjzEVTTEfv9ryqLonrvPWEsx/+jUQLMPwZG7AKNBbinHJSv9ucKZHgaMOVxt/SNsE0EtHtkS+HDB1gVqnU2EauBmmZ5iKZK3vxQLlPNZELg2hqdqOCgvz1L5e29Q9+osVIjovHLahO1iaGqTksSigYzOVvLcX5sDZH9Yuoc18Z+DwzPFA5xF6Qv94MX8ccYkL8K9+qSZD/Q4mW4mPqAvoZm84tKwV1FAz3N9JIrGeSOG9lPjecbahsI0doJIm2byLZdzFlzZU1PwQBX4bQF5uDmWPK4TVDkwEa5ONd5sjvXyu50aotyAwEMsxjDwMfCouRslns1BamjfWGGniiY X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(376005)(36860700004)(1800799015)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 08:08:26.6533 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca88998a-9f50-4732-7bea-08dc64fee2b5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000017.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4211 Currently the amd_get_{min, max, nominal, lowest_nonlinear}_freq() helpers computes the values of min_freq, max_freq, nominal_freq and lowest_nominal_freq respectively afresh from cppc_get_perf_caps(). This is not necessary as there are fields in cpudata to cache these values. To simplify this, add a single helper function named amd_pstate_init_freq() which computes all these frequencies at once, and caches it in cpudata. Use the cached values everywhere else in the code. Acked-by: Huang Rui Reviewed-by: Li Meng Tested-by: Dhananjay Ugwekar Co-developed-by: Gautham R. Shenoy Signed-off-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 126 ++++++++++++++++------------------- 1 file changed, 59 insertions(+), 67 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 2015c9fcc3c9..891fad6f90e1 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -606,74 +606,22 @@ static void amd_pstate_adjust_perf(unsigned int cpu, static int amd_get_min_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - - int ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - /* Switch to khz */ - return cppc_perf.lowest_freq * 1000; + return READ_ONCE(cpudata->min_freq); } static int amd_get_max_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - u32 max_perf, max_freq, nominal_freq, nominal_perf; - u64 boost_ratio; - - int ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - nominal_freq = cppc_perf.nominal_freq; - nominal_perf = READ_ONCE(cpudata->nominal_perf); - max_perf = READ_ONCE(cpudata->highest_perf); - - boost_ratio = div_u64(max_perf << SCHED_CAPACITY_SHIFT, - nominal_perf); - - max_freq = nominal_freq * boost_ratio >> SCHED_CAPACITY_SHIFT; - - /* Switch to khz */ - return max_freq * 1000; + return READ_ONCE(cpudata->max_freq); } static int amd_get_nominal_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - - int ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - /* Switch to khz */ - return cppc_perf.nominal_freq * 1000; + return READ_ONCE(cpudata->nominal_freq); } static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - u32 lowest_nonlinear_freq, lowest_nonlinear_perf, - nominal_freq, nominal_perf; - u64 lowest_nonlinear_ratio; - - int ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - nominal_freq = cppc_perf.nominal_freq; - nominal_perf = READ_ONCE(cpudata->nominal_perf); - - lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf; - - lowest_nonlinear_ratio = div_u64(lowest_nonlinear_perf << SCHED_CAPACITY_SHIFT, - nominal_perf); - - lowest_nonlinear_freq = nominal_freq * lowest_nonlinear_ratio >> SCHED_CAPACITY_SHIFT; - - /* Switch to khz */ - return lowest_nonlinear_freq * 1000; + return READ_ONCE(cpudata->lowest_nonlinear_freq); } static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) @@ -828,6 +776,53 @@ static void amd_pstate_update_limits(unsigned int cpu) mutex_unlock(&amd_pstate_driver_lock); } +/** + * amd_pstate_init_freq: Initialize the max_freq, min_freq, + * nominal_freq and lowest_nonlinear_freq for + * the @cpudata object. + * + * Requires: highest_perf, lowest_perf, nominal_perf and + * lowest_nonlinear_perf members of @cpudata to be + * initialized. + * + * Returns 0 on success, non-zero value on failure. + */ +static int amd_pstate_init_freq(struct amd_cpudata *cpudata) +{ + int ret; + u32 min_freq; + u32 highest_perf, max_freq; + u32 nominal_perf, nominal_freq; + u32 lowest_nonlinear_perf, lowest_nonlinear_freq; + u32 boost_ratio, lowest_nonlinear_ratio; + struct cppc_perf_caps cppc_perf; + + + ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); + if (ret) + return ret; + + min_freq = cppc_perf.lowest_freq * 1000; + nominal_freq = cppc_perf.nominal_freq; + nominal_perf = READ_ONCE(cpudata->nominal_perf); + + highest_perf = READ_ONCE(cpudata->highest_perf); + boost_ratio = div_u64(highest_perf << SCHED_CAPACITY_SHIFT, nominal_perf); + max_freq = (nominal_freq * boost_ratio >> SCHED_CAPACITY_SHIFT) * 1000; + + lowest_nonlinear_perf = READ_ONCE(cpudata->lowest_nonlinear_perf); + lowest_nonlinear_ratio = div_u64(lowest_nonlinear_perf << SCHED_CAPACITY_SHIFT, + nominal_perf); + lowest_nonlinear_freq = (nominal_freq * lowest_nonlinear_ratio >> SCHED_CAPACITY_SHIFT) * 1000; + + WRITE_ONCE(cpudata->min_freq, min_freq); + WRITE_ONCE(cpudata->lowest_nonlinear_freq, lowest_nonlinear_freq); + WRITE_ONCE(cpudata->nominal_freq, nominal_freq); + WRITE_ONCE(cpudata->max_freq, max_freq); + + return 0; +} + static int amd_pstate_cpu_init(struct cpufreq_policy *policy) { int min_freq, max_freq, nominal_freq, lowest_nonlinear_freq, ret; @@ -855,6 +850,10 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; + ret = amd_pstate_init_freq(cpudata); + if (ret) + goto free_cpudata1; + min_freq = amd_get_min_freq(cpudata); max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); @@ -896,13 +895,8 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) goto free_cpudata2; } - /* Initial processor data capability frequencies */ - cpudata->max_freq = max_freq; - cpudata->min_freq = min_freq; cpudata->max_limit_freq = max_freq; cpudata->min_limit_freq = min_freq; - cpudata->nominal_freq = nominal_freq; - cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq; policy->driver_data = cpudata; @@ -1317,6 +1311,10 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; + ret = amd_pstate_init_freq(cpudata); + if (ret) + goto free_cpudata1; + min_freq = amd_get_min_freq(cpudata); max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); @@ -1333,12 +1331,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) /* It will be updated by governor */ policy->cur = policy->cpuinfo.min_freq; - /* Initial processor data capability frequencies */ - cpudata->max_freq = max_freq; - cpudata->min_freq = min_freq; - cpudata->nominal_freq = nominal_freq; - cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq; - policy->driver_data = cpudata; cpudata->epp_cached = amd_pstate_get_epp(cpudata, 0); From patchwork Thu Apr 25 08:07:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 792230 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0258B82D9D; Thu, 25 Apr 2024 08:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032515; cv=fail; b=aIMOrYWgFUn1bVabPSqGxsBngX9yJunGNmaFDRED+cQRWnSJ00yg/bjPFfr2g7sFIYOWibiz9tic7mcrstgZCif8BaTslU9JrAcQykrKLmjmWDSrU91HSWLvWGrR8pssFMrpppZpF4R5nJa9c2ezhmvV4BwZsfo7hzI7U8Pk2i0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032515; c=relaxed/simple; bh=GOEylsnGtnQnASO5apgdHql6QhHuHp5kmw/FAiy/xSc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RVcqmSklF8dFcukIkMxP/czKjukoOWhry/JE+vULyUjSN8hB8MH474vmiQFkqhfklrsPRZUI6QC6XZBNssIAWUWFyYB77dBcglA98lgDXplUHPJs3CFCMhKrkOvxsyhY1nmB14QGR/ZySn1bxHM3rzldhU/vC92IAc8TGiGZuoE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IepBjWZV; arc=fail smtp.client-ip=40.107.243.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IepBjWZV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SOs68A+LBjiaP3EyfJGXJmMFKPDE0VUSaNdd6fsBpol48Z4q7yy0Ek7Lxz0GqfhjAN0eL/Wkga5H3aFSNQyujgRHyzkW3q/DJLfHqLj/V60dgO4qTEpegAScGdcmmXVDCSYzkBjbihnOEDREGHJ1FidI2A43BaBDhTUyUwQkZ2yIRlbrWB/0CGpGor7ZNDr48/yb6KYG5XVrLeupYSQuR2Y3U9Y9HKNZgcBA7cg9XSPomdNH0Mfa209xkAP09poXeaDFd1PrGQ1erlhfuSvqSmsj4M0kPqmzjnMpSru7LPZG2nMS5/AO/dfdCM3ExGajrsIIfhTjO0Ja3KV+J/Wg7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWFXVGCIXk3NQuI7JxRsnYQ5oZtrEZj2oetcQrcIfN0=; b=INAAivUfi/WRxhL+zbnm61V+5hDybw212E32LQ7CF5BOLExqLCEYswdxXASsrMWQIAHxbuaNQpkisvnIvsSF95jywD77EPqiHeq5b5eJvWbQMMQKPH59VUgfzE3nyIMM0laNjEr6QJZUZzvY4unX1F6q4Mzrzcfh74s6EOhc9b538187F9DkNcnBkpZNWvR9k+yLUQIBq5wDjsGh86Een1To9+KGb+BcudygP+1Q/dXUUHsBwHIyUidbJ71SAn7UWrEPljS7UR3zyrzQ+e8TUOF1LG1jE6PgiOncZqdcrNVnVZwL4XUiKMBndAGMV3+85Fzj/SrgNIuE0NtygfwowQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AWFXVGCIXk3NQuI7JxRsnYQ5oZtrEZj2oetcQrcIfN0=; b=IepBjWZVfE4HQJrCdBiU2hlpmb0MtZiGT/X//Ed2jYrNjHw467Sqx6FtGjmAa71Y65UQTAbzrqibRmhdg/iq+N8748b0yNTebxdDPPvKRDCS3nn+pSPKz3CVdwjsJirnhgEanaACRN/X9wxuIYg5VfzKqAJhZZ9MBhdKVpnWg6c= Received: from CH2PR17CA0003.namprd17.prod.outlook.com (2603:10b6:610:53::13) by SN7PR12MB7371.namprd12.prod.outlook.com (2603:10b6:806:29a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Thu, 25 Apr 2024 08:08:31 +0000 Received: from CH3PEPF00000017.namprd21.prod.outlook.com (2603:10b6:610:53:cafe::b) by CH2PR17CA0003.outlook.office365.com (2603:10b6:610:53::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31 via Frontend Transport; Thu, 25 Apr 2024 08:08:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000017.mail.protection.outlook.com (10.167.244.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.0 via Frontend Transport; Thu, 25 Apr 2024 08:08:31 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr 2024 03:08:25 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v12 4/8] cpufreq: amd-pstate: Remove amd_get_{min,max,nominal,lowest_nonlinear}_freq() Date: Thu, 25 Apr 2024 16:07:54 +0800 Message-ID: <23ef36cc03ff5579dbb2d9318ed8cdf4346924ee.1714032153.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000017:EE_|SN7PR12MB7371:EE_ X-MS-Office365-Filtering-Correlation-Id: ae1e3af3-e3f3-4215-bd5c-08dc64fee561 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L7BF9hN0FOl6ImOGHYIkDpDuKuja+5bMrDW/mLIWXxm7uWuTYIraGhN1IPieysOht+7cnKDKj6/tamkUDuifjHGxk+Rr5xE96J3V+bYwbaSdqylomVbGieOJe0t7WSTMlyzw7WpRhe6AL3xZ5Sg810VjwEdTqswEJuvQfT5ezrY3mEOI/E6f7h922eiNA6nBbSN5e96rG7SNQ2AYM9RyHkmQPVvomga0DBRR3KaQRUsHwjaUZyKBcAUHRHD1pOjP/atIaMHqXOTvMQKbfoc9UaTWSYmfdQXcW2WNoCb4Iw6sqoh3au1vKUhdB/k0UPa1RSk9SzYn56gmbYJWjHHIVygPocq62itjB827+peLUbLQH9ADJD4gJpZ5702IdZ4uwqy6kMzuyzP1jfyC6FaEuj83qZMVEU2uyxusNzBDT4MkOQqPSA0bd3G1QKUxf1n3IVkiDrs+MB+0xBTvuoqSW+s1Wx4fbu4+pqbNErhi3eD6ktBQDcIl5Pd4kIo+OUKm9W1DosUyvU0EgOKNL0vXiceLqZ0yiquz2wMZfk5y2Yyd0a6rqFiabvWbur6B5sVLNjosCd1wG9NVYBT8liPEWXyPw8zGbyfByh0Ro7bAKSYYjOXJ/C5P3UWUvUnULBoONq7dEPkGos9dP9DK90ukaMd4q2K/LcJjZzt3CKkiphjNSbUZe82/uGCcYjcXmbQPhFTj3Phm5b10IFRkSi2HPq2dicKMXWhZQRRPMQ/kx7tHssVFogDqv98tt6dmB7yyxtX/FF8SqlzLvi5F8QIo6F/b5TrTP1i81kmbMOI0aLkk6SKMpCGxbDxNZOpl+4NDoG0el8+M+7j7CMTUFNriSyaz2QzMxiUeslFURIdcoTZDhOY5imkxtyBUHLSbnP/MauXjhISHe4ehBb3I2DwYL/TX8rPGH0ryXn91ZbeM7omG50+bTyLGJqXmp9uCGZW6rhiQA90rY71OcUFL7R582rP0zgPlp3E2H7EZpLSKpzLa4UenSYzKqhCip/YKxEZ17qUIuHAqDFxBZvpBVDpB1a8kygOmreWNJCNQctWcnu1ZVEyRS/DlP5Zx3Hdh1fMi769yZZT4EPA/QN0D/LKr23iUkcErg+kVoYPtKfGA5e4Ah3/9lcqDwwxS5ago5OLMGP7BpiCZbHxY5SEDkqKUbFYjsrz7DhHevo3lbdqJgJmaYz2Lm342Rrp0xZSnmdWgfFcgMqY6YAfUHThNwWLngaY3Br9C6tA90JvMvqX5QbrAVtsVkVSYNDUgKFFBeL+6efgLisdvbsIc8cWtVibneTwHOZY8ZhoDukn1EKIrgQMCrgMwl66EYEouvG5PG3Gwbu2PVN22iWLT+axEW9QIA7Krho2kpWMl4caGMS2+YpUna58oztJfXl9WyoBIFh+b X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(376005)(82310400014)(1800799015)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 08:08:31.2001 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae1e3af3-e3f3-4215-bd5c-08dc64fee561 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000017.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7371 From: "Gautham R. Shenoy" amd_get_{min,max,nominal,lowest_nonlinear}_freq() functions merely return cpudata->{min,max,nominal,lowest_nonlinear}_freq values. There is no loss in readability in replacing their invocations by accesses to the corresponding members of cpudata. Do so and remove these helper functions. Acked-by: Huang Rui Reviewed-by: Li Meng Tested-by: Dhananjay Ugwekar Signed-off-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 40 +++++++++--------------------------- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 891fad6f90e1..3836d62b54ef 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -604,26 +604,6 @@ static void amd_pstate_adjust_perf(unsigned int cpu, cpufreq_cpu_put(policy); } -static int amd_get_min_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->min_freq); -} - -static int amd_get_max_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->max_freq); -} - -static int amd_get_nominal_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->nominal_freq); -} - -static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->lowest_nonlinear_freq); -} - static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) { struct amd_cpudata *cpudata = policy->driver_data; @@ -854,10 +834,10 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; - min_freq = amd_get_min_freq(cpudata); - max_freq = amd_get_max_freq(cpudata); - nominal_freq = amd_get_nominal_freq(cpudata); - lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata); + min_freq = READ_ONCE(cpudata->min_freq); + max_freq = READ_ONCE(cpudata->max_freq); + nominal_freq = READ_ONCE(cpudata->nominal_freq); + lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq); if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", @@ -960,7 +940,7 @@ static ssize_t show_amd_pstate_max_freq(struct cpufreq_policy *policy, int max_freq; struct amd_cpudata *cpudata = policy->driver_data; - max_freq = amd_get_max_freq(cpudata); + max_freq = READ_ONCE(cpudata->max_freq); if (max_freq < 0) return max_freq; @@ -973,7 +953,7 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli int freq; struct amd_cpudata *cpudata = policy->driver_data; - freq = amd_get_lowest_nonlinear_freq(cpudata); + freq = READ_ONCE(cpudata->lowest_nonlinear_freq); if (freq < 0) return freq; @@ -1315,10 +1295,10 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; - min_freq = amd_get_min_freq(cpudata); - max_freq = amd_get_max_freq(cpudata); - nominal_freq = amd_get_nominal_freq(cpudata); - lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata); + min_freq = READ_ONCE(cpudata->min_freq); + max_freq = READ_ONCE(cpudata->max_freq); + nominal_freq = READ_ONCE(cpudata->nominal_freq); + lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq); if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", min_freq, max_freq); From patchwork Thu Apr 25 08:07:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 792564 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2040.outbound.protection.outlook.com [40.107.100.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC2A484A3E; Thu, 25 Apr 2024 08:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032518; cv=fail; b=T7lI5myXlX40bfGx++t1wexGyFoS4dN1FNx7LH7tk4F4noBwQ3dgzFxafncrCo3I/D5DSVsIIhtVCFIYC9aZs8ze8WiMRnAIgxCvK3BGUXNDiu4nrpX9/P1vSxGkoCaxourHtNAM4Ks0sw4axYcU8WhGcQI/GHMDEhY+gc4qo3U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032518; c=relaxed/simple; bh=OLudeT+1gijlMUi7TFfWkAzoR9bs8ojKSeLEe4FVrk0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bROPomh+EUUe119/mBSpjn7wBvWsCO+R0sP59Q6400eQmlK7ZFO4z0OPDsvZNL2KSOYFF4u4SvzW600hwgCX8vLKRU2SV+JU6ovNM+tip8v2hC9a+LvRXODoZ+0tlel5ZIcLcnVCMu9WhZqm1Zr8sBC7PyWbnaqp7FK3B9JrzCc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=e8NpAdZr; arc=fail smtp.client-ip=40.107.100.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="e8NpAdZr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jgfvIx/HDdokr6AT9RKsdOQjDvQDSf3W/nwaPcIhUNF3n6zNzTgNxzKPL6k+BgbUF4AW9opF+s2jeaNj3KJbeqi4wy63w1b6v7ZfcVw2Zpio0UWVk2yrpwsM1ZkKGbuVk8CIA+3jrXVA0ACGKmUy0gAlyqz8PyHbUZb2p6HMg0SvE2PhIBf8zPqk99y1pEDAFDqbk34W8BvxgeT57vCznTA5DvDXBATyedbjqaZa7+j/4GpWb5FsRSWRaBJp6gz+SB0mNfUKAI0Bftp9OyxQHOu2Sg4bpEG+vexyxEevY+/lkPubSO5201qT6oLUz6CrtFI2JkCtRCPJE+PGBvLr9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0+TC2KATw7Hqz4WMVGydK+FfXr1FbAtVbdW2gRVy1Mw=; b=VVXafo2+T5inzMQSoi/px7ax23RyBNYi0Im8zWfuH03j8Cf7BbZJCuxFh+tNnM70iopfB2GyL2NaWAKsAIfWIMgWfOqVy4slu8hHTIblcMtbYcO0wzRg4dd7pZocM5cwRQGjvtn4umbQXO8THef4Ik23gHyGHdSACzhw1MxKsgaeWyTsDWhmUjZ6Il6jWFOUPlxps+MoYVnWGm5zWsbK3jfym9Qm7K/J+i681JmNQJo9gabsa8FZ5d4w4aU/ermtVeX/kIez+HY/9QcQoD9yTd9GGqXnV5ERL9ou9/yb7IBfVXcovZXENCiAZBKfWhnCaT8LRd7E+2g+/291aNLdzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+TC2KATw7Hqz4WMVGydK+FfXr1FbAtVbdW2gRVy1Mw=; b=e8NpAdZrfgvB5q1WL//F+quyHLJmSyzd1QHjNE12d4FErnEEchPTORoxT3QF2aBWTwPFzKLMiPklO3j67G1XAs3OmtLuf+2XtEB56c30nNEGrjWt2ZtJI4uu7UF8AgC2Ef+dczRpcDiXO50r/JDHB1mp8Df5LmYBBhrWQTI5QT8= Received: from CH2PR17CA0010.namprd17.prod.outlook.com (2603:10b6:610:53::20) by SJ2PR12MB8109.namprd12.prod.outlook.com (2603:10b6:a03:4f5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Thu, 25 Apr 2024 08:08:33 +0000 Received: from CH3PEPF00000017.namprd21.prod.outlook.com (2603:10b6:610:53:cafe::a9) by CH2PR17CA0010.outlook.office365.com (2603:10b6:610:53::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.36 via Frontend Transport; Thu, 25 Apr 2024 08:08:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000017.mail.protection.outlook.com (10.167.244.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.0 via Frontend Transport; Thu, 25 Apr 2024 08:08:33 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr 2024 03:08:28 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v12 5/8] cpufreq: amd-pstate: Bail out if min/max/nominal_freq is 0 Date: Thu, 25 Apr 2024 16:07:55 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000017:EE_|SJ2PR12MB8109:EE_ X-MS-Office365-Filtering-Correlation-Id: 07c93b5d-4fb4-4c93-74ae-08dc64fee67d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aPUiBRxo82u2FOOR5ndpDKzGqiTXM5gBnCmSALBHx/4HtwXhpZd+kQuQPoP433f1rEOrJLn816h8vDa9/+XEt23dCO0hcmiKWIlKSxdDLh+sqRcnBINNLyDg1W+oE/DEcXL+SFWN0WBYymITy4pVtGzlzjWq/lwIc3j4zs6tSRYWlccVmxSTR/1VCZ6vXEGgHP+05lAO1KOtGA9k7fzBYp72gareW/+TvoQU1g29jc9WzgyJUkNTxnQDTkjt0xKqgtg7FgIQAYhKcVMZM0ZzWDeebbdzE5Y+V9h/pJf0FT7M22zO8fWp45EiP3eFrzXyfYA8sTQFkxyBKNezngybWHjyamW3dhYb7s2+ilUHdpwkzYDS3EfalACfrC4rz6dExhK0LgtGJnqddcBvBj5q+Mgp3/PTm2PSQ29V97fvd6ytTSX6Mq5NsTM/aPTTSOCCtLZtz7YFDILhVAGvKIea8w71L+KAOlS8duni5iJELzPUzFpV36AdhvrkTevxK+i8uVWaVHOKFdtS467DGJff11+aJtaFwRyNSbZK854x4s8ICH8J127bkq47L3I6FncNpUc4zILIXwR0mrwTM93CocDD2fcm5gFT2kLJ4tojmw9NW/NC1HXr1kvAgCXPjVH1DEVA3xW+/dueNnYM2wu2/SVIs6T7azwgkk8/SXJg5ZpmDT0xPuD5E2gJYEQvpBQCW+myO0fUsR5Q3SR7RRLCW1bg6v0zyayua37q9pD7qrBAX1jEguNEcX0HFXt54cIGp+IiagWqDivCAgLQqU+Q2HltPRuXOCdWnPyvCv1scF9iG0jZn42MTQiBLfLxIx3IvaPLxgn1jjWRgg8/raxVK/OiFOOnlhz1lF7h3vlKK7LQgbxf/QYOSMAOyRoItsNdtdrsGjWjoQQDnGzJD1JpAWVk6ommqtVvuEDtgYqauS86/eeLTRh/X/slkaiJwCds2/kyu/BETqdgjOYLrvxpyjt+7cU7h2FNc21sRKrcs4akKAXkvGMpuAEe815LV6PmLCLFzlu6AH/v9JjVUOG958lkJMGZmPJS81nziv2y+UleDTUQiP0TofYOPPOXGDC5oEngPi1AvR5jkXShvNSZrxPNF6kHky1l+8QQ70PrCU24m8Xe0F2hoHB+1bewVhb1Xeq95kEbz+fB5eZeQHsWJquBnAiLk2vyi1/FbBcoVzPEZegccNvzU7mlhYQlXNdvj0Y00GaGUG1n2IpRjTc6mVd1Pa4afcpLqSJRLi3UThItRUoQzPDtklTLcgWSSZIsnOb/tzsXcDBO5Abe2PvpkPGBlQL83u1h9oELQJEfJxj58/lM4WYHaDwvmchUwv5/NhpkK1+GCtlUSY1oBa5Bm7zO6quKb16eQvM+R0IDNW8= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(82310400014)(376005)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 08:08:33.0595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07c93b5d-4fb4-4c93-74ae-08dc64fee67d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000017.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8109 The amd-pstate driver cannot work when the min_freq, nominal_freq or the max_freq is zero. When this happens it is prudent to error out early on rather than waiting failing at the time of the governor initialization. Acked-by: Huang Rui Reviewed-by: Gautham R. Shenoy Tested-by: Dhananjay Ugwekar Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 3836d62b54ef..960fead0b83e 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -839,9 +839,11 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) nominal_freq = READ_ONCE(cpudata->nominal_freq); lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq); - if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { - dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", - min_freq, max_freq); + if (min_freq <= 0 || max_freq <= 0 || + nominal_freq <= 0 || min_freq > max_freq) { + dev_err(dev, + "min_freq(%d) or max_freq(%d) or nominal_freq (%d) value is incorrect, check _CPC in ACPI tables\n", + min_freq, max_freq, nominal_freq); ret = -EINVAL; goto free_cpudata1; } @@ -1299,9 +1301,11 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) max_freq = READ_ONCE(cpudata->max_freq); nominal_freq = READ_ONCE(cpudata->nominal_freq); lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq); - if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { - dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", - min_freq, max_freq); + if (min_freq <= 0 || max_freq <= 0 || + nominal_freq <= 0 || min_freq > max_freq) { + dev_err(dev, + "min_freq(%d) or max_freq(%d) or nominal_freq(%d) value is incorrect, check _CPC in ACPI tables\n", + min_freq, max_freq, nominal_freq); ret = -EINVAL; goto free_cpudata1; } From patchwork Thu Apr 25 08:07:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 792229 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062.outbound.protection.outlook.com [40.107.237.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D115F82D9D; Thu, 25 Apr 2024 08:08:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032522; cv=fail; b=a1TsPn3hmwZx5VNNP/98zsmqrb1/n6JDevHBY6m0hUxkwarpxLxPYnhRGZlPt1Dtwxgtak7eo39ci3xL/+CH4AIORnHAjArzjVswpd791iJ9Nn1kkey2crNz3bdjig1dt26jn7A5LigXPxiUdUF28Ix2Hml30hu4J9XwKuJebWg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032522; c=relaxed/simple; bh=ckwcOBVNDuF40QHvqaELwzXzB6I9pFsprYsdpq4lBWI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dgTIF/BUdlD4wxNbDmtnRRBlnhJ6tVeGtLcQg+lbvdqgXUZ+BLdjLjXkSPV4mIZ8UoPXSow3cXkXv0NCVt1P3xRIKtq9F+Y18gC07JE/ML0Tlm21AlQ2KMudITMbyar6+enG4IaoJoBUuwF8lJJ0VFMDyZsl1fh3I1FbMSd7e9w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=uYIC4eTl; arc=fail smtp.client-ip=40.107.237.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="uYIC4eTl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8dzVek8ZZX4hzAIDsTCd5JylQbJm5ahHKg+2S+xQnWDq1DrcstppitvD9UA25/x9585aA/9F5Bx05ZMxJznzVAVC3XJyLBTqe7HUZLivyC3N3C09vZ11BVvntgS/7ecY+RhN4jxh/TkTsHPKUtSX0Ce0hc/+Z7lGhqn3cGWew+ofkQJM6dZdqYawJ9Xf4UtXlHyew6Q55+lnmknt50hT1Ho6kcHUzLnvcGr5gv+9PhdNXdZRHzplQIMaJWjiWM1bNWXlUGCiJTlR0Q9GTS9whEim4GX2G5ptf7l1l9ynVdM88nJE6rV32xxIdA/DdwfvorTLQHeTmhBfxCUdiHVlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m7Nnj+wrL8I671SDCrz9Xga9ZXP4NJdoC+h1QNGeU94=; b=gyQry7yNei3H4/PycS6aTJvqLpe3HWkTxIFWs//zDBUTAyFTiJqjAqcLkHlXagEwtVHuJEi3WYMCK1noRIgcL3G6DMQwwLpjDRCVGume5hCrRCJSOw5C0QJW2LTiDFq9wXuBKUThyqRKzzOSEiWDYigc038rWxbpVTkWO3jjewPQmVwYSIZ9EfRnmk4cAdiKURFTu7O7hTUPviHlIqVwDWKO77hvdmfY5G3lwE8VYfVU2YaQWSGyb/S66wMP2MPYagCxuwDh469I0+pc6Ne269zoVEJCbHOsVHsRqQFnUB8nqq92nRbRcEYsS5TQG2DmsWQpygSTi8eFIHnDSRJmLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m7Nnj+wrL8I671SDCrz9Xga9ZXP4NJdoC+h1QNGeU94=; b=uYIC4eTlrfufq1l9UsbdQoGRDI7dYGDb0e9qplfGNgrbSxYVs057Crry9C1eHmNzM9SCdjTeydTlb2y5PHhnEd+Ik4ktWoaesPrQc9RMydVu486vddcoStTrJq59wE5cnENkn8dz0hQrCEkwC1F8zZtGipWohWdYGjmTUm6f/wI= Received: from DM6PR11CA0059.namprd11.prod.outlook.com (2603:10b6:5:14c::36) by CH3PR12MB8904.namprd12.prod.outlook.com (2603:10b6:610:167::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Thu, 25 Apr 2024 08:08:37 +0000 Received: from CH3PEPF00000016.namprd21.prod.outlook.com (2603:10b6:5:14c:cafe::f9) by DM6PR11CA0059.outlook.office365.com (2603:10b6:5:14c::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.25 via Frontend Transport; Thu, 25 Apr 2024 08:08:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000016.mail.protection.outlook.com (10.167.244.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.0 via Frontend Transport; Thu, 25 Apr 2024 08:08:37 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr 2024 03:08:32 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v12 6/8] cpufreq: amd-pstate: get transition delay and latency value from ACPI tables Date: Thu, 25 Apr 2024 16:07:56 +0800 Message-ID: <23d8478a809e39748e140eef898c778a3d378697.1714032153.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000016:EE_|CH3PR12MB8904:EE_ X-MS-Office365-Filtering-Correlation-Id: 49ce337c-274e-4d46-c448-08dc64fee937 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a2b+GPSsMxkZoz5exjs0B8qkZUoSlgc8fsH+kuPv/73GUZBVCaIvAe29HvRglekMnAXTCVs9Grt2Ng0RvTENoxEZfnpGYEFc9JTYJ3L+RnxZa0mJ9msEUNXbo5b5nP5BtsnjQE1Y4GkkHecMWwcmyOxBE+zuZ6FDvUE0YJLrELXM6cP3U6i3FB6sWJPE8ApTM2ri1/J1smGL9FdM23hpjzCfcdLEPMfDnp1l5cGzWrMXRs+6HUI1EorvdrodxSZusQMwICMkZCnUNKG77Hvbm/ah2Ckqt6O5BNSPMxpENH1XqqYUTsRYJC1Xe5Gq2zYP6JG0mkJQVwjAr5z7teBjijsXylbga/oymkJYk24npGkiD0FRtXldKYgQ0d2FdQpq7swVI8U3q0/BoPZiWB53FVu5KGPGi+uJuvjGkLB6oPWoJs6iyTtQQCkZ4YSwo3G7NERBUqrQDiz0OVZxw5LaF3OmASFKkMGZiIyjWlB62GFIMgSNUiI/FVmXJ2j2JrLGI+BCkmvNY/eE/Y9UZU2wb/8FGAhv5FSqfI9WaxkujUsO3etuv+IgJqPDBhCA0r4EEMMAw2dccdawMWe/7S/qidsCr+9CJL6oBAFlrmEQPlzhImQvPO7kzP8ujs1NyaQQb7MxlMpGfhoGinzSJp5xntBxwftXXItR6hicnhK++ZE6Ed7bKrUaHBP2KIx91qwBH9BbvXDsxO8DP7eUxrNgHpkfgNIoFt/L0TThjRiwZbFF0V5LV+hkLOdEYXmOlGt2s4Cf9B1CU2wxd6fmqzqtr3exLz8iQSb4tMKLndS0DDGpF2IlqRAvHKUPDHc0eKMvqei7sp7hra/9IQeuDglQ+IotQZk+1JxSJkBLMEF0YA7VH4ZKxYcf00IhgYJMBukaILtJtAbiIXhseXDNgBbNRu42wiEHkJqv9KzW4vycHBJj77RQYm176TJ43Aqqz7ZBwT0xMc9ArXIBFh62Yoeay+CwL8wqiWvBBG7FUCY8v9Di45+4bgljDYX0E2/HEtjZ1byg5gAB+JNHEzFoZi/qyHzuKw6+gJKLDBqerht7aiAtMwd1k0oqW8j25v0MixAQn3KwqfZm2gZ8gRs85mtO2DKyl0RuMfO0Y6Za1jFJpbU59dWbDPYWtL0piJvjiS0reqpI6Ll0kmlQcbNLs6+OXhWXuAs1E+IkFntdt/YNY5Y/diCd04h3pG7O9Om44NnG5MmxORCbcwupO54SrMIJmh0XBglENlLQEnevWfAJ+WnLAlCZyYb9ivO5efYBxQYCr/e8vepM1uhUtQd6HPvmZk9LOzlbZ2j3umwBFsFe2bA/fIIDWxM4P+Lj2Oqve8aZvzyQaXbmn3F4wAw+uqfMWWPc6F0gSNsBK6Fmn+Ej+fE= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(1800799015)(82310400014)(36860700004)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 08:08:37.6359 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49ce337c-274e-4d46-c448-08dc64fee937 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000016.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8904 Make pstate driver initially retrieve the P-state transition delay and latency values from the BIOS ACPI tables which has more reasonable delay and latency values according to the platform design and requirements. Previously there values were hardcoded at specific value which may have conflicted with platform and it might not reflect the most accurate or optimized setting for the processor. [054h 0084 8] Preserve Mask : FFFFFFFF00000000 [05Ch 0092 8] Write Mask : 0000000000000001 [064h 0100 4] Command Latency : 00000FA0 [068h 0104 4] Maximum Access Rate : 0000EA60 [06Ch 0108 2] Minimum Turnaround Time : 0000 Reviewed-by: Gautham R. Shenoy Reviewed-by: Mario Limonciello Tested-by: Dhananjay Ugwekar Signed-off-by: Perry Yuan Acked-by: Huang Rui --- drivers/cpufreq/amd-pstate.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 960fead0b83e..510b5aec42ea 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -756,6 +756,36 @@ static void amd_pstate_update_limits(unsigned int cpu) mutex_unlock(&amd_pstate_driver_lock); } +/** + * Get pstate transition delay time from ACPI tables that firmware set + * instead of using hardcode value directly. + */ +static u32 amd_pstate_get_transition_delay_us(unsigned int cpu) +{ + u32 transition_delay_ns; + + transition_delay_ns = cppc_get_transition_latency(cpu); + if (transition_delay_ns == CPUFREQ_ETERNAL) + return AMD_PSTATE_TRANSITION_DELAY; + + return transition_delay_ns / NSEC_PER_USEC; +} + +/** + * Get pstate transition latency value from ACPI tables that firmware + * set instead of using hardcode value directly. + */ +static u32 amd_pstate_get_transition_latency(unsigned int cpu) +{ + u32 transition_latency; + + transition_latency = cppc_get_transition_latency(cpu); + if (transition_latency == CPUFREQ_ETERNAL) + return AMD_PSTATE_TRANSITION_LATENCY; + + return transition_latency; +} + /** * amd_pstate_init_freq: Initialize the max_freq, min_freq, * nominal_freq and lowest_nonlinear_freq for @@ -848,8 +878,8 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) goto free_cpudata1; } - policy->cpuinfo.transition_latency = AMD_PSTATE_TRANSITION_LATENCY; - policy->transition_delay_us = AMD_PSTATE_TRANSITION_DELAY; + policy->cpuinfo.transition_latency = amd_pstate_get_transition_latency(policy->cpu); + policy->transition_delay_us = amd_pstate_get_transition_delay_us(policy->cpu); policy->min = min_freq; policy->max = max_freq; From patchwork Thu Apr 25 08:07:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 792563 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2070.outbound.protection.outlook.com [40.107.102.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C071074432; Thu, 25 Apr 2024 08:08:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032525; cv=fail; b=NFRFDZH/XThkXI1xm6DpTcOdF5Cs+1A5pZgsdRnMgYIV4Aenefr+c1UbMmVZ6hwmofxjBr3aSTV9LrEluVubvCyN9j7dfgwul9RsFvvN1AiVrCy1LYAKwZxF7tWHd7tBxK2dr2oUg+n6bSgMU0YHBCXPFRAXoGOmdmbmROdmjpo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032525; c=relaxed/simple; bh=g6WD0ANrhaMgE1Y1p/jcF0wVTNB8YbtDmxbug3MTWRU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pK63hyjO0VR7x8kRdg/K89n0pyQWAE53ztPUeajHc/KXTYA0Yw6RGi5I+H4VPo4p9L5JzXk5Wvy95JnSmENzSF517G/YPcFmMTMsoGKCJpYM3W6nRiv7duxhHgpPXsbL+tO4b9lz6BHI28vQd7yus9a31kJNWAIurxdbTbaywTw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=jXHfMgVh; arc=fail smtp.client-ip=40.107.102.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="jXHfMgVh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZpTNETFrWEJAUHsmJe/5IyXKO90XkhZLnyaun7DhHlFNj/y9bPBuaenh8rNHmIqGPxk1CS2lHhDtkWUyeSN1Gj+eOT11HuC8CQd6vDR2iZiXOiAz4DvMz9FN19Jyt6sAh5tpkjM8sSEPFAvoxS95tXRuPVg39VxveafKC6aJf72CRd6WmRs7zLWP/MXP6Vky4CEIW0umtdei6r6KfMOLN5xWWSn7y2QKrWYoSFoUQYflpgasCmZ/Wwium2STLR8rC5FTkOKu045McrI7901e4QGU/5NVz/qkLyWAqeEI+bUNaGMaxMUkTpUq5e1ov6GKC6mVW3V1XkJXZlQrNZ70Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kQelncCBs748RSNbzkjYxC5MXTdjjmvR9tO/qsHHwQY=; b=mp0FJnysCLbk1bwWzNrRT+8w0rHl/TYYyoHIhWU+gUeYm33qpahsFvCgOwlqg14GGLshyUoPadVLGCZUxpMrdij5GxIdrNO5wQ7sYXoWPgMuIUO50MYiXs2EVDLl9iVyhOQzv7IqjHOWeAJ4bVxH6C7M7kOWHnIECmraljVAbrclDxYIpuaL0ig0QltnFEqk8QH07h+SS5OOy3G+C0XrupkNd2vqfZxflFSHWVqwk8p8DsyUpT9QsYJg3s/f/xQ3MymNsIBeNifFVYBCAenw4GBIyiMghXcjfZFabJOhaeE9SWbn+ZJsvicQUwJRaSEDDJQ10ESTTD2iyQtRTdbSrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kQelncCBs748RSNbzkjYxC5MXTdjjmvR9tO/qsHHwQY=; b=jXHfMgVhX5Iv/BGu0whxkdT34naimqaERTJZYcR8rnhJ46j0SSWGYRPPlryuipHpJKjFPTkMUn6Oi+AF8WXyS5wUlpTlION15eNDTD1kct4ZaILlb7+rzuCaDxZigy++zsEY+RgVxaXfnqToitUiYybNbELDJUVe210sHUVp1oo= Received: from CH0PR04CA0075.namprd04.prod.outlook.com (2603:10b6:610:74::20) by CY8PR12MB7170.namprd12.prod.outlook.com (2603:10b6:930:5a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Thu, 25 Apr 2024 08:08:41 +0000 Received: from CH3PEPF00000012.namprd21.prod.outlook.com (2603:10b6:610:74:cafe::e2) by CH0PR04CA0075.outlook.office365.com (2603:10b6:610:74::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.26 via Frontend Transport; Thu, 25 Apr 2024 08:08:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000012.mail.protection.outlook.com (10.167.244.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.0 via Frontend Transport; Thu, 25 Apr 2024 08:08:40 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr 2024 03:08:37 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v12 7/8] cppc_acpi: print error message if CPPC is unsupported Date: Thu, 25 Apr 2024 16:07:57 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000012:EE_|CY8PR12MB7170:EE_ X-MS-Office365-Filtering-Correlation-Id: 7642be05-70db-41cb-8144-08dc64feeb20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WZKuK0Vbu5uzJQcDttd467zDaPi71kSORbjfuFE9XRfQbGVcYU1EVPyZLsbEezElei2xWNJAmE8d3+yfom+RNxZaRIiqGXkpF35waGJvMcqVdRfUM94UYcizH32uMEojimf9SFwYP1iQUiy/P2ozJHCBIQ8Oik8FS9IFSnacHvHSJCf3TawsisG0f6eCQD9l12PZzl/L6jP/LD3avx1idSVCbOD02mbCpMKRS4r/F8sSyLsqhygatg9ecKwnDP/1Ed+4MyDtsKLKFHvglzUoh25YWIx9i4ZakSuLNN9iqFBQw2m1QSdn/0IBw3XtDQACwWg1aY5/chwmoCsIF/hz5ahG3kGgBA4JIY0lczY1N3UEftANtqks7Zg2RV4rjTDOamLqPrGkg6qnf+CrDvCSPmL3/75XHAtw9amHvN7spVlorUcXc04MnmxLKxDg/6k6a8Zc4+PtU7XI1dbisG6kEvG3+wnINpfiqRDPPCkmT8sAl+OcFtc7CY4bey5Habyvg1zzADeeOqnVwd+sKnvsaRYCpJ+24HzVSMxOrZqYsK+JkAvS1ELYmktWyFGUoLxg3TLkF+mCi/Qy3iGCnG0QoUsDwyipt32CjHtIDXlNwAnw+gTTVsxepeLddhI/C9Om1A3WEMI5GfQI/o8zlpwL526UkqicUNsfnWCYAUKYfYw87JFZ4y/7bOSoJktFIIiQkOKEVv2V7YwL27osIPbV10+27Y8NyQCZQcVGKvyHMI5OptbesAOvgVHgF4Sr5qy7KJt8FGCKLpwbt5J5NdqAkFxDYiloPVuEqb1f2m0XnULB9sJIWzGpOib+tEpn1TDD6faHSu+vlzFfIT7u+16AI39NGT3GozdPlR5ZHkJtHM+3YL/YS8w7WYenRKBGw8pE/QvxRMDmpMl1ByDzDzKHhJihMhUsLPPAVgCTjOd3UZKBrnvUeGhUMj+m1trpJucX6vlhTarGyelH2aLEgXpojRpLZF/aBvcAA4JFsBY+kOwDKEG099Q3kPETYdWkqyDUTjNq1KljKc3BjXMulChUi/lFUp8pWiZD2IgDP/Ys6+raq6+HW5BnI8ceIowIH4hH+gvxtlOqapTaq/M2P1T/a+jJvREfAZgEVMnUxF4q2h3JOu1hsFeoGAJKXZyTkrPJvVJMPmwkEHv5PIilzdZtAqtceI6E5ezFTcnjitsZ9bMUAzoSs3J5m9Mju9iRFbnhVyNBNhl3Q5m8n0A88VmvfBqMHcbtjRRU9N9UTN7oyB7jpyKmIz606IMFGD6ECdbWBjiv4/qZ0YnahrjmQ8CS5rGK00eNEmy7si6nANUPE3Nh6+1YtQC7G78EeNvEuAdwv+VTJaO7Xr4mgBNHO2NC1JD/WJKMbnJbBoI6vn1bld2YZplbiMfDwM2dEHm9lyKG X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(1800799015)(376005)(82310400014)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 08:08:40.8389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7642be05-70db-41cb-8144-08dc64feeb20 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000012.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7170 The amd-pstate driver can fail when _CPC objects are not supported by the CPU. However, the current error message is ambiguous (see below) and there is no clear way for attributing the failure of the amd-pstate driver to the lack of CPPC support. [ 0.477523] amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled Fix this by adding an debug message to notify the user if the amd-pstate driver failed to load due to CPPC not be supported by the CPU Reviewed-by: Mario Limonciello Reviewed-by: Gautham R. Shenoy Tested-by: Dhananjay Ugwekar Signed-off-by: Perry Yuan Acked-by: Huang Rui --- drivers/acpi/cppc_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index a40b6f3946ef..1d857978f5f4 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -686,8 +686,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr) if (!osc_sb_cppc2_support_acked) { pr_debug("CPPC v2 _OSC not acked\n"); - if (!cpc_supported_by_cpu()) + if (!cpc_supported_by_cpu()) { + pr_debug("CPPC is not supported by the CPU\n"); return -ENODEV; + } } /* Parse the ACPI _CPC table for this CPU. */ From patchwork Thu Apr 25 08:07:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 792228 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2069.outbound.protection.outlook.com [40.107.93.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 473558594A; Thu, 25 Apr 2024 08:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032529; cv=fail; b=OAdWr+j2fHom5d6NgbFUmrfImgxD+/cuU2agQFOy1QNfrMql/0ydjgwUC5cbFjPAtYNqmxSrSAIpbdvOpwgniqOx6ddlMgS9gsnqluyFPvGv5F9KkiwjAYbBuxc9JSW0HrChr7gdvTxuhTqVwDJAUrJfuFQYzza2+slEZp9Q4ew= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032529; c=relaxed/simple; bh=j1q+E9ZnXMZIXc7Rjt6nP1CRdVKAvNz289xKqrJcwlo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UIWrMZ2SXoZy+Y9iPd8/pGWPJXb+xJ4cat8FnH9lV74aLL6IPJZnR93SHuMvvdDOIoMNB9BCAV/AXyTVACtviUg8eflcElHXz1uSTL50EDSYweoQ4APVpHo7yzx7Ga6K8KZinbGy2SfZPhOgSkifDwWuND2sjYkD39OHMrMnbuQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=e97G4rAE; arc=fail smtp.client-ip=40.107.93.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="e97G4rAE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ktCCX3PDiTftR5apwmlsp9EgU6rvw/zUvzNMPDLQM6FmLLgyBfZ3LGJM5ZBnvNw5gGfNGX53WMCdiscb4IaHOJP6antHCgpJT7oZn+LbEc6B3SaOfLdzQcR+OIF6CfqUr/2W94Ru4jf1fKrQkadeNps3UeA3280CKD3Qd9HsY8VVCtVpDZcfr+EAFkWV6cSaUzR0ke08S8hcvZHMS5S/3aOCMpHsLZCyPOR5pabZlTrukAGT4oAHUWAxeLK2SBZMRrdwW37/wpD7/59mrCsAK22eIObSEEyk0FVHIQ3/BXD38+TK+/qc0w39tGnpM2W/xHAkGF0jzl2fYUyUVc5YOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KhQBkfB3VaHGzUKuG77r2R9IZtcd5OBo3sxYU0IV5xg=; b=Ce5llNB6BcaoA1PtFeDjpBR/gfu9MIc18rPt0vx89QG+R+pO6SX1Q7+7pYnRN8/TaqS5Uq5dyjF4vipqVquwD8Vmcr+Yv7IxjXRz1Ic7K27bqQ1TkRtFebZ3dBz7epXsZ+r1DKMQtiQhZPlH+wkL35jgQxMzRwz2Pts7xeG1WuzffIdHlQhRZ6Lilijk2rYzCjpqrsV/W3Pdndg0qYoOAIf4onbyj+5W4Ksqpa9GhJ2RwrfSghzhs9sW1qGnLelgMS++1goZQR8JcmHsLu2hSOQOF25A8vG2uFyzE416wiCVQVnG1ep57X5nuccWZs/1cZ6QuUiw2A3Cm2lA8S1f+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KhQBkfB3VaHGzUKuG77r2R9IZtcd5OBo3sxYU0IV5xg=; b=e97G4rAEv2i2X8NxPDY5YHtAQAGSwiJOQEiHkPsA4s2ZoS+qREszhtk8mDvy4fIGJNxK5HeVYn8fdedC+KW7GXh7PPULTGEUIW+6NqkjNAI7F5Ool5BbqXGRiKtm5utaJufytQfEhvCxahpr4XQExLyMqidMPrX4dPJP+AZxC84= Received: from CH0PR13CA0051.namprd13.prod.outlook.com (2603:10b6:610:b2::26) by CYYPR12MB8871.namprd12.prod.outlook.com (2603:10b6:930:c2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Thu, 25 Apr 2024 08:08:44 +0000 Received: from CH3PEPF00000018.namprd21.prod.outlook.com (2603:10b6:610:b2:cafe::f0) by CH0PR13CA0051.outlook.office365.com (2603:10b6:610:b2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.10 via Frontend Transport; Thu, 25 Apr 2024 08:08:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000018.mail.protection.outlook.com (10.167.244.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.0 via Frontend Transport; Thu, 25 Apr 2024 08:08:44 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr 2024 03:08:40 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v12 8/8] cpufreq: amd-pstate: Add quirk for the pstate CPPC capabilities missing Date: Thu, 25 Apr 2024 16:07:58 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000018:EE_|CYYPR12MB8871:EE_ X-MS-Office365-Filtering-Correlation-Id: 59abe25e-e866-4f36-8c58-08dc64feed4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|1800799015|82310400014|376005; X-Microsoft-Antispam-Message-Info: o8pcCFzltJh33gYqlzzPM8iMnTeLiBn/9bHOVRQAqZ17zxdHbz13fX/EuRFXwzJEByzpLYuB5Nw2QfhtUMN3K83m92iu9bigjsc/Mt2E7eWlNyO53j8fi2CWQVNE+igY2ckFZP7pCKvoo3CpzitQkXhbWtL0OJLymMzTW4FZH+E6kt5n3tTb2xcGJ7RcT7EU3JLvwlMDVJAysDjyVFMkDOI9N8swon8aEb9pmF6VZxvYTuM3BfWoawFWBr7gPZt/h/pwsn8mbeItL2WDJ2wrH5E/wb9h3VIpkFzLJVsX7iTgtsbkx0zjkVXf/Qxt4ebI5AesMvUSAwCa3mUUV7QrCGbZu7YUP7YeHmb2PDSqYRlwtgVVhY5VjtKkO7MSTqsR56yJC7+zYP0Y9Ts60b6PNz+JMr0eekl/JhIxMpdbfDZbIH3HxHa3gVnu2vwaFpFPFJ1+upSCf/bEw8TATM7yxw+w1IrVjF2mVEMRYJ7K91NHpsteRWUrOOfwTFcsjy8tNFL8emc7YLL6fL++0efZAvTfL0gpQvDlLaa/Tgw7JYuYuaFBCmcqO8oPppXmJAPfgwohsSmI49OFy3avINwcYrSpykbvcBlZ4jALDwHf5EvhibMuinoGpdtvshEWqG9p/XdF/ktWdx5lszuizMa7+1Kvz7ng52T1YRiSsPWOIU4jTpjm4u4R8fyPjeIV1+da8RMgbD2/72n75IsUKxx/8eQEvFjPrntMUXWcUm3zd4slgUFnE5TukhJFM9UG/d3YtiJC/1+ka2W2tlP7PgysTbaHFCuH/8yRK54A2iStdO2hRx1IucVIFhwGigSHhPa4MrZzQEYOCw1w9gc87Z+tUxGi+dj/21o+54s8FBmmMHT2q/oSYa9SwfgmvPt2Ml9VPvleG3h69hsKHRqWiwr+zlEKmP6TaX3NuAXIZp4+kaj5zHUNtdIqbBTVHYg2sQ4MC0hWgXnXoJ8lvhX2njG1bzwl98XA1AjoPxRLtw1pCDmLjdFg6TmLWEMQWuthI0WsddSRVChjn8GDJxMOuGfAy3Le0lsWJwWEZLeo/JA2MjjQaZAVtMoMEpg2GNAx8vTuBs/faWsSRl9BX819CWflSWAw8V8XbZ5TMC6uvPJkImCE+AR6Fdz+3owUXWjNqj/U8ACCHdJofl1wytW0z6VmOinUPLQ8aTb01XNZbMNiS24vMF5zdmLSY8Apnz2vRjM50IjDjLsz1Ja9N9qd4CZBT4DWGBpy9smvZ0jNqxGENizZWVG5ablr8SdR3J8xmU1aOc6/NsR6yaUs3Rk+MfAkYyRJnVCf5Byvy5OMtv/UlToCxNfdNLb42mPVlrrU/C8TmlaQnk73TQlhszzynlwRtJ31+wu+Hru18COTrE7PxXgfhhfNLiHjX68I+IrHNF/Q X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 08:08:44.4896 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59abe25e-e866-4f36-8c58-08dc64feed4d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000018.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8871 Add quirks table to get CPPC capabilities issue fixed by providing correct perf or frequency values while driver loading. If CPPC capabilities are not defined in the ACPI tables or wrongly defined by platform firmware, it needs to use quick to get those issues fixed with correct workaround values to make pstate driver can be loaded even though there are CPPC capabilities errors. The workaround will match the broken BIOS which lack of CPPC capabilities nominal_freq and lowest_freq definition in the ACPI table. $ cat /sys/devices/system/cpu/cpu0/acpi_cppc/lowest_freq 0 $ cat /sys/devices/system/cpu/cpu0/acpi_cppc/nominal_freq 0 Acked-by: Huang Rui Reviewed-by: Mario Limonciello Reviewed-by: Gautham R. Shenoy Tested-by: Dhananjay Ugwekar Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 53 ++++++++++++++++++++++++++++++++++-- include/linux/amd-pstate.h | 6 ++++ 2 files changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 510b5aec42ea..83a29b257794 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -67,6 +67,7 @@ static struct cpufreq_driver amd_pstate_epp_driver; static int cppc_state = AMD_PSTATE_UNDEFINED; static bool cppc_enabled; static bool amd_pstate_prefcore = true; +static struct quirk_entry *quirks; /* * AMD Energy Preference Performance (EPP) @@ -111,6 +112,41 @@ static unsigned int epp_values[] = { typedef int (*cppc_mode_transition_fn)(int); +static struct quirk_entry quirk_amd_7k62 = { + .nominal_freq = 2600, + .lowest_freq = 550, +}; + +static int __init dmi_matched_7k62_bios_bug(const struct dmi_system_id *dmi) +{ + /** + * match the broken bios for family 17h processor support CPPC V2 + * broken BIOS lack of nominal_freq and lowest_freq capabilities + * definition in ACPI tables + */ + if (boot_cpu_has(X86_FEATURE_ZEN2)) { + quirks = dmi->driver_data; + pr_info("Overriding nominal and lowest frequencies for %s\n", dmi->ident); + return 1; + } + + return 0; +} + +static const struct dmi_system_id amd_pstate_quirks_table[] __initconst = { + { + .callback = dmi_matched_7k62_bios_bug, + .ident = "AMD EPYC 7K62", + .matches = { + DMI_MATCH(DMI_BIOS_VERSION, "5.14"), + DMI_MATCH(DMI_BIOS_RELEASE, "12/12/2019"), + }, + .driver_data = &quirk_amd_7k62, + }, + {} +}; +MODULE_DEVICE_TABLE(dmi, amd_pstate_quirks_table); + static inline int get_mode_idx_from_str(const char *str, size_t size) { int i; @@ -812,8 +848,16 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata) if (ret) return ret; - min_freq = cppc_perf.lowest_freq * 1000; - nominal_freq = cppc_perf.nominal_freq; + if (quirks && quirks->lowest_freq) + min_freq = quirks->lowest_freq * 1000; + else + min_freq = cppc_perf.lowest_freq * 1000; + + if (quirks && quirks->nominal_freq) + nominal_freq = quirks->nominal_freq ; + else + nominal_freq = cppc_perf.nominal_freq; + nominal_perf = READ_ONCE(cpudata->nominal_perf); highest_perf = READ_ONCE(cpudata->highest_perf); @@ -1662,6 +1706,11 @@ static int __init amd_pstate_init(void) if (cpufreq_get_current_driver()) return -EEXIST; + quirks = NULL; + + /* check if this machine need CPPC quirks */ + dmi_check_system(amd_pstate_quirks_table); + switch (cppc_state) { case AMD_PSTATE_UNDEFINED: /* Disable on the following configs by default: diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index ec0b0fa3e9bb..d58fc022ec46 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -128,4 +128,10 @@ static const char * const amd_pstate_mode_string[] = { [AMD_PSTATE_GUIDED] = "guided", NULL, }; + +struct quirk_entry { + u32 nominal_freq; + u32 lowest_freq; +}; + #endif /* _LINUX_AMD_PSTATE_H */