From patchwork Tue Apr 30 21:36:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 793546 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A811F50287; Tue, 30 Apr 2024 21:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714513003; cv=none; b=XDGbQo5lzLUVxmWrNJzNX1xAla36+G0s7TD71hOGjGZUG60XKLepqKoxjHSu5IP6aRRtF56mz5tUCqJRwQNQfxZ5GcyA5fmzQs+AxVOMPdp9eDWRm9bq3WJZdxpZarY8NRiZD1BOtoolYk1giy+MILw1A17+qjLCRI0rSROU/R8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714513003; c=relaxed/simple; bh=0Qj+D69jEcpqaHMFgZ7FoyOuv7/ML8F9fuodPYJB9X4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Sq/JYKj89RsiX7Na5kQpwXlxRswsUMFTZMoS9qj/mH4nwUDjGQOlKy9LQ1LWsFsC2eIlcBj3J/QHhordfRW2RWMdPnlxKv2p3jsX5aKku2ssaVmHpunuUNM4DaHZLallkDOjpVVxMKsPvs0D3YwIfcmziHUOIFrzPGGVuL35/gM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=jhwOjB2/; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jhwOjB2/" Received: from pendragon.ideasonboard.com (unknown [109.130.69.237]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CA0966F; Tue, 30 Apr 2024 23:35:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1714512943; bh=0Qj+D69jEcpqaHMFgZ7FoyOuv7/ML8F9fuodPYJB9X4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jhwOjB2/QdCt3pb/4iqM21+Dd2f4UA25f9N0jpS19nz/XOZqWjsW78VJxUafll4+2 fHaBCkbVwYzmnSNDhTXm6V7x+My4iMitDGRTMG3DG/fi87msmsO0+QiNEsnwkN02XL KkkHVaso2cwBUUW2SjUaY34/CZZyK2w/O3zLUZ6I= From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Naushir Patuck , Dave Stevenson , Sakari Ailus , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] media: bcm2835-unicam: Drop usage of of_match_ptr() Date: Wed, 1 May 2024 00:36:32 +0300 Message-ID: <20240430213633.23767-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240430213146.23187-1-laurent.pinchart@ideasonboard.com> References: <20240430213146.23187-1-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Using of_match_ptr() to set the .of_match_table field of the device driver results in the unicam_of_match table being unused on non-OF platforms, causing a compilation warning. Fix it by dropping usage of of_match_ptr(), which can be done because the .of_match_table field is part of the device_driver structure regardless of whether or not CONFIG_OF is selected. Signed-off-by: Laurent Pinchart Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8aTC84kE-lkp@intel.com/ Reviewed-by: Ricardo Ribalda --- drivers/media/platform/broadcom/bcm2835-unicam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c index bd2bbb53070e..c590e26fe2cf 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -2733,7 +2733,7 @@ static struct platform_driver unicam_driver = { .driver = { .name = UNICAM_MODULE_NAME, .pm = pm_ptr(&unicam_pm_ops), - .of_match_table = of_match_ptr(unicam_of_match), + .of_match_table = unicam_of_match, }, }; From patchwork Tue Apr 30 21:36:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 793930 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CA531BED60; Tue, 30 Apr 2024 21:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714513003; cv=none; b=MRcbNdnr6E7M1C2AAn1eJRTpO05JC/wnIdsg5jmcio2JhX63KAJ3Lv7NJ7d0NAHwwIlpR+/KClyFgDiIOoDHGT08M+qwuEy6uTKkOyDXfZ1R2vIs45K3julhzbV0ltTd0iybx8kdo5ROuopTd8TFWUo+yaI5yr71p/Zvdz7tbIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714513003; c=relaxed/simple; bh=8wmctBpBoob2v9+vY4JOC+E0Zgc0jTFshoOo4TzelD8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=McGpyG3qQIzSnUz5IgmEVAGmsxBFiimSGElSoRNYg1qA9+CeZTR7EEISO6WIx7kpqxvoeHEsEPQ3qRiJhZx1suTsUfWSf9IwOrv6JnVHDh7Z7WwPORA5ywxSUEKbPGGL7/jebejalpa5JoX87zI2vieS8c7DJj+DoG1YHEWdXTo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=kW3Pqz3x; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kW3Pqz3x" Received: from pendragon.ideasonboard.com (237.69-130-109.adsl-dyn.isp.belgacom.be [109.130.69.237]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6279CDFB; Tue, 30 Apr 2024 23:35:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1714512944; bh=8wmctBpBoob2v9+vY4JOC+E0Zgc0jTFshoOo4TzelD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kW3Pqz3xsVKcPSo0AMj5291wkB7VvNxzY5t9iGFdhEQXsmcKNt7Y4LcPt8F5dGdbT X7YNb8Rlzq5umn6j0c6Uy8LxS5ZQG8xMLUJtDbCUds9qcIddaIaurOtHhlCxzoCDKT GcCTHIVfMNqU4vz2a2sAOYOIgb2BSjxB+Z3NlpgE= From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Naushir Patuck , Dave Stevenson , Sakari Ailus , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h Date: Wed, 1 May 2024 00:36:33 +0300 Message-ID: <20240430213633.23767-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240430213633.23767-1-laurent.pinchart@ideasonboard.com> References: <20240430213146.23187-1-laurent.pinchart@ideasonboard.com> <20240430213633.23767-1-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The unicam driver uses the v4l2_subdev structure. Include the corresponding header instead of relying on indirect includes. Signed-off-by: Laurent Pinchart Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8aTC84kE-lkp@intel.com/ --- drivers/media/platform/broadcom/bcm2835-unicam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c index c590e26fe2cf..3c7878d8d79b 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -55,6 +55,7 @@ #include #include #include +#include #include #include "bcm2835-unicam-regs.h"