From patchwork Mon Jun 17 14:39:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Curutchet X-Patchwork-Id: 805499 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7214615AD93; Mon, 17 Jun 2024 14:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635158; cv=none; b=UKzeFaXVSof9qFXVuIfW50Z0+rei3ThiwCnq7VqS1/PiWZWSKRKAdxc9m97M+5XOYY0MNbDmSAqtsr99YbcsnWLk6fRdKkUqvjDo96aQiMgnZsCU5LyUMNWSa7XeMGPHVijh3dY/UBKXuP1TWKM+0wKVsd4iZAGudPEWMPfSp+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635158; c=relaxed/simple; bh=YMbrlYAacq8VnF6uzSYjpNqyLR/Zwj3QjxxEfxNoWV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e+DS6zw6CexUvmfGoDtUVyOm6AwLT7XEU1pqA+bMr0B1aE04ZBw5YMCLNkkpXLJoghlwNilr3Rkyb3XWxL+S+ruD680QzYMFtyIr/rXcPZ8Xz3XFrIsudL5OQYZVSltlxlcEmzIRa3slDodHBTFTVDz/gACt1VQpwBB9TNuymnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=AhlP4hBp; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="AhlP4hBp" Received: by mail.gandi.net (Postfix) with ESMTPA id 76B271BF20B; Mon, 17 Jun 2024 14:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1718635153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qt7UmrwvNzoZ4+Yje8MDhIVAuMdtzcc+/RmUSruDHcw=; b=AhlP4hBpI7Cym6yX78bmVgHaxNtsDe0spDn3f0AKUlFLZFu9xO5NxHHrmKg/XqlRpczeNG eQFt4LWGNTkeUPAQVFiDh8sNcYp4PPQsok/b0PkgFyr/SHawLLpmQniPic2ap90vn4VkrF FeVBk+hPbUX8cAi/ctoS37C16iultayklSCWa79+Cjcd/J4WuCr/Z9lOEptPtAJrewS6AN OH+rC0h6qhr61ndPnyQJuEnxf1G2w7ORIQWnF+XsXyrA8WcdBcAKAUqmIJJP0n7NnH9vqk eery3xnPnk3vtio510vqBDVsjc5ooJOGQWlZB8g0vkbrm6qVN45uJY4x8wuL6g== From: Bastien Curutchet To: Riku Voipio , Pavel Machek , Lee Jones Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Herve Codina , Christopher Cordahi , Bastien Curutchet Subject: [PATCH v2 1/4] leds: pca9532: Use defines to select PWM instance Date: Mon, 17 Jun 2024 16:39:07 +0200 Message-ID: <20240617143910.154546-2-bastien.curutchet@bootlin.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240617143910.154546-1-bastien.curutchet@bootlin.com> References: <20240617143910.154546-1-bastien.curutchet@bootlin.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: bastien.curutchet@bootlin.com Two tables are used to configure the PWM and PSC registers of the two PWM available in the pca9532. Magic numbers are used to access this table instead of defines. Add defines PCA9532_PWM_ID_0 and PCA9532_PWM_ID_1 and use them in place of these magic numbers. Signed-off-by: Bastien Curutchet --- drivers/leds/leds-pca9532.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index bf8bb8fc007c..b6e5f48bffe7 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -45,6 +45,9 @@ struct pca9532_data { struct gpio_chip gpio; #endif const struct pca9532_chip_info *chip_info; + +#define PCA9532_PWM_ID_0 0 +#define PCA9532_PWM_ID_1 1 u8 pwm[2]; u8 psc[2]; }; @@ -181,12 +184,12 @@ static int pca9532_set_brightness(struct led_classdev *led_cdev, led->state = PCA9532_ON; else { led->state = PCA9532_PWM0; /* Thecus: hardcode one pwm */ - err = pca9532_calcpwm(led->client, 0, 0, value); + err = pca9532_calcpwm(led->client, PCA9532_PWM_ID_0, 0, value); if (err) return err; } if (led->state == PCA9532_PWM0) - pca9532_setpwm(led->client, 0); + pca9532_setpwm(led->client, PCA9532_PWM_ID_0); pca9532_setled(led); return err; } @@ -209,11 +212,11 @@ static int pca9532_set_blink(struct led_classdev *led_cdev, /* Thecus specific: only use PSC/PWM 0 */ psc = (*delay_on * 152-1)/1000; - err = pca9532_calcpwm(client, 0, psc, led_cdev->brightness); + err = pca9532_calcpwm(client, PCA9532_PWM_ID_0, psc, led_cdev->brightness); if (err) return err; if (led->state == PCA9532_PWM0) - pca9532_setpwm(led->client, 0); + pca9532_setpwm(led->client, PCA9532_PWM_ID_0); pca9532_setled(led); return 0; @@ -229,9 +232,9 @@ static int pca9532_event(struct input_dev *dev, unsigned int type, /* XXX: allow different kind of beeps with psc/pwm modifications */ if (value > 1 && value < 32767) - data->pwm[1] = 127; + data->pwm[PCA9532_PWM_ID_1] = 127; else - data->pwm[1] = 0; + data->pwm[PCA9532_PWM_ID_1] = 0; schedule_work(&data->work); @@ -246,7 +249,7 @@ static void pca9532_input_work(struct work_struct *work) mutex_lock(&data->update_lock); i2c_smbus_write_byte_data(data->client, PCA9532_REG_PWM(maxleds, 1), - data->pwm[1]); + data->pwm[PCA9532_PWM_ID_1]); mutex_unlock(&data->update_lock); } @@ -475,9 +478,9 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np) pdata->gpio_base = -1; - of_property_read_u8_array(np, "nxp,pwm", &pdata->pwm[0], + of_property_read_u8_array(np, "nxp,pwm", &pdata->pwm[PCA9532_PWM_ID_0], ARRAY_SIZE(pdata->pwm)); - of_property_read_u8_array(np, "nxp,psc", &pdata->psc[0], + of_property_read_u8_array(np, "nxp,psc", &pdata->psc[PCA9532_PWM_ID_0], ARRAY_SIZE(pdata->psc)); for_each_available_child_of_node(np, child) { From patchwork Mon Jun 17 14:39:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Curutchet X-Patchwork-Id: 805037 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94F7D15AD86; Mon, 17 Jun 2024 14:39:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635158; cv=none; b=Bs88AWQjfiJOMotd0yHw8FkCCUeVW24R44bTy/e9uccSzUYT4ksXT29aPmqyeFXuqd1gTPGzHL4RdiIlZTIDhWtMRowPE5Xgbxd1pbU4G2RnqgO7o8EIOu39XNa043GRHnRbgml9MLCVQAvBzDEnjpT03ifFkN7iUbvtmLQr2gI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635158; c=relaxed/simple; bh=fNEcNyx2J3ltaqVb/40esraFs0i+Fi+TRItBm4S/zws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kHOmUXZXDyk3PXWDmisRKkjPBjEVZIB7PiWHrglwh2XcRPuZ5EK+e9HbWc6tRqLSnQVq7WIwVtA3j7uJkbjslt8rC3whu0mHrn6J5Vk1s6hjhe2jry5ckljn1meznnjZPq0OYSV/FNMDYfkwtD3QUT2M/Gvo4O+Ad94pyR8RhHo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=HbOYp3un; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="HbOYp3un" Received: by mail.gandi.net (Postfix) with ESMTPA id A3F811BF207; Mon, 17 Jun 2024 14:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1718635155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HOc1KiNHDMlfberoe2a1L+3nunCrn9fY9dBs4yJhsG8=; b=HbOYp3unUKRaylSWxNla3PiSkRMtTYD1q1hbyN68+jbn/E6uMM++OGwfZpUUXULIhb27GN MGzbttMnu2qPZ5zzbtelaUCzjQwZcoBYvQqf00jIlphswiqnFQtn44XPLKJ2zci4PTX4bj kBC0noqrYuAoXe0ZE2U0rMwIbx+0MYyJAArOLWJCnzbul40nWUjBa01fWFaeqFx1JgIDLz WM+1BLUC7CpXOokj7Cu9C5GExk43XFQXg71VgAqO2OV88YXVbND24Fo2JzMxtMk58Uq927 IcBxceVrxkJ4Tk2B0VEW+TBmGOEGmlbDd6dmqA9O19lAmjUmYNYDQnushiLjaQ== From: Bastien Curutchet To: Riku Voipio , Pavel Machek , Lee Jones Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Herve Codina , Christopher Cordahi , Bastien Curutchet Subject: [PATCH v2 2/4] leds: pca9532: Use PWM1 for hardware blinking Date: Mon, 17 Jun 2024 16:39:08 +0200 Message-ID: <20240617143910.154546-3-bastien.curutchet@bootlin.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240617143910.154546-1-bastien.curutchet@bootlin.com> References: <20240617143910.154546-1-bastien.curutchet@bootlin.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: bastien.curutchet@bootlin.com PSC0/PWM0 are used by all LEDs for brightness and blinking. This causes conflicts when you set a brightness of a new LED while an other one is already using PWM0 for blinking. Use PSC1/PWM1 for blinking. Check that no other LED is already blinking with a different PSC1/PWM1 configuration to avoid conflict. Signed-off-by: Bastien Curutchet --- drivers/leds/leds-pca9532.c | 53 ++++++++++++++++++++++++++++++------- 1 file changed, 43 insertions(+), 10 deletions(-) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index b6e5f48bffe7..244ae3ff79b5 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -29,6 +29,9 @@ #define LED_SHIFT(led) (LED_NUM(led) * 2) #define LED_MASK(led) (0x3 << LED_SHIFT(led)) +#define PCA9532_PWM_PERIOD_DIV 152 +#define PCA9532_PWM_DUTY_DIV 256 + #define ldev_to_led(c) container_of(c, struct pca9532_led, ldev) struct pca9532_chip_info { @@ -194,29 +197,59 @@ static int pca9532_set_brightness(struct led_classdev *led_cdev, return err; } +static int pca9532_update_hw_blink(struct pca9532_led *led, + unsigned long delay_on, unsigned long delay_off) +{ + struct pca9532_data *data = i2c_get_clientdata(led->client); + unsigned int psc; + int i; + + /* Look for others LEDs that already use PWM1 */ + for (i = 0; i < data->chip_info->num_leds; i++) { + struct pca9532_led *other = &data->leds[i]; + + if (other == led) + continue; + + if (other->state == PCA9532_PWM1) { + if (other->ldev.blink_delay_on != delay_on || + other->ldev.blink_delay_off != delay_off) { + dev_err(&led->client->dev, + "HW can handle only one blink configuration at a time\n"); + return -EINVAL; + } + } + } + + psc = ((delay_on + delay_off) * PCA9532_PWM_PERIOD_DIV - 1) / 1000; + if (psc > U8_MAX) { + dev_err(&led->client->dev, "Blink period too long to be handled by hardware\n"); + return -EINVAL; + } + + led->state = PCA9532_PWM1; + data->psc[PCA9532_PWM_ID_1] = psc; + data->pwm[PCA9532_PWM_ID_1] = (delay_on * PCA9532_PWM_DUTY_DIV) / (delay_on + delay_off); + + return pca9532_setpwm(data->client, PCA9532_PWM_ID_1); +} + static int pca9532_set_blink(struct led_classdev *led_cdev, unsigned long *delay_on, unsigned long *delay_off) { struct pca9532_led *led = ldev_to_led(led_cdev); - struct i2c_client *client = led->client; - int psc; - int err = 0; + int err; if (*delay_on == 0 && *delay_off == 0) { /* led subsystem ask us for a blink rate */ *delay_on = 1000; *delay_off = 1000; } - if (*delay_on != *delay_off || *delay_on > 1690 || *delay_on < 6) - return -EINVAL; - /* Thecus specific: only use PSC/PWM 0 */ - psc = (*delay_on * 152-1)/1000; - err = pca9532_calcpwm(client, PCA9532_PWM_ID_0, psc, led_cdev->brightness); + err = pca9532_update_hw_blink(led, *delay_on, *delay_off); if (err) return err; - if (led->state == PCA9532_PWM0) - pca9532_setpwm(led->client, PCA9532_PWM_ID_0); + pca9532_setled(led); return 0; From patchwork Mon Jun 17 14:39:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Curutchet X-Patchwork-Id: 805498 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B90D415ADA3; Mon, 17 Jun 2024 14:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635159; cv=none; b=KW0XsXYKvi47xcEn2jTdUJOCh+oyONGQ6atVSvDR973qjulb+tVYjbMmGLuR15JoIY+eUBpHuoSowyKT45fecd9lGoCO5cMdstQOptMHP2NxE2sBhLpP1ITbmXdf/Pw1XQqDfIeH8SrYPqn02zZVhrskE3W/fWD621WM096PJm0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635159; c=relaxed/simple; bh=6nrj6/a24QJFSZToJHuf9ql/CkxfXffm9v3w8u7tOAw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=joZxtbjBXMT4cuahG9aTCfaiAt/639hONaOakmu5D9sQDxkk9/3RW20vGV6f/xc3x5tUJ9xOLi9kMfcWY3EV/ghuhY3nCIKS17HKLVAkaCHI9A40nslcOt3YP3zVZo3qp+QqjzAd1CZ4sQdsqhhEE4f8CMFdRqp7/0h4xsHMWpI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=NCqCDfEZ; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="NCqCDfEZ" Received: by mail.gandi.net (Postfix) with ESMTPA id AF23D1BF209; Mon, 17 Jun 2024 14:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1718635156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ycSwcZwlwGJEHJqy8a8Ha4d7p1eYd2BTEw/EOqHej6c=; b=NCqCDfEZyIIlsmA4TsHp2maSO5CD9xfVZZn/fBywNXGwncfmy5yUAtjKj5PA/YXJ7sjbJx /aaXx64kY0Mi7k7hbiJHz6OOCEDC9AWPHTIpE/7D6WDpAKKHdJu2EerIYpebDr+ySTB6eP XXxw9lIn8OkZK/fcePfl3AHFQnsdPlI4JmwHbFfS3anfX7DnaUW+LDoYDo+cb2vDeaAxN9 9al9RUgWEDTguUqBRNklt/KkgLlM2opsuLrR75SwOUA6960dgbHAJJbBgYmubmPAF7mXIx pRD8O40AM3fo6olm2MOkDcpkOqK/4jhom3Db1ZaKqf/P0uUppvdtREvrEbF5Kg== From: Bastien Curutchet To: Riku Voipio , Pavel Machek , Lee Jones Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Herve Codina , Christopher Cordahi , Bastien Curutchet Subject: [PATCH v2 3/4] leds: pca9532: Explicitly disable hardware blink when PWM1 is unavailable Date: Mon, 17 Jun 2024 16:39:09 +0200 Message-ID: <20240617143910.154546-4-bastien.curutchet@bootlin.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240617143910.154546-1-bastien.curutchet@bootlin.com> References: <20240617143910.154546-1-bastien.curutchet@bootlin.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: bastien.curutchet@bootlin.com When a LED is used to drive a beeper, it uses PWM1. This can cause conflicts if an other LED want to use PWM1 for blinking. Disable use of hardware for blinking when one or more LEDs are used to drive beepers. Signed-off-by: Bastien Curutchet --- drivers/leds/leds-pca9532.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index 244ae3ff79b5..c7a4f677ed4d 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -53,6 +53,7 @@ struct pca9532_data { #define PCA9532_PWM_ID_1 1 u8 pwm[2]; u8 psc[2]; + bool hw_blink; }; static int pca9532_probe(struct i2c_client *client); @@ -238,8 +239,13 @@ static int pca9532_set_blink(struct led_classdev *led_cdev, unsigned long *delay_on, unsigned long *delay_off) { struct pca9532_led *led = ldev_to_led(led_cdev); + struct i2c_client *client = led->client; + struct pca9532_data *data = i2c_get_clientdata(client); int err; + if (!data->hw_blink) + return -EINVAL; + if (*delay_on == 0 && *delay_off == 0) { /* led subsystem ask us for a blink rate */ *delay_on = 1000; @@ -395,6 +401,7 @@ static int pca9532_configure(struct i2c_client *client, data->psc[i]); } + data->hw_blink = true; for (i = 0; i < data->chip_info->num_leds; i++) { struct pca9532_led *led = &data->leds[i]; struct pca9532_led *pled = &pdata->leds[i]; @@ -429,6 +436,8 @@ static int pca9532_configure(struct i2c_client *client, pca9532_setled(led); break; case PCA9532_TYPE_N2100_BEEP: + /* PWM1 is reserved for beeper so blink will not use hardware */ + data->hw_blink = false; BUG_ON(data->idev); led->state = PCA9532_PWM1; pca9532_setled(led); From patchwork Mon Jun 17 14:39:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Curutchet X-Patchwork-Id: 805036 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B159C15ADB2; Mon, 17 Jun 2024 14:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635160; cv=none; b=UzOHngPWQX0eWYWZByX3TBUzGfvlI+XWjP/l//HABNE1b/LKUUUQGCTwgKtJMmYPKL+KwboExaN3b8UsM//scTqkSihztQPkG+vZmqhWiHA94p5skRstq6IGt5vvobu7pT7EXq2ShDyDOZX4qyEX//PJ9gG531uc6zWs7j9XY7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635160; c=relaxed/simple; bh=LPG4MiMDAkQ0MMZeULt23aL6A8Mgcu+KD40iGiJT7kA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VE3nW244hmbmwlQElCrIBUquIDYDnvCNxuncF20QO4S6v1tuC+3i/Zyi+fljQt7IvTVCa/QTm3gM7kkqmmBglVOU4EsIW9e4wz8oFfSL8VfHUm9L8uNrQgrlgbWjQpzIfwpigan8w8+aZbdARRR51oufcd0FyfVkthYN+VMw7yk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=b37tzJGP; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="b37tzJGP" Received: by mail.gandi.net (Postfix) with ESMTPA id AB23B1BF20F; Mon, 17 Jun 2024 14:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1718635157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gaG5bleDwToDs0cUeSJi4WXAYLyvsArl/AdUBHxQ+Pg=; b=b37tzJGPULA5jRCxKQfSlXRTXLeHZoShQGGhw/DgnsLtMKZqRBifR1lfxRS40zqjPrcTFJ YxxkLRg3zGL7muzXWnRc/nn/SpiPhcuAGEcXkxu04nOKOdzXBcQSlfiGjMeHP0aAPzOvGS 6UvYLL1/z3BYGMDuEOubkyeNbWE9966lCt4UjUxbXJjA9EvShFtn7BiHZY2I1SJlKKOCx1 SFUmP3X7ytgVL0OJbg5828yY8sucBb8D7MFQPK5PCWsWYiGV0kH3/e4GSNln71bh8XNtBd 2Omz5XI6OvQP9pFdqEnQEUOoaMsoRVVGhZUlW40bKW06mqOXzHPenORmIsC/nQ== From: Bastien Curutchet To: Riku Voipio , Pavel Machek , Lee Jones Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Herve Codina , Christopher Cordahi , Bastien Curutchet Subject: [PATCH v2 4/4] leds: pca9532: Change default blinking frequency to 1Hz Date: Mon, 17 Jun 2024 16:39:10 +0200 Message-ID: <20240617143910.154546-5-bastien.curutchet@bootlin.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240617143910.154546-1-bastien.curutchet@bootlin.com> References: <20240617143910.154546-1-bastien.curutchet@bootlin.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: bastien.curutchet@bootlin.com Default blinking period is set to 2s. This is too long to be handled by the hardware (maximum is 1.69s). Set the default blinking period to 1s to match what is done in the other LED drivers. Signed-off-by: Bastien Curutchet --- drivers/leds/leds-pca9532.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index c7a4f677ed4d..9f3fac66a11c 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -248,8 +248,8 @@ static int pca9532_set_blink(struct led_classdev *led_cdev, if (*delay_on == 0 && *delay_off == 0) { /* led subsystem ask us for a blink rate */ - *delay_on = 1000; - *delay_off = 1000; + *delay_on = 500; + *delay_off = 500; } err = pca9532_update_hw_blink(led, *delay_on, *delay_off);