From patchwork Thu Jun 20 10:19:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Juszkiewicz X-Patchwork-Id: 805975 Delivered-To: patch@linaro.org Received: by 2002:a5d:508d:0:b0:362:4979:7f74 with SMTP id a13csp212823wrt; Thu, 20 Jun 2024 03:20:44 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVCozeS6q4/ripRObe3DRAtnPTcOI3rGt6ncnmC8NsoulpMNvfd9UqA1tdTTb+pXW/Gl6yIMj6PyhKxni0CEFFQ X-Google-Smtp-Source: AGHT+IHvMpViwK+tYKkytjemmnd4UmeVFWr8e8odwfY+ZCcv8hljtJKsxaPdODGITLvOptW/tq5w X-Received: by 2002:a05:6808:1911:b0:3d5:108a:5ae6 with SMTP id 5614622812f47-3d51b96722amr5602262b6e.9.1718878844401; Thu, 20 Jun 2024 03:20:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718878844; cv=none; d=google.com; s=arc-20160816; b=kvdyaH8QeV6vAiBOJ0YMfeSehuMnrumkzWpc23w9UIiVjNCA1A5LeQ6ArWE1/7ODZB 6+lyi8dmoBJKs9WwD1rqbXHYXqfzPnzmt8cm48lkboyMD5mETLw/pNYVcOBk/Oo058rs ENrCu9lLgJsSAeZKMyjqw5+j8yz3MKJFszOp3xQc57DHU4TZg+tzqr288uHAcvr5eebD sNPWKdi/BCgcmVHxZU4K2xmUC12rwBtE02QajbDGVSx1DWk0/7es1EVv5zD5v14Xqlcz m94WytFUj0MbhspTBKpYv9jNf53l75sPyyXKcuYTbjifyVmur9I+3j6qtaL9m80QjskV hHcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from; bh=2AJE1qYqxwtxxBg7+lADhoMRVndOyx2JvS2Mmry6pT4=; fh=V5vxXQ+IqdfQGwyC5zGLWXOc0z8EtcFzLjSj1F25uQo=; b=nLUHslNKFNnqXnQaol9LL1fy2LHn/idJaapUm77V7/lkZLKRmthJNQtZK+pY5WMCQN vLWvoPRiCh9T/tZQyrirMTGi+ofQ5Bgcq5kngck0MW/9yPkC5bbdzroszSGGqBWRJers QQe8+PKgZy8lON8KOM0816qfP1oJwuoRMaOkYeKJPzdrbExDnsfI/IEwUoUlidgj/3cX NuJABtLWYtQ/y7o03dg9dSpEL4TQuWpEXYOeLnQXisnyeTWY05FZM3KMXh4nbU/8eG4g V6YfMs8dfZsHIjbMJHcESYwBE5iIsTO5vTjr5FRTN5bnD2gC56RB0LKskLIQhXTKt1Z0 mJPQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-441ef3b9b59si166789171cf.110.2024.06.20.03.20.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jun 2024 03:20:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKEth-00020T-SO; Thu, 20 Jun 2024 06:20:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKEtg-0001ze-7Z; Thu, 20 Jun 2024 06:20:04 -0400 Received: from muminek.juszkiewicz.com.pl ([213.251.184.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKEtd-0001T3-Ph; Thu, 20 Jun 2024 06:20:03 -0400 Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id A24CF2619F3; Thu, 20 Jun 2024 12:19:59 +0200 (CEST) X-Virus-Scanned: Debian amavis at juszkiewicz.com.pl Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavis, port 10024) with ESMTP id A8L72k9JCi3L; Thu, 20 Jun 2024 12:19:57 +0200 (CEST) Received: from applejack.lan (83.11.22.244.ipv4.supernova.orange.pl [83.11.22.244]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id BE88D26071F; Thu, 20 Jun 2024 12:19:56 +0200 (CEST) From: Marcin Juszkiewicz Date: Thu, 20 Jun 2024 12:19:48 +0200 Subject: [PATCH v3 1/2] tests/avocado: update firmware for sbsa-ref MIME-Version: 1.0 Message-Id: <20240620-b4-new-firmware-v3-1-29a3a2f1be1e@linaro.org> References: <20240620-b4-new-firmware-v3-0-29a3a2f1be1e@linaro.org> In-Reply-To: <20240620-b4-new-firmware-v3-0-29a3a2f1be1e@linaro.org> To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Leif Lindholm , Radoslaw Biernacki , Cleber Rosa , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal , Ard Biesheuvel , Rebecca Cran , Marcin Juszkiewicz X-Mailer: b4 0.13.0 Received-SPF: softfail client-ip=213.251.184.221; envelope-from=marcin.juszkiewicz@linaro.org; helo=muminek.juszkiewicz.com.pl X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Update firmware to have graphics card memory fix from EDK2 commit c1d1910be6e04a8b1a73090cf2881fb698947a6e: OvmfPkg/QemuVideoDxe: add feature PCD to remap framebuffer W/C Some platforms (such as SBSA-QEMU on recent builds of the emulator) only tolerate misaligned accesses to normal memory, and raise alignment faults on such accesses to device memory, which is the default for PCIe MMIO BARs. When emulating a PCIe graphics controller, the framebuffer is typically exposed via a MMIO BAR, while the disposition of the region is closer to memory (no side effects on reads or writes, except for the changing picture on the screen; direct random access to any pixel in the image). In order to permit the use of such controllers on platforms that only tolerate these types of accesses for normal memory, it is necessary to remap the memory. Use the DXE services to set the desired capabilities and attributes. Hide this behavior under a feature PCD so only platforms that really need it can enable it. (OVMF on x86 has no need for this) With this fix enabled we can boot sbsa-ref with more than one cpu core. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py index 6bb82f2a03..e854ec6a1a 100644 --- a/tests/avocado/machine_aarch64_sbsaref.py +++ b/tests/avocado/machine_aarch64_sbsaref.py @@ -37,18 +37,18 @@ def fetch_firmware(self): Used components: - - Trusted Firmware 2.11.0 - - Tianocore EDK2 stable202405 - - Tianocore EDK2-platforms commit 4bbd0ed + - Trusted Firmware v2.11.0 + - Tianocore EDK2 4d4f569924 + - Tianocore EDK2-platforms 3f08401 """ # Secure BootRom (TF-A code) fs0_xz_url = ( "https://artifacts.codelinaro.org/artifactory/linaro-419-sbsa-ref/" - "20240528-140808/edk2/SBSA_FLASH0.fd.xz" + "20240619-148232/edk2/SBSA_FLASH0.fd.xz" ) - fs0_xz_hash = "fa6004900b67172914c908b78557fec4d36a5f784f4c3dd08f49adb75e1892a9" + fs0_xz_hash = "0c954842a590988f526984de22e21ae0ab9cb351a0c99a8a58e928f0c7359cf7" tar_xz_path = self.fetch_asset(fs0_xz_url, asset_hash=fs0_xz_hash, algorithm='sha256') archive.extract(tar_xz_path, self.workdir) @@ -57,9 +57,9 @@ def fetch_firmware(self): # Non-secure rom (UEFI and EFI variables) fs1_xz_url = ( "https://artifacts.codelinaro.org/artifactory/linaro-419-sbsa-ref/" - "20240528-140808/edk2/SBSA_FLASH1.fd.xz" + "20240619-148232/edk2/SBSA_FLASH1.fd.xz" ) - fs1_xz_hash = "5f3747d4000bc416d9641e33ff4ac60c3cc8cb74ca51b6e932e58531c62eb6f7" + fs1_xz_hash = "c6ec39374c4d79bb9e9cdeeb6db44732d90bb4a334cec92002b3f4b9cac4b5ee" tar_xz_path = self.fetch_asset(fs1_xz_url, asset_hash=fs1_xz_hash, algorithm='sha256') archive.extract(tar_xz_path, self.workdir) From patchwork Thu Jun 20 10:19:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Juszkiewicz X-Patchwork-Id: 805976 Delivered-To: patch@linaro.org Received: by 2002:a5d:508d:0:b0:362:4979:7f74 with SMTP id a13csp212830wrt; Thu, 20 Jun 2024 03:20:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXOzwk1x6a18UAZzDQHrH56+XNBlhcz1Ct9WrZwmGn/+v275BX4k1L1c0Nz00DiLV6hhaQ+OF4jBgRLFEgSpgFr X-Google-Smtp-Source: AGHT+IGof3xNKgDEKu8GDUmqStuk5eeGHkL810W/hk1Ivba+LZwRg/fM2fzalqyyPccf3QNfu7Cm X-Received: by 2002:a81:8b49:0:b0:632:7202:6ce0 with SMTP id 00721157ae682-63a8f9f960emr51481537b3.36.1718878845972; Thu, 20 Jun 2024 03:20:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718878845; cv=none; d=google.com; s=arc-20160816; b=K4wjj2+7Zi6KGyNiaX9CZPn4M1MRtEXfPsasb4XyxzRcXxgdGnHpgE4wHJVNN/V+ah 3mBpH0OVqxAgNEdbQur36kMEsvB/69mS0MFsHn+nkwG6UOcO1UgJ9+atlXutfuYdkawZ LIyGVxh6hSHQoxvFAyN18pTlDPDPlCBAsgomWMIhHb1ZrY/gJgXbdIYlH1BP/GyC8DCy 3cOshhJF1qkD282KXEdaimUQCMNLjvTFV4UDR0v6dF1GkN1rX8DTAfUOSGImyeGC9W/y +EEbOHEhBljwWGHdP+P8zB1tlleuuRqI/YMOBOPtvzy1bE3roTboI1Tfx1I7uzzXqIes ovYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from; bh=LszU6mXtFizGbzBE7k89pBY/0/cMuQcq0Eex9qhrSh8=; fh=V5vxXQ+IqdfQGwyC5zGLWXOc0z8EtcFzLjSj1F25uQo=; b=mbFdT2+znzpRj5KlHcIx/fYmRhDXG4dcmHQ0YmTY3OZ2FxW4vGUke68+PXrKqprsaN DtPh+QeB06tkqxba3iX8mOJt/1aDxK0bdyUt2Y4wRAysYu70McmZJpT6Gzw9StbLmwgC HsNCcByTSs8+HaBtVyL0aLcEhzKKupZyotco9kwM6W6Mdix7kYJ8PfYi1rS6gyMFq862 15sMZiEfQbUBlqQ7X6oskQIZZEZO53GHYIc5CQbgC4NofoGYALNJsXS54FwJzrz92lNv 2ZEFXqDxinOoesAUWQ9XrnGaJ+8dLOyNF7YtS7rwz+twEGexSph9G1sbpdTAOgmT2unN VeJQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6b2a70d80f9si164918816d6.179.2024.06.20.03.20.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jun 2024 03:20:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKEtj-00021i-Gy; Thu, 20 Jun 2024 06:20:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKEth-00020A-0E; Thu, 20 Jun 2024 06:20:05 -0400 Received: from muminek.juszkiewicz.com.pl ([213.251.184.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKEtf-0001Tm-60; Thu, 20 Jun 2024 06:20:04 -0400 Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id 9A85426071F; Thu, 20 Jun 2024 12:20:00 +0200 (CEST) X-Virus-Scanned: Debian amavis at juszkiewicz.com.pl Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavis, port 10024) with ESMTP id aRRNqxGY3i09; Thu, 20 Jun 2024 12:19:58 +0200 (CEST) Received: from applejack.lan (83.11.22.244.ipv4.supernova.orange.pl [83.11.22.244]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id AFCD12619B9; Thu, 20 Jun 2024 12:19:57 +0200 (CEST) From: Marcin Juszkiewicz Date: Thu, 20 Jun 2024 12:19:49 +0200 Subject: [PATCH v3 2/2] tests/avocado: use default amount of cores on sbsa-ref MIME-Version: 1.0 Message-Id: <20240620-b4-new-firmware-v3-2-29a3a2f1be1e@linaro.org> References: <20240620-b4-new-firmware-v3-0-29a3a2f1be1e@linaro.org> In-Reply-To: <20240620-b4-new-firmware-v3-0-29a3a2f1be1e@linaro.org> To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Leif Lindholm , Radoslaw Biernacki , Cleber Rosa , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal , Ard Biesheuvel , Rebecca Cran , Marcin Juszkiewicz X-Mailer: b4 0.13.0 Received-SPF: softfail client-ip=213.251.184.221; envelope-from=marcin.juszkiewicz@linaro.org; helo=muminek.juszkiewicz.com.pl X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The version of the sbsa-ref EDK2 firmware we used to use in this test had a bug where it might make an unaligned access to the framebuffer, which causes a guest crash on newer versions of QEMU where we enforce the architectural requirement that unaligned accesses to Device memory should take an exception. We happened to not notice this because our test was booting with "-smp 1" and through luck this didn't write the boot logo to the framebuffer at an unaligned address; but trying to boot the same firmware with two CPUs would result in a guest crash. Now we have updated the firmware we're using for the test, we can make the test use all the cores on the board, so we are testing the SMP boot path. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py index e854ec6a1a..e920bbf08c 100644 --- a/tests/avocado/machine_aarch64_sbsaref.py +++ b/tests/avocado/machine_aarch64_sbsaref.py @@ -75,8 +75,6 @@ def fetch_firmware(self): f"if=pflash,file={fs0_path},format=raw", "-drive", f"if=pflash,file={fs1_path},format=raw", - "-smp", - "1", "-machine", "sbsa-ref", )