From patchwork Fri Jun 28 17:20:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 808617 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 825471CD15 for ; Fri, 28 Jun 2024 17:06:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594366; cv=none; b=KOYw+aaWycWuMvjSh4ZCAmZnCec3XDreS7D+rLcftJIGLSVmDbc3EJRvnpFuRp5f95VbYBud470KvNRbB0UBA+NVGjE+axsXNuGOWK8/aplKFtH41DAnyuJHcBqvv0Wv6ZR7MntlOQYzl/YEw+otLFCwr1J2rPE9oWJX/RBpy5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594366; c=relaxed/simple; bh=5lq12J1JAYDsWtjhQDsizdKH3WTVHcLRzHZ73XrM1Xw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NzZS+LYC5UO+P9L/3iH7/AQm8Dh1V+rL7imF2nFQuJ2Dx76uGABbB8u9gJQjji+Ne6QgRKSzDi1M5pntYV1y6k/oiNsoGy3lzJtP1Vu3JEb1xx8URw2ct+bOgQCXLrlOWampMHYNx4sghlVsj4F7skdvGeqotRsrEbTo4/8qtZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FnueQUT5; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FnueQUT5" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7068ca5a807so52525b3a.3 for ; Fri, 28 Jun 2024 10:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719594365; x=1720199165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pBmm7sUowrfiMJzmU75UiXhzErerzQHyId7DyLqnbdo=; b=FnueQUT5yjRxsgsa//nX0Mi9MwQBJ3I4uG4696d/gagVA+CSGdTuLPXrm9s58jWEet e8VORzubHlTHeP5U1sHdT6pEhWRTXYT5MxIeEyXyGMRaz37d4ILR0QpZ31vkpjMTt4ye 0UYzble+rBgoj6MxQz2oxNZzSsudm/PNXh4lxNDkw5poJzMnR1o4JIDElweuIb1j8DUP tXXaOU0GoPaya8FQUsKfntuTYvWk2w/MAc4bAog1BtM57LlOEQj78JGL7GNQBEuFqaeO P4FwAUpefy7K48bHa8FrA+yNIf/rvGN208wZcodL8mv1RKh+kQalVE/qjz77ukqhorXq ZL3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594365; x=1720199165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pBmm7sUowrfiMJzmU75UiXhzErerzQHyId7DyLqnbdo=; b=kfM8fTVIwsekLwG1e6WJqXTjUGFXRV0sWzH4rkWmG2aJJ4lDF4f6qWSoAjTh7cadrk egKG3wZKtRg08Dbho5rgkb+VF5yXTZoEOUGPAJwy1hqrFP+UyWOLElPWA5GegcSRYCyo 9NHbWuq67fLN2bOZWdcWLpUJaJ2owpVoaNpqBhNgltajkJHr6E2jkPUhyH8pp49DWJzn MRn7PxrykXulbxEIy8i5oO36HR7zVyneVS/+eUtKAU7EYBuDxOU50fT65r1YdfjSoTDn tCpEGfh4tPKIYmoIjFwp6tTxIXIeHRe0i/xZXoMXOvLqunrHMqJtD5zjQlicP5EFr+CT c5cQ== X-Gm-Message-State: AOJu0Yy3FNqfwVBueA3+/X9e+8CQHnPCFTIuIWxFJ1lxKRmtmESaBNVK VwZgsuz3wqeg91Cd3BzrZVrxjpmo3ETPyGv4eOPTljTBtORlhuOA2gE45g== X-Google-Smtp-Source: AGHT+IEpLd3T9Mm6jrVpuhmvlQ+C4oSIgucGtIgldoaVps2lkiEJVmWFfvP3rxzUsxlT8P1AtrvmVQ== X-Received: by 2002:a05:6a20:3c94:b0:1bd:289f:2ccb with SMTP id adf61e73a8af0-1bd289f63ecmr11015012637.6.1719594364485; Fri, 28 Jun 2024 10:06:04 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6afb8ef1sm1524623a12.40.2024.06.28.10.06.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2024 10:06:04 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 1/8] lpfc: Cancel ELS WQE instead of issuing abort when SLI port is inactive Date: Fri, 28 Jun 2024 10:20:04 -0700 Message-Id: <20240628172011.25921-2-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240628172011.25921-1-justintee8345@gmail.com> References: <20240628172011.25921-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 During SLI port errata events, there should be no expectation that submitted outstanding WQEs will return back CQEs. In these situations, the driver should not rely on receiving CQEs from the SLI port to signal WQE resource clean up. Put an sli_flag LPFC_SLI_ACTIVE check in lpfc_els_flush_cmd when walking the txcmplq. The sli_flag check helps determine whether to issue an abort or driver based cancel on outstanding WQEs. If !LPFC_SLI_ACTIVE, then there's no point to issue anything to the SLI port. Instead, let the driver based cancel logic clean up the submitted WQE resources. Also, enhance some abort log messages that help with future debugging. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_els.c | 2 +- drivers/scsi/lpfc/lpfc_sli.c | 24 +++++++++++------------- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index c32bc773ab29..b27ebb574bfb 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -9665,7 +9665,7 @@ lpfc_els_flush_cmd(struct lpfc_vport *vport) list_for_each_entry_safe(piocb, tmp_iocb, &abort_list, dlist) { spin_lock_irqsave(&phba->hbalock, iflags); list_del_init(&piocb->dlist); - if (mbx_tmo_err) + if (mbx_tmo_err || !(phba->sli.sli_flag & LPFC_SLI_ACTIVE)) list_move_tail(&piocb->list, &cancel_list); else lpfc_sli_issue_abort_iotag(phba, pring, piocb, NULL); diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index f475e7ece41a..8bfac9143314 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -12301,18 +12301,16 @@ lpfc_sli_abort_els_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, goto release_iocb; } } - - lpfc_printf_log(phba, KERN_WARNING, LOG_ELS | LOG_SLI, - "0327 Cannot abort els iocb x%px " - "with io cmd xri %x abort tag : x%x, " - "abort status %x abort code %x\n", - cmdiocb, get_job_abtsiotag(phba, cmdiocb), - (phba->sli_rev == LPFC_SLI_REV4) ? - get_wqe_reqtag(cmdiocb) : - cmdiocb->iocb.un.acxri.abortContextTag, - ulp_status, ulp_word4); - } + + lpfc_printf_log(phba, KERN_INFO, LOG_ELS | LOG_SLI, + "0327 Abort els iocb complete x%px with io cmd xri %x " + "abort tag x%x abort status %x abort code %x\n", + cmdiocb, get_job_abtsiotag(phba, cmdiocb), + (phba->sli_rev == LPFC_SLI_REV4) ? + get_wqe_reqtag(cmdiocb) : + cmdiocb->iocb.ulpIoTag, + ulp_status, ulp_word4); release_iocb: lpfc_sli_release_iocbq(phba, cmdiocb); return; @@ -12509,10 +12507,10 @@ lpfc_sli_issue_abort_iotag(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, lpfc_printf_vlog(vport, KERN_INFO, LOG_SLI, "0339 Abort IO XRI x%x, Original iotag x%x, " "abort tag x%x Cmdjob : x%px Abortjob : x%px " - "retval x%x : IA %d\n", + "retval x%x : IA %d cmd_cmpl %ps\n", ulp_context, (phba->sli_rev == LPFC_SLI_REV4) ? cmdiocb->iotag : iotag, iotag, cmdiocb, abtsiocbp, - retval, ia); + retval, ia, abtsiocbp->cmd_cmpl); if (retval) { cmdiocb->cmd_flag &= ~LPFC_DRIVER_ABORTED; __lpfc_sli_release_iocbq(phba, abtsiocbp); From patchwork Fri Jun 28 17:20:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 808473 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E199A1CD15; Fri, 28 Jun 2024 17:06:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594374; cv=none; b=bkBgLuituBg3Wu3GXgs26a8w+BPhTdnWgzahmfZlt6XFKhVGvQtsZsUbmXIWacZeRKD4Aqn7IaQcYxp/pwI9B1zoBPNmiEGn6RDk4zFGw03bye3nEEJ6svcOPOga0FhYyc/Lil8+JRpfwTlK+5GUrtEkZur5w9VPdNkhe7LipUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594374; c=relaxed/simple; bh=Cljtgd/Isf+l3B0F4sdoVRtTN7f2sCDFmMMfEfMfYJE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A+/fJqsGXUqYjeKF2UPZ01uwqfjUKxNfYe1oRg65Jaa/0JBoc4YZuCFBO+mBIiRyjY/OfsVukkAP1oRLJqe0TL2c6Hg5ArZoQIHV0QiVvdac3HBHQAWtYJPEKj9YdPub8O+nIOh196P9p0yfNtdA33BO5vKFpsa5jp8tkt4SIY0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RcH/SngH; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RcH/SngH" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-6c386a3ac43so131282a12.0; Fri, 28 Jun 2024 10:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719594372; x=1720199172; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1gIvSZMXVhoGcZvS7xN6Z8l1Ej0EBODeUmgZswcD1Zo=; b=RcH/SngHr4bwCNz9ZLOJPgQ05hc5DXqBHSi/BxLur4QqOlYn1QOwcFymRmJOg+xJ9u o3bqKzs8Q2dQetfO4svKN65cQ56B/+2WIjma+Gm7PZJTI6nXy0w2sHM+DWozFT2NJtR3 S5VM00m522xxwfoU2Agn8+QcuQlwsRyvBZmKcGpnxSTOar3hnDUojEc4khZuHhzcNHhT 7fgWB/J0b7Xs3dSxgeSbM1CUVsICvG2llJbHDydJXxyjwLxRG6qFSBZsDdM6ahSeASE3 Vif4wp4li7SzrOWnmV8uVcLSnT0i6dUOIenGO0gCQ3dxwJqHdY9deQxSjKaKuU7p3CTL cgxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594372; x=1720199172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1gIvSZMXVhoGcZvS7xN6Z8l1Ej0EBODeUmgZswcD1Zo=; b=l8lAcQxzVRS/+W239MUNEGnp7wOcPUgXxcHO8vPoWRQ9NVjfJZ4sNkj6GUKhzJhp84 Wfwza+vOVxsrTZU7Q9WvIUNsCqAsbPHSJVPFvpa/y4E+8N628HiFggJ2P1QR1wThCnAI odjRL7620562tWyjKietkICBz440jt4Li5BA9uxG3dwMDV1hawEbw+6z5mw3QmGv4JBu MPoWiBkR9qvzv4CvWko/Yis6GYYerm81R4D28/DqqfhnQ6RUCP0VuIPdd91oJK6dDA/a nuQxI2PS6GA4vGVlTZtH/rgkjykEDNkx/c95LEQlmmEsQFk7MLg626dC/d1fz1KgqxMW ePBA== X-Forwarded-Encrypted: i=1; AJvYcCVpnciFhJ72QVAzxhzx6h1BKzP/WGCDSdrH8lLazyBneJTlksRm2Cc4JtAOaLAtAe72vvCrFw0shnG5+6QdJGKjVRZfGKRB X-Gm-Message-State: AOJu0YzGXRcXPZvoHL+QjVT8N59tNCXGrqgFx0JGnZUK3H7g5/E69H2L JRGqpTD2GRYxiXUKoFjlnU5dgS5yugK1B6Lzj7b/VgJWs8LuQPkMLgB6wA== X-Google-Smtp-Source: AGHT+IGHw5BYsgW0Inrz0ttKbYVGPKT9eE46X1A1MfpGT80g/5Fhiz8+hURvFuC0dSof0ndxOA9HiQ== X-Received: by 2002:a05:6a21:33aa:b0:1be:c3fc:1ccf with SMTP id adf61e73a8af0-1bec3fc1f10mr8465436637.2.1719594371967; Fri, 28 Jun 2024 10:06:11 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6afb8ef1sm1524623a12.40.2024.06.28.10.06.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2024 10:06:11 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee , stable@vger.kernel.org Subject: [PATCH 2/8] lpfc: Allow DEVICE_RECOVERY mode after RSCN receipt if in PRLI_ISSUE state Date: Fri, 28 Jun 2024 10:20:05 -0700 Message-Id: <20240628172011.25921-3-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240628172011.25921-1-justintee8345@gmail.com> References: <20240628172011.25921-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Certain vendor specific targets initially register with the fabric as an initiator function first and then re-register as a target function afterwards. The timing of the target function re-registration can cause a race condition such that the driver is stuck assuming the remote port as an initiator function and never discovers the target's hosted LUNs. Expand the nlp_state qualifier to also include NLP_STE_PRLI_ISSUE because the state means that PRLI was issued but we have not quite reached MAPPED_NODE state yet. If we received an RSCN in the PRLI_ISSUE state, then we should restart discovery again by going into DEVICE_RECOVERY. Fixes: dded1dc31aa4 ("scsi: lpfc: Modify when a node should be put in device recovery mode during RSCN") Cc: # v6.6+ Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 153770bdc56a..13b08c85440f 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -5725,7 +5725,7 @@ lpfc_setup_disc_node(struct lpfc_vport *vport, uint32_t did) return ndlp; if (ndlp->nlp_state > NLP_STE_UNUSED_NODE && - ndlp->nlp_state < NLP_STE_PRLI_ISSUE) { + ndlp->nlp_state <= NLP_STE_PRLI_ISSUE) { lpfc_disc_state_machine(vport, ndlp, NULL, NLP_EVT_DEVICE_RECOVERY); } From patchwork Fri Jun 28 17:20:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 808616 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79C4C1C8FAC for ; Fri, 28 Jun 2024 17:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594377; cv=none; b=P0OmMd5W7bxP2Ln6Poc5rKSTetP+QEGLPsK6v+bTN3GcxVdVZF401f64bj1I5QErfTvL7z6ELEU74QQVMIfbDwHajk2ysP7iBoRYwo+Q4vyN21c1SS92aMT7bc1hSU95L/Jp7b5T6APLzFtNIkGXBrV69FLn7BQoF4sQqkdsmt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594377; c=relaxed/simple; bh=HETjeWSIE+mbVlhjmEFrZI9vC0g7DbF0FRTDqH9Y0D4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GG1eCFqi6foxy89t49Oww9Hy/XvViMcTJSft1tP8jUAd6V+fS8VsDS8Nd3BXPww9urfPSOVBCY0moqofpb7WaVMb58YJA60rea136ceX42z02SvA1AaoEbIl+ezilsAViGuc5Sw6lbB1xXM70bWpaBUTedFQj1orBHy2FT4FNKQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MftaYAGM; arc=none smtp.client-ip=209.85.166.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MftaYAGM" Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-37a80cb5c94so533535ab.1 for ; Fri, 28 Jun 2024 10:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719594375; x=1720199175; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xGYcdO7kisSubyeq3w4oez0y3nBto0BXg7sI05A14qE=; b=MftaYAGMS7Jxo+e04VJuqNZlINTueN/J/CluI5DxVntzICfCCLFXntI7LXQif67jpx 9nICvlUWDOKkX62BY3g4mDkyU1JATuCDt8DV988e6nvolwogUPax5qnyA9cFGBkmclfb KJP0jkfDglcPwaGtuuDTuDoKkYpgVO+bWRMuqJhcCS/BxeI3aO6U7Wxo9qzuAH8J6wFL e3Uuc3wEIdY3bMs1BBTfhIDbndhHzukr+6jy1xD5nbKpZoJ7SS4bHDAOKKAm8smYpxYb GnpofpQZTFGdfbn/0QxPM2PO0HJvkDE0d/8/2YHZ/+XPFqZrHyyhGqx7RNfUkZrMZy9v pKcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594375; x=1720199175; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xGYcdO7kisSubyeq3w4oez0y3nBto0BXg7sI05A14qE=; b=PoMHBgJZxmugSGJqc9gP3aQ1FpYCDhaDZAz1Heij2c6FQ4/cFBYqAUzrKOZVAbAk0/ Ay48pgHwvxwb4Uz+ADjCTuRrIg5CoYe75oDQZpGhcXhP0YwcSRyzUk9zHn2/noFjS436 n/6u1EDePUoxWwgVTUTDGAjFkcind1RqZ1rhpIfsyyYWN6hY8nB97bhZoLYJI4YSWwM/ dSLgiGU2v6HgTl6zJ0WPBUpN9++ZPhDaVMJYI7G5E1sDMmTsG4Tgjc2/GotIuJGiOwEw qzaAP1SbVPgD9XM+l1dZVF3T9/Q6HbXu4XGv2rQzUmywjHGhlsKmkU9M0dafe9xBewmM NKWQ== X-Gm-Message-State: AOJu0Yxhrc/xIhb58/1imvhJiQLoJJSHlDR/kY55Mr0yOOikNl4BQ5gf p0/L/pFCpBzOtfH1SO34+XfXstSN/AnFRNctbZDZB522l96o5/m0r8bC0g== X-Google-Smtp-Source: AGHT+IGnVdbyoSbRwrqyAuWyZObdZtSTFceACiHsSzsqfAxHlMONF+Cm0CWHs7hltoQUg2GpWaFGbw== X-Received: by 2002:a05:6e02:4b2:b0:379:2b4d:d5de with SMTP id e9e14a558f8ab-3792b4dd9cdmr68060315ab.2.1719594375431; Fri, 28 Jun 2024 10:06:15 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6afb8ef1sm1524623a12.40.2024.06.28.10.06.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2024 10:06:15 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 3/8] lpfc: Relax PRLI issue conditions after GID_FT response Date: Fri, 28 Jun 2024 10:20:06 -0700 Message-Id: <20240628172011.25921-4-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240628172011.25921-1-justintee8345@gmail.com> References: <20240628172011.25921-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If previously in REG_LOGIN_ISSUE state, then remove the requirement that PLOGI must have been received from the remote port before issuing a PRLI. After GID_FT completes, it does not matter whether the driver itself sent a PLOGI or received one. The fact that we're in REG_LOGIN_ISSUE state simply means that the next state should be issuing the PRLI to continue discovery of the remote port. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_ct.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c index 376d0f958b72..2dedd1493e5b 100644 --- a/drivers/scsi/lpfc/lpfc_ct.c +++ b/drivers/scsi/lpfc/lpfc_ct.c @@ -1553,22 +1553,14 @@ lpfc_cmpl_ct_cmd_gft_id(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, if (ndlp->nlp_state == NLP_STE_REG_LOGIN_ISSUE && ndlp->nlp_fc4_type) { ndlp->nlp_prev_state = NLP_STE_REG_LOGIN_ISSUE; - /* This is a fabric topology so if discovery - * started with an unsolicited PLOGI, don't - * send a PRLI. Targets don't issue PLOGI or - * PRLI when acting as a target. Likely this is - * an initiator function. - */ - if (!(ndlp->nlp_flag & NLP_RCV_PLOGI)) { - lpfc_nlp_set_state(vport, ndlp, - NLP_STE_PRLI_ISSUE); - lpfc_issue_els_prli(vport, ndlp, 0); - } + lpfc_nlp_set_state(vport, ndlp, + NLP_STE_PRLI_ISSUE); + lpfc_issue_els_prli(vport, ndlp, 0); } else if (!ndlp->nlp_fc4_type) { /* If fc4 type is still unknown, then LOGO */ lpfc_printf_vlog(vport, KERN_INFO, LOG_DISCOVERY | LOG_NODE, - "6443 Sending LOGO ndlp x%px," + "6443 Sending LOGO ndlp x%px, " "DID x%06x with fc4_type: " "x%08x, state: %d\n", ndlp, did, ndlp->nlp_fc4_type, From patchwork Fri Jun 28 17:20:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 808472 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A2571C8FAC for ; Fri, 28 Jun 2024 17:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594380; cv=none; b=SX9d7kn7lgjbS5l0ngImv9IvT/4aHU93tXndB20d8++FiVR6DyjdE8f33JMEBNI4HhQZp28E1kY3LP02QVYP80MJcGKMoBNEbgGbaWIiN0milYo0W3u3Wj6otyc9WIA9QEWHTy1r0BVTyGSRl3qXzump9T4WsvvRTTBbVY2TFYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594380; c=relaxed/simple; bh=7ykx966S4jtDZk/c2VAM0ZDPTRt9EE2FmtqmAWAnXV8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tVHEIIHuVaklWODWl0vrkv27QxBp2bBKMZ0Ug5Zfk4cXOUyWnKPpUKzWAtIjMMxxc+QsdaKKfMr/1N1fmhiDzUkcRmCHsaOTpOPp/tDaWq1CTU5FZ4yaA9tZ6uyfddzd7leGXiPecbDQuTrAaKA+bANzswia5Ejm0iwIxo0XZ/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KpvVanFT; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KpvVanFT" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7065f3de571so85957b3a.0 for ; Fri, 28 Jun 2024 10:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719594379; x=1720199179; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eNPSik58fOB62TXAs3PojLIEX6s0Cwz2LrR2CaqfJY0=; b=KpvVanFTFgz+G1EbXxnvcU5NJRszuNIS2XEdhMP8GJOUj4U1gRGmtApW6scIZpvIaa 5vjez33YgmzVbk+IIukLsQdVDzlzbQHYGvCiIbLfEab/okOytvGW5LNC8znTcUu0842j Vbp95uB2aEO2zJ2DhGw9VzvhW1xNEm9ePS1XYMT5sknlu2mR96t9Pu9xrYo0qzO8Wsn9 X9cqB/vPlWkm2wTRqJjU3eft62DJ8vuwd1/eUxC87slmkuOJB2FP4u0m9J0TMi041YlT qj+rryGUsoEqXhwSGNq9Ja5aHz8VTltbivoSgO8FU16ChotUG4ZwZqdmagqPxWnx+mUS DUrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594379; x=1720199179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eNPSik58fOB62TXAs3PojLIEX6s0Cwz2LrR2CaqfJY0=; b=AwlYrNzs3hZiB2EjIAvkFhkw1D57JihYLxNLu2HzSZxK7F74vXi9NC+4bTBPcAMTS9 HzoKv0a6Pgn6yv6VkETCRt7Nzn6h7PR0qit4CHRL8vzpioAs42dEgLCoWmOPckU6jFzQ roovNmmOzXqo+fNZ7Mh7ZqcGIO06zI67FW95ds6+K4nN2Ok3sn9Xz5aD/pHe15sCpCtl rNhKMjEbUn6vvVPzEsTnQZ99+FgtOl6EzJhGXbZXGXOo8tiIek/ooRlOxnPzCsXqRSgo snpTyAT8hURI/z1WBC7UIRQydcW3JcpFs3qnPQcAo5Nxjt8y7wH8dblz1d6watmHBQ8b SaQA== X-Gm-Message-State: AOJu0YwRDrRtx608L8Y3ym1YHkhF1k7tdIVcUBN+ue3dVE09jKu4A6PU EnjED5Skw1Un8m97xItha9DO9/02ZcIYx3Oh5M6uUSZKXmbbYYRF4zOZYg== X-Google-Smtp-Source: AGHT+IH44dsOA2FU0iRdIJE0V8pJKhqibcYZ7utiKjT+t+kswjJny1LyKOURwydGcgTb6+OJueBXmA== X-Received: by 2002:a05:6a00:3119:b0:705:c0da:bdc1 with SMTP id d2e1a72fcca58-70667e29347mr18823247b3a.2.1719594378749; Fri, 28 Jun 2024 10:06:18 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6afb8ef1sm1524623a12.40.2024.06.28.10.06.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2024 10:06:18 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 4/8] lpfc: Fix handling of fully recovered fabric node in dev_loss callbk Date: Fri, 28 Jun 2024 10:20:07 -0700 Message-Id: <20240628172011.25921-5-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240628172011.25921-1-justintee8345@gmail.com> References: <20240628172011.25921-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In rare cases when a fabric node is recovered after a link bounce and before dev_loss_tmo callbk is reached, the driver may leave the fabric node in an inconsistent state with the NLP_IN_DEV_LOSS flag perpetually set. In lpfc_dev_loss_tmo_callbk, a check is added for a recovered fabric node. If the node is recovered, then don't queue the lpfc_dev_loss_tmo_handler work. In lpfc_dev_loss_tmo_handler, the path taken for the recovered fabric nodes is updated to clear the NLP_IN_DEV_LOSS flag. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_hbadisc.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 13b08c85440f..6943f6c6395c 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -214,6 +214,11 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport) if (ndlp->nlp_state == NLP_STE_MAPPED_NODE) return; + /* check for recovered fabric node */ + if (ndlp->nlp_state == NLP_STE_UNMAPPED_NODE && + ndlp->nlp_DID == Fabric_DID) + return; + if (rport->port_name != wwn_to_u64(ndlp->nlp_portname.u.wwn)) lpfc_printf_vlog(vport, KERN_ERR, LOG_TRACE_EVENT, "6789 rport name %llx != node port name %llx", @@ -546,6 +551,9 @@ lpfc_dev_loss_tmo_handler(struct lpfc_nodelist *ndlp) ndlp->nlp_DID, kref_read(&ndlp->kref), ndlp, ndlp->nlp_flag, vport->port_state); + spin_lock_irqsave(&ndlp->lock, iflags); + ndlp->nlp_flag &= ~NLP_IN_DEV_LOSS; + spin_unlock_irqrestore(&ndlp->lock, iflags); return fcf_inuse; } From patchwork Fri Jun 28 17:20:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 808615 Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB1071C8FAC for ; Fri, 28 Jun 2024 17:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594384; cv=none; b=CUWb3YTIS+gK/6jAtdKwtc2fV1SPH1gfm+aSDjjudXgxk4U7xegy15jHEjrL6uG5D6xynawBHpckw2pGMTud9pQitt2hXmuTYRa2lYN2Z9dp5x0s6Qw5e84KbNEiwXH63EkGzxLdyaTpdYcXjsjUh86O/YBVmbbgQW3Qe8PJtww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594384; c=relaxed/simple; bh=3DxkUpuv/j+Sfk3qXa7C9XWSyljvkIE1MhjgYWto29A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tcSXOskJ5CO2b6MqbGq3MEyc+jLWs+hQZB5Xla2VnbF62DwrdrMBDiWu1MotXmvB/NYBU5vUytQt/8WhZ211xcGAtVaOykPjTPNFIGqfpQb1hJaJ7dRwzpQrodu0Us6SQDcvhoD8lmZQHmFgK9ZVmLtGuDW3v/ZSox8KsBcWt04= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ib0a8Rnr; arc=none smtp.client-ip=209.85.166.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ib0a8Rnr" Received: by mail-il1-f180.google.com with SMTP id e9e14a558f8ab-3762c172d94so488025ab.0 for ; Fri, 28 Jun 2024 10:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719594382; x=1720199182; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sKRsAY0jHyrEEfswJbETTj8mOq9QvVjI6YaRHp8y3XU=; b=Ib0a8Rnrw7DG/j+jtVc2f/5iFLXmzzObqlThUYnH3UugwnBa6OdpyCAkfFJb6UFnb/ mW5TYOD8uOx+d8n8sQJ7d2kVZ6CqkboVa98JIraK3dHl28VvEAkFyTn0LXrFlvOpyMb3 cqgT3KFsWsfZeizMmBD7l3Uftz10BhnakFnDQTSq+ooL498Rvd7pxoLAt4Xqor/TTByA C9buwZd0xp0WEiTUgYQGgcMlu4wIF/Zd/Hd8KWI4mCQ0wGU/Nut7uMHKe8mAJkkHaeni BzKIiziA4kTQ9ykDKGgSLR14Kk60odggULFWu2iH3Hvq944Ptwl4liJvMSZQG1UHD5ko hj9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594382; x=1720199182; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sKRsAY0jHyrEEfswJbETTj8mOq9QvVjI6YaRHp8y3XU=; b=svms1fJwJN5PTosLe5ZIRKV7DFWlIJWClVomKNV55BX0GIrbUN1LWQ75fQkhU7ujtM FxXPm3esfP9YQqw8tpfSeqVOJdiOFKfPBB4r8aKEv+gf2sIV+OF5k5DGFbqo2EhSxxi9 Qcw0/m3J1z5mhEMQb1K4farPnjaXy8LIWBbXwqTYFkhRgiQiC2aGU024etM02c5+hZwO ef44HmCHqL+5TPRqy0XyANmZrv+wN1Q+JWVIYZuI4lAQLgPRtmZpwuheNzJjGH1bvmWQ QeFvWW+yKS8Dmr9x9jZ5I2MBjPWWF8TFy+Z3wncl+wZT0I03KfaTbFRMxJTAmh3VEvdZ wh4A== X-Gm-Message-State: AOJu0YzXS62RW1/stb/0lBTlZyphXT2z9ovuyiSWii1cCHa4FLMgbBZ2 co/Ga1/NEkR4wDIiwBL0fxaZRIX4XhY+0zrwbc5gcHTXH87VcOWafxD6Mw== X-Google-Smtp-Source: AGHT+IHBErmEPl6Yx0Zwkg7OSU0SK3Yl0j8Oylau1Zprj7GBu3I7z47htPch3xmt2/NSgG4/kSikGA== X-Received: by 2002:a92:d28c:0:b0:376:2361:d2ac with SMTP id e9e14a558f8ab-37638b5136dmr149638975ab.2.1719594381782; Fri, 28 Jun 2024 10:06:21 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6afb8ef1sm1524623a12.40.2024.06.28.10.06.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2024 10:06:21 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 5/8] lpfc: Handle mailbox timeouts in lpfc_get_sfp_info Date: Fri, 28 Jun 2024 10:20:08 -0700 Message-Id: <20240628172011.25921-6-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240628172011.25921-1-justintee8345@gmail.com> References: <20240628172011.25921-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The MBX_TIMEOUT return code is not handled in lpfc_get_sfp_info and the routine unconditionally frees submitted mailbox commands regardless of return status. The issue is that for MBX_TIMEOUT cases, when firmware returns SFP information at a later time, that same mailbox memory region references previously freed memory in its cmpl routine. Fix by adding checks for the MBX_TIMEOUT return code. During mailbox resource cleanup, check the mbox flag to make sure that the wait did not timeout. If the MBOX_WAKE flag is not set, then do not free the resources because it will be freed when firmware completes the mailbox at a later time in its cmpl routine. Also, increase the timeout from 30 to 60 seconds to accommodate boot scripts requiring longer timeouts. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_els.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index b27ebb574bfb..929cbfc95163 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -7302,13 +7302,13 @@ int lpfc_get_sfp_info_wait(struct lpfc_hba *phba, mbox->u.mqe.un.mem_dump_type3.addr_hi = putPaddrHigh(mp->phys); } mbox->vport = phba->pport; - - rc = lpfc_sli_issue_mbox_wait(phba, mbox, 30); + rc = lpfc_sli_issue_mbox_wait(phba, mbox, LPFC_MBOX_SLI4_CONFIG_TMO); if (rc == MBX_NOT_FINISHED) { rc = 1; goto error; } - + if (rc == MBX_TIMEOUT) + goto error; if (phba->sli_rev == LPFC_SLI_REV4) mp = mbox->ctx_buf; else @@ -7361,7 +7361,10 @@ int lpfc_get_sfp_info_wait(struct lpfc_hba *phba, mbox->u.mqe.un.mem_dump_type3.addr_hi = putPaddrHigh(mp->phys); } - rc = lpfc_sli_issue_mbox_wait(phba, mbox, 30); + rc = lpfc_sli_issue_mbox_wait(phba, mbox, LPFC_MBOX_SLI4_CONFIG_TMO); + + if (rc == MBX_TIMEOUT) + goto error; if (bf_get(lpfc_mqe_status, &mbox->u.mqe)) { rc = 1; goto error; @@ -7372,8 +7375,10 @@ int lpfc_get_sfp_info_wait(struct lpfc_hba *phba, DMP_SFF_PAGE_A2_SIZE); error: - mbox->ctx_buf = mpsave; - lpfc_mbox_rsrc_cleanup(phba, mbox, MBOX_THD_UNLOCKED); + if (mbox->mbox_flag & LPFC_MBX_WAKE) { + mbox->ctx_buf = mpsave; + lpfc_mbox_rsrc_cleanup(phba, mbox, MBOX_THD_UNLOCKED); + } return rc; From patchwork Fri Jun 28 17:20:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 808471 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BC6A1C8FAC for ; Fri, 28 Jun 2024 17:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594386; cv=none; b=PLzeMCeLKP6/YmZxQM+ervpPr6s796f9tiS8wj5h8KF+ovCw3CYyI6FfXsqOtlJQf8NIHiG10x8taTfVByuvto1jmuQygjvoEzDr5pb1xg/46XvzC+dt1As94HwwdOczIye1nnU4yzJqbv0c8GswAWX9tlv50QxT+EXC+iYGi08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594386; c=relaxed/simple; bh=YhFQ02PguntijKAjYBZDMeujU1WTda6Syu4I7hEtWgk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=U/tVS38FmQnQs/tstGe0y/mY6e2UHACpRL8NXqS5SqarrJMLHIHWq8kQzeb+cUdDx3ATYw2G+uAtzKXZYKxNaeizikmB4Ri5yNGpLBszukNqprvXvkw17l30tLpGvj6dwgFmT5kJLCHkVnxwia3ReCEYDFkQPEXfCKH/epKovp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F1BvtcZJ; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F1BvtcZJ" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7068ca5a807so52570b3a.3 for ; Fri, 28 Jun 2024 10:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719594384; x=1720199184; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kDBaPNFPEycMhOT2/UI1UtFZIA8Ynj6ILMi+Hz/QMsw=; b=F1BvtcZJ/FEemHaNc9VImub48d6IFo/KiJPi++n40ctrA9mINO67x7ko1dp/wVVD+k oQnp9nViChr1+Fih2TpPKC76aO1XSBd2BHKHXT0Ut+U6hwO75XPKWVzkZH7sKp/ouAh7 Ds8NsvHJD/Z0XKGrMgsdXsxLQjGmE0Lf6aefu+0DQUlApX3+PV3uyiScFAvgInTe3RiI fz/EyeIsu+65y2W9dwn7NppcNxx3Az79TaRuj4V+ryFdUg3j9PB3VaqxtKfSSAkr/Zf2 Gow1CGANX8PLJOSlWKJLtTR7KHsTOoUOsO+u4EwEfgXnSDmpB5uHkvET3x24MtbwQb2u 2yew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594384; x=1720199184; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kDBaPNFPEycMhOT2/UI1UtFZIA8Ynj6ILMi+Hz/QMsw=; b=HUvynf/Z56tTMc69yV8VP16SM+Y/7/Hi85VHgw21ytpVFgyrLyG16MLpgC4dfSWhC5 gN6MHvrjyEqROQyONku1x7tBRnIfmttcPH8OeerLHSDFsiEqfTOMnmsbqlXIUST8An9t Y+BJ/BKHZNs7hsAfn4u2uK3+WC6hJqkIoBd2Jyr//ekc/+iVmEN0gBgxdu34R2DHOvcf P+00d+xiYEQVmnMQ0pAdPU9kFDTDDhrAICWaHcrjtp+LqpTKDZAvSP0swhuF/qUSQO5w tJKNmUum/DeQ5M1qnaY2pzt5FxgXSxlAMMOYMlbyPofjQtXp7y3XvJlbKNsWcyZKlBYb OvfA== X-Gm-Message-State: AOJu0YxaWWxkbytd6BvNub4tymqTesPoqJZSiYx+Qqdbm4Q7y/TNNnwc ghKpchKidDWyv0w0mP5qUFucmapBXW+pOnMhC1JPz7eaefhnOsYlKLJEHg== X-Google-Smtp-Source: AGHT+IE6PjhhzyeT0tyvzvnBPaytRByFdDyQcEQM5UfgV4ak1w0ywb3X4Mq4yEtBNYx1bgmhocdLLQ== X-Received: by 2002:a05:6a00:84c6:b0:706:61bb:7094 with SMTP id d2e1a72fcca58-70667fa6defmr19175887b3a.2.1719594383574; Fri, 28 Jun 2024 10:06:23 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6afb8ef1sm1524623a12.40.2024.06.28.10.06.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2024 10:06:23 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 6/8] lpfc: Fix incorrect request len mbox field when setting trunking via sysfs Date: Fri, 28 Jun 2024 10:20:09 -0700 Message-Id: <20240628172011.25921-7-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240628172011.25921-1-justintee8345@gmail.com> References: <20240628172011.25921-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 When setting trunk modes through sysfs, the SLI_CONFIG mailbox command's command payload length is incorrectly hardcoded to 12 bytes. SLI_CONFIG's payload length field should be specified large enough to encompass both the submailbox command header and the submailbox request itself. Thus, replace the hardcoded 12 bytes with a clearer calculation by way of sizeof(struct lpfc_mbx_set_trunk_mode) - sizeof(struct lpfc_sli4_cfg_mhdr). Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_attr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index a46c73e8d7c4..62e517719e8f 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -1831,6 +1831,7 @@ static int lpfc_set_trunking(struct lpfc_hba *phba, char *buff_out) { LPFC_MBOXQ_t *mbox = NULL; + u32 payload_len; unsigned long val = 0; char *pval = NULL; int rc = 0; @@ -1869,9 +1870,11 @@ lpfc_set_trunking(struct lpfc_hba *phba, char *buff_out) if (!mbox) return -ENOMEM; + payload_len = sizeof(struct lpfc_mbx_set_trunk_mode) - + sizeof(struct lpfc_sli4_cfg_mhdr); lpfc_sli4_config(phba, mbox, LPFC_MBOX_SUBSYSTEM_FCOE, LPFC_MBOX_OPCODE_FCOE_FC_SET_TRUNK_MODE, - 12, LPFC_SLI4_MBX_EMBED); + payload_len, LPFC_SLI4_MBX_EMBED); bf_set(lpfc_mbx_set_trunk_mode, &mbox->u.mqe.un.set_trunk_mode, From patchwork Fri Jun 28 17:20:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 808614 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 428EC1CB322 for ; Fri, 28 Jun 2024 17:06:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594387; cv=none; b=cu9mbKmuK8OociB/YujRegpBwcONoOq9ww4+s8SSFmc0VJ0gJijh8v+x+fG7XrJHWKn2iO9hihK78pfFNW9JLYn4bR1LSycHqBzhmzw3NyWa6g1N7fNLGRzVzfpMQz9d2HOdlox9WJ580ljOR6F5/8XJs9cth3qBZ5mCXIRB7EE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594387; c=relaxed/simple; bh=9So4BZMf5XjyQ1XyzPVmP6biJ5yXu5JY4/YOZnbmTio=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZJ1D4cGexPKvfdWknyWvmv9wpA4wxyjYam4G01XyvUNEjFSYH3WLDYOQUwYHt+6AGU2Wgeb1kUIronlnCakd+ZWFUHtJnAD/sspu7DLcGCDvfrZzQnpxENN6PN9LYcN0yf1lc6loDem53zvL/30M0sFkScs5GEsVkjTFpSuK6CA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZPeaq1ac; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZPeaq1ac" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-70677fe5d87so41973b3a.1 for ; Fri, 28 Jun 2024 10:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719594385; x=1720199185; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dKgOvlTc0UfjL+qcFfB925sH1IjQwSnOhFoOsm7UVZ8=; b=ZPeaq1ac90pOPR83DVHhWTylXjxQaaiWhQn958TN8IQ58e6Dz72tMUio+/fi2q+Vhi oFXI5lr2BIlhriLrnvuGew/YSxzoeERUrFzbNqsCycn1DLv0EtQW6F/kNtlFpmxGB0eu /dk7lfUHZFPXWc6Q7ITE99HGwIwngR13NwcAP04VRMT3C08ooXXaTD4olWObPPSCff/J L+bgji65Q9L91rtCp/Z0FigJkD45qQioDsYcHsWJRfV6NCUNO0zMeP0sre9EAU4riA0O JqFxhmmLB2rF4tFaQMIxLLTX9GEumpSU4wcx3eur7p6SM/zwt8tzIpMZi6IpkxT/5H0M iZIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594385; x=1720199185; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dKgOvlTc0UfjL+qcFfB925sH1IjQwSnOhFoOsm7UVZ8=; b=HV+dH2ORytyP7ZkXUazVT6PL11eKY8KIQi9gshfYxO7Tk31OP6aH1ZYAY5Hucc0F45 C/waR3YBo07qYBSHzYVs9JC16Lcnl3uJcn5MbnCjz6kYn+k++yziLPLNtWAEq3Wk+WE0 5ZEJMrN8ITrNnSssSbjNCpCvhnn92ZRRykGuqUDvzy3el2uBddSadFMdcMSUx6I7ZIq+ mOdwhCZ9cBouG9smjI6UvS7U5YX0OC7Wg8CBniNA8d6YR3kGGXtEsoCOZwT9GFxGw+9n N5aBclDQfqjKs8iqejN0FNhTRvkI02iINRYm7Uhi9rqqXKqEr3Rs5sKrhSW+xMWaQaas fyuw== X-Gm-Message-State: AOJu0YzqSLStI3+Wq3RJdHdcoj5slfVniMHoDSWvW7LexKU8vcADMZXP LPLP0suQ3me75VePcmgoP/AOPiY+MRXotHbovs3qfry1e5xA43DucSSXMw== X-Google-Smtp-Source: AGHT+IEwpEgTM35JjFiIGMf+1wkBFbpGJyzr+raBp2kiM4YUFbMhgzuWQ1DEa4uuoOtcjKKqgc7WVg== X-Received: by 2002:a05:6a00:8702:b0:705:daf0:9004 with SMTP id d2e1a72fcca58-706680c1610mr19162822b3a.3.1719594385254; Fri, 28 Jun 2024 10:06:25 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6afb8ef1sm1524623a12.40.2024.06.28.10.06.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2024 10:06:24 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 7/8] lpfc: Revise lpfc_prep_embed_io routine with proper endian macro usages Date: Fri, 28 Jun 2024 10:20:10 -0700 Message-Id: <20240628172011.25921-8-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240628172011.25921-1-justintee8345@gmail.com> References: <20240628172011.25921-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On big endian architectures, it is possible to run into a memory out of bounds pointer dereference when FCP targets are zoned. In lpfc_prep_embed_io, the memcpy(ptr, fcp_cmnd, sgl->sge_len) is referencing a little endian formatted sgl->sge_len value. So, the memcpy can cause big endian systems to crash. Redefine the *sgl ptr as a struct sli4_sge_le to make it clear that we are referring to a little endian formatted data structure. And, update the routine with proper le32_to_cpu macro usages. Fixes: af20bb73ac25 ("scsi: lpfc: Add support for 32 byte CDBs") Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_sli.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 8bfac9143314..88debef2fb6d 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -10579,10 +10579,11 @@ lpfc_prep_embed_io(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd) { struct lpfc_iocbq *piocb = &lpfc_cmd->cur_iocbq; union lpfc_wqe128 *wqe = &lpfc_cmd->cur_iocbq.wqe; - struct sli4_sge *sgl; + struct sli4_sge_le *sgl; + u32 type_size; /* 128 byte wqe support here */ - sgl = (struct sli4_sge *)lpfc_cmd->dma_sgl; + sgl = (struct sli4_sge_le *)lpfc_cmd->dma_sgl; if (phba->fcp_embed_io) { struct fcp_cmnd *fcp_cmnd; @@ -10591,9 +10592,9 @@ lpfc_prep_embed_io(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd) fcp_cmnd = lpfc_cmd->fcp_cmnd; /* Word 0-2 - FCP_CMND */ - wqe->generic.bde.tus.f.bdeFlags = - BUFF_TYPE_BDE_IMMED; - wqe->generic.bde.tus.f.bdeSize = sgl->sge_len; + type_size = le32_to_cpu(sgl->sge_len); + type_size |= ULP_BDE64_TYPE_BDE_IMMED; + wqe->generic.bde.tus.w = type_size; wqe->generic.bde.addrHigh = 0; wqe->generic.bde.addrLow = 72; /* Word 18 */ @@ -10602,13 +10603,13 @@ lpfc_prep_embed_io(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd) /* Word 18-29 FCP CMND Payload */ ptr = &wqe->words[18]; - memcpy(ptr, fcp_cmnd, sgl->sge_len); + lpfc_sli_pcimem_bcopy(fcp_cmnd, ptr, le32_to_cpu(sgl->sge_len)); } else { /* Word 0-2 - Inline BDE */ wqe->generic.bde.tus.f.bdeFlags = BUFF_TYPE_BDE_64; - wqe->generic.bde.tus.f.bdeSize = sgl->sge_len; - wqe->generic.bde.addrHigh = sgl->addr_hi; - wqe->generic.bde.addrLow = sgl->addr_lo; + wqe->generic.bde.tus.f.bdeSize = le32_to_cpu(sgl->sge_len); + wqe->generic.bde.addrHigh = le32_to_cpu(sgl->addr_hi); + wqe->generic.bde.addrLow = le32_to_cpu(sgl->addr_lo); /* Word 10 */ bf_set(wqe_dbde, &wqe->generic.wqe_com, 1); From patchwork Fri Jun 28 17:20:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 808470 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2140F1CCCBD for ; Fri, 28 Jun 2024 17:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594390; cv=none; b=pO+2gTPj3QGVuItPClGmONAPDTxwCG1BY9LRhWXG1/3IpA4HpN1c0bnKFoRGsXNy8K3VrjJx4esmQQWr1rDrFjCSzapWqLCg7B3ga68Fv8IZ8bLYS3IUksazvAPV8rKUeG/P4pt0LuNtHanRRgzLAaOO5vxJy9LZr/1lW256zJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719594390; c=relaxed/simple; bh=PvrlveKPqs+0HJxR+rli0Vbc2GJR7hvNoa09VKw+cv8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=d9PCo1GHV8DLo0p0FK3a9ZLyIdHO4LTMyPvK60piMxjneAxOHEpdl9eF+HxcZvsiauvNsJl3d+aQtDnapqxeqBOPDV9t2eSibEU4bcpJLb1HSKyk0yrRGriFTED5yv1+gwdEF7EhmLV0jZrlbq3ADIYHT+n7ESLuMRaxKSf+9Mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L24hWGUm; arc=none smtp.client-ip=209.85.166.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L24hWGUm" Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-3762c172d94so488095ab.0 for ; Fri, 28 Jun 2024 10:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719594388; x=1720199188; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iy7iomoDBwwUT5KvVF8VDfkmXA3JUEiZ7ec1EpJHMSg=; b=L24hWGUmrROPAX0rdxA7OA4OJS6Xn1x41VSPIBnxSi3xqypZQkZNSUtQtjEe4O/Zhk rsui8bFebBaBVRmHLUVkA4vH+BPA4uWsycqVC3TKq1qJ5TukMJ1kBF2JpFN/ZPNz1BhX lyxPGThkCkdUodn+3tXhOEcgRVlSSwJKjBOgN6EMBz4t6K8OvfmDJg3oJL4fFJY3f9IF WNYShxSd2UesLj6IYQz92OfKf/NoX0aWmHd+Jh+gp9jyRAc0gcsv2+6VtFbRtuI+oX/t 6htp9Ct0IrG5ZKW2tAUCY4RtNel2XzYssDw0Fd0Ng1xhXwuofgOLsTZOW3OD7ymlNibE L7GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594388; x=1720199188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iy7iomoDBwwUT5KvVF8VDfkmXA3JUEiZ7ec1EpJHMSg=; b=noC6B3Qt9Rb4vwUSqdWKcgzJyshOB7Z0Wm3vWF3fMTppC28oKJ2txkCeXkW9QX09xc 3f938fEDyvU8ukdKqvE+uHJWmrx8KPiAMCeoDtwbgZt4JvsVaOSHNGOtexsV4N6wvqAE zXfgjz/EU26m7fmZwX3fNUYUaJffAKA+o7dUyGTAE3HtB6Lh3EQLHLh9plcE9hmFkGsW IFvNHgugoGGtI2BU46EL8l3ujFShcdC/6q0DHSzseQjXXnHYb1twY7a/DEK6Xq05fYy6 w9e/8VH6w0gGZFzSMYQJgyDWqlsMLjPmzwY7vxqXCSg4Sc1COZqCnBKfNkOKcxzJYDKJ WfCA== X-Gm-Message-State: AOJu0YzE31RdX+Om4f+zVaoj1DiOCvLsWb3g6x2ydqLx6bY3cdSy0cFn wYW5UkJM+pNZxweH2UFUIPh/pUKYO9PtZDNAjHBKIfYIolYwBQBsVlFbmA== X-Google-Smtp-Source: AGHT+IE0/Jhxedpq3h15I2UTPtjSXPnRB7d21sct0sEgEgE+5+pacELilaBpgcYkh7vw1eQIj1mp8w== X-Received: by 2002:a05:6602:3148:b0:7f3:9ef8:30a4 with SMTP id ca18e2360f4ac-7f39ef8334dmr1849525139f.1.1719594388098; Fri, 28 Jun 2024 10:06:28 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6afb8ef1sm1524623a12.40.2024.06.28.10.06.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2024 10:06:27 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 8/8] lpfc: Update lpfc version to 14.4.0.3 Date: Fri, 28 Jun 2024 10:20:11 -0700 Message-Id: <20240628172011.25921-9-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240628172011.25921-1-justintee8345@gmail.com> References: <20240628172011.25921-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Update lpfc version to 14.4.0.3 Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index f06087e47859..7ac9ef281881 100644 --- a/drivers/scsi/lpfc/lpfc_version.h +++ b/drivers/scsi/lpfc/lpfc_version.h @@ -20,7 +20,7 @@ * included with this package. * *******************************************************************/ -#define LPFC_DRIVER_VERSION "14.4.0.2" +#define LPFC_DRIVER_VERSION "14.4.0.3" #define LPFC_DRIVER_NAME "lpfc" /* Used for SLI 2/3 */