From patchwork Sat Jun 29 08:36:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Smirnov X-Patchwork-Id: 808522 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9675C1CFA0 for ; Sat, 29 Jun 2024 08:36:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719650213; cv=none; b=deyRQk1tHEDZq+Kjwqjezlj6AI9gYVxU5Sz9waIc9Y+j6r6edsMcH5ClXySTOqTUvFxw2mo55XsP0qm9xXvv74vWJbsw9eEn8SsnYhzLKXnw0znFOXq0C6D1jeugF9KAheMN7e9Zx9UxpgGqFr74VctUC3aZxnlc68DAfG/dZu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719650213; c=relaxed/simple; bh=xM3JcotPURzS3F6oKYPh75/sbUV4o65lTk6FVra6anQ=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=uL8Zn+WLuYSeNWXEaHYcAbLpx+8iq/f73ERYxjcNui/j8oh78mXBLi2kaMW9d/M2LO02aSos3v6CYpGbafgUtkGxVG2cdUI0vnq2Uhfb5aoWd0+/UuwRD0jl83KVWcEcP6yRtweWK6BQrFup/hS/S6Uxe2smvPlooBPqVgEBaXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from localhost.localdomain (217.23.187.157) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Sat, 29 Jun 2024 11:36:38 +0300 From: Roman Smirnov To: CC: Roman Smirnov Subject: [PATCH BlueZ v2] avdtp: add NULL checks to avdtp_has_stream() Date: Sat, 29 Jun 2024 11:36:18 +0300 Message-ID: <20240629083619.11804-1-r.smirnov@omp.ru> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 06/29/2024 08:24:14 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 186224 [Jun 29 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: r.smirnov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 21 0.3.21 ebee5449fc125b2da45f1a6a6bc2c5c0c3ad0e05 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 217.23.187.157 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: omp.ru:7.1.1; d41d8cd98f00b204e9800998ecf8427e.com:7.1.1; 127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: ApMailHostAddress: 217.23.187.157 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 06/29/2024 08:27:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 6/29/2024 6:47:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Make avdtp_has_stream() safe for passing NULL pointers. Found with the SVACE static analysis tool. --- V1 -> V2: added check for stream profiles/audio/avdtp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c index 3667e0840..64735c5ee 100644 --- a/profiles/audio/avdtp.c +++ b/profiles/audio/avdtp.c @@ -3918,6 +3918,9 @@ struct btd_device *avdtp_get_device(struct avdtp *session) gboolean avdtp_has_stream(struct avdtp *session, struct avdtp_stream *stream) { + if (!session || !stream) + return FALSE; + return g_slist_find(session->streams, stream) ? TRUE : FALSE; }