From patchwork Wed Aug 7 14:12:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 817636 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EC03339B1 for ; Wed, 7 Aug 2024 14:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039973; cv=none; b=CV6nrOkdYTa/XYC/SSrktASq7a0FbHzD6FU63ZlmxAqSNniGAQxbuufGTY6g5sRWnFHf3sgFWBgR8RSOKdBK8na0zaCVlhdoUDHxye9JaYDyHLr66EEJkoAowpJRNNNnWj5kNuc0XswAlS/WUL0I3A8wbRH1SaA/Y6eRU7xzMz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039973; c=relaxed/simple; bh=qaLIhY5a76Z3Df5j4EUrP5Uqp81Mo30nXZU+/Xwg6EU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PVPsSuZYQA+g0lM9MSsPdebTz2qz9sfGoXXVCMdgUhvdIaJ2PVyat5bsOzDJTcRUJboSQRRzGswOHWj4W54VJJisR0SAxhmigPrabVaHvjeFxHNx/kNYLTHY+I4JAAbR8+zm34KH4UpZGL8WjYw6ubP+27RKZD8vKWHR0/ljgl4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=y47iMReT; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="y47iMReT" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5b9d48d1456so1109010a12.1 for ; Wed, 07 Aug 2024 07:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723039970; x=1723644770; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LPc8uL/JW9kq7vTw/l6UlNZzhd8kMKMZECX7hWsn11g=; b=y47iMReTM8VnQbFb+ijO1pi5Hm9vkUEp+WNV/IJ6bfloBBVqjsDsycwi/JxUkG1sLc oRlQHqnEx1KHXqYjTswg6pEJVCK8UW89A3I7TqHxLrLPmiWJROlQ4HwGYwpEUA7vFFhV qTpOHHPSZjmXqLshdqh1N3jXwL9FCR3miDldo+H8MqdS05E1Z3Dk6j9dChueN7Pqu3MA VOBg1kGJ4ofiX2aPXJZ2qkBauR8uEKGl6pXgSJco5tPcMbOykJ8UJvIK15Rp89Bb7sYB LkktYGnoxGepnGYVMVnPrw6wFWNy8h5DPCWCYEIAA5fs/BCapUOtdtyyc/qJ3nkz3Hbx Ht0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723039970; x=1723644770; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LPc8uL/JW9kq7vTw/l6UlNZzhd8kMKMZECX7hWsn11g=; b=nzwyl+6KO4x7Jq9UpQpBiiVvDHXyKX7BFddOOVlkAAEynEV+QU+YXMIGgp3f8Khzeh gIq3Vtj3nG3i27RxIaFRHVo+tMvJdA/VFYF/4eWGf2ROSgOfZmZm5OhIpTPkIUvY1LLf +pGAg6wyRGc2lsNDwdTgWaCu0YE4ZUliFMM4fBJOCRCjnxDBwpMmBPtyKM4BgvAhmfqx 98wZjNnTzz5zA/MUwPpzB3ju0VbElNQ04/VuIDS6JTfjhBeEzh4flbPDJnNS3HeqReis tujdDWJKJ+sP7mYGey3yNxgzAUx2MdNJyoOhbhj1syW8QmT90MRmr3cKyXUCfz0wJP2E ZNbA== X-Forwarded-Encrypted: i=1; AJvYcCUPX4PLuwzkTt85GYXCKCNSaP8r5G3Ay6ATGB/r0qnBATZinFQ8vXp22S82L1Ptbt2QlizoaY07JhOQXnlHWJbWG3wZgGjgrnu0N1jR X-Gm-Message-State: AOJu0YwyTSEk8OZYweRkqBW/41QZgcw2fkehQ8lqgQNfftWqij5wwtLp dmAYhSCcUDIqogRfYRktla33bP73KNl5mWSZhGSigh/Gi2jhj4JCUBEuaKVFT7TaCqRiLswVuyj 2 X-Google-Smtp-Source: AGHT+IEsUdOugcFq+1Zh+LgBNPD+cI5u68iHgjax1xg5KbxJ57PrjeQWrdQKQ2V4fRjbRDhrQZGJug== X-Received: by 2002:aa7:ccd6:0:b0:59e:a1a6:11b9 with SMTP id 4fb4d7f45d1cf-5bba36774c0mr2032366a12.2.1723039969391; Wed, 07 Aug 2024 07:12:49 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a245:8609:c1c4:a4f8:94c8:31f2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b83b92cbccsm7057525a12.68.2024.08.07.07.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 07:12:48 -0700 (PDT) From: Markus Schneider-Pargmann To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Markus Schneider-Pargmann , Tony Lindgren , Vignesh Raghavendra , Ronald Wahl , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Thomas Richard , Thomas Gleixner , Udit Kumar , Andy Shevchenko Cc: Vibhore Vardhan , Kevin Hilman , Dhruva Gole , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 1/5] dt-bindings: serial: 8250_omap: Add wakeup-source property Date: Wed, 7 Aug 2024 16:12:23 +0200 Message-ID: <20240807141227.1093006-2-msp@baylibre.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240807141227.1093006-1-msp@baylibre.com> References: <20240807141227.1093006-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add the wakeup-source to enable this device as a wakeup source if defined in DT. Signed-off-by: Markus Schneider-Pargmann Acked-by: Conor Dooley --- Documentation/devicetree/bindings/serial/8250_omap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/serial/8250_omap.yaml b/Documentation/devicetree/bindings/serial/8250_omap.yaml index 6a7be42da523..4b78de6b46a2 100644 --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml @@ -76,6 +76,7 @@ properties: clock-frequency: true current-speed: true overrun-throttle-ms: true + wakeup-source: true required: - compatible From patchwork Wed Aug 7 14:12:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 818006 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C984E40875 for ; Wed, 7 Aug 2024 14:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039974; cv=none; b=iDSNZpLtvHySXtqDcjDAtcjYPtLyKT4eGYvF1cY1t0nQa0r2S7JjzZGfVObgGx9c5th5dIqPSEPyAHbpm/fwaWdg2Xa7vXt+xi0P0HFL9MvSdKEV/lZPUU+hLz1Gcl56HS0o0UwggdtjlqoQbNeo80uJHPKIGlMpOXQcqJfqrj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039974; c=relaxed/simple; bh=G53h7iK7equCI+YAgbuXL22KeDRVYHM1PGJrRCk2n3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Sv1+18mnBTbWMAREFeubc7s3VusLApTUuIuMkCJrpqNq1jc4RKN5+YQfHaEy4fL8pN1h5rC8v5x3qevB6ER9ycPqix3A1c6CsLTEFz3LKNwWiwfBJKjxVoiNTiCnATCCLIpIBSIOUQkX5usGNSV+css+pjl/hixzjflL7sGISlU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=PKt0TU2o; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="PKt0TU2o" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-52f00ad303aso2736855e87.2 for ; Wed, 07 Aug 2024 07:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723039971; x=1723644771; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a5C8r3Duyh4k8zPXTMuRthG6AYE+Xab3qX66upD04/4=; b=PKt0TU2oq+4p6tLspbrj9btjzCWn8Wcyz+t8d8wx8JrpLnwcCT/IVQ3ANXxxBaxoG7 ImOOqBIx3CAZotrA0xPrPXiiHsVX0ngdsNGj6TRyFhp/KZjkDuFQ+sFu3bl9UiQIUoF6 oMDmFd9mo7EswuD5aeaDeDjhbw7TS2VZZoruofRWIntOhuMmt7bP/tr2h/8yvL7MN49y D0pehhghzftlXhP3zsBK3u7e3khtFg4RVVBxueUMQfE6iDPelLbHDVDA7u5lmdn9md7O 4qCNkQ3T9kPOdmE3i7JFSlVgmDiW8RiDnC33M6kzRs0T17eQXSYUXxlhPs7/U/ro+WLz rrWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723039971; x=1723644771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a5C8r3Duyh4k8zPXTMuRthG6AYE+Xab3qX66upD04/4=; b=dVJbyOi75CbR5XaS3XYffbwQJLqfdiEGsviMmjj2++r3fELOTIQQQh0F1JEo2VRIMD eB8hgjU8MIJ7Dwr1GdZn5sa3F6alGSVRHKsVxE7WnKFeRAKogQV8PiuiVnYuHSWnBSCm yJCGyThPFX+tYSU3+/jQp/GVksNYH9FAGE354oMCYyV4UVQz14yXe5DsxYImK4NawQz/ /KmsW+0Tu3/71M6ACfOU2CoURCKO+kvQWbyUv88CqQ0uIrpRh/3ebXcib4unHwnozwOR ja7F/nR2+ZUNR3aqKJB7jrNTq29PiZaUS8YueeKqF4rxyvwfhbYaVNcXVYjwav6SwWDm T7HA== X-Forwarded-Encrypted: i=1; AJvYcCUlQ/F2K1+KhDMknBaBXU6NjVi1e1h6Gg+YO/naeB7MnHDRlx/4NaTxW0yd/SQHZER9wKWS5QMDuZaZVTHhO2Y+sJ3o/pvU1sw0ju4N X-Gm-Message-State: AOJu0Ywbeqd7DC+zYoENJaDpltTS2rTr631dGFiJavo2qvqpyLiimAWf eriOPRxZGGrW9ECjcPFi4l4qSd97mU515/sBqxlF8kM+yOSN2ktNK4AiAmhIYIs= X-Google-Smtp-Source: AGHT+IFosTI6Kk9S7vVp+2KFUmR/5pvfyiB5Vr1uhy5ZefdQG7LKhdWRJvxVgUXiBD9CZ+Mjmb+Ybw== X-Received: by 2002:a05:6512:3c98:b0:530:b760:92b3 with SMTP id 2adb3069b0e04-530bb3a2247mr9912329e87.31.1723039970563; Wed, 07 Aug 2024 07:12:50 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a245:8609:c1c4:a4f8:94c8:31f2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b83b92cbccsm7057525a12.68.2024.08.07.07.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 07:12:50 -0700 (PDT) From: Markus Schneider-Pargmann To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Markus Schneider-Pargmann , Tony Lindgren , Vignesh Raghavendra , Ronald Wahl , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Thomas Richard , Thomas Gleixner , Udit Kumar , Andy Shevchenko Cc: Vibhore Vardhan , Kevin Hilman , Dhruva Gole , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 2/5] serial: 8250: omap: Remove unused wakeups_enabled Date: Wed, 7 Aug 2024 16:12:24 +0200 Message-ID: <20240807141227.1093006-3-msp@baylibre.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240807141227.1093006-1-msp@baylibre.com> References: <20240807141227.1093006-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This field seems to be unused for quite some time already. Remove it. Signed-off-by: Markus Schneider-Pargmann --- drivers/tty/serial/8250/8250_omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c index 1af9aed99c65..02d4f3073696 100644 --- a/drivers/tty/serial/8250/8250_omap.c +++ b/drivers/tty/serial/8250/8250_omap.c @@ -144,7 +144,6 @@ struct omap8250_priv { atomic_t active; bool is_suspending; int wakeirq; - int wakeups_enabled; u32 latency; u32 calc_latency; struct pm_qos_request pm_qos_request; From patchwork Wed Aug 7 14:12:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 817635 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B155811A for ; Wed, 7 Aug 2024 14:12:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039976; cv=none; b=GKK4tlEL6T9Ml1Cqb5c3XK/iKTvfSQninKXwHXh7K/nT8DdKHyXJFK32uhBNTgIF8Ge8G6qh0lZXOlJZ5nnZ/JjOz38f1nUDrAp60PRpfe9HZPAGfLyNrG/8D/Bj6tZjM4QPTL6J1+0ln65Vg3JpK/361tCpJp3UFpnKG7zDq1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039976; c=relaxed/simple; bh=e9Jc2sCWqNGEQJxc1zAjMLSN7zhY899ZX891bxlRIFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K8cJZsMw/QWLrTCHz2tfOiaj33xhqPxMpwXzOkAsT23poQRUPK7SPn91t6eIFK/VW7BdvKTjoLLlCdVlp0BTbcMei+dVXnmnNs2wIgHTJuwg+9/pVRHW8tsWhvDqzL1UUp58DTeUghhbswg360WqX9E6FqRPNMV5verh5JPJhGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=w1LATSfC; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="w1LATSfC" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5a156556fb4so2161804a12.3 for ; Wed, 07 Aug 2024 07:12:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723039972; x=1723644772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oKla0TikiRVuhRSfUT0bnjb0mFUM6MzVyHzb7uGiohw=; b=w1LATSfC1cDKgdDqOGwe3eDw9Mp9RG252mLySZfJImFljP1OOFTgA0wxCA6NSTeuET bLyYU2r6iJiEcYLCAaJJK1ISp6OGpqMNFoffi/MsabY6tnOJDdm7N9/2LpEUCvzgkrFJ 4efDk6BCnRM2OpgSVkNlqXgJq8zNMNgzG+/PLOvyEwz7dCU8T95PeAaxfElW1f11bDr7 IvjkamYeEOZXN3xJnvpu26gxBQ71rjfOOe96MCoDVWFqqkqh0/m5/1MwqIzjKW/CJmpy Ee4RNKc9pCPeinesdVg04djl5zH45vZHYzGvmJufOJuC9FLkE3vizvnLlF+ziFSfpDbn Buig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723039972; x=1723644772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oKla0TikiRVuhRSfUT0bnjb0mFUM6MzVyHzb7uGiohw=; b=s3IXQzB3wKbo9LRQnohCzmF9kMD56gBhogu/f90bh86gYOh7+JEKrK14qu5fXJ+nKI 5beTv1E8WPFNVuEyy76tNxvD31wrwtwaNvHLt4k7eotGBGmDcR+mx6Q95ikkVl+w0Q3j GR4V1wez3xwqAmzqLGUxPRacLQPhgFPLXMaI8Dhivgl6zpr4oob3HdU9QiUedBZvQdL5 KLvn0Z6xaJlWTn7Z4/1H5le3cgB4vTs3m8oEHpdETG1wxWV6hulPbfOx7kjpMdOcmMMo 4iXAi/7ZycipnP5eErRYOq/vipwCm5lE9cce/pQNc7NbfgWi/6ohWmJ4+Zp7NC/jzub5 gzaA== X-Forwarded-Encrypted: i=1; AJvYcCXuW2LsrJucAYCiub6dR5xKXeQ3TZAAtQJqHM6Ea6A8nTQlNlNlvvJx7ky3xODkCV1tx/nWGi2Gs1YKQiWLmo6n0823tMuabs5u8xeo X-Gm-Message-State: AOJu0Yx1pVJV3UwDCxbI/XI/rtvtB+zkL1A5FqclnPkLjcGeO2yaQ3pD bAz/Z2V1rz8YZqMrUW2mcmo+/LR2XVx8LrEUm0C7p/0Cz4R487QJ7Ko3YuY2vdo= X-Google-Smtp-Source: AGHT+IFTtDrHzcEyJfrxQSsx9wYYXZfPjxj1fP6zwRtDfyoo6YHEvanfv08xhTEKIkVOKBpqh5fwkA== X-Received: by 2002:a05:6402:542:b0:5a2:37e0:1e88 with SMTP id 4fb4d7f45d1cf-5b7f39e0ac1mr12617987a12.9.1723039971875; Wed, 07 Aug 2024 07:12:51 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a245:8609:c1c4:a4f8:94c8:31f2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b83b92cbccsm7057525a12.68.2024.08.07.07.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 07:12:51 -0700 (PDT) From: Markus Schneider-Pargmann To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Markus Schneider-Pargmann , Tony Lindgren , Vignesh Raghavendra , Ronald Wahl , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Thomas Richard , Thomas Gleixner , Udit Kumar , Andy Shevchenko Cc: Vibhore Vardhan , Kevin Hilman , Dhruva Gole , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 3/5] serial: 8250: omap: Cleanup on error in request_irq Date: Wed, 7 Aug 2024 16:12:25 +0200 Message-ID: <20240807141227.1093006-4-msp@baylibre.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240807141227.1093006-1-msp@baylibre.com> References: <20240807141227.1093006-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If devm_request_irq fails, the code does not cleanup many things that were setup before. Instead of directly returning ret we should jump to err. Fixes: fef4f600319e ("serial: 8250: omap: Fix life cycle issues for interrupt handlers") Signed-off-by: Markus Schneider-Pargmann --- drivers/tty/serial/8250/8250_omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c index 02d4f3073696..01d430de9c64 100644 --- a/drivers/tty/serial/8250/8250_omap.c +++ b/drivers/tty/serial/8250/8250_omap.c @@ -1587,7 +1587,7 @@ static int omap8250_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, up.port.irq, omap8250_irq, 0, dev_name(&pdev->dev), priv); if (ret < 0) - return ret; + goto err; priv->wakeirq = irq_of_parse_and_map(np, 1); From patchwork Wed Aug 7 14:12:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 818005 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2699474058 for ; Wed, 7 Aug 2024 14:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039976; cv=none; b=I/oi61Ro2IfCkR+FWNREizHCmSAtPN5O7sp793V2koxe9PSX19ZrQMCAopqx0vIed4uZ2TC8RP4/+qzPgrdLcCrXwN83qoQM39RTXWYbhH8cW7tUuoc3UDtlNlsQSxVui5E9f71Xj92IUBuWpjZk7G4o5iZ7wmVKpkmkbjUrZNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039976; c=relaxed/simple; bh=/M7emE/2Qa2RgsvJur8Mg3ojafyx/BbqtMTsB9gWNeE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KLFUNT49F3rBSYbxdP12F75DYqf3ChnHK8yf2EC6AOCagX7xENxm21i9UFGK2DX/CcYN5sAtM2KHiQAVBEU/NZ5GB29ElAbHKyzQy0EqU5H/gRRmDyNkkwc+jeIfkeIArZhWYQo0hD/6+UkUySogkXHjasVjxfy88Q+Ahtek+WI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=hcHvxlmh; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="hcHvxlmh" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5a10835487fso2891831a12.1 for ; Wed, 07 Aug 2024 07:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723039973; x=1723644773; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vj85BiW7OH0vjd00Din4ISdKFXtoAd7NnhKsZDjxWzA=; b=hcHvxlmhGW0B8hjAS2RGGef1QnhgFqQU1v6V3rU7UmCDt8MlCA9ERKp9GhDhkZ6281 5hO4L3srugHqaLct9wU62weixLIvxmT9e7QmjqFQOlHlGXYVQ2Pc/vCaWXdpZJcxoT4x MFxUfNlFriwwTXJtXCQGk1PDs3S4JO4suOcXF9jPMUwCpTTSjm4aq2Ls4gPajtTfMfxa i4EywJclY6Q9mIB8o7/gIDwBe9W3cvqulsrmT8lFq7/wQwetXXYxmynsGRbUxavcqnKs THoStBY3qJVJrWhb5xrvgvv7IleUArW7JXoeFgWweYhqBPnxMJPOp2f3PKmIKP4hqqn3 HBDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723039973; x=1723644773; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vj85BiW7OH0vjd00Din4ISdKFXtoAd7NnhKsZDjxWzA=; b=d3BC06xyljnz3fleV1S9OQFNFe4w+/98kQPXyt8+5KVDg66dOIj5YsGGIfQ6aKs7J4 iQzbGwrV++CoF3eRyT7ploi2NxxjTVncYPsQUUseuukGfJhJaAo+1ZNX4MoYX94vXPuJ XTemA5K8x2+r+9pJbhml6yf3aj9/6P1uTMvCxqWzSMEEZmjfz6cMfjKLPSzVZ/ySEfy/ UGLYfQJ8e+64JM+pDvOu0hySAkUd0qLo4TuW0ULFjZ/XdJNr36EmUQTkx2313bwREIhL 6DTD2DnERnFx6Rci38wtaF4/+1PCW70KWKmRZR8v9AnMz9LhENchvouiwBaxc3Z0CIJF OGEA== X-Forwarded-Encrypted: i=1; AJvYcCWBqRGBnRZRSOKNlHKI4tq96l+U28NmvmueWvSrCVex8QZhDLuuZReBSQesfNRCWYU3oZCcnz+7tXt81C4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+geSQ2T6HfR7r6BG5yOLE0ppQzS+2YrGl6YnymQEGwQl09W/L IOqbsJC6D3y9rdDd8izbGBJZGRKSneMd5uyJQm2elmjMsBvLdj6au29urK+dNIU= X-Google-Smtp-Source: AGHT+IFFeWkyTUn3gXwl17NAH20cD1sXn2wOqFO/iSCy6b44/Rpq7Q6khSChCCoOdtQ8kcv5YttJkA== X-Received: by 2002:a05:6402:40c:b0:5a0:c709:aa0b with SMTP id 4fb4d7f45d1cf-5b7f56fd439mr14154527a12.24.1723039973524; Wed, 07 Aug 2024 07:12:53 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a245:8609:c1c4:a4f8:94c8:31f2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b83b92cbccsm7057525a12.68.2024.08.07.07.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 07:12:52 -0700 (PDT) From: Markus Schneider-Pargmann To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Markus Schneider-Pargmann , Tony Lindgren , Vignesh Raghavendra , Ronald Wahl , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Thomas Richard , Thomas Gleixner , Udit Kumar , Andy Shevchenko Cc: Vibhore Vardhan , Kevin Hilman , Dhruva Gole , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 4/5] serial: 8250: omap: Set wakeup capable, do not enable Date: Wed, 7 Aug 2024 16:12:26 +0200 Message-ID: <20240807141227.1093006-5-msp@baylibre.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240807141227.1093006-1-msp@baylibre.com> References: <20240807141227.1093006-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The driver sets wakeup enable by default. But not all UARTs are meant to be wakeup enabled. Change the default to be wakeup capable but not enabled. The user can enable wakeup when needed. Signed-off-by: Markus Schneider-Pargmann Acked-by: Kevin Hilman Reviewed-by: Kevin Hilman --- drivers/tty/serial/8250/8250_omap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c index 01d430de9c64..7a6dfd40af9e 100644 --- a/drivers/tty/serial/8250/8250_omap.c +++ b/drivers/tty/serial/8250/8250_omap.c @@ -1529,7 +1529,7 @@ static int omap8250_probe(struct platform_device *pdev) platform_set_drvdata(pdev, priv); - device_init_wakeup(&pdev->dev, true); + device_set_wakeup_capable(&pdev->dev, true); pm_runtime_enable(&pdev->dev); pm_runtime_use_autosuspend(&pdev->dev); @@ -1628,7 +1628,7 @@ static void omap8250_remove(struct platform_device *pdev) flush_work(&priv->qos_work); pm_runtime_disable(&pdev->dev); cpu_latency_qos_remove_request(&priv->pm_qos_request); - device_init_wakeup(&pdev->dev, false); + device_set_wakeup_capable(&pdev->dev, false); } static int omap8250_prepare(struct device *dev) From patchwork Wed Aug 7 14:12:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 817634 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58B3577F08 for ; Wed, 7 Aug 2024 14:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039978; cv=none; b=sn9I4oDvr/v7Uqq7jqb1izwd8ImBe0ifk/b+UHa9phK6Oq48CGHFc9Qsqo6r++EmvUT9hes58ZYXP1LQ0/Ccod/2hhjEW81MzU3pyy0v++Ps+SFJY3Nat0FoH9xFrRed2HW7YuXc1OnwmOgU5LKpTdohp3Ns47BphCuY8Staz6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723039978; c=relaxed/simple; bh=jJ/dqspqaWeDfyxYIMbjnG33egLfKjvpbKPXZLYU2Y4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aNkpXnlU60aWrAVqRRosjVByMJKBrT5soJ3sblpDewn4Pn42FF60RnmEPjsyqAp9xj7ezlCYNmwOZzFFEvPEBEaiujzBxfg5t/su7zw53QomHaLAU0/ZqCRzC8x/6JgpKgvl2lXZCYO/iNAKnEz65nH3wtA6KvoCc6I5ke8SGVc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=3J9tLpxp; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="3J9tLpxp" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5b8c2a611adso2563337a12.1 for ; Wed, 07 Aug 2024 07:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723039975; x=1723644775; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KWzbHrkvy9hRtxlDmALumwCtMR3F4NOzbURL/XveH2s=; b=3J9tLpxpAQktP/CNTTI9R2YOuNOZ9seuckzPxBGLeAWc3ObioLIZSPGwwitFJdIq75 Rvdk8vMG4l3ysDhInNv0TsiunZFNkjPa6oIkwD+dqWAuVU0U2KJ5h06vL+CAFeoPBQaL ASbmu1hDxqC/gsdzEgLienLvA1eWUZbGXRxfQQWuNBsU2Aj+vBITfE7mSaN2q2mM0v/W l4zVUQYUYYPNzDzLZfzPWAWtJ5PlzkYQbU5rQ51CKWYFcJEifIaAn6lPS+WRx/Uat4EO +S6F1jRk4ijw5lu82yXg6tJ0yFDe6syDb9z8O/pdzwt1fuzZSOLxrSEi0yo1R63qYXgI NQ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723039975; x=1723644775; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KWzbHrkvy9hRtxlDmALumwCtMR3F4NOzbURL/XveH2s=; b=NAKmoC6PCXw1My1aZ/cx8LM/rMu5K60xvkyn1dCxYqBVOVuw8j3IMtyY2ytQCUmm7A AZ1LJgCfruYh5iPijTEqQpRF6mPU6KBtyz1hVQixanVVg0Y3uQDT8Z70A838teWZuR+9 0twEtzlN4zfW1yhP9iAwPp3D8nbIoXmD1nT9TzrPWr78azA2sldOAKv6wuG8WkYUVnKt AfLl3SyA9UCoWUH1pTmgGsY8XkpdGUcPTlBOsZtfXWpSRxFJlLnx2n0uJSoHH0/1qFMc 7BHDQF/85p8XZT/xZ++c+AIZ0ohecgvGy9RoIpSmyglvsb5+h6rLrwHGNPbM3vRtLQRK /52g== X-Forwarded-Encrypted: i=1; AJvYcCUhSugiMov9dWFH0Nl/duhCypRCQ0s0MueKLRbN1UNm0IalDGSVfHRtLJBSW3DILaxRmlSkyoqy+MYM+SorICkgd80dN541FX01k4P+ X-Gm-Message-State: AOJu0YzziuF3a5SxeCtruazzZ96C/8uou/4ez0I12xPdZfkFnJafIz9u Xd/2IxgJ7shLpRj34rkouuPPL5ddRWHW1oWvEKkT8OpqEdUHGU7zFXa7PJ9v33o= X-Google-Smtp-Source: AGHT+IGq4cislIJyd0Fi3SNfVx3j+NKux5WeCaTZh0bSfOP0nKaFhK2IzDBaxUc7p5dC22ZqWvPYOg== X-Received: by 2002:a05:6402:60f:b0:5a3:a9f8:cf20 with SMTP id 4fb4d7f45d1cf-5b7f58eb70dmr12738369a12.34.1723039974659; Wed, 07 Aug 2024 07:12:54 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a245:8609:c1c4:a4f8:94c8:31f2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b83b92cbccsm7057525a12.68.2024.08.07.07.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 07:12:54 -0700 (PDT) From: Markus Schneider-Pargmann To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Markus Schneider-Pargmann , Tony Lindgren , Vignesh Raghavendra , Ronald Wahl , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Thomas Richard , Thomas Gleixner , Udit Kumar , Andy Shevchenko Cc: Vibhore Vardhan , Kevin Hilman , Dhruva Gole , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 5/5] serial: 8250: omap: Parse DT wakeup-source proerty Date: Wed, 7 Aug 2024 16:12:27 +0200 Message-ID: <20240807141227.1093006-6-msp@baylibre.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240807141227.1093006-1-msp@baylibre.com> References: <20240807141227.1093006-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If the wakeup-source property is present, enable wakeup from this device. Signed-off-by: Markus Schneider-Pargmann --- drivers/tty/serial/8250/8250_omap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c index 7a6dfd40af9e..ccb83c05be20 100644 --- a/drivers/tty/serial/8250/8250_omap.c +++ b/drivers/tty/serial/8250/8250_omap.c @@ -1530,6 +1530,9 @@ static int omap8250_probe(struct platform_device *pdev) platform_set_drvdata(pdev, priv); device_set_wakeup_capable(&pdev->dev, true); + if (of_property_read_bool(np, "wakeup-source")) + device_set_wakeup_enable(&pdev->dev, true); + pm_runtime_enable(&pdev->dev); pm_runtime_use_autosuspend(&pdev->dev);