From patchwork Wed Aug 28 03:49:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacobe Zang X-Patchwork-Id: 824402 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2130.outbound.protection.outlook.com [40.107.215.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF588145A18; Wed, 28 Aug 2024 03:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.215.130 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816985; cv=fail; b=ASDd+EifkbmKB4+sq3J3cNoly4MxIMiRDQoEsWVChlzAf7WJFcT5ZTxJ3oV5tqEhA5fBWTjXpG3t06wVIEBaCWDj6wEBVQ1ThCyMRbXBVsnLQ/Xu7KATStDrwDj0hr9qRtE1zRfa79C7CJ2nrBQAxRWZKKeOMHXAVE5kxwdCtAA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816985; c=relaxed/simple; bh=2VnM3Xke/V+FBPoCBZ6dXFpkeLfGCL5kEesF20cliAc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mLfy4vlWL070YzbUyiJUnJFey5Opx7UG7MK3Vuk9Axx1pYbRuEdAQ6C91pQSbFeJxMX6gIr3EUYwU+jtE8JSytg39qyRHCi+mq7k1kp1nmQWgxDq9jLOgneYASiJ1jLO31xZDWgfNrzuKbP3sd5wrqavW14P09RyNhmmSJlBEtE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com; spf=pass smtp.mailfrom=wesion.com; arc=fail smtp.client-ip=40.107.215.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wesion.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VF4ROkMCTvqbVWvWuO+siwdL2PFM7/4tIWT7jl1D49k67Y0q6+z5+Z+SBv784D9RYKiIYtXwSsVVHJWwiRpuORx/BcgR22mF6TKhRCsR5xenvFWA56FfVHNLTVoqrqc+RGp6popHmM9YGfoay+LLSjV/Vb9T5CPCeIVA6rDF0mMf1ZkgXS7Nzq1ftl6iI/d/IcLPLRtLV/o202vgFVcelugiv5WFooazwvNAUe+5HHK68CULGUu9vcoPdTZQHl9HUB/hnwaFWwU5jF5PAa0Nmfzrw1vvX51J00nvD1I+oLsZgHo9/H/WLhYeFMYWqwgvXgf//92rjKlhDTtf11o8RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n3ZCKui3FOaZbR8MmUilWzOmfwqy4Ji7tdvVIJh0aaI=; b=Yicqcftoxwl9Uu5TM1acXk1ljNWPP8Z77hi+Kay9scuFLSVZ42pmvR4M9H3dPFdjPQGXfAqaG1ZyAvN/+LILpugvQO1NDzp9sBK2udTcM04DOLAL6pGacS3CNh8TFosqPuT/A7sB9NvwVq/6oExtRyeKydSAzctrdu/A1aIE5nBLWQg3Ab9t+k8vbi1aLUnydXaIU8qPkmsmmFHhO/4YsvGLNxsFUwAtZ4rqGbHmMlm3nBlqTr2fZlLTv88L9RcZsyc1cdY5dawG8sGE0GmSdeGQ+Sj9EUsUAQuxplKE+o2i7uAX/34X5pEmfdOEvV+JtemqQMzPw3aE7YxzhXq5sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wesion.com; dmarc=pass action=none header.from=wesion.com; dkim=pass header.d=wesion.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wesion.com; Received: from TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) by JH0PR03MB8233.apcprd03.prod.outlook.com (2603:1096:990:46::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.25; Wed, 28 Aug 2024 03:49:42 +0000 Received: from TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0]) by TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0%4]) with mapi id 15.20.7875.019; Wed, 28 Aug 2024 03:49:42 +0000 From: Jacobe Zang To: arend.vanspriel@broadcom.com, kvalo@kernel.org, marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, saikrishnag@marvell.com, megi@xff.cz, bhelgaas@google.com, duoming@zju.edu.cn, minipli@grsecurity.net, yajun.deng@linux.dev, stern@rowland.harvard.edu, gregkh@linuxfoundation.org, christophe.jaillet@wanadoo.fr, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, nick@khadas.com, Jacobe Zang , Krzysztof Kozlowski Subject: [PATCH v12 1/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d Date: Wed, 28 Aug 2024 11:49:11 +0800 Message-Id: <20240828034915.969383-2-jacobe.zang@wesion.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240828034915.969383-1-jacobe.zang@wesion.com> References: <20240828034915.969383-1-jacobe.zang@wesion.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR03MB7001:EE_|JH0PR03MB8233:EE_ X-MS-Office365-Filtering-Correlation-Id: 643bac91-6bb4-431a-b6ba-08dcc71472c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|7416014|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: 5mBaryhj7vGaTdDHUw4kg4wVTD3gTi5cql0g0qdoJIv6xPfP7NLKXSWsZ7MlPeAoMtI5A1aijQ8NmZeGoDc1OfRCjwGOZQQQ0nnhbd4IJJL5AzHigr90n77kKZekVpAaihiRKh14rnngmvFHku9UTNv6sEyOHN+USsDEK7v8L7OVBW0QoKJJwelx30rgXDFSZUrtRnaNtoBsuXEfiJctvUgzFfil+VOajxSg6dH7Fm+bM/dSps0x8abLXnoVtegVTFOlKjGmaP86spIA5pb7UiPlCzLixik7wtPJdA6Fdg0gWMu4+0ceJdtSDWoaED5qoJiY4gqpOwfdyReJFBCAPq53fSqhu9olMmuP4hPmQeqwl2+NNTDAfqFTZT2ESazuxfHxb0Y7+aBrXdJnaYuqqv1Mclxc/s4QMcTSdKUx74tF/eVTcwnWLudRDOx3HwH60xgpPyJfafme0C+K5MytNFes6ZV0YJhl0SWRtKqFcil2awpE1+b8PUkADn2jTPshO8eCCdbT6Ob0Msg7X20RW9oq3GuSSkEOYAlpCV+9R2UK++cU3IpgG/X/OU52LVRFNQm6BxOOoNaZec5Wwbr1pDydGHItgFJKam8SUSz0QTo1pqwEds7Xnm/hKW1FqGQhTZpKn4O+BZcA0e4cBsGfOxBhxxKw31fbCCmKwvsf8oYF76YtkaKLhwhwfFBQddctSVfTrgK7MSRFmFArImRBwMlv5lU8vgKabNfkIweV/DULz9BOJ5xPo35KKzOr4Z5gys2QYBaozSZbGZ6A5AZes0iC7u2OIXN527m/IbVYyjgwEZkpNL+fibzgYjHhAoJrDJv93dmUhTNzAJBE4UkWn1vqFVGzMnyCyPwezigFp0p3vcYi9k93PNjyHJYBnCB96rSvqe490HNlSohb3KQgcfAswndXrYtVp0OhY9HuO2n/r+aNOhOmq7TFWNJalWI/nHDKXA9CFs/7eKXDVm82qrhc49Yq0OmIdYLHQhuRTsj16D4Fv0XRPUM7LxDvbgA5thqeEg5W8zlKjak4Blh7+qkD/tvfH3Y+bYw5R7SijmOOxD69D5k9C5h78AvHBWjX/A14/K4G8bURN6GLxF8Dq+SRvlZXiTNQpSCqaYw1tQ0/T4qWJe6nbzb9TDbU2GgkYwyGwOYqdjP+/VRXOl3K5x/Brvmi6ffuKHKmi4KhaQSgGBAT854tmNKpl2clHm7YE0F5qJtdwDiZHGcPlpTiqhbZUT7KytOZeNOkMCDV2nWjoZOWpKuTMWd0/LqsXgj2Eh7fMjauXmj73rjT5SnHoRAFa8nVnMhimX5Ck0rgg6v3Yd0wv5AOg3yFJ+c0s4HmMBEFsfccPpE+ztcXkM4jgeVHv0jjirh0A5GFlLUy3m4BO3mQBmmBel7PRu5Nm2wrB23dO4OMe7odkg0BD4OSRw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR03MB7001.apcprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(7416014)(376014)(52116014)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NgZ6cCeoYz5pNvVKPr/XDgpy+i4JRTLdQ0zo48IY/rM9+qfUb5LUabD1+ETIOqov8mv4DmCvXa71Wpl58BkkBapIJIbKwoW3XF80OJTwu1cickmejJDmBSmEy6GVw0w28YeQ4VdiYJDO5a/jM0MUy0g0VZxB7LsqvLgIahoGGfM/7mQNMFMTZVJuHYk87dNOzAGHpZSYHICkvdtt7J119yjQK+8sqoaZuZMAgA20yIM6G88Qw/PVRHigwLIdV6VKuOvdDrn/qC0ehfdySMMfxJsxXFiMz1P0o//U66NhaNO+XQgjZlG+V9smzNag1dBrcBdydBn5/16SDn9tYHM+pKb6bAunL91KI1nETXl8N11TU+4Ed88SmwyJEwWoiTFK7HUIOA7gRmhJPwowAjMiDCX699JeylVnffg3mFK+V0Pof8EzggAnBq+VQwKjz0cpFV6oGe3n4lkCJmIa8ITaX2mOg+t5RKTu/+on5BvuRBvfmKjsO/GYXxxOjyR0XDU9Ke10K2fg0eJC849htPPplsigOAI5Jn2c+PzXkZ5aBKJpZ1CkBHKmNU2qwQYpZZOM9voc8FBkAztzHEmsB2j+jJf0WVuBqugNPFPsKrS3zAx7E7/7BVgdZOze2li5kb0nMHrFCNaBudDkciOG33+7h5eozpSOHymn4xlM9pPs9C9Cpu3H20DFzjRu3nw3tBu//B8+4T+ao+K0ljSlStruLzn3q3mxNd+qDIfQk5q2gJOFy9ibaLsD6lR8soG2uRAcmf7d51xDxrMF/Fo1tCn+dO6KegMgQDTu9STb7HuxqDW3uHbr8dBKTc196q8nhQqPiZ/T5NG9U7KhshdCnDKz/kD4xtnXuDELRRm3CUaUznZWSFQPfX1/yiUf4hpan0uhF/GIGgTp51C4dCczuWyk0I+LCZVCOxav+arJbSKYB6BDmGirmXriyUXAUjM/rp0kBAtK3FZYW9yvTpB4sGV6mAUN8GcqaP5PR5cSaEEQSJpsconUIQBL1Nj5c64X8/Xlxqq9L9YYAH1pH0+tIqwDLYOlI2wJ/1PzBPGDJZ8NlL81E12Kf6RuCoNqQls8EbX59xsivejAc3QFcK6Gu5JTgFvzNhPPCsh5DUK3FyoqIQpZeZHlvB/8IbJAyMnk30np0n263ay/+RjHxUZ5n3SYxykGU8xfUTexen9q/w2jpGm2qQ1SsoDd6UUUBNswNxHGcA4gljf32+/Y6o0E0b3rlbLuPsjaF3CmpGOyvzThtjx5fEZKawHrVD8UJcrUJwT4uEIZ/rAHsSxouAEhRw3Hl2dGDnYonaRItd/Geon5IzKtbT1mxInu97u/o7tPGhPdnGUh/sVXbhga2C2mVQMY3TKGPVuIRr4cIoY2n9DgW0ScXfp01nTfgAen1NCsUV+Y87LODFttdL7JmuAoIoRm5APDMDIPMChor0PCbV+mu2waOKxfk+8XVYqOfPng77Ek3CkDYFyAs+Tk6qFGzU2d7QXeqLztz1vgaA3M1gq/MoMBL4i72IFlxLIFvV2RdiqY+yq8YnNAqmhnUbXKk1QYXda4YQoE7O1KIJRbvCRjf5Zz65khHYDj1qFvD8vXU+Z6 X-OriginatorOrg: wesion.com X-MS-Exchange-CrossTenant-Network-Message-Id: 643bac91-6bb4-431a-b6ba-08dcc71472c2 X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB7001.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2024 03:49:42.0164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 2dc3bd76-7ac2-4780-a5b7-6c6cc6b5af9b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BAcA3MxFYtaVlMpAgVelyexRbuK9aHB9U9i/1OzkgaHgTago/zXPrlDGaS0ev/btyCUZiGymmTKBd5SR9AsTfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR03MB8233 It's the device id used by AP6275P which is the Wi-Fi module used by Rockchip's RK3588 evaluation board and also used in some other RK3588 boards. Acked-by: Arend van Spriel Acked-by: Krzysztof Kozlowski Signed-off-by: Jacobe Zang --- .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index e564f20d8f415..2c2093c77ec9a 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -53,6 +53,7 @@ properties: - pci14e4,4488 # BCM4377 - pci14e4,4425 # BCM4378 - pci14e4,4433 # BCM4387 + - pci14e4,449d # BCM43752 reg: description: SDIO function number for the device (for most cases From patchwork Wed Aug 28 03:49:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacobe Zang X-Patchwork-Id: 823514 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2117.outbound.protection.outlook.com [40.107.117.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEE9D13E3EF; Wed, 28 Aug 2024 03:49:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.117.117 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816991; cv=fail; b=mBEUX5uKZ55ocF/c0Rqd/BSjsoNYF9kv/Qxb0/50LkUKm5MS3o//79XaBCVhWbvrbmkJtGvYFUQEcOuzgJA884fmncJ1JqsnZ26S78p4WwU6l0k/E3O7ZPnqbtmNA1N6QSooS7AipQv7cDSC+OZ1fDzdwLFFAyOmEQCQNzZZVJY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816991; c=relaxed/simple; bh=uyVPq0vuS+FMU0odfnlfw0F2eZnLPgwjnpAdPSqAp68=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=WEC+gJbsUfPa568qYbIwT/j2ceWaOsjGiF++1BLUC/nP+7Il9j6DHrwrhUZmA9o5rFYVKWqXYoDIXtRrM9kvT0nbciP5ci8jYUOjiJLiFlEd/6/cE8xaxS0BBGztB1qZq4pJGHgqBYs3jabTUOIqIoFNmiwnyTEMr9YHR9Gv3g4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com; spf=pass smtp.mailfrom=wesion.com; arc=fail smtp.client-ip=40.107.117.117 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wesion.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ob9QoGP1bQl2BVGcpyb8kNsyGQ544PmfFKfWMkf17rHXvCps0nW10aWfkx4Eut9MtN90h7WUnaqegrsdqKWcNSeNi35d2HuK8KDSfE9G8ZBOxI4lng7EOB/UOOWcWYN69Weolv3jDvNbRX0KMSiDItr0lxq/iqBbQz6psbdcdS7JsmmDHW44TrxdPZdjlI4YwYLxnN0OCsril6CWvXKqA0F9Q3rBMe012/o2iTAOtTVTSu4KGe25N657MAj4NOqKtNg3KQ+iWs8r1vmPZ5kk//Z4GAza7Nqql4VV1fgawGLfOXLRDSfP0ia769MqPtdfxHVb5mpZCbP93l5+/ip/XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1iPX8WFIoQ4QXgUD/qR3fD/Finzms7t/FKq4XAi292c=; b=n+oue3eOYIi5Buec04+9ckbBPwWuXGjEqdsZUmqoNCwmJoBPpd2AGv2wno+5zhDNeDRy1lCy4CsG41SY0o97F/avyoC/mkyl5fAymwBGDzP33D5qFmCX9ygQVSJdT9yU3TXywGxbP13+8cPUNxMffTzPzLJCTNcm2ny/IGHop5UY7RNJkIQw7H52MRJspJEd+zSrWogPYbhLMxsGBCOWspAzW0gcrA6T+KVjRRSCVWdaiZvyhbSNM4q9+HrMz9WDZPeSUOWVf8LZx9ALhWZIwhOc2w8I/j3TMxdEXrDGDshkG5uQJrJHKdb3EqMj/YO96CybJrnpu4a4vxDde+y87Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wesion.com; dmarc=pass action=none header.from=wesion.com; dkim=pass header.d=wesion.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wesion.com; Received: from TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) by JH0PR03MB8233.apcprd03.prod.outlook.com (2603:1096:990:46::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.25; Wed, 28 Aug 2024 03:49:47 +0000 Received: from TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0]) by TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0%4]) with mapi id 15.20.7875.019; Wed, 28 Aug 2024 03:49:46 +0000 From: Jacobe Zang To: arend.vanspriel@broadcom.com, kvalo@kernel.org, marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, saikrishnag@marvell.com, megi@xff.cz, bhelgaas@google.com, duoming@zju.edu.cn, minipli@grsecurity.net, yajun.deng@linux.dev, stern@rowland.harvard.edu, gregkh@linuxfoundation.org, christophe.jaillet@wanadoo.fr, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, nick@khadas.com, Jacobe Zang , Krzysztof Kozlowski Subject: [PATCH v12 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Date: Wed, 28 Aug 2024 11:49:12 +0800 Message-Id: <20240828034915.969383-3-jacobe.zang@wesion.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240828034915.969383-1-jacobe.zang@wesion.com> References: <20240828034915.969383-1-jacobe.zang@wesion.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR03MB7001:EE_|JH0PR03MB8233:EE_ X-MS-Office365-Filtering-Correlation-Id: 06c979d7-e463-41d0-bc47-08dcc7147535 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|7416014|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: amDyMtXD2c62yMqBvbOYkatUBg8Ss/C0o54r64rFJ3mOnoQtuUGkhe4if3fnsHrITtOCs519Ec1AzhPCPs1XKCVJJbpHP86dEA9vhNUcdYu/vxKBI7nSjgPvUKFUIFLmuaDt6k7RZXZRt9Bb4YPOqMiHzqV7isuWw/+B5JgfKBvZOa9nGxB2ij5/tK5isFTNjr75TdsG7ZW36gFMCoQnYsh7hzQv4zMKelqz8nBfOuLR9wNHSi6QnFUA77CfqD+3m6iOfzz2h0tWg9EjEWqJqNcujPrS6YwpDAuAhpv1XhWD/mHRpckrfmafY7TYhJfrUdeGOAYi3+KIyJ/l+Vx4gbGyFRJt/67s9FoJNsmIqGfxiU6HH3ds9J0gyNDYiAWQEF2S7Bbgb6SERKZGtqmZ6/Z+TnFXKtSfLGmpHx+xrC9rrjH/tWdq7IVgMy/Sr0lyL2Pcz+6APtKXBwQisT4ID8D4DpTbo8QuJroEejmKBnVvHAJbO3pRD+j4/0FGVKFWmmkOy25shhrL4MLIdxqzYR7TBH0soNRwHQMl7UoNTCKoWwgiwG7vkUqYSpbENRmWkBOY3LMKT63SKp4MpD8lE6gla/EEp/5ZG7FrISxcna+KzvjoNjR/8e/+NonFsxmgtihss/ascjFvvoJJ4LJP6kIpOYaxcHpP90qURgqo3K9nfTxM2FHAjih+yoUOGgAB0vC5XwXmtqS2h4V6rdhJc1mWFx3HVJu3zGXPHbFg3wh9P9TlLECuZV89kvQe2RPOMkA/q9+oftnJGTkPzEC9nET8ddnGbWjaAjzMqgcEGG0Vdl3bFm4IYEmm0eqKLPGZfWkxPyivlmEaKcCp3ar+mptEbPSpjZo9bmKOZ+ku3ur3UgLkeduVpyrhxvoJ7AeVKXxjaZzW1kRBzqsGbyKk8jWgTPhnZ75wAamvAOBDSOWytTZcq3F4ldej1uwuuY0Tce6BTKatLXK8GZfxwdN9Y09kN3H4WTngbkHFSIxhbJKlgnvmNKNu0ysG2HRqRkyXRkM/w3mTBG0ZU4KPwIx7PDc+i0wJyn0Yvi/z9SGC0FNoKqNNO9ZGxgHjcjf9kwPQwNcRRDyYJ7ktQLXsE98EO6PaK83GieLcRVVSAnKh0prtxryUsgltp5HQ8wUodr6K/rKTv3C+uOZgAbPWlE+taK0QfqL7w8sYHbnHnqI3mCN5N6XTS/Vu9OOyvTFEc84T0bjMtDeKdb2+6wHn6XCHmBYBl979X8Cuhfj9A7KzkkG6Apf6ueDr3eZT4nAlyiXYkaHlhK3CfrAohp+b+0akQqeabjv2BYq364Ozotxr84sLQT7uoOPn+1EkOHR9UIEu8iwN1DwmzJ5+cLbAVT4P8irKgXPCFR/TM9yRgy4U8Av/TmsooiYQmD8It2oijsnu499kueoVKANLWD6JiBURlQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR03MB7001.apcprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(7416014)(376014)(52116014)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bO8baC5pSxTt4KonDer7eav9WQa2BITFofH5W7LGaQgIsSh7Wo79IwKLJ1JRkrXtyDCdrmxAB4YxdqSp9CTtwfSYTiJ43fGcAo6zCmq/1j+8pb9YRTYkHmtVremqorQ0DzOZe7wenSV0y8mGMJfsmC6hoxc3elX4klIlwQHnUAFLdpaKUUY1TI7lyyb08OfwwEKXXFSkNa0Mmnc5EFjdzOj1+sg/Lj8++Id5+o0xRxAGmD42SFrCkRUKBsQcfTsU22XlPokjnnzQIz/fpxRLpwPHteJ2qoKg0kEHJccTqt8xq5hp98saU79M2JfsghASk1SUVFVJhia3Q07eRgAK+XLV0RaXAXqk71fcUOlIh67j1JZKxKJvuBgZ5nqOZ3Yqak0ccKRM/GvQWbhgMxZM/IXuB5X0txtPxNWXFSotdN8vqnL21WIOgPCHuJ+dwDqPeucAUEpwyget5Fi92ciceRi7TFlGguHrybSWMMODaFn7wqgP0KlNsF2Qp9Q6TD1DNaTsc4fNja38Lwfh2FbOuSi6n+0wqXRSvm9Z4Qq0ku6X4xNqBSD9waimgqEDjFq7++uDsAwzLBO8KY81S7ZjlqHcmz72upF4KGYBfEeSAIPVWVGqZMVRro4IR51U7ZGdj/we1Xp08uPPtc+niMuIaUwm618YF+MtwVUv0trBcETUqXMiTTshnO+AXGpYAD3J/jX+0gF7oMJv8xl772ploUo3IjuTrBE9nn3uq/qVSFWF5B0LY5oI4xwYzF45BQSoD7PjPZzzfnWImKM7RS2pI0qzMCRNgf0gLgK+GFAcBuT4GHsTJud58FWEbSiHsvKLflwgyxrpHr8ii5Ewimo+eTSjRaQufQkAesaeywrl4TX0IpKyRLt5opjgn9ZouHUyvmDJA/+ojxDAn5Faxhl0mrbJnU7wb1agkghpI1l/6KH0pRGzuOFHZReG8duOY58GqmAAuwSljDh5KxFWcPFXndDm8wN/UvUan0WqbKiwL0TCYlQXfFQEkpPahMLg3z1Mw+0jg/3wB/LZjFoWLvlEUZgK7dONvxheMK9HX9KCeeWSmclzWN9mQbIDd5sw8VycLhRCxLkET04HmuRPsjf3wuLsA0m5USglaq0uQMmMOm9BnKG7iZYgHu9EK98erU0UQv06LSf/XnHWvgrmTZlKhvXdRjPoe6EgFGwSmmhdRJbGjz7JA0ht61NL4+W+RajVvO+wFCqscKIQPg37O3/5eZxNGdpcJRXbQew/9AHQvaS+4U7e25gzLveQRxaJB6W1khaFuE21GCRcP+jOBSZIh07sB/p99WSLfZYLxIHlFuou2+uXNBCsJkJZXALlv9T/8FuBI+JYMzUsJnlsj/7Wguc2bFn1hwJ/lP2/6Nrb5s42m+ABZ37Fbx2CtZpdhIz8S0Y+qHpJy0MuWdggQlb8+XPva9pbzHJyS86vqHIpDa9HlzdRgQQrsyisdzcmi9q897SZqx3BeB3IGBghPf+0PGQvn6pISnkCllQvHe4zRGWO7s8U0KFjkoLgHFJsjGUVdOcjCx4x0Cs5+vZWCE2FlUiDb1KOJ82JwKXtcgXKTZaRV+OQsD3SQSJEie4MKwlb X-OriginatorOrg: wesion.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06c979d7-e463-41d0-bc47-08dcc7147535 X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB7001.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2024 03:49:46.1362 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 2dc3bd76-7ac2-4780-a5b7-6c6cc6b5af9b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 20MEtez0wlVtLtzUlU6WNi+ZzHxd/aGNqGnG4EGdQCOFQmlqDqdgSwcRwHIA6xkEC9H/WjSZBHqzKg7S7wSA9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR03MB8233 Not only AP6275P Wi-Fi device but also all Broadcom wireless devices allow external low power clock input. In DTS the clock as an optional choice in the absence of an internal clock. Reviewed-by: Arend van Spriel Reviewed-by: Krzysztof Kozlowski Signed-off-by: Jacobe Zang --- .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index 2c2093c77ec9a..a3607d55ef367 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -122,6 +122,14 @@ properties: NVRAM. This would normally be filled in by the bootloader from platform configuration data. + clocks: + items: + - description: External Low Power Clock input (32.768KHz) + + clock-names: + items: + - const: lpo + required: - compatible - reg From patchwork Wed Aug 28 03:49:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacobe Zang X-Patchwork-Id: 824401 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2117.outbound.protection.outlook.com [40.107.117.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A606A14BF8A; Wed, 28 Aug 2024 03:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.117.117 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816993; cv=fail; b=dkOAVAF1BWVOIHvE9ZkmOLdb9fYPH1xhqIEKc8Jq5wC1KM5d+ESka+JL6JF0EwXokwltGAF/tO1qalHCZIohsp7xWwFV5K0ftKnszhUzRpy3PzD8lmuJaszZf0rMC9xQbPTL1c2Fsrvh9rnynp77h6H6mFtWe0AklnPoio2o/gg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816993; c=relaxed/simple; bh=SkJCMMdxlPiXHgrU+t4Un0L3oRjoKWUvMNm29UdJmfg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=o0QVSSYh3l58ZhikJrClSYspio/CZzplYTxntzsQC5AxpxGJxo28yIImiCylMXYUXBEWbdnTb79EGcioHWSM2HmrO0PEgg78X90Y50C2b6xnxZ0SPaeriGTlX3t5Iiq2vTsU8OiZZmr8b9kQ5pQy+vPV9t1DCs05ufDpJKOopIw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com; spf=pass smtp.mailfrom=wesion.com; arc=fail smtp.client-ip=40.107.117.117 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wesion.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hutjUKLEXDzS1riJNs3QfUi3oyoEfmgzXsBucSsyeTvzsQEF9BfLKJdJ/0hMQoabji43Xc9eseGJsooQpyqAWOoneaHq4EMkQtQy8yLgd6gdTfZ/v6+YvHJN3FxO4mRc7RApKFhI8zSPNKowfglXnMgqAjDotIf81fPip1CQ6LlnqIq9ZUEahfQEtCwyMyK7Tcp5yBWRt05nHOs7Ax+JZV/350tKm5oCKKTRfJYVJHAmoBGo1xpUJC4Me57lFzkjJ71dWnqxrkC6K/pLIdLG5IQePRsj0P65OqEI8yIR4pNvBnzt3dUYcRLhm4eWh1NsvSEJ7H4ip2vh5rc0uamXdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oTgJ8ZwxW+KugQc0Y9vNTj7zyjU/ry5rYyMRb49SIxk=; b=H+zxmz8yjdiOFttS7DfP1URNk20EdhYlaVql0CATEAPqyXNoDp4lUXAbuGLRiyzTrpfn5XoJKo8BlvNRIbH0P6iC3R2UHInXOHRuSQxp5SX28LE1vVyZaT08f5cLUaN66Hxr2tTb/wVQqtNglXfCE/LA3b45Q0XHivA+lYeQXPNm/J9K+u4i+0kra9Pwf/G9WU5nuZk9KuFMIbVrPiXBpcFuKIOLsBJk0x8iq8GEowanNpnWFXEGgULadWzlaenWMxbrHgrhhPe6r2gYZxaZ45ELkhx8cU1MFJck+KrvJyBEi4cVpKorWXCWBC69imqt8l0z5BkY23pgKQW4RRrYzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wesion.com; dmarc=pass action=none header.from=wesion.com; dkim=pass header.d=wesion.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wesion.com; Received: from TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) by JH0PR03MB8233.apcprd03.prod.outlook.com (2603:1096:990:46::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.25; Wed, 28 Aug 2024 03:49:50 +0000 Received: from TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0]) by TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0%4]) with mapi id 15.20.7875.019; Wed, 28 Aug 2024 03:49:50 +0000 From: Jacobe Zang To: arend.vanspriel@broadcom.com, kvalo@kernel.org, marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, saikrishnag@marvell.com, megi@xff.cz, bhelgaas@google.com, duoming@zju.edu.cn, minipli@grsecurity.net, yajun.deng@linux.dev, stern@rowland.harvard.edu, gregkh@linuxfoundation.org, christophe.jaillet@wanadoo.fr, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, nick@khadas.com, Jacobe Zang Subject: [PATCH v12 3/5] dt-bindings: net: wireless: brcm4329-fmac: change properties enum structure Date: Wed, 28 Aug 2024 11:49:13 +0800 Message-Id: <20240828034915.969383-4-jacobe.zang@wesion.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240828034915.969383-1-jacobe.zang@wesion.com> References: <20240828034915.969383-1-jacobe.zang@wesion.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR03MB7001:EE_|JH0PR03MB8233:EE_ X-MS-Office365-Filtering-Correlation-Id: eb56d1f1-195f-4b61-d6c8-08dcc71477a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|7416014|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: R0pOuRTGUhVbpSr3xT3/Mz1SFSTtvNgAL0nz4bkFh6+cuic7YX+l46lLXwDRmGTQb/wj9Y0S9tiWZCnqPNZqlJAMwg6s408wasn3YzOLndF5UTUdYE0m01cieSMzP8GEWkHodoiirFghJj5ivGBDUXX1KFeDmQzFnDIKv9fj82OOWjP6FZ38ptBz+AoWFwhjjk3qp42VuWDas+3R9bS/5APfV7wGwwQtbPwwuQrNBjjk+Okux2AR/WqwFmiOpvm8VKKX3LhlUkWzL6xGCquG6bFWNnBnpAHKL+FBy/6n7IzMxANFAwufaQezaujHYdlODb2FVw1cPqY/m3iLIPrOhohns++2tWr1B69PXvskbRtT0OZCL0RICOE2OsNgvvirvhcf7t2kI7mACoQY3yYrgQFyNokxwPcILdKSHgzn41h8E+HsIc/538rbvKxny1+U4a13XA5dzEjK9DX3I8BH9gvNDjzgvK3a9McVEyrGJfKpy6p+fKBeNATwIpZBR+Zsaro8LB1YL51DCOgnAEiQo2PORocCthXyxHApogEkdmTEGT8/NNYTSezLH1OTSj798WpGQQMXFELBQFU82mioURisW3wqWZ0PLX1HNaw/YG9He16BZAyv1PQr1zqFbpLAKLQXPH4ZNar/NlfIWOVB3tzx9daUeIosj4KN4X1mKRdU5zu9XXzJBl7GA1sgOcS0mNzhxifSW52s+fcrHwqUX65Hw+IyTRmJ32kAhV0jjSiIJi0gLsXBxY8+QNJgczOSw6auOob1Otp+poMhLn68XpO2m3C54yto6wPvokHRDDtWC4WOkUOxXj+enMRAYKHDtrk1dLO5o6Rz5OoXRevmQTmwc3wvQ/zvY9bf+8d6X1QArSxd5us1OfFa1fIkIA81pG0UcvctkcletpQbyCR6qWuOJzTlbuNKKpx2Vie3lh2QkKwGfhE4l+A3OsgtLGHJnbFIdy0gFilD+01e03ftqHMnKccgQXGKBhur1XhLZRsXqVyoY8o/cALOnkpNDCldU8UuSq8ds8uILIIq/KJLTZ5eMfmIDmuco+d1cg4JygIZgqPsJo2RvYQSdus+sZVW8dCqv17P1Xm+eXiEjcZF2XoM5gxBcYWnucQMA61NEM8gzQmYXQ1HcZ8XaslMrikyM6aTtA4pCo1LFwbenQe9cIjrJ2LJTDYsdePyJ8hdFUVu/PaUMW1cenWzfMOocPiBjnoeI4HaWTyJ4JT0wQvZDdVyb0wEA61M3sCe1Y2Fqi5Q+jppBDGxizEzxLJbiWQH6UcnTySkzxLwVubw//U7PjHPBkblC9JgLpJ9Eaenu8PceGxY4M7q4wYgV0wr2VOXNmhy9D5RLTa8noeYRiEfjFaLRowOK82dDm4GkK2fXg0x9TBt0UeTzhQ25o8Syd3hRPBE8cR2MMWqJo0jhGXfCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR03MB7001.apcprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(7416014)(376014)(52116014)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /aaYBb0icbemNm7AFSNogF4gKp7FhbgmhLK0XD0VErke9FrAG+1ZDnjVBUJwOyQWaL9FkDF0+V6xWTiSLVnsdB5lb8I51mnleaT0QvaZ74qe6qCEq+Bv/qW4Gs1TgwUEHHCru2IKoCR9cfpRDVR2UljYsZVvqt+diDTF4XYgcKzx2sTKX47eMdIPX2uT4ud7eKagjJUFTNQ1zVmiwIJuxFhJSnsJCIOU1G1iMqTRNsXYWcOQ+74ukAA8LwySpxEBIqlqRtqgKnydfYT5UwGytzcn6Cc9n52LBXwJp0I/4qO7/iQRb6Orfacf4GAdBUx+i2Im93V+ceba7m8JRvfRowvD/dUXJ0izBp7fb2DlFtIXN04vYuF3PBzLEoH4jHG5SUGxiwTBoRWMLzWkJwSO2A94x8fqAL0+jEnb3pTqLDs/BsDXKwRcSjWGPyzP9BfS/i+O1VCnD/ycz5j/rqV3M3R/uIuFYKakhYQPi3M2O+j4d4OumeIdZm5ATzMuNN7MOdnj/RTHslfxnjXfiRhsvi2+vylL3z9W9BvnG3tK1dLVE17+tG4YVj+lQGDY00Kz5x0f7Zp/JiOkwVzJkhuDFBkqzoks0FZNW1/2VcQOKpykvuZwKghpty+mSzSEc2gtR2NM185s5VkjO1PfBsRHowxO5xyAhe+oQFt+HazRFFEB9T4X0og4FkUVFLkbKtl/lPScLTj5k7CCPumrA7EQ5wp/XTBb8L5O/k2hvQhMvSCDJjSb0V/gpcn+8iWvzhwpC0ESG+RO/mDgZjsLGad0/96yYbH/amcf72LeebAhAPK/eHF7fWq7UZrIUaO0caViqYh9IujRGObJoD/Px3RVZ6DdLm6sHSdxwiocMeHoFOjQDzCrRSGsF+347IzG7JAFYliCLkmlCP7Pjfkx67o6V+QB90GswMsdCoYMJ4FHFSvtOYloPRYz0DJn5uTBKSrPeAJbgSS0qgKDxXd4Gnh61LQjUBeb+pvxRVEaHY0hI6QB2ZupYwMRUuHjfnXS1JJTmlhFRO8IPEM2qduznFjt0UjhA6Yc+gKHY7YYOoD5l7WHUszV6mcAepdKN2N2+2hRspDeiU/TBI3mMyIq7KUTh54g8LGltJkbo51B5BpId1XcS0fSo37GOb3bDw9pNPs250gtY6QbQAjCYK1rGNi6POHSE+MiLmtDd/H1RjjX4PBCyKrXVQkU1XYxcm4yoliquEybyTDQTDLt0gtU1dh9sKR9xVy4lE7TCOlLvr2GdhJkOYPhOZyojXVfJfK+/c1/mw44z9cWSyJYTGth2L4Ntz31hZl70pY05AZO1nKpTIwJggPoQNqxRRq31al2TE/SANG/Z+GGkLJ4F0ZduOiBcNIAUVwNG0rWp87iGnarWmmgeNbJPj4Ts6+2RUJjMsayd3bMopHZJRdsvfTX189HaRWYDxVKOiMj5z6IhNKqIGEzX+MShbg61EsifIO0lTH1LkEPzGI4C0DrdXp55xfYW7kB4lksh0sxgGOs4o9iA9aYbp/OOr7GII9BaOG5ctGSexOHMXIrF/CzhEHalkvmQO+3kt+wJZnixAYUEehVxtUr9LRwp2DKOnpKyBMTjMQP X-OriginatorOrg: wesion.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb56d1f1-195f-4b61-d6c8-08dcc71477a1 X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB7001.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2024 03:49:50.1301 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 2dc3bd76-7ac2-4780-a5b7-6c6cc6b5af9b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RUKXElNTXU2o1YfiZEUX6QhDVoB8kgad8gOrl1Zj+fyNDnIkW2jx/tU3j8CADOJjcABLuiZCLpbqevzy2huzGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR03MB8233 Add "brcm,bcm4329-fmac" as fallback compatible for wireless devices that used PCI ID based compatible. So that can pass the compatible check in driver. Signed-off-by: Jacobe Zang --- .../net/wireless/brcm,bcm4329-fmac.yaml | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index a3607d55ef367..4870caed5f75e 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -27,7 +27,6 @@ properties: - brcm,bcm4341b0-fmac - brcm,bcm4341b4-fmac - brcm,bcm4341b5-fmac - - brcm,bcm4329-fmac - brcm,bcm4330-fmac - brcm,bcm4334-fmac - brcm,bcm43340-fmac @@ -46,14 +45,17 @@ properties: - cypress,cyw43012-fmac - infineon,cyw43439-fmac - const: brcm,bcm4329-fmac - - enum: - - brcm,bcm4329-fmac - - pci14e4,43dc # BCM4355 - - pci14e4,4464 # BCM4364 - - pci14e4,4488 # BCM4377 - - pci14e4,4425 # BCM4378 - - pci14e4,4433 # BCM4387 - - pci14e4,449d # BCM43752 + - items: + - enum: + - brcm,bcm4329-fmac + - pci14e4,43dc # BCM4355 + - pci14e4,4464 # BCM4364 + - pci14e4,4488 # BCM4377 + - pci14e4,4425 # BCM4378 + - pci14e4,4433 # BCM4387 + - pci14e4,449d # BCM43752 + - const: brcm,bcm4329-fmac + - const: brcm,bcm4329-fmac reg: description: SDIO function number for the device (for most cases From patchwork Wed Aug 28 03:49:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacobe Zang X-Patchwork-Id: 823513 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2101.outbound.protection.outlook.com [40.107.255.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2943A14BF8A; Wed, 28 Aug 2024 03:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.255.101 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816999; cv=fail; b=nKUiL3EfaFu1Hcx4v7jjTKTBzWAeMiWd3WmqV+ObBPrP0nVLrNzQ9t0q46WTliG1ChKymy6RiAZDXu+D5mTN+bHe1zAk9nOvCsswFJMtLKOdRSN4KChjogomZMIKDa0Tced+MJt6LSiyiuvATDODqYJ/AxVBSUgvjkxtTNlItu4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816999; c=relaxed/simple; bh=aQvU1H1bz/roJ9mCuqhAqDEeD+kqdQn4UHfZEiFgd58=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=lSxBmhGHBB1Z1xr7xZ01bpQ2zVtgp7RFR8xl/ENdK4HlteTPlEhAosm17ThcozcI1RKyImQ16GN2VOoQddDOekTVb8OAT1JoJnLr5isphjU75PF06xTEebOOV4die5L6SeS53myUci8KxWnJO9wUqUxxf/Vahq44HHPu7Kpyc2I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com; spf=pass smtp.mailfrom=wesion.com; arc=fail smtp.client-ip=40.107.255.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wesion.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FUmTOkLvHyV65XjPC1+DUbjPigJLFKQkw7g8syq6RhbwH9S3VYcSN3uZpTTfKAhPvC3zwQ2lG+TELRJzZDCAxuhNC8kL2tpCVAmRd7uQj5e/51kB6bHBBU9bGqgVybDSmfezHJICbUOpMrE/Hco7E7gFzHEcn7y3eFGnWJOGRRyw3avnsmHSq7Mbh4q9Biuu++NWshGevarUZi0Qi6SLCvq9xGzSAHX7vpI//QoD4HQKdCmcZ3+2V5TNPqB+7OzI2dh5uQLb8T8g/g8DXFVdV2b6YWW6y9rsSLlgWAbH3UCLbe0Vb9lRTP1Lx2d9eMQDrNePyRrZfgON0kCKB/JxNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AHkiPmTfCGL6lb2qYDJpA+PP5vnYSg9s1MRyJcxUrys=; b=vYhkQCOOibGR2C49jLW7OL5MFIz2Feyb2eMJfrqKPbeOuJHMhhHNACkgc03LZEfA4ibKsgaEt4QgV3BzHKvlFRgDJTb9C+2nmvGsZl9XzGDTGRy6EuxoGpYOrfF4WtegCDT4gKIOLnlIh2j5sIvOIZQseV8yy8FPhkdqRgePLlNBAL9t2LXiU1D1/CTExPbj4Cxbg4EBLcdTv4j1NQrxGLhWj+o2alguzyUVnLcngO4BI77RWZJkIWheGePSbzhuM9/YSJ2zK8JVJBocG4heGwgaMKP9iXWrLwphakMRsvTbEpI6FfJ9BtJsvfBUlaS+M/ocEuLexXI/Yhtmlq3a+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wesion.com; dmarc=pass action=none header.from=wesion.com; dkim=pass header.d=wesion.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wesion.com; Received: from TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) by JH0PR03MB8233.apcprd03.prod.outlook.com (2603:1096:990:46::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.25; Wed, 28 Aug 2024 03:49:54 +0000 Received: from TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0]) by TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0%4]) with mapi id 15.20.7875.019; Wed, 28 Aug 2024 03:49:54 +0000 From: Jacobe Zang To: arend.vanspriel@broadcom.com, kvalo@kernel.org, marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, saikrishnag@marvell.com, megi@xff.cz, bhelgaas@google.com, duoming@zju.edu.cn, minipli@grsecurity.net, yajun.deng@linux.dev, stern@rowland.harvard.edu, gregkh@linuxfoundation.org, christophe.jaillet@wanadoo.fr, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, nick@khadas.com, Jacobe Zang Subject: [PATCH v12 4/5] wifi: brcmfmac: Add optional lpo clock enable support Date: Wed, 28 Aug 2024 11:49:14 +0800 Message-Id: <20240828034915.969383-5-jacobe.zang@wesion.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240828034915.969383-1-jacobe.zang@wesion.com> References: <20240828034915.969383-1-jacobe.zang@wesion.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR03MB7001:EE_|JH0PR03MB8233:EE_ X-MS-Office365-Filtering-Correlation-Id: f54dec6a-39b7-4f45-7eb5-08dcc71479fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|7416014|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: IX79dHDQ7o/S3s+Y8wHvY53C5wHhZqPyaXIS+7EhWbioxu1a/v8kR0MozhcnjT3OrVrTweNGTqEn/JvMuCfHJZs/Oh/LK3c/Jrln7td0p+nMPspl761pmQSRNDn3v7P1khRFPV0j8UQhlommqJryd76h7vLHadMVa9sJRUxGvTSmbSJDG0bc80YldLkB+Ltn6rluBK8f+ykLXE2LCAO+FRlGi/K9NbXbzQRK0ecRH8rByGK2G1EVzKycQQHP4W8f0i5jKq5i1qh1+/lP31TiFbX1lABgrLTMnO1sDMlYv0wXgtUIcbteIlp+rTLECgYBMgbaxg4Qf5QjWQ0s/JaFbSz+IBae8A7Alfs8BKIbsZ8J0VdSOvzU4NhLrK4JmV0Vpn+3RpQqBpwXtuoqSCicQboCdoh9u6Hx8NYQuuWObbv7W8jVTYnQ4hoWoetvCXB3/DZDc//XmtH534XwoVGjowFLM8LHHJlt9Sbjhd+CB1aSAJmjE76EEPDKhW/PQX+fYH4zHEIcbcEsjOgbzcUdTRiiRxiGbao0it8u+tKfg1X3o3as/wvqxHCceI/7KxgUhFD1XabZAtLyfxTwhvzEI7fUqbaMAWuyGK84jGOxTKJVt2F638PJEqWGURTm0oOZH+uWP77uTeqpbA85okx24jz0Tv4cwbk22NRo/EZiu52a5xDueD6KcaYeyknvSHTNqLjrJhohx4lU0kN45vpX24a5E6mXgMMj9W0iCsmLIoTw7pUcuQsaSrePl7AliKf5ofI7jjebV5Pq/ps7xd50RqkXeocKR9ozco90UIdrDryc+y+yF08QTuBbcf1XY65yBH0tiulvsPQQpzL0Wluk4P4ejpQ1jU/zx+oKU7yGkv7dnFERaY+GpR/8Snang4IV/UFNoAfbJtAIuZbmTrNf2U8nGUMgWmhEpIJggDmN34Q2MxnaJih+cvgR77UFPkvyLyv8SGOKF2ubF+QNkXDOMb0S4mdep8RLWipGxN5ceDsTjIW/LG5hRZAWP+RE+rZLoWV0P9HP5viAVX8YV0n4k0cLFA/Vj+cTpn3KmaMbYflVxbBZxy1rtEjf63O0z/KQWjIs/dscxbXxF+q+yaIbTWH7VG16BoTVNFdFAJVryLBer+tJYQrYzvfa8ORzG3X5yZ12mpoy3L9qW1nkX+vTLVbEPpdfO3MLlM+JoJ/pFoubdrEtDqXnYjZYPNoCeAl3NemicgCU4sDDZKO54RoDeCvG+p1XfjJ6UUJPYmHfCtqZSVeznVc4CfMCD9WJcJFpf8t1zPZw+1wrq8sBmIKgHYPEC0H3qsk+rhbdv9ybFE1qFidtWHDm3urQklxGLl8NViOOhguNdfDhSjU5jxm9d3q0wwzV+jq2wfVAAMhj97R4HXfEe79DkySPAZs7L04/AcwXa0PZgxjuKHXakXvdDA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR03MB7001.apcprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(7416014)(376014)(52116014)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9pRJtJLlD88Pf9eyjAXsid6nvY2CfnAHs2vLdwrihqUiV2Mo2/S7/y6gbZn9zzsB1oei7t5bYe9EZ2NwbhA/n3Z63BmQAageWDYoOH3++caG6OcmQhtKFHEVd5B4vXmQA9lZbUb1xvh53j0HmsC840dUmGKUAlT3uzVVTHQ4cZOQUdJt2dqt0uwoHuvKhdPzTJ5MEm8IfzZ8Jgl9aYBLVN8czi89V+gmPJPV7rJL1VYfzBUeSsAEUyzcCRAsC9sEQ/cEiHe3tNsJuNQg4C5MxO+tTf67qre0LBDhzgoLs91a5GNAXypr9sqZm1mWSq1PQ5jbdRCrmjC8N6kRun/LVN7V3aUX9qfPsjjW7fKUtkmipIl5b8474cjPJBKmUk/mgr0dj1HQXi40OtYKcaYDeJiHrTRYTzq1wFCN5NMw3xYtu25SXBQEtzYcIIxpVCdL4w5umLLNFAF5Iko7jUmVDJiOVNo9vuzcsirc7VexL5kUWlOX3FCuQqp960qbLk+TU6kmJcqHjXqLUh/5Rk3D0XMmcexbZDdTw8Bwe4B/tz3ue8wUS0XjXp1LnLpRhXHNIiKQi7+YDz9BJPJkXIHefeVxtlnP4jqbSBbAC+6LeKlkXbbijY20J49baugnEl26d2EQu0QweAUCuTCK+IkHM51B+mJptj6aw0BHaDH44EcK9iYGyUAqs4MDNrO4wBtCj9UO1tX871WTRUbmp+6Kb7wBBIXm/LV8XyoXNVrfrLql38q7d2uJdnl2pBOLG9dinenvrwIqmv8CViTCkftMNhU7ZYEiMqWxWV2/N3zRkrR9gFh/lxG+h0qVs3+IXS7+q3ZguEgJUgsu6ujR5vZc+as+T4XyV+QFz1B2ME5GRNnZQwrVsEsPBpSZlLh/PjfRRunP7ExAhizqyqaVc+XuNRHol/nPne67YmwZ2J5CevlJilj4S0l7jCE1OdyRSQrtJBk6wD2OmLaTpsg2i/AHfblhSHAu+GoKuro1zJafjuUvNcv2u3Ym77q+newFdMlLKFtnE6OlUhLsKIhgvOCn9JeAlgs2HU2SNl51tKCtl3DLtt0dwgm9uhb20lPIxWTCZgyTLVpWQLHIMd2LlS0FPa6/LYfY9wNJz2+rUZBjSds+LkJSGdNd/8zWpDDuUKFFHq8/noXUA3wBUrQmujNrySb7FHtUkJWvbPq6sU2rb0K8Lf+j87EzVRaW4DCFBHvN369GQlPeu6al/WroWRkiaEt8Lno2Dt9iWzJvL5GEshYniJqbbJrnlU9Jsbijp+fWt7TWDPTZeGySOvkgFdC1ctxtdEXpOzKXFY1VLpSt13klHbnDlwK+CgsPwuxpnttatGfsUcEuowHmQnWLWZqlDCpFbL+VD5HJcSxcueVZ437COeaF/Kmspk5oTgU87E1dYwANbcIvS6G5JYJKIPHHwuLjTH++YAhCqjj9EwbknJrUKG22ObgwTSkWotpqX2drgQ++o4zd1Upxf4vRulF8ww3GQ3xDX+SJHkZsPqWqiOp/UNK8HXIVV0JHrxC5Spe01fmG5uL+gPBqfCHbZCUv2lGzuUHibJ5Pp/s4RzQEU3HUnuQpIy3yuvpeJGD/igB/ X-OriginatorOrg: wesion.com X-MS-Exchange-CrossTenant-Network-Message-Id: f54dec6a-39b7-4f45-7eb5-08dcc71479fa X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB7001.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2024 03:49:54.0683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 2dc3bd76-7ac2-4780-a5b7-6c6cc6b5af9b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hcIocNrlTPfVzqi7ct1kOZ7qG0fqtmL/PQ9OTluEQiGbI+4eLmklWhShPEnrHnGoOseltk7diHr9qtYfvB2xjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR03MB8233 WiFi modules often require 32kHz clock to function. Add support to enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check to the top of brcmf_of_probe. Change function prototypes from void to int and add appropriate errno's for return values that will be send to bus when error occurred. Co-developed-by: Ondrej Jirman Signed-off-by: Ondrej Jirman Co-developed-by: Arend van Spriel Signed-off-by: Arend van Spriel Reviewed-by: Sai Krishna Signed-off-by: Jacobe Zang --- .../broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 +-- .../broadcom/brcm80211/brcmfmac/common.c | 3 +- .../wireless/broadcom/brcm80211/brcmfmac/of.c | 29 +++++++++++++------ .../wireless/broadcom/brcm80211/brcmfmac/of.h | 9 +++--- .../broadcom/brcm80211/brcmfmac/pcie.c | 3 ++ .../broadcom/brcm80211/brcmfmac/sdio.c | 20 ++++++++----- .../broadcom/brcm80211/brcmfmac/usb.c | 3 ++ 7 files changed, 48 insertions(+), 23 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c index d35262335eaf7..17f6b33beabd8 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c @@ -947,8 +947,8 @@ int brcmf_sdiod_probe(struct brcmf_sdio_dev *sdiodev) /* try to attach to the target device */ sdiodev->bus = brcmf_sdio_probe(sdiodev); - if (!sdiodev->bus) { - ret = -ENODEV; + if (IS_ERR(sdiodev->bus)) { + ret = PTR_ERR(sdiodev->bus); goto out; } brcmf_sdiod_host_fixup(sdiodev->func2->card->host); diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c index b24faae35873d..58d50918dd177 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c @@ -561,7 +561,8 @@ struct brcmf_mp_device *brcmf_get_module_param(struct device *dev, if (!found) { /* No platform data for this device, try OF and DMI data */ brcmf_dmi_probe(settings, chip, chiprev); - brcmf_of_probe(dev, bus_type, settings); + if (brcmf_of_probe(dev, bus_type, settings) == -EPROBE_DEFER) + return ERR_PTR(-EPROBE_DEFER); brcmf_acpi_probe(dev, bus_type, settings); } return settings; diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c index fe4f657561056..c1285adabf72b 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include "debug.h" @@ -65,18 +66,22 @@ static int brcmf_of_get_country_codes(struct device *dev, return 0; } -void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, - struct brcmf_mp_device *settings) +int brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, + struct brcmf_mp_device *settings) { struct brcmfmac_sdio_pd *sdio = &settings->bus.sdio; struct device_node *root, *np = dev->of_node; struct of_phandle_args oirq; + struct clk *clk; const char *prop; int irq; int err; u32 irqf; u32 val; + if (!np || !of_device_is_compatible(np, "brcm,bcm4329-fmac")) + return 0; + /* Apple ARM64 platforms have their own idea of board type, passed in * via the device tree. They also have an antenna SKU parameter */ @@ -106,7 +111,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, board_type = devm_kstrdup(dev, tmp, GFP_KERNEL); if (!board_type) { of_node_put(root); - return; + return 0; } strreplace(board_type, '/', '-'); settings->board_type = board_type; @@ -114,33 +119,39 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, of_node_put(root); } - if (!np || !of_device_is_compatible(np, "brcm,bcm4329-fmac")) - return; - err = brcmf_of_get_country_codes(dev, settings); if (err) brcmf_err("failed to get OF country code map (err=%d)\n", err); of_get_mac_address(np, settings->mac); + clk = devm_clk_get_optional_enabled(dev, "lpo"); + if (IS_ERR(clk)) + return PTR_ERR(clk); + + brcmf_dbg(INFO, "%s LPO clock\n", clk ? "enable" : "no"); + clk_set_rate(clk, 32768); + if (bus_type != BRCMF_BUSTYPE_SDIO) - return; + return 0; if (of_property_read_u32(np, "brcm,drive-strength", &val) == 0) sdio->drive_strength = val; /* make sure there are interrupts defined in the node */ if (of_irq_parse_one(np, 0, &oirq)) - return; + return 0; irq = irq_create_of_mapping(&oirq); if (!irq) { brcmf_err("interrupt could not be mapped\n"); - return; + return 0; } irqf = irqd_get_trigger_type(irq_get_irq_data(irq)); sdio->oob_irq_supported = true; sdio->oob_irq_nr = irq; sdio->oob_irq_flags = irqf; + + return 0; } diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.h index 10bf52253337e..ae124c73fc3b7 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.h +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.h @@ -3,11 +3,12 @@ * Copyright (c) 2014 Broadcom Corporation */ #ifdef CONFIG_OF -void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, - struct brcmf_mp_device *settings); +int brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, + struct brcmf_mp_device *settings); #else -static void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, - struct brcmf_mp_device *settings) +static int brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, + struct brcmf_mp_device *settings) { + return 0; } #endif /* CONFIG_OF */ diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index ce482a3877e90..190e8990618c5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -2452,6 +2452,9 @@ brcmf_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *id) ret = -ENOMEM; goto fail; } + ret = PTR_ERR_OR_ZERO(devinfo->settings); + if (ret < 0) + goto fail; bus = kzalloc(sizeof(*bus), GFP_KERNEL); if (!bus) { diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index 1461dc453ac22..59c77645e2183 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -3943,7 +3943,7 @@ static const struct brcmf_buscore_ops brcmf_sdio_buscore_ops = { .write32 = brcmf_sdio_buscore_write32, }; -static bool +static int brcmf_sdio_probe_attach(struct brcmf_sdio *bus) { struct brcmf_sdio_dev *sdiodev; @@ -3953,6 +3953,7 @@ brcmf_sdio_probe_attach(struct brcmf_sdio *bus) u32 reg_val; u32 drivestrength; u32 enum_base; + int ret = -EBADE; sdiodev = bus->sdiodev; sdio_claim_host(sdiodev->func1); @@ -4001,8 +4002,9 @@ brcmf_sdio_probe_attach(struct brcmf_sdio *bus) BRCMF_BUSTYPE_SDIO, bus->ci->chip, bus->ci->chiprev); - if (!sdiodev->settings) { + if (IS_ERR_OR_NULL(sdiodev->settings)) { brcmf_err("Failed to get device parameters\n"); + ret = PTR_ERR_OR_ZERO(sdiodev->settings); goto fail; } /* platform specific configuration: @@ -4071,7 +4073,7 @@ brcmf_sdio_probe_attach(struct brcmf_sdio *bus) /* allocate header buffer */ bus->hdrbuf = kzalloc(MAX_HDR_READ + bus->head_align, GFP_KERNEL); if (!bus->hdrbuf) - return false; + return -ENOMEM; /* Locate an appropriately-aligned portion of hdrbuf */ bus->rxhdr = (u8 *) roundup((unsigned long)&bus->hdrbuf[0], bus->head_align); @@ -4082,11 +4084,11 @@ brcmf_sdio_probe_attach(struct brcmf_sdio *bus) if (bus->poll) bus->pollrate = 1; - return true; + return 0; fail: sdio_release_host(sdiodev->func1); - return false; + return ret; } static int @@ -4452,7 +4454,9 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev) /* Allocate private bus interface state */ bus = kzalloc(sizeof(*bus), GFP_ATOMIC); if (!bus) + ret = -ENOMEM; goto fail; + } bus->sdiodev = sdiodev; sdiodev->bus = bus; @@ -4467,6 +4471,7 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev) dev_name(&sdiodev->func1->dev)); if (!wq) { brcmf_err("insufficient memory to create txworkqueue\n"); + ret = -ENOMEM; goto fail; } brcmf_sdiod_freezer_count(sdiodev); @@ -4474,7 +4479,8 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev) bus->brcmf_wq = wq; /* attempt to attach to the dongle */ - if (!(brcmf_sdio_probe_attach(bus))) { + ret = brcmf_sdio_probe_attach(bus); + if (ret < 0) { brcmf_err("brcmf_sdio_probe_attach failed\n"); goto fail; } @@ -4546,7 +4552,7 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev) fail: brcmf_sdio_remove(bus); - return NULL; + return ERR_PTR(ret); } /* Detach and free everything */ diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c index 8afbf529c7450..2821c27f317ee 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c @@ -1272,6 +1272,9 @@ static int brcmf_usb_probe_cb(struct brcmf_usbdev_info *devinfo, ret = -ENOMEM; goto fail; } + ret = PTR_ERR_OR_ZERO(devinfo->settings); + if (ret < 0) + goto fail; if (!brcmf_usb_dlneeded(devinfo)) { ret = brcmf_alloc(devinfo->dev, devinfo->settings); From patchwork Wed Aug 28 03:49:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacobe Zang X-Patchwork-Id: 824400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2123.outbound.protection.outlook.com [40.107.215.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 702F0155C8C; Wed, 28 Aug 2024 03:50:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.215.123 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724817003; cv=fail; b=ACgy/qAA/RDg8HhKB2/uh8W5ONYsaQQi6nppQyzey9z2j5+4sXJSQlLYqPSWFVeYfvNCaCr8TJFfATsUXTvVRByslqp9Iqn1/tUyF3JtAL/BVLZhsyAUznXayjEngMBtmtCI2F/Pobi/rU/X+VLN/4ybwbRyC+158+9QVwUUiMw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724817003; c=relaxed/simple; bh=IxE5Om0KesCF9OD2iKf9/48PjNYY0p8Qn/cbFbUhE2Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Dp9DkTvtgh6/18MFrEkz2Jgj2Us4CGfs2fCIRDcse8tc+qT2hq6J8rnxlgqrytw1NnjkHQgmCYqU7tAKyQrxGwid4nz1WvMdwBLAaT/TUZUdKSzNn58v29+6dTAcDQBvzVEeNZUS33FbQrSyfm4oUX8kv13Y7A160sEWc6xh+tk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com; spf=pass smtp.mailfrom=wesion.com; arc=fail smtp.client-ip=40.107.215.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wesion.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wesion.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MwBi63me65PG+mxptmfV9dZJpXeYvgiQ+znR+Gn5zsjUo9kM1ci+6XcMVerFHVUMdbencm3EA7p99JZFdCSOgQBygcTz0DW2jbjq/U9O62jx5nG+WbNBC5iad6nxOGCwoGALf1M+qRQWOAmnNNG/Lr3P99jJMwOU8FOoHPuvkTSuXu2rVtJfmsJxM2j0F0cPYB4dKjElYR0nJSfuDWW2bCUHegUmSQfVyMxSTnpx7/+sn2sTPsgOG6d2ZuUYi8KbRFrGVK2c90P8gMpRyScDUpkASIkRJfHyoP9ReSrhmvVz83e60NUHSYe6gG/YKkClqc8Az69z0IB7fTQHtdqoVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5LRnI0UH7UZG4g9HkC23GXGUDdkH4KVjXqUKx9S3KmM=; b=K9PJPE95zzTn1ie8a28g4QF0Di9rMJFvTgf9qjt3r+U6S4jPWxAuWlbCeTU2pUcettuocLEflFRhynO0nhtaLv5ckD4ApBH0sj77A0BXV9ctZ8tPMykN13WR+GmoiyHqE7d0B43Yp+CC/N1n/CrfLUJiaoPMQ9XsjKJQgIT3uhx05UUzDjEkbdzafTxNo0yon8qDlmrQSH12LD2l1nRZiKx2kKMHNigodQhZYXxAFeB0ptWjGcv4Q721RsiznsXsVEmmrr7OrIuKFrhMxSa5U7YK+4PTQkmCTqaAHbitz9pWK0uC8X7xqapc1HJwWHorLF7+pG/ZCNQokdArSCVvTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wesion.com; dmarc=pass action=none header.from=wesion.com; dkim=pass header.d=wesion.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wesion.com; Received: from TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) by JH0PR03MB8233.apcprd03.prod.outlook.com (2603:1096:990:46::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.25; Wed, 28 Aug 2024 03:49:58 +0000 Received: from TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0]) by TYZPR03MB7001.apcprd03.prod.outlook.com ([fe80::78dd:5e68:1a9c:36c0%4]) with mapi id 15.20.7875.019; Wed, 28 Aug 2024 03:49:58 +0000 From: Jacobe Zang To: arend.vanspriel@broadcom.com, kvalo@kernel.org, marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, saikrishnag@marvell.com, megi@xff.cz, bhelgaas@google.com, duoming@zju.edu.cn, minipli@grsecurity.net, yajun.deng@linux.dev, stern@rowland.harvard.edu, gregkh@linuxfoundation.org, christophe.jaillet@wanadoo.fr, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, nick@khadas.com, Jacobe Zang Subject: [PATCH v12 5/5] wifi: brcmfmac: add flag for random seed during firmware download Date: Wed, 28 Aug 2024 11:49:15 +0800 Message-Id: <20240828034915.969383-6-jacobe.zang@wesion.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240828034915.969383-1-jacobe.zang@wesion.com> References: <20240828034915.969383-1-jacobe.zang@wesion.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To TYZPR03MB7001.apcprd03.prod.outlook.com (2603:1096:400:26a::14) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR03MB7001:EE_|JH0PR03MB8233:EE_ X-MS-Office365-Filtering-Correlation-Id: 255f8a2a-c5cc-4898-b751-08dcc7147ca1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|7416014|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: Fb7vNPIOQdKny5Wn8QuqCeMMuQg6Ac+1zGoGTwIp4XRka7CKwj1dq93TxkW25GrOi5Q++U8R8Zdj5G6vfH9sEdnBnV8hIJa1Z2yc6k6+jYNL7opfh3OxkiebOBxJkwKJjSNMn6pUolKx0W38W8DipdQ+Mynq6/41K/TXcJdQzR4x7SQ4C7do7l37Y0ksXbkEIpEmg1HUiiNzpibz/ziisD3K4X9Kv9D0EKn9pzALQz7Ph9G8hUV2V8pSLh+GZnj9GTL/PmKKudsz9stdM+G2xGmqM2CtPfH9UwzpOX4+HuEs5blWMA+/IvTiEE7b16YwFcLGq9wVYuNKydufrvRXJUtwLsFmize8eywZtENMK8RmaSer9mkGOsqGm40WTFhreObqX3DRJvVWm7rSXEQu4VcWwmEnMr4Fja1fmTz5chH5o4nJEgLLqJC/VIhjBI2txBVjl4BbRYSWDCTNluQWVxX4MKl6lFPqCTx5WQJJHqYxFH3oKVKIxqmV+dTQb0LQc0jEnnhTYgMvYrGuuuBXi2+nqHnQrOZT1+R2GY9ZnHreB4HCwMHlR6ph5jU2nE1y3R+8S4//Egka4RAXl2IXc2Sti46zpBPenyM1izoPRzEDRzCZdSwUq+A8aP3i6zq9q3cJEaBy94P9lP81Rx1T4fDBWfd/yVR/DaMH2O/SiVZG4bxB7EbeBelGrmpMXhi65jy6hR+7oe7UxPVZ39H+sQ7wyApbNegG3/jIPYHVLPdQlSO9BG1hJWGbiT820tYwLhpta9YKmM7/gFzD/mWXkwIbkgvK1cJRz/pS9WXfTGtElEgXktNazzskdjHnr4RzfkytAAjqVgVSJM4SEUuwuZcxsewYBe5ySMYSjPOyYEbUKejP5TK+1utEqSk+SDjPi4hYbINvskhPDjXA17kkzIHZ19Eem5fDB0QRjrIKfyg//t3oVZw48eafBlJ/0SqL8AozZUeQe8x4vEa5m88uG0/gsaAdXKO0UKbYCOwKWgRchPvbjWpzrScssUI4ppZImNBC/w02jeOdxjD1jqenNHKaTH9lVfbPbp1ix9l9Bs0TP8BGzCLzRaiTM2stmMv7Aglg8tMsmUczd6GA3FQfN7CCflf689k5foTlAqQHTgu02pppEmMw1hdu/dd8MV1csYbh2ZxAXIX14BPT360s44cfMUdRSVISLw3MUVWdWDCKmICaUPBeDB5eBsJktG1P6GaTd6to6VjUPwuakVD970/IVS8O8kDDq1hA8MVDn9hG5M5WSd797ZvaWZAQXiZkBhFawlu58caOOyI3/JhhyCZVqxTI3z9HLtHC8iw6kUc3fhETrEJjSoPXrIVB+vlIdie+GXVS7n1Aej1CfTXB/uu64P5H+s1JCcZK+yLIbcuIadfdlN07GwKsptRQoNx0siv0iceqzd9iNzLhP9ITrw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR03MB7001.apcprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(7416014)(376014)(52116014)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fbI6SneXKVEL49FDFcw5h+Ga52EyeK6vFaCIq6/chMT3auK59pE2or9z6+lAbNbjHMpyUwpiEvIxdH6o6YcqVjqX+vuNnlLVfrRCtIkqTmlDNTpSsDOOWXUjzVyAWUd5WjO8EigiIA9xttWuzNKMl6tJ245GrFnH66vpwWtrrHER68qM44zxlT62+Jx5Wfd7ehDmhSlseqTv3uRECJAWon+qHGllor0zOUfeWX/acGuF2U1uZAeGxxTQKOe06MB2ZmN0VTI88qnUfN80pSmaSrogHSYWJFd371UagER5j+Oh7IR1nzSqKHFY/ihmXRl2HBN0r7GMXqJQ5/WuYEpUMXwdB698c8/nUMzmfzCD2aLsOySKY4GFSePu1VHwJV7MHqlKBD4mAVd1uffgTRWFWPohmSOXcjiCK1SSUpUcLqAL70HtgJ433k3z2TkghZLIEqdYlI4TlZhfnnjtExuN5e3YatnfBqBw2L7kcD/lFL9qYgnLOx2dWdChJK/IjY0ddCjBwnipJeE1iWwhweiv/xw4C8bIaJkH9NJZvkCPkc63RdkLl+S0OQe6AlLUKfJcEeILXZx4CEBeXgdZPEO6r+Cq4FS5tlp7I7UT+FrB2IwWQFTY5LVUV6jFrXS8+s5lk8QoOrLJghziP2XK15w5aw4WxWWIgTJDudYIzxiYUKvNddhG9iCW+Uk5ibVw8IJPYXNE8xIKQruBP6dHD3tMhKh2bBrejoMS3myiwWxLBGslKP3NscjbkzZbDZ+K9ZyBlgSJrdHRT9VBcTlXZP42lJvCQGJJJoaXq7VPxigH2hXKMTpMpvM2k3gbqwqCr4RByAxPYN0+mNpNcKD2/w0IdzKDncDzaChPmvpdnTcNCfChPrXuBRbrAvZlTViIvjm54sL0+vHscZn0BZZTIOXfwaMeyPS/09118izfQluYeal3BL3vLgGiIdUzI2h4gtbpYKG4mEb8m6YhUoblDOBVp17lZrsqLC7PZ2VeZS5R9RkEsVxVpxS8CjJKDY5bSo4CzsBVSxHurasd4lOCH/q3DZ1ECrG6GnABm/8pE2pDKSiVUVS9rQPxpSWEw23bGeyhMrpQAL8AU223QVh7VJGz7DJjzRmCqPHEkCKGSFzebaT9UNAjlAF0XSTt8IRSdCYO85nKE2cN4NBUX02SpzZywiVpUuCS0C6ArWhah0tOid+a0GoYImhB5R082ehksNjyjg17tc3phsymXBh4MgD5Gvu9D8HLQu6KQtfjKbjrrdZITrycOdhpxvjyxZLnwNrLjRi+klL4phrlKKjIyxgjNuq3boG/JrLcZOzenU1h/2hPRa5fvIYOjgp/xp9qCLBWPiJ8xK2qP9ryLuqTmlliHjS9AqWgqCOZtIbhHiMW1kf+0UqNeUVCMpupSFWdgwjo3cu/IHjkjRpX1TfEab3ynvzXEv5l3XIWHJZ/qvVuFOJBU88RMzMtiZ2A1EBFmR+O+608zfYDIRR8nLkur+XsSQolfkJhtMGPryLAgBAeFJdPr/p+Yt2y8Nt7gOoFJS01P8LFFwpSQb3PLkXYDeY0YH1z8wKYMpwT9D78CAIrrboXZoGv2dhJRUguuzSLHA2y X-OriginatorOrg: wesion.com X-MS-Exchange-CrossTenant-Network-Message-Id: 255f8a2a-c5cc-4898-b751-08dcc7147ca1 X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB7001.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2024 03:49:58.5196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 2dc3bd76-7ac2-4780-a5b7-6c6cc6b5af9b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tP6UGpVWV5a7j09RQfao4Yv0+EADFvZfoZnztkzaCLBrwX5J2TYOCbYjlPsuZkRMjhl9iDDjb59LWPgQiBoCwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR03MB8233 Providing the random seed to firmware was tied to the fact that the device has a valid OTP, which worked for some Apple chips. However, it turns out the BCM43752 device also needs the random seed in order to get firmware running. Suspect it is simply tied to the firmware branch used for the device. Introducing a mechanism to allow setting it for a device through the device table. Co-developed-by: Ondrej Jirman Signed-off-by: Ondrej Jirman Co-developed-by: Arend van Spriel Signed-off-by: Arend van Spriel Signed-off-by: Jacobe Zang --- .../broadcom/brcm80211/brcmfmac/pcie.c | 52 ++++++++++++++++--- .../broadcom/brcm80211/include/brcm_hw_ids.h | 2 + 2 files changed, 46 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index 190e8990618c5..c0fdaa4dceda4 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -66,6 +66,7 @@ BRCMF_FW_DEF(4365C, "brcmfmac4365c-pcie"); BRCMF_FW_DEF(4366B, "brcmfmac4366b-pcie"); BRCMF_FW_DEF(4366C, "brcmfmac4366c-pcie"); BRCMF_FW_DEF(4371, "brcmfmac4371-pcie"); +BRCMF_FW_CLM_DEF(43752, "brcmfmac43752-pcie"); BRCMF_FW_CLM_DEF(4377B3, "brcmfmac4377b3-pcie"); BRCMF_FW_CLM_DEF(4378B1, "brcmfmac4378b1-pcie"); BRCMF_FW_CLM_DEF(4378B3, "brcmfmac4378b3-pcie"); @@ -104,6 +105,7 @@ static const struct brcmf_firmware_mapping brcmf_pcie_fwnames[] = { BRCMF_FW_ENTRY(BRCM_CC_43664_CHIP_ID, 0xFFFFFFF0, 4366C), BRCMF_FW_ENTRY(BRCM_CC_43666_CHIP_ID, 0xFFFFFFF0, 4366C), BRCMF_FW_ENTRY(BRCM_CC_4371_CHIP_ID, 0xFFFFFFFF, 4371), + BRCMF_FW_ENTRY(BRCM_CC_43752_CHIP_ID, 0xFFFFFFFF, 43752), BRCMF_FW_ENTRY(BRCM_CC_4377_CHIP_ID, 0xFFFFFFFF, 4377B3), /* revision ID 4 */ BRCMF_FW_ENTRY(BRCM_CC_4378_CHIP_ID, 0x0000000F, 4378B1), /* revision ID 3 */ BRCMF_FW_ENTRY(BRCM_CC_4378_CHIP_ID, 0xFFFFFFE0, 4378B3), /* revision ID 5 */ @@ -353,6 +355,7 @@ struct brcmf_pciedev_info { u16 value); struct brcmf_mp_device *settings; struct brcmf_otp_params otp; + bool fwseed; #ifdef DEBUG u32 console_interval; bool console_active; @@ -1715,14 +1718,14 @@ static int brcmf_pcie_download_fw_nvram(struct brcmf_pciedev_info *devinfo, memcpy_toio(devinfo->tcm + address, nvram, nvram_len); brcmf_fw_nvram_free(nvram); - if (devinfo->otp.valid) { + if (devinfo->fwseed) { size_t rand_len = BRCMF_RANDOM_SEED_LENGTH; struct brcmf_random_seed_footer footer = { .length = cpu_to_le32(rand_len), .magic = cpu_to_le32(BRCMF_RANDOM_SEED_MAGIC), }; - /* Some Apple chips/firmwares expect a buffer of random + /* Some chips/firmwares expect a buffer of random * data to be present before NVRAM */ brcmf_dbg(PCIE, "Download random seed\n"); @@ -2394,6 +2397,37 @@ static void brcmf_pcie_debugfs_create(struct device *dev) } #endif +struct brcmf_pcie_drvdata { + enum brcmf_fwvendor vendor; + bool fw_seed; +}; + +enum { + BRCMF_DRVDATA_CYW, + BRCMF_DRVDATA_BCA, + BRCMF_DRVDATA_WCC, + BRCMF_DRVDATA_WCC_SEED, +}; + +static const struct brcmf_pcie_drvdata drvdata[] = { + [BRCMF_DRVDATA_CYW] = { + .vendor = BRCMF_FWVENDOR_CYW, + .fw_seed = false, + }, + [BRCMF_DRVDATA_BCA] = { + .vendor = BRCMF_FWVENDOR_BCA, + .fw_seed = false, + }, + [BRCMF_DRVDATA_WCC] = { + .vendor = BRCMF_FWVENDOR_WCC, + .fw_seed = false, + }, + [BRCMF_DRVDATA_WCC_SEED] = { + .vendor = BRCMF_FWVENDOR_WCC, + .fw_seed = true, + }, +}; + /* Forward declaration for pci_match_id() call */ static const struct pci_device_id brcmf_pcie_devid_table[]; @@ -2475,9 +2509,10 @@ brcmf_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *id) bus->bus_priv.pcie = pcie_bus_dev; bus->ops = &brcmf_pcie_bus_ops; bus->proto_type = BRCMF_PROTO_MSGBUF; - bus->fwvid = id->driver_data; bus->chip = devinfo->coreid; bus->wowl_supported = pci_pme_capable(pdev, PCI_D3hot); + bus->fwvid = drvdata[id->driver_data].vendor; + devinfo->fwseed = drvdata[id->driver_data].fw_seed; dev_set_drvdata(&pdev->dev, bus); ret = brcmf_alloc(&devinfo->pdev->dev, devinfo->settings); @@ -2663,14 +2698,14 @@ static const struct dev_pm_ops brcmf_pciedrvr_pm = { BRCM_PCIE_VENDOR_ID_BROADCOM, (dev_id), \ PCI_ANY_ID, PCI_ANY_ID, \ PCI_CLASS_NETWORK_OTHER << 8, 0xffff00, \ - BRCMF_FWVENDOR_ ## fw_vend \ + BRCMF_DRVDATA_ ## fw_vend \ } #define BRCMF_PCIE_DEVICE_SUB(dev_id, subvend, subdev, fw_vend) \ { \ BRCM_PCIE_VENDOR_ID_BROADCOM, (dev_id), \ (subvend), (subdev), \ PCI_CLASS_NETWORK_OTHER << 8, 0xffff00, \ - BRCMF_FWVENDOR_ ## fw_vend \ + BRCMF_DRVDATA_ ## fw_vend \ } static const struct pci_device_id brcmf_pcie_devid_table[] = { @@ -2698,9 +2733,10 @@ static const struct pci_device_id brcmf_pcie_devid_table[] = { BRCMF_PCIE_DEVICE(BRCM_PCIE_4366_5G_DEVICE_ID, BCA), BRCMF_PCIE_DEVICE(BRCM_PCIE_4371_DEVICE_ID, WCC), BRCMF_PCIE_DEVICE(BRCM_PCIE_43596_DEVICE_ID, CYW), - BRCMF_PCIE_DEVICE(BRCM_PCIE_4377_DEVICE_ID, WCC), - BRCMF_PCIE_DEVICE(BRCM_PCIE_4378_DEVICE_ID, WCC), - BRCMF_PCIE_DEVICE(BRCM_PCIE_4387_DEVICE_ID, WCC), + BRCMF_PCIE_DEVICE(BRCM_PCIE_4377_DEVICE_ID, WCC_SEED), + BRCMF_PCIE_DEVICE(BRCM_PCIE_4378_DEVICE_ID, WCC_SEED), + BRCMF_PCIE_DEVICE(BRCM_PCIE_4387_DEVICE_ID, WCC_SEED), + BRCMF_PCIE_DEVICE(BRCM_PCIE_43752_DEVICE_ID, WCC_SEED), { /* end: all zeroes */ } }; diff --git a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h index 44684bf1b9acc..c1e22c589d85e 100644 --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h @@ -52,6 +52,7 @@ #define BRCM_CC_43664_CHIP_ID 43664 #define BRCM_CC_43666_CHIP_ID 43666 #define BRCM_CC_4371_CHIP_ID 0x4371 +#define BRCM_CC_43752_CHIP_ID 43752 #define BRCM_CC_4377_CHIP_ID 0x4377 #define BRCM_CC_4378_CHIP_ID 0x4378 #define BRCM_CC_4387_CHIP_ID 0x4387 @@ -94,6 +95,7 @@ #define BRCM_PCIE_4366_5G_DEVICE_ID 0x43c5 #define BRCM_PCIE_4371_DEVICE_ID 0x440d #define BRCM_PCIE_43596_DEVICE_ID 0x4415 +#define BRCM_PCIE_43752_DEVICE_ID 0x449d #define BRCM_PCIE_4377_DEVICE_ID 0x4488 #define BRCM_PCIE_4378_DEVICE_ID 0x4425 #define BRCM_PCIE_4387_DEVICE_ID 0x4433