From patchwork Fri Sep 6 16:14:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 826197 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 784FA1D0DC3 for ; Fri, 6 Sep 2024 16:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725639312; cv=none; b=TS9cQSOsXZExLkR0aE3xDinoI0AMldAXBKyiLpupzxsw71PvGJ1P6jNIoKctNbpqeiJa3gwaElYTWObLID5o1M5XXJk+vnRF4Nbvsn1GpMcuf5Q8cy7hMJlL2DECAhJOWM2i2Si/JoWYMIUfNYa3EPfbXctWSkrNO5o/0nRGTKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725639312; c=relaxed/simple; bh=Z30ieLDM06mHqkwlhFkl2a4vKxiH7HFPI0x22ElrwLA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JLwQIqKN3X7HUHeoerP2P0nhySntPqTu2/AvKiBSqQlyblQ7B2IXedKsLXpcrxJTA8bywBCUl5iLJKR57X1dQklAWaMz33hd7qWW1iB+dOdxOmkqHjk6GfP/pviXjjlbMhn9jzLRZF7AtsSESSCjtm8QO1v7jNuuqiTf+J/BZyw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=uJaLkb2t; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="uJaLkb2t" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-718d985b6bbso695821b3a.2 for ; Fri, 06 Sep 2024 09:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725639310; x=1726244110; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M23QSkkmj0U8+DRFhBewDD71q06y3alOAwKMp01rg4o=; b=uJaLkb2tAACQZZyj8dYypx4sSVTMYxHapD2G7fqxdgRRB2XIf3LopVRDVPSV2lBjYP GIk3xj77wBsLeytvH7gOBHNfyGbgdVRTNX300DqCyBo0MtQdcFjb2Y4BGNxzbBjV3fGo HSiyq1sKOhrVCylfGAdorDPM0Ub5Xt8nZyxk73+YdVrwFNm9JRn5ijPg71TF0vRNmf+Q kum8/HFCkm6h0Mw33Mqd6Be6oSLE70y/xodEj5fVAed5Ae0atjW/hGaKouYH+8xJge8Y 1kC/icAHNUcNlFQmlpUnxP8bf8M5Kytr1hUtFaNrBj566kGDg95eLMC9C4r+FjTwG1TC DCgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725639310; x=1726244110; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M23QSkkmj0U8+DRFhBewDD71q06y3alOAwKMp01rg4o=; b=Tkf+oWxShnX17XhdHHFewKDdceR7VLP3My8mnK0vpbNUJlO5MXN10gRkKEW0ew6eIw iWNhSFeyxRtahH0cMCbvVMGXL+Q7a0sleWf0Aq4mNq18wQkGvFHpXje2OHaQGuM+UnnB ktGFi0X3gSRsOaInMvEvOa40Iun0BqlXu7lRwIKMLLtXXBvv8Z7of6PnPbiggcje+1q1 6FE5upDTTOPqskB82iadnzadBhOT9fHv4+JF3jOUuGGaHZANySSybCFkYqt9j+2kt5Sv 6R2hcl3aWwlS7f6ENVYdmFCjGvj8FNOFQiAi50/k2gonbLclRMDlG9FOo4lmNKzNco3u aZnA== X-Forwarded-Encrypted: i=1; AJvYcCXXO5jMF0IN3xpBp07Cgkp/wDDDVC+Z8eB8AMvB7V3cBtbfAU7EUBYL13lCOYdcIrpU9gKgJnQsiw==@vger.kernel.org X-Gm-Message-State: AOJu0YwiWjNJSXMG/pkaW8UYYyjKn9XeOnprUPcIcsUimVtktlKYgBWY mP3xiSoGvEubnHzx2I0Ds/vv4bs1C2n03gP/S+2MxjgZ4N8dUnsoy5TfSCofpM4= X-Google-Smtp-Source: AGHT+IG42XDdUECXdsVsjNHnNCea/VVAWmmRze3BgvuQbgKT9T3nq0761gcMU17mf5578jJTNXnTdA== X-Received: by 2002:a05:6a20:ac44:b0:1cc:9ff8:eb3a with SMTP id adf61e73a8af0-1cf1d059a66mr3145797637.4.1725639309783; Fri, 06 Sep 2024 09:15:09 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-717c95c5d4bsm1861053b3a.102.2024.09.06.09.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 09:15:09 -0700 (PDT) From: Kevin Hilman Date: Fri, 06 Sep 2024 09:14:49 -0700 Subject: [PATCH v4 1/3] pmdomain: ti_sci: add per-device latency constraint management Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240906-lpm-v6-10-constraints-pmdomain-v4-1-4055557fafbc@baylibre.com> References: <20240906-lpm-v6-10-constraints-pmdomain-v4-0-4055557fafbc@baylibre.com> In-Reply-To: <20240906-lpm-v6-10-constraints-pmdomain-v4-0-4055557fafbc@baylibre.com> To: Ulf Hansson , linux-pm@vger.kernel.org Cc: Nishanth Menon , Vibhore Vardhan , Dhruva Gole , Akashdeep Kaur , Sebin Francis , Markus Schneider-Pargmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kevin Hilman X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3830; i=khilman@baylibre.com; h=from:subject:message-id; bh=Z30ieLDM06mHqkwlhFkl2a4vKxiH7HFPI0x22ElrwLA=; b=owEBbQKS/ZANAwAKAVk3GJrT+8ZlAcsmYgBm2yqLeioEVn+N9TW7gc9VPGmGj/Eky5GN6PguO KOykfS2nTWJAjMEAAEKAB0WIQR7h0YOFpJ/qfW/8QxZNxia0/vGZQUCZtsqiwAKCRBZNxia0/vG ZTM+D/oCriCt5fa8AcDFmDrbjCQCyI9IRqkn4tSiSYkSKsTPyY/fQglGec2YE5LyH94QgtSWOcT NvLxvQbBD2FoRtzgzaKJUAfxi2FIXNwK6uJlwFkSaebQMcjh5GXNKrijTD2EbgS2fBaTVoRME/u dLD0x1Yr9ZgrB2tmdsnPObD6pEIrHSk2oUaRUVqIgYPZ5l/I3/eXWWPfix5PiZHdBFgVC0b6JZS NiQ5s6x2BFI2SNOl0fFdWZkXS77zjSmRp2v2DtUZ/A6vzPa2/HWaEB4GfwcJEhmLtwaEwHRG9yX Tq5aFuJElx/ezGE4rnvGrkOcKDskhme5nIa6gfqjjdJu6lmzDowtDxjXFC9EkXG4zkhMF0aRLMC 9t5S9YvWW5yzgB5FSLOn6Z9dnEUUCGiZR/MbNNAocRbxFECjLsTdRsO+QHaZ8Bq5ui+qzoBBjpB H1uI1ycR+kphQCzryIxKd2nxXViIPU50iL9n3VJgL2e/IoK9vKn/pPKhvckcnhXU5cy46i0bR0E XKaDARGTcc78FER5LhrSNc6vqvjyOVIrUs9gdlThAS2cBGIg6C+ri3xB+ZAA8lbt5NfcLHyeSAb 1xoeETY7VCgXg6XQjb1UEelyudDQ4U5AFUZXkTnu5KXXi7YdVEBhhPReuaLzmF2zS2oACqYle/c DKCoED/lAEL3czA== X-Developer-Key: i=khilman@baylibre.com; a=openpgp; fpr=7B87460E16927FA9F5BFF10C5937189AD3FBC665 For each device in a TI SCI PM domain, check whether the device has any resume latency constraints set via per-device PM QoS. If constraints are set, send them to DM via the new SCI constraints API. Checking for constraints happen for each device before system-wide suspend (via ->suspend() hook.) An important detail here is that the PM domain driver inserts itself into the path of both the ->suspend() and ->resume() hook path of *all* devices in the PM domain. This allows generic PM domain code to handle the constraint management and communication with TI SCI. Further, this allows device drivers to use existing PM QoS APIs to add/update constraints. DM firmware clears constraints during its resume, so Linux has to check/update/send constraints each time system suspends. Co-developed-by: Vibhore Vardhan Signed-off-by: Vibhore Vardhan Reviewed-by: Markus Schneider-Pargmann Reviewed-by: Ulf Hansson Tested-by: Dhruva Gole Signed-off-by: Kevin Hilman --- drivers/pmdomain/ti/ti_sci_pm_domains.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c index 1510d5ddae3d..bb95c40ab3ea 100644 --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c @@ -13,6 +13,8 @@ #include #include #include +#include +#include #include #include @@ -51,6 +53,27 @@ struct ti_sci_pm_domain { #define genpd_to_ti_sci_pd(gpd) container_of(gpd, struct ti_sci_pm_domain, pd) +static inline bool ti_sci_pd_is_valid_constraint(s32 val) +{ + return val != PM_QOS_RESUME_LATENCY_NO_CONSTRAINT; +} + +static void ti_sci_pd_set_lat_constraint(struct device *dev, s32 val) +{ + struct generic_pm_domain *genpd = pd_to_genpd(dev->pm_domain); + struct ti_sci_pm_domain *pd = genpd_to_ti_sci_pd(genpd); + const struct ti_sci_handle *ti_sci = pd->parent->ti_sci; + int ret; + + ret = ti_sci->ops.pm_ops.set_latency_constraint(ti_sci, val, TISCI_MSG_CONSTRAINT_SET); + if (ret) + dev_err(dev, "ti_sci_pd: set latency constraint failed: ret=%d\n", + ret); + else + dev_dbg(dev, "ti_sci_pd: ID:%d set latency constraint %d\n", + pd->idx, val); +} + /* * ti_sci_pd_power_off(): genpd power down hook * @domain: pointer to the powerdomain to power off @@ -79,6 +102,22 @@ static int ti_sci_pd_power_on(struct generic_pm_domain *domain) return ti_sci->ops.dev_ops.get_device(ti_sci, pd->idx); } +static int ti_sci_pd_suspend(struct device *dev) +{ + int ret; + s32 val; + + ret = pm_generic_suspend(dev); + if (ret) + return ret; + + val = dev_pm_qos_read_value(dev, DEV_PM_QOS_RESUME_LATENCY); + if (ti_sci_pd_is_valid_constraint(val)) + ti_sci_pd_set_lat_constraint(dev, val); + + return 0; +} + /* * ti_sci_pd_xlate(): translation service for TI SCI genpds * @genpdspec: DT identification data for the genpd @@ -188,6 +227,13 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev) pd->pd.power_on = ti_sci_pd_power_on; pd->idx = args.args[0]; pd->parent = pd_provider; + /* + * If SCI constraint functions are present, then firmware + * supports the constraints API. + */ + if (pd_provider->ti_sci->ops.pm_ops.set_device_constraint && + pd_provider->ti_sci->ops.pm_ops.set_latency_constraint) + pd->pd.domain.ops.suspend = ti_sci_pd_suspend; pm_genpd_init(&pd->pd, NULL, true); From patchwork Fri Sep 6 16:14:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 826196 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58D611D048E for ; Fri, 6 Sep 2024 16:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725639313; cv=none; b=susRM0LyIdz1R0+OKHkT9GyI8VOQgd5nGVBbfks2eTJEaf/tQ2pWol9gXd1WRrurACPoNJU9E5PzdRM+OjtZhGqZIpa3be2LDwYxcvSrbDtMT/yHjgKzrqH94p3flPMAdRnuY2JvEABQ5DfU0X1zeAnAJHJxqhagTc0aJantCYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725639313; c=relaxed/simple; bh=W1HLvNNrQ5aRbDnCoPuDJ9mQXm5CPHYILEXs8vfWbg0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZFgs2qIE/Mohhnu6YASwvkj0ZMTtTxZ1pkHro7zPWA9BzS13dkyOmBLpCc5sGxTVi9/N3GBlmkUPL12cfNdDv37SgbCFpijuiToPj64G5s0aPoZox3GyLugGTpX253cwsY1dheMptXEN6gaAtBqdb4wwVK8pER8ORiqahIHh+JQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=OXu0bamw; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="OXu0bamw" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2054e22ce3fso21731795ad.2 for ; Fri, 06 Sep 2024 09:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725639311; x=1726244111; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+2aRXAwD8KrJpuKg+9Kk7rgQMra5BG+HeEZO3HX3uDc=; b=OXu0bamwVxUGaQrrPd/AL9Ge6+VtAIjBJ4INEYkXFCoj+3c66n7Rh32mCmWqW0j3nS yqcFPcELWBXpSpDe06VYTvUNi/h2e9Z2idQwdRz1RL1PhGBSkdMfzWGZlYNmF/2PSJXT gzEu5JBMykIJD8y31fareJlnXzeiQownVYUX0H80fZciB8TlhenedBJbojbYHs8xp3Jd wyjPEB0kkwQdBHcCgOdVx2U1EIBF5O3h4d1THJO0rhlfGugwf8XwJrE1em+hrzkZT18C foyl6PICUKVquxamCao/l2TePT9OwXbPkcc7GSf1U0exHwiM4XhdsFsxExqGK5p7oS4E 0X/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725639311; x=1726244111; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+2aRXAwD8KrJpuKg+9Kk7rgQMra5BG+HeEZO3HX3uDc=; b=VYdKypLNE9EL4/OR6cmw0jKkcbqB080RM8PrjXCzWzzj0B98+lQzy5jhfnIEV0OjhW o38enxyx2nMKhsHGN4erYme93YFc3RgQxPBgLWuADDFypwoYjMZagehyBMUvY/V1MLwU bguRAlXUyok4cE1c5is3jWTf6TPGRhg/fjJD0IdX+N9IvSj3YEUYfvkR9wb1+vFt3rpJ wzxuSAHrlGS+RFgCmUi9vErG3VG01kDg249U98blRQM/JbqqcRTIcN5zVgSi7p5ZJzik SWWTm/vBjeEMB+R9rs++j+HDCMWyeZv//fKJJ/Q1RuRHjEheRRbi0sl59t3tliZxhnsw ykDw== X-Forwarded-Encrypted: i=1; AJvYcCW5q2uISwmzUFfuAmibhazPFaWWDCeydDhTv9970RpW7i7RhY/al82GNHaXhJULVsXswJ/GwV2b8A==@vger.kernel.org X-Gm-Message-State: AOJu0YwRwuXcsWfo2qx/h2ZdqpeF12X4QnmSibCxK0fQgWZ9S0sECp2w 0ckp/4Eqcqh3L29Q8uEi1HON8/V0FpEuzR49ZaEr4l6afKShIxzKod7DEifthe0= X-Google-Smtp-Source: AGHT+IHRAWOqa4vtw51vHKymkcBna51OsZjUMFHA5+x4d7b3lyErQUCwhi/Zf1+52AB9PHN69BgAZg== X-Received: by 2002:a17:902:cf0a:b0:205:6d54:1ce6 with SMTP id d9443c01a7336-206f065b9afmr40654155ad.57.1725639310751; Fri, 06 Sep 2024 09:15:10 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-206aea333dasm44777155ad.163.2024.09.06.09.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 09:15:10 -0700 (PDT) From: Kevin Hilman Date: Fri, 06 Sep 2024 09:14:50 -0700 Subject: [PATCH v4 2/3] pmdomain: ti_sci: add wakeup constraint management Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240906-lpm-v6-10-constraints-pmdomain-v4-2-4055557fafbc@baylibre.com> References: <20240906-lpm-v6-10-constraints-pmdomain-v4-0-4055557fafbc@baylibre.com> In-Reply-To: <20240906-lpm-v6-10-constraints-pmdomain-v4-0-4055557fafbc@baylibre.com> To: Ulf Hansson , linux-pm@vger.kernel.org Cc: Nishanth Menon , Vibhore Vardhan , Dhruva Gole , Akashdeep Kaur , Sebin Francis , Markus Schneider-Pargmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kevin Hilman X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1767; i=khilman@baylibre.com; h=from:subject:message-id; bh=W1HLvNNrQ5aRbDnCoPuDJ9mQXm5CPHYILEXs8vfWbg0=; b=owEBbQKS/ZANAwAKAVk3GJrT+8ZlAcsmYgBm2yqLsdfADWbiS7a65KXGYejPWS4mVPwOv9Z37 CdRwYoZ9AeJAjMEAAEKAB0WIQR7h0YOFpJ/qfW/8QxZNxia0/vGZQUCZtsqiwAKCRBZNxia0/vG ZSlpD/4g0D6USz6yaus/cIGpB9stTfudQwizKsEkI7rgMBhQtGFHYKpx8BRaIOVShQpNLJqm2g5 xminiI4LrPPru1vNYBLrVb9tsLbtejG9/w7XFxv3P56LYdOdyCZ6amGsez8lZZ7QJIcaKSWJYl/ /vST951zmhT6NZZoratDwIbxflkz62dLjVKF9MKxJfF3Q3DLcBQ8N/+f4mdnU4KuqfFaEAmRNjX 5RlJ+l4reF9zSbahjP630qCQ0gnXIhfTYqZbu9zky9pw0SYTmt5GRQucfJee+kgSRA7HT8XtWc/ dae0VG/ZjwL4eK0ekdcx9R9pZCfYvzDTm3YmPCrnZn3ylj7fuYaMQXG0ENODmvOc8y8ecBbUFTW lok/oOBlD94p7P+4KDGFzIfAXKTBoCghVTC2br2nHKyT+7zbxVwlk8ZBCVPIzklKjA6y/zgLSZ9 KfcsRj5Q+XkRWu5W27p0du/guhlBPLnJZaZ47D6BgcrstGzH3H3JV2hF26YwsI/IBqFtiewEYUF f0AkaW5G87N5ie9+XZll6o1mJb0x6tV9EFEm2g0tuJDBC1YTEvuWVmyeCfcRC3/ntDoj9GAgh5P O2xo5H7sVfn2cUpkSOT/gN3tIhcl4+WDDlMlrVsggWlabpv+PTNcSyRYlp+vAYnplztlc4Ehpzt WKYKkXG5FhQK3EQ== X-Developer-Key: i=khilman@baylibre.com; a=openpgp; fpr=7B87460E16927FA9F5BFF10C5937189AD3FBC665 During system-wide suspend, check all devices connected to PM domain to see if they are wakeup-enabled. If so, set a TI SCI device constraint. Note: DM firmware clears all constraints on resume. Co-developed-by: Vibhore Vardhan Signed-off-by: Vibhore Vardhan Reviewed-by: Ulf Hansson Tested-by: Dhruva Gole Signed-off-by: Kevin Hilman Reviewed-by: Markus Schneider-Pargmann --- drivers/pmdomain/ti/ti_sci_pm_domains.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c index bb95c40ab3ea..1ab1e46924ab 100644 --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c @@ -74,6 +74,21 @@ static void ti_sci_pd_set_lat_constraint(struct device *dev, s32 val) pd->idx, val); } +static inline void ti_sci_pd_set_wkup_constraint(struct device *dev) +{ + struct generic_pm_domain *genpd = pd_to_genpd(dev->pm_domain); + struct ti_sci_pm_domain *pd = genpd_to_ti_sci_pd(genpd); + const struct ti_sci_handle *ti_sci = pd->parent->ti_sci; + int ret; + + if (device_may_wakeup(dev)) { + ret = ti_sci->ops.pm_ops.set_device_constraint(ti_sci, pd->idx, + TISCI_MSG_CONSTRAINT_SET); + if (!ret) + dev_dbg(dev, "ti_sci_pd: ID:%d set device constraint.\n", pd->idx); + } +} + /* * ti_sci_pd_power_off(): genpd power down hook * @domain: pointer to the powerdomain to power off @@ -115,6 +130,8 @@ static int ti_sci_pd_suspend(struct device *dev) if (ti_sci_pd_is_valid_constraint(val)) ti_sci_pd_set_lat_constraint(dev, val); + ti_sci_pd_set_wkup_constraint(dev); + return 0; } From patchwork Fri Sep 6 16:14:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 826533 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 886981D365D for ; Fri, 6 Sep 2024 16:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725639314; cv=none; b=kQ4WJxLzGQdZQmgfZ8gmEBJLtBxaI2MeujcEYPvpt5At3K2X4EzjBiHMw7YU+uNIBJ7GrcaOgTzeicfN8hucm9LL2qJSe8Gb692k/lRxlqVMza3SsEpBgzCElUAy9UN74/biLmxgNoqu0llw3JL9fBArh/PAqVCAnGQ+37sbbUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725639314; c=relaxed/simple; bh=9FdOyIfVNqdxWITOueSVvAjoQfrL1FwTK+07Gro9K44=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KPDApnYPhKTpMaNfCxoX5ypXCseO/aolx0MYrdiTlUkvhXul9mcSr7FgW2bY827yOW8pKZq9OTMQvsctNV2I4sF5Z1mvAIwmpY4UeYMl93DLd1A/girXoDdwoqF4PVLeqUDdOSVMniwHhNJjn0Vw4B8TVb0pWgrZUd6/lvs82+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=qMDIGnAp; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="qMDIGnAp" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-201d5af11a4so21133785ad.3 for ; Fri, 06 Sep 2024 09:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725639312; x=1726244112; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wHpYPG0F7ARkJaF7S/WPtuawc45vlNVeHmm3gtL++pA=; b=qMDIGnAppe8EAd0KyIHcTCQWGamVvACBZ1R8kuiai46yvEvbBQpeHDeND+RnwW8Q01 TzuDVXMqnRiAkVkVoc4fAZPAb0i0scpPQXbJQVLx3Y0Y9i940x5wjJknWDvnGlk8PzYO bpk3L7Lvl0ofa2tpRtb2JwOHYc8ZKODa7B7cgozAhyBQx0RLgvq7tds0c3zYEYnXxXfF DaCbyVXTqGUe0tctoNYYg5OlYgEVEPRAWrHsaGrZ90+xtILvsIUQyW+q6ucAnWRP3zJT fEtsfWD41VvgQpj3LCVzL0g4Rcrt+bw5SCr4+99hoxGIX6vRFphRSTe0zIb+GAFBxBwK MaBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725639312; x=1726244112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wHpYPG0F7ARkJaF7S/WPtuawc45vlNVeHmm3gtL++pA=; b=rQrr+3EzNzbEtuCv4Go+TRHwgpX3+Ehar7jEJGG6/tGdNvmelo8u+qtxrJwWtBz3XU Zs0666u0nDSgv+1YeVzuwgWDD5uZIP6r9ZAYETDi9RHl+i6dfEj7UJGCJaVZekhNHfsp bJcHLj8RGoGFos/aOiZVjSuR3JqyIHZJzJpuzskB8YX7LjcWV6A/Kk60+VGHVy9IXPle LJnGkU12G69/bS/ohpvp6aQ9bDZXTUxfTFjx++/OUPckEYP/fjl0wtCDt8ARgGGCtW2r FVqCFL/qFtNczBjUcyvuarDQlM/FsVepE6uP9WLBD6G3LtM1wigms99mu/bS9rTs8gFL XvpQ== X-Forwarded-Encrypted: i=1; AJvYcCWsA/1XqpxRLepS7MBEgX2WmXfjZUqhbLwB6yhqRqke4Sz8AoHdcr8iKE654pQ6C+3C5pMld2VulQ==@vger.kernel.org X-Gm-Message-State: AOJu0YweEY1N72zaXksKROYjdYzECmh1q1FUQ0rAUj5KFtVHJiKADpeU b4EDildncQSpSkxhPhifhG4XZktEqVXLW3RxHhc3aGaAkFe1GLWq2ZzERFDBgus= X-Google-Smtp-Source: AGHT+IESwuJ5dl0Z6KD7hUnigeZrm7cUkuRf9V0jjKkRN2+AzCtxauGn4MqXh2z3XQDnxgcU4F8gcw== X-Received: by 2002:a17:902:f709:b0:206:cc5b:ad0c with SMTP id d9443c01a7336-206f053479amr36155775ad.28.1725639311833; Fri, 06 Sep 2024 09:15:11 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-206aea54e7bsm44826065ad.183.2024.09.06.09.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 09:15:11 -0700 (PDT) From: Kevin Hilman Date: Fri, 06 Sep 2024 09:14:51 -0700 Subject: [PATCH v4 3/3] pmdomain: ti_sci: handle wake IRQs for IO daisy chain wakeups Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240906-lpm-v6-10-constraints-pmdomain-v4-3-4055557fafbc@baylibre.com> References: <20240906-lpm-v6-10-constraints-pmdomain-v4-0-4055557fafbc@baylibre.com> In-Reply-To: <20240906-lpm-v6-10-constraints-pmdomain-v4-0-4055557fafbc@baylibre.com> To: Ulf Hansson , linux-pm@vger.kernel.org Cc: Nishanth Menon , Vibhore Vardhan , Dhruva Gole , Akashdeep Kaur , Sebin Francis , Markus Schneider-Pargmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kevin Hilman X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1579; i=khilman@baylibre.com; h=from:subject:message-id; bh=9FdOyIfVNqdxWITOueSVvAjoQfrL1FwTK+07Gro9K44=; b=owEBbQKS/ZANAwAKAVk3GJrT+8ZlAcsmYgBm2yqL/PIURu2uNA/h3Fwo/1sgpktG8Pixx/6mQ DAnA057AgGJAjMEAAEKAB0WIQR7h0YOFpJ/qfW/8QxZNxia0/vGZQUCZtsqiwAKCRBZNxia0/vG ZWE8D/wIk6Ofc+XVqFuDQ0NyitdIu9sTbMxYy2i+0cqK1UaRlvQ3Jk0fNkebAHDh03LT0y2OKbu UpUdE6GUxbfPx32hl4Xlq4OmowhHI8SVOzW5VoCrqPhf6H1gCgL2cBp9sMlXfAMX9/1MMOKxX9W K1eQNh8BlZp/xjhU+jKY2GEw0h7uhb/dCC9Sr/YjHng/LIwFK50wJghGLf5ce/krvwSjBEjJ2xB hRKhbmzV8Wm6Kb276Afm31RPPuW59JI2BwtGPR7GxBhFIXg5wPKlXaqawt1mol76ErBE7EH5YsE oa6EwAgpI+RAgSjUPSjYT8r/PQryjwEYeRe98O1hot4r5kuIoLpKUhm9aYRW/djKuXR5KzAWtif /FZWROQDFCvyYyR9liyjiex88DIOdeL9ywLDvwNUtTYrxjmk9Kxq0LDgCl9Apvww0xJnifCzT1U f8xOpc4YTgKdor1/d+pK8czdxq8JBKRgqAuyqHjWfZkCkbnNK2cN7hn4/du6O/90aqzpLR6a+58 FUaASt50dqSLB5p5qZbQg7z3TD0fQHTVQlp8zgjJbN4mjF4jzmjjWHqwcrLNehFv751mOS0bgxb zBdBE5nMU0CKYhAir9AZewEg7SCS+tJ806Rkg1TYKzIjjNSZ5v0vjRgKUhSKpSGsnc9fwbWV4pS 2XF7jXvOcur+sVw== X-Developer-Key: i=khilman@baylibre.com; a=openpgp; fpr=7B87460E16927FA9F5BFF10C5937189AD3FBC665 When a device supports IO daisy-chain wakeups, it uses a dedicated wake IRQ. Devices with IO daisy-chain wakeups enabled should not set wakeup constraints since these can happen even from deep power states, so should not prevent the DM from picking deep power states. Wake IRQs are set with dev_pm_set_wake_irq() or dev_pm_set_dedicated_wake_irq(). The latter is used by the serial driver used on K3 platforms (drivers/tty/serial/8250/8250_omap.c) when the interrupts-extended property is used to describe the dedicated wakeup interrupt. Detect these wake IRQs in the suspend path, and if set, skip sending constraint. Tested-by: Dhruva Gole Signed-off-by: Kevin Hilman Reviewed-by: Ulf Hansson Reviewed-by: Markus Schneider-Pargmann --- drivers/pmdomain/ti/ti_sci_pm_domains.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c index 1ab1e46924ab..566af9f055b8 100644 --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c @@ -82,6 +82,15 @@ static inline void ti_sci_pd_set_wkup_constraint(struct device *dev) int ret; if (device_may_wakeup(dev)) { + /* + * If device can wakeup using IO daisy chain wakeups, + * we do not want to set a constraint. + */ + if (dev->power.wakeirq) { + dev_dbg(dev, "%s: has wake IRQ, not setting constraints\n", __func__); + return; + } + ret = ti_sci->ops.pm_ops.set_device_constraint(ti_sci, pd->idx, TISCI_MSG_CONSTRAINT_SET); if (!ret)