From patchwork Thu Sep 12 03:35:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 828642 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76F9A155A2F for ; Thu, 12 Sep 2024 03:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726112104; cv=fail; b=VjY/MC16YP0tnMTJEpkMQREugtTsB6qQ04hzaw5PTofUnqiHx3+c6dtpG6HddgiEmZ4zPNog/p5khEe3cOSmBR+knWjXL1Bb8J5bOD3/pUOtC0HoftRztULXz687zRoUhI9rHzG9CLxdqfKiE1Do6QsOy6D9rBch8x9yG1aTTuo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726112104; c=relaxed/simple; bh=t9AInFr91FjWEB8V754C8w5Tg/5D5f9TBxLi/syHsbQ=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=Mvpe9WD09EmLSU+Or86f09KnNt6izIxGRBjxZLLd3HaPZZUhLERTVT5NNVVe2Snm2am5mwOCdl4+EK2Y9uhw5y98irH3YqHY7OoMmc4OGJQcBOfWusQ9Hw275croMoDQZzpkdoGV8zUluZEdGntG1SJlHb2ExWxABwd9W6oFrqI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=jluQUyKL; arc=fail smtp.client-ip=40.107.20.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="jluQUyKL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BHR1OVdFWIP/CsOzdfixWZiOXHKY+teO6rncGFAXyeLG23hE3VbEVK6UhVr15HFWV8q+o+HUzwTgSUW4JBQgW2VujdlLXB2GSAWJ10O19bPtMZk+sz5t77poUQdLhFR78zzdwFM/AKrcVr8y5Xy7yhtUUVLny+4AHLPJisH2bFZRMrgRik2ZVTuWO5MAyeHh2UXGfVKWkxPN6rb2fML+WFBYo1O4mMtvZ9VdJtF0lonPxv00MUUp6mN45Op4yFfHkl5pHgx+901qfm5NyDyMe56/dBzAImU8fF3DpVUkMIXi1Cawdt8b87aMgY9ubSpuCjD8zNnKL75Dt9GGWmlTuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kiGVfhcHylTJHVkfsZhZdatHpJw/Zk8U7gSVAgBCHLE=; b=uALd7y9bXZc8fKtAWjzArAUGfn5u6GWUfK1oAxaA+k4zS+IOBDuBgk3LfVLGBFubwNMwY3WWnI92f5ebmrMBqGnZiOCPw8JG9zBqRtvbv4jbcLHd+3wWUEWwx8RAa9PW7L/7inmxM5TLS4Wxch/CSkclYFyG2EiLax38DlQXJ0qgd08d+C0ajOqJP2t7HLXBna6dUiWz3jCHOXs4MGl3TUFEYo+RVoQUKx7UVEfYcO85HE8AVpj3kqWZUz6+6IXHnifDG/AZuAgyh4n3S3L++4XaQx1qPqy1KdyqungqqYbYKZaq7VkuxDVUroVa7h/iec+3wzwVyze6tSDRpW4t2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kiGVfhcHylTJHVkfsZhZdatHpJw/Zk8U7gSVAgBCHLE=; b=jluQUyKLVzBrX2n93bkymY3GzPIzV9/EeHgcZyZLg0Lx2Yubdb1F3w0pWZ9TP/8J6auT0Y1fjczdU5Nz5oRjmgWcsCJfweU2sQh47IE3QatQ0dcFbXJhUy+uYihMDSbwyJPOl1z4hAzzZbWrPIWXpKVw4os5YduyVrVeNo2Une62jrNJeS/YCsGpigsS8rBI50Z4gp6NQwvG/NuUKEyrJ6Iv9K6PKBKhQrPA8gzLHEsD6+OhgqCs7Cvg7h4lsrQpH422EEaIGMeHDheIbRA3yn7OJtONRLhJZD6BKn74dTpOWE09bB+XY+t45V2Xw2HpzlNyf8+PuO7l135RVk7XXg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by VI2PR04MB10953.eurprd04.prod.outlook.com (2603:10a6:800:271::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.17; Thu, 12 Sep 2024 03:34:58 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%4]) with mapi id 15.20.7918.024; Thu, 12 Sep 2024 03:34:57 +0000 From: Xu Yang To: peter.chen@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, imx@lists.linux.dev, jun.li@nxp.com Subject: [PATCH 1/3] usb: chipidea: udc: handle USB Error Interrupt if IOC not set Date: Thu, 12 Sep 2024 11:35:49 +0800 Message-Id: <20240912033551.910337-1-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SG2PR04CA0153.apcprd04.prod.outlook.com (2603:1096:4::15) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|VI2PR04MB10953:EE_ X-MS-Office365-Filtering-Correlation-Id: 4285f1dc-cb8d-409b-c94a-08dcd2dbdfc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: AeFckC9C6EHQTVvCpFJmn7BPKnqAjt91/578gjAkbKDlDyQdmFuebnRPjNWUsLFjqx+hfs0/+j7yA7dR7tXz7CwDOyymncl3BN9PF6JG0Ko5i3rL1vrg0SJDFR5ZCQMSCBsSVhe7SUQuGTSFS/n2/jNB3KXapBPEyfBQC8bROOFWRyrz7ZoI/xgc+bewms3xHkYMl2SbGoda+MYbi6RvpHD4X4+/EVlJLV+QtUunCFW6j6n/SsSPxZMtu731s0I8KeawqQII1l3tU47MkJbTNGWx+vqCo1yEJiS1fUaMxXy/3kQ9Frqtz4s2poAsktuFAnKUNqH2zoXK3VvXKTTlmfQAgK8cRzoLzCexVFkExJ397FvrOipSDFWk4J3h+0DTQgY2DD/NEPiGypjxGQ3+I58X+VQoZsa3bYxv6/QPUNjBTmwAt5KCkT4O12NeSXcNIYxLdWxFD1ElSiQgWUO364QD1PJHV68Zi68mI4qp780s/RJt2YoxLMpJQmyYzKB9UAhF63uniB/yy1rvpaYG+NByGDzBYXsZdYsjp85rYd7kdxQz4iDaJwdoebxsw/yNFt15Zx3pmbvFrjoVxKhIFjlheH6j82nuX+8JN2UabOhFJxNfLY1h25EXqChHkX4Exge+nuVoZce8ME0K9EZGUWJaoP33wOpAtRsoSrfwz821mxA5iXOr0QysaiNlnrjxnJX7XFjzqYZVN1CR6XmfW8RWUZ8sJRUQrREW5poQtyjqiiyO+yXUitdJrcWFsbmulsqm7CtO3eNUZ+xEMHABDzgonjUb2ZOIJiLxozaP2Wtt4Nojc4fuxA7lotoLN/NTP645z602j0B22NLv4VLLjr7jRfAsxzwWPcygSGRW/6XZn3OSdeI/32LnF5tEbXGsMyf6KafpIxxFLPeHLTsbgpqXDmnr6fplTdrt0izuF11SVU5CRNs7dT1YHekp877cVCbvJfvi2q5tqMlUQzgszXSqnZGX27qkhHZYqjEKr/Pw168BYKPvk2/sNBbxY7dX5g/Qr0P0LArSKSZ0jVczqKEs/39tWo2QFBoz4PrPOUlJsOxhH0Fwd+DzPPBO809nRTX33PEzZcUDExN1k//ynmyOWf4uvSPi8ha0QJHtW4SzcmxDZbzZZzpJkGLY8mX/F22kxiPg9AvYYfOWAzcrf92gaUAoVp5p2XMjL79xd7ZqxLtQB07lPy0c6AoAH4ljnbeASlBbj33ewNAySnzaccJFsW3ZkaJEnBzt12QPorAvQEAZM+WtLldeUNf1MefC79vqu5Uh1ScBM3E98/yYzKRG3OVyIH+Axht0ww0WwUrDe6tOzuxCUsjRDHJiS46MYQPWuh6NCuFszPGURNkxjEorG1LQDEnoYTY3ZpMNoT3vvJn+TNS8Pxy0wOywS0BFS1YnhDGQHRLK1YUk87YKag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8822.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 21SgIwvnLk1qC0xk+JSqQWYHPRNxp25BXf23kTpUTxNOFvTJzwPXPQ9f+2emXqvPIxDckMQYAAcZeb56BxUDqmg9OYB45Vh1DayFgBNktjv+/82v9FdCNeLC2aeHQzvz99YQg30OSRY56oP0leYDBunDcOTb2LfNSR5NUsVjXERROKHJql9lsE6cUiE52WQReEJoT5anpy8OkauSUoiE+1Vm+2+CqNA8eO44DxhPS+tZ1ti+SiPBXEbHSnq6/jX4uHCHuL5LebalYXinlSvidzswzeahNg+bGNtfRtU+/W/txwD46Kof+3MHU/ISMSzd2iVUaYxAe3nRtVfr7AnNON6tBGz0J4Plg5TyGWNQJ5zvhwlpKJVsf8CCracB/zR2ih+wCD/Qt9DEkUkv5RbdOKYpnrbppi67wBNbCPL+EZMwscTrR5U1s8uoS3yaIP+sWYrJ3CK+XTmSlqFcVYApJ0gDEsIb7aj99/sfCG6hAAF9Ogr+SJLUGNlBOCQxHzVl0GOPGBnwbKB3LJHu5jTafxJ4SpBqnCpQ3+Yk8hbVJ1kaRCSO0YtY8feQ6MGzCS9P929Ywg+zVaW0JIKYtUEO7nR+xMAGC/aoKBe0w1cDxGX4wi0NHE3+cDI3b38MVGTvK/3+SkrWQYfcdXHVEJLS3GJRvsaNliusmscDLTY1U1Y4SxC8ivSSCpfdwCGI4Fk6U1GeFpkk5xeCxj6CRrmv+5Bz437WNYyxN2MCq6IY9/aeNzHkHcNW0CEb2pB/7N0EvE4gQy+SAHrQiQVAfV3NAZAPutqmJahODjEdzEh8D+uj7PDUIOLVpAV2UpqJX0uZ1PGcZaWu582VlZCJV+KGXPYqAUjp3MBZCu0xvRR5PpXCTqNAbayHS+smRbdNoz1++TwK2QaBae+WNHPimC923YFFigrsi7VjMQ3Q11wTBo1RU7so+zB1SbEdMwo5dfqRTERuTBvIRE+g5PC8oqXzguhVtnOb6reuvK4bRmK/bcxwRLeWxIzyQVNlzRvMiHssquDy8bBfmTsQaCwCAWyLe60h+RjpPHTiHLPPnwdTzOiD5W4aqYHYNlJ/3Cnz0EYuh+fLHPj93SFP2Cn2xVEPPY1kPBCvahP/QAZ7wcGWZ6grrkW1k9v1uzK3Dwb13KADMWjyTpQLxToFa2tqAqYE+HoiwI38gPP1BrR/69RRczRz6MxOFOtOXAHDQ0ax0DB/fJ1aR9hLbnUhV3oI75/meJU7b3FPQyobuCSwighqDnoHHwp9j+WLwjS2IjC7RhNKFW6PgzgyaNcYCUE/lPf+jX0tpNyaPj36qFN1JMVjnUEoKdLG4pZVbkWaRXSKSvIhwUcFHKEszTD0HyTTXjF9iFPtZHsf/DVraA0uG5GBlIh5OzDGAEZnzkwZ09YXkuOoc4bxZWNPXUR9FUVuFxgMI2oPrLJ9tmtSiSja8/trGKO8LOsxaK4LEe9m7dz8fvCXduiBcu5gIsWSMtHVENFD6jQiWkklt2amkL8B4QSwpjlUeyZxdmQ0SUB7ApAL4FUxbxLRDmdf+c11hoGgX+c/Hs23/66kITNpdBSxfsJAxQcbDtMK0oup3fjNA7NmDT4B X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4285f1dc-cb8d-409b-c94a-08dcd2dbdfc9 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2024 03:34:57.6933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TT/caJzMWbklDaS+XZyXnxnmqJyYDBv8xWy+bmfzPZ5aVjWYCORbMv5YJVzsmFKvXo8cH2J63qkVAUBUh7nN5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10953 As per USBSTS register description about UEI: When completion of a USB transaction results in an error condition, this bit is set by the Host/Device Controller. This bit is set along with the USBINT bit, if the TD on which the error interrupt occurred also had its interrupt on complete (IOC) bit set. Currently, device controller will do nothing when endpoints met transfer error if IOC didn't set on that error dTD since UI didn't assert too. This will also handle UEI event as same as USBSTS.UI for such cases. Signed-off-by: Xu Yang Acked-by: Peter Chen --- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 69ef3cd8d4f8..b9ccf62e0a50 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -2063,7 +2063,7 @@ static irqreturn_t udc_irq(struct ci_hdrc *ci) } } - if (USBi_UI & intr) + if ((USBi_UI | USBi_UEI) & intr) isr_tr_complete_handler(ci); if ((USBi_SLI & intr) && !(ci->suspended)) { From patchwork Thu Sep 12 03:35:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 828153 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C1C15CD49 for ; Thu, 12 Sep 2024 03:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726112106; cv=fail; b=KrO8D1+rH5Nk4JUdbDQthy81w25Jv/Aw3RtUwrOKpBc9na3rzc24iVisiXXYdwx4B6B5aJsSXycaJuWa1Gc+Cmad8Qyp7ZokGnKKw0TTdj7W5KqQ+uZPELxAnpsZHw4GO+s/zN8X7rSMB1AK2Kbe8hPwP6Z4PM5SNh4lmwMITtY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726112106; c=relaxed/simple; bh=0p0GwEcZh7YKRYOkifejHRQ3e9UvYdXpUzBekV2hRr8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=g3k7GITzISsIDOErOG5bQ65bQNfrrGNS9xps/EMRvzHUWPWZAo/ntjrLAtK1KsYMwBfW1wb8nKqHc8K6IkJ7PBragLahFa26vni6c8DA3qXVCxtqr+joyrlI42/od480NJB19oRwAJi80VLmhjB95ISaI5gvzRNesO6tGGSgQwg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=EEG5P2VR; arc=fail smtp.client-ip=40.107.20.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="EEG5P2VR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nsZZEyA+xK4UwJCbgDXnP+FoR/yncY2DfzTDUWQciT4jCvNfB3V9ZNTgk6Eium0O+YecojHpDTsIQiGZePp4bEJerL460IfkefkctVoa3SkCILup26QC0YepgAfwhpj8/VFHsC+9Web3afj/YREzUDIFJUA9x2TVjtiKli6yfz4r3eyNLZnf9HJyku3lHoRS6gXNiEzilKJWe2LIVK7XVUstQftb/8MzXCnlqluqFjwA752FOufwCVkdwI5k2xyHUZHV4DGLO+qaClO/R3EXAJUpH7LaMFDge1HOGLtMxGhX/mhtKAqZ+M52saa/P7dlxM3xU1QqBohYv987QAqJzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Yhmn4n/k7bL9VAKeERWEYA4KU+DmRo6gUIYyW29pqc=; b=v4JZkwqGVDbg06xuBHmZ7z9IhiyiYXgyquE2uVFfg2KYBeOSPRD6/87sDX11VaViWebwnCuOAa6+YHZlSM0wwQgQqBbB/5g378oX9xuH+ljNApKyeSP+kRudfHv3W2roLL+B61Kv3bTkIJWjqY9Dcpzz3a6Sz67U3TfvFsgN1H7FQ1J2irZxaZHel86lqfbGceHmEFGRH49tW/Mpq7SRGhpDPsSoekkPtn3V3vFjeFiqTwF+Ah6dk156ML2staXTI0xLDPEa5ubyPPS6pTFzwMaETi0GZwRhH9noraoODCGOdrbvTvgLC/M4eIrGc/nNugxgHYdbQLD9tK++0QRKxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Yhmn4n/k7bL9VAKeERWEYA4KU+DmRo6gUIYyW29pqc=; b=EEG5P2VRABe97rF1AvTP0DC2ErkWdStrpyKiZclo4GxxBFq3HMDdB+3i6omtEDgiEVFj+v9k5ENRzJKNGSWmspAvW5JttJy3nBXtzboN6qwuaBgUSgiQznyKxe/sBU0/vqI6O2QM9+6MZKGhbTiUqK0YwvSOQSNLquVM3ohFTNqKF8kXdcG8Kv9MocxEASCk7DJ+RhLtXeNctKTdq4JjLW3s7GdsBmZ+hHK649Ebjom+HZWy6z1p9wWNIPvocX9Z614OOTUTxBBG74YOIXbY9gxcrN7RuWZOWHRgFhueS6ZXfrE3lU/H5vMLouhO5FtqvSyD4ZCYl/KHRGa1oiB6cw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by VI2PR04MB10953.eurprd04.prod.outlook.com (2603:10a6:800:271::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.17; Thu, 12 Sep 2024 03:35:00 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%4]) with mapi id 15.20.7918.024; Thu, 12 Sep 2024 03:34:59 +0000 From: Xu Yang To: peter.chen@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, imx@lists.linux.dev, jun.li@nxp.com Subject: [PATCH 2/3] usb: chipidea: udc: improve dTD link logic Date: Thu, 12 Sep 2024 11:35:50 +0800 Message-Id: <20240912033551.910337-2-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240912033551.910337-1-xu.yang_2@nxp.com> References: <20240912033551.910337-1-xu.yang_2@nxp.com> X-ClientProxiedBy: SG2PR04CA0153.apcprd04.prod.outlook.com (2603:1096:4::15) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|VI2PR04MB10953:EE_ X-MS-Office365-Filtering-Correlation-Id: 48240f61-400b-4f15-2d38-08dcd2dbe126 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: LoClNDMtMTYlNVahWmsc9tV+dD9FKrWyxVguskxu3vLnYElTudKUXH/cJ0jRNiEqylG8vUcUvF0SrdtmQWZVW/or+io2IKoO3/mmaiQdcfoJlNDVLR1QMRn9gIVOb4ubXvvpNz8kbPgZWNXFwR/d1/qvGQp96fkjUnGOt+4UyuAfCpezxKRJK4FKCJJalQVaHhPknTPh19vYEMKuLCFeIkpcH3WsJApcTFtu+WO0aLsHeJfjX+uhopdIE4ENxu2BqAaLab2a3Xyzmwu94/Wy2GlFddcaebybCMeQyQKZhWefHDYBwokGI9ld/UIYYKOJl+s5bVgMLeXd6UnB74vlUhniuHIhAAGJ4GhDUaeoAm3Ftc2BK/rGFfe+dDenb7MPWWzQVJ0D9PxhhrNXhuHHjKLpu95ShERc7u0PfFjY4LYn0jxs3MWDwaOPJUNa2bOFWzgBScKJKJ3Xc8hG73mp+UcWn3SQYR07BwQLDwHQ0M8J67RYbVw4pBw2CSQX0jEfW+jNum9+nj5dI5nuTp6K/pOFmzTVYB5wl7ckCSHL3XaJ3apfM6OLg6p2gqkhoHqH4A81Y1wpwAmnjwaVe1goJNW9x8VEL5YDsF1N0alrXhiQEhySgeYyf3WF5XH4NBmr8zoRG+b3iYKhspoRXgWCL2zJP1Ys30G40RNOVJQLEQfrrWgYDZ8/PEcU6Th5wBYqlUmv+tmMDj9/2odr1E47VzoP34ub5wffTvo7SrFaQPVDcu0yfb+V3WC85hOzKhUZzf6EZUV160vMkc/Q5agBl4pb3buQ/VnUoFdiAlH0mCVB2V2/b7zhPTnvjQg0/FHDAd9gwmaN9mryxz0StpSCFayOj/5e6+MTt+NwrMlL7a73XvL/zXyW6j4zgo/Sz88gcKw6ldTWZNYuPEp/FmxZM6nl3VkaGNFHLX1UXWRW4iqd+U9Eb4BaSa1utUt9oFrDXSdI5mVRnXlba+M9FRp0zwhPMh1x/DnrQq05KdhvdeqdH3m5d/ZP5uDIm4e4IWEaM1FLcHcdJeRmZV84jiEx2mV78CCG40eVnbW6rhAhM1B0NWOGN4Rz/V127vHIEyKsJd5DpH6awsGZHnKOB/hbGAtskD/1bY4/RzM8vj5+PF5d4XDm5HPwyVDb4yRDBx458qBVifZe75O+COuBvsZAg4ZPyNXt91ULa/RRb+5lY6OP431TSP7CEwGyxOXn007B56G6jN8RSfaYNYcC15Wt7JabXUIhc4qYKg1nhiL97m0JSWLcxA+hGBrWKxeDRNx9O6mac9+AkE95sfVM8o+vuzuLxDcau+vCjgzg3GaGpaaAmI4S4x855e60i4OoMsiirqvagkTodVnODM0qPn+UEntIUAkVc02S+zQ5wbDgeJK2MKD7v+dvLy6Szuz88hEjjl+PVaTQXYdk1PUogwHwnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8822.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZhwQUQ6TaOfS4v3jS8FTKKmoDJF/qNi0XLpavqjtXTpIypA2FdOH7S64SLmwyGPCnGm0UpkNucabij/Efez1lxr/uaYvVeCpqIy/0Xqj5aqMNaLgVHJFoyHcXOiBwRbZUva3qfYW0Yu1RQ7GxVnljZxZ96M8Gl3QNJYgy5Ly4JsrlyletEkmlvliXyt0WcGdCgoXWSb9mEObuC9k4tPe6IS6FI3qhRkZ/dUg53BRwqe/6jOM7g3HvkTShNKwwnYJ2oeQqlSDWDJ/KRRVwRcotDX3eeAbegI3WUPzwYHk9ujWUQNkwD5f/LeuT0S3N+ZCWk61yFGvZd95iTLo+qmAfdeCdxLrnzpkIYnASDYKERwi290+DP0FZXZpZcvW5S+Rb87HMK78mXccuRKLRFiN9pnAKN2JO8MYtNeyDFFt9nrcK17vMJnoKrFgulJXCF4UJqLCELENLbTetjmZN2HH475lYN2IXb2BK8CcsdGxpV+lOuEibfRWn6PgkwMC46LeIKEimJbcQCAWmnxCRglliqbyddjLiRMCyUnhKfo8ebkQItDE4227XDIkmhd7AxhdIyxPsbykY3OKkpRPc8GdsrV3LRYlJSG4vWXy2dlPMysF42uEXAFofSfpRXjVk2fdpdrCgEq9ztoRoxPLpHiPUq+Z7rWdqjp6aVN7xlO0Nwz9VywdeA+tVtoFlL10xUZvxuqJBxWKuq9qXVYIDYqaaETL110LA3FEjtaI7P732AFrlgvYQOH5WAT1omcF6u3l19SXWwjympvNzIHkFsDrb74Ss6uCD4tR15e+g99jQ44lkPJuKgCa6wZe0xzBxHpJ7tlArIQsQKHIzrgDRp9Tx9BRy8nm7jY3KECEsysgIXfUb5p1CcEegeIGcH7LpLLMCAK31tnL2rZ6CoL87u1tqrYrB6Ke+onBky4etZOA2OtgxcYjwyv3C/cpk/feoI/Ig8CPF1Sz6RbgXaTNVQpWQEduMwTeTevj5yQSBs6+LNPFjjjqZGVC+D14kx6EURF71NWfb3QJuhyDoLrHoOagp5ZvGYJWxMrFmUFvr80z4RpOAa3jglx2P2yLQgo2HPvlAha+OJhF+cbJGSdp8xFASBjOOQ54vHHYqygAZlHVAKlbc2uyp/P18r6Vgr5FgtZzw91RHzILOmIfxf6s6R5vt9BzQh8YaBB6gap638yp5iEor7g2a+UUuY7GhyFqKuJlbesuiJ/gfSZ3QXe2gOrWhxiuGmyHxtWVEPZq77mpV+QPgRZ8rlt8NyDZp54m/UkYTmA35r2lcl3rFGNwyDfFw6vWhoxiIrzZc+XvCS1KVKolPi9zJ0uAYAaKBbQuWkvKgO4aBUzI8nVrX8hD9AyvTIcp00i1K4QGVg54sz6f6nQEswJYgQM4gGnzuL/1g14uWZLFirYik9E0jM5oxoZb0FwCFq73kCVIJJY8qDky3Uo/yNzCDjP2/7GM+Wj3l98BsP5fPI/THjxkDrzpsk0V5fFWnpaIKOWKReSniutxwpq6Lwc6ux1tAgMXZrs2Motssp0P8TFvQOJPgzcktfqzejfgGa6sKVPPizdbxxI/ltdPHWAWlfbwKpCEycC4O6Od X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48240f61-400b-4f15-2d38-08dcd2dbe126 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2024 03:34:59.8756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: orr1bkRKZRxRyVkplOmHmAsH49x2KhXFiah06/FlzaHj9ne0CGVuDnZMj6jcPOJI3BLWWDbNO5y5B0kn8He5SQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10953 Currently, ATDTW semaphore is used to safety link new dTD to dQH. But this code has a bug when the endpoint is already in error before polling ATDTW or just met error during polling ATDTW. In that cases, ATDTW will never turn to 1 and the cpu will busy loop there. When the endpoint met error, ENDPTSTAT will be cleared by HW. Therefore, ENDPTSTAT should also be considered during this process. In case of endpoint error, the current dTD should not be pushed to the head of dQH since some dTDs may be still not executed. Therefore, the link logic is also improved accordingly. Signed-off-by: Xu Yang --- drivers/usb/chipidea/udc.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index b9ccf62e0a50..0ab57b87b07b 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -612,10 +612,17 @@ static int _hardware_enqueue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) do { hw_write(ci, OP_USBCMD, USBCMD_ATDTW, USBCMD_ATDTW); tmp_stat = hw_read(ci, OP_ENDPTSTAT, BIT(n)); - } while (!hw_read(ci, OP_USBCMD, USBCMD_ATDTW)); + } while (!hw_read(ci, OP_USBCMD, USBCMD_ATDTW) && tmp_stat); hw_write(ci, OP_USBCMD, USBCMD_ATDTW, 0); if (tmp_stat) goto done; + + /* In case of error, ENDPTSTAT will also turn into 0, then + * don't push this dTD to dQH head if current dTD pointer + * is not the last dTD in previous request. + */ + if (hwep->qh.ptr->curr != prevlastnode->dma) + goto done; } /* QH configuration */ From patchwork Thu Sep 12 03:35:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 828641 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2251714CC for ; Thu, 12 Sep 2024 03:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726112110; cv=fail; b=mPhxgEb+E4uSGVAzxp6LRpu0D63ucnhkO0tX751NC7ZgTSZxLt4dtnDDhFNy3IcW1v+jU0VYNIyfV7EBlkvZ83WzARaHk2i8VWRoO3bzczOx7qHAdCZ91VwO6fQoGM1An4YJXBifiaiK09dTPDIQ9mHFwjQWqRkg+hU3q2fNJ8k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726112110; c=relaxed/simple; bh=pCAe3xzSE14RZ6oYTvg5eejM7aVdIhu5uKPgRHiZZbc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=i/E0kdkDG5px55pkXZIStq7c2fbwF2DirxWJobxyU4CMwogVYZc9x4PHeDl+9jitj8sG65w6hC0OzEhZw7ldmPC0TZCNcHPugihN+PKriPHJuPdYLLHJH0eGc/6iQtHax8HE5ZvLssNF4pFzsxBRAfCumldLTgurFE0X3rRMjVI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=n6JV/YV2; arc=fail smtp.client-ip=40.107.20.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="n6JV/YV2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BgIpEJk93C1rv4tbblsRhoFxaOSoXgeWGmwiniNV2dtUmhYw9+H7AY1DKoJhndY30bUvL/MIzfOJyrXX8Vn+NE2SWX5kkRp/8zPQ0Cy9bALxcoIuWzZchDIG13hzAtMsxjMrM8jSFawzqVQbjSztCFeFvSWSxMikaJ+LgMhhiutj5lZtt7PCIAzrv5eqvCOFhRdhJ7a7z7yx30TuBqpkm0Hne/qpn0QW7hcW+u6E8xu6xJApLq52hRspYqtCUj5I3kjhLy0aBwxuq+O2JicC24b0nRTP3xzLCsdP1wxG9YAgS0nF2htkK1arFU2NMM7gOd1jJWkFq90QH0ksCYw0NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mjJESt/q2kEdP4+f7qsKmbh2QARyRcr4pIHDQj9m8x0=; b=OrUhvZfzHRfvHspJdg0B6EZ/qAxLwdylffKUq8z9r8/rdVHX/x7xRmVvL4+WV/pVBEZ0jM2kvL5g1DxKN3+V1RnQPB6uAMXleLo/zG8TMsJjp4dTNA1WWkpfOBFiiehkcoy9X4LnQNIx2eOUgOBDMm4RmME0zBtw2AxYe8/MypL+cotWLZr5FkSVAl//4p8xnK7KtsTsHpwa0+3Qd1WUEZkZsZEfa+GQ1ybQgIDcbjzg/q8xU+KTYJulxpSRtrr6BYwos46MT3nKqzvGssiKPCAOIOEdF57a7RV0oUxgWE/z+vqExHj1vxAbwmhWvQyFbnxxIMpKw2NICn0b1syPlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mjJESt/q2kEdP4+f7qsKmbh2QARyRcr4pIHDQj9m8x0=; b=n6JV/YV2un+iI2F9Gu2hz7QW0U8ZTAOlKwpTnKHS5OcqmnnaKs+blyk154P3fgQtq5ICS/atVOYhBjPPH0TZrkVDpdu6YeHRU4blCw2rXIGbLH5RpMg0X8kceBVxpXORuuSD7dDF/57JaWu7QinUMCXaBuLjOlhMaKt7Cam8whovjszHj7qGBRE6jkEDfDVIPtA6RtkwVLGQHWXLrD7vajf4oMJ4DyeQ0tfnSjop5+Ux1tkR0JpDBLGpTE2E2CxBhGICUKw+XXEWB4n+zXgfkqLYDBBS7oPoZEyrOKePRpk1aJtu2BP7JOyi4KziHb+D7GC3MLdTwKPNZ5zO84uIeQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by VI2PR04MB10953.eurprd04.prod.outlook.com (2603:10a6:800:271::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.17; Thu, 12 Sep 2024 03:35:02 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%4]) with mapi id 15.20.7918.024; Thu, 12 Sep 2024 03:35:02 +0000 From: Xu Yang To: peter.chen@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, imx@lists.linux.dev, jun.li@nxp.com Subject: [PATCH 3/3] usb: chipidea: udc: make isoc endpoint a bit error tolerant Date: Thu, 12 Sep 2024 11:35:51 +0800 Message-Id: <20240912033551.910337-3-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240912033551.910337-1-xu.yang_2@nxp.com> References: <20240912033551.910337-1-xu.yang_2@nxp.com> X-ClientProxiedBy: SG2PR04CA0153.apcprd04.prod.outlook.com (2603:1096:4::15) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|VI2PR04MB10953:EE_ X-MS-Office365-Filtering-Correlation-Id: c017e631-b758-4ac4-a27f-08dcd2dbe272 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: zJVFhTPn55vSUuPIX76ycnYbt8ALQro523DaCOvXN3BSA+4b4cvlJCiBbk8tylwJqYuOiGm1HXWbL1lziCvkkeddbgV0MerMWRHgcwHkRgklE2DDqgOxtPC5qw+D+w2VoiNE3GilaUM4J51pSY5NWYkYNKIejlA5Q/iarllL3wwwzDyoXWZMahPfKYp483h5pkD/eHXh+uOJjC+nW3Zji4e7HA2L8oFlfRDXKncwcDDTn9gKZU0TX4QDLsN2wNfjjxq4dh+Usgik6r8wyb429CijvYxPm5rTW9OB6/prh0gC1enXArYNRW26DNyoWtzVgq+EhU9ZC5jX+JN1PFBddu1I98b+yG5UbkXdARIwt8D8SLbxYTOw4KRP+X/emc/4s8d8Ap/2EGkxcc1txnTPpKmnbCNg4z3wojUUw51kLUKvkZk2LKCiDzhAJ+E4Zj12L7qjpqF5XyhgA9jhPRfrKBXHe/sWQyfNYIUNUxURlYBxcDYz0IoezuSbfxdfdA0xxbHY8IFWsPvbqktSMMiDPJnOjigvwZEyCYx6iePi1FryFwVDEXHUvQfA7prWj8Bp+465l+20Qz2WZtt5eIPyLPZ6xhAEb72vcxrukQpSPZDWrtS+KsdA2fS15OloDgv+acb4gwEDEQ/RGCgNGG4GVlPo916ve07W9TGUiLs0LrdwKGNl+1q6X4KHnb404mKGStJ2V4XJttcGHinF9h1HOniTZHag4/iCi3eTWktHmAvAKGTICB+T9kpN86CszCl6skp7Sx7+mZ6UCD7CzFAHFt3YJfiFpqSF45+zucW2PablA0YGQOGIKi8sTZTyAK6BNZhgjsMIYUnURSXopkE0UY0E5HNKFotbbJLUcsLRseDQfmyIRDIPDove2BW7rAPo1/HIxDw/NPUucOLRP0dwQR9L6FKXK75VNVE8TeW5tB638HGd/GNX3u/Div30ixnfHLUFAAX7kmDw9FAGJ1hnq2VMH8Ka87NzEwByCMSajRiyHBmmKMU0DgU+cKDrwXJ7HFQz00N5qmPYW64vA+Iao7fcUF40GZUhug/9PsKXwyi5xg0+DRi5PuVVRt588nRTCBPWqqGnpsHOtkY+2cGo3GU1l1okV7DBXmo5/bHXKVYXsOGnYyAmWbU0+5AbPhXuxzFUsk8GZczCokW3lZR7UWnpk25LhJe2ueZ9khJhTY9c2pH7SZMaSfugCxZjnunwdkjgouz3pyXGjWtIYwp+qgHU1ojgND0VGbYrpLUFPuD9RtxK0OPE8Wk2u7sQpL6BkS2LE5ISo2OhR75/cvdESqSvyMtl+VtqauA8Xo6KFPvV9zeHosKQf0Q1/84wjQBAFOqyxN+3F1cb3dZUuK2onEkOam5/N8BTcQ1/xKzD7sxFjp2HcRFX69fkMSSNiqTp7pPCPfGxPXfmWsuxisC+5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8822.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TdsUNI7QR2dGVPcmZcCVrngUXqXxQ/mtYbgjkPdxkn5t3phuvc8TRSdgLTzBi85S8zTkttg84FQ6U54KaAFHCMAoQ3t06CfRPvoXaXimTtOgpq/3yd6QW5NdSiQuomJ1yRuYseznfWCJzFcrUA3mqggg5ousEPsAUuMSkSfaCzilY7PuSmT630dDXvl5hBMxI0F1lOQcgTid2yAdRzv1qRK52IKdWtTbtLg3WhiX6QjG8wxpQzeiGDeuBCQhUzjt1K7/Fe22hj1qZHMeSOPUFI+mFJi9VSh1dBAc5+zr2Sqtruj89deykeDgWUNEKgJBlxr1Y23YKk0L8LQTibCCwtIvv3oQHMUz14KNE9ZAisz0N296oNXDyu9elppzCgUQmAUy58ng7InUQiM3Mev8cJUkjOIOJX5+6o+n4ijm3qvb+GvmA9M8UG0BZXIVCqkmtJXpipG2qht/NvV5e/Wuj1bkOk69D4mBzy4SrO1vc6y5D+cMtmR2iwB139ep3SW1Ie2Sk0RMN1qykolUj+gxvGb6SSnbZJA1snMMvnES0UixG3tuQsNFkkdS24XAzG3xOWAnNJeFX8qsZTxGsoHFkIPDvJ4DToHv8uOC/gnQc4FGJTEQuX+HpUN8ukO6GSfs6jr3OhZhrt4oVXOxe3QoqrnhnLiLoxlUbyi9zYNuQiP0jHfhzvE8+FeUIKEWWv4OL8MjDvijcYGPETW4WtUEMvKZZFlDkbPcMMRw5rEVPAVVwCxcypODUGRSiCC7gcZzgZOLq0kgvOjN8Fo4zgNFcA+iKKG4xnvF9M/aPKWBJnbAMRi2IvpH6Q+NQeh53y47miVufmZIQQ+juZPqYQJW1qkNir48O1vZNVB0KHhkbz6Fl3/jyQRJVBEMk+pNWrvAutsIhzB6r8R7Z06dAgbvTBXPjEhE6jgMbGo8cctVFmk9E/W2/oD9p//N8xKzmx0Q1lnkA+oQhWqtlR25pqhk35fh0GTEPjJXp+Ptb9qDIH6m/2E38b2Ktx/WkyU+9KIxbHnZTad4Zihg68Bxk7UNgWni9Ugm2D22wTwQHaqdogHaVMu1KmsojhQkVosqocpFM3h85o714s/A3ZOz31y8gN6YUEsUKk5Oy2djgFa0ukr99VnofHj83vzmi7ZydthcXrQuvupkIkmtuZcT0kNBUJNjn/1NPs8AYyuRIGlwkWotTn2Z3U9XtOy5tFw8zyOv3/Z9z+6HFPSBIeFYchLTRbyK3yHFPPDHGByDAHTzStjKv5j45Y2jZ+uJezt46fumw92cO0rcecJkK9ELgxJ11dO8zXXr4Y0j//mDnXjqndTswosUsAYuVG7J+tDxRmsc6ID9SwA410OhYqcm2UOapS/HtQver3zE03W+9Jfu2ukPvvmJwMSxPvDrZJCtrDeJNi/52d0nn4hMr7Ib1xk4GfDOT5CyBBxnX875ULfhijvUv3hkPzzG8JjEezEl9zb14UmLwwe5mVv7TXIJ6Py2jIAFxzJQTu7RFRPjf50FimuBBWs5Wp+PqNEV4ak4iHqhRjFQB3zvfLUkynIKc2gi9sN4032kahKkY773abeezP3+p1GHT8eTl+/wBaLDD4Sj X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c017e631-b758-4ac4-a27f-08dcd2dbe272 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2024 03:35:02.0257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FPmzPyEo99NhCnc9dfd/BXi0aLVaYNehXrKxegnNlDqSyGV/iLDeLhqjfntYOBOR2VQd6tNdKKRDuXclt8rIFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10953 When a endpoint met errors, the usb controller will firstly assert related error bit in status filed of dTD, then ENDPTCOMPLETE will be asserted. Finally, USBSTS.UEI will be set. Due to isoc transfers are error-tolerant transfers, we can make isoc endpoint a bit error tolerant on device mode too. In case of error, it's possilbe to resume the endpoint by reprime the corresponding endpoint. When error occurs, this will allow error dTD be deleted from dQH and giveback request to user. Then, a reprime/prime operation is executed depends on whether dQH is empty or not. If dQH is not empty, reprime will be done during dequeue process. If dQH is empty, prime will be done when new dTD is linked. In this way, isoc transfer can be recovered from a small number of errors. Signed-off-by: Xu Yang --- drivers/usb/chipidea/udc.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 0ab57b87b07b..b1a1be6439b6 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -683,6 +683,7 @@ static int _hardware_dequeue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) unsigned remaining_length; unsigned actual = hwreq->req.length; struct ci_hdrc *ci = hwep->ci; + bool is_isoc = hwep->type == USB_ENDPOINT_XFER_ISOC; if (hwreq->req.status != -EALREADY) return -EINVAL; @@ -696,7 +697,7 @@ static int _hardware_dequeue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) int n = hw_ep_bit(hwep->num, hwep->dir); if (ci->rev == CI_REVISION_24 || - ci->rev == CI_REVISION_22) + ci->rev == CI_REVISION_22 || is_isoc) if (!hw_read(ci, OP_ENDPTSTAT, BIT(n))) reprime_dtd(ci, hwep, node); hwreq->req.status = -EALREADY; @@ -707,7 +708,6 @@ static int _hardware_dequeue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) remaining_length >>= __ffs(TD_TOTAL_BYTES); actual -= remaining_length; - hwreq->req.status = tmptoken & TD_STATUS; if ((TD_STATUS_HALTED & hwreq->req.status)) { hwreq->req.status = -EPIPE; break; @@ -715,11 +715,13 @@ static int _hardware_dequeue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) hwreq->req.status = -EPROTO; break; } else if ((TD_STATUS_TR_ERR & hwreq->req.status)) { - hwreq->req.status = -EILSEQ; - break; + if (!is_isoc) { + hwreq->req.status = -EILSEQ; + break; + } } - if (remaining_length) { + if (remaining_length && !is_isoc) { if (hwep->dir == TX) { hwreq->req.status = -EPROTO; break;