From patchwork Tue Sep 17 10:35:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 829233 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp213937wrr; Tue, 17 Sep 2024 03:36:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXLYYmCrzrjZ+rINp7+JsLLAvzQVMs9M+4yo+i56EzfZZPUihJRqiOHsmXrOPTjVoWTOyP+gA==@linaro.org X-Google-Smtp-Source: AGHT+IG5F4l0oYguaZPcdrtPFMHuusOiDZb5FGnxenHHB5jlxjo/bTM8j8KUQne6tyuGq5VLSMMV X-Received: by 2002:a05:622a:2a11:b0:458:4f4d:1ffd with SMTP id d75a77b69052e-4599d2b9845mr258372861cf.45.1726569408183; Tue, 17 Sep 2024 03:36:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569408; cv=none; d=google.com; s=arc-20240605; b=M71duPrV6pm4WDf1DAhGN1Tk4nj7lR6DvMIsjNjT5JCyZUWEoBeD23b/+tBj8OBRNw tiMspBGxcxS+fwocNkZVxbAy59819AIwLJ+DCK3Xgw9BdYuE2lOuA7lS99o/dxHuM+oT Lx9xewQbdnwudJuoq2erMSbnUmyR96wzIk1SlSk9ijZiqMs5nR0KNAsLGYXjr316m8Nr wOQ5ol7cJ0IUy8lJQnGiv+5AsWyAjSsnpcNEeYUxHomKcSJ8eOKDtm9eFsSMWr7Ib+MR 0RzfXaeyeqDBlxSpnwTiSn5/I430abxDtIHme44tSY7WN8gDCpijYU1L3fND7BZ87G+u 0OPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2A0bMQNYir9UiOIApKS5SDLnl+/c9VOLN14bZaqlyWE=; fh=CsrrMFYqxLb2ncaqCW7Qx+RO/RoxmO0iSVmBprRl/p8=; b=VVyPQhc7wqGMyH2pzWAtKJX4DCh0wZqrWxmWt/hMOlD/kTDV+DaJ/APFe5o7yHx+FY /woApDuk8PdUSZ8iATkSA8Pe9zZz8KgqxiCvWj5nNrSOqTFZTSlq6iyxYRsB+UA+Riuz q4KNXeXyfhsqViOygg1Jjm+QVo39GSnifEWIv+gQT3UGme/+nrwdGNHMLnlljTEhr1GM Kz6kMlGsSItLnsjLX9iWw5mwFI+QWT8LhFUXhpU4hosuMM6K2mRPU2aE6LuDdBT8q/a+ VxZ9K+TL3a7W2RXMVYAPgCekQJioTCcSqBQcs5DZbDfE2ffoBTqT3VGJ593D5HS0f+gS r4wg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NdjpxfAb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-459aad0c4fesi85393391cf.303.2024.09.17.03.36.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:36:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NdjpxfAb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVZD-0004SZ-Bq; Tue, 17 Sep 2024 06:36:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZ8-00045K-Ev for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZ6-0007Kz-S0 for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2A0bMQNYir9UiOIApKS5SDLnl+/c9VOLN14bZaqlyWE=; b=NdjpxfAbzSDvACG3IlDkmSHdEIbCwKPw6E3hnjtPn85yvK0gJUUn/f0Ml1fzuTILyFPb4+ lx/1gMZx5c7/OWG7+C9lxGsGYhS4n2ASX9Uo0RdwTjrQLHHXkxgwYLOmhgWoqWwejJN5ZJ nOrrUH36RfHHq7YkmqmHsS9kYxSc8sA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-x2MMbfEENSijvHX_W6gpqw-1; Tue, 17 Sep 2024 06:36:05 -0400 X-MC-Unique: x2MMbfEENSijvHX_W6gpqw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D40441956048; Tue, 17 Sep 2024 10:36:04 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.158]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BB6061955F54; Tue, 17 Sep 2024 10:36:02 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier , Richard Henderson Subject: [PULL 08/17] tests/qtest: replace assert(0) with g_assert_not_reached() Date: Tue, 17 Sep 2024 12:35:31 +0200 Message-ID: <20240917103540.149144-9-thuth@redhat.com> In-Reply-To: <20240917103540.149144-1-thuth@redhat.com> References: <20240917103540.149144-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.453203-13-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/ipmi-bt-test.c | 2 +- tests/qtest/ipmi-kcs-test.c | 4 ++-- tests/qtest/rtl8139-test.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c index 383239bcd4..13f7c841f5 100644 --- a/tests/qtest/ipmi-bt-test.c +++ b/tests/qtest/ipmi-bt-test.c @@ -251,7 +251,7 @@ static void emu_msg_handler(void) msg[msg_len++] = 0xa0; write_emu_msg(msg, msg_len); } else { - g_assert(0); + g_assert_not_reached(); } } diff --git a/tests/qtest/ipmi-kcs-test.c b/tests/qtest/ipmi-kcs-test.c index afc24dd3e4..3186c6ad64 100644 --- a/tests/qtest/ipmi-kcs-test.c +++ b/tests/qtest/ipmi-kcs-test.c @@ -145,7 +145,7 @@ static void kcs_cmd(uint8_t *cmd, unsigned int cmd_len, break; default: - g_assert(0); + g_assert_not_reached(); } *rsp_len = j; } @@ -184,7 +184,7 @@ static void kcs_abort(uint8_t *cmd, unsigned int cmd_len, break; default: - g_assert(0); + g_assert_not_reached(); } /* Start the abort here */ diff --git a/tests/qtest/rtl8139-test.c b/tests/qtest/rtl8139-test.c index eedf90f65a..55f671f2f5 100644 --- a/tests/qtest/rtl8139-test.c +++ b/tests/qtest/rtl8139-test.c @@ -65,7 +65,7 @@ PORT(IntrMask, w, 0x3c) PORT(IntrStatus, w, 0x3E) PORT(TimerInt, l, 0x54) -#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert(0); } while (0) +#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert_not_reached(); } while (0) static void test_timer(void) { From patchwork Tue Sep 17 10:35:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 829234 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp213940wrr; Tue, 17 Sep 2024 03:36:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUU0bd/M9fzdep+Hm9jg0Zs3Gg18JfGfHKiw9Ih2XYGFBAk+fPZWSXlT3vZTecqFI6Fwblbyw==@linaro.org X-Google-Smtp-Source: AGHT+IEwQAcLoxqCQ6iqbNscWJgqtxAUrTqvb6kQVYQdurAybE/gipMwShCQuSJe/Z9sh83Ve7Rj X-Received: by 2002:a05:6214:5b0d:b0:6c5:5b0b:d2bd with SMTP id 6a1803df08f44-6c573b5bf62mr291760226d6.25.1726569408489; Tue, 17 Sep 2024 03:36:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569408; cv=none; d=google.com; s=arc-20240605; b=igzOf1fevCEz431iJ5mytFOaOJxxADNQuRq96OzSUwqLY0iD2KDTqd44TKE837xLeg gYtpAaa+Ctm+dheZOzDoj/jmGwkYU27wDD+o/snzBJNcYJEK9S/mhsvY37bCBLrkN7eb HkD5Bxi7S3igIg/7fJUXQoy+/EdjchO2QcO3JqCRUMyjUpqjHXfIRiB8XvJQUsSvU5vT FUzhZ9wURnwEC8fwNe+X4AHnKDP94JL+Cqp4UbopmYqzO3G9EOP2dL1Qpg5mRninxQtB zS0lZCYNanw1h4GBEc4snkR0fozVwPnBTjkXIQQCBlyHBp7WImGQsv/hOC//TLuVEq6y 8BTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TvVrh6vqILKkbVGpDKaYq80XG1PO1QYdQIXKP3XRj2Y=; fh=CsrrMFYqxLb2ncaqCW7Qx+RO/RoxmO0iSVmBprRl/p8=; b=Wqgff+9RM1hh3Pd4DuG2TJQoEUmZRGvjbCMbKg9Y4XfnyReuIRXx/nTBtwmnBINLn4 UZ4t8zMAVirHbVWEIZB0unfFYxJvHz4GBflQ/8L3HZ8/6jev5ubekiuX7tgZVt4IDFyo uawLlis667+ZfNQ8zZwzcS68425pAbb6fP96d1683nWTYaHcwk5iKhLY/ME9cECyowxH 8qiPUXILoqDYKe8XOtHW4WDWc9ZoxnzqQwMnPpOy1nA6sJMVHl/8lxrpJDTTi3tcHPok HOcmf2Emt7zELpaZoYpGv3O7LtVbVjHvFCnQ36YD1qcqA2NvoW0VLAeONiQ8WymghQCT TVTQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TPMTiCiR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6c58c620fe0si78827656d6.113.2024.09.17.03.36.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:36:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TPMTiCiR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVZH-0004Xc-BJ; Tue, 17 Sep 2024 06:36:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZ8-00044G-AA for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZ6-0007LE-Q4 for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TvVrh6vqILKkbVGpDKaYq80XG1PO1QYdQIXKP3XRj2Y=; b=TPMTiCiR6tEYt7JWKKrQbzVQ7Hp7VSUjXqqtZsEwEaIlK1C8rHK7JaIZTjuRakZd8e+KFt 5cGtDV3mxoZ8aQAlsdNiKjEedXRArI7OQKhKomM7ELciLlJsJ4el0nzjQ51tKr8nQxD6SP 5w8wkQKYtCJ+/oz52w83aOtUCtD0Cog= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-247-1uBcJolTNMOzqnuJGc3luQ-1; Tue, 17 Sep 2024 06:36:08 -0400 X-MC-Unique: 1uBcJolTNMOzqnuJGc3luQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A61431956069; Tue, 17 Sep 2024 10:36:07 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.158]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6ED971955DC7; Tue, 17 Sep 2024 10:36:05 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier , Richard Henderson Subject: [PULL 09/17] tests/unit: replace assert(0) with g_assert_not_reached() Date: Tue, 17 Sep 2024 12:35:32 +0200 Message-ID: <20240917103540.149144-10-thuth@redhat.com> In-Reply-To: <20240917103540.149144-1-thuth@redhat.com> References: <20240917103540.149144-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.453203-14-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- tests/unit/test-xs-node.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/test-xs-node.c b/tests/unit/test-xs-node.c index ac94e7ed6c..2f447a73fb 100644 --- a/tests/unit/test-xs-node.c +++ b/tests/unit/test-xs-node.c @@ -212,7 +212,7 @@ static void compare_tx(gpointer key, gpointer val, gpointer opaque) printf("Comparison failure in TX %u after serdes:\n", tx_id); dump_ref("Original", t1->root, 0); dump_ref("Deserialised", t2->root, 0); - g_assert(0); + g_assert_not_reached(); } g_assert(t1->nr_nodes == t2->nr_nodes); } @@ -257,7 +257,7 @@ static void check_serdes(XenstoreImplState *s) printf("Comparison failure in main tree after serdes:\n"); dump_ref("Original", s->root, 0); dump_ref("Deserialised", s2->root, 0); - g_assert(0); + g_assert_not_reached(); } nr_transactions1 = g_hash_table_size(s->transactions); From patchwork Tue Sep 17 10:35:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 829239 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp214767wrr; Tue, 17 Sep 2024 03:39:24 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU2dx87ZOt7fvDteYHAbodjo9rHllp0nf4Ki+SV2X42UEO/+oQ0eHkRR/aIx7W/tf+fYteXcg==@linaro.org X-Google-Smtp-Source: AGHT+IEXnHCA28fqEhS6X7URjyMf5q5q8Xg8V7cvWW2/htzSkxUfyiML4tGCZBI6tB/ZNNJOKG8S X-Received: by 2002:a05:620a:1a27:b0:7a9:bd11:38d with SMTP id af79cd13be357-7ab30d349e7mr2771387185a.27.1726569564019; Tue, 17 Sep 2024 03:39:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569564; cv=none; d=google.com; s=arc-20240605; b=IjFXzzF7JPov2SMDUoMvtSdlYequ3W8MGjBfIbTIGHFECdj7TPVfHZItUCAzLFViTR ZD8RRtdGVnd8SiEaDAIsf4Q9K3G5RgbfLhVecI3MCOgVTjpcielNFobTLDKakPeIgsdL DO73UXQYUDvoxYN09uQu8icja5oEjyt2nAw2pG9SU/I8lnGnGF4KKsqi5FU1FLk0NgpZ dUAPGtsQtYk8e9VxWqxlSm9/Iz8oObPGLxA8IJND6H34PV+8DVbMSqqLUFwkY7FPXlqy nnTupCTEwYNfUN++v1dlCo2k8pVXe1zneF9gc/tfxBntyjVOoQ0mkZxo9n5tLeeZUhn0 wo8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v26HX4KfoH9FCWLXXwdsNQjAtd1ysIY14tKOsxB2S4Q=; fh=zncCS4ASCFUIZRNByWxwtFkopqYw5r/XelbqsPN6tKk=; b=Tq+wGl/C4AHe/Rt5X8aiwZ0+k6AM7TVNCTjPAiUmxzC6j3G65pjyfmunwa0O8CP8mS LuoSbIWbw1JuZQ83l7CNdzo2YA/W/1rO5us054ylSmAOsoyO7/LTWRn4rPKXXTztDxsO +qhJe4jmC71YvZOGb00LuFqgn1WEzWfUUryMoJHvyWiTdp4yPQke79QazZd6B06qNdFu cx9T8D8KPxxUElW+8gdnCwi9oK1jqyho7+VPFZb5rVj2wWCSl/AmdX6DBaiKL2gDdWt9 NH7R0+qh7XxcLb2TaFYvLUr6MNlY7Mw9xPAElzud1KTZQ4luokNZjxeqk/JmRd7zRm6g mkQQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WviGX4aG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7ab3eb55114si795270085a.246.2024.09.17.03.39.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:39:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WviGX4aG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVZe-0006ge-Du; Tue, 17 Sep 2024 06:36:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZF-0004kt-7K for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZB-0007Lv-0w for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v26HX4KfoH9FCWLXXwdsNQjAtd1ysIY14tKOsxB2S4Q=; b=WviGX4aG+E8ZsQzO7r0eddMk8zlKP7Pc4KN+i8fdlC6WPmsUlba5fPPrqkaV/NSN4OIFiL 2Wg/AVx8U0enK17U9UsbGItxhQO8rRJDnZYuU+Yina5rtmtsBQA+nfyXNZHaYdcX19kcQ9 LNu7W0iQ+Ej/49Ehmsv4NbVAlvJWQF0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-M8bql_FwP96PkuWRzHnlYw-1; Tue, 17 Sep 2024 06:36:13 -0400 X-MC-Unique: M8bql_FwP96PkuWRzHnlYw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF0D61955D4E; Tue, 17 Sep 2024 10:36:11 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.158]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3CAEA1955DA1; Tue, 17 Sep 2024 10:36:07 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier , Richard Henderson , Eric Farman Subject: [PULL 10/17] include/hw/s390x: replace assert(false) with g_assert_not_reached() Date: Tue, 17 Sep 2024 12:35:33 +0200 Message-ID: <20240917103540.149144-11-thuth@redhat.com> In-Reply-To: <20240917103540.149144-1-thuth@redhat.com> References: <20240917103540.149144-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier Reviewed-by: Eric Farman Message-ID: <20240912073921.453203-15-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- include/hw/s390x/cpu-topology.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h index a11b1baa77..9283c948e3 100644 --- a/include/hw/s390x/cpu-topology.h +++ b/include/hw/s390x/cpu-topology.h @@ -57,7 +57,7 @@ static inline void s390_topology_setup_cpu(MachineState *ms, static inline void s390_topology_reset(void) { /* Unreachable, CPU topology not implemented for TCG */ - assert(false); + g_assert_not_reached(); } #endif From patchwork Tue Sep 17 10:35:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 829238 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp214705wrr; Tue, 17 Sep 2024 03:39:12 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW2GHu8WbW9/ajoAt7/BjRYhUmVOL/GXRvEXRt09fzCMnhZDKxLrUJUbELY5z7JHD0ExYd4dQ==@linaro.org X-Google-Smtp-Source: AGHT+IEC4esBDZik6kaK2dzB+qPofGBtemOYxsL+8K2dDsR4yPcjIYk60GEZh3lFNGsfey7OVPwM X-Received: by 2002:a05:620a:640c:b0:7ac:a077:6a3e with SMTP id af79cd13be357-7aca0776d13mr148861785a.39.1726569552543; Tue, 17 Sep 2024 03:39:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569552; cv=none; d=google.com; s=arc-20240605; b=A7Y4yNIr0BdLuRwpi/1MJxtF4ekL0UnTUBarF0Eu0gPoaFGKqMFZ9+NV0YX/IoWlcV teBPVHX4Xap3sSZ0DRvIvlANJz/9LJ0gs627VhglKHjhRt4CfrpFMmREwovGo3DTw+iR MwVkCdhw/d0zk4C8HphnKPMojOA+d1Y8LmygXGnEIV6tM7Np6/DJj4/WEiH0GN1ZsQmS 77w2H7acrdrAnlvMx9nAOtKEsJHacGkTPL/l4RidGieYyGoTQbYqcoktWjcMLVXR6UJy bRLidXfRCT6Q5GVm/olJYPR1942bgIiVBRFDfE6DqgpXVs4szOw0weybNRmIZ9eNOqUM jU1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=la+StKHLdWyfgIDn0o+CQJClKABKz7FpaTl7t/apb1g=; fh=CsrrMFYqxLb2ncaqCW7Qx+RO/RoxmO0iSVmBprRl/p8=; b=SIIMWM/Imf9NA8T3TsAMGzajEBsTB4OFqnHmTP2gE91EUQFicxrXmG+ZQFuucZOreJ fJnBCVt3725TJtrBu2Ai9tqTwaH2NX7+z9g/GQq70fzPMJ0ZdOEKkhiKvKk4bP3AN4ZO BctpMSgOsRF2vCUUtpQRyJ59hKCWyzpBLC8yi9TS9WS8GO9GpCsmI+GHgEbz+JiklsNV lPFIYgmDeQ5Fmmt3eZe8576yC2/vdQZNIr8YQRnK5X6PPqgjcFnfkPtGD5MJH5BfL3iP A5Q2q1dQ5f2JEgEvAwUfGnlWExUbES/M/xk1sp4UemwZ+5sRHr5t+++DWROcLrUspapl ONLw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XSirlGuo; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7ab3eb54d2fsi814689285a.333.2024.09.17.03.39.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:39:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XSirlGuo; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVZg-0006xA-Ky; Tue, 17 Sep 2024 06:36:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZI-0004zT-UL for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZH-0007Mq-C0 for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=la+StKHLdWyfgIDn0o+CQJClKABKz7FpaTl7t/apb1g=; b=XSirlGuoZhYqTbGOgbemAOSbP0IUpkuAWnHdl/1YbHIlViAZj0SX1qUBqgviMUEpUg0Nxo SyPa0gc9mDG2h0vdD6eoY0EzFeiy9fpNVukDkaf/1053q88lyJuT40REd7sxenWiOikAuo FpmZFIELuegwXJxJU4NTwM/pnjNbzZs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-yl2ZPdjdOTy9M4or0P3FQA-1; Tue, 17 Sep 2024 06:36:16 -0400 X-MC-Unique: yl2ZPdjdOTy9M4or0P3FQA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 563B21955D4F; Tue, 17 Sep 2024 10:36:15 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.158]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 497A019560A3; Tue, 17 Sep 2024 10:36:12 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier , Richard Henderson Subject: [PULL 11/17] tests/qtest: replace assert(false) with g_assert_not_reached() Date: Tue, 17 Sep 2024 12:35:34 +0200 Message-ID: <20240917103540.149144-12-thuth@redhat.com> In-Reply-To: <20240917103540.149144-1-thuth@redhat.com> References: <20240917103540.149144-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.453203-24-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/numa-test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qtest/numa-test.c b/tests/qtest/numa-test.c index ede418963c..6d92baee86 100644 --- a/tests/qtest/numa-test.c +++ b/tests/qtest/numa-test.c @@ -162,7 +162,7 @@ static void pc_numa_cpu(const void *data) } else if (socket == 1 && core == 1 && thread == 1) { g_assert_cmpint(node, ==, 1); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -207,7 +207,7 @@ static void spapr_numa_cpu(const void *data) } else if (core == 3) { g_assert_cmpint(node, ==, 1); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -257,7 +257,7 @@ static void aarch64_numa_cpu(const void *data) } else if (socket == 1 && cluster == 0 && core == 0 && thread == 0) { g_assert_cmpint(node, ==, 0); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -305,7 +305,7 @@ static void loongarch64_numa_cpu(const void *data) } else if (socket == 1 && core == 0 && thread == 0) { g_assert_cmpint(node, ==, 0); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -367,7 +367,7 @@ static void pc_dynamic_cpu_cfg(const void *data) } else if (socket == 1) { g_assert_cmpint(node, ==, 0); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } From patchwork Tue Sep 17 10:35:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 829237 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp214686wrr; Tue, 17 Sep 2024 03:39:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU+MHeQafYy10p7Jw+8Ls26E4nVjhYzl+wp7XzjR5K3phShx0k1KfSf/VWJPJX1+WTCGnzXBQ==@linaro.org X-Google-Smtp-Source: AGHT+IEk55e0vfKr7gH2jzCHKBd0OG/y3Xvxd6IvLdaUKZhiwt6SI3CWbseKfNvjKy6r7RpI2R5X X-Received: by 2002:a05:6214:2dc7:b0:6c3:6799:ddef with SMTP id 6a1803df08f44-6c57df6f95dmr189266566d6.3.1726569547512; Tue, 17 Sep 2024 03:39:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569547; cv=none; d=google.com; s=arc-20240605; b=MSzYzFZBOJWmS5KDdLqf87U5EO4jlD/3UFA1x4yOLuKISC8KC87VhaYqdDy5ZpCnTI k7bys/SqRpw5d4OXMPiyFaFASa+S/LQSu1+rCrs1nFaMQKFU45JaKsNaI9ZuokqZSU9w HrRAK85ch8Gzduk0Bsppa30iGifUjBHBD5wkKW/RD/6sn/rZPIWMJT2Y3/vBuWqtW9cY 5br3822+nXzOt+c3o6V3t473Qu9Lv7XTemlFFNRn2PsEbrftq6qCdpfdpFPvfqewHvqs 5CRBXeyNRIF6B9mePkZL1AMbgEQwozXHTEQeeBAJHqQQm1W8kjU6NVIQ4dYNclnDFoZa XJtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3NnS7zxsGL5esjGBlxR9UFclzM6uubRuh3Jvmzpw6i4=; fh=CsrrMFYqxLb2ncaqCW7Qx+RO/RoxmO0iSVmBprRl/p8=; b=UcOQ7CubYqBWf8EZ6Dhx5rQ7nSDo358wVpTdGJ3mfJGI6/QXuFV0OyiWM033LgPfA5 maHxzN0zjnZ98JGbeT5tPEEsb496cHd/GGtwktabmIiMAvf4hJ5fI2bg4D2amQmkGmFf hJ0XlElhkkNxV1q+W5XL2sXSWq+iuP2QcY4hgdgf/nzM3Z6GHylZ7yrw1CAMxu9llFDC 4fUOgR1O1piUgJU/raDG25+shk2X/Mptmmc4korMjzkPvaq/Kekw6E5u60NlMfL5wtHW PjmahNCdV2HiMlo7/F8SJ8v2cyyikAk9TuoqUm6I0WRoDm2xYAYxZdJcgEPXG3PgF8xc YiaA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KS4fFAhb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-459aaf34bcdsi78940941cf.624.2024.09.17.03.39.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:39:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KS4fFAhb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVZg-000730-SI; Tue, 17 Sep 2024 06:36:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZH-0004uX-N5 for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZF-0007MW-TP for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3NnS7zxsGL5esjGBlxR9UFclzM6uubRuh3Jvmzpw6i4=; b=KS4fFAhbqTZlZJG9WYArQrFmDfPjrwyJJIwB8fWqyYsses+kXzJLbM2rWtCb6PC6tcZU5X k45N0Ke3B8NMbMf8anP2ME1leJQtplQq2kLjzWAE+h81sllnXTjOy5wc+73U6lqo7dj22p dDhP/ZosM1U6KxnGhg+Lwun9ex2NI2E= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-0csRzS_mMQS9mAHNVVFdmg-1; Tue, 17 Sep 2024 06:36:18 -0400 X-MC-Unique: 0csRzS_mMQS9mAHNVVFdmg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F00711953941; Tue, 17 Sep 2024 10:36:17 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.158]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 15E4C1955F54; Tue, 17 Sep 2024 10:36:15 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier , Richard Henderson Subject: [PULL 12/17] tests/qtest: remove break after g_assert_not_reached() Date: Tue, 17 Sep 2024 12:35:35 +0200 Message-ID: <20240917103540.149144-13-thuth@redhat.com> In-Reply-To: <20240917103540.149144-1-thuth@redhat.com> References: <20240917103540.149144-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.453203-36-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/migration-helpers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c index a43d180c80..0025933883 100644 --- a/tests/qtest/migration-helpers.c +++ b/tests/qtest/migration-helpers.c @@ -76,7 +76,6 @@ static QDict *SocketAddress_to_qdict(SocketAddress *addr) break; default: g_assert_not_reached(); - break; } return dict; From patchwork Tue Sep 17 10:35:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 829235 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp214275wrr; Tue, 17 Sep 2024 03:37:49 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWjKvPWViL5yF+CkzsECcppUZCzt+4d1eYQTAm5Lc6F4tSgcOtlJQ4WkW1vXrk6HyRZJG6ZxQ==@linaro.org X-Google-Smtp-Source: AGHT+IG70MQb8Q2vgSekx2k57Tpw1z/7gvIU4rP+vuW6RT8TbkDdRWqU+tEBnLA19gC0VUHM7eH2 X-Received: by 2002:a05:6214:3f8e:b0:6c5:1614:9c59 with SMTP id 6a1803df08f44-6c573582ed5mr258664426d6.31.1726569469039; Tue, 17 Sep 2024 03:37:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569469; cv=none; d=google.com; s=arc-20240605; b=JWGpFDeZiM4jvi08xwpn9FXm483ccUdOA5fl0JdAtewAyLMpjnU9MeTsnGWzFYX+hU K5zvvfjN2X5+uwSe3e69XHa/w9wr3fgSNutQkFWYycND6k/9Fdgm7XOiEtFSEtZmncql 3qQEhhprSaCPdJQXEwlHQ1Du2g4+J3fwh5ci8fqkhn8vhxel2h38BEejOuOGJe1QADsN PWNLdNEN3+YI4MkKvrEx5cpznYp/Rvy3zNo6L55BSlMK0JOlo9hnxZp51QLJnsELMwLP 8stA7XYgQVJlVEdPk6ixEULiRySWNFbfap0BAlZQ7Bywf1teP89vIAhOvr8t+lOd50xe xUHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RrpOSC6Rg72NNwlied+iu+T4AhUm/+ZVKk3vGDHCg58=; fh=O2CrEh5mhIHeEcAGIBhUzevFkYJbEzl3B4GiSlAkA7U=; b=IHI64IGpvie2nvB1hi2pT5CUzqWEuYe3Y6aPBFV/vNHrOLevm/Ix19XWgLkjhGMfQc RIV1k11M0DllT9nxTOWvGtKm7BpXCcQKQ7ibkpgga2BqB0UAlNtpXIzo+LbkAC0/wUXQ tmbrtz+s3qYfo0w+9JGvifsJ015hK0Jbcq8Xy2Hd24rjVhfQRRwOUaCZ89Jf++s+T0jv K2vs6wz25BPcj1EvcXb00jSwKSLFxdPTtBkxRWyDiUgDQegDk6CoMEA50sc0ul8lJUKJ 8sJe3/lrzKSo9AFiBWgYW9gfYC6TUsGCDgC6ut7dXV5y9chOl7o+6QpeJ4s5laBbmq3P o9JA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZA2Jy5LD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6c58c7ad8b3si79613896d6.341.2024.09.17.03.37.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:37:49 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZA2Jy5LD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVZi-0007DF-DG; Tue, 17 Sep 2024 06:36:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZO-0005MB-SC for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZL-0007NX-64 for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RrpOSC6Rg72NNwlied+iu+T4AhUm/+ZVKk3vGDHCg58=; b=ZA2Jy5LD15uQ5SEWsgbws3GqPew5ZERg1I3S20B3q/+NQWXPb3PspN945Cs+7LuGQzZFYT swW6pX/4NRVdxNkKtojH4etNgPJMiR2jzU+gZMVI/q+A8kgzTiVanzJ9Y9qChvsNwPAS8o BiFGcmdkI8RC9L0MLHCyv80bLpeC9mY= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679--MH9P_I4PIeBPieLQxUDHw-1; Tue, 17 Sep 2024 06:36:21 -0400 X-MC-Unique: -MH9P_I4PIeBPieLQxUDHw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7390D1955D50; Tue, 17 Sep 2024 10:36:20 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.158]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9C10D19560A3; Tue, 17 Sep 2024 10:36:18 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , =?utf-8?q?Philippe_Mathieu-Dau?= =?utf-8?q?d=C3=A9?= , Pierrick Bouvier Subject: [PULL 13/17] system: Sort QEMU_ARCH_VIRTIO_PCI definition Date: Tue, 17 Sep 2024 12:35:36 +0200 Message-ID: <20240917103540.149144-14-thuth@redhat.com> In-Reply-To: <20240917103540.149144-1-thuth@redhat.com> References: <20240917103540.149144-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Sort the QEMU_ARCH_VIRTIO_PCI to simplify adding/removing entries. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240705124528.97471-2-philmd@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Thomas Huth --- system/qdev-monitor.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index 6af6ef7d66..acdc8b73a3 100644 --- a/system/qdev-monitor.c +++ b/system/qdev-monitor.c @@ -55,12 +55,17 @@ typedef struct QDevAlias } QDevAlias; /* default virtio transport per architecture */ -#define QEMU_ARCH_VIRTIO_PCI (QEMU_ARCH_ALPHA | QEMU_ARCH_ARM | \ - QEMU_ARCH_HPPA | QEMU_ARCH_I386 | \ - QEMU_ARCH_MIPS | QEMU_ARCH_PPC | \ - QEMU_ARCH_RISCV | QEMU_ARCH_SH4 | \ - QEMU_ARCH_SPARC | QEMU_ARCH_XTENSA | \ - QEMU_ARCH_LOONGARCH) +#define QEMU_ARCH_VIRTIO_PCI (QEMU_ARCH_ALPHA | \ + QEMU_ARCH_ARM | \ + QEMU_ARCH_HPPA | \ + QEMU_ARCH_I386 | \ + QEMU_ARCH_LOONGARCH | \ + QEMU_ARCH_MIPS | \ + QEMU_ARCH_PPC | \ + QEMU_ARCH_RISCV | \ + QEMU_ARCH_SH4 | \ + QEMU_ARCH_SPARC | \ + QEMU_ARCH_XTENSA) #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) From patchwork Tue Sep 17 10:35:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 829236 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp214675wrr; Tue, 17 Sep 2024 03:39:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXag8xJK1aCiamzuUQrwVbxCoevrts+PGKnsqEZ5J3sM+3wT8KjpbvQ2g72lxE59rEZLfcVqQ==@linaro.org X-Google-Smtp-Source: AGHT+IFSh0XRJkFAt4ox/H8QfLYjYhQVLDrfoOjtM7MMIqVU4UsnsLu1jWZgU8o4CEqzueZxuKxX X-Received: by 2002:a05:6214:5bc9:b0:6c3:550b:1eb with SMTP id 6a1803df08f44-6c57dfb80eemr220797506d6.24.1726569544694; Tue, 17 Sep 2024 03:39:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569544; cv=none; d=google.com; s=arc-20240605; b=EhTmgqqi1x8czFXI+EvyxQe1JAJEmq3RqRy4uCLgYtdCGr3yg1HShJDue7ndN+4vPP 43vricym1f9gnMDXV5fiKXcdAvIPLXbMAUpAyg7Z+00J9gjRtGASuVNbd/IxIJkxK/dy 7mveFq+CGKy3m2CWzcWkCZwE8fuN2VrPWFQNI8yWK/1wRhqBSFtEy7Cb/aDTXiQ1rLoS GXWeJ/0jWnFusS/nXgivDjRM6kgOtYM94XcznHZ2bNKdMcCM7zNDbMF7EorTPkihYGmI ip8sIRvpZ3KCX5rqoDktFFOqCBKMroUC4dIt+BSvGGRfUU7IdC9tiiD0L8pgVWgDiJsR v9XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=n4EpXxOh9friBx8H3P9NsHJCHGUYXkNGqZuppeYoFEw=; fh=tOREyZHlK9Diwyw/7bj5IUyLT4I5EVkj5DE8XDtMiTs=; b=W7aD9AYpUlWNQAwDr8TzWzknS4csauRraeijgGwjwYgTwDaST3owzn0epiGkUFs+8b bHa3Ddq3sb8ZdhtBw+Nwf72ZM0u4qSLx5fkmr9vgO9nf4vM3JD5fdkE/zO5AHur/fa9J daPN/RKqqoxPnliB3in+vplOxbCQVOAAmnRSRA5YHf2fG1bocdbPfw3qjiTU29F+nnOB m1L2GXs8N1ewi2X7DT9EFztmeF1T26BOi0m9GBiidSNEIluYA40JQtqPzMawRZRs4Xnp OvKHN5nHp3WvdPG2dg+5bgWn/481b+egb/eN8iSZwfMTvJMKWbpkpeqws54bsoYiaxhX Kb+Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=imPwT1L4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6c58c68b2f1si79596036d6.208.2024.09.17.03.39.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:39:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=imPwT1L4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVZj-0007HE-9a; Tue, 17 Sep 2024 06:36:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZT-0005fc-LM for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZS-0007P2-7j for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n4EpXxOh9friBx8H3P9NsHJCHGUYXkNGqZuppeYoFEw=; b=imPwT1L4qqWq4klL+vj3TOsA/IMViiKrTXiFnXYMa5LOWGBI+TbL6YnzLNqRZLe9Xcp1PG yNypSXqscny2F6LciBCZ3lepOBNlgvP2CSNYMemLG4xFgIOT7c2vXxlAWmcYykA3iBhSll IQdAuzJy+hxTYgTxTyQw2D4dVqCN7ug= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-82mHJqaGOwy5l_F4fF5z0g-1; Tue, 17 Sep 2024 06:36:31 -0400 X-MC-Unique: 82mHJqaGOwy5l_F4fF5z0g-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B354F19560BF; Tue, 17 Sep 2024 10:36:30 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.158]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 85A4A1955DC7; Tue, 17 Sep 2024 10:36:29 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell Subject: [PULL 17/17] .gitlab-ci.d/crossbuilds.yml: Force 'make check' to -j2 for cross-i686-tci Date: Tue, 17 Sep 2024 12:35:40 +0200 Message-ID: <20240917103540.149144-18-thuth@redhat.com> In-Reply-To: <20240917103540.149144-1-thuth@redhat.com> References: <20240917103540.149144-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell In commit 1374ed49e1453c300 we forced the cross-i686-tci job to -j1 to see if this helped with test timeouts. It seems to help with that but on the other hand we now sometimes run into the overall 60 minute job timeout. Try -j2 instead. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Message-ID: <20240916134913.2540486-1-peter.maydell@linaro.org> Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuilds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 1e21d082aa..95dfc39224 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -62,11 +62,11 @@ cross-i686-tci: IMAGE: debian-i686-cross ACCEL: tcg-interpreter EXTRA_CONFIGURE_OPTS: --target-list=i386-softmmu,i386-linux-user,aarch64-softmmu,aarch64-linux-user,ppc-softmmu,ppc-linux-user --disable-plugins --disable-kvm - # Force tests to run in series, to see whether this + # Force tests to run with reduced parallelism, to see whether this # reduces the flakiness of this CI job. The CI # environment by default shows us 8 CPUs and so we # would otherwise be using a parallelism of 9. - MAKE_CHECK_ARGS: check check-tcg -j1 + MAKE_CHECK_ARGS: check check-tcg -j2 cross-mipsel-system: extends: .cross_system_build_job