From patchwork Sun Nov 24 15:43:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 180131 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp2067038ilf; Sun, 24 Nov 2019 07:44:03 -0800 (PST) X-Google-Smtp-Source: APXvYqxflvxX1Pd8i5yE1Kepi0CA3JI4I30apWkBYGBu8yfJFWKxupJWiH6/aDHGXXVF9NM798ol X-Received: by 2002:aa7:c047:: with SMTP id k7mr13498973edo.58.1574610243121; Sun, 24 Nov 2019 07:44:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574610243; cv=none; d=google.com; s=arc-20160816; b=rMUGpM0xRLxZ4rboCEXoz6y/hGam2vV7I/fxBc2WLuj6N90lDyhu3o/LnFxydYgriD nJShu18Qe1cklnAdtRpNAFWjvZLIa1zsuFTLN+Vo5REq0LKQCGo0hEDqtJCdpNDd/U1L vMDWXPEhTB6sm+k07AhOBFI1AG+5L2c4vih5odcvDBji5seU16C6X1VVD6ssYk0wy8mp 7Pi45OG3JcKlHFuReqkfifrj8x75mgYxUzEiYLMySf4kfdr0s2dN/xNxtKO9io+L01b7 Aa82eQJeOAIEk+/n2WqN0pctD0wC2dm9t7Zqcp/nTHWDQJF9vqMieLjI6BnpL/FKl8GM 8jcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=7GoVKZppoRs4H8MV5EKljB+lt4NwFU2QYQ4kHf9aeFM=; b=l+xCr4vdHjOWgiA9lJjgXs3Azk4OkR8L5vm+Ges3Irpof6bCIwyH73vV16iJjMLsqj o6BquW9pfMWPKxV08A57vTTQvQHOOCm+Nds2zBRLH0I5NLZkNhdo3kfZLbkU5rkNLNvb St888Aasr++l5rmaIXZI/IrffPFC0CtVo/hVlG9Hhj+GtepjC70YwhlY26n7Py9SdIc7 l3fPsNxKu+209engPZqqYpJ6DUVWVTwF5UPWCNSPNX1JvBHED0wG9HWLCZ6GrQTOMjt+ lUpi2xwIIMeM/DYT+mGupK2hpEOB1O+YxfdcT481sBxymJpjbuyWjis/2Ab8qyNI9k3P wg4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gcN26IH2; spf=pass (google.com: best guess record for domain of linux-serial-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9si2709132ejm.397.2019.11.24.07.44.02; Sun, 24 Nov 2019 07:44:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-serial-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gcN26IH2; spf=pass (google.com: best guess record for domain of linux-serial-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726004AbfKXPn6 (ORCPT + 1 other); Sun, 24 Nov 2019 10:43:58 -0500 Received: from mail-yb1-f196.google.com ([209.85.219.196]:34787 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbfKXPn6 (ORCPT ); Sun, 24 Nov 2019 10:43:58 -0500 Received: by mail-yb1-f196.google.com with SMTP id k17so4994062ybp.1 for ; Sun, 24 Nov 2019 07:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=7GoVKZppoRs4H8MV5EKljB+lt4NwFU2QYQ4kHf9aeFM=; b=gcN26IH29ommNyDhhBdS4LUjBSrhnXAY5ZK1+Yfk+Ut2ikTr3yycJPIH/+RCBpTxej N3TJayJ955EbCu045tGM2rEeL1myhqCn4BIxYOU16q0Shyq0hjbSHBw/MRfXxxVnzG2a hoiIRe8KalUW2+Fl4zEqdIbGYkOibTEl4kdeDcDIM9ExUeU8to+bnMXaGRqKOFlooUmy OWxikAkr9yZ/fEAc3KUdjeUrD7Tzb78Z4PkiftSuvzZAtAvNtPDacWCgA+Kyxle6eoo2 H4tCC/DHHg6AbTdmSWPMpy8WHZHMZBfOfC2TZhYTLcO3OoW0VYxhjd/iz+a8H9oY7niu m3XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7GoVKZppoRs4H8MV5EKljB+lt4NwFU2QYQ4kHf9aeFM=; b=K6o3r7afNKrOmRtBd6/NZAh9q7nwFzesmDVNfhnt76dYfIMx3tNN9y7Lnonw3J+xls 4EbvGDNq3Wy69GZ8NIeoinkN+3UCfPKJh6a3Z4WDxL+TjMudScWMBI5Z4OPMloOv6fDw GNaUwSyVwEwvENE4cuvYesQad3dP3RFM7KbTE7TXeD++v45rbiPT6etn1C0Sg9wgTq4e 7lYKck+5DlHblE1HGNeMjvVVE+bjESzDgjKi/BPqTwKy3Biyk5boirBaZCoQPcxCysNl WdIh1kAQ2bgq6sFtZHTv1JGBZepwYvdtsFMTmALthB3dOuPct+nQUNG0czC+N8Z/ZkzJ 1K5Q== X-Gm-Message-State: APjAAAXTSEhC0d+ypuPVONMMLXaJfIeAPw2s3VH+WvQ9gYiNBML8XylY mS4Ny82zSozpkytkqra2aClAPA== X-Received: by 2002:a25:8281:: with SMTP id r1mr19218080ybk.489.1574610237279; Sun, 24 Nov 2019 07:43:57 -0800 (PST) Received: from localhost.localdomain (li2093-158.members.linode.com. [172.105.159.158]) by smtp.gmail.com with ESMTPSA id h81sm2222564ywa.78.2019.11.24.07.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2019 07:43:56 -0800 (PST) From: Leo Yan To: Andy Gross , Greg Kroah-Hartman , Jiri Slaby , Bjorn Andersson , Stephen Boyd , Nicolas Dechesne , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH 1/2] tty: serial: msm_serial: Fix lockup for sysrq and oops Date: Sun, 24 Nov 2019 23:43:33 +0800 Message-Id: <20191124154334.15366-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org As the commit 677fe555cbfb ("serial: imx: Fix recursive locking bug") has mentioned the uart driver might cause recursive locking between normal printing and the kernel debugging facilities (e.g. sysrq and oops). In the commit it gave out suggestion for fixing recursive locking issue: "The solution is to avoid locking in the sysrq case and trylock in the oops_in_progress case." This patch follows the suggestion (also used the exactly same code with other serial drivers, e.g. amba-pl011.c) to fix the recursive locking issue, this can avoid stuck caused by deadlock and print out log for sysrq and oops. Signed-off-by: Leo Yan --- drivers/tty/serial/msm_serial.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 3657a24913fc..889538182e83 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -1576,6 +1576,7 @@ static void __msm_console_write(struct uart_port *port, const char *s, int num_newlines = 0; bool replaced = false; void __iomem *tf; + int locked = 1; if (is_uartdm) tf = port->membase + UARTDM_TF; @@ -1588,7 +1589,13 @@ static void __msm_console_write(struct uart_port *port, const char *s, num_newlines++; count += num_newlines; - spin_lock(&port->lock); + if (port->sysrq) + locked = 0; + else if (oops_in_progress) + locked = spin_trylock(&port->lock); + else + spin_lock(&port->lock); + if (is_uartdm) msm_reset_dm_count(port, count); @@ -1624,7 +1631,9 @@ static void __msm_console_write(struct uart_port *port, const char *s, iowrite32_rep(tf, buf, 1); i += num_chars; } - spin_unlock(&port->lock); + + if (locked) + spin_unlock(&port->lock); } static void msm_console_write(struct console *co, const char *s,