From patchwork Fri Oct 4 16:03:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 832729 Delivered-To: patch@linaro.org Received: by 2002:adf:8b52:0:b0:367:895a:4699 with SMTP id v18csp853975wra; Fri, 4 Oct 2024 09:04:39 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWrgswVQw5qkb6uOMpJxobYDKT0s65bF9I9tRPyyZ9Fo9khMBQbu23iLH4AUTj4w2/3qaM8qQ==@linaro.org X-Google-Smtp-Source: AGHT+IF11CYlN/0SN+VKe8k0EDNvWFA7fOm0nSFKvamGgaNWVALJEibCQA5jNJnv/qbTALQkB5gL X-Received: by 2002:a05:690c:fc2:b0:6e2:1864:cf14 with SMTP id 00721157ae682-6e2c6fc6828mr33780937b3.8.1728057879429; Fri, 04 Oct 2024 09:04:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728057879; cv=none; d=google.com; s=arc-20240605; b=luN4SNFsiGPpx2TP09rmmRYy+1pwpDBj2qhkPGtfjJ75hriEu+JMCsFlx8Lq2SQQ8W VziI8qBtzIrqjrZivAxoeF7EjV6ROoib85PVKayN+qNRurPREHWjw+n4mZzlc43MUy3o tTYxdR1ad9nPtWylgc+2XD8cK08hJhWlOEtMM4FjMhs8c6VlGg/hDSOexQZUKC/Z20rA G519JRS/6+vDg83lhWdiXJZAdKUPsQu6y/xUZHIk3DCjefvpR8kbZ+/fTV5jR/HVOOk9 lJGISxM5U/dJ7K+rppTR2DZb8eTusOuvs41VXWa8N0laLyo+pNYoG+4fG94LrWkhthbi yVnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=DZrlM9vH2JiPiE2ATZG5uPX6sco/jY6VeaG0J4tQo1E=; fh=IMXbw0xx+6Q/2UEl1nyvDi1qBBGGml6rPCVUBtTSKyg=; b=ZJxnVVtlL/EZM5uq6eqT7dHpldurpj7dv6Sgt2sFTWm0g3L1XR5cAYXY2JEUCIK9uP e431tZe2XPRAMKVEr99Xzghfki8NP7iUoo0V6hh5yEOG/XMw/GzC71ES3v0Ckkatqex4 u0nnucFY5WFF3CqoA7oNdXl0ipphD818izUy+pCQ9Xg0dRGtOYLCTgeDL7FOtDpZXd5y s31f336WBvbYvnsestWw5aP73YtSg3UFcmM6F2MIGKumgdSPpyrrazjHiTYtppbDylSE RNgeqK7jgmlZhOaXlTJH7xjf4KR8PW9uZjZeGDkBPAIFp0AFwP/AHfUJOCmt6N/JAiqs wS2Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 00721157ae682-6e2bd677d5dsi23674767b3.488.2024.10.04.09.04.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Oct 2024 09:04:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swkmh-0001qJ-Tk; Fri, 04 Oct 2024 12:04:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swkmP-0001nQ-Pp; Fri, 04 Oct 2024 12:03:49 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swkmO-0001Tr-3s; Fri, 04 Oct 2024 12:03:45 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id D30F595566; Fri, 4 Oct 2024 19:03:29 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 18CC914D974; Fri, 4 Oct 2024 19:03:32 +0300 (MSK) Received: (nullmailer pid 1282505 invoked by uid 1000); Fri, 04 Oct 2024 16:03:32 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 01/23] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header Date: Fri, 4 Oct 2024 19:03:09 +0300 Message-Id: <20241004160331.1282441-2-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241004160331.1282441-1-mjt@tls.msk.ru> References: <20241004160331.1282441-1-mjt@tls.msk.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé We were including the "exec/tswap.h" header to get target_words_bigendian() declaration, but since commit a276ec8e26 ("hw/audio/virtio-snd: Always use little endian audio format") removed this method call, we don't need this header anymore. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Manos Pitsidianakis Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/audio/virtio-snd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 69838181dd..c5581d7b3d 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -20,7 +20,6 @@ #include "qemu/log.h" #include "qemu/error-report.h" #include "qemu/lockable.h" -#include "exec/tswap.h" #include "sysemu/runstate.h" #include "trace.h" #include "qapi/error.h" From patchwork Fri Oct 4 16:03:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 832730 Delivered-To: patch@linaro.org Received: by 2002:adf:8b52:0:b0:367:895a:4699 with SMTP id v18csp855073wra; Fri, 4 Oct 2024 09:06:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWwkjt1Hcn4oNerKZNXfgNdH8HimOkMoIj/2xN3i5JvUEwT522rVgUjfqC3ompF3CgYHUMOSw==@linaro.org X-Google-Smtp-Source: AGHT+IHWpd9a2NZsMonSxWiIzhr9gMS4vsdwMcNZGcQJcmb9EqCATNdUR2tdCR+Pwijn6le/MrJ5 X-Received: by 2002:a05:6102:3708:b0:4a3:ca55:ea53 with SMTP id ada2fe7eead31-4a4059202f0mr2424734137.27.1728057979359; Fri, 04 Oct 2024 09:06:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728057979; cv=none; d=google.com; s=arc-20240605; b=LtrHrqw/9a3VU5QwCIxFDPuBeRtdlocRtd3qt1BzIJT/HCJZ8Wx5+Vaa768C2/sBBI Q9g44AogoJ8L+VpqSK1kwWkaZRUVlhd9S2Z5CJ8LozO79w2u/4j/TU8XjWbCma34XlFk jgqsz97mVpAR3nDIE6drINKnPZHxoW/8VNoBj4fr3b8GCl4EHFyef5eRUAsh0Ghh8Fcx IQLc4fkJE/I4doQr8R8EUbXQTtTYdEPEzz/8Wq0FQyDCn4whLN/q7c4Svw2BTfgsZgye QUGsIw4/7LCnMOsrBLuDYRKYNkDADrANwJg7ECUlWn1J0czM6RMX2q2Z17aDRWqqW7Zw G4aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=pZXVZE/T4A+vW9a8PUfeiFrBKHp3K/eWqQlIz66waTc=; fh=IMXbw0xx+6Q/2UEl1nyvDi1qBBGGml6rPCVUBtTSKyg=; b=X9FUf/bPTvEuNOmdEdH13zam8sCD5TnAXsGztMeYLqqDYJXsBmHZO8XoPbgNZAGCM7 G/V5yrkr0XCBwDJDmcHFS5Nn5CgG4uW2fJ1fqH2lAMxVmozYIPzJcuUpAS/hSsduxsw7 hyfddPId4En9ntBNmEV3saU6RJ/PGGmLx9nv1mIMKGUDiBSONblVJBJEaHKEvcfZPayk rPEbiQzvjtupUGqGcc9l3lA8jwbUJdabnr7hNwrIumDsapMF1WjTB617QQOjsjLNEjTo Kfdk4Xtw2LNM5FguU3f4JVfc+xV3RKKKksut911I2+VytfLBOaq35FJ3xNnJPF2MT8Qk ljTg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4a412ee5ec2si11840137.670.2024.10.04.09.06.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Oct 2024 09:06:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swknz-0003Rc-4O; Fri, 04 Oct 2024 12:05:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swknw-0003FX-3q; Fri, 04 Oct 2024 12:05:20 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swknu-0001wZ-H5; Fri, 04 Oct 2024 12:05:19 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id D569195579; Fri, 4 Oct 2024 19:03:30 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 1BB8C14D987; Fri, 4 Oct 2024 19:03:33 +0300 (MSK) Received: (nullmailer pid 1282566 invoked by uid 1000); Fri, 04 Oct 2024 16:03:32 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 20/23] hw/mips: Build fw_cfg.c once Date: Fri, 4 Oct 2024 19:03:28 +0300 Message-Id: <20241004160331.1282441-21-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241004160331.1282441-1-mjt@tls.msk.ru> References: <20241004160331.1282441-1-mjt@tls.msk.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Nothing in fw_cfg.c requires target-specific knowledge, build it once for the 4 MIPS variants. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/mips/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mips/meson.build b/hw/mips/meson.build index ca37c42d90..fcbee53bb3 100644 --- a/hw/mips/meson.build +++ b/hw/mips/meson.build @@ -1,6 +1,6 @@ mips_ss = ss.source_set() mips_ss.add(files('bootloader.c', 'mips_int.c')) -mips_ss.add(when: 'CONFIG_FW_CFG_MIPS', if_true: files('fw_cfg.c')) +common_ss.add(when: 'CONFIG_FW_CFG_MIPS', if_true: files('fw_cfg.c')) mips_ss.add(when: 'CONFIG_LOONGSON3V', if_true: files('loongson3_bootp.c', 'loongson3_virt.c')) mips_ss.add(when: 'CONFIG_MALTA', if_true: files('malta.c')) mips_ss.add(when: 'CONFIG_MIPS_CPS', if_true: files('cps.c')) From patchwork Fri Oct 4 16:03:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 832731 Delivered-To: patch@linaro.org Received: by 2002:adf:8b52:0:b0:367:895a:4699 with SMTP id v18csp855389wra; Fri, 4 Oct 2024 09:06:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW4BaCIl4FIPrZiFUiyE4lWnl4TOKsQANUJRjmB8loNFSppvFoB/YK14n5skWBtSt9S6zGr4Q==@linaro.org X-Google-Smtp-Source: AGHT+IE325H4U1zCqg1APEDZvMU26KJgAzWUO815U9ZLDPKDJfOiKrvXIiUDeuafSo21tsVk0xdu X-Received: by 2002:a05:6102:4413:b0:4a3:d9da:16d6 with SMTP id ada2fe7eead31-4a405745621mr2864529137.3.1728058011319; Fri, 04 Oct 2024 09:06:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728058011; cv=none; d=google.com; s=arc-20240605; b=gfmq2K9dd+QbnRjdB8bWTlj155Vsc2ghWiRJLml/4Ac1PDNEB0a7yrpiTYez3c3z+I sRtI2XsKu+mUMztk+Kwo1RugMxgucwsn0wr1xdSkOJRrexZ7ys79pg6YLwBeysvm2qrB Sgv48/rypgMCdzPtZoXJzKUjuo8ES89QagczfNhhXZ2UntOrYsfQaj53MtTZmgLabbq7 LH/fHFuhPaZ0w38FscllzOmUxWrPugn9jIvEKS0fb+Ji8Y2uT6V/ebLhAspnGZSKFbnJ p3LQQJynyUt+7v9uOSWlhcU9I1PZBuUzWkyWWyBegfBfneZhyZRfPKzWLlpzIJTGAFs3 RSzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=jT+zooujVsLGzoT20mG6BKHIJ5eh2+ZlFdB/TXo6FsI=; fh=cS2Tln+tR873plP2hbRuf2Uwh4g+jngXB8rVjwPMBIk=; b=G+48sroI5zSJ891dSfeMyzm2bOKg2NMnoLJpXzVxFqGQTBv3nQSYvu3x1GtjMm7wly jH1bYMGgHlQRLHK7GmUfnynNVuWSuA0Dix1d1Nn803DqWOGW6F8xeEcecE+vm03N6gBk C+dYw2Z07y3ChSNOGuu5Ow1zRwTFG3Vqb3PdDZC1wuvRbGh0CBXYVR8kG4LYhjjuul/4 /dOtII4hvS3IzWcCnIU0tdDV7V81tvQrSjKx9rjTNKQkRENGmJLcsK5Md5O3Py81uGDQ fqM2JmO1TGRuo/jJMaOn74Uz8ZCDTiYbjkyV2CkM/4lvShvw5dYaR600Kx5Gmf+AwXqG cLjA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4a412e8f926si13076137.272.2024.10.04.09.06.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Oct 2024 09:06:51 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swkoM-0005ef-Ln; Fri, 04 Oct 2024 12:05:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swkoJ-0005QP-Eb; Fri, 04 Oct 2024 12:05:43 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swkoH-0001xw-IM; Fri, 04 Oct 2024 12:05:43 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id F00D59557B; Fri, 4 Oct 2024 19:03:30 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 3519814D989; Fri, 4 Oct 2024 19:03:33 +0300 (MSK) Received: (nullmailer pid 1282572 invoked by uid 1000); Fri, 04 Oct 2024 16:03:32 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 22/23] docs/devel: Mention post_load hook restrictions where we document the hook Date: Fri, 4 Oct 2024 19:03:30 +0300 Message-Id: <20241004160331.1282441-23-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241004160331.1282441-1-mjt@tls.msk.ru> References: <20241004160331.1282441-1-mjt@tls.msk.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell Accessing another device in a post_load hook is a bad idea, because the order of device save/restore is not fixed, and so this cross-device access makes the save/restore non-deterministic. We previously only flagged up this requirement in the record-and-replay developer docs; repeat it in the main migration documentation, where a developer trying to implement a post_load hook is more likely to see it. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/devel/migration/main.rst | 6 ++++++ docs/devel/replay.rst | 3 +++ 2 files changed, 9 insertions(+) diff --git a/docs/devel/migration/main.rst b/docs/devel/migration/main.rst index 784c899dca..c2857fc244 100644 --- a/docs/devel/migration/main.rst +++ b/docs/devel/migration/main.rst @@ -465,6 +465,12 @@ Examples of such API functions are: - portio_list_set_address() - portio_list_set_enabled() +Since the order of device save/restore is not defined, you must +avoid accessing or changing any other device's state in one of these +callbacks. (For instance, don't do anything that calls ``update_irq()`` +in a ``post_load`` hook.) Otherwise, restore will not be deterministic, +and this will break execution record/replay. + Iterative device migration -------------------------- diff --git a/docs/devel/replay.rst b/docs/devel/replay.rst index effd856f0c..40f58d9d4f 100644 --- a/docs/devel/replay.rst +++ b/docs/devel/replay.rst @@ -202,6 +202,9 @@ into the log. Saving/restoring the VM state ----------------------------- +Record/replay relies on VM state save and restore being complete and +deterministic. + All fields in the device state structure (including virtual timers) should be restored by loadvm to the same values they had before savevm.