From patchwork Mon Oct 7 13:55:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joy Chakraborty X-Patchwork-Id: 833518 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BA0B1D47D7 for ; Mon, 7 Oct 2024 13:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728309322; cv=none; b=MhXdp4/mHGocz3479A+/Z0S3W4sL4iRjdtTgQ95D0FXaHb0w/qYd95qBzyXImft/pDjq7yhC8ATLppmtb+R8K4P92jE3EZcWzmGzmIOzPainCQ0w8ae7E/yzG9nogoOnMefx9bf2d/pgFCazbe+E2nZtaihijgPSoFF0mnUQ5yY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728309322; c=relaxed/simple; bh=WkIFA3Bbn+M2B5VzgzqBsaRxhzbrBeYNIHEndslM8DI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=D+4+wY0lqlMi5MA27uNYRg9pucU0z9/8sTWHxgWHdGIa9ZNs30wdgA5VBB6HzmQWcKTT8oq3ZACatqoTBbsFjofzsvXSSiLCONQBTL3yRiuEFCEr8IJGrVVOMCiaUJMCjmkVqcsNplzzI7jy2XXC87olQNpRvplA5APiz+D8mpY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joychakr.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lS8ZamyX; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joychakr.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lS8ZamyX" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e25d494faa4so5090165276.0 for ; Mon, 07 Oct 2024 06:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728309320; x=1728914120; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=CblMzpCPNydZZpvacmjghKpdVLiy01vOQxnw0IUvqWY=; b=lS8ZamyXxnbKqpKuIf5E/mv6YmXlWu1PXd7stmV5YK6mPT1cpUsbGUNeh/1cvuhfZg Ii98egDa2o0NtsmB3+qqd36NXK2ZDI0hUXJ8NrxPljeMVBltr9CFsPN6gyvGozi9Pl6P +niv8NgHQJgPHT+7foJFoqKlc/Mm4WxYpF66j5TbLahdIofcVrXfDe4HLkEEkIPHHmjy XgtluDG0TO48R3OwQhJ+UgxleVRsOIREi9nZyXDSEQ60UpxmVPbz1dMnK2o/yxhMEK/O 7qzdNk3PSz6xb5/w3csMac79WYCnHXmQPOeeTfPxBAzAEQ7l/piXnIwwMZcAM41CsRjz CyEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728309320; x=1728914120; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CblMzpCPNydZZpvacmjghKpdVLiy01vOQxnw0IUvqWY=; b=X5duL9Xh5daxbJgGWoX6EHuA/EfpkUiB05SX8hfVdV2B3SJP1IJCK0sjBJuAgqUTAc tueZOSwl9roPDivKPqu1YnJEYQOj7eF8bvW3XiSkUdjlYtupi45SocLlF17+/VdBG+Ha sqmBiyWf+0zSKQEPo1sbfX0GoPke4I/nH61DX03uSbvTC73FQDXeP6Y/Ms1su0BLJx0K /6kbdyM/DHHR1+rJ0Vg7asOOTy/NX/kNjNlJOeE02pWP276PpN5o8h5RR413H7k6KPIC caFyBgQYyRdkGA82FI4cpvopAh2EttKxSxADpzQPRpe6PVvz2aXid+gdn/zKuuFxReau uYXg== X-Gm-Message-State: AOJu0YyntwyihvTBa9EvTMWsuauTSfw8IKKvQfs/GiUEjDKDwuvffhoU otsz8NDKJgwMc4okDMxbWBd9v64fFqviBvwz8IjyqgDom/Ma3I6PJrERPMvFoNhWsNYIymX7CHF nAbJN+Ho4Dw== X-Google-Smtp-Source: AGHT+IHENiCfXeLIY8OuGdXiRZ0mZC1NUSLuuz9kZp63rvGsqpTXO15oaagthIfQlsuXinVnTY8fy8lvpJBe2w== X-Received: from joychakr.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:6ea]) (user=joychakr job=sendgmr) by 2002:a25:dc86:0:b0:e1a:6bf9:aa83 with SMTP id 3f1490d57ef6-e28936d0742mr52400276.3.1728309320208; Mon, 07 Oct 2024 06:55:20 -0700 (PDT) Date: Mon, 7 Oct 2024 13:55:05 +0000 In-Reply-To: <20241007135508.3143756-1-joychakr@google.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241007135508.3143756-1-joychakr@google.com> X-Mailer: git-send-email 2.47.0.rc0.187.ge670bccf7e-goog Message-ID: <20241007135508.3143756-2-joychakr@google.com> Subject: [PATCH 1/2] dt-bindings: usb: dwc3: Add binding for USB Gen2 de-emphasis From: Joy Chakraborty To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thinh Nguyen , Felipe Balbi Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joy Chakraborty PIPE4 spec defines an 18bit de-emphasis setting to be passed from controller to the PHY. TxDeemph[17:0] is split as [5:0] C-1, [11:6] C0, [17:12] C+1 for 3 tap filter used for USB Gen2(10GT/s). Signed-off-by: Joy Chakraborty --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index 1cd0ca90127d..a1f1bbcf1467 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -190,6 +190,18 @@ properties: - 1 # -3.5dB de-emphasis - 2 # No de-emphasis + snps,tx_gen2_de_emphasis_quirk: + description: When set core will set Tx de-emphasis for USB Gen2 + type: boolean + + snps,tx_gen2_de_emphasis: + description: + The 18bit value of Tx deemphasis defined in PIPE4 spec driven to PHY + for normal operation. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 0x3ffff + snps,dis_u3_susphy_quirk: description: When set core will disable USB3 suspend phy type: boolean From patchwork Mon Oct 7 13:55:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joy Chakraborty X-Patchwork-Id: 833517 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 719661D6DAE for ; Mon, 7 Oct 2024 13:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728309332; cv=none; b=puuoU9RcbnesREla+jsPOM4fSMgKXoU9UgUcjA4hMDzAXSUjMGzFZwJXcorKIgscs5/X0cSTkKAh7Es9lOr9nQPbVYHpMKrkE1k62BsevW9nVkHzy0UA6ORMPZtThVzwtJcBck4+JBS1jM3FD33ov/c6ItuzPpSgfsHI9K6HklU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728309332; c=relaxed/simple; bh=hozD34R+1r+AOEtpIL+3KZ2W+shD6S4TBvGWV06zetk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=u+g3EeQqRL/hKxNlvOGhb0DLsYzmrSmAk1AuCKC/apbWgh376ZPBcTwzDAwxKfJi2pqyZYNZbJiSBwMpP17Y1iPwD+bGB7+00JxwJMq7NA82QbiIg/BofP5FADdvxz0PPCkDwcgqH4f1bFe4W9N45NBVnO/+tSGEwivwNjBPSr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joychakr.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=sgSTqS+I; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joychakr.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sgSTqS+I" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e24a0daf98eso4521103276.1 for ; Mon, 07 Oct 2024 06:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728309328; x=1728914128; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=LUZWXIYmMgx7eQT8FX3UW0dYEBsjOxQkFr0vicKGH/A=; b=sgSTqS+IgzrDXaIf3EkBcrNqKuaY+jSihBNRra/QDZbzLAQN1cQ5y/MGVE2LC2mabH ccJafmHqBrWjmaN8xYqx4weiT4ibsCjBGucH7li/Eq63lW+bb2vs5ePz7QzLLbcjJ6FX 7c018ctgA+qch/cFLsS9dmh5WsnoogCEEAHsS6fvjUW5M1aICzikVeJU0RNmHyIWiWZV cSVqjgQ0deEXbOJp0nZe+r96DZykyHRk1dULf420ELNN6KL/Y1irffrqN6wnhacFgpha Li7WpU8BrO/Vjg/8zgiWoOYXaLgcUhw3yDhle0pb/lLjkV4P25wVLscacgEIVWomdstM J9XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728309328; x=1728914128; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LUZWXIYmMgx7eQT8FX3UW0dYEBsjOxQkFr0vicKGH/A=; b=acdgpsys0XmVaeOw3WVLinT6azfny+wGiLJEqn1Ik4dmSSTsNKba+96SsjNgir2G6L NTCF8EMEXSQnOt6xsZQ98BaVwhPgnWJoPJBCbPdgYPQvEOrTivFCaOUw0KEvwzZCgL0h DEVIOCuuhxlRg0y/9qGYT2WvmqClyO4ORd99wJl97//OXyxMDBcs0m3IQTTBZ0xGoNmV CBw9fedt5wAEGaPt+ZEogI5WFiZ8R/O+6UoGHlfdto0hF0SiXqD/jaKabXvTH7AQnBpL NAOSUs/X7a+jbQ7wthC9L+f/b+uvcEJNdKcDk2vHPHpxOluI4Py7f6UOmpp2/Ijcpvd0 UGPg== X-Gm-Message-State: AOJu0YwyMGB+Fd2CYd4fEn14Pw0+qC8r4KBJIAFzbfhU10pSKpg/Qal1 vskrNy6LxsSM9/alsTQa+EkyQXYTuAgdLbHvxLW6UcZuyFoW7wdIBW8wmxnoGIagegpZyeLlO8v mKogxWbOlHg== X-Google-Smtp-Source: AGHT+IHAjKT4qNlRsQdqeZv5m+rXvrWxHJ+iDczfE+jTXAOP5PTHzUEVzRCM39ErLrwzhS0XlNSExa1A5e5xhQ== X-Received: from joychakr.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:6ea]) (user=joychakr job=sendgmr) by 2002:a05:6902:1817:b0:e24:9f58:dd17 with SMTP id 3f1490d57ef6-e28936bf5d1mr34659276.1.1728309328396; Mon, 07 Oct 2024 06:55:28 -0700 (PDT) Date: Mon, 7 Oct 2024 13:55:07 +0000 In-Reply-To: <20241007135508.3143756-1-joychakr@google.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241007135508.3143756-1-joychakr@google.com> X-Mailer: git-send-email 2.47.0.rc0.187.ge670bccf7e-goog Message-ID: <20241007135508.3143756-4-joychakr@google.com> Subject: [PATCH 2/2] usb: dwc3: Program USB Gen2 de-emphasis defined in PIPE4 spec From: Joy Chakraborty To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thinh Nguyen , Felipe Balbi Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joy Chakraborty Set 18bit TxDeemph[17:0] in LCSR_TX_DEEMPH(n) register for USB3 Gen2 Normal Operation as defined in PIPE4 spec based on dt quirk "snps,tx_gen2_de_emphasis_quirk" and "snps,tx_gen2_de_emphasis". Signed-off-by: Joy Chakraborty --- drivers/usb/dwc3/core.c | 13 +++++++++++++ drivers/usb/dwc3/core.h | 6 ++++++ 2 files changed, 19 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 9eb085f359ce..25e19aea364a 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -693,6 +693,11 @@ static int dwc3_ss_phy_setup(struct dwc3 *dwc, int index) dwc3_writel(dwc->regs, DWC3_GUSB3PIPECTL(index), reg); + if (dwc->tx_gen2_de_emphasis_quirk) { + reg = dwc->tx_gen2_de_emphasis; + dwc3_writel(dwc->regs, DWC3_LCSR_TX_DEEMPH(index), reg); + } + return 0; } @@ -1654,6 +1659,7 @@ static void dwc3_get_properties(struct dwc3 *dwc) u8 tx_thr_num_pkt_prd = 0; u8 tx_max_burst_prd = 0; u8 tx_fifo_resize_max_num; + u32 tx_gen2_de_emphasis = 0; const char *usb_psy_name; int ret; @@ -1797,8 +1803,15 @@ static void dwc3_get_properties(struct dwc3 *dwc) dwc->dis_split_quirk = device_property_read_bool(dev, "snps,dis-split-quirk"); + dwc->tx_gen2_de_emphasis_quirk = device_property_read_bool(dev, + "snps,tx_gen2_de_emphasis_quirk"); + if (dwc->tx_gen2_de_emphasis_quirk) + device_property_read_u32(dev, "snps,tx_gen2_de_emphasis", + &tx_gen2_de_emphasis); + dwc->lpm_nyet_threshold = lpm_nyet_threshold; dwc->tx_de_emphasis = tx_de_emphasis; + dwc->tx_gen2_de_emphasis = tx_gen2_de_emphasis; dwc->hird_threshold = hird_threshold; diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index c71240e8f7c7..fa9db38b7e15 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -179,7 +179,9 @@ #define DWC3_OEVTEN 0xcc0C #define DWC3_OSTS 0xcc10 +/* Link Registers */ #define DWC3_LLUCTL 0xd024 +#define DWC3_LCSR_TX_DEEMPH(n) (0xd060 + ((n) * 0x80)) /* Bit fields */ @@ -1145,6 +1147,8 @@ struct dwc3_scratchpad_array { * 1 - -3.5dB de-emphasis * 2 - No de-emphasis * 3 - Reserved + * @tx_gen2_de_emphasis_quirk: set if we enable USB Gen2 Tx de-emphasis quirk + * @tx_gen2_de_emphasis: Tx de-emphasis value used in USB Gen2 with PIPE4 * @dis_metastability_quirk: set to disable metastability quirk. * @dis_split_quirk: set to disable split boundary. * @sys_wakeup: set if the device may do system wakeup. @@ -1374,6 +1378,8 @@ struct dwc3 { unsigned tx_de_emphasis_quirk:1; unsigned tx_de_emphasis:2; + unsigned tx_gen2_de_emphasis_quirk:1; + unsigned tx_gen2_de_emphasis:18; unsigned dis_metastability_quirk:1;