From patchwork Tue Jun 20 12:43:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 106000 Delivered-To: patch@linaro.org Received: by 10.140.91.2 with SMTP id y2csp1352073qgd; Tue, 20 Jun 2017 05:47:57 -0700 (PDT) X-Received: by 10.98.0.66 with SMTP id 63mr6309780pfa.100.1497962877810; Tue, 20 Jun 2017 05:47:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497962877; cv=none; d=google.com; s=arc-20160816; b=qStUPal5lr3A2dXyOg4qWaw5/Lo4uw7CBTIcnQU4S9KRhUegCGsRI1cR+J5mdIiTjX pPLAu2W+geFwnJJ8xcKVDwUMP/Qg5x/LS7S8/pQiMZNM91zr4L6kIQGMUVMx/l5cHPiN QD+xnuv6i7FXtqzUbZk4Xbb2Ds4NAHd+L5VHAUPJ48sDHB+hxzMHEFdPZyQbVD+a8dUw x5+WF8eNs/hnVaIxVc1mDN2M/Ey+3eetkTe/9o9qbmbwJBbKEt8TjU07mvW+IKG5meGw irJorefgNtTLR2xhNa/7s7cH44Z5XyAvTRmlekeBP+zOu1HY68m6RRGB/9B1npEzRJol Hl1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=54FUqbTnhWz+ixb2L/9isbCUAsmjMR523F1jLHc5WYE=; b=UulPN/EpPNxlc+43xUBTyqUF4DChs9cj67qmGPzA6C3/+uAt9NH2oK/KPzXe7dMXpi sxzXDRIwJholBIB8zQZHL5wbY5IA+LcOLgT3TkWdFLxKhvFi16MjIah/Lj1zmhdYlXvR KV9qK/y4dWZYuKPIzFDGzRTLBhRR7SoquJ2yoDwkFRejAPUaJkinVHuovKUtHdpy3uaL TEZJb4E7kBjTQEgOXxHAEHvnTNEF9UdSZfb0X9UgGLF3Yz2eQexiG+tR+Gvbl3xNCQXq 9MkpnTxbqk4TRgGbTiEBrNmvTk2AWqgLSmOxg6J5evQl3c7XUud89/k3D1FDe7q4+5om HVfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a186si5889721pge.160.2017.06.20.05.47.57; Tue, 20 Jun 2017 05:47:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070AbdFTMru (ORCPT + 25 others); Tue, 20 Jun 2017 08:47:50 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:8766 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbdFTMrs (ORCPT ); Tue, 20 Jun 2017 08:47:48 -0400 Received: from 172.30.72.55 (EHLO DGGEML403-HUB.china.huawei.com) ([172.30.72.55]) by dggrg01-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id AQR16141; Tue, 20 Jun 2017 20:44:23 +0800 (CST) Received: from localhost (10.177.23.164) by DGGEML403-HUB.china.huawei.com (10.3.17.33) with Microsoft SMTP Server id 14.3.301.0; Tue, 20 Jun 2017 20:44:15 +0800 From: Zhen Lei To: linux-kernel , linux-api , Greg Kroah-Hartman , Michal Hocko , linux-mm CC: Zefan Li , Xinwei Hu , "Tianhong Ding" , Hanjun Guo , Zhen Lei Subject: [PATCH 1/1] mm: only dispaly online cpus of the numa node Date: Tue, 20 Jun 2017 20:43:28 +0800 Message-ID: <1497962608-12756-1-git-send-email-thunder.leizhen@huawei.com> X-Mailer: git-send-email 1.9.5.msysgit.0 MIME-Version: 1.0 X-Originating-IP: [10.177.23.164] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.594918A7.013E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 9341345198a707542b02dee59055d77c Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When I executed numactl -H(which read /sys/devices/system/node/nodeX/cpumap and display cpumask_of_node for each node), but I got different result on X86 and arm64. For each numa node, the former only displayed online CPUs, and the latter displayed all possible CPUs. Unfortunately, both Linux documentation and numactl manual have not described it clear. I sent a mail to ask for help, and Michal Hocko replied that he preferred to print online cpus because it doesn't really make much sense to bind anything on offline nodes. Signed-off-by: Zhen Lei --- drivers/base/node.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.5.0 Acked-by: Michal Hocko diff --git a/drivers/base/node.c b/drivers/base/node.c index 5548f96..d5e7ce7 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -28,12 +28,14 @@ static struct bus_type node_subsys = { static ssize_t node_read_cpumap(struct device *dev, bool list, char *buf) { struct node *node_dev = to_node(dev); - const struct cpumask *mask = cpumask_of_node(node_dev->dev.id); + struct cpumask mask; + + cpumask_and(&mask, cpumask_of_node(node_dev->dev.id), cpu_online_mask); /* 2008/04/07: buf currently PAGE_SIZE, need 9 chars per 32 bits. */ BUILD_BUG_ON((NR_CPUS/32 * 9) > (PAGE_SIZE-1)); - return cpumap_print_to_pagebuf(list, buf, mask); + return cpumap_print_to_pagebuf(list, buf, &mask); } static inline ssize_t node_read_cpumask(struct device *dev,