From patchwork Fri Oct 18 07:48:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5ZCz6YC86YC8?= X-Patchwork-Id: 837173 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D89C018B482; Fri, 18 Oct 2024 07:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729237776; cv=none; b=p5rOEc1Uv1eAKkm9092A6HPnqvOC7NmUv5G/uXXsoS0+03Xvd+XB/R7jHq+Q9DxsbR2Vpeo+89FjVI/gi+8nphKv43mR2U1xlwpG3hVkPnwfVeKla7SVrdg40CgNaAiI+G0R8crES7doEjl2XRPhcF8sZxJ/bYsNOiIIr2a3FIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729237776; c=relaxed/simple; bh=Rc4qEXMa0QYjvHOp4pyZqLnpUr0nGSD3dQ+U4hdNEaM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Xzw2NnVxbLjpZuffaA0GGy9YuC+fSikaKo8LIuvAiLGRDe7OWofZVEiWBGkuAQq8l2zWu/NAZPnyq2KU5GqGghH/hA329PBC8r3qt4OgVfEoBhZ332sIFZVudLQbMzFdyif3j3MJQi9CPtRhkZ1EBOJTeRwiQyy43bVOqhbWHOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TFmZHO+r; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TFmZHO+r" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7ea7e250c54so1274776a12.0; Fri, 18 Oct 2024 00:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729237774; x=1729842574; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1isxM+T848GFvJvzymmh7gVtU9Db8eItqMO8i4yplDI=; b=TFmZHO+rzhekS1sK7U/n79AZfhaP5ISKJMry1cgHQkKH5PgZluPuOO6HNKRg7rTr/g gz/Gc9sQNL9JmoEOi4R92FKJJQYKXEoSIWfjb1lKschWwqCipAr05IZoVH4Kp56zw8aZ nq6Sw3MrtCHNA4if2/4BnVNNP5qAZd524K63lafqtjO79zhejqMb82pvnHslZlKjbdp6 0kXV+Mpct7Tr+nFndnJR0tATVly2mR34hqgjMOYwPq7x4fTAsE8czv+iLvAfv4joIY0n ulm0+2+HiWOtc1di7mlm7EpmSoVCtCVimpVW0G/iSC7sBaucxCUy2tRU5R34lcGn67GB ajHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729237774; x=1729842574; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1isxM+T848GFvJvzymmh7gVtU9Db8eItqMO8i4yplDI=; b=GPE+z8slCZvAMvN2CJF6emKWUVeA/iM6alg53FMzF7KCHmgykIFCxkuPmg6J5HoS7I Qm4U/IfDy9fG1Hyk/d16zVXpBd9VYfoiXpcbEJn56QuEutYConOal/Pz+ZMWibk1W6CJ Kd2r6kD/REeQQu1s4ggIHJAYq3GybQM2xj0hJHEKme0BWh+OIp5i/YFSPTYugaUhv8Lf l3ttr8eKUJk5c0ZnwPuBuazS5Tp6XL+7I8d4LChdbRkhFW6y+pLoQhE0MwbQ9oPovwb0 1ctGnGMnwWkXe+9JcpD3WE0vpRu1F+WMmqo9u1vKHpUudk8V5YWRDM11KChDqq3obQEL yFSg== X-Forwarded-Encrypted: i=1; AJvYcCWFUdBgJFFDGfFFkIffjhpDK41H6nb/ckefMdTGNcvj61B7w3/tB+n1qSp6anEKAafgC0+cVh4toeo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4r3181Ie2PQUVOLtydFAEEgooLw7jtPChQqAHzDr9q95QuYqH PW6zuKsisDpGmgVMsRjhYuG16GA2i3ivRbq/HZzdD5lZ/UfIo3phxwxds2kJ X-Google-Smtp-Source: AGHT+IGq9xXBjZ7B+bmpZuX1zHoZ3akorwGczXJzcLA0dPqp+H4yvzKs0UT4OCM9H+bsNsIXFm5osw== X-Received: by 2002:a05:6a21:3a94:b0:1d9:282f:3d16 with SMTP id adf61e73a8af0-1d92c56cad7mr2315018637.32.1729237773888; Fri, 18 Oct 2024 00:49:33 -0700 (PDT) Received: from localhost ([2402:7500:479:5c7a:4a5c:7794:109d:58b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e5a8d674asm7346715ad.169.2024.10.18.00.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 00:49:33 -0700 (PDT) From: wojackbb@gmail.com To: netdev@vger.kernel.org, linux-usb@vger.kernel.org Cc: chandrashekar.devegowda@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com, loic.poulain@linaro.org, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, johan@kernel.org, Jack Wu Subject: [PATCH 1/2] [net,v3] net: wwan: t7xx: add PM_AUTOSUSPEND_MS_BY_DW5933E for Dell DW5933e Date: Fri, 18 Oct 2024 15:48:41 +0800 Message-Id: <20241018074841.23546-1-wojackbb@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jack Wu Because optimizing the power consumption of Dell DW5933e, Add a new auto suspend time for Dell DW5933e. The Tests uses a small script to loop through the power_state of Dell DW5933e. (for example: /sys/bus/pci/devices/0000\:72\:00.0/power_state) * If Auto suspend is 20 seconds, test script show power_state have 5% of the time was in D3 state when host don't have data packet transmission. * Changed auto suspend time to 5 seconds, test script show power_state have 50% of the time was in D3 state when host don't have data packet transmission. Signed-off-by: Jack Wu --- V3: * supplementary commit information V2: * Fix code style error --- --- drivers/net/wwan/t7xx/t7xx_pci.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/wwan/t7xx/t7xx_pci.c b/drivers/net/wwan/t7xx/t7xx_pci.c index e556e5bd49ab..ec567153ea6e 100644 --- a/drivers/net/wwan/t7xx/t7xx_pci.c +++ b/drivers/net/wwan/t7xx/t7xx_pci.c @@ -49,6 +49,7 @@ #define PM_SLEEP_DIS_TIMEOUT_MS 20 #define PM_ACK_TIMEOUT_MS 1500 #define PM_AUTOSUSPEND_MS 20000 +#define PM_AUTOSUSPEND_MS_BY_DW5933E 5000 #define PM_RESOURCE_POLL_TIMEOUT_US 10000 #define PM_RESOURCE_POLL_STEP_US 100 @@ -174,7 +175,7 @@ static int t7xx_wait_pm_config(struct t7xx_pci_dev *t7xx_dev) return ret; } -static int t7xx_pci_pm_init(struct t7xx_pci_dev *t7xx_dev) +static int t7xx_pci_pm_init(struct t7xx_pci_dev *t7xx_dev, int pm_autosuspend_ms) { struct pci_dev *pdev = t7xx_dev->pdev; @@ -191,7 +192,7 @@ static int t7xx_pci_pm_init(struct t7xx_pci_dev *t7xx_dev) DPM_FLAG_NO_DIRECT_COMPLETE); iowrite32(T7XX_L1_BIT(0), IREG_BASE(t7xx_dev) + DISABLE_ASPM_LOWPWR); - pm_runtime_set_autosuspend_delay(&pdev->dev, PM_AUTOSUSPEND_MS); + pm_runtime_set_autosuspend_delay(&pdev->dev, pm_autosuspend_ms); pm_runtime_use_autosuspend(&pdev->dev); return 0; @@ -824,7 +825,13 @@ static int t7xx_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) IREG_BASE(t7xx_dev) = pcim_iomap_table(pdev)[T7XX_PCI_IREG_BASE]; t7xx_dev->base_addr.pcie_ext_reg_base = pcim_iomap_table(pdev)[T7XX_PCI_EREG_BASE]; - ret = t7xx_pci_pm_init(t7xx_dev); + if (id->vendor == 0x14c0 && id->device == 0x4d75) { + /* Dell DW5933e */ + ret = t7xx_pci_pm_init(t7xx_dev, PM_AUTOSUSPEND_MS_BY_DW5933E); + } else { + /* Other devices */ + ret = t7xx_pci_pm_init(t7xx_dev, PM_AUTOSUSPEND_MS); + } if (ret) return ret;