From patchwork Wed Oct 23 11:33:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837803 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp405506wrb; Wed, 23 Oct 2024 04:35:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWnwvI3qarDSgpYOoe0N0Yi6HWChIkKbvQ4R2pLZAx3CnLrzlh/9bySrXN+GS1e4HkAL9jDlg==@linaro.org X-Google-Smtp-Source: AGHT+IGYEqis5/HQjgjBH7jSH74lcx3zrd5lrrsReNkSagc8IRJ5sDV4gJk13iABy/2BcRFMbQmZ X-Received: by 2002:a05:6214:88e:b0:6cb:ef96:c79e with SMTP id 6a1803df08f44-6ce342f47b3mr23060166d6.34.1729683304709; Wed, 23 Oct 2024 04:35:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683304; cv=none; d=google.com; s=arc-20240605; b=AuyUn7L+YBK+NHF2mlrvflmbp/b2FRN+5jY/tCfX4jGPQrabhjdDRR7SEnGjasaIVH 3zTrMC0BLLrgL0rR97Agt370eXuBEybYSd78zemkBLVdjh7TeYOzqd/M0zgGXJlNj1at V0toF1eZv0AQbagLKTXFqBOaJaobX0CwxV6SFMeGsd59EwsYaJMFSDlEm+wyZa0N5VJ7 9Cd09334qU7Af1g92RuAyj7V6onhyz8gMMNjrI1vlG7wBrjC3GJhGoiGp2fRj98ctM9O iI8Dygw83nBl9TrwjMYZZQyM1DAoIsPi5MeArLtE6XsZYyFyMcAxyGM3rWX0FkeaQ3qJ 4Wqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+XNjfi7hRi9preQg6Skm6jboyJIHM73C5JCjrQ/Fxa0=; fh=p+eKEdn09QHzHdwfHiKY3bz9+G3n7au2l3N4h9YZqkc=; b=hA3eVZwJXg5cnvL2AvX2JP7WsRTnpDrWKpySKUwu5FvT+aWyPfOPju3rQf2lT1LvoS Oz7LSz7eeruTTO+bxjhNtUH/82tTUrIBFPFjPzL2AGFTac5TwLTIt237xzMcAP+ij5Mw 9FSj1zv7cb3WoaNyrrPguCoyBA9lZk57Rkf1QWPFQ5tQK2X+cBZshODi/+ErpeP6R9Dm lTWDAqGzKDkPe1aKv5ikuyCOkD+89DHEoVHJnmImJZtwabYhc9xGwAVEfmejrLQV64Th 27qk3LLuHd4jqVBDCLNTY+y8WqFB+1pIjaITk3Gj7H7r462Amn8yNL6jwiQHu+4pPp5T j87A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="gSmwH/Q7"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6ce008f3f7esi85877806d6.137.2024.10.23.04.35.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:35:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="gSmwH/Q7"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ZdB-0007KO-OX; Wed, 23 Oct 2024 07:34:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zd2-0007DN-Rp for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:16 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zcy-00033q-2e for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:14 -0400 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5c95a962c2bso8038746a12.2 for ; Wed, 23 Oct 2024 04:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683249; x=1730288049; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+XNjfi7hRi9preQg6Skm6jboyJIHM73C5JCjrQ/Fxa0=; b=gSmwH/Q7+/Rr63a5baY/EhChgY05Q+7PZiQg5QMVSsfGV/n6SwHdDJrX6PesT8nIMK MzmwJjrzf+eucnctEoNIT3GNuFAMf1+5eoOnTPCbupzGMgseX1vvMP+AD5aQWqLPMFDt v/GdB8TpJGt4TJC12Lt6a95pR831IwU3cs+GZX/lSAFjQQLxhxOcbTajXKYtk9hXNl6d KSNgF95du3C5sTwTSKqeKuFJHfO+NOxh77lBSss1lNLoapIIFb9OxKgAKk+p+HEUtqD1 ZTctnlWF9ctvXbGY9f8PdqNkzcTP7dfyAv1iHqjBc2W/UonqxXCJrPEGhaBXAwyPdmSh b2xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683249; x=1730288049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+XNjfi7hRi9preQg6Skm6jboyJIHM73C5JCjrQ/Fxa0=; b=XwjhhQ6acA6tEnJeWcqHTPslswawVkeH6H6cSRoQbzNxKFxBOMfyUv1z3hUWnRAd2z RY0wu4LDG1O5ub+TGy96Nw2dtJ0LnBYI5UsEJW0hbvefe6yCfE3AO3iL6M4ZDvbcqCBv ZGGNjMQ+8ONnJFRNGnFBqcdMVH+4mq1Ps86Ia0KTduHUQrAxWDsM49QFmiilkbuNXOOP RLO5r46fwQL4qGxwZaaHVRskmPADzKDRPJ02dmpZLKVCdmgjWaBtuyJTTsi1vDQAPFIG /bOE2dR5vDXhax29iZDBuFAyv4nma+3ADInfRuBxU3jfT7XnQs245N1mZhsJk1oMFnAG 8ADw== X-Gm-Message-State: AOJu0YyHiPW5TNzrF/4+sAZ/8GacI/odiT5ao3yTSDJ23IMFiEJU4khc M4aOb31xBUfjD49HTwMkcuVsGdl4DbBdDEx1eXfdoBLHGoclW3NLgE/U7gr6ols= X-Received: by 2002:a05:6402:434c:b0:5c4:51b3:d75f with SMTP id 4fb4d7f45d1cf-5cb8af72080mr1849170a12.24.1729683248677; Wed, 23 Oct 2024 04:34:08 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cb766710d1sm2661378a12.90.2024.10.23.04.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:07 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 11D8C5F8AD; Wed, 23 Oct 2024 12:34:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , Ilya Leoshkevich Subject: [PATCH v3 01/18] tests/docker: Fix microblaze atomics Date: Wed, 23 Oct 2024 12:33:49 +0100 Message-Id: <20241023113406.1284676-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Ilya Leoshkevich GCC produces invalid code for microblaze atomics. The fix is unfortunately not upstream, so fetch it from an external location and apply it locally. Suggested-by: Peter Maydell Signed-off-by: Ilya Leoshkevich Reviewed-by: Pierrick Bouvier Message-Id: <20241022105614.839199-2-alex.bennee@linaro.org> Message-Id: <20240919152308.10440-1-iii@linux.ibm.com> Signed-off-by: Alex Bennée --- .../debian-microblaze-cross.d/build-toolchain.sh | 8 ++++++++ tests/docker/dockerfiles/debian-toolchain.docker | 7 +++++++ 2 files changed, 15 insertions(+) diff --git a/tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh b/tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh index 23ec0aa9a7..c5cd0aa931 100755 --- a/tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh +++ b/tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh @@ -10,6 +10,8 @@ TOOLCHAIN_INSTALL=/usr/local TOOLCHAIN_BIN=${TOOLCHAIN_INSTALL}/bin CROSS_SYSROOT=${TOOLCHAIN_INSTALL}/$TARGET/sys-root +GCC_PATCH0_URL=https://raw.githubusercontent.com/Xilinx/meta-xilinx/refs/tags/xlnx-rel-v2024.1/meta-microblaze/recipes-devtools/gcc/gcc-12/0009-Patch-microblaze-Fix-atomic-boolean-return-value.patch + export PATH=${TOOLCHAIN_BIN}:$PATH # @@ -31,6 +33,12 @@ mv gcc-11.2.0 src-gcc mv musl-1.2.2 src-musl mv linux-5.10.70 src-linux +# +# Patch gcc +# + +wget -O - ${GCC_PATCH0_URL} | patch -d src-gcc -p1 + mkdir -p bld-hdr bld-binu bld-gcc bld-musl mkdir -p ${CROSS_SYSROOT}/usr/include diff --git a/tests/docker/dockerfiles/debian-toolchain.docker b/tests/docker/dockerfiles/debian-toolchain.docker index 687a97fec4..ab4ce29533 100644 --- a/tests/docker/dockerfiles/debian-toolchain.docker +++ b/tests/docker/dockerfiles/debian-toolchain.docker @@ -10,6 +10,8 @@ FROM docker.io/library/debian:11-slim # ??? The build-dep isn't working, missing a number of # minimal build dependiencies, e.g. libmpc. +RUN sed 's/^deb /deb-src /' /etc/apt/sources.list.d/deb-src.list + RUN apt update && \ DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \ DEBIAN_FRONTEND=noninteractive eatmydata \ @@ -33,6 +35,11 @@ RUN cd /root && ./build-toolchain.sh # and the build trees by restoring the original image, # then copying the built toolchain from stage 0. FROM docker.io/library/debian:11-slim +RUN apt update && \ + DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \ + DEBIAN_FRONTEND=noninteractive eatmydata \ + apt install -y --no-install-recommends \ + libmpc3 COPY --from=0 /usr/local /usr/local # As a final step configure the user (if env is defined) ARG USER From patchwork Wed Oct 23 11:33:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837807 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp406009wrb; Wed, 23 Oct 2024 04:36:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWoraAjkf0VXOafGCwkJSgy2gvggr5FZPDdzQNK6ftZO4LIwfRS8Iun8QIWdmb6kC8Rq53yTQ==@linaro.org X-Google-Smtp-Source: AGHT+IExmLgpDdhIAtNIl+UQY41q8m2mcNyPUdz7yRQnL2hInNIQBrrauDNMBY8aQ4WHftkD/z5d X-Received: by 2002:a05:6214:5702:b0:6cb:c9bc:1a23 with SMTP id 6a1803df08f44-6ce341a2c8emr31845816d6.24.1729683382999; Wed, 23 Oct 2024 04:36:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683382; cv=none; d=google.com; s=arc-20240605; b=MPCKMaMB/76CDkxTjvOcTW9Im2J1ffDBXXy0y66ro8XmXiYncmhO5EdCTOl8yA3lcU EqjfNjR+KD+hR7rL50Iv7Aia9Dhvp9N+oy0USg08YCcMxHbIIC6iC0SmH3y+w748oe9B cJGPx2SQ4zvrSJLOH8OmLxe8JJwa/r+9+rM6JKhnSdPPPXSdaNz4PfO2fSVQGqLDYark 8KfDOM+c2I2czKdljGAjx5tjE4Iqy/K1bWssVPgHB+o+wVJe/MlArDO0AdCjft6Ph6rr 85J6SbZuEMYQ/yM2tmvh70SKGZBCPdbM72DH+y8Cp0RInX4EyIZXdjop8B6FpTyd7Lwl Vw4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZFUfe3R/gzmi/FEpNAJD4C8KljhahEoI2QawPam7H0s=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=URJtEqMN4f0iDbNrfYhV8bOo9z6G3cYsSv0E0FZb/FpV+85CMy9ApnTHofP0oBrjGp V+/uGVLQs3Ku5nXcbukyIdJRv7oOHYCANwuwjdb7COzRp34kAUOqOe6BzM/p8JgmLCgY jOxC1Ki+u9eLqXZi85qiDWYdLEkty2UpW2hMfTZxyjCXGcYJ0Am7tYp4pppsVj9M/D+6 kajbZ/G1Mxl2j26T/lV3zK6qsy4RztgaQQygwKMOKCulNFaqXXo3UV6z++VlI/Pvs6PW yyFbNxRKt3FA7hJbU5MXac57cVJrjE6j+rFAZFIy7JHgWDI4hBzIFDsAsnq+tSgAFQTJ ubbA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=reHHUfya; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6ce009ceabasi89872666d6.341.2024.10.23.04.36.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:36:22 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=reHHUfya; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ZdC-0007Kd-Aw; Wed, 23 Oct 2024 07:34:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zd2-0007DK-Qo for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:16 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zcy-00034J-3H for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:16 -0400 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5cb72918bddso3627071a12.3 for ; Wed, 23 Oct 2024 04:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683249; x=1730288049; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZFUfe3R/gzmi/FEpNAJD4C8KljhahEoI2QawPam7H0s=; b=reHHUfyacE0ijQhkTPS/sYb4u2eEui30zOQBkWbcmAEylOthzA3oCTKoT4MwKMoZN1 0wJ3JFYhxNxYfIpjzLiQBvikXMbuHHWLunM29ewGXqhmV70c6aX+yqxwBIb2ZfcFwTcb eFpNUSYP841CRz8Zxt7eNWQAsxLNgtS4HYAhYq3jHHUTxxZe4oOCI4V6KXFZ08KPllRl i4TpH/KcmeQHEiWLGJXVI4x+D4yrEm08ksEAuUQ06z99CGUnfKOn/n2+hPZPraTK5jwJ j2y5BR3+BUCQ3s+uS5x7pxk7StmxGXhcVllKdOlcG6YMKLjGeFZsNmlF5+eiXGFzEqxy 8fHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683249; x=1730288049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZFUfe3R/gzmi/FEpNAJD4C8KljhahEoI2QawPam7H0s=; b=bmWSozZJUN1xV34tnJ585aDa141kF/yY4Ut+qvzLdVjSUWUDMDr3sId4fqrxSSLrRY yvBp+y/GZqzCFMutx7Pf4/SVogmbA9Df/JG9BTVEcBnoKc3J/Phdmpv2Xb4E6mPEN48q Wfw2cGoxGR1lEipdiBZACMOtye4bSlpIaxEGpIza3QQJVurcFnKKOJyRNHF7NAmZHqAE 63im/8/AEAaIZ1wj7zYoIdUKRKrIlouT1ecE6uN4SEev2Enkj7Cex7JPzmu4ObW5+a6t tzIHonHfjZ9+haEzbmK9eOBZou0Q3Vh7PHS/bIEaYgtTmMa1ZfbTQuyRYynlP8hS7zCm Lu8Q== X-Gm-Message-State: AOJu0Yxty4i5sab/TMT3V8YZyAWudu5osMPDYrdzzZWPy3BqQKaLWEEu aRGeDMJDFWRC/Z07lg3qWTBkzOCVWhSangJFnj/ZQi5EB8cgUwFzL+w491usSpY= X-Received: by 2002:a05:6402:2791:b0:5cb:666e:9f8c with SMTP id 4fb4d7f45d1cf-5cb8af97d8bmr1943092a12.32.1729683248995; Wed, 23 Oct 2024 04:34:08 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a65451sm4275667a12.27.2024.10.23.04.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:07 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3EC7A5F8CC; Wed, 23 Oct 2024 12:34:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 03/18] MAINTAINERS: mention my testing/next tree Date: Wed, 23 Oct 2024 12:33:51 +0100 Message-Id: <20241023113406.1284676-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org I put it under my name as there may be other maintainer testing trees as well. Message-Id: <20241022105614.839199-4-alex.bennee@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c3bfa132fd..ef1678a1a8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4080,6 +4080,7 @@ Build and test automation ------------------------- Build and test automation, general continuous integration M: Alex Bennée +T: git https://gitlab.com/stsquad/qemu testing/next M: Philippe Mathieu-Daudé M: Thomas Huth R: Wainer dos Santos Moschetta From patchwork Wed Oct 23 11:33:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837806 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp405697wrb; Wed, 23 Oct 2024 04:35:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW02HfxlbT6DlUQ5x/hQEybECXkCoxMUgFcxFN/TltImidYN5kf4UhGJskCteGZ1mrkHQmR9A==@linaro.org X-Google-Smtp-Source: AGHT+IHvTjBQckpcpKHxWsUHDs+lZ0ITCw/6H6pqnAiO+NXpG94oAB+CCc5hN93xWuWYiSLSKzsE X-Received: by 2002:a05:622a:a009:b0:461:1532:d769 with SMTP id d75a77b69052e-4611532ddeemr23538911cf.54.1729683334796; Wed, 23 Oct 2024 04:35:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683334; cv=none; d=google.com; s=arc-20240605; b=X8R56KmcBIIXw82498dsmhWkYUff89HNGuSDMHv44vL5i5P/8/NtS7m30G4qXVxWwA KpIXqmN7UD9Z2Lb1fpJUXd48K9fiKGz95ZucFQ1Px6yzq9j7nG/Z7G2k3/SIDc8p4FkI XeCZvLOiJ8E67iFF0ZV+5zCCDTY/Z1T6aB7nWN6yiHI6LV/dEzK4Jsn4gA4AsXVYT5Sl JOGjPAJJy1LM3riVaHk5wRGEzZXUVXQcyi8NdQy6JGl4t++BMbcwLUMf2Mf8jIKFaiZs GEz+41R5AO/lKKrvcYRjn8E+7zGqwiDWq1BR1EQjs5IPwMg73E9VX/kHQ6FdBhg5g3nD 1pJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/9/+YXB0yFn3lOXE+wDfnOMUk7oakkE6QbrJ6dxZQ+4=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=dnGWZ2d92O46PbHnRYrehYesKitAHBnNIinA0gyII0DIZnClBm85Nbl6Qxbr4ZYM+B JcED//eXF1SAvHavSAaQGL5DQl4U4hksSX5daCUKL6xRtOTIHZTF9rrw4Ofrvls7FfqJ b+SoIx0bnpftGL3GuuNqKhWJXFwcHfkI4hH/qtALIqoLoZHPe6oCYTExo+u8SuOYLF2O PtpX7ZjEkT1/4msCqHqkNIS9G1ZVdL+kGfjn4GXIs4RBJqt5QeV0h/8tGvo7A6g9Ejz8 NgV5D6H/40CcrjzsCFTYO1B0mttXA1K70mwrXForg6RvQZajqFwuOR0f6f5rnTzAGsyI qYdw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ef51HeCm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-460d3d96b9csi92015861cf.680.2024.10.23.04.35.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:35:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ef51HeCm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3Zd7-0007Fj-8E; Wed, 23 Oct 2024 07:34:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zd2-0007DO-Ry for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:16 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zcy-00035d-L3 for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:16 -0400 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a9a0472306cso897197866b.3 for ; Wed, 23 Oct 2024 04:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683251; x=1730288051; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/9/+YXB0yFn3lOXE+wDfnOMUk7oakkE6QbrJ6dxZQ+4=; b=Ef51HeCmu+1RWV5vlaVWCHUhDbxPLK68ANw+taYZPe/xXh9KyU0qM7g1liLgMF7G/4 PsUOQAAfzk4+HVl0g829y73KBqnZ4PoYHZ/iy7CFGEh1uLUT0JPIf6w2ByZ0kbw47rvB Ti5/or4ZxzC6oye/VYpqKIscW1/xdd1JUSHZV0CkZO5bu6Yia72/qceQjEoJH9+Wf7Iw bDU1JvNNCFG+NItNiF51T4F55hrCgWN8QP0p++SMj2aCnUVsOWwkfFVds44hTcoJrtiA Evp8GRpJKH05lfNAUU5x5Ev9xj9AeUHFrXn9I9AbS0B1EQ9Yk/3u/C5XCj6OHB56eTDK Gp0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683251; x=1730288051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/9/+YXB0yFn3lOXE+wDfnOMUk7oakkE6QbrJ6dxZQ+4=; b=ObEHLDsD+iQc/gKBOssJPgVD4bPaBO37/rGE424nEqjWdMHh7794BkhoKBXvxI2sZR 3vUTCc0Jrh0sxJYwfL5rDIFwFvdsgYhv0WArboHOEjB6hDnvrEcMJAEJ6cCBvEycMypr wrW6nKRj00Hu4HC8Hao+YMu2jht74MvU6k3bDsDCI3+CVl4EQS3RuelxLKgbE+HXvjop kRAxn5YNnRCi98FSA7Tv+3QKu4Qg52eNlSYIlpTiUZF9cJEsQ7y3oAqhOX6bdxh0yrES e7knWyr63qJY7v6Wqpe6wmn6e34WgO0yIEFBqhbdXe81okAMpDox4o8AJkvDnv2bRS8h HwoQ== X-Gm-Message-State: AOJu0Yx8znvG0Ho4ieRs3qUodaP4Sbu453vTI+HLkmw7mAbZulOSsN5q DYkVNZ8nAfMkJW7fpI6Bz2rdm5ub3Z+Ldrronb4tklUhXECbI5Cuqy83lTRfjpc= X-Received: by 2002:a17:907:9496:b0:a9a:1bb4:800c with SMTP id a640c23a62f3a-a9abf85caf5mr187274866b.4.1729683250848; Wed, 23 Oct 2024 04:34:10 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9acad2eeabsm12746666b.20.2024.10.23.04.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:08 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 570455F8D7; Wed, 23 Oct 2024 12:34:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 04/18] meson: hide tsan related warnings Date: Wed, 23 Oct 2024 12:33:52 +0100 Message-Id: <20241023113406.1284676-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier When building with gcc-12 -fsanitize=thread, gcc reports some constructions not supported with tsan. Found on debian stable. qemu/include/qemu/atomic.h:36:52: error: ‘atomic_thread_fence’ is not supported with ‘-fsanitize=thread’ [-Werror=tsan] 36 | #define smp_mb() ({ barrier(); __atomic_thread_fence(__ATOMIC_SEQ_CST); }) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth Message-Id: <20240910174013.1433331-2-pierrick.bouvier@linaro.org> Signed-off-by: Alex Bennée --- meson.build | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index d26690ce20..bdd67a2d6d 100644 --- a/meson.build +++ b/meson.build @@ -538,7 +538,15 @@ if get_option('tsan') prefix: '#include ') error('Cannot enable TSAN due to missing fiber annotation interface') endif - qemu_cflags = ['-fsanitize=thread'] + qemu_cflags + tsan_warn_suppress = [] + # gcc (>=11) will report constructions not supported by tsan: + # "error: ‘atomic_thread_fence’ is not supported with ‘-fsanitize=thread’" + # https://gcc.gnu.org/gcc-11/changes.html + # However, clang does not support this warning and this triggers an error. + if cc.has_argument('-Wno-tsan') + tsan_warn_suppress = ['-Wno-tsan'] + endif + qemu_cflags = ['-fsanitize=thread'] + tsan_warn_suppress + qemu_cflags qemu_ldflags = ['-fsanitize=thread'] + qemu_ldflags endif From patchwork Wed Oct 23 11:33:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837810 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp406248wrb; Wed, 23 Oct 2024 04:37:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVOyEzpClk2s/BN1ZIhYubZnJx1OD1VeKVNDxHasPaUJi5M8gA8XmJHwfmk+ORtBea+q/nuIQ==@linaro.org X-Google-Smtp-Source: AGHT+IHd7K9pbYucYzREHZX2zhLhLAGHBbrtsADQ19iSSPjtUkKXfNWNQj2j4Zt6FNp97Rq9sr/X X-Received: by 2002:a05:6214:4406:b0:6cb:e52c:c8e6 with SMTP id 6a1803df08f44-6ce341ccc50mr27600106d6.31.1729683419934; Wed, 23 Oct 2024 04:36:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683419; cv=none; d=google.com; s=arc-20240605; b=V9FR2wjBQ34rQjrNzx8sJqIZrPAAejZiitVHbbT0KvkaTPw/mNZYVnmRYKA2w7hmfP gxbI7+ap//w2MabyR+vYd1fwBuFIAA0QAFM3IvD3aI3Q2Rgl140lTWyBouW21iODOs1e F1ptcceOM/tsCgIZ1N6Qa70A3sX0apmzk7oP9exZMlQHqYskuPhqvK2Vp8/mlhs74Hzo iwKv5qYGB4BWoGN2cXwdPj3YMw2yKsLxBUw3P1kyY3TyA9yUTVkGndcDznLpugWcG9ZL s0wFh/vzbG7bLC8D2sWXnV4K2QgYstVBRSy0B5Ht4ng/c8ONAYlryg68YLqSUdb9pDo1 In+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F14s2fuGgke3fc+cUXWbJXkLt5Skh4xTYd/t6sQdYbY=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=Vm+bQ4BgWIj0f0NqhsPs/e4CNphDCJZN1ZjTDVp3pW9d+UFu6K/y0Itm/h5FQFyb2X 0dK8FqnlRN+BIJdSVc3g8VUnRa7EqBB70XPItMf2hFksuGjLqd07Dcqb7YKr7BdcDcPv ifJTFrvIaj2mqROEw8FR5Yyqp3NlC2R1UZq5JZl6X+wn1uslvgCfUHr5clgbjCd4VKBW nlJgNiOfNAPOrqzjPToIQxWxnOGtQbwJMlaLs9zpwIlhtQrNb+hOSF7/ZpnJRoB/snjl JQTXblO1CKR+UncR2Ebo4w+EEbAR3CdyNBo2nDyXDpPetp0sv8oA+FFhHyIulOl3PGZZ PjIA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=opO1NYF7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6ce00a028e0si90334346d6.481.2024.10.23.04.36.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:36:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=opO1NYF7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3Zd9-0007Ia-O0; Wed, 23 Oct 2024 07:34:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zd7-0007Fu-FS for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:21 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zd4-00037u-B5 for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:21 -0400 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a9a0c40849cso1027401766b.3 for ; Wed, 23 Oct 2024 04:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683256; x=1730288056; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F14s2fuGgke3fc+cUXWbJXkLt5Skh4xTYd/t6sQdYbY=; b=opO1NYF75BCF5psXILq+pIVtZdfMuPaNRwfMnc4fVpT6O4lwn84I1yeNp7HKzm0UK2 Z14F94YppJjB1zBZ3i8jk87B0rUnvYGS5GxpjP6Ev3ra2q2BXOTJJy0DT0NOlRme0RLt eVs3gO1BoTibUG5IAb3kUGUCk68x6fBu/9XmmYAC+E+iY6ABvBPbPm7KasTxEletmL/9 lXO7/Nd07KdPv/iPN2rhs1EXlFEhQyKyRnnDL96XBbVPgarBP6R+VOuyV2e3R2SSOEk8 Pss37qfaXGvcS9PtouDwx41Xl6sB/RU34DVOkO28CVyJ9O6SqS2jCc8kDjTH+9w6LTMd r18Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683256; x=1730288056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F14s2fuGgke3fc+cUXWbJXkLt5Skh4xTYd/t6sQdYbY=; b=ef6gEdLGLBt5we/R8QE2/25Q+/D/Abb55QhJTsp7MnsTE0+k4CfMJOjMVAdRSue/Ku M/Ms4LQ/yxiZ07ozmCl85PLVBgWhLzcuj0R8A0Bm0hgJU5V8ZtT/H/Tr42hgVymCt6hC NyX2FKvMEQGdrkNF8t7XH/O/6K0rngeW2I8j1VBVL47rOCwxwjMK1LbU5I/bmG5+VOSM EcWCf9WyWIA7loWNCUaBclO4gN7ud+ICq3zPaQQepyyDJwu7pCWpuEefwvp7ig6yQBaZ 9FCyxyX33RF3g6WUozI4yFx+II0hqfD7XPug6Iru9Qtv+2GDgKWJokGBr49sMQdZCEcZ EC0A== X-Gm-Message-State: AOJu0YzHGUK7hLYjKgMX++yFuv60VK9GaQmICZQVFRfna0ra9X/QWCv5 ckwqHfawi3zcp2kcqYtqiE5yDSwl5WE2xWRuO30uB+YJolgmno5I3zdwuc+YW7Q= X-Received: by 2002:a17:907:97cb:b0:a99:fff3:2eb0 with SMTP id a640c23a62f3a-a9abf92cf40mr200716666b.40.1729683256020; Wed, 23 Oct 2024 04:34:16 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a91559f15sm463603866b.133.2024.10.23.04.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 84B6C5F925; Wed, 23 Oct 2024 12:34:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 06/18] scripts/ci: remove architecture checks for build-environment updates Date: Wed, 23 Oct 2024 12:33:54 +0100 Message-Id: <20241023113406.1284676-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We were missing s390x here. There isn't much point testing for the architecture here as we will fail anyway if the appropriate package list is missing. Message-Id: <20241022105614.839199-7-alex.bennee@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- scripts/ci/setup/ubuntu/build-environment.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/ci/setup/ubuntu/build-environment.yml b/scripts/ci/setup/ubuntu/build-environment.yml index edf1900b3e..56b51609e3 100644 --- a/scripts/ci/setup/ubuntu/build-environment.yml +++ b/scripts/ci/setup/ubuntu/build-environment.yml @@ -39,7 +39,6 @@ when: - ansible_facts['distribution'] == 'Ubuntu' - ansible_facts['distribution_version'] == '22.04' - - ansible_facts['architecture'] == 'aarch64' or ansible_facts['architecture'] == 'x86_64' - name: Install packages for QEMU on Ubuntu 22.04 package: @@ -47,7 +46,6 @@ when: - ansible_facts['distribution'] == 'Ubuntu' - ansible_facts['distribution_version'] == '22.04' - - ansible_facts['architecture'] == 'aarch64' or ansible_facts['architecture'] == 'x86_64' - name: Install armhf cross-compile packages to build QEMU on AArch64 Ubuntu 22.04 package: From patchwork Wed Oct 23 11:33:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837815 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp407548wrb; Wed, 23 Oct 2024 04:40:09 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWewSSkqcLglqgslSWqLdQufQqgMqRhsyc25qKjA56oA6IA7uoF98DCAZOt8ggKZ9QNRBjwrw==@linaro.org X-Google-Smtp-Source: AGHT+IGglV1yvnwttg6/HNcZtQOsD8jDyYxe4EGpp/Y5RMVxnwRl8jg+WLQLKchFMeD5hU809TPE X-Received: by 2002:a05:6214:398e:b0:6cc:a17:ba65 with SMTP id 6a1803df08f44-6ce342d8c7cmr28628906d6.39.1729683608775; Wed, 23 Oct 2024 04:40:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683608; cv=none; d=google.com; s=arc-20240605; b=ZHBGLiQunoxC0DW2i38CgaQEVjco/I+fF+1BjdCJ5Yl0aMp4mDZSCu5FmB9hiU7odY kKGgs8Q0Y8ZdeNBdEiEQjveRkOgnnAZwTnoVcMEVifoE0vJDspwPRW+CxRJPYeB4zc1C R4gLHaek3vmEbYgfX4Cwk5rAwWfAn9KLcb6RV/hjPaF7Ro3mP/p0qO/yEBBaxnJi77WA TyIoJi9KUMiqcGkCQx9XiHhLY3NBOA+kFXa8WmmTgKKlu9h5ZsnU97nhUyA7TkazoLBD Spi1cT43uTFuiI8MvskNjF4TkXE0Kvl2Os0mfQywwF65c2HAqW26EYBE0/N0ugDR2mtk xuGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mXxgum5YZeyhem1wJIKkI9XyHJDK2HstmvwMGCvFrKs=; fh=p+eKEdn09QHzHdwfHiKY3bz9+G3n7au2l3N4h9YZqkc=; b=Mx27N+q+0ACJEUF9cJW7eO/1ltnDSXRDPeLsVlYIacVPK6/nKMECnmv7jtEserlVxI LZvmFgF2CnPclHujX54HuTfM5vUQJcBIs8kI1rnmpo0o2upR21jAzz79m1857FD0ryCs ZGMNtzDIN6YdxtCih5DRR+oiEeLzWCF3j9jPJaneYYNnI08QGQeGjYTFon/C7SVdxLJ8 leMMFVo9lLdqTIjMm2xBdWaZ0u4TZ7tBKoMgqzGU1o1IHgJ7lTmNT2fQE348BvHA/uod gke+LRHbWeOj8YlzIqV6azKd2TuQuwYr3Kcxq4Up2FjDk3A6c5qyV0dned4bGz5vc7qx hCVA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cs2+K6Gl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6ce00a02d4esi90684816d6.515.2024.10.23.04.40.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:40:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cs2+K6Gl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3Zd8-0007Gp-Ky; Wed, 23 Oct 2024 07:34:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zd7-0007Fr-F7 for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:21 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zd2-000371-Cw for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:21 -0400 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5c962c3e97dso8032485a12.0 for ; Wed, 23 Oct 2024 04:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683254; x=1730288054; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mXxgum5YZeyhem1wJIKkI9XyHJDK2HstmvwMGCvFrKs=; b=Cs2+K6Gla+tt0AJROazW2TdPiNLDbIEqQT7mTqNbx34ecaieEnTVaA+j+5AK7k/djC quFOBBakbMOmxRGfS3MILF4zIWg+5j6gaJA+sfuRERYNx5Hj2jQcIdDneLIqd+IMW+3m 0YOclhDsXMvTxVx0muvbcxBjHIrDOJvv3Um7rGjAaUc76gL3y7JPAIAMlZoz5PSXs9uJ CrkeuWg31tH0/vtFae2mBSal2wnn3ZcuyWBNsZSop7lGl2xuGNJ1maQr7j/LEpPeLsBw SpdM086Hw0M6SYuGDx3wxjmuJ9k/Ypm34r1U0gUkZbuxZBpyj79QHt43Zi2x7c4RZ0LG K7oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683254; x=1730288054; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mXxgum5YZeyhem1wJIKkI9XyHJDK2HstmvwMGCvFrKs=; b=OuvRqygyVXXeeAGcsZsJFJGPuOHh9/X3BMpUfLrZFRwIItJig2CN1bNN0j/zFPeNHg xMeEP5odwDFEUXUTPEoZ3eyHH8p+pLYINTlmfG4a5OWCGiy6Zy3I/SVM/SzbzLnu66O/ ohDV5By0UR/R4OR7pGb3tQrQCYpZU3wp7ALxePoiW3VLQuzcmuTy25nee3ppRG0YZQHD OcmCiDtHAhqODUZv/5Gx7WJ3WNRFzNgK8vuX0hEPVXPcm1+rwRZkiNEkMNUUfeyj98fp fSzUF0KJUXlKgQWEPcd1PUtM7oDx5Ddo4+SJgeYcakaWr1fZCJMN6Pj0MjwHDigY1HvV CEjQ== X-Gm-Message-State: AOJu0YzL/i4sgEe5+/rdgBU32d4s+kcF5IC+wKJjb8mBYcAbTu62+StD gw94+0hEUb5lBPQTKY2AK3U53M/Hdbi9RvzqXEyNZXSVD0YvkLe2B3gt3QV0PvE= X-Received: by 2002:a05:6402:2186:b0:5ca:d533:1c7b with SMTP id 4fb4d7f45d1cf-5cb8af6c62bmr2323197a12.28.1729683254182; Wed, 23 Oct 2024 04:34:14 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a654a2sm4338458a12.38.2024.10.23.04.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 9C8B75F92E; Wed, 23 Oct 2024 12:34:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , Ilya Leoshkevich Subject: [PATCH v3 07/18] tests/tcg/x86_64: Add cross-modifying code test Date: Wed, 23 Oct 2024 12:33:55 +0100 Message-Id: <20241023113406.1284676-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Ilya Leoshkevich commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before translation") fixed cross-modifying code handling, but did not add a test. The changed code was further improved recently [1], and I was not sure whether these modifications were safe (spoiler: they were fine). Add a test to make sure there are no regressions. [1] https://lists.gnu.org/archive/html/qemu-devel/2022-09/msg00034.html Signed-off-by: Ilya Leoshkevich Reviewed-by: Pierrick Bouvier Message-Id: <20241022105614.839199-8-alex.bennee@linaro.org> Message-Id: <20241001150617.9977-1-iii@linux.ibm.com> Signed-off-by: Alex Bennée --- tests/tcg/x86_64/cross-modifying-code.c | 80 +++++++++++++++++++++++++ tests/tcg/x86_64/Makefile.target | 4 ++ 2 files changed, 84 insertions(+) create mode 100644 tests/tcg/x86_64/cross-modifying-code.c diff --git a/tests/tcg/x86_64/cross-modifying-code.c b/tests/tcg/x86_64/cross-modifying-code.c new file mode 100644 index 0000000000..2704df6061 --- /dev/null +++ b/tests/tcg/x86_64/cross-modifying-code.c @@ -0,0 +1,80 @@ +/* + * Test patching code, running in one thread, from another thread. + * + * Intel SDM calls this "cross-modifying code" and recommends a special + * sequence, which requires both threads to cooperate. + * + * Linux kernel uses a different sequence that does not require cooperation and + * involves patching the first byte with int3. + * + * Finally, there is user-mode software out there that simply uses atomics, and + * that seems to be good enough in practice. Test that QEMU has no problems + * with this as well. + */ + +#include +#include +#include +#include + +void add1_or_nop(long *x); +asm(".pushsection .rwx,\"awx\",@progbits\n" + ".globl add1_or_nop\n" + /* addq $0x1,(%rdi) */ + "add1_or_nop: .byte 0x48, 0x83, 0x07, 0x01\n" + "ret\n" + ".popsection\n"); + +#define THREAD_WAIT 0 +#define THREAD_PATCH 1 +#define THREAD_STOP 2 + +static void *thread_func(void *arg) +{ + int val = 0x0026748d; /* nop */ + + while (true) { + switch (__atomic_load_n((int *)arg, __ATOMIC_SEQ_CST)) { + case THREAD_WAIT: + break; + case THREAD_PATCH: + val = __atomic_exchange_n((int *)&add1_or_nop, val, + __ATOMIC_SEQ_CST); + break; + case THREAD_STOP: + return NULL; + default: + assert(false); + __builtin_unreachable(); + } + } +} + +#define INITIAL 42 +#define COUNT 1000000 + +int main(void) +{ + int command = THREAD_WAIT; + pthread_t thread; + long x = 0; + int err; + int i; + + err = pthread_create(&thread, NULL, &thread_func, &command); + assert(err == 0); + + __atomic_store_n(&command, THREAD_PATCH, __ATOMIC_SEQ_CST); + for (i = 0; i < COUNT; i++) { + add1_or_nop(&x); + } + __atomic_store_n(&command, THREAD_STOP, __ATOMIC_SEQ_CST); + + err = pthread_join(thread, NULL); + assert(err == 0); + + assert(x >= INITIAL); + assert(x <= INITIAL + COUNT); + + return EXIT_SUCCESS; +} diff --git a/tests/tcg/x86_64/Makefile.target b/tests/tcg/x86_64/Makefile.target index 783ab5b21a..d6dff559c7 100644 --- a/tests/tcg/x86_64/Makefile.target +++ b/tests/tcg/x86_64/Makefile.target @@ -17,6 +17,7 @@ X86_64_TESTS += cmpxchg X86_64_TESTS += adox X86_64_TESTS += test-1648 X86_64_TESTS += test-2175 +X86_64_TESTS += cross-modifying-code TESTS=$(MULTIARCH_TESTS) $(X86_64_TESTS) test-x86_64 else TESTS=$(MULTIARCH_TESTS) @@ -27,6 +28,9 @@ adox: CFLAGS=-O2 run-test-i386-ssse3: QEMU_OPTS += -cpu max run-plugin-test-i386-ssse3-%: QEMU_OPTS += -cpu max +cross-modifying-code: CFLAGS+=-pthread +cross-modifying-code: LDFLAGS+=-pthread + test-x86_64: LDFLAGS+=-lm -lc test-x86_64: test-i386.c test-i386.h test-i386-shift.h test-i386-muldiv.h $(CC) $(CFLAGS) $< -o $@ $(LDFLAGS) From patchwork Wed Oct 23 11:33:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837804 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp405507wrb; Wed, 23 Oct 2024 04:35:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU2ajofgKTmQFTIkhOyv8OSO7jySczprnob02ehB1vWPwN0PWMV7mcht73LkmQKKBFA2o9yvQ==@linaro.org X-Google-Smtp-Source: AGHT+IFbFPuApzYdzWb/v810rhslFqqtzazwjs+0UoPpnJ68myawbx/YC37XlLx8Q7+Qz2G4yn6c X-Received: by 2002:a05:622a:13d4:b0:458:23fc:f345 with SMTP id d75a77b69052e-46114727a0cmr31288891cf.38.1729683304809; Wed, 23 Oct 2024 04:35:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683304; cv=none; d=google.com; s=arc-20240605; b=Fc4JaCZqQGl7p0lnAoDCz/9l0VVaVUrBASqXz4fbDTWVN5g8y355zSz5UDv+8TJDjD zOhb7Rl6UAC7cet45e2FBFuXxEaYPdLYn7BEB+GAS73JU4bSRev02VS+C3Dr2XP//WiP iSE63ZdE8xNDgHzYWB+FjldTchN9NxOQdg3aRlWqCRXoBcRUHGNjubyBH0lgG3tmPqun E7G31PtRrtihP4wqa0VbLzSLvSijtlm4j7jidaqej4fA7xAHnUueexgEmk12qWVz69PA Yvm2UpL5dVE7Layjr+Y5ROlhKoe6F9KVoWXOQf1aK4aNOy5ygXoyiwbtUeJegldBl0fO RYug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CnSO5MY5LW+ONfwtsvf8QoavFQHBZ1D8g95DfEWZbMI=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=WJrOICN+/8V/AFmQmNytp1/xVJwXNPA8TPq03yCtSrCABzreqCSGPaLtB8WlZJlvPw d01usUjSSpexoi5WRJLlGSyrcoSr63zFIIoDDT0PlzAjAEgUxcjPQV9tziYKqk9gM9PF B2YaW60PWDQEvEuHz342qyEp+B5vc9ZPa85Wtv4M9QlbWssqAqguXrJfQROXHv8Bfg0c 7gv+SskIwALP0y2rx5fFvwseOg/j2ocvH4kT2/TJd9r5R/y3yEvEW2mb3/pyRT4i9qwk ArSHFe6WvzWDW5N8VBD78QZG5bhyXvMCUBW6Vv/NydqmswODQDXl3CEfyO7Gv02RldTE ETiA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jQU2mK7z; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-460d3d49667si85639561cf.582.2024.10.23.04.35.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:35:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jQU2mK7z; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ZdB-0007KK-L5; Wed, 23 Oct 2024 07:34:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zd9-0007HK-3e for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:23 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zd4-00037Q-B3 for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:22 -0400 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a9a3dc089d8so928281466b.3 for ; Wed, 23 Oct 2024 04:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683256; x=1730288056; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CnSO5MY5LW+ONfwtsvf8QoavFQHBZ1D8g95DfEWZbMI=; b=jQU2mK7z3WhJqfx/UsSvHzqcfWIupt+nlC+hTg76NZDXNSY2tj5kIkvGzJlnQt7hHr mZvwGbwW1j8oeElIyPTYmDemcbhHZnajALtEoAF7ugxNS7WPOpIa+B4U8++x+annx4DF 5H+o0FuffaaCOY9QCCwJVG5zFkfvYN8858BS6rllI2NXcW8g6btRZq9rWHgVc/49tHmB Ewchq+87KaiSxQqrMbGqmdjtRkdKiK+wKEC9o1IwzkhYG0ibwt2hmutES50jkfw2m1ST fzXur1aPC51ZbnX25YqQsc5dXRSdNrzYyWB+fvF4ZnSMdGW0tDaMwIyQPZ50OInHTnLK d5XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683256; x=1730288056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CnSO5MY5LW+ONfwtsvf8QoavFQHBZ1D8g95DfEWZbMI=; b=eA4oDVQVyurFI4zsslXstbWYo+0J3Odpd556UcunOZs8x3T0xY6/0R0fGi4bEYapOr 8iVlpwF8zSp1eLbIN1RysM7q3YzDEGczG8/tPB3Rbb4y0z/xDeeZziroyJEayGlLOidU FbAyscmgBuwfyLdjCP4K8QNqO/GPOCArTe7GgeBnx8y05Ow5TsC0rxpsNFLtiA7CoREU m+Ny/FGVAuYJr8YpgclnaBmMamjsKaD+eNWvZdU2w9rxWdXveQja2ul8tFpHG6Cryvwr omdkbcU/XXMaqTfY4nsX8kq5kE8/E/AN8kGH2qCNqeboe9dPMDLJoRFLde4UHIoMQ2CI lc7g== X-Gm-Message-State: AOJu0YzguRGzPuT+4RSB/pF0c+LaYUOnB2GjhdOP6yl3Q+aTHOulcs07 g8qzsJIIZyaPQ4EPEQF8a1BVMgX/8iXvJq4SF/bwF1TGQtLvIps6ARAgHzSl4hs= X-Received: by 2002:a17:907:9496:b0:a99:46dd:f397 with SMTP id a640c23a62f3a-a9abf96f1f5mr184448566b.64.1729683255674; Wed, 23 Oct 2024 04:34:15 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a912ed80fsm463139066b.46.2024.10.23.04.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id B61D85F942; Wed, 23 Oct 2024 12:34:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 08/18] accel/tcg: add tracepoints for cpu_loop_exit_atomic Date: Wed, 23 Oct 2024 12:33:56 +0100 Message-Id: <20241023113406.1284676-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We try to avoid using cpu_loop_exit_atomic as it brings in an all-core sync point. However on some cpu/kernel/benchmark combinations it is starting to show up in the performance profile. To make it easier to see whats going on add tracepoints for the slow path so we can see what is triggering the wait. It seems for a modern CPU it can be quite a bit, for example: ./qemu-system-aarch64 \ -machine type=virt,virtualization=on,pflash0=rom,pflash1=efivars,gic-version=max \ -smp 4 \ -accel tcg \ -device virtio-net-pci,netdev=unet \ -device virtio-scsi-pci \ -device scsi-hd,drive=hd \ -netdev user,id=unet,hostfwd=tcp::2222-:22 \ -blockdev driver=raw,node-name=hd,file.driver=host_device,file.filename=/dev/zen-ssd2/trixie-arm64,discard=unmap \ -serial mon:stdio \ -blockdev node-name=rom,driver=file,filename=(pwd)/pc-bios/edk2-aarch64-code.fd,read-only=true \ -blockdev node-name=efivars,driver=file,filename=$HOME/images/qemu-arm64-efivars \ -m 8192 \ -object memory-backend-memfd,id=mem,size=8G,share=on \ -kernel /home/alex/lsrc/linux.git/builds/arm64/arch/arm64/boot/Image -append "root=/dev/sda2 console=ttyAMA0 systemd.unit=benchmark-stress-ng.service" \ -display none -d trace:load_atom\*_fallback,trace:store_atom\*_fallback With: -cpu neoverse-v1,pauth-impdef=on => 2203343 With: -cpu cortex-a76 => 0 Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Pierrick Bouvier --- v2 - 0x prefixes for ra as per checkpatch --- accel/tcg/user-exec.c | 2 +- accel/tcg/ldst_atomicity.c.inc | 9 +++++++++ accel/tcg/trace-events | 12 ++++++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index 51b2c16dbe..aa8af52cc3 100644 --- a/accel/tcg/user-exec.c +++ b/accel/tcg/user-exec.c @@ -29,7 +29,7 @@ #include "exec/page-protection.h" #include "exec/helper-proto.h" #include "qemu/atomic128.h" -#include "trace/trace-root.h" +#include "trace.h" #include "tcg/tcg-ldst.h" #include "internal-common.h" #include "internal-target.h" diff --git a/accel/tcg/ldst_atomicity.c.inc b/accel/tcg/ldst_atomicity.c.inc index 134da3c1da..c735add261 100644 --- a/accel/tcg/ldst_atomicity.c.inc +++ b/accel/tcg/ldst_atomicity.c.inc @@ -168,6 +168,7 @@ static uint64_t load_atomic8_or_exit(CPUState *cpu, uintptr_t ra, void *pv) #endif /* Ultimate fallback: re-execute in serial context. */ + trace_load_atom8_or_exit_fallback(ra); cpu_loop_exit_atomic(cpu, ra); } @@ -212,6 +213,7 @@ static Int128 load_atomic16_or_exit(CPUState *cpu, uintptr_t ra, void *pv) } /* Ultimate fallback: re-execute in serial context. */ + trace_load_atom16_or_exit_fallback(ra); cpu_loop_exit_atomic(cpu, ra); } @@ -519,6 +521,7 @@ static uint64_t load_atom_8(CPUState *cpu, uintptr_t ra, if (HAVE_al8) { return load_atom_extract_al8x2(pv); } + trace_load_atom8_fallback(memop, ra); cpu_loop_exit_atomic(cpu, ra); default: g_assert_not_reached(); @@ -563,6 +566,7 @@ static Int128 load_atom_16(CPUState *cpu, uintptr_t ra, break; case MO_64: if (!HAVE_al8) { + trace_load_atom16_fallback(memop, ra); cpu_loop_exit_atomic(cpu, ra); } a = load_atomic8(pv); @@ -570,6 +574,7 @@ static Int128 load_atom_16(CPUState *cpu, uintptr_t ra, break; case -MO_64: if (!HAVE_al8) { + trace_load_atom16_fallback(memop, ra); cpu_loop_exit_atomic(cpu, ra); } a = load_atom_extract_al8x2(pv); @@ -897,6 +902,7 @@ static void store_atom_2(CPUState *cpu, uintptr_t ra, g_assert_not_reached(); } + trace_store_atom2_fallback(memop, ra); cpu_loop_exit_atomic(cpu, ra); } @@ -961,6 +967,7 @@ static void store_atom_4(CPUState *cpu, uintptr_t ra, return; } } + trace_store_atom4_fallback(memop, ra); cpu_loop_exit_atomic(cpu, ra); default: g_assert_not_reached(); @@ -1029,6 +1036,7 @@ static void store_atom_8(CPUState *cpu, uintptr_t ra, default: g_assert_not_reached(); } + trace_store_atom8_fallback(memop, ra); cpu_loop_exit_atomic(cpu, ra); } @@ -1107,5 +1115,6 @@ static void store_atom_16(CPUState *cpu, uintptr_t ra, default: g_assert_not_reached(); } + trace_store_atom16_fallback(memop, ra); cpu_loop_exit_atomic(cpu, ra); } diff --git a/accel/tcg/trace-events b/accel/tcg/trace-events index 4e9b450520..14f638810c 100644 --- a/accel/tcg/trace-events +++ b/accel/tcg/trace-events @@ -12,3 +12,15 @@ memory_notdirty_set_dirty(uint64_t vaddr) "0x%" PRIx64 # translate-all.c translate_block(void *tb, uintptr_t pc, const void *tb_code) "tb:%p, pc:0x%"PRIxPTR", tb_code:%p" + +# ldst_atomicity +load_atom2_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x%"PRIxPTR"" +load_atom4_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x%"PRIxPTR"" +load_atom8_or_exit_fallback(uintptr_t ra) "ra:0x%"PRIxPTR"" +load_atom8_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x%"PRIxPTR"" +load_atom16_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x%"PRIxPTR"" +load_atom16_or_exit_fallback(uintptr_t ra) "ra:0x%"PRIxPTR"" +store_atom2_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x%"PRIxPTR"" +store_atom4_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x%"PRIxPTR"" +store_atom8_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x%"PRIxPTR"" +store_atom16_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x%"PRIxPTR"" From patchwork Wed Oct 23 11:33:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837811 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp406498wrb; Wed, 23 Oct 2024 04:37:37 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVmMlwEmr1/vQ20NLSlDisEDmcEpDt54x3MumQ8aF42hcTOq0RNiJ8lCX5wuHoRUoR4+vle0Q==@linaro.org X-Google-Smtp-Source: AGHT+IGQ2OdHH2J37AUKw5gME6F7+CrJhXlzxSfrZ99wzvZH3uGOCByuQ6MtaitOdJS3wHMG0A75 X-Received: by 2002:a05:620a:45ab:b0:7b1:4ad5:571c with SMTP id af79cd13be357-7b17e57a8bfmr240996985a.38.1729683457550; Wed, 23 Oct 2024 04:37:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683457; cv=none; d=google.com; s=arc-20240605; b=Q0LskCAxVX5JhGsUFmNrj/WrSuQkfp/RKeolTLpiEUJ5R03FfUY8CbiXtDcwcnMsaK czBI11qRR7T2aJ/Zl7Kiawd6TNCxor2siAAf/HLc63I21emxVpctCLAp8Ssb3NxFYBa1 FzW8uE6RsNS8r6MhbuctPlkkATItG8+2xSZ8BjozY/xpW+vWAZmr0Kq/d6iplutr3N4o jPV1CtMnfUG2Sjf9Pj5/kI4KwMXXXJyjCbXeXvIHMR/uDXPGd+Kch+CaWEbKfbENylyJ 1tMZ5uka5RztjzwZyhH7ORPxIgsFmhDkFwnagcU6Jn6ipzBKhiNVCp6MtGyFZ3Gnrygr Ls9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dc/d/VIiG49L+/d6qxDj8y/ZsZGo0rIznhJwT5hb3KQ=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=YJhCeT/r/N62kO10BbC3gvyU0oLGAqV29C4Btn1thkrT0aKqh0UyXIQ/YLSjFQ3/Nz W9d3Y+r0CLXUEn2L1ghR3VrmjjfHO+qXSyfU9rTvBJPXpwBLCrG4markT4v98nesb4v2 8c3a/gSd8V5QQoFSJiB3vODyAoFI5UrpTzmrwVgxafuoUXrCKsCmYWQrPm2m4xGHWpFV qa4KRE0r19/upJLz4qwmPya7krgaqSop0zJ8vLSbcfb4B8QGBqVlo2KPmYg6GI2aJA0x Mim8M7KIomKwnDDXHPIG3d11e7Mz3O3/xmm7YrNflHDyaLdyKZR50Hs4KIlcVg6lyLub plbg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nn+9Gcmn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b165a998f6si926732185a.561.2024.10.23.04.37.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:37:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nn+9Gcmn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ZdJ-0007Od-ID; Wed, 23 Oct 2024 07:34:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zd4-0007EY-Il for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:19 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zd0-000369-Ot for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:17 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a9a0f198d38so927033966b.1 for ; Wed, 23 Oct 2024 04:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683252; x=1730288052; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dc/d/VIiG49L+/d6qxDj8y/ZsZGo0rIznhJwT5hb3KQ=; b=Nn+9GcmntLkV26cfpF+y789AyNHXHDlFjCaH6lTW4w2n8nyVAVXdtPIBnIoJZq9PhC emHNqP3Z6edRclJnB0pyEfrS/bLduuQCOaQIU8VHbXJAcDRLheARjjeMbYN1bnhFNiW3 +fyC6rQWUdVGAG8fYOZvvTc+0qrETpRBesclKyxtkP7V8lYVv6UbIoU/Dre58RZKFoSm IwclX9iqzqP6BmqGjPYImcKFAqc47Ii45j02BZhV61L9ZLsmTDH6NzEKZqDgOs+aalAY 7iGTgJPqLIBTowv5lDuwpNK3vJdBvO1c5T0wHFdIdv5Tb6W798XQnc28Oy88xwqi33P4 nrPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683252; x=1730288052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dc/d/VIiG49L+/d6qxDj8y/ZsZGo0rIznhJwT5hb3KQ=; b=NzZToxPHrurlLBXt+Y8VtXFz+/giHrF7hnnFrrkkDqpMUMdv6xIjDXCVDod+Hgk8n7 ElRbOK8kIHW4mzzDyokuYUud9xl3ofxc1Ph3MUHAKQ4FS+7L+vO7Gn8poqYCP/Xw9PZO oEtwwNYFp9+GXUP41lJSj+O3Ca6gQUPqZb4d9DNvf3VFVjbA5nSEujU/2xjPWtlqcsoC WYGFcQcuwgwAb6K0H6tdsH/hq9C6Li2nVhzxQ6bCBE0f/SYsVcnK/8rBQJ9GTOymlpBx lt+8p6ndlQwXOMZYahM5SkDsa+wqY+MNP8m0tXkCR4YaHLpGSFznbcjNIblQzlvIbqOC qpVQ== X-Gm-Message-State: AOJu0YxzYGD2PcHOdkh9lLNtXhybsCeokrS8pNUu9PZ2eLSTO9RmkzxU UfQcz06uzl6dmfSzvezP2d7WhD4kXXs9ZNA+udzjM7q04dLs4MoDd9o6WuUv0M4= X-Received: by 2002:a17:907:3f98:b0:a99:ebbb:12fd with SMTP id a640c23a62f3a-a9abf96f557mr195597966b.65.1729683252535; Wed, 23 Oct 2024 04:34:12 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a912ee125sm463814566b.75.2024.10.23.04.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CBBA05F9D0; Wed, 23 Oct 2024 12:34:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 09/18] dockerfiles: fix default targets for debian-loongarch-cross Date: Wed, 23 Oct 2024 12:33:57 +0100 Message-Id: <20241023113406.1284676-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier fix system target name, and remove --disable-system (which deactivates system target). Found using: make docker-test-build@debian-loongarch-cross V=1 Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20241020213759.2168248-1-pierrick.bouvier@linaro.org> Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker index 79eab5621e..538ab53490 100644 --- a/tests/docker/dockerfiles/debian-loongarch-cross.docker +++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker @@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08. ENV PATH $PATH:/opt/cross-tools/bin ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH -ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools -ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu +ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools +ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu ENV MAKE /usr/bin/make # As a final step configure the user (if env is defined) From patchwork Wed Oct 23 11:33:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837808 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp406125wrb; Wed, 23 Oct 2024 04:36:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVCGMZ2MQ9Ak87T6x58it/yxdldHFtyj1AA3qsRtF2bo33BJpWd7hu0t1lR1sRg9WuDrAkQKQ==@linaro.org X-Google-Smtp-Source: AGHT+IFM7Q+IiCjWNbNcP2mao35ttn6JY1bRn3VbBiIkJIWMgbG7ibi2HnexMtl/d42b/wn4RCLp X-Received: by 2002:a05:6808:302a:b0:3e5:e092:cd52 with SMTP id 5614622812f47-3e6245ae506mr2693013b6e.40.1729683400717; Wed, 23 Oct 2024 04:36:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683400; cv=none; d=google.com; s=arc-20240605; b=WSDPJ39DTZ6AVeQPlrBfIV6GF+m0rf+68yVLKFey0/CgG/ydX/azSrIz+XrZBT7FTm BTOaZqyN0+wuueKA3dONHit3a7Wn5P2DDMgwTiOesnMpGAlydAJzrHYjsSQ7QTsyM2mz npH4cqkCF5Tv9XyT5N/X8VLhxFnIOBuwlgGBywm057IbtalgoiG2rcwgm4Id8Gp6+6X4 SGaJ/nsOLmxRCprVMlNRZlmEKohcgGGKp5kWXWIQR5/MOmhUxmY2hZgCKTrB/XvWuGIQ ZXBnhEAfB6g1OXRqY1EL53Pd5QrAcHpTdRdOKcYg7W7n+bv0VYrTsu7JK9xS8jQ/LdVu b80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ofWiMJKewV0PnnRBMLTuVVpoKKxPWtTmA16jFFUgpg0=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=JzbkYinCDJ8by0Oc4h7vhmrx/4O+8Naf9gSNiH73PMhvjhMUsBCCshE7Vbze8aBPMu uiZYHw8cnecK+/bSNtwg4ywQhqv7fTQTsFBYpgIJldkCJLJeRYzyA9psUgPpCw9O8kQc orDlkQ2gZ2TWavbcyLSmLRHU3zsyuBDwks6YWsbqrOYbrLZvd+1XgXv9O7KUUtnsvS4p b/+8C81gr6KZwc8jcqGHHFrPtynC7shjGf0IJYoB7f/BaMHWd26gzs0j2yIBdN2glwr3 x9PP82LcoVpy1buJbvms0/p1t0DvVSxcaXySAVmtLymPUVHTij42QX1AktPyDI/7Lk9w Yb0w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BIrsmyDF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6ce0098b101si87372796d6.305.2024.10.23.04.36.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:36:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BIrsmyDF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ZdJ-0007Of-Ot; Wed, 23 Oct 2024 07:34:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zd4-0007EZ-If for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:19 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zd2-00036M-CH for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:18 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5c9454f3bfaso7887323a12.2 for ; Wed, 23 Oct 2024 04:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683253; x=1730288053; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ofWiMJKewV0PnnRBMLTuVVpoKKxPWtTmA16jFFUgpg0=; b=BIrsmyDFut7RonuX8l0QGtCPKVIUpg0myGKnhvIY+nomUlyoPk7oSGT8Yc7lWSB61y 38hVVJApn1maq7Oq0p+V/zFQ/EsthG9dFmpFfCsg1I70HhVB3F3SGOin9akFDeZZo7+S ZDPjX8WWM+MOhah8wW+KNxSRNNVGq2IXXUiMqExkUSp1xqI9bxEZ2ZBdZrEq9Uog5h/a YzhdNNozpl4fCkdx30AO/Ul43mlDptmk/nYZHCfyi/jWnj0YO6j/jI/rgS90ZRi+v60d iBJbNFQ7wjVA7PuehCzGcCzgoRk9Ty5SU020YCGgrF/iiqmsb4Xr7spHBFO2iBBQEh+T 77Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683253; x=1730288053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ofWiMJKewV0PnnRBMLTuVVpoKKxPWtTmA16jFFUgpg0=; b=PCJMoKr8wgVcH35m5mOHs0/WN+M+gvOeSwoKs6KxZtvQEUtBEq42PzYMX1N9GicjNY kQKKQ5UA2/1NZrla7D1A+v7wXfUlJInnKJdpViRJIh+xozSobT0hg2RceKobEJK4T8BD UDxAAWq0gN7YKEncVK+QnLskMlBZRsWEj74B7uLcf3wmzwcWirC+vW9dcfEvt39DkyuT vXthV6FlDeUiarwKOMf/v+3qB9qiKcjVpNzTbYLwc0EOS8h0bD4vAvnroIUbTKxMmrDs 5id/emGFTR1T15H/MvKejo0Wm/EujrWCss7Ow56J/t6MSqHLa4Au82J2MXlm+UpUbamv Lsyw== X-Gm-Message-State: AOJu0YxxoU2NqlpHfmnyc5xFuRe06AabpbgSixrqOwFBMWJfvTMKCVaG MLOPZQoeHinPcv+ZiqvGBAO17xsHr6Lcgpe1XTEcKOaWEtVQCsYflKAy9H9Gmak= X-Received: by 2002:a17:907:7e97:b0:a99:e619:260e with SMTP id a640c23a62f3a-a9abf8acd51mr195736866b.28.1729683252885; Wed, 23 Oct 2024 04:34:12 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a91370744sm465054866b.131.2024.10.23.04.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id E3FA95F9DD; Wed, 23 Oct 2024 12:34:07 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 10/18] gitlab: make check-[dco|patch] a little more verbose Date: Wed, 23 Oct 2024 12:33:58 +0100 Message-Id: <20241023113406.1284676-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org When git fails the rather terse backtrace only indicates it failed without some useful context. Add some to make the log a little more useful. Signed-off-by: Alex Bennée --- v2 - keep check_call, just don't redirect stdout/err --- .gitlab-ci.d/check-dco.py | 5 ++--- .gitlab-ci.d/check-patch.py | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.gitlab-ci.d/check-dco.py b/.gitlab-ci.d/check-dco.py index 632c8bcce8..d221b16bd5 100755 --- a/.gitlab-ci.d/check-dco.py +++ b/.gitlab-ci.d/check-dco.py @@ -19,10 +19,9 @@ reponame = os.path.basename(cwd) repourl = "https://gitlab.com/%s/%s.git" % (namespace, reponame) +print(f"adding upstream git repo @ {repourl}") subprocess.check_call(["git", "remote", "add", "check-dco", repourl]) -subprocess.check_call(["git", "fetch", "check-dco", "master"], - stdout=subprocess.DEVNULL, - stderr=subprocess.DEVNULL) +subprocess.check_call(["git", "fetch", "check-dco", "master"]) ancestor = subprocess.check_output(["git", "merge-base", "check-dco/master", "HEAD"], diff --git a/.gitlab-ci.d/check-patch.py b/.gitlab-ci.d/check-patch.py index 39e2b403c9..68c549a146 100755 --- a/.gitlab-ci.d/check-patch.py +++ b/.gitlab-ci.d/check-patch.py @@ -19,13 +19,12 @@ reponame = os.path.basename(cwd) repourl = "https://gitlab.com/%s/%s.git" % (namespace, reponame) +print(f"adding upstream git repo @ {repourl}") # GitLab CI environment does not give us any direct info about the # base for the user's branch. We thus need to figure out a common # ancestor between the user's branch and current git master. subprocess.check_call(["git", "remote", "add", "check-patch", repourl]) -subprocess.check_call(["git", "fetch", "check-patch", "master"], - stdout=subprocess.DEVNULL, - stderr=subprocess.DEVNULL) +subprocess.check_call(["git", "fetch", "check-patch", "master"]) ancestor = subprocess.check_output(["git", "merge-base", "check-patch/master", "HEAD"], From patchwork Wed Oct 23 11:33:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837812 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp406908wrb; Wed, 23 Oct 2024 04:38:45 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXtcl6pKYClPTr7cP01Ct7Ad3R3mmRJPDggIUaVob4m+8rqGgYlAtq69X6a3SScBOAZ5q4ncQ==@linaro.org X-Google-Smtp-Source: AGHT+IF+KmyYf7bTYjVqyFgZtT4iyWN2wOFZ0M91AAb1XBuSFAd3hOI0auXgbYsAUxEhanER6OYH X-Received: by 2002:a05:6122:8d4:b0:50d:4cb8:5afd with SMTP id 71dfb90a1353d-50fd0208932mr2740906e0c.4.1729683525575; Wed, 23 Oct 2024 04:38:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683525; cv=none; d=google.com; s=arc-20240605; b=Ni80pvUkX+uz3rX2/KTm30tszupVxNrX4SJRIinOO5k8/0wLA9cBBpWRRZTX1ZEq/u SHL7INNclxh1F4Vfc56TGZ+2IKM0JhPJLHOb2TjNE7CwoeaWhleZszGoWx/SZdOgpeRj awpBgM75giNqCh0O3rX3+0R5U3/0FywrVmbkykbzP+UhAVckK3gFQWLsUoVw7lJlG+Mi 2LXw090OQ2f3uIOTH2APpSiWCsNHVECxasJUAvkwunBbr0ARMwZwJDTEW5wjNH0EhOPI lX/otdwSM2QyPuIsw4yWw2wHG8U64xe0d9ViJSuhEiEPJ+3tbgYNdwiNLm8zu0XE6lfg Vb5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1qX1H0ILZzPVxOYwNvN6Q27i9glRVOd//mtyRaXauYw=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=AGDzy3DriSk0VauC8j/wbo2ZYYSFaVOn/mjfRUvb8IKJyLFZ7xQVTI874ROX6Dsok2 S4wfu2NTsnfPHVLcazm+RaedbHk4d+eXVlb0e/M5G1nK/wg31shRS5ebCnQzdBxnDIrK ramb8NXJN8zyxgJXkqeWaZPMmEJdYiZPeDiyfr5QoZwmX5yW7Ukm/cCayMXmu05nVS85 fvHMD2ZGqf77uWXpDfhXA3NDvCHu08itvA67WsB+8X18SaswqgCiq6ghqtPYWe9H7v+z 4P/eylOfyUJVVHrfGblHA5lakI2Ya3b+/ZjrhzsDPsR3zRm0RWbUcRdRlq3wTfJVBNU1 LJ3g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NBdbNKBW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b165a70648si878563885a.302.2024.10.23.04.38.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:38:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NBdbNKBW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ZdE-0007Lp-BT; Wed, 23 Oct 2024 07:34:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3ZdA-0007JB-EJ for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:24 -0400 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zd5-00039f-OT for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:24 -0400 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-539e13375d3so7403434e87.3 for ; Wed, 23 Oct 2024 04:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683258; x=1730288058; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1qX1H0ILZzPVxOYwNvN6Q27i9glRVOd//mtyRaXauYw=; b=NBdbNKBWtJaKwVrYgDEy5W99fHWwFaSDCveYBvMTIX3ATnkBzfGQjkqQ3QjLxBjSzU Zw1W1gi7T0nj7atfn+Cm8Mexl7UzYO+DlEbQ+vLTwpiCUmB/cvPop7bhLYq8m4i+CVGJ P0zat9HmLcbSK5yYafuaRRviJ9WPZKKIkf742vsInvuST6zBzvNupEN7exUaxaa+BMZN XPF02AsRzb79S4c/0k/cprUUM7IbskVZp1ktLT03d0LbmHKi0b0ZmS2jvnq04URPX7R5 DfpP9DyjLahgZooZx5gQbBkWAe9JhJvmRShqksAvsHTj2Br/w7qyTayR6EtHmoeFPX2x inQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683258; x=1730288058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1qX1H0ILZzPVxOYwNvN6Q27i9glRVOd//mtyRaXauYw=; b=c4G/WdE6kYCNgjvDbJSQBQsOR2EndkmboEmGs8ENj8EALgMfVQ5a7WIEjZeKagnFYv suCYW3RcUb8xvF8ztR4F4F8EWMHNtqDQ0F9z+q9jXXiFRECHNtz4hrieuRT3NeM86ZFA fQA3LA+HF2H/J1aOfWKcAV2GpJaQ2KQX3TwcP5j/7ngDyuhvV9QQKKiA9OaazTGpDgRK vOlPpXkWNbCOiW9wpS7d/odYp2vnUUl8oMd3tQbtfXq4KGreGm3aJiEl/UEaXRgzLSty hUtuSGlqnzZ2lYKl3Ul4+iXG5mAd7XlqFGhGYOUU+nQrmLfy9FE/UhgOhZHDh4a6FN/S Eb6g== X-Gm-Message-State: AOJu0Yz8/1VD6mZp7z9lRbdNUmIrP5V1D0lODltow/hN431nqU0b7deS aV/cAfywE0UBXUf3ihkz915U9yg2KLHVd4YA7mP89YOfaOtZyfjX2XHjde1E5Zo= X-Received: by 2002:a05:6512:2243:b0:539:530e:9de5 with SMTP id 2adb3069b0e04-53b1a3a7ae9mr1018902e87.56.1729683257601; Wed, 23 Oct 2024 04:34:17 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a912ee061sm464471066b.63.2024.10.23.04.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:16 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 061BA5F9EC; Wed, 23 Oct 2024 12:34:08 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 11/18] MAINTAINERS: mention my gdbstub/next tree Date: Wed, 23 Oct 2024 12:33:59 +0100 Message-Id: <20241023113406.1284676-12-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x133.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Make it easy for people to see what is already queued. Message-Id: <20241022105614.839199-12-alex.bennee@linaro.org> Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ef1678a1a8..7eea7b7954 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2984,6 +2984,7 @@ F: gdb-xml/ F: tests/tcg/multiarch/gdbstub/* F: scripts/feature_to_c.py F: scripts/probe-gdb-support.py +T: git https://gitlab.com/stsquad/qemu gdbstub/next Memory API M: Paolo Bonzini From patchwork Wed Oct 23 11:34:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837813 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp406928wrb; Wed, 23 Oct 2024 04:38:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXznwchqwIhbmgv5YE7QBKbUxPBzCKuDvCNiqpYo/v1dsuN6MgxAlKaoHtx04FenePxUX7W5A==@linaro.org X-Google-Smtp-Source: AGHT+IEnEyfw8O31d5WtOzmD0XUCsRYjsjVnLRaJeWLEE7HOSRkccrUYXsJcisnQVBJqth2w+hXg X-Received: by 2002:a05:620a:44d4:b0:7b1:4d40:52be with SMTP id af79cd13be357-7b17e19db94mr363655485a.1.1729683528269; Wed, 23 Oct 2024 04:38:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683528; cv=none; d=google.com; s=arc-20240605; b=TB+9ze5u1JPLB+G+24/5GWLOxCpZo/7mVjDLvyt/SQ0XIedW76xUlL6bMPqUWyix2f mXq3SMUEH0jCsIEMdrkAKmYyMudGckjJkipmiTHK4jr0h6XyM9wSV6y2uQvxWgfz2Sb0 KwA0Gj4dgF8Qb6VPERHKtRHM5w+lIuI0txupY7zBlbHOjoMEpcyAHqk9lyCkWXIzQCch E3EREFhgxT3X/djShDX4VginQp5ZCmC6cllIzm1KWhepEvimD8GbMbhX96URHQuhCqAj rM7oGcEfHel0GiYZ4yu6kQIt25mAUUX3d5sbL4OJ9P++3+i2PWnoMUFCtHDqD9DrFst9 lG7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VE6CRJWS0PrV56e8l4nrxhdjzzIjf9914lqwk9uoLck=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=fnBNbtf0Va5KRklJyfGP8ORBjGwAKUGrf4SmFi3GenIterRPa4XQNP1axn1d0y193C woYXS4Pk3UVxnqLA5pcyARK+oXmVXfSG/Y1RR8iWLprYwM6YiedvPrE780iEcIo5m/k7 qvf+NCcm8OHheg2qgg2Cn6EBtO+tGn14vUNcDxw/JjVaGG0E0aiC/QAA84iq+/CqeUnN 2JcqK4KHDSjfviYiWd9Y2FOZo9Uy1kROKhOAErrc2G7+rIMz82EXX6Cx7/2a0dGo1v0J 7tEJ1Hqz4GQDwyt6K/XB59zJjx0WRgqCZfxaITfAOVsOnilsoE4s/W79Ub7uWXQrIENE DG+A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o2YceghB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b165aa397bsi864812085a.680.2024.10.23.04.38.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:38:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o2YceghB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ZdD-0007L6-Tf; Wed, 23 Oct 2024 07:34:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zd9-0007H9-0u for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:23 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zd5-00039q-J8 for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:22 -0400 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a99f1fd20c4so902102366b.0 for ; Wed, 23 Oct 2024 04:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683258; x=1730288058; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VE6CRJWS0PrV56e8l4nrxhdjzzIjf9914lqwk9uoLck=; b=o2YceghBHeY3zB84UkwMZDChzV8I08YQGBDmm0RJFSdiaiKrZKXbjQ8mLjQLHgY/qq OUaz9qJHHuk1qmw2UdlKFwjHXDw9TS2OPihmRaERoetnuFnu4/VI0trUh9HucWbuQR1E r1YhigYERo0K2Qyo+4BAG6sJYAcMbHbk29qPW78v1RbzkBybludgSBJmlS5/u+t9Jlap NEmNTmW1Mo7DCUYuFJkKeE1MbalyLNhS4OgFqJgVWRxvhxCD+egTxvQLWE3jwgsqBYg0 JuZtvS59esOeeWmpsV09B79GGTf8aezeagiuDpDYdRDtEWgwrpA8NrWf22DaCR19vpY4 9z7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683258; x=1730288058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VE6CRJWS0PrV56e8l4nrxhdjzzIjf9914lqwk9uoLck=; b=NrPn+ZllknkeizQNmEMqG03RgPIM34HPjlIecpRxh4Gfgw66KxOcMj6zdf5y0O2jlL HTDB/iW/A4nKFDGPYP5Q6Av+G3IndLZ+vswTZhd6Z5f0sqRAnMRcB9WiRfAcnLgGLDUH B5bFZVLkTI0ScL6aDzTJhEglbeWp9uoliVtpoL6QUWY7eBBpW/WfLdhpEt0esFbZiVlv B0a8As1hlJhR1AJz44vebqTXtpaeRvRNtuwMISFP/2DMPtWJWXgHZdjQUe9c4hhrLv7+ H2BT+ZvyplAgPK5ffg3SHw2V6QAWXsh/KVG9ccPMtz7oetLXWbf3J5VK+YEEC/EBZkKQ 09xA== X-Gm-Message-State: AOJu0YxPURZ2/BO1Z2fJU8Ls2VmE+qGQMe57DrNDIl/8nQhv+xaG4nqF GxjDVb6glqzRcJkF7Cli8g4JzOJR8XmvTWhXsn4Sy7DjeK9tuwGvacLl3VLEfyU= X-Received: by 2002:a17:907:3e27:b0:a99:e82a:87ee with SMTP id a640c23a62f3a-a9abf9660a9mr167046366b.57.1729683257920; Wed, 23 Oct 2024 04:34:17 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a91306fc0sm464586866b.91.2024.10.23.04.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:16 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 1BD045FA0B; Wed, 23 Oct 2024 12:34:08 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 12/18] config/targets: update aarch64_be-linux-user gdb XML list Date: Wed, 23 Oct 2024 12:34:00 +0100 Message-Id: <20241023113406.1284676-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Attempting to run the binary asserts when it can't find the XML entry. We can fix it so we don't although I suspect other stuff is broken. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2580 Message-Id: <20241022105614.839199-13-alex.bennee@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- configs/targets/aarch64_be-linux-user.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/targets/aarch64_be-linux-user.mak b/configs/targets/aarch64_be-linux-user.mak index 778d22b2a9..dcef597a80 100644 --- a/configs/targets/aarch64_be-linux-user.mak +++ b/configs/targets/aarch64_be-linux-user.mak @@ -1,7 +1,7 @@ TARGET_ARCH=aarch64 TARGET_BASE_ARCH=arm TARGET_BIG_ENDIAN=y -TARGET_XML_FILES= gdb-xml/aarch64-core.xml gdb-xml/aarch64-fpu.xml gdb-xml/aarch64-pauth.xml +TARGET_XML_FILES= gdb-xml/aarch64-core.xml gdb-xml/aarch64-fpu.xml gdb-xml/aarch64-pauth.xml gdb-xml/aarch64-mte.xml TARGET_HAS_BFLT=y CONFIG_SEMIHOSTING=y CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y From patchwork Wed Oct 23 11:34:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837809 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp406206wrb; Wed, 23 Oct 2024 04:36:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXZuenrIAm5xfnCePZcYDiZAle2iHLfIgcjM5cOnhDeZ2V8ANHjcj5cjmzeCsX5JcHoOSIv6A==@linaro.org X-Google-Smtp-Source: AGHT+IGn0JbPjPaUmo0NXwUpp9Wk4nVSAvsI2JGYmxqCh8Yyn3S9QjZm02K9if2iej8isOPcQIcE X-Received: by 2002:a05:6808:3998:b0:3e6:b47:6226 with SMTP id 5614622812f47-3e62452d459mr3028602b6e.27.1729683415286; Wed, 23 Oct 2024 04:36:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683415; cv=none; d=google.com; s=arc-20240605; b=MQP4EKZvL5Zji+vFusfUmdUdEHIGDFiTyuL9BZftWkcp/7slYM9nW8GqCMTPeUSlWm 2D5HHpmGzrJPNLaw8EQ05WJdaJs8CZTbGSynxpUFUF/9xuY+urkGvO+VYHleSVHqHhpT bVLR5pOasZ70mb/sZ2bcoSklmzUViLej3u9n+qi2J0qV+CWLn4AXT0jbubh4clUZ7CEI Szl4/24lxYapoLxb6Hh50+3rnJrV8VxBZLOtIjidi0fq5sAJF2WfwqiPIYU6ADC2kgkv 7nrtyMToEKsevyWJEeyPoVndujC4qpIvxWfvnMbaiXBXuU/RCfkgzUvWv7WAZrYxsB8k 0krg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7pLXAr/OU0jkbK3hvA7jKCluJF6NjbiqDXh6Q2a0Cto=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=ckSOaDeTkUMHIpFZMjM/8p73fX63ePe+/F68YsXK70Jjzx9kVIKX41VdxFZE02VJuH Aomzs94VuOy2kD4gDh2Hrz5bjl2d3MiP24Na+Qu2b24AUKLCQ4UI+09FSAJ9s/SAPY/B Jrtl38RudXVS5p5OD6s2k1rLNuFXvhCnuD/DpvdgVGVC8B+tLrlYQbiwTLePJZxCiFkm MhWlwpbu2nTrDglFFAz5AaAezSIB5NhiwQNYc4kiTgnPYo3PP1CRjeRPhcis5e9ZY9Pc jM1AMSp6k3mdAHbUh0m+CWr4FfyCU7yr/4fWpUpoy8Dg5lGxiLXecWmf3mKcUTtlAn+d dTtQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xNqooZ8H; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-460d3dacb5csi86144381cf.763.2024.10.23.04.36.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:36:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xNqooZ8H; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ZdG-0007N0-JP; Wed, 23 Oct 2024 07:34:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3ZdB-0007KS-P6 for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:25 -0400 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zd7-0003Al-IA for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:25 -0400 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5c40aea5c40so612788a12.0 for ; Wed, 23 Oct 2024 04:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683260; x=1730288060; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7pLXAr/OU0jkbK3hvA7jKCluJF6NjbiqDXh6Q2a0Cto=; b=xNqooZ8H09y9F7nP7yXiphk78kIYgcBQ5c34aqCW7e7AeIiUZcPzBDi7pHGPAuDRET Wgo/w4+lmY0xkEfUTy/VPGhlVx0huA2AfiXwBjQ7GDmsCO8kcGkznxxDLxPBN3G2IQJz xBZYrxvqSoBzYcpKyGSAhj1ioHuwlWlZxtafn7a9jLfXQ+hv3eM59P6+62T/1sgcQ8jL JHMKWPVAooOkGnf/8ORs/exaZ3KeM0Oh2TKppOL+TZm8NWh1rxs1a2UktW3TFnrZZcha M24slX4MUUNinpha4N9TOOxROXYkVZ/4GxZgCiNBG3DvcQ82yz2PnL/0LE4/Q1J7O1Yr wwqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683260; x=1730288060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7pLXAr/OU0jkbK3hvA7jKCluJF6NjbiqDXh6Q2a0Cto=; b=N8Y4VIzhqlhysGG3arOqshA+L55oKFypbNpjbItK/PAHFKdQkxI0J78qZXAVfA6pgq SELURETs48/fXWZYdsSDpgQydt+d16HS+tXyGOWZV2xQ3SjxzarvDJx+dMcNZXjpQVb6 V9IU5aI/xTT8EcPzTMSGgzak6OTg/IN9xq7atjcdTv/RuRiuTmDZMADLUvYQCKDxCwZG f98R9tcqtkazPBx0CFS7BBFwAPcVX7DUK2ylG563SNhwAOGMiFbS+0clohhusmmkl9QZ 4NtxR+k9M5O3EtB093ENi8zKRagGZO6vKhVjokJyW6WE6TlQDpm2yQD73D1PuUB3ZRHR LXcQ== X-Gm-Message-State: AOJu0YzoUeVXLTdaoW40362C0NJk14+sNL+6lo9T0Deso0eFIuI/DzFa Ym94mONBt7JksJPi2Do45007E82pp4YATuk2JDArVRB4n4TqaUJDhaXCLGXYcO4= X-Received: by 2002:a05:6402:42d2:b0:5c9:60a:5025 with SMTP id 4fb4d7f45d1cf-5cb8b53d00dmr2462019a12.9.1729683259827; Wed, 23 Oct 2024 04:34:19 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66c6b18csm4250181a12.62.2024.10.23.04.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:16 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 397B25FABE; Wed, 23 Oct 2024 12:34:08 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 13/18] tests/tcg: enable basic testing for aarch64_be-linux-user Date: Wed, 23 Oct 2024 12:34:01 +0100 Message-Id: <20241023113406.1284676-14-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We didn't notice breakage of aarch64_be because we don't have any TCG tests for it. However while the existing aarch64 compiler can target big-endian builds no one packages a BE libc. Instead we bang some rocks together to do the most basic of hello world with a nostdlib syscall test. Message-Id: <20241022105614.839199-14-alex.bennee@linaro.org> Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- v2 - fix checkpatch complaints v3 - fix libc typo --- configure | 5 ++++ tests/tcg/aarch64_be/hello.c | 35 ++++++++++++++++++++++++++++ tests/tcg/Makefile.target | 7 +++++- tests/tcg/aarch64_be/Makefile.target | 17 ++++++++++++++ 4 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/aarch64_be/hello.c create mode 100644 tests/tcg/aarch64_be/Makefile.target diff --git a/configure b/configure index 72d1a94225..7dd3400ccb 100755 --- a/configure +++ b/configure @@ -1418,6 +1418,7 @@ probe_target_compiler() { target_arch=${1%%-*} case $target_arch in aarch64) container_hosts="x86_64 aarch64" ;; + aarch64_be) container_hosts="x86_64 aarch64" ;; alpha) container_hosts=x86_64 ;; arm) container_hosts="x86_64 aarch64" ;; hexagon) container_hosts=x86_64 ;; @@ -1447,6 +1448,10 @@ probe_target_compiler() { case $target_arch in # debian-all-test-cross architectures + aarch64_be) + container_image=debian-all-test-cross + container_cross_prefix=aarch64-linux-gnu- + ;; hppa|m68k|mips|riscv64|sparc64) container_image=debian-all-test-cross ;; diff --git a/tests/tcg/aarch64_be/hello.c b/tests/tcg/aarch64_be/hello.c new file mode 100644 index 0000000000..a9b2ab45de --- /dev/null +++ b/tests/tcg/aarch64_be/hello.c @@ -0,0 +1,35 @@ +/* + * Non-libc syscall hello world for Aarch64 BE + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#define __NR_write 64 +#define __NR_exit 93 + +int write(int fd, char *buf, int len) +{ + register int x0 __asm__("x0") = fd; + register char *x1 __asm__("x1") = buf; + register int x2 __asm__("x2") = len; + register int x8 __asm__("x8") = __NR_write; + + asm volatile("svc #0" : : "r"(x0), "r"(x1), "r"(x2), "r"(x8)); + + return len; +} + +void exit(int ret) +{ + register int x0 __asm__("x0") = ret; + register int x8 __asm__("x8") = __NR_exit; + + asm volatile("svc #0" : : "r"(x0), "r"(x8)); + __builtin_unreachable(); +} + +void _start(void) +{ + write(1, "Hello World\n", 12); + exit(0); +} diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 2da70b2fcf..9722145b97 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -103,9 +103,14 @@ ifeq ($(filter %-softmmu, $(TARGET)),) # then the target. If there are common tests shared between # sub-targets (e.g. ARM & AArch64) then it is up to # $(TARGET_NAME)/Makefile.target to include the common parent -# architecture in its VPATH. +# architecture in its VPATH. However some targets are so minimal we +# can't even build the multiarch tests. +ifneq ($(filter $(TARGET_NAME),aarch64_be),) +-include $(SRC_PATH)/tests/tcg/$(TARGET_NAME)/Makefile.target +else -include $(SRC_PATH)/tests/tcg/multiarch/Makefile.target -include $(SRC_PATH)/tests/tcg/$(TARGET_NAME)/Makefile.target +endif # Add the common build options CFLAGS+=-Wall -Werror -O0 -g -fno-strict-aliasing diff --git a/tests/tcg/aarch64_be/Makefile.target b/tests/tcg/aarch64_be/Makefile.target new file mode 100644 index 0000000000..cbe5fa0b2d --- /dev/null +++ b/tests/tcg/aarch64_be/Makefile.target @@ -0,0 +1,17 @@ +# -*- Mode: makefile -*- +# +# A super basic AArch64 BE makefile. As we don't have any big-endian +# libc available the best we can do is a basic Hello World. + +AARCH64BE_SRC=$(SRC_PATH)/tests/tcg/aarch64_be +VPATH += $(AARCH64BE_SRC) + +AARCH64BE_TEST_SRCS=$(notdir $(wildcard $(AARCH64BE_SRC)/*.c)) +AARCH64BE_TESTS=$(AARCH64BE_TEST_SRCS:.c=) +#MULTIARCH_TESTS = $(MULTIARCH_SRCS:.c=) + +# We need to specify big-endian cflags +CFLAGS +=-mbig-endian -ffreestanding +LDFLAGS +=-nostdlib + +TESTS += $(AARCH64BE_TESTS) From patchwork Wed Oct 23 11:34:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837805 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp405644wrb; Wed, 23 Oct 2024 04:35:26 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVDGV3V0A0nc/vwVpVQb/uS2VXOMkgZHR+utuglHMc7nx2Wxp/nsWYd6tEK7/6db1PpMiwTww==@linaro.org X-Google-Smtp-Source: AGHT+IH/oEgbr9qd/zrFRJr1r0KdKNDczC1b3fu0ageUOvwi/RW3saBJ21oijDlrEI92D5N3L/xw X-Received: by 2002:ac8:57c5:0:b0:460:3ee4:aec3 with SMTP id d75a77b69052e-460ff674c8cmr120613861cf.28.1729683325949; Wed, 23 Oct 2024 04:35:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683325; cv=none; d=google.com; s=arc-20240605; b=H60wJjBPiASmzy8yOKskY2W7/JTmFWKZMyr5UGgpO4uyHOTOYtK7uREzRSgirZyM6P G6fK7FcHXswlhMaQmwVZiKceU4WUenRPjlJRg7Q3JK9ga3zdmEbSmtLvrF4j1zQi/O2K Ph/Ay6HdgSNSPoUxOAVLgUdHvSx1aJ/Npy68GsUBBE/qLOcjt+nVJroLQxLevj1UBp9J Y4XBASIHUzc2rRn2yoA38GBgq7utyh4LayWTvmwBWhUw0PzErz9UYb5GSIogZD8wvlx+ oynpbfzOULXz4vSY0Vhwi2vCFCJWlXYAfbv1QbEjN3Zm0a5npbt+8iOUvJhEpo2X1p2v 9Smw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Pgb6ox3Ya7i122uZlocXrETTS1VOKhPW7bSAndX3jjQ=; fh=l1t90F6F6JZSpbj7u9iYi6XNqmAxS8H0cD2356tyWXo=; b=U9qKv9EeZ+n3oLYPdD7MnOY0dLHbiVj8K2I3ufKwC4tLwhzNhFaHcJApQzGkRK8VBE lFzM7toKneOblGKsmXFlKzNIRJAlBLWDmIFi3qGDm0hiAoGDj8UITNodf0l5NQtcIqXa Nz6kPs3EnSaca5R49cq/q5ZlJBcjrazx18G8nebTNqLHrlWN9S8fEMooYBwBtlsJnVxq zwWH+69UpHghYcLbeicxGZLmC5CCk+FUt6nQQcPJPinzpbYGXsIoVa+x51JnrXmYHMQ2 PAI3uPrxPxAeFC4kb1dIk4QQS++g9S8rpvw9j2R4DUraOh+CE66EdDqqhlzqDNxIPbNy QuJA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JdoPzub4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-460d3d4ab39si83915281cf.585.2024.10.23.04.35.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:35:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JdoPzub4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ZdE-0007M9-Vu; Wed, 23 Oct 2024 07:34:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3ZdA-0007JA-Bv for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:24 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zd5-0003A1-TD for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:34:24 -0400 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5c962c3e97dso8032564a12.0 for ; Wed, 23 Oct 2024 04:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683258; x=1730288058; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pgb6ox3Ya7i122uZlocXrETTS1VOKhPW7bSAndX3jjQ=; b=JdoPzub4/WCKhYFUSb1nVoi7+m34EEvO83ag6ti9knbL6ovsMwky7NHVHQfw+Rrfv2 3epzuFWRs3F5u6c4QWKicwRujtrDuG5Ho13VmiCoK33oglTEsvt+vINXN97C1SbUDNek DUEdfET06yP4oxhlTerQQ7EDHujWpdr40TZinrUuxQDIzTmn7IJEaKu3H5VEKGgtFJrs ArcX4ICroe4ExxiKYXvtav4XEHQ/wOMF916HxSJKfpe9HeZEckI3e2Ywi8h9CnHwUZnE xbswocxRNRhx+nIkhYIRHbvLTLtJA+nZKUwOTJNAWMejK0tZfkTWBkVu1kX3sJcUUTBx o3IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683258; x=1730288058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pgb6ox3Ya7i122uZlocXrETTS1VOKhPW7bSAndX3jjQ=; b=veNngdlABj0m+DJBcvo591GQEooBZH+cCiELYIUFIaivAl8df2xYCFmCCS5eBz73VD 6EZdOu8RIylUog+yBuyRWlphUQJ/0KJH38HNEm0biZfF4CIS+b4KSW6k+kEwZl17oXYW CDVUesnMNaAwmbUYD2gBjifYwWsGXTiLNzubEWdzLfDEAxNDyU/1goPCRNyZmE9e1BBN 7Bq5cOyTaEXckbFPEH/M+0a2NLvSiM75hTDeuYVX4tlVgFWW3irHst5VujScEnVFW1/E Bi4MjmnWbsmY5hat2oFz8u4dq9CsfhnQ5T7ZSw1/AH0+1GpD5iyZhJZHeMSOdSRCHD/n cZ3A== X-Gm-Message-State: AOJu0YxKAiLFnlqbCc9TFLDyziYYtaq3tdQGSKyaRhbuUJ4F65gpoxKz Bxg8mq3Z+SXgLEnlfU1cGeGqJt/vrU2hNhZtDhxOSB3hg6GF30IVh0eisz+ankA= X-Received: by 2002:a17:907:724b:b0:a9a:49a8:f1fa with SMTP id a640c23a62f3a-a9abf8933f0mr220298266b.23.1729683258240; Wed, 23 Oct 2024 04:34:18 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a912ee0f5sm463385166b.66.2024.10.23.04.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:34:16 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 5288E5FBDC; Wed, 23 Oct 2024 12:34:08 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , Gustavo Romero Subject: [PATCH v3 14/18] tests/tcg/aarch64: Use raw strings for regexes in test-mte.py Date: Wed, 23 Oct 2024 12:34:02 +0100 Message-Id: <20241023113406.1284676-15-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Gustavo Romero Use Python's raw string notation instead of string literals for regex so it's not necessary to double backslashes when regex special forms are used. Raw notation is preferred for regex and easier to read. Signed-off-by: Gustavo Romero Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20241015140806.385449-1-gustavo.romero@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/aarch64/gdbstub/test-mte.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/aarch64/gdbstub/test-mte.py b/tests/tcg/aarch64/gdbstub/test-mte.py index a4cae6caa0..9ad98e7a54 100644 --- a/tests/tcg/aarch64/gdbstub/test-mte.py +++ b/tests/tcg/aarch64/gdbstub/test-mte.py @@ -23,8 +23,8 @@ from test_gdbstub import arg_parser, main, report -PATTERN_0 = "Memory tags for address 0x[0-9a-f]+ match \\(0x[0-9a-f]+\\)." -PATTERN_1 = ".*(0x[0-9a-f]+)" +PATTERN_0 = r"Memory tags for address 0x[0-9a-f]+ match \(0x[0-9a-f]+\)." +PATTERN_1 = r".*(0x[0-9a-f]+)" def run_test(): From patchwork Wed Oct 23 11:34:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 837816 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1f12:b0:37d:45d0:187 with SMTP id hh18csp409518wrb; Wed, 23 Oct 2024 04:45:17 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW9SYgHVF9fsiJeKbyoSRm7SkHg6gzTe4o/xaiAp93RA14tbNj9EaGoFPTGs0fEV+EabWt+aA==@linaro.org X-Google-Smtp-Source: AGHT+IHUE214ahgiIJR5aC91+PeAqY8paKK/pmOIZ7TsSizSBATwqHULnGZcXxOiA+FeSKaqKIqS X-Received: by 2002:a05:6102:6cc:b0:4a4:9541:e384 with SMTP id ada2fe7eead31-4a751c8c92fmr2477595137.23.1729683917236; Wed, 23 Oct 2024 04:45:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729683917; cv=none; d=google.com; s=arc-20240605; b=Q4bC8zRBb0o5sH9BVBf4cevA0WW0G+Z7eMBcejZeJmjV0LML1LfwaN7nSVC3pd4Vnt OX6SyRIrL8zvT6JYUhzJMH6Tmzl0uNwYGwnAf8sMn7joS/JTeQL4yJNRM+k8PHf2MtG7 6FFi8M3pkD/gB01UtUyrcMzkFw6pmd2j22tfGu04HkWYw09sE23fgi3RtiSnbrr5PE2I brGgKBfUAs3RAmIchoh7gbgumnKoIJ9RFG366jG1eyXcjVJxVeVzxot6lQgWJ1vm/cMD O41HxY8dhmCDHkufKmRv/DNxJo6lv53SptwsRGTFLTqXniwSy/mkJvhk/2tu8tfH84rM 7k8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A1RT2huJ5JZoTziBJ4jD+CCwuEKWgio+GHjHj5uuvtc=; fh=jDher3lN9MWBdjSkb8j3t3602VJXe3Qz1zNBmICawX8=; b=gZpeR6bJNqiy27jJWzx30ufuuhJOpA270MAqlp3QjYYwWBDOQYBcw8MyNc6VlzkMil LyWFM4hOq2BujI5/4oCAhGRVlnLsyWJA/Ve9+8gGdGhYWve7I89OR07+HRxxpiTOYHVm 1Vv+gSpH1M7yjWzs7Sj4vmJvJ5hY+KwzmgfuCVwjhDrcXowQFVzYVpiuR82WWlGdgkZt Bg4OQVOBMFPwtPP3cNXI/ccxW/KEoh6ld/DsrcK1rQbRTszzWbdZUVusiNRzp7/Jq0BT XCz1ZQxtdXKFNvPdut2VY4Ya+RBMBY6bhs4o5b/cLqt221ixdtcO79naAdNmFixz2JIp Lyrw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VkKRgNFE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-460d3daaf7esi84506211cf.736.2024.10.23.04.45.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 04:45:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VkKRgNFE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3Zme-0001xG-Uh; Wed, 23 Oct 2024 07:44:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Zme-0001wZ-0q for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:44:12 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Zmb-0004ZW-KR for qemu-devel@nongnu.org; Wed, 23 Oct 2024 07:44:11 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-539f4d8ef66so9057330e87.1 for ; Wed, 23 Oct 2024 04:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729683848; x=1730288648; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A1RT2huJ5JZoTziBJ4jD+CCwuEKWgio+GHjHj5uuvtc=; b=VkKRgNFEANB5Q2uBwV1xX9rsEfKD+NihbbnZhVqJZ/ZGaCmI6A3RjAvBe9qoVrLHHM fO+eniL9C2n2OPSaZsHoq0IeWDaAnwY/b5FzFiBumsbdzGx1J70iP/ml9mR0QrRWtjJo jOVYEtSNI2IOgbRxvduQagoXJ4DQ7vIm2YFfkYZ4j/rzONroQnLYQl5QwiElCtPG1bP8 7efgTAg9rHEkThs45BzJE/Ls+bXaRY00yVpy7se8uqkW3MskVlcFTj8EfSEBL8U/oSZ8 Renet3qMicxdzwZLOym3l19yirztoulOiiZq3ow7WJwoIxP6TdZcHJ64nIeCNp1rfWa+ x8SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683848; x=1730288648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A1RT2huJ5JZoTziBJ4jD+CCwuEKWgio+GHjHj5uuvtc=; b=KlCHrK2PR0HMU7OEkx+K/gYMFC9DnxcLqka4igD6lnl+n0PsCLVo3Lf1G4fgz/iNkg CiUmb97ZzBviMDfnCiY5XFKvTes1piIrroUFcIdMZ0mm2cTAZyS3GtwG0ldu+mndVtah L1cCvLtXUso/BVhn1KXTileRoR3LBA6swm1lJ6pvta2Z2wOH6xp7lO1dbtanXQdi60Qs FoV6n9VRB/o9Urf7/7en4gJNxVJP4ezUXgRv64YiFDG4L6dmTQYRQJu1HHjvLQT3K1L5 2zVM1u6sAR8JLxY9HLiRV9WVRMwdrueHmYAX5MEQSqpAHetk+L5PcKodnNCwrv/u4cbF rNmw== X-Gm-Message-State: AOJu0YwqjI7WSmiwUs+GFh/oS2irPeMt/IfNAdyC1y7CmbFpvAd8nJDu kmt+krbKMO0eA8/I0rHQgVMbsLNOSWFxTe2dti7S4zF8C81OoPfftowFS8t5jVI= X-Received: by 2002:a05:6512:3b87:b0:539:e873:6e2 with SMTP id 2adb3069b0e04-53b1a31d89dmr1220513e87.8.1729683846016; Wed, 23 Oct 2024 04:44:06 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a6d798sm4478915a12.50.2024.10.23.04.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 04:44:04 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 9B1C55FC19; Wed, 23 Oct 2024 12:34:08 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Eduardo Habkost , Pierrick Bouvier , Peter Maydell , Yanan Wang , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, Marcelo Tosatti , Riku Voipio , Wainer dos Santos Moschetta , Marcel Apfelbaum , Paolo Bonzini , Mahmoud Mandour , Laurent Vivier , Jiaxun Yang , "Edgar E. Iglesias" , Richard Henderson , Alexandre Iooss , qemu-arm@nongnu.org, =?utf-8?q?Daniel_?= =?utf-8?q?P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Cleber Rosa , kvm@vger.kernel.org, Beraldo Leal , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 17/18] contrib/plugins: remove Makefile for contrib/plugins Date: Wed, 23 Oct 2024 12:34:05 +0100 Message-Id: <20241023113406.1284676-18-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023113406.1284676-1-alex.bennee@linaro.org> References: <20241023113406.1284676-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x129.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier Now replaced by meson build. Signed-off-by: Pierrick Bouvier Message-Id: <20240925204845.390689-3-pierrick.bouvier@linaro.org> Signed-off-by: Alex Bennée --- configure | 18 --------- Makefile | 10 ----- contrib/plugins/Makefile | 87 ---------------------------------------- 3 files changed, 115 deletions(-) delete mode 100644 contrib/plugins/Makefile diff --git a/configure b/configure index 7dd3400ccb..101ca9ace9 100755 --- a/configure +++ b/configure @@ -1073,7 +1073,6 @@ if test "$plugins" != "no" && test $host_bits -eq 64; then plugins="no" else plugins=yes - subdirs="$subdirs contrib/plugins" fi fi @@ -1704,7 +1703,6 @@ LINKS="$LINKS .gdbinit scripts" # scripts needed by relative path in .gdbinit LINKS="$LINKS tests/avocado tests/data" LINKS="$LINKS tests/qemu-iotests/check tests/qemu-iotests/Makefile" LINKS="$LINKS python" -LINKS="$LINKS contrib/plugins/Makefile " for f in $LINKS ; do if [ -e "$source_path/$f" ]; then symlink "$source_path/$f" "$f" @@ -1790,22 +1788,6 @@ if test "$default_targets" = "yes"; then echo "CONFIG_DEFAULT_TARGETS=y" >> $config_host_mak fi -# contrib/plugins configuration -echo "# Automatically generated by configure - do not modify" > contrib/plugins/$config_host_mak -echo "SRC_PATH=$source_path/contrib/plugins" >> contrib/plugins/$config_host_mak -echo "PKG_CONFIG=${pkg_config}" >> contrib/plugins/$config_host_mak -echo "CC=$cc $CPU_CFLAGS" >> contrib/plugins/$config_host_mak -echo "CFLAGS=${CFLAGS-$default_cflags} $EXTRA_CFLAGS" >> contrib/plugins/$config_host_mak -if test "$host_os" = windows; then - echo "DLLTOOL=$dlltool" >> contrib/plugins/$config_host_mak -fi -if test "$host_os" = darwin; then - echo "CONFIG_DARWIN=y" >> contrib/plugins/$config_host_mak -fi -if test "$host_os" = windows; then - echo "CONFIG_WIN32=y" >> contrib/plugins/$config_host_mak -fi - # tests/tcg configuration mkdir -p tests/tcg echo "# Automatically generated by configure - do not modify" > tests/tcg/$config_host_mak diff --git a/Makefile b/Makefile index 917c9a34d1..b65b0bd41a 100644 --- a/Makefile +++ b/Makefile @@ -187,11 +187,6 @@ SUBDIR_RULES=$(foreach t, all clean distclean, $(addsuffix /$(t), $(SUBDIRS))) $(SUBDIR_RULES): $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" $(notdir $@),) -ifneq ($(filter contrib/plugins, $(SUBDIRS)),) -.PHONY: plugins -plugins: contrib/plugins/all -endif - .PHONY: recurse-all recurse-clean recurse-all: $(addsuffix /all, $(SUBDIRS)) recurse-clean: $(addsuffix /clean, $(SUBDIRS)) @@ -307,11 +302,6 @@ help: $(call print-help,cscope,Generate cscope index) $(call print-help,sparse,Run sparse on the QEMU source) @echo '' -ifneq ($(filter contrib/plugins, $(SUBDIRS)),) - @echo 'Plugin targets:' - $(call print-help,plugins,Build the example TCG plugins) - @echo '' -endif @echo 'Cleaning targets:' $(call print-help,clean,Remove most generated files but keep the config) $(call print-help,distclean,Remove all generated files) diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile deleted file mode 100644 index bbddd4800f..0000000000 --- a/contrib/plugins/Makefile +++ /dev/null @@ -1,87 +0,0 @@ -# -*- Mode: makefile -*- -# -# This Makefile example is fairly independent from the main makefile -# so users can take and adapt it for their build. We only really -# include config-host.mak so we don't have to repeat probing for -# programs that the main configure has already done for us. -# - -include config-host.mak - -TOP_SRC_PATH = $(SRC_PATH)/../.. - -VPATH += $(SRC_PATH) - -NAMES := -NAMES += bbv -NAMES += execlog -NAMES += hotblocks -NAMES += hotpages -NAMES += howvec - -# The lockstep example communicates using unix sockets, -# and can't be easily made to work on windows. -ifneq ($(CONFIG_WIN32),y) -NAMES += lockstep -endif - -NAMES += hwprofile -NAMES += cache -NAMES += drcov -NAMES += ips -NAMES += stoptrigger -NAMES += cflow - -ifeq ($(CONFIG_WIN32),y) -SO_SUFFIX := .dll -LDLIBS += $(shell $(PKG_CONFIG) --libs glib-2.0) -else -SO_SUFFIX := .so -endif - -SONAMES := $(addsuffix $(SO_SUFFIX),$(addprefix lib,$(NAMES))) - -# The main QEMU uses Glib extensively so it is perfectly fine to use it -# in plugins (which many example do). -PLUGIN_CFLAGS := $(shell $(PKG_CONFIG) --cflags glib-2.0) -PLUGIN_CFLAGS += -fPIC -Wall -PLUGIN_CFLAGS += -I$(TOP_SRC_PATH)/include/qemu - -# Helper that honours V=1 so we get some output when compiling -quiet-@ = $(if $(V),,@$(if $1,printf " %-7s %s\n" "$(strip $1)" "$(strip $2)" && )) -quiet-command = $(call quiet-@,$2,$3)$1 - -# for including , in command strings -COMMA := , - -all: $(SONAMES) - -%.o: %.c - $(call quiet-command, \ - $(CC) $(CFLAGS) $(PLUGIN_CFLAGS) -c -o $@ $<, \ - BUILD, plugin $@) - -ifeq ($(CONFIG_WIN32),y) -lib%$(SO_SUFFIX): %.o win32_linker.o ../../plugins/libqemu_plugin_api.a - $(call quiet-command, \ - $(CC) -shared -o $@ $^ $(LDLIBS), \ - LINK, plugin $@) -else ifeq ($(CONFIG_DARWIN),y) -lib%$(SO_SUFFIX): %.o - $(call quiet-command, \ - $(CC) -bundle -Wl$(COMMA)-undefined$(COMMA)dynamic_lookup -o $@ $^ $(LDLIBS), \ - LINK, plugin $@) -else -lib%$(SO_SUFFIX): %.o - $(call quiet-command, \ - $(CC) -shared -o $@ $^ $(LDLIBS), \ - LINK, plugin $@) -endif - - -clean distclean: - rm -f *.o *$(SO_SUFFIX) *.d - rm -Rf .libs - -.PHONY: all clean -.SECONDARY: